From nobody Sun Sep 28 16:35:28 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1756568814; cv=none; d=zohomail.com; s=zohoarc; b=KyP6bPfDXLoc6pzZuZgwti01lWNxddMjr9Ei4NEdDW9QvAujGZPpsJwx8AiNZkgQJ6Mo+ENyC5EQLROk0Qdt9V9O6o3d+0pCutxpBIG+xOkVhfRjTNPztGuO52dqsuZtd7WpJINGNaKJmONB/xUVC7bsnTfTPaAncnJj4ZZpFhI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756568814; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=0cSYtWQY+sl2psNrjqMwDQ/CGi50FF+HBZzJGLsoQhg=; b=KgdisfOje+5BRqHTNfrRMxFZKgdhRJVGuI9fXrZ761PhUefpsR4FgVkWnFvopVXyzlD1FWAKtkqXUtqNxTKLOud/996Ct97sIJ8y0eUsie50eQG0tsBobk5bz/7UDpt61rTPKemr4iBFDq8VvX2YGiHz6uk9/ylakIuB9FbTx2o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756568814244180.11349951432828; Sat, 30 Aug 2025 08:46:54 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1usNEs-0004em-3K; Sat, 30 Aug 2025 11:11:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1urwy7-0008SJ-Kn for qemu-devel@nongnu.org; Fri, 29 Aug 2025 07:08:31 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1urwy4-0001gp-RY for qemu-devel@nongnu.org; Fri, 29 Aug 2025 07:08:31 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-93-b2eaxCJEMke8sOfXm0XjsQ-1; Fri, 29 Aug 2025 07:08:23 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9F6D51800345; Fri, 29 Aug 2025 11:08:22 +0000 (UTC) Received: from srv1.redhat.com (unknown [10.45.225.62]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1635430001B5; Fri, 29 Aug 2025 11:08:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756465707; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0cSYtWQY+sl2psNrjqMwDQ/CGi50FF+HBZzJGLsoQhg=; b=WfGH1xMfucWGLGxsakA9AaGhb5gDFLiGezaoiATeDT426kVqbGXOYYIIucjec1u3Lg6/PF AzrS9qRqnXKam8N+0JLA33RNZ/as+vaxjom1h7U9eM0dBDUJLLBeuhl+2jL84ZBGqozyrO hLuQBb2qyLqUfNyxBXtd+WfraobCGGE= X-MC-Unique: b2eaxCJEMke8sOfXm0XjsQ-1 X-Mimecast-MFC-AGG-ID: b2eaxCJEMke8sOfXm0XjsQ_1756465702 From: Kostiantyn Kostiuk To: qemu-devel@nongnu.org, Peter Maydell , Richard Henderson , Stefan Hajnoczi Subject: [PULL 2/9] qga: fix potentially not initialized nr_volumes in qga_vss_fsfreeze() Date: Fri, 29 Aug 2025 14:08:06 +0300 Message-ID: <20250829110813.50286-3-kkostiuk@redhat.com> In-Reply-To: <20250829110813.50286-1-kkostiuk@redhat.com> References: <20250829110813.50286-1-kkostiuk@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=kkostiuk@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1756568816647124100 Content-Type: text/plain; charset="utf-8" From: "Denis V. Lunev via" In this function we could have this variable not initialized. If this could be acceptable on error, the variable could be left not initialized f.e. as follows: void requester_freeze(int *num_vols, void *mountpoints, ErrorSet *errset) { ... if (mountpoints) { ... if (num_mount_points =3D=3D 0) { /* If there is no valid mount points, just exit. */ goto out; } } ... if (!mountpoints) { ... if (num_fixed_drives =3D=3D 0) { goto out; /* If there is no fixed drive, just exit. */ } } ... } Stay on safe side, initialize the variable at the beginning. Signed-off-by: Denis V. Lunev CC: Kostiantyn Kostiuk CC: Michael Roth Reviewed-by: Kostiantyn Kostiuk Link: https://lore.kernel.org/qemu-devel/20250807133221.1135453-1-den@openv= z.org Signed-off-by: Kostiantyn Kostiuk --- qga/vss-win32.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qga/vss-win32.c b/qga/vss-win32.c index f444a25a70..b272bfc782 100644 --- a/qga/vss-win32.c +++ b/qga/vss-win32.c @@ -157,6 +157,8 @@ void qga_vss_fsfreeze(int *nr_volume, bool freeze, .errp =3D errp, }; =20 + *nr_volume =3D 0; + g_assert(errp); /* requester.cpp requires it */ func =3D (QGAVSSRequesterFunc)GetProcAddress(provider_lib, func_name); if (!func) { --=20 2.50.1