From nobody Sun Sep 28 16:34:17 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1756401714; cv=none; d=zohomail.com; s=zohoarc; b=YNbo5owyzF+DGQs/tKQ1Mm4vZdxxSB+ps1BYtfIotsl7tR73OLWzKOCUZrmro+swlnZD8LvQ14JCyGsqSu/IE5SWl0morM4Gc0vYXB//J59MkofzWi9NixS713GlraRuhXmh+bb7nubN7fVAAsuHaSmQLnp+2vgB0PwmmIzKNhk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756401714; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=fugM9PHy2tclelvvYQOdAG0IRRSDsWvkqc8Uh7CBDc8=; b=hp06/VTn8jWjBDpxWhwLyv/M42iOmMakLtsb8ZQhXz18HsRliwTIYzEBX0W/W1Zzu5aKHwmH1gQTxhJirwiPCWL5/bdOBLbs9lx99ccVrTb5KuTFJnbwjaoLd1x4tAq/OZ8NZertrF05FB7ik0RLCITMZ84bpFhMhjZjPjTPco8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756401714209331.1305731352137; Thu, 28 Aug 2025 10:21:54 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1urgBS-0002Tg-2g; Thu, 28 Aug 2025 13:13:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1urdEz-0003r3-5q for qemu-devel@nongnu.org; Thu, 28 Aug 2025 10:04:37 -0400 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1urdEu-0002th-9V for qemu-devel@nongnu.org; Thu, 28 Aug 2025 10:04:36 -0400 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-3c84925055aso764522f8f.2 for ; Thu, 28 Aug 2025 07:04:31 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3cce1724939sm6947712f8f.26.2025.08.28.07.04.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Aug 2025 07:04:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1756389870; x=1756994670; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=fugM9PHy2tclelvvYQOdAG0IRRSDsWvkqc8Uh7CBDc8=; b=FOqhcx57qaHpJWU+CGihKfigV+0CRpG4ItIIja2nJjLAVfFz1tc5AoQ79hwdxpL4jy FBievLgySGCuPBcB6FEyvS7KxDtuLAzmAoLvyuqJBNt5rI4+6TY4/0Ow7TB9mTJUq7/L UjaAtXG8S+0cSp9BYi8BmSR/JHSmkGxcqicZrPGwfXnM+kM5N97Dld3GleZWNJCkmMkQ GXrHaKxWsiG/+uxloyNLoO0kayvEVkIveb8Iji5zYT7eAISOK30nq2DWv59GGAzSvXG1 9FRU0upEGDNRHgK1Hwje/fsYJ2gQDEVvYtKsH/M39TAUBsaZBXRCZSQz8lOU6E4+NwpI iUXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756389870; x=1756994670; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fugM9PHy2tclelvvYQOdAG0IRRSDsWvkqc8Uh7CBDc8=; b=mggHkOJ8iXUQeNJllRUZ0dL3u9wIyzs63m1czci2qH7yOzuUs9AT4JWWQ1Sl/2yF8s Hy0CcOL3nz9X/KpLGVRix018Pvos7U7VQtBfxLmwcXD0d/IKO6o5bx94MgrWkt6/yp5g /2U8twzZ96uKvDzVkb1kHMelui3N9MSaNTiem0BzCTfVOzM2ZM4sZyVNQl+UotZ71y9V bGE1H1sUwNcvTxMEFQUDzVZznnQsdxrTneGwIXggKzuZxgE2kq8OiiShZaecEq6rlnbk xboz8eCqD0TCb7tFKPhl+8ZUAtAn56zvhOpqeKaaiarsrrkGfxBJtzZ1QDPOTfvAviKL A+sw== X-Forwarded-Encrypted: i=1; AJvYcCVNaVWmi/L6vcTEnLpCQdadCJJcVPpyeF1SP57lyFJgTWJWf7TlN9vIbz3k9SUvsx5hudbhnmGUyvm7@nongnu.org X-Gm-Message-State: AOJu0Yy26SYpEFLt++tkNImUraK2sw1uHkw52Fwfi0BVSSgZ7VSNPnBB wLRpyePlByW2aHkZRXLlGRXb/spMoYGTZZobWyMS9KUIBhMe/q2nMkdj/RO+ByYa/CM= X-Gm-Gg: ASbGncvcvaxYy9f68JKVAQdi1f6l2M1IhR6/Y/vj5Zo1S4hRRM4s7OO/TU2PvjYOtzv TgsXR2qgcZ6ayt/Tx2gtTa7hsLEfbv0sKErRa2/TbzNdtVRBb8OKf/KIHT47lPLvpwrBE6QD3u+ xS+tXwtK7OHxiGFLjYyOd+bAfVWF89SQ12q0/W2pE0U0p8DtnVOBR+CVcDiVG6R3htfcfo0KTba qBlCKAfzNVm3FLpiKYy6FVIIiOMpY0WzckE7f9FdaiCLw9ixIXRpjgoPQb0IlDiz2j+jBkDMWk4 Ypp0DeKj8R8WYWZEX0SsFrlZx7XZ4rGgMUha8jYfNGZbXMZ3VK6rAb1UpsqMtoMIh4XNdtZeAPv CGkJwiub8GzJG5Lw/7GbUNzSk2TqkijJOvARxJJM= X-Google-Smtp-Source: AGHT+IH7E+ywXeCVND5fc2Q87QhfOnCVshrj6Px4I2XmLpRupFCVcId7dN352tcHgOZud6lAKghT2g== X-Received: by 2002:a5d:4392:0:b0:3cc:3d4b:7fb1 with SMTP id ffacd0b85a97d-3cc3d4b813emr4256767f8f.49.1756389870134; Thu, 28 Aug 2025 07:04:30 -0700 (PDT) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH 4/5] target/arm: Drop ARM_FEATURE_XSCALE handling Date: Thu, 28 Aug 2025 15:04:21 +0100 Message-ID: <20250828140422.3271703-5-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250828140422.3271703-1-peter.maydell@linaro.org> References: <20250828140422.3271703-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1756401716259116600 Content-Type: text/plain; charset="utf-8" We have now removed all the CPU types which had the Intel XScale extensions indicated via ARM_FEATURE_XSCALE, so this feature bit is never set. Remove all the code that can only be reached when using this flag. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- target/arm/cpu.h | 3 --- target/arm/cpu.c | 13 --------- target/arm/helper.c | 54 -------------------------------------- target/arm/ptw.c | 7 +++-- target/arm/tcg/op_helper.c | 6 ----- 5 files changed, 3 insertions(+), 80 deletions(-) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index d6e8e99f191..0cfe23c1238 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -340,7 +340,6 @@ typedef struct CPUArchState { uint64_t vsctlr; /* Virtualization System control register. */ uint64_t cpacr_el1; /* Architectural feature access control regist= er */ uint64_t cptr_el[4]; /* ARMv8 feature trap registers */ - uint32_t c1_xscaleauxcr; /* XScale auxiliary control register. */ uint64_t sder; /* Secure debug enable register. */ uint32_t nsacr; /* Non-secure access control register. */ union { /* MMU translation table base 0. */ @@ -511,7 +510,6 @@ typedef struct CPUArchState { uint64_t cntvoff_el2; /* Counter Virtual Offset register */ uint64_t cntpoff_el2; /* Counter Physical Offset register */ ARMGenericTimer c14_timer[NUM_GTIMERS]; - uint32_t c15_cpar; /* XScale Coprocessor Access Register */ uint32_t c15_ticonfig; /* TI925T configuration byte. */ uint32_t c15_i_max; /* Maximum D-cache dirty line index. */ uint32_t c15_i_min; /* Minimum D-cache dirty line index. */ @@ -2427,7 +2425,6 @@ QEMU_BUILD_BUG_ON(ARRAY_SIZE(((ARMCPU *)0)->ccsidr) <= =3D R_V7M_CSSELR_INDEX_MASK); */ enum arm_features { ARM_FEATURE_AUXCR, /* ARM1026 Auxiliary control register. */ - ARM_FEATURE_XSCALE, /* Intel XScale extensions. */ ARM_FEATURE_IWMMXT, /* Intel iwMMXt extension. */ ARM_FEATURE_V6, ARM_FEATURE_V6K, diff --git a/target/arm/cpu.c b/target/arm/cpu.c index e2b2337399c..ad39b216a44 100644 --- a/target/arm/cpu.c +++ b/target/arm/cpu.c @@ -349,11 +349,6 @@ static void arm_cpu_reset_hold(Object *obj, ResetType = type) env->uncached_cpsr =3D ARM_CPU_MODE_USR; /* For user mode we must enable access to coprocessors */ env->vfp.xregs[ARM_VFP_FPEXC] =3D 1 << 30; - if (arm_feature(env, ARM_FEATURE_IWMMXT)) { - env->cp15.c15_cpar =3D 3; - } else if (arm_feature(env, ARM_FEATURE_XSCALE)) { - env->cp15.c15_cpar =3D 1; - } #else =20 /* @@ -2253,14 +2248,6 @@ static void arm_cpu_realizefn(DeviceState *dev, Erro= r **errp) } =20 =20 - /* - * We rely on no XScale CPU having VFP so we can use the same bits in = the - * TB flags field for VECSTRIDE and XSCALE_CPAR. - */ - assert(arm_feature(env, ARM_FEATURE_AARCH64) || - !cpu_isar_feature(aa32_vfp_simd, cpu) || - !arm_feature(env, ARM_FEATURE_XSCALE)); - #ifndef CONFIG_USER_ONLY { int pagebits; diff --git a/target/arm/helper.c b/target/arm/helper.c index 0c1299ff841..746eb1d51ef 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -2917,39 +2917,6 @@ static const ARMCPRegInfo omap_cp_reginfo[] =3D { .type =3D ARM_CP_CONST | ARM_CP_OVERRIDE, .resetvalue =3D 0 }, }; =20 -static void xscale_cpar_write(CPUARMState *env, const ARMCPRegInfo *ri, - uint64_t value) -{ - env->cp15.c15_cpar =3D value & 0x3fff; -} - -static const ARMCPRegInfo xscale_cp_reginfo[] =3D { - { .name =3D "XSCALE_CPAR", - .cp =3D 15, .crn =3D 15, .crm =3D 1, .opc1 =3D 0, .opc2 =3D 0, .acce= ss =3D PL1_RW, - .fieldoffset =3D offsetof(CPUARMState, cp15.c15_cpar), .resetvalue = =3D 0, - .writefn =3D xscale_cpar_write, }, - { .name =3D "XSCALE_AUXCR", - .cp =3D 15, .crn =3D 1, .crm =3D 0, .opc1 =3D 0, .opc2 =3D 1, .acces= s =3D PL1_RW, - .fieldoffset =3D offsetof(CPUARMState, cp15.c1_xscaleauxcr), - .resetvalue =3D 0, }, - /* - * XScale specific cache-lockdown: since we have no cache we NOP these - * and hope the guest does not really rely on cache behaviour. - */ - { .name =3D "XSCALE_LOCK_ICACHE_LINE", - .cp =3D 15, .opc1 =3D 0, .crn =3D 9, .crm =3D 1, .opc2 =3D 0, - .access =3D PL1_W, .type =3D ARM_CP_NOP }, - { .name =3D "XSCALE_UNLOCK_ICACHE", - .cp =3D 15, .opc1 =3D 0, .crn =3D 9, .crm =3D 1, .opc2 =3D 1, - .access =3D PL1_W, .type =3D ARM_CP_NOP }, - { .name =3D "XSCALE_DCACHE_LOCK", - .cp =3D 15, .opc1 =3D 0, .crn =3D 9, .crm =3D 2, .opc2 =3D 0, - .access =3D PL1_RW, .type =3D ARM_CP_NOP }, - { .name =3D "XSCALE_UNLOCK_DCACHE", - .cp =3D 15, .opc1 =3D 0, .crn =3D 9, .crm =3D 2, .opc2 =3D 1, - .access =3D PL1_W, .type =3D ARM_CP_NOP }, -}; - static const ARMCPRegInfo dummy_c15_cp_reginfo[] =3D { /* * RAZ/WI the whole crn=3D15 space, when we don't have a more specific @@ -3340,16 +3307,6 @@ static void sctlr_write(CPUARMState *env, const ARMC= PRegInfo *ri, =20 /* This may enable/disable the MMU, so do a TLB flush. */ tlb_flush(CPU(cpu)); - - if (tcg_enabled() && ri->type & ARM_CP_SUPPRESS_TB_END) { - /* - * Normally we would always end the TB on an SCTLR write; see the - * comment in ARMCPRegInfo sctlr initialization below for why Xsca= le - * is special. Setting ARM_CP_SUPPRESS_TB_END also stops the rebu= ild - * of hflags from the translator, so do it here. - */ - arm_rebuild_hflags(env); - } } =20 static void mdcr_el3_write(CPUARMState *env, const ARMCPRegInfo *ri, @@ -6753,9 +6710,6 @@ void register_cp_regs_for_features(ARMCPU *cpu) if (arm_feature(env, ARM_FEATURE_STRONGARM)) { define_arm_cp_regs(cpu, strongarm_cp_reginfo); } - if (arm_feature(env, ARM_FEATURE_XSCALE)) { - define_arm_cp_regs(cpu, xscale_cp_reginfo); - } if (arm_feature(env, ARM_FEATURE_DUMMY_C15_REGS)) { define_arm_cp_regs(cpu, dummy_c15_cp_reginfo); } @@ -7104,14 +7058,6 @@ void register_cp_regs_for_features(ARMCPU *cpu) .writefn =3D sctlr_write, .resetvalue =3D cpu->reset_sctlr, .raw_writefn =3D raw_write, }; - if (arm_feature(env, ARM_FEATURE_XSCALE)) { - /* - * Normally we would always end the TB on an SCTLR write, but = Linux - * arch/arm/mach-pxa/sleep.S expects two instructions following - * an MMU enable to execute from cache. Imitate this behaviou= r. - */ - sctlr.type |=3D ARM_CP_SUPPRESS_TB_END; - } define_one_arm_cp_reg(cpu, &sctlr); =20 if (arm_feature(env, ARM_FEATURE_PMSA) && diff --git a/target/arm/ptw.c b/target/arm/ptw.c index 561bf2678e5..440daffff60 100644 --- a/target/arm/ptw.c +++ b/target/arm/ptw.c @@ -1061,11 +1061,10 @@ static bool get_phys_addr_v5(CPUARMState *env, S1Tr= anslate *ptw, ap =3D (desc >> (4 + ((address >> 9) & 6))) & 3; result->f.lg_page_size =3D 12; break; - case 3: /* 1k page, or ARMv6/XScale "extended small (4k) page" */ + case 3: /* 1k page, or ARMv6 "extended small (4k) page" */ if (type =3D=3D 1) { - /* ARMv6/XScale extended small page format */ - if (arm_feature(env, ARM_FEATURE_XSCALE) - || arm_feature(env, ARM_FEATURE_V6)) { + /* ARMv6 extended small page format */ + if (arm_feature(env, ARM_FEATURE_V6)) { phys_addr =3D (desc & 0xfffff000) | (address & 0xfff); result->f.lg_page_size =3D 12; } else { diff --git a/target/arm/tcg/op_helper.c b/target/arm/tcg/op_helper.c index 575e566280b..5373e0e998c 100644 --- a/target/arm/tcg/op_helper.c +++ b/target/arm/tcg/op_helper.c @@ -768,12 +768,6 @@ const void *HELPER(access_check_cp_reg)(CPUARMState *e= nv, uint32_t key, =20 assert(ri !=3D NULL); =20 - if (arm_feature(env, ARM_FEATURE_XSCALE) && ri->cp < 14 - && extract32(env->cp15.c15_cpar, ri->cp, 1) =3D=3D 0) { - res =3D CP_ACCESS_UNDEFINED; - goto fail; - } - if (ri->accessfn) { res =3D ri->accessfn(env, ri, isread); } --=20 2.43.0