From nobody Sun Sep 28 16:30:51 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1756383393; cv=none; d=zohomail.com; s=zohoarc; b=MXP9CD3Uar3OIrGlnkmZ0KEX75lf+QBnIJ8W79TFhxMGqi3o8LVGOwuCXmrwNSO8Gm6iOxKEkYAGMG5pg/ggHpI7UzUpQNe6almMGM7R2Dp4Hdk1W1bzxV53pYdT0j97tQKVaPw4cxWTA8x3w8RreINLm+9vQJUDz+rSOs5JNXI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756383393; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=2iLTU2Od33oMP9jF0MYnO7hKypI+OnHyTOWI0bio9z0=; b=XE8AL6eHySD1cFsldJp/NEs3I1Z/8RbpQc2ETNTTnJ5PhAjAJSEY9fu+NxZd0s6WfHiDwmW8+XQTbAY0z8PCCBWXl52mplIJk8JCADtJcYGpEDn4JsWzNTxu+/Thhe9wrsord/M+VzKiVCo1XEaLMlaUYqYdayMnD8Z//NrOElE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756383393620566.1093570106644; Thu, 28 Aug 2025 05:16:33 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1urbQy-00023U-Mr; Thu, 28 Aug 2025 08:08:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1urbQu-00021I-MY for qemu-devel@nongnu.org; Thu, 28 Aug 2025 08:08:48 -0400 Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1urbQs-00076h-V1 for qemu-devel@nongnu.org; Thu, 28 Aug 2025 08:08:48 -0400 Received: by mail-pj1-x102b.google.com with SMTP id 98e67ed59e1d1-32326e09f58so911051a91.2 for ; Thu, 28 Aug 2025 05:08:46 -0700 (PDT) Received: from stoup.. ([144.6.121.55]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b49cb8b4b98sm13933222a12.19.2025.08.28.05.08.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Aug 2025 05:08:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1756382925; x=1756987725; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2iLTU2Od33oMP9jF0MYnO7hKypI+OnHyTOWI0bio9z0=; b=PSYq0UfRh8umX4WxqT0p9wHEMyW7fiiFzEv23FcTo9EjJO0TLpZ0jEiStDyTKfhen8 uZRaqUeJnhGvDDqaCoAI11cc147m/c1ubTusc/AO5Tzk6wJGapRpbTkjIwCkLob38y30 dX4DO4SAyObP4xmQNRqTpo/HwWABlIZ5PFGhN0QMpzuVLwl8QcjV8f43YE0U8eVXGPKf 8NJCKuXrfQS4AnRh0xVhIe/vFz9eQLD22CRLEafVdMnINQTiwSiVoKIVCxpqAvSI/IbH ruL+UqDdU0G6TtKQOdq73gsQLmmwv6VdlStA50RWKHNLo/012ze/9hshQyyD3HHxuNKk 6o2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756382925; x=1756987725; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2iLTU2Od33oMP9jF0MYnO7hKypI+OnHyTOWI0bio9z0=; b=XM/RwlKwdGCyjThjTNpu1CuBLg9ml5K2ksyTTBK21KGW06AMeG97YGVfkpTtxzFUiL xyL5IiOf5LuTg/HzKb+tH+MUT5vnKJ1/UzXslxNAvECwtNWyYMJ8Qw9HoSPqzXSUPNB0 oUMIwrha8jD32gnEaNasqwNAvrjVJKA285wNjluTgv7bz2Y1T1bgpsntmWzXqpKnx6Nt 5Aei8TL4scrUGp/7lYdQM15U6eLnbsQ92bnhvRix74dohLINsLSVIGaGfJcBEcBAnDLI gmpakloE9NthHrVrq1mVrtl9PY35Y46xcLWw/9wagFa7M47ZMt2Vttj+iXksGJNrjkxb /qPw== X-Gm-Message-State: AOJu0YyAEOgYAqVIVIsN8xtdXkqN4hOTxEdIJhoNTHG+fFNGHSwrpKs9 3Hlfj7lZjze+bmr+/576NvIPKAKMW/CGz3beHUoEgxH3OELSq93ykhK8+XpquRjCNT6HPw4EQsJ 8J4Mg//c= X-Gm-Gg: ASbGnctyHRMGb3E0xjpfE7+qcOYh/LLthCCSR/Ep1shSx7fk3cU3qclOUkikY9Bt0K1 mF8Qxq8o3c0uemuV7W9dcyWyoJjQEM4uBfP01S28C/b043RkXKYgzROzbWB3yM/A9l1HrikTAhC k3rhou6sZQ4afzNcXFa4mWj54bA9b09NEja4d6ZFJUJ2IVVlGGUSG+rAE46BjVOovkUk30//peb fNeNE2enq9ecnmLulZ19GD1sb5uRK3TFKgK5xWFzwXilsVSH7746mr1ye9sx8Qb3NCNYXmLRhdQ nWHH3nNUNYOk35DKFv1dKhsTadnBmdpIFEJQfg1XM4dFnQtKyZudSzDlSF69TJ5sIY7CmoSgndf UCLT3ATca0c3J0wxB7b5lL7rQrw== X-Google-Smtp-Source: AGHT+IH7ghq5yEyNDPaJ2fD5WRV4we5dOZnJDV8il6kOkqZ+rshKaHfZFLihicsc4aFM/hvB6oplwg== X-Received: by 2002:a17:90b:2f47:b0:321:9628:ebf5 with SMTP id 98e67ed59e1d1-32517d1ffbcmr29080246a91.30.1756382925016; Thu, 28 Aug 2025 05:08:45 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org Subject: [PATCH v3 01/87] linux-user/x86_64: Convert target_elf_gregset_t to a struct Date: Thu, 28 Aug 2025 22:07:10 +1000 Message-ID: <20250828120836.195358-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250828120836.195358-1-richard.henderson@linaro.org> References: <20250828120836.195358-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::102b; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1756383395740116601 Content-Type: text/plain; charset="utf-8" A structure typedef may be abstract, while an array typedef cannot. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell --- linux-user/elfload.c | 60 +++++++++++++++++++++++--------------------- 1 file changed, 31 insertions(+), 29 deletions(-) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index fce4c05674..ba205c5a19 100644 --- a/linux-user/elfload.c +++ b/linux-user/elfload.c @@ -154,7 +154,9 @@ typedef abi_int target_pid_t; #define ELF_ARCH EM_X86_64 =20 #define ELF_NREG 27 -typedef target_elf_greg_t target_elf_gregset_t[ELF_NREG]; +typedef struct target_elf_gregset_t { + target_elf_greg_t regs[ELF_NREG]; +} target_elf_gregset_t; =20 /* * Note that ELF_NREG should be 29 as there should be place for @@ -163,35 +165,35 @@ typedef target_elf_greg_t target_elf_gregset_t[ELF_N= REG]; * * See linux kernel: arch/x86/include/asm/elf.h */ -static void elf_core_copy_regs(target_elf_gregset_t *regs, const CPUX86Sta= te *env) +static void elf_core_copy_regs(target_elf_gregset_t *r, const CPUX86State = *env) { - (*regs)[0] =3D tswapreg(env->regs[15]); - (*regs)[1] =3D tswapreg(env->regs[14]); - (*regs)[2] =3D tswapreg(env->regs[13]); - (*regs)[3] =3D tswapreg(env->regs[12]); - (*regs)[4] =3D tswapreg(env->regs[R_EBP]); - (*regs)[5] =3D tswapreg(env->regs[R_EBX]); - (*regs)[6] =3D tswapreg(env->regs[11]); - (*regs)[7] =3D tswapreg(env->regs[10]); - (*regs)[8] =3D tswapreg(env->regs[9]); - (*regs)[9] =3D tswapreg(env->regs[8]); - (*regs)[10] =3D tswapreg(env->regs[R_EAX]); - (*regs)[11] =3D tswapreg(env->regs[R_ECX]); - (*regs)[12] =3D tswapreg(env->regs[R_EDX]); - (*regs)[13] =3D tswapreg(env->regs[R_ESI]); - (*regs)[14] =3D tswapreg(env->regs[R_EDI]); - (*regs)[15] =3D tswapreg(get_task_state(env_cpu_const(env))->orig_ax); - (*regs)[16] =3D tswapreg(env->eip); - (*regs)[17] =3D tswapreg(env->segs[R_CS].selector & 0xffff); - (*regs)[18] =3D tswapreg(env->eflags); - (*regs)[19] =3D tswapreg(env->regs[R_ESP]); - (*regs)[20] =3D tswapreg(env->segs[R_SS].selector & 0xffff); - (*regs)[21] =3D tswapreg(env->segs[R_FS].selector & 0xffff); - (*regs)[22] =3D tswapreg(env->segs[R_GS].selector & 0xffff); - (*regs)[23] =3D tswapreg(env->segs[R_DS].selector & 0xffff); - (*regs)[24] =3D tswapreg(env->segs[R_ES].selector & 0xffff); - (*regs)[25] =3D tswapreg(env->segs[R_FS].selector & 0xffff); - (*regs)[26] =3D tswapreg(env->segs[R_GS].selector & 0xffff); + r->regs[0] =3D tswapreg(env->regs[15]); + r->regs[1] =3D tswapreg(env->regs[14]); + r->regs[2] =3D tswapreg(env->regs[13]); + r->regs[3] =3D tswapreg(env->regs[12]); + r->regs[4] =3D tswapreg(env->regs[R_EBP]); + r->regs[5] =3D tswapreg(env->regs[R_EBX]); + r->regs[6] =3D tswapreg(env->regs[11]); + r->regs[7] =3D tswapreg(env->regs[10]); + r->regs[8] =3D tswapreg(env->regs[9]); + r->regs[9] =3D tswapreg(env->regs[8]); + r->regs[10] =3D tswapreg(env->regs[R_EAX]); + r->regs[11] =3D tswapreg(env->regs[R_ECX]); + r->regs[12] =3D tswapreg(env->regs[R_EDX]); + r->regs[13] =3D tswapreg(env->regs[R_ESI]); + r->regs[14] =3D tswapreg(env->regs[R_EDI]); + r->regs[15] =3D tswapreg(get_task_state(env_cpu_const(env))->orig_ax); + r->regs[16] =3D tswapreg(env->eip); + r->regs[17] =3D tswapreg(env->segs[R_CS].selector & 0xffff); + r->regs[18] =3D tswapreg(env->eflags); + r->regs[19] =3D tswapreg(env->regs[R_ESP]); + r->regs[20] =3D tswapreg(env->segs[R_SS].selector & 0xffff); + r->regs[21] =3D tswapreg(env->segs[R_FS].selector & 0xffff); + r->regs[22] =3D tswapreg(env->segs[R_GS].selector & 0xffff); + r->regs[23] =3D tswapreg(env->segs[R_DS].selector & 0xffff); + r->regs[24] =3D tswapreg(env->segs[R_ES].selector & 0xffff); + r->regs[25] =3D tswapreg(env->segs[R_FS].selector & 0xffff); + r->regs[26] =3D tswapreg(env->segs[R_GS].selector & 0xffff); } =20 #if ULONG_MAX > UINT32_MAX --=20 2.43.0