From nobody Sun Sep 28 15:28:19 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1756379595; cv=pass; d=zohomail.com; s=zohoarc; b=Srab9XkPX7FoDniarIKmdXUHI9CFPZRF/nl3d0wl/Q8F/ri+CAN4pC0NGdHH+H4voRSvMyR0gAVejvmOo5iIDKT/H77IN1gMwoFlzMuMdBA5NSjWksT+O9lWFdRdnyFVu/ncP861qtmUt9jmgAxLA6aZ0zOR9jTh60bKfonlJhs= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756379595; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=cn5GzoaGB+CMWRd6KFx+uxroBQLEoM1HgPQQHj8Kb3Y=; b=NAvFOkHP+beCyfmch9VVOwLerbG6+RUo60EyAiu8rJPTN7qTIAwwPgOK/djMjyvf37P7AUS9WGRGTm9/Q/IMQZUJvSPB4qQYP8MY45thgaeZRjmkL0tCvdAKmJ1QgGNkKzYPLiOOSdeq8VUZnLjCWnwV+UWObWJkEcaioVcbFnM= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756379595475615.4758087153714; Thu, 28 Aug 2025 04:13:15 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uraXJ-0007ze-4g; Thu, 28 Aug 2025 07:11:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uraXD-0007vH-Oa for qemu-devel@nongnu.org; Thu, 28 Aug 2025 07:11:16 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uraXB-0004z6-C1 for qemu-devel@nongnu.org; Thu, 28 Aug 2025 07:11:15 -0400 Received: from pps.filterd (m0127844.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57S6aJVI2725983; Thu, 28 Aug 2025 04:11:09 -0700 Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11on2125.outbound.protection.outlook.com [40.107.220.125]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 48t6kjswff-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 28 Aug 2025 04:11:09 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BL3PR02MB8891.namprd02.prod.outlook.com (2603:10b6:208:3b2::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9052.20; Thu, 28 Aug 2025 11:11:03 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%3]) with mapi id 15.20.9052.019; Thu, 28 Aug 2025 11:11:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=cn5GzoaGB+CMWRd6KFx+uxroBQLEoM1HgPQQHj8Kb 3Y=; b=EfJyKIvc6daZcgJcNNnHkL2U4aHgc9fbQdBA0LrmGwGQQEbfrH2JwdOZJ CxpRajLO7Cls+aEnDa+3D7/tYXkSuFssqflbYviOjpUbrtJxi2anfxrDT1P8BjCl 9/JGMWevXeSVLDEB6Is+5Lxn8+40iR7FkbN3qotwL27I7E73dnQveo5bqkGsm+3V MPRiTckDi0b7kfWFp1nbq5bux8da7Q/IUxsAfDZE62gHg6N+XrsJap53a9LvY9hN 06KnSlD/M0sGO2pr2MO97/3H7kMr84tb8rZ1VUhG4ZLztYWZN0a7Vg0PGh00+byR sld3s1uA0VyVADR+gUefMDSKwvDcA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hQxJ2ka1U8jriZtOs7CcRY3FTHEDeKhJlX+yVtyZztugJYxcHE16nsKY/Ny/+8jKxnbb0mcZXl4o9O7bqXCYzSFx2x6K29zfV6bbtNbcDi0uVwdtvyIKguM8Snz2j88gfn67l2q8oYQqBJoAk25exEN4C/O8bPLq9E1DebvXxTZoVoZft2WUhydwRE1N+VrJn9tQ5U7rX6+DshM/AZFjd9Bo4ZGBmb1jP4VjpewMRJ/YZV/aXhtm7GtA2A9WKbcLRwXINekNHTJrg35NJBhBdC2cnkfl+HmEzcQSDf+s5dUbXiqE+07SJXsHlP3Sc+ynXbsDhDRqiWVUcbCCdsqIwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cn5GzoaGB+CMWRd6KFx+uxroBQLEoM1HgPQQHj8Kb3Y=; b=O8vyg5FM5evZ/2yJuOIz8EqNeyA1RbyHEjWJPiqJgtqYjkMpG4qnDNtsdMozEd9TzpGULWjiJq5DMc4Rb3L9xdMirhZiDnbJKK5IkGm8tCz+SJrR1/651HKcWL8tDPHrA/KOmZBw3/eCotziwvsRd/KG6P0CuH5D7Zl6Ec98RpQjLGTyJiPA8thAEX9Wfci1U8pU6dOdURj2wSAGwHLiA0tAwcI7A/A9kuTIL52PFfjrpSHQbgcae9XXLHTeakHclOTjsw7ZDNHjQdDld39zXr6mjHqDqDaxonND7YceD/oDrPE0UsM8gY88GUwK7IDygKJSyOIfvnBAaD70VtbTpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cn5GzoaGB+CMWRd6KFx+uxroBQLEoM1HgPQQHj8Kb3Y=; b=RO4/zvIZ691VMp5XVSPshL/DOk/9/SzT+K4qmGIdbZ+bTpBlyioicCaezvO3k4PM/7xojFcjCQn8OCkKA06rR9JhM+t+Qcsx+0Zu/PhEntY9jDX27gLm/Hi0Ht5xLG9nWxSfNmlZ4IWt1eRSYrQIXwxRnibUCo8u5ZMfing17PX9FJofshNYUZfuytGZXT1ulDg4JpPcmA5M06CKsNznlFkmXIThAOzfTQgPgKWcLDdXWmaQzSKfxck5sEi34CL7fqSC6xCmZgq+sI9rD15dhA44LlrdlTDq8otR4A13Z9VBikaeN3aQBX3BXBys/woj2GH6Dwq1DT6pzHkU9suq3A== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v7 01/19] hw/i386/pc_piix.c: restrict isapc machine to 32-bit CPUs Date: Thu, 28 Aug 2025 12:09:44 +0100 Message-ID: <20250828111057.468712-2-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250828111057.468712-1-mark.caveayland@nutanix.com> References: <20250828111057.468712-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM9P193CA0028.EURP193.PROD.OUTLOOK.COM (2603:10a6:20b:21e::33) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BL3PR02MB8891:EE_ X-MS-Office365-Filtering-Correlation-Id: 9dac7b57-6f9c-487c-8b3e-08dde623939a x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|10070799003|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?T0dxVWpETGpmQTIxaEJieXU1Mzdsc1JMUWVadGpab0syY1RNUytHVmlWNXhl?= =?utf-8?B?WGJpMjBoQ3ZzbmFGUTRCTTgyNEpwdWdFNERkNXFrT0plWGNLRUduZDBQOUU3?= =?utf-8?B?R283L2l6OStsUVZCODFrQmFjTHVudUZkSnlhSnpCQ0N0OGdQb3BNVE9DRWZO?= =?utf-8?B?ZXNuNGFTK2VXdy9tbGdRWnUxK28rV1pMUWtqUzcwYTRiZm5UeEJ4Wlc0MFcz?= =?utf-8?B?N3B4aENRRDFXSUN2YWRxMDJiNy92Q1dJdUoxRWdha3ZTcmIwQTQ2QnUycG4x?= =?utf-8?B?YlRLclNTY1hWWFpXMkFOK2xZTTE3MCtVT2UrTHlGTHZQalNZUUs0L0dReUFx?= =?utf-8?B?UWR0T2pLbE45OGMrVzcrMnN4OFQ5THNLL0N0YjFJVitVVFBXMzFxMVdIRWwx?= =?utf-8?B?RFI0TWdnMTR2Z1IvSVVPcUZqUUZaenV6bk5ubHQ0NG1CVWM5RFQ5SGpBMTBw?= =?utf-8?B?SXJ5ZGlZMC9ONlVOTTNOM1hpRXBDVlFuOGJ6Qm9LcEFPbFRXTWJQbGZGWHhE?= =?utf-8?B?MnZ2b0t3RnpEMExmYmkyNEp5VmJ2MnZ1c29Nd0NlbmRZL3RKa204RzRrRVA4?= =?utf-8?B?NFBIZ0V4Z2VUUkZOYUUxN0hzZi9lbFZlK3MxT0FHWHlCQnZRNkY0S3RuUHVs?= =?utf-8?B?UVlsVVdxNGNjR2d1aFcyeVJKaDhLNFErL1RVZkF2emdNTWRDYUo4djlkK256?= =?utf-8?B?REVnRlRiblNWZ0ZyVkJxVXJ1YW5rZEpLNVRnM1ZkbVZIZ1ZEN2ZOQUw5U0lv?= =?utf-8?B?cU51bGUvcUlrRHNKYnZ5RU5KRzlJajczYmV0VE4rbUU4VU5SMk5wdk1Mankz?= =?utf-8?B?UElwOWZUcTA5bVBpU1B0dnFhWjlIRTEzQ1RPVUNZa2I2ODA1blduVjFlREkv?= =?utf-8?B?dmovT1daVE10dk5rNUJZUUl5R3BDQTdZMUsrbEhHeHZDcVRaT0FvU0N6Sm9Z?= =?utf-8?B?bFg1VTF3UUV5bC9mMUVKK2RKc2JZNGUvYmdwU1NUV0FqbmFPUlUxN1JOVUlV?= =?utf-8?B?eHV4ZFQ5UXBmTVFiT3liQmM1RmZKdE52TlJlZVNxZGwvWTBMWGdSS1kxbE5j?= =?utf-8?B?bStmL2hVYU5Cb1lzdXlpTlBnTjl5c3BNZnY0SklvU29GT3ppMkNlUFBLa0RQ?= =?utf-8?B?c2x6OWRpTnNSZUpsK1BZelhZWVhpVnZiZlNsVEc3TTNpNmg3TDM4UjArWG5B?= =?utf-8?B?aVBzcUw5ZmYvenlQV2l4THdMWFJ0NXNMZXBpcU5mY3ErNHBUYmpBNmwvSVQ0?= =?utf-8?B?czlEd0R3UUpaWWRtVm9laURUM3VhbFluR2lmK0pxMU5RcXV1N3F4NERmYUZW?= =?utf-8?B?ZW12am9HMG5MMGJPaTVUZnJIRVBGenU0YkhqZnlCNnhFM3hNUFptV0dBWWVm?= =?utf-8?B?ZXQ0RDdGeFJpVGx3eUxiM2JlQ1Z1dUZJYlZNV1YySVR4dUwzWUZ4Ull5NG1Q?= =?utf-8?B?Z1RFd2lpS1VHV2Z2azBTLzl4UWRaS29oblNHNUxCS0tNeUE3S2VzdUE0VXpx?= =?utf-8?B?YkR5RDNqVFg5cTY2OXdaMSt3clZlY1NZNCtjSVJUTTJaampjc0VQcWppYUVK?= =?utf-8?B?OUM0Qkc0U0tGSXVRWEs5SUNWSzZBREladzF2Nnd0MGFrNWc1UGcrVVpxeXFh?= =?utf-8?B?cXRMZUk3QnJLRDZyVkw4N25ZT3J3K2xWZ0p0M1l2THo1NFhTUFZBWEVOd3Jn?= =?utf-8?B?a3dUdlZHZUFRQnJGd1dSemZhdkpQV2NwWXEySG1Db0VoUHFGVXk1KzljdUtD?= =?utf-8?B?WDlKd2NxNVIxR1dWZ3d2Q1g3cExyYmNmcW4va1VSZHJZaHAxTG45STl5d3hC?= =?utf-8?B?cVpoa1Y2TlZxdDY1N3JPTjNkT0pTc1crSzlweWl2dXpiSzM4UU44ZndwK2ph?= =?utf-8?B?K1lqSFZhMWNzRC8wNnptdlRxZmNxNFphaGh0TWsxMmxEWDJ1TmNlZ0R4aUNr?= =?utf-8?Q?nmnUPwbiJzk=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(10070799003)(376014)(366016)(1800799024); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?enEyNkhiKzMyMktCbFZ4bWdDWkFyd2NPYjIvSXhPbENyZUFrL0VmWXVGTXFr?= =?utf-8?B?dFMwZnIzeXFLYmlRWnM0VjVjSklLeTU1V1R5K3E0eVcrZ0s1dFhtUXF4KzZ0?= =?utf-8?B?cHdIQ3FWcmJ1UjFzREtCRnRCN3hZcTRWNDNVTTdJMUlRbVZjWFprY0NMYTJV?= =?utf-8?B?eHhmZVNoZFljNkF3UkcrcWJmcDdlQWtVMDJxK3VRbnFSV0NXTzJFeGlVY3Q0?= =?utf-8?B?TmoxT09jSEdXNDZwM1JPWjRjN2Q4RE1lb1AvT3BtNHd3ZEZaaFdRNUlXamM5?= =?utf-8?B?Z0FhdW4xZmtrTUNqenNwRW9uUWZIcmVZNExNL1I2djRzTTZXM3NDNVVETWhu?= =?utf-8?B?VndvaThHQWE1VTJ1YVd5Nk12ZFpadE5IRVRVZzVQWWI3Nkc5cGF6Y2U5TGJa?= =?utf-8?B?bzNzYkY0UDBjWVhranFERnBXdzF5bUpvbEVHUWp3YzVBaTRwbzdpVi9wSHNW?= =?utf-8?B?STFlSXpHZ0g0cnpETXpIN3BFalRMWjZWSE9SSmhZOWxrRTN5anh4dVI4bFFt?= =?utf-8?B?R1BWQkdhMVF2YUQyaEVrTUdIdUNKZXZJWGhWMG9oNEZOUXBSZ0p6K3pxZUE0?= =?utf-8?B?RnUzZ0I1VytQUEJkQzdHei8vbEp0QitJWSt2ZXQwN1VmbEFDWDN2dzFHMkJx?= =?utf-8?B?VXVtRkVENXhoRXBZVTFETjFvUjZUaVh0dkVtQTFiaHptZ2M5c2pDSnhPRm5s?= =?utf-8?B?Rmwvb0pXakpzODZuZHdYbHJTTUkvbjJrMFFVTWc4cG1BWkJxVGhIN01ySHJG?= =?utf-8?B?eXJTUWI3V04ybGYzS0ViUGljeitCdlFmZ3AwQlhXRnRZamhPdVMzN2hMblJY?= =?utf-8?B?MGdZR0pJZGtmV3lnc3RNbDA5ejNhdm5jSUFxdWhzYjhNM25XY1JYa1g1VTJa?= =?utf-8?B?Mzg4clRvY2kvdU1QK2w1Vi82azczTjREYkxUZUxGUkhmcG1JQkJkMWcrWmJ1?= =?utf-8?B?QTl6WjkrclpHdm9WTTFLZlQyT0liOWVrSjI2akhMRW9VeEY5UHBSdTlLK3hI?= =?utf-8?B?dVh5bk9wb1VHaU9TZTY3allFeTlGVHlsNnpGMndsV1hscWFWV0MxTE5MRXQw?= =?utf-8?B?WlYra3FmTXZpQk1sYXNUbjV1T2puVVM2SjdhYU1DRlluajZHZ0srdkZqTGdn?= =?utf-8?B?RnVUeDJid1hHblNLRkdyejU0bXRxZUxmMXFBamRtTmxyUkVsNDNmNTFWekQz?= =?utf-8?B?cy9DUW8xdkwzUmRxRjJtN1l6cXZ0MndVZW1pdExzYjNvSlBzNEVRN0hreEVR?= =?utf-8?B?bGJYdmd1MXQ2MU5NYjduaTNEemM2MzdYakhraXUxK1ZoSU9NS1lZTFpiTVM4?= =?utf-8?B?Q0NtcjNsT09ZRXdhVldlQmo3enVQNUtxZXV0aFpScStHL2NWTG54endRN05x?= =?utf-8?B?elY3cGEzN0ZKakt2Z002bW9obGVWeGhuVVFzVitXTCtQa3BOcnBUYzJkVjJP?= =?utf-8?B?K2dnWFdQUkJDYnlwVmY5KzVMNTYzNkJ4OFVvMkxieGNFTml2STdoVFMzbkhy?= =?utf-8?B?KzJFcEhJOW9NcnpsQXE2ZU45eTZiajk5aGhOa1lZQmlVTU5qVVJNT2trUUhW?= =?utf-8?B?VWMvbVczR3RvYWdVSTN3VnU5UEdZUFhRRnFheFhjblFwRWozYllMVXF3NXpG?= =?utf-8?B?Um9KL0NRV0JERFZPVjBVK0RoK08vRVNwcHdUTHJ4UEk2MXRSekE0ZEY3NDE2?= =?utf-8?B?YkFWTGF4QWNwczJ6LzJBbXFtSlJ6TTVtRlgxYTJOZGg5RmxFUFNveHBwSFlM?= =?utf-8?B?SVlnMDNnN0thVkVXTGhOaEhIUk1nbUcyWlZabytkVjlYN0RjR3diejdMQmwx?= =?utf-8?B?bWlvME5qVElXYmlxSXFuekZ5aGtFQ05QR0RKeGRhNkw5S25yamxNaUhmcTNv?= =?utf-8?B?Rkphd3Frd2trSWRoRnBGVE5sdnVvbnpDSERaczQySnk3a2FWRCtXNXZZTW5R?= =?utf-8?B?eDFQR2NxOGdsN01iYWYrU3h1M3Jib3p2bzc1VkpMZVpjdmVWb3QwVTF3eC9W?= =?utf-8?B?S2ZNbjl5VHhPaVQzd2FNNFBMMEIvNytiU25IcjFoV04wZ0o5L0tNZFpJaHUx?= =?utf-8?B?ME1oTmF3YUtOZkRhQXN3NGNwMXlYa1BlZnB4YXBLYUVkUTMzU3lCNHFnTHd4?= =?utf-8?B?UFlaY3JRTWQ5czltU0lJOTVicHhhOUY4VGNyM1VZMEcwK1Z3VU1sRU1uemhV?= =?utf-8?B?aUhzdC9UVkg1c2JPYUNwU1BBUTZocG9wd3hUY0gybU1YTXc0TkcwMzd6TmFH?= =?utf-8?B?RXFUaSs2WXo2TWUxeDVMKzV2WEtnPT0=?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9dac7b57-6f9c-487c-8b3e-08dde623939a X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2025 11:11:03.3834 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: f1RtsSZG/352wLVZl6RLLqoRi4qdA1nds07MervLsbOmlf9+uhM+7ixd4B+2sZBescqVrc/bCWXxG9BQivltQPQDBHl7TGnXTNL8l0Tl69c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR02MB8891 X-Proofpoint-GUID: WBLYTkIvo5JmX7qx8FP08C-MZ-objjJz X-Authority-Analysis: v=2.4 cv=c+WrQQ9l c=1 sm=1 tr=0 ts=68b0394d cx=c_pps a=c0qqeiFHmtsfDSKKRmqUVQ==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=9Z-VKcTvWNG3FDJRCYcA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: WBLYTkIvo5JmX7qx8FP08C-MZ-objjJz X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODI4MDA5MyBTYWx0ZWRfX5dYi5/jtasjc bw4QU0/5yMHXIZ1W9WcYI7mBDlTatkfp6DYKMesc3fjBl7+l8o154HlUxuEiV2egxC8FDfKfhnM kajJ0GtouJzUPCJ6A/zyikaRVWGQeWYdIVTpkFawZwf8AZeXckm8+DgQJ+a4fiY55mlcnHx/LZd i345f6VWsUJ0eEN0SP9Yl2CUQbFNn3DyldCWlB74qwnPVRrg801XRrS5gMkxz3i7vxk0SsMr7Gk h0EL8/ilmrxiEseNNoucyAnhjdDwei1K+1LP1oOFvp0IbAGt+9CD6p9Hqi1SHK6QEmuCFccUnT0 5ny+w6L/SCdhYZBQz2KWeyjHejY81jsSmvPXZRu0iYMgHfqaFQhdoF7d/eVo6k= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-28_03,2025-08-28_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1756379596160116600 The isapc machine represents a legacy ISA PC with a 486 CPU. Whilst it is possible to specify any CPU via -cpu on the command line, it makes no sense to allow modern 64-bit CPUs to be used. Restrict the isapc machine to the available 32-bit CPUs, taking care to handle the case where if a user inadvertently uses either -cpu max or -cpu host then the "best" 32-bit CPU is used (in this case the pentium3). Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/pc_piix.c | 39 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index d165ac72ed..8f5fb3cf90 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -436,6 +436,31 @@ static void pc_set_south_bridge(Object *obj, int value= , Error **errp) #ifdef CONFIG_ISAPC static void pc_init_isa(MachineState *machine) { + /* + * There is a small chance that someone unintentionally passes "-cpu m= ax" + * for the isapc machine, which will provide a much more modern 32-bit + * CPU than would be expected for an ISA-era PC. If the "max" cpu type= has + * been specified, choose the "best" 32-bit cpu possible which we cons= ider + * be the pentium3 (deliberately choosing an Intel CPU given that the + * default 486 CPU for the isapc machine is also an Intel CPU). + */ + if (!strcmp(machine->cpu_type, X86_CPU_TYPE_NAME("max"))) { + machine->cpu_type =3D X86_CPU_TYPE_NAME("pentium3"); + warn_report("-cpu max is invalid for isapc machine, using pentium3= "); + } + + /* + * Similarly if someone unintentionally passes "-cpu host" for the isa= pc + * machine then display a warning and also switch to the "best" 32-bit + * cpu possible which we consider to be the pentium3. This is because = any + * host CPU will already be modern than this, but it also ensures any + * newer CPU flags/features are filtered out for older guests. + */ + if (!strcmp(machine->cpu_type, X86_CPU_TYPE_NAME("host"))) { + machine->cpu_type =3D X86_CPU_TYPE_NAME("pentium3"); + warn_report("-cpu host is invalid for isapc machine, using pentium= 3"); + } + pc_init1(machine, NULL); } #endif @@ -815,7 +840,20 @@ DEFINE_I440FX_MACHINE(2, 6); #ifdef CONFIG_ISAPC static void isapc_machine_options(MachineClass *m) { + static const char * const valid_cpu_types[] =3D { + X86_CPU_TYPE_NAME("486"), + X86_CPU_TYPE_NAME("athlon"), + X86_CPU_TYPE_NAME("kvm32"), + X86_CPU_TYPE_NAME("pentium"), + X86_CPU_TYPE_NAME("pentium2"), + X86_CPU_TYPE_NAME("pentium3"), + X86_CPU_TYPE_NAME("qemu32"), + X86_CPU_TYPE_NAME("max"), + X86_CPU_TYPE_NAME("host"), + NULL + }; PCMachineClass *pcmc =3D PC_MACHINE_CLASS(m); + m->desc =3D "ISA-only PC"; m->max_cpus =3D 1; m->option_rom_has_mr =3D true; @@ -828,6 +866,7 @@ static void isapc_machine_options(MachineClass *m) pcmc->has_reserved_memory =3D false; m->default_nic =3D "ne2k_isa"; m->default_cpu_type =3D X86_CPU_TYPE_NAME("486"); + m->valid_cpu_types =3D valid_cpu_types; m->no_floppy =3D !module_object_class_by_name(TYPE_ISA_FDC); m->no_parallel =3D !module_object_class_by_name(TYPE_ISA_PARALLEL); } --=20 2.43.0 From nobody Sun Sep 28 15:28:19 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1756379518; cv=pass; d=zohomail.com; s=zohoarc; b=fk1PR1s9FbOXL00ydhm1J+6G9EcnYOaQ4SyW6j1IMWL6fwwyN0kINo4Z60rwyo3KZXCxYPfm99e1pV6HRQ2bEv4DvAY6xocSzTkjgMBhQHouxlexuRjMLwNOWTOfv1pEuBC9Qtn2X8zW2lR3MPAMEwRjrqsJoe1bPM8odFiDjE0= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756379518; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=F4DC5jXTS8ERZceIX85OY3SMMmuQe/FLHPVXAK9qJFw=; b=CgMVHbw7SWuJxf+FyTWRK1k/nTU781/rNDfltqdjFJAFfa0RuiKUVa1r6rsqQcaRDF8NRo5mcEdSLu/klPv50/pJvZtYmIddQ93N2Hv5B7ndUMvac6KD+tT/kX/eNeoYlel6j+/7hU8tklDfSjTpCbqpB89ElQ9RAdTxQD4LOXE= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756379518036891.5895255771175; Thu, 28 Aug 2025 04:11:58 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uraXM-00083W-QP; Thu, 28 Aug 2025 07:11:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uraXI-0007zb-OW for qemu-devel@nongnu.org; Thu, 28 Aug 2025 07:11:20 -0400 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uraXG-00051i-K8 for qemu-devel@nongnu.org; Thu, 28 Aug 2025 07:11:20 -0400 Received: from pps.filterd (m0127837.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57S5H04m016745; Thu, 28 Aug 2025 04:11:15 -0700 Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10on2112.outbound.protection.outlook.com [40.107.92.112]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 48tgu2rr8x-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 28 Aug 2025 04:11:15 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BL3PR02MB8891.namprd02.prod.outlook.com (2603:10b6:208:3b2::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9052.20; Thu, 28 Aug 2025 11:11:07 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%3]) with mapi id 15.20.9052.019; Thu, 28 Aug 2025 11:11:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=F4DC5jXTS8ERZceIX85OY3SMMmuQe/FLHPVXAK9qJ Fw=; b=QmZa9bDtzy2o4K0AZdnUg48Zbr/iNMafE2Rlc5EgKmVAiTgQj1UgZtXy3 UpTM/7Ka2fzdZtvlBWkR+0B9SiqSvSDgeqTgjeG3yWfjOVOBg8GlkJxBZSpEMU3x jAtU8ALYAbxmTC78vI5BC6PB/wm14ilXKpJn5WS4mnTz1a2yNeC7XPxGq27kAghm 9MDq7450lAhkgFBBOaEHGOliOXVVrUSSwyycGJv7ZrwVeyjnFhBYXivKCT1xcyNS ss+CPIJY8QZWDoiLjPTHPWZ4hwAFGH4zqOjp7ib8VMq/7p/f1HRPZV/6ggAvE6OX RsmHrLg9gCUJfnLYUeBQEKz8Rkd8Q== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gtKsqguCKTKJX6Z7Hn0aXOTl/KhrfRhQ0VB/VpWi4m8USf7n+kslqctjau4uu95pBgRpmwodK/ICXHcoyFN/mMRwHlP2omq3TAYYoR4hvS8Jnt0pyYRM0RpkFFij8eICYKdsxQHq2RQLc0xOF81x6MFLcxuJITovIJUokpYdTbsjXw3MQyucXOUtrzdpNdRhyCsHbU1775C3EKzlo/C3fXQh8FCzlkdVJeG40HumvZ2MjdL33gNF420eTQDvdrV4i2JWEuLeL9vowqe5wb/682o25Yh0qIWWu+7GXiXiZH1NmISF5lir1694RX6jbFjRERK4N8t5Ruj7f1RY9tI7eA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F4DC5jXTS8ERZceIX85OY3SMMmuQe/FLHPVXAK9qJFw=; b=sK7EvFA/B8ighhkey+aWXJVnY5onAT8bjDDGCgMBIvQN/5twC19NKtLYvok95klOJ6PoL4rE2zUKb56dAHC3e2ehwH/miSyp5UZKNbsM7/X9pxPTZaNcRYzSHkpP7KzGvDfLattA+yorkhEsTLZqV2kSGoCZjMgvN5OQWOB4lh1vtAY7Nnfn/i9xKU6B2mCPfcx3jRHfXcrTT00BPi7engdh6s6cwMzv7QV6eEjho8l+g5JrQPHimzMWWjI/2JXZGAw1ect0YkEDn5UUeRtWiUWTRKZ8347eCx2lXaGOKxcFVZhto0iVp+w8ueY6uQq9FpPCHQcPppRbTBl/CDDbOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F4DC5jXTS8ERZceIX85OY3SMMmuQe/FLHPVXAK9qJFw=; b=kEpHYsV7C54QRsv/27iLlkZ63DqzkWwgBbrXPlXakQYqeyPThLLDUZcEZ7cWhbHeFEw+/7QSq3lNtO0DQgN1s5fWCCbG9KAx5TDdSFPVkNc3wksDqxaKhupRan2q2RiGgDO3q0bZ/juKQffovUp2JtIZutf2Nr3IcOIqGEupTCBDAP7Hqx0nIhLWWNTVURXX85W8fswQ3qSYabDEfvJGD6OVJTFqM5RTcFHiadvuvzzNzcI6hYoG8OXgag1/vlBOM/3v29pz9bF+UWPfKUxyB3AFZgjDjov+vCjt2kRhHTpmmf3AvOSaICdPVbs+jyGEBNg9d99HfTw08+2HQbmlJg== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v7 02/19] hw/i386/pc_piix.c: restrict isapc machine to 3.5G memory Date: Thu, 28 Aug 2025 12:09:45 +0100 Message-ID: <20250828111057.468712-3-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250828111057.468712-1-mark.caveayland@nutanix.com> References: <20250828111057.468712-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS4PR09CA0009.eurprd09.prod.outlook.com (2603:10a6:20b:5e0::12) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BL3PR02MB8891:EE_ X-MS-Office365-Filtering-Correlation-Id: 90ac8ac1-f5c6-498e-384f-08dde62395fc x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|10070799003|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?hXr8Gz5todXDJ43K6VuO5j0lE4btBD18eQ4gvxl2gpvY8H4TndsmNZ3vyj/P?= =?us-ascii?Q?mtBH4DYSu3W6gxGcD2X5SmoH1Zo24tZ/0NwO3zbXtvWvjPt+Xv+Q+nAi94hh?= =?us-ascii?Q?bPGAgW3S5pVQH2YFDcatsu8ehkUmlxZMb5oDTDq9egqqytxT5D65w0ic+L3T?= =?us-ascii?Q?jmPxfmhe6Yn7S1FbwraexoSLQHJVfkQT2w1BDBDgB6KiwvZdp6TbHVLvpY2h?= =?us-ascii?Q?GNjB36Hmsv+isMg268tY1IpbdyTiGUTbS0I8WTsL/IZQoFgsp9TgJrJGtpca?= =?us-ascii?Q?izsp26dKI9vR3a69WmNGs2Lgd6UAhChIGSWEJ+Xj3W94Rv2xi5Ii12Il8IUN?= =?us-ascii?Q?Uq5bM7Vw//OAns9UKzj/S7F5zMhRJGHVxmFaPNeXYBaOIcia3tawQxr/aiir?= =?us-ascii?Q?mzQYG1sgDFybiyonC5TMSRGwueWwQILLyKm0Fwpb2IV/MLosMlY6BDgpbc5h?= =?us-ascii?Q?xH9eNaw+4LbLaWxHL+lACKxkR7RxRp+zdvK7psfQy+ng2HMSKafga99SlBwz?= =?us-ascii?Q?xXb8qiHOuQNyMb+F4TPlCxK9RSQcBFHQbi/6773ngGeR3LoyYQcVDziAle2V?= =?us-ascii?Q?7vq80sD0yltwymL238UprF4j3vZEIsXvNX5luwdH5JSAmfZKcLmLQWumW3Ib?= =?us-ascii?Q?ph6p2/A70IipOdEpwLWNxDHxn9grxR0rFUalMHrSysDQ2WCBjrwqzdcIw3Xh?= =?us-ascii?Q?2Id+NQL1A5oXRcQF5VhlxHAFy5n8NQTN1TDHwghctxso+dqdrkzlMRldMOOE?= =?us-ascii?Q?GcDD/FWxaDoIgC+2pqU0aNSU31K8LKcKCBIhpN1/SXT1NxW33vviYT3L+7Wn?= =?us-ascii?Q?15Q00NdGU7fyED3RtKcn8fI1b3KSzDiGRRr0MQy1wKLOGXRWuiD+/WcccJNg?= =?us-ascii?Q?HSwTRAwY4oISaSo4E6IERLIruGDUnEcFx2mf2YQ7rv69bx14iQQOV69AmXSn?= =?us-ascii?Q?7xjrvRw9iHlqj7HASVturocFckGw25hXXbVlzm7r/z0XwGx2wJ2dGYFdtt1o?= =?us-ascii?Q?NyElY4rd5bA89ShGFhyeXS9tBf/RQqWMpuKQ1hE90liPCZZfwhbg4qYGL9nC?= =?us-ascii?Q?GW/Tq0OlJI2FesI0b/ySvjgIBSonVcB2MsO1aOYYNjK3fTdlWzerhqTzCkmO?= =?us-ascii?Q?rRQIh+PA9C0RB11ijEFQhOdexTBm5IfMMPcUMVjHCo7GgM36KHt79VIj0VU7?= =?us-ascii?Q?6KPQf64l4meaymx43PKKs9cUIG8HIbqxf2M4c/Q6CJxroq6ltfE/yGh58Z9k?= =?us-ascii?Q?HbMuvKaSr4tCNpiz+Q98GgQaiJpa80dwmuXlznPD1XQcWoeRY9lU+QWqOe5F?= =?us-ascii?Q?NrMOkGiJUP8CAjhMJR9WVhZjIKyEnD86l7dUlgfWTN/ox39v9oUIP+1KqlkV?= =?us-ascii?Q?XhapE/Qq3SZ36pOiirAUvOeioqIyg1KcKTj1kbau6Nb362tP0mqjRe08ejwm?= =?us-ascii?Q?/8tt/lJAER0=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(10070799003)(376014)(366016)(1800799024); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hmTNSY3R79HlMk+koeyuEu7+QvSOPpQcRDivmjow3DOdY8MLrjc8JzmbKMCE?= =?us-ascii?Q?dG70idmxNlIs9KiIvObVJS+8dnrmdjKyvreliTo9rvTVEURvFxqGzAMuCjr5?= =?us-ascii?Q?zJOGT83rtPvqu9q/LPZg2oR5aq0hb7lGdmfyJ5xbyCHUUzk2ER3VZzHLudU0?= =?us-ascii?Q?aqYjSsIYEg/3nRpz2axhfr1iFCCupsEnLOMoGpkbjhC8EQCC0rVXWBUtvbWr?= =?us-ascii?Q?Mdj//r5TAaNyMESBu6yG3zZBXlM0Cb4W6VZ6KRaN86UYmWiCnMvyOYhPAiMZ?= =?us-ascii?Q?ISjq7uMYjaDAK3LeXB4uZP7PgZ8XMAg4unVgx/O6h/WX1KaCaBedefZKPYA4?= =?us-ascii?Q?hVKMryiISyKd9q5amIL1i+KtWoSKBdHKjqn015XC3TfsZU7wN+YlB3D/2eAu?= =?us-ascii?Q?b/sdgr1EdjwU035Un9FJtTJaxlhONLBvYBOrjoEkQxWriY2ERCmM6d4J1fwb?= =?us-ascii?Q?foCL/ZBKEfDl1kwj8FwWhWE3ZvPcm+pflrwCmCX3O/aKqrq9gKG5HzSQ/Dsk?= =?us-ascii?Q?QXhjUJ3kuHX5uezPgoGQoU3ld1bujznyMpo9B8tD77pSG0W3uFnN4tfsZh3M?= =?us-ascii?Q?Lwb00K3RIkDhtW83OfBb8g8vGl0N9yoQwOLq+Nyrj90sIPOPTB5I4Wjnc9nC?= =?us-ascii?Q?2hpaOWrJg8QPW8ziT5qeTfzCraoiBq9QZdlcsvrPZ0bYtktqv+vncPhQhqge?= =?us-ascii?Q?59tSL8OsaF7s7JjwVUpJI9n6rvLxpvMcptMwfQWAnk9SiiBNQwCnb5oGdN4Y?= =?us-ascii?Q?3evKGa3daKY21EBl6d8q8Wp3THodz562VFsacsMojDvsQ/lR0sz9hCx6DrBy?= =?us-ascii?Q?d2ky2FIwhsjffZqhig7WP/+GLtyUna5s2xuw7gUHTndYi3LKLJ1OBbr+wY0I?= =?us-ascii?Q?9r4dSBZ5O+0f92CVWM6wMDott2RRITgXbNDznvIAnjQ+aROpSw4g2AVXDNTQ?= =?us-ascii?Q?z74+NsAgmJ5RxWzzurHbi5MuUwzGcJl0X/12gWYBXN0VRp2TVH92kBau4Ef5?= =?us-ascii?Q?1PVlv0x9JwbRHENhRUWE6Dp0knT7veCOk7DTsR4soON9mtAUhaTZKcdniUYn?= =?us-ascii?Q?TyjrM/a0ohSlsWSAcJvJeAz6bNUyGJNrtOYWYa/o4NepmhBn2nSWJN8rPyDn?= =?us-ascii?Q?WsamDqqHdG6MNNaG3I2jJ1LrULbC2kz5KSv2NlWJhi427B6/i/tUdK3JbJTa?= =?us-ascii?Q?20kPib3SBLYRx4ooB9DpmL3rwH+8c8t3j1Rff0iQvaFbsigt2GXbFhSXLb93?= =?us-ascii?Q?ai2GaiKk3NJcQTLQmpdeOKZz7Qw3XXJNlg57eyj0Q+pLDPjuxTfH4z9EWw/b?= =?us-ascii?Q?wWH8479p8xn7heZN1aRhejndvs8nyJgM1XQmIzM66LjtAIhWuTctpJjofxbX?= =?us-ascii?Q?TvoAntEGe+Qeram8ikyGx2Pn+Y6dxsi+yfsDlYHl2CmAdnUDmmNmsOm7PqXZ?= =?us-ascii?Q?ecckicd5YVDse/zEkgmEBvjcr+YY8kApLOehybbAryamcnjeYse/3xmv5/YD?= =?us-ascii?Q?W6mMp9fQopweoCPG4PxKolCZxyavzpd0xJj5VlymMET/+G6af7WLaDVenFoN?= =?us-ascii?Q?nuRot/NokDjK5th11n0RSxy0lpL002PyNYxxSjJgrAcnVmQn/Tkk+x4puisG?= =?us-ascii?Q?Xd/1BgMrRy5HsHDeABxcxdjZEKw8tZ0w32LULf4kHz4CtEDe33rk+/JAMw2p?= =?us-ascii?Q?/sXVkA=3D=3D?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 90ac8ac1-f5c6-498e-384f-08dde62395fc X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2025 11:11:07.1919 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KCxpY2IiICYFCr2OZUj8H0GiQjFCmbe8TW4V6oOVRiE9l8WqBCXqE6VXeVh7o24fYMckwxis9ejspqLgO68qS25YP5IuOQNzY8s4Ow2vkqM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR02MB8891 X-Proofpoint-GUID: -V2ifCBHiOvUKMwqyhPNozbjwO-31lL9 X-Proofpoint-ORIG-GUID: -V2ifCBHiOvUKMwqyhPNozbjwO-31lL9 X-Authority-Analysis: v=2.4 cv=ANL1oDcN c=1 sm=1 tr=0 ts=68b03953 cx=c_pps a=OoAjNmQ5oDU3bam8S/baIA==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=2OwXVqhp2XgA:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=-_9pao_q6fl1E6OtMoIA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODI4MDA5MyBTYWx0ZWRfX1s/YKmsMlyGm l41SQhczennoph3oiMZc5ZWoWCMeC8NIRmSgjwyMiL4IMEaCIvOxOr0kKDpexO4AMKEmYm6eSXW qk/A1dL5Ml51XHXanMEzfkznOeicZME1MUnB5WQ6gBT75zCjylEpalzzvTcrMg8D8+R87/9+SA/ +f9YoI8c7xo6oDTI0Tpg9/oMLmy1SzordYnr3LZMWVjttAAucNPzhJwFBN0RdqL/NExJ62I3oG7 Sy2VjuNDO0XKr4LKO4LwlVtiJRBM7/Dxfpe6VdZ8j41UWD4qji7Nbq5Od27wYQogGO7hmFRkJtt vsTceOehKN5VVWTApIXwvWPgSJnZpeZnczHN1aOU1xbMnq7rxkg+KMqzmLRwIA= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-28_03,2025-08-28_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.151.68; envelope-from=mark.caveayland@nutanix.com; helo=mx0a-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1756379521146124100 Content-Type: text/plain; charset="utf-8" Since the isapc machine is now limited to using 32-bit CPUs, add a hard res= triction so that the machine cannot be started with more than 3.5G memory. This matc= hes the default value for max_ram_below_4g if not specified and provides consistent behaviour betweem TCG and KVM accelerators. Signed-off-by: Mark Cave-Ayland --- hw/i386/pc_piix.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 8f5fb3cf90..9a3b5d88f0 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -461,6 +461,12 @@ static void pc_init_isa(MachineState *machine) warn_report("-cpu host is invalid for isapc machine, using pentium= 3"); } =20 + if (machine->ram_size > 3.5 * GiB) { + error_report("Too much memory for this machine: %" PRId64 " MiB, " + "maximum 3584 MiB", machine->ram_size / MiB); + exit(1); + } + pc_init1(machine, NULL); } #endif --=20 2.43.0 From nobody Sun Sep 28 15:28:19 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1756379517; cv=pass; d=zohomail.com; s=zohoarc; b=gtONC/RgeVqBIiFRzn1oIWrJAJgoV9STQWOZQBOr1aDWOPOPzPbSiUyrJfF4cc1RRxFPtGGDpD043q5Eam2e7ov1JLFFj6fAfzbRpYbcZ63M5XYxct0pYehlrE9FJ5pVNVqJb0MeitxhwkKybXTyccKrKg77zr/XuWj/nNMTINo= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756379517; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=Vm0v1DVf9N4uvuZ8H0+MDFCY7nHayO+0F+irSwbHIt8=; b=WYh/guMAU2TscJ+PgQWdJ5UKQKZ84iKjJgLYMAbPq/6IOLO/0qfuifJPYlRwioyp1iPJcjaJ9wlVHsUhPaToWKoIYALXkfBNKpXRBLOSmm2q+H86ztduRB8n0hyUqrpc6d6Hv9W8T9dxyz/vnPCtmHpOOFWLg4+zux0IXTA/QSI= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756379517797613.0471558848056; Thu, 28 Aug 2025 04:11:57 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uraXN-00084c-GX; Thu, 28 Aug 2025 07:11:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uraXK-00081B-LC for qemu-devel@nongnu.org; Thu, 28 Aug 2025 07:11:22 -0400 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uraXI-00052W-Tk for qemu-devel@nongnu.org; Thu, 28 Aug 2025 07:11:22 -0400 Received: from pps.filterd (m0127840.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57S7hYMs2893263; Thu, 28 Aug 2025 04:11:17 -0700 Received: from sj2pr03cu001.outbound.protection.outlook.com (mail-westusazon11022090.outbound.protection.outlook.com [52.101.43.90]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 48t7sy1pfw-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 28 Aug 2025 04:11:17 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BN0PR02MB8077.namprd02.prod.outlook.com (2603:10b6:408:149::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9052.23; Thu, 28 Aug 2025 11:11:11 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%3]) with mapi id 15.20.9052.019; Thu, 28 Aug 2025 11:11:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=Vm0v1DVf9N4uvuZ8H0+MDFCY7nHayO+0F+irSwbHI t8=; b=MwE+XjsNTqQVZPQzEaiZCciBLwZoXKBBKgzYuuG8T+DmoU/CIpJ9pKMRN jIBCRbF0bqlLmZgu8ncJoM3c5xMHAA1d73jM1pafIpSSR3H69q4d4TwxFaK3bU5+ kh5xIHa87urgWeZI62GmkfWYlksmMn7ALCQpDoCgDPavjXaLWQso7aRJ7KvsaGdc dYNVl+zSin3XWmLkiiwdj2BYqA+wy2ZGzu6AD1FThop+g+sc+avh+aCbHluqutTk ef5EQWCW0vbqX3PYJr8hpCPUs2fcvpKZnLg6W/U39/D28b2swHanvUFPBVF+fB1b yFoDSNgjwQ8P9G34UMnpiRkCH7ekg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Yh1RZ4COJTMer9wdDP6MzhcipBAi4h2Iiuw5GZA/Y3G79aLwbHet4IIRYXALIgpMRL4Zr9kTxPmtUv2TbbN9Dwu7jNPpnhUtDa56YLffgPTKZbwZ26th0nFoNjtCLdSQD8Sp+TFuJ6SWOpAjkdB5el/l+AtQDkplMSTtuIlib8o31Dv4+OcEl9g6x+XJ7zxdYikeaUbzqP+r0pk/4syJMU7H46/CzZhcFaGjLAMl/CrVMTqKQm0xNMw2VOxeiuHS+O1wPBDGOGUbc3wJWzrvAMXzUNeyGPaYhH/XzUrsWrEF2hQ7zY3eJQS3ka/1vAi8dTMYlnjiX+hyIz25UO2Oug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vm0v1DVf9N4uvuZ8H0+MDFCY7nHayO+0F+irSwbHIt8=; b=T85th0eyr38uhXKAM84jlhnQaTxhDX4SVhf197+ICQT7YgIGc/29pHk1EZPW++KkGMp/TOOH7cnxPR1GBSTcavsRJsS6+o1Dx40drofbu4W7wQI3JfREMPBFcmEVPu74tzGhm6X+x9xEFgArRSq2QweEqjs2NzNvvMeuzqpsyQmx3XtSyhfsdyEqJp/pIB3SJtlDA7LWGvVM4p34JSG7IdQ968+nKNBIxuYeR5dQ0RftWnDDyDFJYDFQ5jJOz515pulMckrkWZwYTD2DmiSTJ0UHDbC8EoOBRbIMQ3hyJoDMfnCoAm4Dd3YIqHYu+gtUpW6/QkBdAU6ah3DGyW89Cw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vm0v1DVf9N4uvuZ8H0+MDFCY7nHayO+0F+irSwbHIt8=; b=yQXyWt6Dq2+8SAQMna5KzcbeNQFAeUqqrAlaGpKEXWe4OGsTum/03/ay7v68D9lsUG5mBhibpezNBhl578T1VHs2ojXYgkqlHpH8IsYjhD3t5HRPCcndDYOJXp26BUHnNsfad52dl4GjBET2eDqn65g7m/3HQ/7p//GozzlMrj4R+XTv16TJZs1sBdCtipe3IL6wsipM22jAtKaoKgD6HkXDy0q7Gt/eAOrOiEJ82PNx/8NlLOuqq7WCZxIiof2MKmq4MpEdk84YU8Y0BDsP1UcZeJU8fRXK0FWl+Jl1Sd5adEQV/jY/0X4m9lL1v9YuqN9oP5DXAXPYCy6+Kr3+mQ== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v7 03/19] hw/i386/pc_piix.c: remove include for loader.h Date: Thu, 28 Aug 2025 12:09:46 +0100 Message-ID: <20250828111057.468712-4-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250828111057.468712-1-mark.caveayland@nutanix.com> References: <20250828111057.468712-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM0PR05CA0081.eurprd05.prod.outlook.com (2603:10a6:208:136::21) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BN0PR02MB8077:EE_ X-MS-Office365-Filtering-Correlation-Id: 45237ff7-b6b6-4359-d49a-08dde6239830 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|10070799003|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?V2Fhay8vNFdDcVE1eWVUbGx0WjVlRDYrcVVKZU1YclBrd1Y3MXdGcTlUaTFY?= =?utf-8?B?RFVvWitKN2JvMnBrYWJZT0F6eXdBSWpIV1EvZ3hlK0NNQTJqMkVKYXdYYk1L?= =?utf-8?B?UFVDTWh6V0V4RmRzN0lkaW9aMHNtWEFJVjlSOUNhK2cvOUdVREZOVEkwbnIr?= =?utf-8?B?VDRLN3FxY1dXcXlod1ZWNmFCV2pOc3RNeU01cm9tbUtCSms2ZnU4T21pbDdw?= =?utf-8?B?Z0h6VGpFc1A2ZVJnOWFvNk1CK3dQbWdrbW8yNnFOakdZTzNRMDJiYWNSNzMr?= =?utf-8?B?UWNNYktyVlVocU55TWtEL0pOZVhiVmthUmJvbzJTWDNYN1l2QkE4SU02WmtW?= =?utf-8?B?NGgvb3R3ZWU3Y010OFQ2Z0lISlY1bGxwUjdZd0V3Y1IrWWtkT3NMWEpKQ3ZH?= =?utf-8?B?aTBnQmVNbXVhUTBIMlUvWVNKT1NwTXpDdFlzY2lEa3N2MmJqYjhsTkVHZ1dI?= =?utf-8?B?RFBHTG1XN3pnUDdhaXp1YVRHdnlZblBJRkF6aU9yNjB1OTJMRVlEY0UxN3c4?= =?utf-8?B?M2ZiaytBQmszRzJKSVhYc2g1NkN4UkJJMHdibGdFNGJqa2pWRVhITWtTS1Zr?= =?utf-8?B?elIrZ1NIZTdqMTZoRlNaVDhXeUt2OVpNdlNYdFNMbGU3RTZlSUVJUFlFRUhD?= =?utf-8?B?ZEVNWlloZlVmei9MMS9pZGJXTW92NWlLN0lEZ1pDdmxUUmJ4NVY5SmRoRnlP?= =?utf-8?B?YlNUTWFwcUhxTld3SmpjWDhWWmJtM2ZTdjFkalpMeWxpTmZzMUZOTmhZNVBH?= =?utf-8?B?QnNyUUhhb3Fid3VIcUZudDBXOGVmdzBudFpodFQwVVkwL1VvNWxWS3ViOXdC?= =?utf-8?B?ZXQxV1NzelFqWGozejdYdlljYWZBbmhJZFdWWXVLSktSREIvRVJFdUd1YlFy?= =?utf-8?B?Y0tmNFR5QU5ZWXY3c1l3MEdJYjVtei9UYVlITWhRa3UyT2tGckE0VEswdUhp?= =?utf-8?B?OWN1Zk53QURhbEFYTWxBV2tyVk9MeVNEaDhONzY0VWgwOW0yV2RhOE1nNmd0?= =?utf-8?B?ckpzckVNWm9CT1hnZlBNTGtzTUhQamFMeTRGVXVqakN1VGNhUVlONHhCaUVU?= =?utf-8?B?aFFnNjBYRzBQS3FGVjNlajhxYlM0dmlQNkpjdUpOY2tzQWZsVmtNMy9LVFNM?= =?utf-8?B?OUY2dzdFUlN4TzU0cnVCTjM5TTRSekNLbTZUbGRNd0JoUjZyVHEzSlNwQk1W?= =?utf-8?B?Q3NPeTNFVWJPZC9YS01YVWhtN1BxZUsxSnhBUU0xMnV6dHF4MVJSVVFsUkRD?= =?utf-8?B?OW5jdDIwZllNbVVySjd3T1N1aEs5ME0yZjBOaG53aXdnRmZLVFlKK1JDQnZn?= =?utf-8?B?L2c1ODN2QVdnellpWnJXZWZzeTRONVVUK1NJeUdnL252WkV4NGdXUnE5bitt?= =?utf-8?B?WVRHcTBtWEg1R09UOTNYTmNoYnowKzA3QmpxRVBrU2RFaXFlZ25YVXdVbkZJ?= =?utf-8?B?eGNHT0hlZG1LaXQ0OUZCdzhwZzZ1VEwxNCtnQTdxdkxPbjd4aEVtd242ZWh4?= =?utf-8?B?aWliSC9GckpPbG1RaXJkN0tjcEhWTlV2TlhEaXMraGJ5WlB4bC9iNkFOeEJE?= =?utf-8?B?WEU3Y1Z0enl6bFNHWGRMemY1bzdaVkpBbTk3dVpsZ211MlVmYy93MGQwQ3Jt?= =?utf-8?B?enUwMUR5QlNBSjNJeHRoczR6UUpUKzNzaG05NUhZL1JCSU9yaG9NRExhWmVX?= =?utf-8?B?YXBUWHRtYXhyNEYzclhpQTVEaWp0d3NUMW1hUVhDR003R0V1OE9qZ1AybzIr?= =?utf-8?B?eHAxU1VuUlRXZWJNWnZGL1BWbkI0Nk9GRWRsenorVFM2dm5kM0hCaDlvN2VH?= =?utf-8?B?Y0JSenN6RlM1Zmlac1djQlBzaHhHdWFMNm9nczRTWitnMVFyTDVna1h1WDdl?= =?utf-8?B?U0dlYis1djJxRmIvaUhkZFFPMVJ4aTdMd0h5R1VQakFZcnc9PQ==?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(10070799003)(366016); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RldTWjJzLzFGS2V6c2JLOGVzNXJYRjdqeWNIZlhoL3B0MWpYWVJsVm4vSzZF?= =?utf-8?B?ZS85dHZ0SUlQZzR4Zk9kWTVKcTZzYkRTdmNKbjJ6Z01DZ29xZU1ueWdEc2dn?= =?utf-8?B?T3N5ckpaQS95MGU0TFlOUHdUNkVabW9WV0FqTmFrT1FzdkJVWExXK1Y1SHRT?= =?utf-8?B?cGZLVnAyMWMyRkQxV3ZrbnFrMGhOeDlLNnZsSXZrZTRkZnZXbWNWU1p2emxw?= =?utf-8?B?OExmNmo5Sk1XNE5wTXYyK2NOUElnUnM5di8xRC9NQkFrL1h5Q1NiVUl2aHk1?= =?utf-8?B?TG9OWWk5KzEvaWt4REVYMjVjbXNLOWkycTRqSGN6V3R6ZmVQMzA4UFBubjZV?= =?utf-8?B?TFlEUHlZVncrTDhIMHE4Z3JNc0lIRGhrUGNIMU9BOEZIMkZ2a2N5OHFwb0xK?= =?utf-8?B?TUpHOVB2cjdEcjFwVFdUc2JpTW9LV3paNWJZL1BveVJCaDZQQUZtMHV5Q25r?= =?utf-8?B?Q0Z2QXlndjA1N3Fpd0xpVmxidUxsbG5ld3NETmNLcHgvUFV0ZDRtYWtHYlNP?= =?utf-8?B?aFFaSC9CZm5YbGJaTUFGTklIcm1tZ0dNcThtWEJMd0FMOHd2dzhaeGxuSGwy?= =?utf-8?B?SytYbzk0bUNwNGxMdi9sbXpPZFA4em42YjBwa29BM0swZ3NiTDY3MUU2U0hh?= =?utf-8?B?SXJrU0Npeks5WWZlcFBLb1dBbzRKN3U2cE4wZjR4eDZuQmJJWTQzd1R5RnNr?= =?utf-8?B?dmt3ZHhsSVh4RVFZMmN2cWdEdlVLWlVkcS9YanQ2Rklwd2VIa2dFL2ZObG5j?= =?utf-8?B?ZmlMeEFDM2tDekVUMHc5VVZXS3JxK1IwMUxCcit5UXN0eUVNbmJpWjNFbEFn?= =?utf-8?B?NGZYTCtGSkJwSjNhNEVWSUlqemt6Mmh2c2x3RmdDYXEyZnA2VzZNdHF0aXVn?= =?utf-8?B?b1pkSXNqbmkxbVM2K2EySHRDRmFMSmdseEllYXhtWnVlMGZ2VGhJNmRrdjdS?= =?utf-8?B?YlNhcWNIVk9PN1orTjMvelQxMkhlcUE3RXlmclpud1N4ZE1yZDRHS1hVZ2Rn?= =?utf-8?B?c1VCNWpFUjFJdytNU2Z1MmJ2K3k2RXR5OUNUT2c1SXZ5bmJ2QXA3TTcvWGYr?= =?utf-8?B?a0hzUHhhMDZybEtzelhPV2ZzbmF5ekJlL3J2RExHeGJhdGVTV1VBNWMrUG1h?= =?utf-8?B?Mm40alByUGJsL2Y2Zi9RQkRUdVBERUVHZDNJbUZNV3orTkdWclhlc0xQYlJz?= =?utf-8?B?Y3F2TnBydzBXUVBrdkFzVWF3OC9iOHRnNEVXeHdXMDNFM2xRL0NZbnI3ekRG?= =?utf-8?B?RzAxTFNGdERwS3hScjUySnFjck5PNkxCbDJudGxLbTVLVGRnVG5zWWlWUWZP?= =?utf-8?B?aE5oL0pIQTFTcVcwcFd0REczTnEwYmpYK0UwZm5hY3NWSnpLaXo2Nm9ocE92?= =?utf-8?B?UXlOSDdjUW9QSmlQZnZRTnl5NVFGem1MbFFPOGR6S0VYUGRFRWs1MDdQTThZ?= =?utf-8?B?SWw1bHNtVnhGb3R6QVAzc2VzSUpSY2ZDQmo3ZzNwcW1ZVFd6SkFMdFhwbS9n?= =?utf-8?B?Q2MwbDZaNGRQdVptZ3k4VWV4ZWpibkFGNVF0UWxmTmo5azJmek45YlVZNmxM?= =?utf-8?B?Vkw1OUgxbGtYL2tzRWU0ZEpUYThPd0VtMHdMN282b0pDNTJBVHVBZFkxYzFk?= =?utf-8?B?TTdhZHVadkFqOEw2bWRyTmdVVUoyREgyRGdQVTkzeUN6OFpMMm5Ta3p6YTV3?= =?utf-8?B?VHlXalRmRUJjZUhJUGVVWkh1SGdsZEp1NUpEVEhjYU9kNVRQUjAvSkpZeE1m?= =?utf-8?B?a1ZsZUpqNHdoOGhMQzAvMHVXN0xxaUJrR3B6WGY1dkxUQldXZ2dNaUovOE5I?= =?utf-8?B?d3lxT2ptL08yT09CMk5nTDNIWitsMG8wOFJVUjQ3SlhLZjBLeHJQbkJuMzR4?= =?utf-8?B?MVFqbVI4WGUyTjZTZUNPeFpVQ0hiQnFjbkVYaXRjbWFYbUQ1Yzd3VEI1alBr?= =?utf-8?B?dTVGWlg1ejA4VUdWbWsyVmVHQVBiQmtwN1lTUHhHeG52cndZM3ZteGRCclVr?= =?utf-8?B?VjBkUmtMSG95aUVnK0pyVEgxOW9VWk1SNit0UDRlOEtGcnZpR2hMZ1phUCta?= =?utf-8?B?R0pzSmVJNWFSMTMrMFZrektsUU5xZzFQV292N2tiWW9yRkhCMHJpZUpjUThY?= =?utf-8?B?Z1Y2SnVLT0lpNXVBb29mLy8rRGhJQWJCTm9ialRtZGxrazBDT2NlU2JTa005?= =?utf-8?B?WS9nWlQ0UGtMU0R3aWs3ZUVOemRQTVVtdC9ma1VjSnA1U2laeUh1NXFmNGd3?= =?utf-8?B?TmdDYitBZU1aU3pzbG9vVXpRY05nPT0=?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 45237ff7-b6b6-4359-d49a-08dde6239830 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2025 11:11:10.8794 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JKDq3azlITJPz5+9Ph7bEysLsNxGHHqK8lLxJa+hXwHYc+lrn+tVh/NyH4mqh+QcUMqz48DP9DxmsswGAdWyPjQm4isZPGnYeDO7jlk9gyg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR02MB8077 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODI4MDA5MyBTYWx0ZWRfX7Og2+M8sA/T+ +p4hv/a54flxVyAXmXXPMlnlTB8yBUSvuuw61Vevqtoa1nU7Onjkx+ST2O/YvExY0MfE+DDL25U E8GN6waxilhgrhQUu95Iffk9P9N5LwyOXd1VFH3ho58J9MnE2pfeB/Cf7XkJRb9SOcN65IMVuJ9 HmbQjqFSUFk3YgZ4oj7deVOpV8YC8AtK/2IVtvcD+I9m2bWvtEAa/whQo0CNPja7bprJ+i12WD2 hu/ytNK/2rnmRrThgbtohfQbJQuWtZ6+OFcaDbBqfY4430kYfMNd+CnAKeqbr+FzYNai42K3MP/ ak9smXigkl8npzEXD/asgWEJjEwND+O9xbryxHuNK9PNf2in6i9fTu4gqz8DxY= X-Proofpoint-GUID: j6lCV2A3pcjFSAU2--k-NuFNFMpkvFMn X-Authority-Analysis: v=2.4 cv=M/VNKzws c=1 sm=1 tr=0 ts=68b03955 cx=c_pps a=ybF/z1spmW4Yh6p7z4QQKQ==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=QyXUC8HyAAAA:8 a=Q1hRsLocYsZLQuAplzoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: j6lCV2A3pcjFSAU2--k-NuFNFMpkvFMn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-28_03,2025-08-28_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.151.68; envelope-from=mark.caveayland@nutanix.com; helo=mx0a-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1756379518875116600 This header is not required since the loader functionality is handled separ= ately by pc_memory_init() in pc.c. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Xiaoyao Li --- hw/i386/pc_piix.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 9a3b5d88f0..351986232d 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -28,7 +28,6 @@ #include "qemu/units.h" #include "hw/char/parallel-isa.h" #include "hw/dma/i8257.h" -#include "hw/loader.h" #include "hw/i386/x86.h" #include "hw/i386/pc.h" #include "hw/i386/apic.h" --=20 2.43.0 From nobody Sun Sep 28 15:28:19 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1756379517; cv=pass; d=zohomail.com; s=zohoarc; b=O4pYSIoAEeUZaHUlxu/SZVcZZghLgpmLpOXnQpMD+D3j4P6GFlRHzfIt5OpV7xXnO7lSg/1ryKH+xuleZ9IXCzBTfXUGkSYe4sw5Q2i7sLoQ0wY9IEl1kYaIzbxAoLYEN6fu4CVIZScaGFWyjEuh0Dt28Q30JnLyTB9do56aI+k= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756379517; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=9IUNwb32XH3GteQUpu13jX4m0ui3n4TCwBDbkEqdf4M=; b=Mwppekf6Bh2c7vj0WPasbSF4f16szJO55wrmynEmDd8ERAySF6OYNC43IclpChXH0ELJBsuSp7tyr+bw02NPUPJJJfhCwXshu8lLin3Rvog4XAZ7aX1pq0qN91gvxFpf4tyl1SoqGtiZn7yO0eo9lwVpQe/Y3zYSXRC3n/a0oJY= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756379517858287.85959635168786; Thu, 28 Aug 2025 04:11:57 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uraXQ-00087X-SN; Thu, 28 Aug 2025 07:11:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uraXP-00086j-CK for qemu-devel@nongnu.org; Thu, 28 Aug 2025 07:11:27 -0400 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uraXJ-00053Z-Cn for qemu-devel@nongnu.org; Thu, 28 Aug 2025 07:11:27 -0400 Received: from pps.filterd (m0127838.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57S7oJr32962933; Thu, 28 Aug 2025 04:11:18 -0700 Received: from sj2pr03cu001.outbound.protection.outlook.com (mail-westusazon11022109.outbound.protection.outlook.com [52.101.43.109]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 48t7xvhnnn-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 28 Aug 2025 04:11:17 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BN0PR02MB8077.namprd02.prod.outlook.com (2603:10b6:408:149::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9052.23; Thu, 28 Aug 2025 11:11:14 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%3]) with mapi id 15.20.9052.019; Thu, 28 Aug 2025 11:11:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=9IUNwb32XH3GteQUpu13jX4m0ui3n4TCwBDbkEqdf 4M=; b=mnZH6NAkU8tY9eTTiB3oApqKqZr+bav/x1Q+tjKhfvxAdsFM8Hw6sZACL OYOEVHlP3TT6stNyHfF8NpMbdvawH6kacJJoxIW+j8sJxkyasTvc9p9eI+6vSKeM 2lU2e8vbYTCGe7RDuSt2UbNmyO24+lGvfWx24mKY+jMZKaZwzk0JFwao6umZ/f+C RtBv+qNn31o37plJUid2pNtg8/mJmcdUfX1OiqOot4NcKWEpXxpdfKAF62j2ZssM QeC2RKLvGljJ9JL2zBGAiX4E1jIcgUS5fpDdO3/eCg3ldSNjiq9XcOY9i//kYkNG ubVrPj7Eibq9JZIQI3CewpHGOnsyg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MNbnaTOwk0AsLXQi3nOsqIz5sFco0spOssXBZCQ5ZrHtt3ZrMA+BtkSnBZXv/mZTyH971Jv1rRzgyl9SigHGD2tIYWUJValOlu+1MarNcCOIIHEXxR0SDOS0KIYiLLV9R2OydjHSO05nSpNUGI+y1RfzKVORr9S5BxsZMBQaU2lBK5IwE1xW1KjQ2UCiP3A5wrLfLtds+jX0uJDn0mzYPtxopeC5wGI0PP1dIEMs4HeWlHMYtw3TRw0IuZRHCKgMYK9T884NLVYQ71rjUQVZJ3NnZSNY383xbsY5ctun2Sm9Y3UlnK144Gf+QmBh0EWmLdX7XSnQERonYPKG3jjbqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9IUNwb32XH3GteQUpu13jX4m0ui3n4TCwBDbkEqdf4M=; b=KfYAjDw+gPeOtI5lZMr50PI9z/htlLVYmssl1EmWOSENm+InAsPjVJFw7z7PGzBKtRB4TbG1+cPrEw3a0ofFUhiUifTUArxz+k6CqxZIiZ2T1CW/VCyWDnWFRgHpqU8yNdZaf6baw0/smXAbI3PKO2RX9Lagw6Hlk8FyJnOwi4c63cYfPhSdVIWFoxgc+aaRFjRR4H8Cu51SYa5/jMLrjA87zKUzt/sKgLeXG235xqvaoHXFe7TZd6vJOE/cUW4GXIgYtFXq57GRn//SwIYfb8oY0TuY+vY8UMlt5EuKGloECw7lRIQkDjZSs13wmecDjvYAwqiFsCBQ6ZmHufyqfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9IUNwb32XH3GteQUpu13jX4m0ui3n4TCwBDbkEqdf4M=; b=O5D1JUW4VS36p5ZIXicDvaLBLHkn7Jw4b1ojTHvBz4oe07CUI27eEnPu2AAe7j24lGUk2bPOPMHsw+p5+pncrBtWbC+IBl4qBQ5EUELAz2n09oCyYi66Nm+qmf1IfmnKE6stF6ZH3eG9+tnzQLbg1RS6DlzKuju0dZOxaWdbMnGCMAUo6hB2zcZfd9LQBgLQ6Ggt3PUl40sDR6UGcGLZQdaJcHf/m88zcVGa0l3gdxw40SXVczrfDCfmKbTghg0h2NoHb0ZPViEFy8X61ZWrAQ4cmgi7EpLa9KSBCKZOi3i5lLZf7iCyFPmNDX4OFJ76NZKkl5JYsMKjqldrv5eTLQ== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v7 04/19] hw/i386/pc_piix.c: inline pc_xen_hvm_init_pci() into pc_xen_hvm_init() Date: Thu, 28 Aug 2025 12:09:47 +0100 Message-ID: <20250828111057.468712-5-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250828111057.468712-1-mark.caveayland@nutanix.com> References: <20250828111057.468712-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM0PR04CA0090.eurprd04.prod.outlook.com (2603:10a6:208:be::31) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BN0PR02MB8077:EE_ X-MS-Office365-Filtering-Correlation-Id: ada94e50-634b-4af0-7842-08dde6239a09 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|10070799003|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dnpiZUNsL2pnakRZNXpPRjB2MDFEQW9lUTVDSFJ6b1JidVJoSWJacXRHM0h2?= =?utf-8?B?WllLdy82M3c1cmh6TzdHMHRSMmRKZGN5RUEvQU9rMWRqWWVrSWpuS001U2lB?= =?utf-8?B?MlhmSDBJUEgyOFByUEpGcEpJVS9NemVjMUVWenUrRExUbUhlV1RJbnhNUWxQ?= =?utf-8?B?NTFIODRRakNWKythcmFOR1VYQThQVUdaTnYvVjdQdm9uUHJVbit2aERiZExD?= =?utf-8?B?a2gwVkxFME5Ld09xZHdkZ09XTDZ3Rm52Tm1wQm9WVnVnSDdLTGwvMk1JNExK?= =?utf-8?B?ZmRrRXFmSnRIcWdjbzBIY3JqVlZNSkRhK2JhNXlsL09mcUtPcVVURXF6UWg0?= =?utf-8?B?M05OcUNKUWxESE1pV29YTDg1c0taZHFxZVI2K3IzVnBxL1JaTHNGWWdRN0di?= =?utf-8?B?QzZXek5ZejA1QXNqM1Vsa09xOEg4NzNvcnZueUZZb2lXeVFOZy9WYTlzZVV1?= =?utf-8?B?YlRLTytzVmV6Snd1MDBpbWZsNWFuZGV5bTFzOXZnWlkzS0hGTzJNc05CVTNz?= =?utf-8?B?V041N051VGtOa2hORzlqMG5aL2dVR2RmZ1FpNWFVRFJqb1p5aEVvNksvTERI?= =?utf-8?B?clJuR04wdW5iT1VQK3FXYUNXOUg3TkhwL3ExYzR0YkRIYzZOaVE2eTNlYW15?= =?utf-8?B?UzVEMVh0OW42UDF1U1pISU16SjRZVHVUejdnV2lGd1dxZkQrRVhqSnNQTitE?= =?utf-8?B?MTVzdThpZjNFMmIwdmlrSG9UTE8rRm5abG9jVFJQdGlRYUNtM2tCRFJ5VThR?= =?utf-8?B?TEdwakJ4UUNqamJXYTgxM2pjbVlqUDZQaDRNS3RvL3QzRG1HSjJ3ZFM0c3p0?= =?utf-8?B?K1pBNmNjYWsrR1ZIZE54U2duTEhvZmNrcHc0OUhBVlFVRVVFc3R0ZEtQQnY3?= =?utf-8?B?OTAwSDBaUUZxUGxNbEY0TG0yaGlmTGVFdjdtWk1hanhtSnYxcWdpN2l2QzJW?= =?utf-8?B?WGFNdUxqa3VuZXRhZGh2aDVhcFdrL0lJVXRvVGppbUo5UXMrSTBWUjJHNys2?= =?utf-8?B?NTZkcXoyVWpidUVwWktBSWIyZEw4TWdOdlhvS1pBL3NLUmxWVElOZjhDV3Rt?= =?utf-8?B?ZjE4WnFRbkFCejZOa2FwTDIxTjVEOVpnM3B3Qzh4VWNVdUpORkM3M0JnTFow?= =?utf-8?B?dXFwejF2cnBZN2FmS0c4Myt2eVc3T0lhc00rZnY2eFo2SUx5Vm1DTDErUjhy?= =?utf-8?B?NmVRNjZMSm5yeUZLNHR3RXdWMmpHUmdYRzhZdi9HSDZlc0lFQVNvVTNQY1Y2?= =?utf-8?B?am93UWZrd0J0UWZacVErdXdrT2dKVVlDdXlPRlp3ckFTUWlCQlBSNytaMUk2?= =?utf-8?B?MlZVdU5saXp1ZDhRRFlBb0M2bnhHMjRnclhFSjNqNVBmaEtIMTVUSjM3RDN1?= =?utf-8?B?aW5aMmdmMnJBSjNlR1FvNFVocUpuQmRQR0h1aWsyOXlHczZJcUd4QmgxUUtG?= =?utf-8?B?R3A0VEJKSFAxQjBrck1ac1lmZ1FoVGFmK1pMRm14SlEzbGxzNVM0NGpWVkZD?= =?utf-8?B?WkROT2lnTTBTUzAzaTA2MVRsTTNNRU44SUNPbGNBaTdKem8zK2R1N2JZdUdX?= =?utf-8?B?aFRXV3RhZ0VRUlk5RVVjWDREWjVxYXlnVW9xcUNWallVaW1iOTVOQnIya1ll?= =?utf-8?B?UnBpSFdjczNKQURrWmU5cHlCbXFDVHMyRFFybjRaSzFiNkZ2S3dqa2daTlFM?= =?utf-8?B?OGhPdC84S3dNYjVlYUVib3B0SDZyQzluQUQ0ZW5VbGlDVHpDcFgwSWFwZzRq?= =?utf-8?B?VFE4bVZNcE5Eay9EajRWZjE3T09XaXphNGV3dWZ0L0pSMmVkMzJ0cVEvT3JS?= =?utf-8?B?UEhaOVF2c1h1ZVp1T04xMHBZSnhxdFh3UW4zOWcvL2M1eVZXUWxYR0hDTFVP?= =?utf-8?B?QW1YWmRuNTZjKyswb3ExMzI4cG5JbzA1VzZaQ1JIVU9SbnpjMEI0dUtrb1Zq?= =?utf-8?Q?UVUPLx0dG2Y=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(10070799003)(366016); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ODBjUS9FSDAySk5CcWYxTFcxVUgzSlo3Y2QxdU8xZ3h2UCtxdnVheDYzM29X?= =?utf-8?B?Ujgyck9IMFlkZDNJbjJtUmFqemFzZy9qdVBXT0M3bEF5YTJwU2NnelpEMXA4?= =?utf-8?B?OW5pTGhjaitvUE8wWU93YTk5UlB4UXF6a1dFMnRFTU1xNmptYXprZkNnWVpz?= =?utf-8?B?WDVKK1NoNEIvU0ZXOTVQSTFyZ091L0sxZ1c5enZBUXhGdjhSeUlaQmRjYzNo?= =?utf-8?B?VGVoVkNxcU5rTDArR3pLU0Y1VlIwelZDZWNsSU9kMEpSVjFWV3BkZFNoOXNO?= =?utf-8?B?YU5TNmtFelhOdUVGanh3VDFuT0x6RG9ucVBJZUE4NlRGQzc3N1Nodys2NXNm?= =?utf-8?B?cStCL3MyTCtzUkt1OWgvelNtelpMWkRoNFI0WXk2WHA5Ym5xVnVkYjF3eFBr?= =?utf-8?B?YWlXNWo0bTUwQWMvVDVkN2VIcnJZVnk0aGY0VXdQdzBkbTd5NkExWUxaeE81?= =?utf-8?B?R2hHTVlvT2FJQWlBcVBoKzBoNG5iYVdyQUk5UDA2RXp2Q1cycHpEb0ErSHRi?= =?utf-8?B?cmVsUkM2bW51d3c3K2xJV1kzS08xRnAzb0YvTC9Td2g3Q3I5eXFsQU9xM3FI?= =?utf-8?B?VDlIQndHc2VJOFVTdWYvekQzUFp4TFBTdE04YUEyaGFKVXNvQjFrYmtJSldt?= =?utf-8?B?K2cwZlF5WndPOS8vVkt4aFFUWW9FUHZXdExKNHNid1VMbnVEYmxvV1NxbDVu?= =?utf-8?B?dVJCNS9jOWtYazNjZTVRY3llZlltcDFqYWJwUW9kbENOeDd4UVNCc29NNFZj?= =?utf-8?B?WDlaOWJDRThRS0hObEtERG1tcFcwOXM3ZXFOMWRSRGxRMW5vZ055Z2UrbWlJ?= =?utf-8?B?MXRHWWFhTldXVzE0VVlReUI4MHZFV0xxNjludmJSTldEaDZ6dXU4NU00cUF6?= =?utf-8?B?R3VqMnhmMlJWT1JQcEk5cmI2OGF6QXV6UkRTRWdtdGhVMVVHUVp4MnBiRC81?= =?utf-8?B?bzB2STZDUEhKYlJUbHY4YXExWlF1eXNXYjBYK2pJeEtDUlI1U1lXL2hpRmto?= =?utf-8?B?bmZFRFZNUnptRmpKMHRIMTNwL1Jod0p6bll0VGJmRzNZdWFSOUYyc0lVZ0pB?= =?utf-8?B?YzBSSHlkRGc0Tm9BbG9OZmhSejN3SnJXU1EweTgvSExUL0VwZy95R201UXY3?= =?utf-8?B?MkpEL1NGR2NrRHQrSWdvRWRPTjJFRXpUcldvVldNZWxTNk9FUHBEdnlieTVX?= =?utf-8?B?TmVPZGlGcGREZG13M0JJUG5XeDFrRXBnVC9qMFp0Yk1rSDM0RG53OEZ0UGxV?= =?utf-8?B?U3Q2ZFljQ2xrWENmSDMyV21uVGF3bGdIeU96UVhXdzdjWlNmVHh5Zloycjg1?= =?utf-8?B?YmozZGNYY0dKNWd4ZHdwRXBwY2l5QVhEaHByZy8wOUh0bzhoZkNvNnZLZkJM?= =?utf-8?B?UUlVQ2UzYzdOc3FqN3p5SkQ4ZzdQajdkc1JwbUdUTWh1V1Nicmw0Y1VTTFhi?= =?utf-8?B?bktXcG9OYllJakZwWEhTcG5oU1hmV0lBNEo0N21XTFI3L0srZmpxZ3FWbFVu?= =?utf-8?B?R3gyekRCWFNWbUdxMnNmeGNFVStBM2ZSSWxLYUpFR2p5dnRBRzBzeitqOHgv?= =?utf-8?B?eHJjcTRrdkRXV3M3dzA4ZHd1eTIwbThyb0VvY3JLa09WVVhkYzI1MlVMZFZN?= =?utf-8?B?R2Z3RUk3NUUrYzN5RW85VUFwYmhDMk5lUno1aGpXT1JudTEwQy9DUldQS3FJ?= =?utf-8?B?R1I1M1ZaRWUwOVVYZkpUL01Ub1ZUZFJzbUVCTUhTclJLV0lHWjVlaE52OG01?= =?utf-8?B?U0NaRFh4eDhHY3Z5VnA1NFhOOVVoclpjV2k3K20wTGYwMHp3Y1FGRHNDV1d5?= =?utf-8?B?a21SMnlON0NjWU9qRmNkQ1Zka0ltTXczREUyTjYzSkhQU0xnOTRLTmpIR3Jp?= =?utf-8?B?YTZzbW56cERoblNyOUoxR09lYUFsWVcyamZmOTdVZ29GczRKUkRSS2ltcHFF?= =?utf-8?B?c2xyQzdzbzFWb1huYzdKRUZrT3ZZRWVpL085Mk9UeU8wcHlqU01Fc0picFRC?= =?utf-8?B?ZERTWFJaQ2VwaGRMQkZFZzdFSzNKRk45RjBjSENwcEVKZE5LSWtZdmFXZFNV?= =?utf-8?B?QVVpYnlTMVFXOEdsbDBZRTFRQmdLZHpER2U3UEVKdCtUY0ZzeWE4cXBIRWMy?= =?utf-8?B?bC9sZExQOGN0ODhkZ0I3dDZiOWlBQzNoQ1BKbzg2dys0a2Y5alJzZ052R0JI?= =?utf-8?B?SWNweTNDMVlsb094SVZxaVh0YThGbWlqTzRyakJmbFFjZWtFbmpNNjZlblhn?= =?utf-8?B?MEN1RGFWZi9mbDBJalIvaUpjZ0xBPT0=?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: ada94e50-634b-4af0-7842-08dde6239a09 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2025 11:11:13.9739 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 06B70qFmgpLDRsmcjZGLl7zs11wnm14TcPPaak2ZF2g8ue4K1vN4bDnRJAfzQZky0ovnOe3oLFg5VsP+dEEX0u+jNmg9aj+tInRo332Rq00= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR02MB8077 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODI4MDA5MyBTYWx0ZWRfX5kPpk3MNAzHZ KvOM+nAMWx0ass1pz1fd+rmRyEU5yeBc4cjG/jkTT2ztR/QgU17HbRPsHznFwO0FBbceevXOq6C /1CXq8cIpW/OkehfJZqH25r/QJ3f+vQRlvpsHEbm92Y9R2/ivUMQ1lMXZZ08nTev3i1OSpynrcP jiGAMgyAQX+W8ikTCFHWwt9dnDd7qKqA/dq/dPkCsfV0DllKNocPRGax2scs9szir5Qo1X6f83u ijyOWVCbtoC+YNKJ7pQSpk8OiQYfY5TaIDzxAWz9PkRVRV/uG28+NUWdqTpCgl5VnGY3K3Vgf75 c/MlMoIQVU0uQtbMRs6VVSlide1r8NSVQir3d/8ZUAw0sS3C0aZTNY/h+infgA= X-Proofpoint-GUID: EgTCdF0JkpErkjMU5hgQbsBnKd-9rUK_ X-Authority-Analysis: v=2.4 cv=Coq/cm4D c=1 sm=1 tr=0 ts=68b03956 cx=c_pps a=lEAIQdlJR7AYAfTETB4wFQ==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=0kUYKlekyDsA:10 a=KKAkSRfTAAAA:8 a=64Cc0HZtAAAA:8 a=QyXUC8HyAAAA:8 a=Nl9WzMjVwZFxynAfEmwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: EgTCdF0JkpErkjMU5hgQbsBnKd-9rUK_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-28_03,2025-08-28_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.151.68; envelope-from=mark.caveayland@nutanix.com; helo=mx0a-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1756379518894116600 This helps to simplify the initialisation of the Xen hvm machine. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Mark Cave-Ayland Reviewed-by: Xiaoyao Li --- hw/i386/pc_piix.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 351986232d..8e302dc013 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -471,14 +471,6 @@ static void pc_init_isa(MachineState *machine) #endif =20 #ifdef CONFIG_XEN -static void pc_xen_hvm_init_pci(MachineState *machine) -{ - const char *pci_type =3D xen_igd_gfx_pt_enabled() ? - TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE : TYPE_I440FX_PCI_D= EVICE; - - pc_init1(machine, pci_type); -} - static void pc_xen_hvm_init(MachineState *machine) { PCMachineState *pcms =3D PC_MACHINE(machine); @@ -488,7 +480,10 @@ static void pc_xen_hvm_init(MachineState *machine) exit(1); } =20 - pc_xen_hvm_init_pci(machine); + pc_init1(machine, xen_igd_gfx_pt_enabled() + ? TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE + : TYPE_I440FX_PCI_DEVICE); + xen_igd_reserve_slot(pcms->pcibus); pci_create_simple(pcms->pcibus, -1, "xen-platform"); } --=20 2.43.0 From nobody Sun Sep 28 15:28:19 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1756379626; cv=pass; d=zohomail.com; s=zohoarc; b=kVIeL9/MXC9CgRDoQr7EhWYqC27a1leR7XgFMoAox2y13tS4WmkSq9Nimj9GSkYJ/PlxR4i/0denv0SyHnym5LYagDpGyBsbhdNLSntd3S1QfMccmRhW9ffhkAR8SqaF/2m9Rx+kHGElpkHX1Y2aaU6kTrHRZqqpfcFZyJ5Wkvw= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756379626; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=vR1vnKko24eU/idjwrdF0zDBhRAmB5/IkfWIQUv+kPw=; b=ZkSkClC2CNMkRLxXuRmtIfDA8xxRLpirjazV9eJL1poUXl49rKOuA2RhFKQB59LISk+bpDCdx5OAmZvU2qby5WoNsTaFSZ3Hzn12sEEmeBC64TwJ0C2Uek863FRYR0rn+H/uh93/2g6KWSzz+aWC+hzsO+sf+k0zqThF6plF9JE= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756379626271857.8960255846107; Thu, 28 Aug 2025 04:13:46 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uraXS-00089J-Kz; Thu, 28 Aug 2025 07:11:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uraXP-00087C-RS for qemu-devel@nongnu.org; Thu, 28 Aug 2025 07:11:27 -0400 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uraXL-00054y-97 for qemu-devel@nongnu.org; Thu, 28 Aug 2025 07:11:27 -0400 Received: from pps.filterd (m0127840.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57S7hYMt2893263; Thu, 28 Aug 2025 04:11:20 -0700 Received: from sn4pr0501cu005.outbound.protection.outlook.com (mail-southcentralusazon11021093.outbound.protection.outlook.com [40.93.194.93]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 48t7sy1pfy-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 28 Aug 2025 04:11:19 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BN0PR02MB8077.namprd02.prod.outlook.com (2603:10b6:408:149::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9052.23; Thu, 28 Aug 2025 11:11:18 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%3]) with mapi id 15.20.9052.019; Thu, 28 Aug 2025 11:11:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=vR1vnKko24eU/idjwrdF0zDBhRAmB5/IkfWIQUv+k Pw=; b=EF+HYv9zfvcZtQ6wy2T61tQ+/Ufqq0mw1/vHVXuq4TH/8UeOfmtveJN+6 e7mMXoUz4eyY056dW267j7fmj0S3hAd7hBG1/725E4RA5JzDzq2k12TubpMEMfx/ SBF/qJJgGfk3Rmmf1z4j8l9e9bxWxLUbsa6eyI8QAbpC5/VD4YrQ7OdlgKMhdyl3 XgBauaJ8LXGWsTs7WJpew+aUj4Mzab9p6kr+2T/ItymhpmqrpjnbG7806gIXDZuO rgTu5lp9epSF8/7B18VVtyrkUTZLdzAaxJ4LPOmkXjr4kHyEYfsihB4wSwHJOabu lBFMH/yctO/lGkHtA3RXAfPOry3Pg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Sxj+XaX/mUjdEJc/Bn1myRt++c2tKufxYoKP2G56VXTneCrhzqHKVsJtZXT5BbuhU2zHfCe/StwC3eqJoniUYViDGU5C/SjrmpQ2EP8ErFL2TfNe70VAYyUHRJR7zKMJ6dpT9UAhvCq/h16WJ/uwiBNT5YgbBLKA+9gVutL9a4Lh72GGuJ6x4BuJjtDRSSxgqevD4M5jFSJuAakk6gCINbJix0gMgLF/nj/2Gq0bKXYmKH30UPaKNRPue2vTfyAnPkMviZ4BltbubBRJadP9TrbEZtipUzLcD98qgc1p9NyZRHUdkOjeAjtbb0Ub8C0EQvZYB17GOfNmnYNftjmA9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vR1vnKko24eU/idjwrdF0zDBhRAmB5/IkfWIQUv+kPw=; b=AC6cJkEoAhaGucOuhlp/gNix/3+09oACUpaPaZqpOXMrWcfSjYOFYpIfgKLPT8DqpQq63fnP7dhi2/qWiqfA6rShqI9+eXdo8olt+Jn+HcqepdRSlOmml68qPJve3m+9jzHg6m7oQTwRxNw2RW/AH30c5bsMrQD3IVvPCyhcxnqiUD1FxrVY/hC3WPbtpXao+DXLv/9OFlG0/sILSN6PdNQapm/fmDnBklqSCUhfEQUolsDwF3P0WeZLQujWcx53BW0eAa3LVIO8KzlJo1sNWXHAVOInWNVhfBZP6UX8kuenMCuItjeTlpKKAjh3Z3Lc5EpKAN+4hRHhasOQxOa9Kw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vR1vnKko24eU/idjwrdF0zDBhRAmB5/IkfWIQUv+kPw=; b=wCJAiUkyRg89bdHCl8oV1KgPZ53+U8JyHnA9I9rQo6AZ4OlqILQ4w8IAXDfTQKc1VSGnyF8s3HnxI7HTFd1rFJYk6fkLB2kM6dyzFAAZt6ZfG6Ir/o5XTSEgUh+0UdtBWiVg6oHHkYFEXx5y4Lv72Z7WMrV3czEbTkVOtZwMn/EkNgNQS9yE+T32ULFw8JsOMopZlhPCQSkZcn5CaFGbqCtFuw2xM1SawQJhpuJ7NB9HX1M+2Gr+hh0Uxp6rdh010cUfpvTKBKQIe9ul1txQJoSipiGK2cxWuBx7/dgdi7fp5d4EUSW/6t9ekOCRSlj0DxG7ieqzX5xeSQ2+LjEbKA== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v7 05/19] hw/i386/pc_piix.c: duplicate pc_init1() into pc_isa_init() Date: Thu, 28 Aug 2025 12:09:48 +0100 Message-ID: <20250828111057.468712-6-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250828111057.468712-1-mark.caveayland@nutanix.com> References: <20250828111057.468712-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM0PR02CA0013.eurprd02.prod.outlook.com (2603:10a6:208:3e::26) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BN0PR02MB8077:EE_ X-MS-Office365-Filtering-Correlation-Id: 6555cc63-d666-41fb-e219-08dde6239c6e x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|10070799003|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Wm1PN2k1bFJIR2lBSHE1bFltRUVVV2FyWjhaZ1RFWXQ1alRjdWJpWGNnSFdV?= =?utf-8?B?NFFKamZtRE9UeTI5elpqamlvM3FsNW84d1VNYWwwdDNZL0x6ZkVKUzJGcjlp?= =?utf-8?B?VElONEVuVUIzVmlxcVpNYkQ1dEJSR0ZKVUtTSXhPaTBlQjFOY0NQejZJZ3pj?= =?utf-8?B?RDNrbTliZi9QMlpPdDM4U3N2QnNYUG01enhEQWExQjJGV2dUMzc4MUN5R2ZZ?= =?utf-8?B?K2xGQk9CR3BCdWQ1LzJvZThJdSs2b3JJZGJXTTFpT000Ym9QVXZWTlpIQ3Zs?= =?utf-8?B?NHRHSUpxSk5sU3FhVXpyZjVFZ01sZWI2bUEyYzVLUGkrd1ZNNUsyaTJJQjFS?= =?utf-8?B?cU05N0hkUGtiQkpzNCtXNWxCWkVvKzZ0a2t1eGtKV0JFTVc4MzdCQk5rQVZu?= =?utf-8?B?RGRpdEg4dWFGZG5XaS9RSVpkaFVpV2NmUjhRS1ZNUHk5SXJNUnJJdEdJcUtn?= =?utf-8?B?cmhQR0dJYzc1cU14NTZuNEVDYVRHVStkcTZ3UVhrRE01M3F5K0RQQzhFbzE5?= =?utf-8?B?UkVRZm9hVkltRi9iZUVYQnJTL1RQL3JUUS9wM2ZiMVU0OEY0aCtIaWlCdDJV?= =?utf-8?B?dnFBUlVKSS9uVTdqL2lKSWEzUzRDR29VN0l4MWlTNllsZkd6WjIyM1hUQzV4?= =?utf-8?B?SnBLcTVjQXRFMXpGT21NaXVMY05LTjNqNXU1TTZyaW1WeVFrcHJiejZnYUJz?= =?utf-8?B?S29sSTV6RHFCQ1c3aStJUXBQYnlLeTJ2QUpQQlJmNXVlVmhXckozUmFVbExy?= =?utf-8?B?ZE9NdVlGNUpQMG13UUZZRUFCR3BYaU41UmZyR0E5T1FmeVptWGl2UWQyNnF5?= =?utf-8?B?bWZxR2NkUktxcTc3MTM5TFVIekk4NG9FanhhOXcxLzFKdWQyc0k5NTlNbCtC?= =?utf-8?B?ZkNmMkRCUFV4VFFFcG56QXBuMXJValkxZ1JWVFFqSVFhTFduWFBnSEswalRY?= =?utf-8?B?eDlSS0JmRlpyQlBGb1B1Vi96dUNoOVNqQllWeG5vdW5sU2V1a2NKLzA5eU96?= =?utf-8?B?Wjl3TTNqbWRBQ1lTWmxoSHpLUGRES053VlNxek96MzRMTnREZDBzL3dGOXdz?= =?utf-8?B?eXR6WE9rM243VmNsR0hNTmVDS3RPUDFiTUZON2FxNkZ4bml5MkcvQmdvR2x5?= =?utf-8?B?d3RkWGFONUQxT2w0KzltT2Q0U3NSeHM4bUU4ajJsdFJmR3UzN016RVlEWjNF?= =?utf-8?B?RXJhb2IzR0I0S3hQM0VoY3hIRDV6bzdGeG1OYWdsUnNWQ3c5bnFGVkFPQm1h?= =?utf-8?B?UkdCTjVIQUJqNWsxUlZ5L0VtR0hDVmpPdmt2WkRjZXBvWnhvLzl5RGZyTWw2?= =?utf-8?B?Y0VGNjRuMDFhdWhrazg3cFJxNzAzL1NVbGNCRHIvMS84K3JqeFVtSlpHUm01?= =?utf-8?B?L0k4WFhxTTJYMGUzcXY0eFp5YzE1anRCNVhWemRkMUU2M1k1UGtLOVd1cDQy?= =?utf-8?B?STc1RzFkTnVSVjM1aVVGRFppbXhlZktUMy93Vk1vWkxCYVpUYXBaL1U4anU1?= =?utf-8?B?bXNDYUZGcW5Rb2ZMV1ZLVnRzUXI5L2tVdTBtTHcwamxpcUJPc0tzS0ZLbnN1?= =?utf-8?B?NXZsVGNJSGFBdzQxYzdGcHBrMlVHeGRTaTFwZDZCbCtDRXlqV25FMjlFbHdw?= =?utf-8?B?QlZUQlhpdXUzOFZMN012RlBGbHFzUW5ORUNHTVpra2FVOXFpN2pxc0hmdjgv?= =?utf-8?B?QTVTYm16Zkw4Mlc0bEY0c3oybWk3N2Z6VWN2ZGFQb01HcWtuTDI1bklFZjhh?= =?utf-8?B?NjBkOEpNOFZxUzQ2ZnhkMlNoT3pvbTNGOUVkaGM5YTBmZUlUS0daeVNPaDVl?= =?utf-8?B?eDkrWnBqYXNadS9kQkk2WjJ0UHVnRzRvY2Z2L0tpNTAvQlZXZVNNYTNTVWFM?= =?utf-8?B?S3pRMDhpcUt1VVg4bnJkUXBlSTNuQWZsQnRPUjkyTThBWG5tSXkyelcyMEFN?= =?utf-8?Q?R0rHwA53bpQ=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(10070799003)(366016); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MFN0OXlrWnJUOFprNDBtbXZ0YVJrOVN1NFg5Z2xqclo0QlNkL0c3b0cwWDZ6?= =?utf-8?B?amdEdm8wcVJEMCsrSzhFTFNsbVNxbnF6Vmh6b1d3OGNEajRJUTBQVWF4N3RM?= =?utf-8?B?aDZSTFpKemI4RGQ2bXBDaDFaNUtXSWs1Mkhsbkg3c3hoRHRQbm9td0dnRkph?= =?utf-8?B?YlBkb2lKYlBFd1FybFo5bmVFTW5XbjBNN01pMTk0U1gzUVhmV3FRSDdVUU8y?= =?utf-8?B?ZHhCRXBuOEltblFBSHA2RzVCZXVEaWtFZE1yQzNXaWQrLytTdUExMFYwVWR2?= =?utf-8?B?bjRkMGhrMStnTFVKY3hKSzlDZHpRWFU4bHlmOVVoU201T3NjTVNrTGxkcVlK?= =?utf-8?B?ZDg4S1NoY2JqV2RrY2ViWGhqQUNMYis1bDdVWWpDeUgyek1sdUdnczNQL210?= =?utf-8?B?VldVbnJCVXB6ekdVa2tiWC8rS0hpeEFEcFFrNFlvREsvRXZQdnp3WXpFaHRF?= =?utf-8?B?VlZPSWpSODN3RVdKOEJmSmdqVkUwUk5QdUtCQjRSODJlL0xWcUdOZnMxWE5H?= =?utf-8?B?ZW43VkZ1alRiVVJEc04rNEhEYWJOTjF4ellDNldDRjBreS9sbXpRZnpaN3BM?= =?utf-8?B?czJMeWxrUU80emMyOEo1Vk83dVErVHEvbllvMVlYUWJKQ3RaMkRxL1N0Q05S?= =?utf-8?B?Zll2RjhHYUtIejNPSWFHWmR3cCtGcXNZeGpQVjFENVlvVzFjelNGaUU1QnZB?= =?utf-8?B?WXlVMy80UUNtNHA2VjM4cGlmS2NGVCtFVGY2WlhqeHV5VjhhZDhjQisyblZv?= =?utf-8?B?eENRbDgwSWExVDhpZ0tlRWRPMmgvZjQ1Q3V3MHJnVFZhM01IVFRGRm1aZk1E?= =?utf-8?B?UllRVUY2dmg1S3lobUd0STFpK21XbEF2WW9JeFBmTVFtODNNRithcGpSMkdG?= =?utf-8?B?ZmplZ3V2c21Ca2pNeU55WG1CRzNEcHlRK3pMRk56bkh0M2VTcDRBR0pud1NS?= =?utf-8?B?K0ptVHRxaG41dUFvTCt1eHRRcHZSWmY1VUlXUGVUVG9KWVl2bkNYWGdMVUha?= =?utf-8?B?UHJ2OWpxcFYveHpobXovUDQ4YmtpaVhkcXZsUHh1aEY1MTRCMDIyTWc5dlRt?= =?utf-8?B?OUtQdVNOZnRKbHc3RXcrTER3U245S01LcnI1K2xKY0Y2UVhvdSs2bTFDMHpV?= =?utf-8?B?VUJuayt4cjloWndWU1ZVRDNhSE1jYlkvNnhTdklQaDlzVS9XaENvdXJTNWQ4?= =?utf-8?B?THdTeGZGQkhYbGVwQXIzL1ptZndlZG5TU3B3UDE5dExXc3VWdDEzZ3EvTVFI?= =?utf-8?B?NlZ5aXdTSEpBdHpPVXQ1UHpGNyt4bTZKNU9jZ3JxRGN4OXRwQkhOT0FmbVVY?= =?utf-8?B?SW9NTGxCQjdiMk9WUzVtd3psQmNKYUd0ZHZRWnlRcUJvcHVHL21HMktTTmZv?= =?utf-8?B?V0xzWVRJSVhUZHZpemFEYURmY3VsTzJSaGJFQkFub0trVTlwUy95YXkwM1Bw?= =?utf-8?B?bkhVT1MySjNkbDl1NW9tQ1hZUHllYkxDeWpEZmRmM1dBUytNZDZuQkcyYXBr?= =?utf-8?B?YWk2YmlHSm5UTXVqb0llNUNnekxrTEY1YmVjZXRQVisyTGJ6WWxSSG0vaDJK?= =?utf-8?B?elRkRDVYZDJXaTNJSGwrVWFTVlh6QVdKdkphRi9VSlEwTFpQYVdXQkJtUkEw?= =?utf-8?B?bmdtVExSMDBhVnM1ZVgwTHdOd0NjRzZiSkVtTEh5c1JoM1B4S0YxcUZYUzcw?= =?utf-8?B?UHFob2RBb2NJYktPMGVrYUpNOURuY3FIYU55czB4RUJEbExWV2pSN0QrdEMr?= =?utf-8?B?RnFBSDEvV1BWUVNzZGVDUmRLVTVUUXNBSUttaUZyUm41REJBT0t4WFBaY3VW?= =?utf-8?B?aFZFRGpiRmUwMWtlclBFOHdJdE84SDcrRVB5RWZacFhJUU9PL1hqMklNVUxO?= =?utf-8?B?RlRrU3NVUHRYMWNEWkpQYklsUHlNdU9KVmZjVjRYdGNvMTBvMEU4K1hlR01z?= =?utf-8?B?KytqdHdDQmdwcHVNQnc2aDYyVnpuR0pMRFMyYzRZOEhrdnNvbXdLRmFYdzUw?= =?utf-8?B?SWdnTmRHVUZaYzNLYmhwQVluT3VxYm1NajdEN08zODd2WWZmRURyWjhqZWVp?= =?utf-8?B?cyttOWVmb00xaFlxY0Q1OWlYNlFIdVBuMlJGNWF1bDdmNXgrVkwwZ1luTlZD?= =?utf-8?B?ejRDZXZTTjJ3YXRjc3RPRjhwcWpPNHdCYklTTFppQmk0THVMNjZseitRZVB0?= =?utf-8?B?TEdIMU45T3ZxZXEwajlja2thME1yNGs5TlZsVHhxTllQdG5hV1FVUTh2T0R5?= =?utf-8?B?WGp0dXdxbjNaOENTekNEeFhMM3FRPT0=?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6555cc63-d666-41fb-e219-08dde6239c6e X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2025 11:11:18.1392 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5s2qAWqirDSh/slF+MduUHyCmP9la7yRKZM5yH/3jqVPAb041tn/CF/BGsVFw+h6gi+FMIjz8KIZMvRkTM9WlIpsbOmuPjJJQImR7NYZ+mk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR02MB8077 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODI4MDA5MyBTYWx0ZWRfX+LHkXAdlRHpZ tU87DRW+les5Yp5Bi7qPq+2mrpiEsUc4ayaX+ClDODkY8Uhb/55y67+zUVzCEtA+bf5zFhl4N3S Ytowqr+1zZJpWx87TNVpMMTgSLlMTfA+rykcZqg+hNs+MwrNTYWI1m3d0GcWCJ2irvJaOVuhbDh opNXXcyA8OZwhsZ+V0Yti8/YmgaFs49AckQQ2PLmp7UlDjWpIrZHEvJ/zKGY8beqhkiV04bQPVN QAfeLCfbH11mm09hivLFbv9mqhHFmSny4FIXDOmjVbCEYhEOk1xRiLtGfcllu6HbjDtEEMDWGL4 452RtXU26DTiPjXiLDsukTtOkFJFa6xusOqdtBZyI5iTiiiSO0jajzgNhMor/g= X-Proofpoint-GUID: ZWoiVApevml2WCLg80HDrOTLUL7KDg_n X-Authority-Analysis: v=2.4 cv=M/VNKzws c=1 sm=1 tr=0 ts=68b03957 cx=c_pps a=G8VycjxW3wO8/D/xgNJDKg==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=13zc6MqDSUu7KqF3LJsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: ZWoiVApevml2WCLg80HDrOTLUL7KDg_n X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-28_03,2025-08-28_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.151.68; envelope-from=mark.caveayland@nutanix.com; helo=mx0a-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1756379628619116600 This is to prepare for splitting the isapc machine into its own separate fi= le. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/pc_piix.c | 275 +++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 274 insertions(+), 1 deletion(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 8e302dc013..60bf18c680 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -435,6 +435,23 @@ static void pc_set_south_bridge(Object *obj, int value= , Error **errp) #ifdef CONFIG_ISAPC static void pc_init_isa(MachineState *machine) { + const char *pci_type =3D NULL; + PCMachineState *pcms =3D PC_MACHINE(machine); + PCMachineClass *pcmc =3D PC_MACHINE_GET_CLASS(pcms); + X86MachineState *x86ms =3D X86_MACHINE(machine); + MemoryRegion *system_memory =3D get_system_memory(); + MemoryRegion *system_io =3D get_system_io(); + Object *phb =3D NULL; + ISABus *isa_bus; + Object *piix4_pm =3D NULL; + qemu_irq smi_irq; + GSIState *gsi_state; + MemoryRegion *ram_memory; + MemoryRegion *pci_memory =3D NULL; + MemoryRegion *rom_memory =3D system_memory; + ram_addr_t lowmem; + uint64_t hole64_size =3D 0; + /* * There is a small chance that someone unintentionally passes "-cpu m= ax" * for the isapc machine, which will provide a much more modern 32-bit @@ -466,7 +483,263 @@ static void pc_init_isa(MachineState *machine) exit(1); } =20 - pc_init1(machine, NULL); + /* + * Calculate ram split, for memory below and above 4G. It's a bit + * complicated for backward compatibility reasons ... + * + * - Traditional split is 3.5G (lowmem =3D 0xe0000000). This is the + * default value for max_ram_below_4g now. + * + * - Then, to gigabyte align the memory, we move the split to 3G + * (lowmem =3D 0xc0000000). But only in case we have to split in + * the first place, i.e. ram_size is larger than (traditional) + * lowmem. And for new machine types (gigabyte_align =3D true) + * only, for live migration compatibility reasons. + * + * - Next the max-ram-below-4g option was added, which allowed to + * reduce lowmem to a smaller value, to allow a larger PCI I/O + * window below 4G. qemu doesn't enforce gigabyte alignment here, + * but prints a warning. + * + * - Finally max-ram-below-4g got updated to also allow raising lowme= m, + * so legacy non-PAE guests can get as much memory as possible in + * the 32bit address space below 4G. + * + * - Note that Xen has its own ram setup code in xen_ram_init(), + * called via xen_hvm_init_pc(). + * + * Examples: + * qemu -M pc-1.7 -m 4G (old default) -> 3584M low, 512M high + * qemu -M pc -m 4G (new default) -> 3072M low, 1024M high + * qemu -M pc,max-ram-below-4g=3D2G -m 4G -> 2048M low, 2048M h= igh + * qemu -M pc,max-ram-below-4g=3D4G -m 3968M -> 3968M low (=3D4G-1= 28M) + */ + if (xen_enabled()) { + xen_hvm_init_pc(pcms, &ram_memory); + } else { + ram_memory =3D machine->ram; + if (!pcms->max_ram_below_4g) { + pcms->max_ram_below_4g =3D 0xe0000000; /* default: 3.5G */ + } + lowmem =3D pcms->max_ram_below_4g; + if (machine->ram_size >=3D pcms->max_ram_below_4g) { + if (pcmc->gigabyte_align) { + if (lowmem > 0xc0000000) { + lowmem =3D 0xc0000000; + } + if (lowmem & (1 * GiB - 1)) { + warn_report("Large machine and max_ram_below_4g " + "(%" PRIu64 ") not a multiple of 1G; " + "possible bad performance.", + pcms->max_ram_below_4g); + } + } + } + + if (machine->ram_size >=3D lowmem) { + x86ms->above_4g_mem_size =3D machine->ram_size - lowmem; + x86ms->below_4g_mem_size =3D lowmem; + } else { + x86ms->above_4g_mem_size =3D 0; + x86ms->below_4g_mem_size =3D machine->ram_size; + } + } + + pc_machine_init_sgx_epc(pcms); + x86_cpus_init(x86ms, pcmc->default_cpu_version); + + if (kvm_enabled()) { + kvmclock_create(pcmc->kvmclock_create_always); + } + + if (pcmc->pci_enabled) { + pci_memory =3D g_new(MemoryRegion, 1); + memory_region_init(pci_memory, NULL, "pci", UINT64_MAX); + rom_memory =3D pci_memory; + + phb =3D OBJECT(qdev_new(TYPE_I440FX_PCI_HOST_BRIDGE)); + object_property_add_child(OBJECT(machine), "i440fx", phb); + object_property_set_link(phb, PCI_HOST_PROP_RAM_MEM, + OBJECT(ram_memory), &error_fatal); + object_property_set_link(phb, PCI_HOST_PROP_PCI_MEM, + OBJECT(pci_memory), &error_fatal); + object_property_set_link(phb, PCI_HOST_PROP_SYSTEM_MEM, + OBJECT(system_memory), &error_fatal); + object_property_set_link(phb, PCI_HOST_PROP_IO_MEM, + OBJECT(system_io), &error_fatal); + object_property_set_uint(phb, PCI_HOST_BELOW_4G_MEM_SIZE, + x86ms->below_4g_mem_size, &error_fatal); + object_property_set_uint(phb, PCI_HOST_ABOVE_4G_MEM_SIZE, + x86ms->above_4g_mem_size, &error_fatal); + object_property_set_str(phb, I440FX_HOST_PROP_PCI_TYPE, pci_type, + &error_fatal); + sysbus_realize_and_unref(SYS_BUS_DEVICE(phb), &error_fatal); + + pcms->pcibus =3D PCI_BUS(qdev_get_child_bus(DEVICE(phb), "pci.0")); + pci_bus_map_irqs(pcms->pcibus, + xen_enabled() ? xen_pci_slot_get_pirq + : pc_pci_slot_get_pirq); + + hole64_size =3D object_property_get_uint(phb, + PCI_HOST_PROP_PCI_HOLE64_SI= ZE, + &error_abort); + } + + /* allocate ram and load rom/bios */ + if (!xen_enabled()) { + pc_memory_init(pcms, system_memory, rom_memory, hole64_size); + } else { + assert(machine->ram_size =3D=3D x86ms->below_4g_mem_size + + x86ms->above_4g_mem_size); + + pc_system_flash_cleanup_unused(pcms); + if (machine->kernel_filename !=3D NULL) { + /* For xen HVM direct kernel boot, load linux here */ + xen_load_linux(pcms); + } + } + + gsi_state =3D pc_gsi_create(&x86ms->gsi, pcmc->pci_enabled); + + if (pcmc->pci_enabled) { + PCIDevice *pci_dev; + DeviceState *dev; + size_t i; + + pci_dev =3D pci_new_multifunction(-1, pcms->south_bridge); + object_property_set_bool(OBJECT(pci_dev), "has-usb", + machine_usb(machine), &error_abort); + object_property_set_bool(OBJECT(pci_dev), "has-acpi", + x86_machine_is_acpi_enabled(x86ms), + &error_abort); + object_property_set_bool(OBJECT(pci_dev), "has-pic", false, + &error_abort); + object_property_set_bool(OBJECT(pci_dev), "has-pit", false, + &error_abort); + qdev_prop_set_uint32(DEVICE(pci_dev), "smb_io_base", 0xb100); + object_property_set_bool(OBJECT(pci_dev), "smm-enabled", + x86_machine_is_smm_enabled(x86ms), + &error_abort); + dev =3D DEVICE(pci_dev); + for (i =3D 0; i < ISA_NUM_IRQS; i++) { + qdev_connect_gpio_out_named(dev, "isa-irqs", i, x86ms->gsi[i]); + } + pci_realize_and_unref(pci_dev, pcms->pcibus, &error_fatal); + + if (xen_enabled()) { + pci_device_set_intx_routing_notifier( + pci_dev, piix_intx_routing_notifier_xen); + + /* + * Xen supports additional interrupt routes from the PCI devic= es to + * the IOAPIC: the four pins of each PCI device on the bus are= also + * connected to the IOAPIC directly. + * These additional routes can be discovered through ACPI. + */ + pci_bus_irqs(pcms->pcibus, xen_intx_set_irq, pci_dev, + XEN_IOAPIC_NUM_PIRQS); + } + + isa_bus =3D ISA_BUS(qdev_get_child_bus(DEVICE(pci_dev), "isa.0")); + x86ms->rtc =3D ISA_DEVICE(object_resolve_path_component(OBJECT(pci= _dev), + "rtc")); + piix4_pm =3D object_resolve_path_component(OBJECT(pci_dev), "pm"); + dev =3D DEVICE(object_resolve_path_component(OBJECT(pci_dev), "ide= ")); + pci_ide_create_devs(PCI_DEVICE(dev)); + pcms->idebus[0] =3D qdev_get_child_bus(dev, "ide.0"); + pcms->idebus[1] =3D qdev_get_child_bus(dev, "ide.1"); + } else { + uint32_t irq; + + isa_bus =3D isa_bus_new(NULL, system_memory, system_io, + &error_abort); + isa_bus_register_input_irqs(isa_bus, x86ms->gsi); + + x86ms->rtc =3D isa_new(TYPE_MC146818_RTC); + qdev_prop_set_int32(DEVICE(x86ms->rtc), "base_year", 2000); + isa_realize_and_unref(x86ms->rtc, isa_bus, &error_fatal); + irq =3D object_property_get_uint(OBJECT(x86ms->rtc), "irq", + &error_fatal); + isa_connect_gpio_out(ISA_DEVICE(x86ms->rtc), 0, irq); + + i8257_dma_init(OBJECT(machine), isa_bus, 0); + pcms->hpet_enabled =3D false; + } + + if (x86ms->pic =3D=3D ON_OFF_AUTO_ON || x86ms->pic =3D=3D ON_OFF_AUTO_= AUTO) { + pc_i8259_create(isa_bus, gsi_state->i8259_irq); + } + + if (phb) { + ioapic_init_gsi(gsi_state, phb); + } + + if (tcg_enabled()) { + x86_register_ferr_irq(x86ms->gsi[13]); + } + + pc_vga_init(isa_bus, pcmc->pci_enabled ? pcms->pcibus : NULL); + + /* init basic PC hardware */ + pc_basic_device_init(pcms, isa_bus, x86ms->gsi, x86ms->rtc, + !MACHINE_CLASS(pcmc)->no_floppy, 0x4); + + pc_nic_init(pcmc, isa_bus, pcms->pcibus); + +#ifdef CONFIG_IDE_ISA + if (!pcmc->pci_enabled) { + DriveInfo *hd[MAX_IDE_BUS * MAX_IDE_DEVS]; + int i; + + ide_drive_get(hd, ARRAY_SIZE(hd)); + for (i =3D 0; i < MAX_IDE_BUS; i++) { + ISADevice *dev; + char busname[] =3D "ide.0"; + dev =3D isa_ide_init(isa_bus, ide_iobase[i], ide_iobase2[i], + ide_irq[i], + hd[MAX_IDE_DEVS * i], hd[MAX_IDE_DEVS * i += 1]); + /* + * The ide bus name is ide.0 for the first bus and ide.1 for t= he + * second one. + */ + busname[4] =3D '0' + i; + pcms->idebus[i] =3D qdev_get_child_bus(DEVICE(dev), busname); + } + } +#endif + + if (piix4_pm) { + smi_irq =3D qemu_allocate_irq(pc_acpi_smi_interrupt, first_cpu, 0); + + qdev_connect_gpio_out_named(DEVICE(piix4_pm), "smi-irq", 0, smi_ir= q); + pcms->smbus =3D I2C_BUS(qdev_get_child_bus(DEVICE(piix4_pm), "i2c"= )); + /* TODO: Populate SPD eeprom data. */ + smbus_eeprom_init(pcms->smbus, 8, NULL, 0); + + object_property_add_link(OBJECT(machine), PC_MACHINE_ACPI_DEVICE_P= ROP, + TYPE_HOTPLUG_HANDLER, + (Object **)&x86ms->acpi_dev, + object_property_allow_set_link, + OBJ_PROP_LINK_STRONG); + object_property_set_link(OBJECT(machine), PC_MACHINE_ACPI_DEVICE_P= ROP, + piix4_pm, &error_abort); + } + + if (machine->nvdimms_state->is_enabled) { + nvdimm_init_acpi_state(machine->nvdimms_state, system_io, + x86_nvdimm_acpi_dsmio, + x86ms->fw_cfg, OBJECT(pcms)); + } + +#if defined(CONFIG_IGVM) + /* Apply guest state from IGVM if supplied */ + if (x86ms->igvm) { + if (IGVM_CFG_GET_CLASS(x86ms->igvm) + ->process(x86ms->igvm, machine->cgs, false, &error_fatal) = < 0) { + g_assert_not_reached(); + } + } +#endif } #endif =20 --=20 2.43.0 From nobody Sun Sep 28 15:28:19 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1756379593; cv=pass; d=zohomail.com; s=zohoarc; b=GR6mjJ6t4YDxDfamQ3pR6O8PCSScpHbKpyoz62BQPAt1W3wi6vPAQcG9ZqcelU3RICXRHkXPcQndhqmk9Wi/1fihlftvu0vrj7Tz8LWSkFP3Opbcw+uftWls2cBhTx0NYEf19yGyYGuogsY+bAokdoa1Goe1U0x6qTnbnpjp5Zc= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756379593; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=+B25GMUTHHEBM5QT7HQgM4UJYcL7SI8/Cf5f3sh7yF0=; b=n8Q382nWegY7niG3MtshHcOogfD9MXcSNUchHoLiOSfztU7YimNr0/LTxtRE6qqOXj7WXIXqJ7tZOy47r0dzgNKQHOIsWo+oN2+y88WnzmNytUIzEP9XCxHdFJ0UwkV0cuI+DbMsoPxQXQQ6Opkh0jEY4yiMSM9fV10sioT5efw= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756379593422865.5865159715904; Thu, 28 Aug 2025 04:13:13 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uraXS-00089K-Lx; Thu, 28 Aug 2025 07:11:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uraXQ-00087O-Nc for qemu-devel@nongnu.org; Thu, 28 Aug 2025 07:11:28 -0400 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uraXO-00056D-60 for qemu-devel@nongnu.org; Thu, 28 Aug 2025 07:11:28 -0400 Received: from pps.filterd (m0127840.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57S7WhbK2893431; Thu, 28 Aug 2025 04:11:23 -0700 Received: from sj2pr03cu001.outbound.protection.outlook.com (mail-westusazon11022080.outbound.protection.outlook.com [52.101.43.80]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 48t7sy1pg1-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 28 Aug 2025 04:11:22 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BN0PR02MB8077.namprd02.prod.outlook.com (2603:10b6:408:149::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9052.23; Thu, 28 Aug 2025 11:11:21 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%3]) with mapi id 15.20.9052.019; Thu, 28 Aug 2025 11:11:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=+B25GMUTHHEBM5QT7HQgM4UJYcL7SI8/Cf5f3sh7y F0=; b=trv8y9nNosCWAxlWV0QIE/rbXfw2havTt/+7oBC2GlhuX4v23gmtF11Gf sWkdr8lThoME8L++WdgKcCzPE1ciScgKi3r9RHTmoT0g3Gl/V7S96Hec8wYp+eIb umAf/APffGzCwgG4Fnst2nIEExuYc+Xej2+YV7MNJfv5rKg4AOtzdGoOaOE6Pgkk zYI6Zt9QKFBFlSsvYxqUWDCcFI9SwZm+wbE3fgTfy7fUMJVFelQCAD63prPyz/WE j+I9hU6PW4wbD0f9OZcCtfG7LVCaLrqwIMR49PrXyOzWGj5W40EIytqr91whguuI TnsDUDFbNcbBYWcbFWtbhXJFnKqYg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cTjTGZuj+e/9PRsYTwoV9/7l1KH1t4taZrsEpLB1LVPN9jBAAjVOzXQ9bVHu+/NmSucuRmyQFDrEVaQSeLIjG6m4vhJYxsfRFWndAqGdJbqeEnJYYV3ek5WmAGSyYvUhWkD17CRbF80mZ8VjZqkjCoC9VJZg4YO7PtcQnSuGYuOBfXLKn8fyXCvDp0VljCSt0DgIMNwxFubLG4iTEdHUXDto0xBEzddWOHG3W4AL4xeG1AL3xXjEtmQfsk6xfanvm5ME4FbYTie5qUmF042RfcNEwf54cltSi/Fb7Rfp+Nj5rB5NOI/wwOx6nVIXFv3aEoeSw+SpsFfG2ZLfObdFcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+B25GMUTHHEBM5QT7HQgM4UJYcL7SI8/Cf5f3sh7yF0=; b=AkVXHzeECvfkhvBy6KtWXMeFAC2zpm5Mb5fpTCLgKEe6cacs9aWpTn3vWOf8IE3LzQtD4ZbMqSm8Gpyt2B/mQdk1gRpbW/V+JP7/CVj/AbPK7lDX07oijbzr6ayYu+X+mmaPYkHr7z8Oohy7jJvnye0Il9YhKvbOXXvWF6Ys+3teMIrkBuCnqLcw6q1DlrSdvfSYPoeSRl0/jmuqvEt+2FEzeXHVR9WpTFkkPzwnTnCziogVyJ/WG4aA0tBrr2Eh2wKMYvqdSxnfNviCJrxb53x7OYBiGnJHGW1XkhLCej6kKuGnCO38nYjT0K+te48aGtkeVAZAgFnGTZg+9kU2ng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+B25GMUTHHEBM5QT7HQgM4UJYcL7SI8/Cf5f3sh7yF0=; b=p0mqvV4uzEu3p8LwlbxXl+o77VZujqOQaxWbyxeGBtZMqH6JjocCdFqpcYKMWff6alUWN+ZJ37j1HU1Ou86hsxCdGzg+as5/XLiUvddL4rDuX7XEsdvBnUGrJNVj5o8AbprV5SYvFLTyJBjULw8doj7wFSyIFYEOd9aTAS3PqJE1IuONGExDbbJIdwpViv0F9RL4OQjnp3nawVyZVQ+dFyi8cpvCaRdr8j3RJeDXL0UowQ9cHCyR/O1ooTOzXiS6qDLDmrOA7aigbhWMRsOV72ANL4XeBuBQjdxxDQTaudmM9rCk397kRwXJ0KaoJevCsUufLme5/VhRUgrDmHUPkQ== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v7 06/19] hw/i386/pc_piix.c: remove pcmc->pci_enabled dependent initialisation from pc_init_isa() Date: Thu, 28 Aug 2025 12:09:49 +0100 Message-ID: <20250828111057.468712-7-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250828111057.468712-1-mark.caveayland@nutanix.com> References: <20250828111057.468712-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM9P192CA0015.EURP192.PROD.OUTLOOK.COM (2603:10a6:20b:21d::20) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BN0PR02MB8077:EE_ X-MS-Office365-Filtering-Correlation-Id: 4cbe6300-f268-4212-64f1-08dde6239e65 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|10070799003|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?M3RUSzY0RUJvaEJOQTcwQWR3KzQvZTRqSGs5RGpXeEh4Q0hhZFdWbDF5YTlV?= =?utf-8?B?Z0oybmZNeXNGWU9vVWJvYTZqU0Z5NnBtQ25ZQ3VQcnl5bkE3WnRLcTdVZmhh?= =?utf-8?B?VG5rcXI5N25pZTVJVksrU3NaMXZmNmNneURxRXhTWk5XM05qRXR5L01ybGIr?= =?utf-8?B?UWtqZnlVT1ZadndXajBiZ2VlYlc5eGlZL2V0SVphc1RYcjFMdGZaQjZENGYx?= =?utf-8?B?NHRDSmNSZjBwQ29taTdORlBtSHJxbFdVSDhEVG9oYmNIK3VGc0N6TzR3UlNz?= =?utf-8?B?L09NZFpmcTgrTjhPUnFNejVVN0crbkpxenlkbmRxRjF2Z3VyZWt3R1QzMngw?= =?utf-8?B?M21NRVRPWmRudVBlVXNkYkZkRExIM1huWjU5V2QrR2p5VnErZXlRcDY2QXZi?= =?utf-8?B?VXF4VWFjQjRPaXA2NVV4WDVVTG1qcEpaQVRabDZHazlHWEtOWGdzbTRzNnhm?= =?utf-8?B?QWN1MEo5eDh3TFBFSmFJOUZWaisyTUdWSkZFZ28zYThlMkVhL0NRalJpY3pt?= =?utf-8?B?dnorOWpiMVFldCtPaCsrZkQvYzhzSWQxRUFtcFdUMEtqbjlrTUZaUGVPNGRz?= =?utf-8?B?TUlSK25wNmd5S1poQmkyci96TUp1SHJZdWdaaE5IcFBlUzJhRVc5VU9aUVhI?= =?utf-8?B?SFZUdXhWeEtUQlUyb2JsWDZsVEdVenFnUFU2bzQrRHZTWlp4NlNrSnBBSkhB?= =?utf-8?B?ajZ0ZlFFUW5ITFBDNVp6d0pQWWxYMHRJTExTR0swd3VERVpxSStZRVY2V201?= =?utf-8?B?bnJMTzdmNlQ1bTBCOTRnK1M4aXlMR3ZGa1Q1YTdvdW00d1ZRaWo5TlU3VE1w?= =?utf-8?B?ZHhQcXJzS25jNWpOcnNZa0tQL2lWQXVVVHdTb2dIcnhmbVY0cFBmWHlKNTR6?= =?utf-8?B?eVJIYTArc2s5dHN0QUJWT0NkRHNaWlIrajZvcVVReUZjaGo1RkM3QjgzYWtk?= =?utf-8?B?TTZKQVpUcGhZdjJ2L0k3QUZDdDNyQzVVR2Z2VmcwYUhZcWhHZFNSNkZkRTd6?= =?utf-8?B?K3R2azZoTjNpeUVneFc0ZjZBVkxUSURQOFQwN1NJWkNEbHRKMXA4THFOQy91?= =?utf-8?B?ZzFHVjRHM0dpT2hMRFJYWWcyUEkxUktRMUpRZUM1bVQxR1l5aUw2bXFIclNj?= =?utf-8?B?Z1Z3WVRRNko3NXY3dEpscXJCUzM3S3pHdEtIamVQMzZ2dHV5QldMWEZFTUVs?= =?utf-8?B?SGJqMzNUNmdhRFVSVFIrWlFsNStNOXltQUkyWGkzSUhVTUU4b21wa3hXNUNU?= =?utf-8?B?aWdONUJVTjRuU0tqZko3R3lqNjJ6Rk5EVjkzNllIRFNFK0tnRVRWQUJjdDNo?= =?utf-8?B?cEJVM09VN3ltOWtRcm5ZWUdTR3V2WkR5c2ptYlBhL0xxd0pKZFNvMnJVLzNK?= =?utf-8?B?U3UwS2xCQzlnM0Zlb09ibFBpVy9jWHVMaGFVRU1IMkhRS05uYmtBWW9KeHJ1?= =?utf-8?B?UGxoaktMUDlIUytBNjFabnhTdnpMR0ZwWDlidlNBTmJtQTJqaEREdTNwUGoz?= =?utf-8?B?RGF5M21LNGYxVmpYaE45LzQ0ZXhLZExiRVoyQ1VFclI2d25MVmRIZHQ4eDVV?= =?utf-8?B?N1RVbHdiSU5CU3dzcGlnT0ZtTEdmTmpiaERHL1IwS1paS2JLVkNUUFk0YUVK?= =?utf-8?B?SWtIRzhJdUZVMzd0ay9kejJZaTRTWU5RNjZHYmp4TjFLQ1JiYnVkZmprL2hl?= =?utf-8?B?V3FpYmdvcUxsVEljeUJubG1FL3IyYnJiYVVMQVV4RXZmSGJVVVRjRnJVQ015?= =?utf-8?B?Rndhc2U3VXRHaEFXL3RUanE4Z2hTdjk1b09LN0ZNSkRpd0hUYTR0NjhTOTdI?= =?utf-8?B?eWpFZEk4UVNNMk0vcEVyK1BNMHVmOUVFSEh1YjcvNThPWlErbFIzMnc1cFdO?= =?utf-8?B?WUVrbllBekFWRTk2YjRjTC9BMzNsK1VjYm1vM0YwU3dhd2RXNHdlM2w4blkr?= =?utf-8?Q?D5XID+alI9w=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(10070799003)(366016); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a3RyRnA5Tng4YTNLcVpWZGE2T0duTkJ1TWZSR2lqaDJIb3d5UnRvVDNSM3lq?= =?utf-8?B?c1k4ZzI2dGgrbEZXU1hoWWJzN254aTNRaEdqL3ZDU1dycUFnUm9ISTdLYzFX?= =?utf-8?B?VDNGRXByZlFjRk14ZnZKNVhtbzg4YU5MQWkzSVo4MldpQzZqdVRobUE0TG9l?= =?utf-8?B?NExDWUt5dUlNdGpMeHNyTkZGWVhYWTJHZ05heTBEcW1UMVljbGpvTjB4STlV?= =?utf-8?B?Y0ZXTnRYcGlEU3NlZkZVSWVXQ05aOS83dDNmdE1LclNxc3F4Q0dEZFB4R1A4?= =?utf-8?B?L1NueFpHKzNPRFExcnd0UHczNFR4cmVJcmtjcGt6Vyszblp1ajBCcHJQMW1I?= =?utf-8?B?STl0akZrckVVL1d2dHJYTGhRNzZtRm9KbXBmS2EwbWxOK0NialFSVlRHVGdG?= =?utf-8?B?dFE1ZDVnV054YitLdS9HT3QyQzVGS0J2dFBlQUdoZ3JrWExpaTUvbEJCWVZt?= =?utf-8?B?WXRCUFpHdFROWVJHUXpxMlpBLzBJSDJqeDVCd3RySHFTYXBDdFI4YkNpbFFN?= =?utf-8?B?aUpJeWNXdHZPbkpQWUlxWGxZUE5RR1FkK2d1SXRNT2REc2JMNWFLM3dHU2FY?= =?utf-8?B?K05CbjBYUmE1LzBFajd3TncxK1dwT1o1SzRwaXpuTlNXVXIrUGRxR2dTV3hn?= =?utf-8?B?elRZT1hNSTQrK3J4RUpIbTJiUGRzaGh4RkNiTldyZW5kY3NtWG1JTFh2b0p2?= =?utf-8?B?Vys0Sm50akdIaDEwQ3AyYU9lcUNoUjZON1pjOTJHeWlBT29WVlYvQjJWYnAy?= =?utf-8?B?R1lQN3RObEhHMWFZcS9rd0cwWlRYMEhSTHlqRDlTZVVEanh2Y1V0ZkFsZHRQ?= =?utf-8?B?TTNUUmJ1N2c0VUt4SStGRTFkalJaaVo5aFR1TUlFMW5iQUNYb0JlSGgwaGov?= =?utf-8?B?V0xQVGYwUXRJNkZMU1B5cmJLMStaM0pNVTRDRXpGbm5IZEtUYk5ySi9tT1Jx?= =?utf-8?B?YlZTMWgyVlE0SGFDaXRLajkvcUdzVS85Zi9oN21USnNkeFVqS3NwY2lTU3FJ?= =?utf-8?B?amNtR3N4aEwxS2NPbW9ZMTlCMnhwbEc1RzU3bVAzaWtVMFpCeUVqZDNKZGJ4?= =?utf-8?B?NXpNaWp3Uis4RnRyY0J3cGV0RUx5WnBKOC9abGJzbWkxWjd0T1Rjb01FQXEr?= =?utf-8?B?cCs3c3VONWVIQnB0SGx6U2ZVK2V2QldhWHRxTzRRdTAvRzEvK3RDVjFYNkk1?= =?utf-8?B?UnRRcEZodXVLQVE2Q29DOS9UcG8xVm1aREwzV0F1dTRQTUZoNFNaRWQyQ2RT?= =?utf-8?B?bjJkbUkyUXZiQmdFdTM4Qk1DbTZ0UXNldFBEUEhhTzllMjNqbUVOZzd3bGNP?= =?utf-8?B?M1J0RVh2NGo3MU4rMkF0TDFuMUYxQnF1eDB4RjFpR2ZPZUdzWmJKelZvVEtN?= =?utf-8?B?Ym56SnhpN0tLNC9BNE1zazcwbldrQ0tTb3V2N1hyWGU2bXhoQ0JudERSYVda?= =?utf-8?B?akNnS2p5NlZKK0xCNjZHQm9tUkpQVkt0VlIvU3djZDhZUmc5RVN3NGZreUdJ?= =?utf-8?B?aWhHeUd6VXZkUGZDQVJRN2pFczk0SUhuZTErV1ZsK29xaFZZeDNlRlF4TVIw?= =?utf-8?B?RkJmRnlxcjdBb3VxUzlYNWxnQmhjclc1eHZGRTZlaVZFb1JaeUdOYksxTlBu?= =?utf-8?B?WmxjMHBVTlpla1ZHWWlCMkh0UUJuSHRYV1FqR2FLWWpzM09KV09PeTJReHh3?= =?utf-8?B?RU5xOGFzWE1WRndXWjRVRDJTUUV3Y3llQURobVFxdk1CWVRpb1ZaTmN1ek1a?= =?utf-8?B?azlSbkJtcHJlQVpxLzl2dmxnbnNNVjNQUnlQNStXclQ4Z3ZCSXhtTCtrSkpP?= =?utf-8?B?Qy9TVEZudENIOU9TTndPOThWYUNGRHdUVHlvSnRMT3NnRkxiV3J4QWVYVlFW?= =?utf-8?B?VXpkZDVQUUhzOEFKMWhrT1MreFM0Mlhob09maXQxMGhmdEg1VlczU1UzTWFB?= =?utf-8?B?bEtOLzQ3Z21HeW1RbkVDeTByazB2TzNHNkx2RHlzVk1vN2RNSEJOL1hZR25m?= =?utf-8?B?U3pUaUoxZXNCL3FPRmlIRG1kc2dlVmdsb0dZVTM1OGhSdDRuYVR3Wm1DT3VU?= =?utf-8?B?Yjc0WkpDOFRrOWhZNTJ3Q2xueFpXb3lWaFRBNkZPYndRMmh1UlRaYUl6azI0?= =?utf-8?B?RUYyYldHVzBoZThUTTJoOVdPZ1ArV3YvTmYwdDlXVWpPUVUyZDU4MjZOd3JP?= =?utf-8?B?cnZIT0l1a2RMMlRRWFJQN2ttbzNzTGFOTFBpUzZIMFpWQXBwNTJGbXl0OGs5?= =?utf-8?B?NWFsbkI5NEVlMkhiUWhsbkVwRDh3PT0=?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4cbe6300-f268-4212-64f1-08dde6239e65 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2025 11:11:21.4068 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Zset4J2x/ED170J5IBQUC3JWmhVxFEtJoQjstdGXCLV7gKbJz36WZcchTX5U7p76CTal/kvzrXYbBdVRMMerQD3Ce8AIRdxzNKlYfd0lC8M= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR02MB8077 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODI4MDA5MyBTYWx0ZWRfX2nlchwPX0OmX TezGRUX0hxJ/kiQw2apiHJwaLoYdNGSlgVTaxNZtkfFh8AERAXL/hvxxEhZUdNaKHgHBI3AqM6S OUAMYqW3fr2U37BCjeDDrUYU0gNP9MjCNIaS0aH61vobo0x4TQRHIeHZI7PirFrHQC3BlqqrsiT Ct6jF9MpswwR7LSrTx8HHbj88q4cKfLxdzQJywvVtAnt7F8oRNlJUm2RNuKPdJuhGMDqcnC2/4I k82KnXWsre/Bkn8vuJoBdiFV298Hh5HIcpB+K1z0rPqFhNAVK7cwUdZKi0v+/AScanTV5olTzEN MzOs59K8k9A4H+Ik6rlK6MmKLO+BwLH1AOaF/Q9SH/oI1GYw4jd/JbWsUDcNMQ= X-Proofpoint-GUID: CgzlKvj0KETOPOVL5uYTQx_N3JCRimWA X-Authority-Analysis: v=2.4 cv=M/VNKzws c=1 sm=1 tr=0 ts=68b0395a cx=c_pps a=hSYwUsMu3dPAZ0NekjkltQ==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=QyXUC8HyAAAA:8 a=hgPnCYdh90dhvLNmeTIA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: CgzlKvj0KETOPOVL5uYTQx_N3JCRimWA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-28_03,2025-08-28_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.151.68; envelope-from=mark.caveayland@nutanix.com; helo=mx0a-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1756379596081124100 PCI code will never be used for an isapc machine. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Xiaoyao Li --- hw/i386/pc_piix.c | 120 ++++++---------------------------------------- 1 file changed, 15 insertions(+), 105 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 60bf18c680..f1b4468d0a 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -435,19 +435,17 @@ static void pc_set_south_bridge(Object *obj, int valu= e, Error **errp) #ifdef CONFIG_ISAPC static void pc_init_isa(MachineState *machine) { - const char *pci_type =3D NULL; PCMachineState *pcms =3D PC_MACHINE(machine); PCMachineClass *pcmc =3D PC_MACHINE_GET_CLASS(pcms); X86MachineState *x86ms =3D X86_MACHINE(machine); MemoryRegion *system_memory =3D get_system_memory(); MemoryRegion *system_io =3D get_system_io(); - Object *phb =3D NULL; ISABus *isa_bus; Object *piix4_pm =3D NULL; qemu_irq smi_irq; + uint32_t irq; GSIState *gsi_state; MemoryRegion *ram_memory; - MemoryRegion *pci_memory =3D NULL; MemoryRegion *rom_memory =3D system_memory; ram_addr_t lowmem; uint64_t hole64_size =3D 0; @@ -552,39 +550,6 @@ static void pc_init_isa(MachineState *machine) kvmclock_create(pcmc->kvmclock_create_always); } =20 - if (pcmc->pci_enabled) { - pci_memory =3D g_new(MemoryRegion, 1); - memory_region_init(pci_memory, NULL, "pci", UINT64_MAX); - rom_memory =3D pci_memory; - - phb =3D OBJECT(qdev_new(TYPE_I440FX_PCI_HOST_BRIDGE)); - object_property_add_child(OBJECT(machine), "i440fx", phb); - object_property_set_link(phb, PCI_HOST_PROP_RAM_MEM, - OBJECT(ram_memory), &error_fatal); - object_property_set_link(phb, PCI_HOST_PROP_PCI_MEM, - OBJECT(pci_memory), &error_fatal); - object_property_set_link(phb, PCI_HOST_PROP_SYSTEM_MEM, - OBJECT(system_memory), &error_fatal); - object_property_set_link(phb, PCI_HOST_PROP_IO_MEM, - OBJECT(system_io), &error_fatal); - object_property_set_uint(phb, PCI_HOST_BELOW_4G_MEM_SIZE, - x86ms->below_4g_mem_size, &error_fatal); - object_property_set_uint(phb, PCI_HOST_ABOVE_4G_MEM_SIZE, - x86ms->above_4g_mem_size, &error_fatal); - object_property_set_str(phb, I440FX_HOST_PROP_PCI_TYPE, pci_type, - &error_fatal); - sysbus_realize_and_unref(SYS_BUS_DEVICE(phb), &error_fatal); - - pcms->pcibus =3D PCI_BUS(qdev_get_child_bus(DEVICE(phb), "pci.0")); - pci_bus_map_irqs(pcms->pcibus, - xen_enabled() ? xen_pci_slot_get_pirq - : pc_pci_slot_get_pirq); - - hole64_size =3D object_property_get_uint(phb, - PCI_HOST_PROP_PCI_HOLE64_SI= ZE, - &error_abort); - } - /* allocate ram and load rom/bios */ if (!xen_enabled()) { pc_memory_init(pcms, system_memory, rom_memory, hole64_size); @@ -599,92 +564,37 @@ static void pc_init_isa(MachineState *machine) } } =20 - gsi_state =3D pc_gsi_create(&x86ms->gsi, pcmc->pci_enabled); - - if (pcmc->pci_enabled) { - PCIDevice *pci_dev; - DeviceState *dev; - size_t i; - - pci_dev =3D pci_new_multifunction(-1, pcms->south_bridge); - object_property_set_bool(OBJECT(pci_dev), "has-usb", - machine_usb(machine), &error_abort); - object_property_set_bool(OBJECT(pci_dev), "has-acpi", - x86_machine_is_acpi_enabled(x86ms), - &error_abort); - object_property_set_bool(OBJECT(pci_dev), "has-pic", false, - &error_abort); - object_property_set_bool(OBJECT(pci_dev), "has-pit", false, - &error_abort); - qdev_prop_set_uint32(DEVICE(pci_dev), "smb_io_base", 0xb100); - object_property_set_bool(OBJECT(pci_dev), "smm-enabled", - x86_machine_is_smm_enabled(x86ms), - &error_abort); - dev =3D DEVICE(pci_dev); - for (i =3D 0; i < ISA_NUM_IRQS; i++) { - qdev_connect_gpio_out_named(dev, "isa-irqs", i, x86ms->gsi[i]); - } - pci_realize_and_unref(pci_dev, pcms->pcibus, &error_fatal); - - if (xen_enabled()) { - pci_device_set_intx_routing_notifier( - pci_dev, piix_intx_routing_notifier_xen); - - /* - * Xen supports additional interrupt routes from the PCI devic= es to - * the IOAPIC: the four pins of each PCI device on the bus are= also - * connected to the IOAPIC directly. - * These additional routes can be discovered through ACPI. - */ - pci_bus_irqs(pcms->pcibus, xen_intx_set_irq, pci_dev, - XEN_IOAPIC_NUM_PIRQS); - } - - isa_bus =3D ISA_BUS(qdev_get_child_bus(DEVICE(pci_dev), "isa.0")); - x86ms->rtc =3D ISA_DEVICE(object_resolve_path_component(OBJECT(pci= _dev), - "rtc")); - piix4_pm =3D object_resolve_path_component(OBJECT(pci_dev), "pm"); - dev =3D DEVICE(object_resolve_path_component(OBJECT(pci_dev), "ide= ")); - pci_ide_create_devs(PCI_DEVICE(dev)); - pcms->idebus[0] =3D qdev_get_child_bus(dev, "ide.0"); - pcms->idebus[1] =3D qdev_get_child_bus(dev, "ide.1"); - } else { - uint32_t irq; + gsi_state =3D pc_gsi_create(&x86ms->gsi, false); =20 - isa_bus =3D isa_bus_new(NULL, system_memory, system_io, - &error_abort); - isa_bus_register_input_irqs(isa_bus, x86ms->gsi); + isa_bus =3D isa_bus_new(NULL, system_memory, system_io, + &error_abort); + isa_bus_register_input_irqs(isa_bus, x86ms->gsi); =20 - x86ms->rtc =3D isa_new(TYPE_MC146818_RTC); - qdev_prop_set_int32(DEVICE(x86ms->rtc), "base_year", 2000); - isa_realize_and_unref(x86ms->rtc, isa_bus, &error_fatal); - irq =3D object_property_get_uint(OBJECT(x86ms->rtc), "irq", - &error_fatal); - isa_connect_gpio_out(ISA_DEVICE(x86ms->rtc), 0, irq); + x86ms->rtc =3D isa_new(TYPE_MC146818_RTC); + qdev_prop_set_int32(DEVICE(x86ms->rtc), "base_year", 2000); + isa_realize_and_unref(x86ms->rtc, isa_bus, &error_fatal); + irq =3D object_property_get_uint(OBJECT(x86ms->rtc), "irq", + &error_fatal); + isa_connect_gpio_out(ISA_DEVICE(x86ms->rtc), 0, irq); =20 - i8257_dma_init(OBJECT(machine), isa_bus, 0); - pcms->hpet_enabled =3D false; - } + i8257_dma_init(OBJECT(machine), isa_bus, 0); + pcms->hpet_enabled =3D false; =20 if (x86ms->pic =3D=3D ON_OFF_AUTO_ON || x86ms->pic =3D=3D ON_OFF_AUTO_= AUTO) { pc_i8259_create(isa_bus, gsi_state->i8259_irq); } =20 - if (phb) { - ioapic_init_gsi(gsi_state, phb); - } - if (tcg_enabled()) { x86_register_ferr_irq(x86ms->gsi[13]); } =20 - pc_vga_init(isa_bus, pcmc->pci_enabled ? pcms->pcibus : NULL); + pc_vga_init(isa_bus, NULL); =20 /* init basic PC hardware */ pc_basic_device_init(pcms, isa_bus, x86ms->gsi, x86ms->rtc, !MACHINE_CLASS(pcmc)->no_floppy, 0x4); =20 - pc_nic_init(pcmc, isa_bus, pcms->pcibus); + pc_nic_init(pcmc, isa_bus, NULL); =20 #ifdef CONFIG_IDE_ISA if (!pcmc->pci_enabled) { --=20 2.43.0 From nobody Sun Sep 28 15:28:19 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1756379628; cv=pass; d=zohomail.com; s=zohoarc; b=QlcBuJETvQtTe0UNYUszgA2vIaxVHuupZEpgwzHV00iJTc8nlgF2Bo84XB/Uv4NlwoEkjSCTfwSWocnA1VFtDZOsnqwWyzwkgNAbZGLXITpvEHYrPqIz4pHt7x6yRXUI1jBnrNgb+Zh+85tms6ZjcLEjLOujZ+NozKZ4UcIOpiE= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756379628; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=PbFRNEaVoa7+oOm/Uk5dJlrTDqgoD/i9eSmj2G0Pmfs=; b=O2oyAsQH1Gk8b/6cdZbFH0iAdKn2mhVKgR4OJmvZzDVqIgAh+F+Klz6w+RtfMwMDTexO/mufrnSHJHKmePDW7Dp6oGCX94AVJlO9aoSuCFilS5nijJ7F5hyNn0JJnHtinOKdfSKa03kiHWkVpZfvSjAF393DslYOX/uYy5OcQr8= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 175637962779737.95850713175378; Thu, 28 Aug 2025 04:13:47 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uraXU-0008BW-8V; Thu, 28 Aug 2025 07:11:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uraXS-00089H-DR for qemu-devel@nongnu.org; Thu, 28 Aug 2025 07:11:30 -0400 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uraXQ-00057q-Mx for qemu-devel@nongnu.org; Thu, 28 Aug 2025 07:11:30 -0400 Received: from pps.filterd (m0127839.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57S9m7CY3413914; Thu, 28 Aug 2025 04:11:25 -0700 Received: from sj2pr03cu001.outbound.protection.outlook.com (mail-westusazon11022136.outbound.protection.outlook.com [52.101.43.136]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 48tbd9s9aj-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 28 Aug 2025 04:11:25 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BN0PR02MB8077.namprd02.prod.outlook.com (2603:10b6:408:149::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9052.23; Thu, 28 Aug 2025 11:11:24 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%3]) with mapi id 15.20.9052.019; Thu, 28 Aug 2025 11:11:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=PbFRNEaVoa7+oOm/Uk5dJlrTDqgoD/i9eSmj2G0Pm fs=; b=ihInhw1nbVd04Iri49sjpHidi3zxVkVw+Xn2B8b5fD3dd40mmWHHC67Eu 0zssFL8jMREOgRNDXVI18Q3rOoy8ZHUJmlYwoAmaPM2LW+0Vuw3DeA6LSNvIEzPx RhDCXXiZuKEtiLOfPAUI60J74nnQWLt3yM3GiMzaeLTog0z54QhApI3ENMsnfMsz FgBO467QA9ImsuyYPCmzmRjMupeJeeXvt6hoAhL6/gwrnklzGTrrSjU3fZtHeCNy Sh8Dyz4XYqaXjFLTQzv1d32AXmlzDvNNH30Fj/l4AjNa5OEupkjboq9YvQlH9f1D JIeXtTY+3KHWhrl/OWRmVgHhEU6Aw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lFx/kWpMQtOI6DEkqRBDBhLpFfYjU0KEN2Sc0BhwcptM4RShmv4Mvo4OqTbPnaKYSL80tGvvHgGQxOx/mCKM/3h2ud64YdB6PipPFDiQRE2lUCtIdIo8g2r7/Jvf65fAyykvrTfAepJSEI/aM4kNVNOl9YkQ0hmmg3gw5f2FSXczf0a0fUn/53tiUjRK4sTysRJTTE/nxSpWcD1NrgF0fHr3xZwji9aRi3scVyqtTRnJpFaKe/3J26hi9zAOajQQYkVoeQ0L2aWA2fxLX8RZyRtlnF0KA9gDb4O2Qmv6OMCuLbjm+R3PCMj9mrbVOOwqMID/S4HoMPKpyH044qlUAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PbFRNEaVoa7+oOm/Uk5dJlrTDqgoD/i9eSmj2G0Pmfs=; b=iXhR5mLfuD8RKpQ4HsH5eYy/5dr+lqa+sK0i/IsjdUMKqprYKrBCNqeF09X5zXYJn4Qqm3Kiof0TLYy2vc5EjSk2rcgW9wfdcyRnEecUa9Bmcd0Xz7vRnUKryg+IiDcayDFYOr9hVmdASUhfwAUYNjgnq0oGF+7GZYIA05pofLtJhcccSX4gUQYC3NR6k6MOzRoKCf0k+5kPx+0afBkRnhyaHBH8e/q8dSjlczexxsYzF2aw+/7kGAi7T1n6iSQfxqgRbBOrmFdsO+R3dl5NXPaj32tGoXeOmYdsVFbCiWLiNa57zXCR4CJ/8gXbncbFwy3JEeIPTGToKrrwfa7bMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PbFRNEaVoa7+oOm/Uk5dJlrTDqgoD/i9eSmj2G0Pmfs=; b=y7WRq2nmZCgslNwjzMHCEp9kjSy2me4B5VjuhwCveiFRR8kQ36RAkvwURW5O/0OdEWGbux3R2t50JY3rru7/9BZyrksnQRpAVIPxAij4HcAp5F38vb+73/JxaPQ29dVIQkdSHSDgWkVtqwoEsmVj/d50QcWfhw58MxUUMPXe8qNAQr5dqcDWxkyHY0d2TEVdp2ACu4F/UFX+YzuASu/nPfh3UVTR/fE39j0W0qkS0piCOr+C5EoRFrkkmAYW43gYxAG6leJ1sW8dzM6cWFGdzHJzL2499Vol9wpQUu9FLwVxQnzktIgdoldPZ9SLJ9kqvsuKHmEE2K4T77tsiwxsIA== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v7 07/19] hw/i386/pc_piix.c: remove igvm initialisation from pc_init_isa() Date: Thu, 28 Aug 2025 12:09:50 +0100 Message-ID: <20250828111057.468712-8-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250828111057.468712-1-mark.caveayland@nutanix.com> References: <20250828111057.468712-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM0PR10CA0053.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:150::33) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BN0PR02MB8077:EE_ X-MS-Office365-Filtering-Correlation-Id: f97e834d-82bb-469a-c201-08dde623a049 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|10070799003|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?SUb1ZLJ5cxsNm0Ym2RIE5fxCeMh1VFvmQ7Er7H1CNB7dPDbDkm66VjrWMPzD?= =?us-ascii?Q?571n7V3UYJwoeVXk+WxpK1BhQxfgo29s4y9aoDVkuYXm3pmWOqQGfHsjPnUT?= =?us-ascii?Q?OfWMMw0GeMly1vqyEY/+gqAh9JdumdJYrUiTLnZlyvdnK8afA8xgjegxO6Il?= =?us-ascii?Q?hvLDOrdhjUIahLBJh5hFdFyPHN84xo0vFA+KDHMkpyTqmU5mRIkb3o3Pb3eN?= =?us-ascii?Q?1vESUZfqTXB/nUe33/9aT5CGNyND4UfOReFjA0FQv0gbdKT47aWgWc04ehKY?= =?us-ascii?Q?mmdccLnnQhetCYVPzEql41zcDwp2PVrvN61cN65lEAn17RzPozNOeeYZ3sPb?= =?us-ascii?Q?3c0xTY4Sp5wgYIHczBb9E1/Dc8dBB9mVRNFiaGNSFJhybjcaZtZOAEQJ4WwX?= =?us-ascii?Q?DoAJbt5IFQpT6/J9pn1knvBggvyRPKa1IkykZufvMZPo8HwZ8MwIctr5+5wv?= =?us-ascii?Q?aBP+X45QF/4n2G75XzEnGggOxrC5nqemWk0/qurqIT+698DJDr7ry0UHgvrf?= =?us-ascii?Q?lqshaJTm3T9CpyNWvRdSLoVb7KrBZFsRHYlCw/PzJLBHUT7Te/VgSPDh2FcR?= =?us-ascii?Q?21b/AgYhDKry/OhZ7ATWtKJjdY1ANCetz7yzedM1jD5/8/vbszKLssT66Vpx?= =?us-ascii?Q?rhjDbtEH0dtzLIZGUbfvDLfyARA2s2mXhS38yMkNzK4K7jp/XRgI4NnPvijN?= =?us-ascii?Q?h2aR/ftamBvdh+zutapX0bPV0vTGmb8EsuKiYBUQFKwJT3ET4vX0fR2QHzEt?= =?us-ascii?Q?zNxyYiP5Y+/gcga+yI7a6XWGxIeeIwNr91/e4GC/sxjm590naHPdBjECPgyP?= =?us-ascii?Q?VxkFjhafWNM1dRsM7NSNXlhVGjcmt6yyWn8xpdewGm/NKBXFdWcNCefmysh8?= =?us-ascii?Q?Y9B7DlKOEqP0nJjMhhSmFIjZA5onKmyRO5cYGLpItwNUXxBGUDqWyAeT98Og?= =?us-ascii?Q?vEThTkQYWRoCgbovht0zU/J8BYXkXCwpHx/qj45foEaA0e7M5UMK9lg1bDF/?= =?us-ascii?Q?tpyp3/0HRHE6v4hWn4UylSc4tg/jgTfwF+6Wsl+sc8yAl1PyO5RfVK7XiEHM?= =?us-ascii?Q?qUKFaIQNWndmz/7VhnNZcP0CJ/WP4CkVpLf1QIozO4EUB1dzK2aTHPrJHIGD?= =?us-ascii?Q?cc9KmAUiuzK/yClY+j7ZX6mr0XJ9IjG6c7P1oOUAJ6CUFrzWy6AmpGTCJXjh?= =?us-ascii?Q?zUOd/HlChS2ZpGcZYzq/5fVrRAW6eWhBXKNYT12qrZsnot50PYMqGt8xWfd/?= =?us-ascii?Q?QcD91ALQh/utk2IQ2vbPnoir4/Yeui+w1JiOAUthsquWy+uy3WJVXFZwGF7Z?= =?us-ascii?Q?vug19Eiza1ralVJiSWgtTzkVgEa+9vdx7/VmonXIqyadmIC8Yqe8ohycbY4F?= =?us-ascii?Q?ZSGeEi8HH6xtKD8GDocTNWKL2+x8NlLyg1nGHmGME6qpRBWhIw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(10070799003)(366016); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aFNWY90P5aBX1XXwOd+fWl+LtiUVfRj+66QbGSqeb7xePeNJkj22OV0xtFwE?= =?us-ascii?Q?NTUa+w4k68n6RlycWy29Tdr74cT5MzmVICA9PoAOCWRhSdGuAEHjdGFk8ZDg?= =?us-ascii?Q?uVARDOFtDtFl8AdkfNDFFephVE3HJiKTkcvJhFz/BRvBTY9vS/wmBPKfiZSR?= =?us-ascii?Q?GlmnPmziRP+MIHr5OpS1Jxqj2qw0A60gl3LkcbkhO2SBwICFhmeAlq18xkFc?= =?us-ascii?Q?UwoUVtvhuX96mIvm3BJZP/EJhSbcaPJ9WAp/1EBteNCDZjBZ8Pl1GOrrlXf0?= =?us-ascii?Q?G8qmYBQ1wUuu4WwbWbZ405T0oUa5bwc+f7Sgv+geaCTIOLF62gVhwNZ1Gyxu?= =?us-ascii?Q?GyiPMFudXUv5zeGenw61D9JMHaW7jiULiCov/991OHqlM2XPxggKpsho2uPC?= =?us-ascii?Q?iUVfBdGZc+3gW1QNyqrLH6Gsub55epiozCoLiUa09LxbYAIrnFZHRKLrrfoL?= =?us-ascii?Q?lQhLCoFw8jl0TXBKn1NQyjGWfd/NKXa4rxvDQLRPiE0DbjSXfb1bd3Zhvj9r?= =?us-ascii?Q?0lgYtP6lOaSBllafOSBoz1C4X5/suxTN2T0Gq3X49KGMFFeQml8OpXzfS5OM?= =?us-ascii?Q?KEDO/4QBFKnVNJa7gKODIAnAVlALbCL3V4oRN2cTwvmcmTpOPo2NYp2u1wlt?= =?us-ascii?Q?PR1XfGGU/MECLgVYvW1/2oV9CBJ9p21SY7E8NGN1sNplNY5i4hdOS4OlB0W9?= =?us-ascii?Q?t4kvVsur3RoyiuTT++DY5IJgk6Lw2CoUxChzMfyNxINy7pCfBvPVHxS7qBed?= =?us-ascii?Q?3x+PDyIkOWLNDku0K+Y6YcLgcUtpi5BXJyCylvUw6DHi6bFibVjbL2QRjpUF?= =?us-ascii?Q?YFdCqba0KhsK8L/BV3Q504G5N+8b/k1n+4jpXJBzjAEvvtMI+YuFzMY0TP/b?= =?us-ascii?Q?Y/50oseJ9afQ1jb+Ebs5hGpjp1O5XtRT6hkRa+wUdudbBN2T8jf5PZunIF4+?= =?us-ascii?Q?oTRAdYXgFKRJdO/ECEkIwX3/zE1HgJpk/NBLahR3X6MOP010R/ulH5Gvfm92?= =?us-ascii?Q?Sdjn9VXErwxW6oNOyKStTAKr04oUHij53mI324cm4VqR2nd2nn2l1AOTT0Ek?= =?us-ascii?Q?jXtFE6BURFFNss5MwWv4Ne3iBho2VEeZAp5TBCTp4OTLprroMzZoh9t1zEks?= =?us-ascii?Q?wX+zMiNdT8FYlAB3KjYNnpXJb822XfmWxcsMdhrRdIdQ6fyIDXFWvpCvango?= =?us-ascii?Q?dNi/UfJbVuVlyp1lwOq0PLSZ75nCvgqkRElEnALCMi6xJTTdKG1o8W0CXcE3?= =?us-ascii?Q?pFOi2QiZma5uzHPbnLOFmMBFA2zv9FfY+Z8Zhww7YupTvFvKKliNpyeacqxB?= =?us-ascii?Q?C5vXfBdJLdXXPxNm3PVpHLFX6vTRF8EI7kiv5NyOp6/QSq2l25D4lBgL4Asy?= =?us-ascii?Q?1/NgxQ3uIIqkouZq1GVMTQFJX9z+ezvlOCdhnwhLDyNi72cZ+yEQLlbYmx6U?= =?us-ascii?Q?O9XZo/73VGKthf09HW4Gm2XMe3s9in6sfoFLAfRKGVGjaFrC7liCyoeydhEd?= =?us-ascii?Q?Su657EY34QSf1trm2ZuvuEsxulummdGS1UV0Q+BzJwKsGmKqwflmA7PqKw7U?= =?us-ascii?Q?pFmuXf4mFiTU4ZYTZbeqYmBMWOO1KJvTJVsf8eNnRAuEvLlBaFpKr9rS6pBV?= =?us-ascii?Q?X3BcWX6S0ziCjrrqCjiavXp95IaiG7f/SOoqEnR7T2beDvstsK52K1pOxFs+?= =?us-ascii?Q?UYXX5Q=3D=3D?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: f97e834d-82bb-469a-c201-08dde623a049 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2025 11:11:24.4612 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sk7CYzJc/gQeJELIApasIxCkNML8iRBm8P5LK4MDMAVVLxCwIUYula1W4a6todip3OXTZQqHglyEcnUwPn07UoVKxOcG49wC5WAUzeqNu+I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR02MB8077 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODI4MDA5MyBTYWx0ZWRfXxmGnHYmT5OxB 5q6y1Vz19X8lTHVGUMUn/E9oTOVV+5t2KWBcNmo/8Kz5s+SzR4nQ1aV62MbGwF6pKcikRuxNrtj sCcH/NQai5LAod5O1NRfPLdqoEmT25UyZSlT+errfFHFaycGqRi8BV8US4cgbJg9PWM9Rf8sfLD a2yhqKoBmWKQbxaHWBkf/pJb+g2ofx3E+HsRHSqMCy7uH13DFBMj2UUcTLVpaxDx3O7vi8mX7B2 1M7PSTpx1p9WuCAyNMjG0wLxvNdiWu8E5brzTbosD9+Pd6DqPeaySRom3FGkSej3ZbCnJhpH0JO hpQnoKNI8jUZVUyfT2yWmnjmvE9vexTxtlMJ+v/VQ1cdjTc9pTi/Wlnjx7104o= X-Proofpoint-ORIG-GUID: kgZT4dj_2exwtb71LOmfXDQwWbSvyfhv X-Authority-Analysis: v=2.4 cv=IZ+HWXqa c=1 sm=1 tr=0 ts=68b0395d cx=c_pps a=/d/dYiFJ9j2vSnh1phFeww==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=2OwXVqhp2XgA:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=HV6HxWYAiGuMivAlcYUA:9 X-Proofpoint-GUID: kgZT4dj_2exwtb71LOmfXDQwWbSvyfhv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-28_03,2025-08-28_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.151.68; envelope-from=mark.caveayland@nutanix.com; helo=mx0a-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1756379628309116600 Content-Type: text/plain; charset="utf-8" According to the QEMU documentation igvm is only supported for the pc and q= 35 machines so remove igvm support from the isapc machine. Signed-off-by: Mark Cave-Ayland --- hw/i386/pc_piix.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index f1b4468d0a..5ae265bd53 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -640,16 +640,6 @@ static void pc_init_isa(MachineState *machine) x86_nvdimm_acpi_dsmio, x86ms->fw_cfg, OBJECT(pcms)); } - -#if defined(CONFIG_IGVM) - /* Apply guest state from IGVM if supplied */ - if (x86ms->igvm) { - if (IGVM_CFG_GET_CLASS(x86ms->igvm) - ->process(x86ms->igvm, machine->cgs, false, &error_fatal) = < 0) { - g_assert_not_reached(); - } - } -#endif } #endif =20 --=20 2.43.0 From nobody Sun Sep 28 15:28:19 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1756379628; cv=pass; d=zohomail.com; s=zohoarc; b=TCmM2zXM7nwJDvktlv+8RpG1aQuRqJVYKdhapMwVjOKb0e/iym5Z9C/6BF3EEHQJ3a/F5Lz7iT6yeKidOSrMZ8OeovBCjEPzbb207VqsGDK8WVLygI/DpbJASm7RGiWL5AmUWUzF9C7hdo/T3uAjWizzpSjZ/cVQs/bXC7bhWLU= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756379628; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=JkAP3cMirRl48ga9I7leI0o1jCthDMzhQx2D4lpW4bA=; b=X/anc305/bfoEg4JEuNHZgzAKZLVpNGAn56Zjb9UPl7ZAnCKIvt26xZ4MxUEHJ0J7Zg6ohPIQmgzmHF2hAeMaCeysBydu+ODZqIyNqPyIUfIZWUQVdo1srXcWFDkKk0LiWBERVd77mGzySDSmuRDh44hqZ1uBt9C40Zfqpv/KAg= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756379628402610.6826762154991; Thu, 28 Aug 2025 04:13:48 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uraXX-0008Eu-2M; Thu, 28 Aug 2025 07:11:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uraXU-0008Ce-RS for qemu-devel@nongnu.org; Thu, 28 Aug 2025 07:11:32 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uraXT-00059t-5Q for qemu-devel@nongnu.org; Thu, 28 Aug 2025 07:11:32 -0400 Received: from pps.filterd (m0127842.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57S8Ouf81758401; Thu, 28 Aug 2025 04:11:29 -0700 Received: from sj2pr03cu001.outbound.protection.outlook.com (mail-westusazon11022080.outbound.protection.outlook.com [52.101.43.80]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 48t00vjx23-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 28 Aug 2025 04:11:29 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BN0PR02MB8077.namprd02.prod.outlook.com (2603:10b6:408:149::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9052.23; Thu, 28 Aug 2025 11:11:27 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%3]) with mapi id 15.20.9052.019; Thu, 28 Aug 2025 11:11:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=JkAP3cMirRl48ga9I7leI0o1jCthDMzhQx2D4lpW4 bA=; b=ODeC6TVYdct2EX82Mx9pRovg5pzXu1eaiOX55bEki67YeUr8shSqb1I63 nnbj6bDoOIAMP+w3X3N+6/nP3MyZRBic6l4rRQmMIqmij89rbu6aUTS2Z3ZoScZB Rd63HyiuVsmYEjHwNpMaL7r3z8d31B0Sf0uonJ81z3ob33hbq2aAN9AJSIWLBLwE xM+9ranp0/B1/dEPwYLAz/HODaF0y5fOWLT1ZiV9aLEw0HpqDuWmMfMQ9w7RZKT6 pwhJsp8jPw9USZNgX46u6R/tL/dGO/lIWGFLn92DVQxryMw8S4v36OvVw/noQi0Q XqFXiOjDUxf4q+KqhgWt22DWdnLaA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bzHzWi4djPI9kExLlQHfv52jup4/OphEW+FuCc9eh/O+taiNMr+MESGIChPBZ5iBiQgHER18+/6MQPxZ1mSWAqg/mci/gu25GHND4EfuM5Ivz/Q2KNlFw2ZLJyLRWZz7L7StG+rDsoQh38S2iTrRXysZifHIKbSDvPV0ZoWAxFDcTEjtWcZ5LdhKxVLKNt5bMdxLss8A93vNBHhwssQ/Y+NCnPeBCWDmzkg2iJujuSAB47C0eIFxV9mPENCrOfeFXbXRMJSEYL60YwecuOu1Ic4PJXuB2WnO8Q1eL19KsDIbkLrhWOimKbGrm3o95HCQyhUpFgengHsQQI6cX7627g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JkAP3cMirRl48ga9I7leI0o1jCthDMzhQx2D4lpW4bA=; b=cHzXV+NAzMM4L8+0fzjUVH3aPm8/HloVNIk7rc5cx+ufjJPApnl4/ED/bXwWOCmmlFFFXEoeFgtKZYHQPNIC8PEEd4gQGX6S60wclkN6ikJyC3Q4CCa/BzPEy4pJwIduviy8Lq1mNGoN21hso3fhkadLgeVJ3GhRmzHh7r7m8xJ5SGfBr+Pp/5PKTn5dpzwLXHLX3Fr5rfak2tYcNCof5+Rqv2HOyfbT6ISKAJMQNU8HlalrvZTGRt0iaXlQI72+7HfW/EJhAfPZQL6NOaCuyGusWuuw9fyflOCplMME787Dj9WPJmynVMuas+Sd3jMMN5PusRwJlgnVdIZAlsmFNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JkAP3cMirRl48ga9I7leI0o1jCthDMzhQx2D4lpW4bA=; b=T4LAcfacBVP5YAGx3LqRbCDwI0fVD1tPr60hhft7mkgpyvYcnErPkDfVhscLROGvG3/wPS2zUjHIXE73qDYm8uelWLpMf4uc7wCdawOY5EP2uuCPnSGrnkE8CX9eHgzIwxbtSeQdZYg+c+8Tpbm9tcU6/VPKLExoaPhTqAExcKYV06R0KCXRGId3g133qToh/Gw/RspQYSYfPZcxUozUhVATBo3FXiRKCSkdMDhxJetJ6HQhrc4kKW6rRcJ28m9XeiW1ahJFYkf+CzoKfvu1UobtaNJNnKBrcCdvDQWep9MkEC32ujykFPb/B2V1iP+MTEHv7+mg3Qoal9MwsIrv3A== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v7 08/19] hw/i386/pc_piix.c: remove SMI and piix4_pm initialisation from pc_init_isa() Date: Thu, 28 Aug 2025 12:09:51 +0100 Message-ID: <20250828111057.468712-9-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250828111057.468712-1-mark.caveayland@nutanix.com> References: <20250828111057.468712-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM8P251CA0026.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:21b::31) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BN0PR02MB8077:EE_ X-MS-Office365-Filtering-Correlation-Id: 616af61d-7820-46c5-498d-08dde623a235 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|10070799003|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?MzdkY2tGWU5sTTFsNWZYUjczcmxNUnJyeGkvRG1WU1N6WTNCaHJPV2pXQk1T?= =?utf-8?B?OXp4LzBSRy9hUXFtNEcxLys1S3ZROGVPYWpHQy9iWHNsTWptNmM3SHpHT0tE?= =?utf-8?B?bWtOcFJVRjMrV3ZRQjJEeTdRUkdwa0twUFZpeVZ5WFFJb2pvMzc3bXM0TTNP?= =?utf-8?B?MlVIMjFkdDVWMHhZeEhud2hrSHJMSXFLaFIyaWpvM3V6RDZ0VG8zb1FxZ1ow?= =?utf-8?B?UjVWREtXVEhaa3ducU1ZQnRSVnFDaERrWFlaNXNGVFo2aUZvVm52SFkwYjI0?= =?utf-8?B?UUZORkRsS0doSHBic2VuYmQrakp0anNMM3dxaHVBYVdjN1plVEw4dFVkOTJQ?= =?utf-8?B?Vkh3OW12b1pPU0s2VkpseHZ3VURzK1hLelRVdTFkWStmWG5aSFdWWTlkMzEx?= =?utf-8?B?Y3p0SDdwSUFYZEtVckVIc0RZQXJScUtjL2VuUyt5WDNhMTFkN0ZyeWd3d0pB?= =?utf-8?B?SFZlZUdoZkhLUk1tTExPTDFqdU4vRm5JQW95YVhGbkFadHRheXY1SnJsaXZG?= =?utf-8?B?MkZrd1FQaTVuYkxJK2F6L0krdUg0a2JoS2NJYUl2SGljcmpOWjBjem4xSDlp?= =?utf-8?B?cTNDTG01d3hIcEF5L0Y5L2tNdWtMOWN3ZitVallTc3l4MDZLZEVvWFVuQ2Mx?= =?utf-8?B?VkxKcVBjUzdINGFkbndHaHhBMTAxemVZVS9GbkZTZk41a2l5b3VtU2FHdjlq?= =?utf-8?B?RWFHMEI2OHRVMTNZayt1RlZpUkFmTUMzd2JaRENDNCtKN0ZpWTNqYytVUlAy?= =?utf-8?B?RG8xZXpqV21kUXIwOVFZN1lBWklHVStkMHJ2WWs1dzdldlFoWkN2Und3MHJV?= =?utf-8?B?UXltWlZIZ0U0ZUNEdGlPL2JzTWk0ejdra3JGenN6VHRmd3RUYkFwYnRWTHBP?= =?utf-8?B?dmcrWEdwRk02MjJHN3FGeE1rL1d3NEdWZFBJc044MFJCUUd2bVV3OEVUK1g5?= =?utf-8?B?MGVMQnl2dHp1YW9jaHUrTGxzVDNGenRNb1BJbll3emxwTk9UMUxuOEMxYkhU?= =?utf-8?B?bnJyOWlHRHlDVlBRTzZTcmVQajVmRmRjT291QjkrOE5HQjRYOTh1TTQrZlVH?= =?utf-8?B?YTU2TUpMOHJHYkozcWt0b0lvUEtIT0lsVVI2Q2svdytpVnd5cm9ZUEd6Y3Ni?= =?utf-8?B?SGpwWXV4RWx0c3RoVGNQMGU1Rm1nRlkzWVZWaHN4bjVZbVdMckxhTFpLNlBm?= =?utf-8?B?TVY1d29yaytIM2hlWllEd2x3UjlHRERCendMbWU4SkxOS2lqRVhKUFVNMzdL?= =?utf-8?B?WjNyekoyQms0WnRLNmwvY0xhb0w3ZW43ZVdsVENZdUNyMzQ0cE9tNVh4ZlEr?= =?utf-8?B?RW01Yk8vRjlOb0dXRDNUMlFiYWhKQUgrcy9NSnZFdi9XdSt3Uk5ZYWJ4REIr?= =?utf-8?B?bkwxSFVod2dkZzFGR2JscnloMitES0pmNm4rN0d0TFVsZFdrVUNnUnVQdmI1?= =?utf-8?B?UTRIWFUwSUEzeUhnVG1NTDZMbGNOK01pUER3Nm5BYXlOWUZIL3Z1UHNIYWIv?= =?utf-8?B?V2ZiazQwSkNZQXdtSlB1bGprZHVNTUVCM2o4VE8wditrTEM0UnZvWnFKNG5x?= =?utf-8?B?TGNoZ3VKL0pFNVd5aWQwSmZreGthd1RPMHhGckZxYUtYM2UrZ0Q2YWd4K2ti?= =?utf-8?B?OTdJc0JKVDdRZDZocUpUTXBJWFhIdkR1c0JiRENpaXZEcVpqb2Z3Z0o5S1BG?= =?utf-8?B?bnRUSGd5TmVpa0NIaVFGVUg0YkdHak5MN25rTEV0aFpheGdUZnJ6Zll2T2xu?= =?utf-8?B?N1pNNStaK24xd2dweGI3cHV2UkJ2K3FCWFZYdnlGMVpncGVvaTdJbWtBOTZ0?= =?utf-8?B?U3RiYkZ2MzhORkxXcDJzSTc2ZlZ3VHFPYmRFczl4WFBTaFlhbUhBTVN6ZS94?= =?utf-8?B?MmJURkUvT0JCRDV1RFdINE1Da05lb0lTZ25mVUJ0cE9kcjMxTTl2MzFmeXBv?= =?utf-8?Q?lQjfKJEAoBo=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(10070799003)(366016); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VGw5T0czOHpuTmw4TTNIRU0yZWdidTdPZm03TWJXNUNUMUVNanJIUlQrSjU4?= =?utf-8?B?QUxmdExsaTROckNFc25TdnNVS2lYTmxQNUhXYkdjSEhPaWswUDNhNkd6UGJZ?= =?utf-8?B?aytHU2NuendxT3EyNFcrcjBhRXNqY2lnLyt5VGhkb2FqOEc1WEkwQUNpVlVw?= =?utf-8?B?VTRuZGp0QjlaZnJweGJLcTRHVGRDa0JRVGNLWDRPNTFuK2lBUWZUb0NxYTVs?= =?utf-8?B?ZnZES29yVG1KRVlZRnQ3WWhYR0VPYy9INFR6eS93MnMzYjJqZ0pBSjFpbUsz?= =?utf-8?B?Q0RGbGs1ckJpRXI0UE9JRkVHZ0w4VHppaExRa1N5ZS9tY25JVkl0d1pSb2NB?= =?utf-8?B?djlXVUxNM3lNNVJETlhJUkZCMHpTT0d1OXBqQ2pEc2txTTdWRkxReUVxVDFP?= =?utf-8?B?MHQ1RUEydVFJN2pHUlQxL3Z5eUgycXNDMTd2ejFWT0xSa3FKUk9pbkpQRnRn?= =?utf-8?B?MWNkRU1FRFNZOXBFdHNZTzlkSStSanorMkJNRTFKalpqUDJvYm9EbzVXUnpr?= =?utf-8?B?dGVwV1pNTzRXejdHUXl0cHZPZmJOb2VpV3F6YjhJc3NiWmxYYTR4L1JDbGgy?= =?utf-8?B?eGM4SDVHOXl4M0JWOGZZVzhMMzZTeXRUbXRNQlpzbTJ4OGswUFQ2NjluMUF5?= =?utf-8?B?dm9HblZnNXJDRGZ6T1ZuSEVJU2xNTnkyY3VVcGI4ZzZ5K2FiaHpTWERvenVh?= =?utf-8?B?SzdRZjR0UE1ha1FySHo0cHVoK01mck9pbU53bXo3ZER6TGxLUFp2WjlFa0Jx?= =?utf-8?B?My90WGdxUmpnMkhjd3c5MjF0VHpMandHakl2UEZwd1MrTmVPTVljVmt5eUcz?= =?utf-8?B?Mnh2dDRidHlWMm9QbVZCUjNZK2Qwdm5kM3R4b2FvQTBEZ3RaT3NUeVYreks5?= =?utf-8?B?TElreG5aY084bnNSMHdReG1zWGtBaFhYa0xUTEZUUklGc0dVTWo3S2tGblFm?= =?utf-8?B?aVdMUzNpR1c0Y3p5dklzMTY2MTB4dGFacStDS3hYWlJsWXAzV3RnNjZycGFP?= =?utf-8?B?bE5iU25vYTRPM0VDR1B6Y1llOWErQitFRkN0NGxnTWM1VUNoZll4VnZBVDV5?= =?utf-8?B?ZldaaVFZVWp4LzRsSjFQT1FvbVE1aS9FRHJCeCtBY1Vac3BicVlTRTFIUnBI?= =?utf-8?B?bUVWNE5hTEQ3WHBCRzEzdjVaTTV0cDRmVHY3ZSs1djlUMm0wamEzd0prb2lm?= =?utf-8?B?Vi9yTnByMzJpUjYyNTdBaytBczhsSHJLdng4Nk93NlorRUNxVTN6YnVBenF0?= =?utf-8?B?ZEZTVnBIRm10ZTJLbVFTWDIxRG1PZ0NYRmdSVUdYNmlLOHhzWCtZSW1sdXN5?= =?utf-8?B?djZIdjBsZUZ6MVd5T1hPZGZxZTljNjh6YktXS0E1dElmOVdlNEpES21UekRE?= =?utf-8?B?bUVFYWRwM0svQzdjYVNUM0xLK1F0K0NiOE5uOW5oNjJCZ0pNb0dScHRIMjVV?= =?utf-8?B?bzJsYnhVV29HZW1tNDExc0hVTFpkK1k1aUdXa0F6UmVlcjlKWUM3a1NzOUlz?= =?utf-8?B?MEJFdjJZNVlPRDlHKzVmeVdMVFhwa1ZqOTBER3paSmZXMmxueXZVWmZ2dE10?= =?utf-8?B?ZWt1dHBvUXJHTnVGTE9NSCt4cVRjSXJlWFBHYytGeDFtZng3enl0eWlXU2dO?= =?utf-8?B?R1NYQS9YUWlkNHNoYkwxUTkrNUJacUU4ZTRwRWx4S1VDWVE5WDhaL0FjVFBa?= =?utf-8?B?cmkrVVh3YjdJTytRcUNTMkZvaGVVT3dsdUtqdEFNb09hL3VIbThoUTVtUVd6?= =?utf-8?B?NjNnaFhoWFZqOEo5VHQ5YmZ3anMydVh2c3h4ODErSGFMYk5DQXFiNlErRDdD?= =?utf-8?B?bDR2ZHNnZlA0a1BsUU95dFRpRWJPc2lvY2hWYkIxRW9xMnNTRGc5TS9rdWh6?= =?utf-8?B?WTEyeHdkRGl3bFlGcWNBZEI5WkkrcmVwampWdllrRUJrTVM0dS9hdWwrSmJn?= =?utf-8?B?S2RFS1RGZC80dG82UUdvRVpEdkVjMW1hSndSVmhkTk5pZ3ZyT1ZZVWU5VFg3?= =?utf-8?B?a1EzNVpmeGZHK21UWDRxejZWZHVQRTBMQ01zTGtiejhXY1Fma2lhaHdCb0VL?= =?utf-8?B?aUZXZ2E1L2x2NE1idVdkcnJrZXkrc3NDdFphMGdpTjFIaThkZ2dWR212NFhp?= =?utf-8?B?ZDhkdHQvU0gxckxqdHp2MTNGVHpHTzd6Uk9uY2t2cWtOeVgvVCtCVkxWZ1Zn?= =?utf-8?B?WnNrQkltRi85akdSSGZZcUpyeTZWL3hnY2srNXBRSWtnSkpIMkJhWE0rOENO?= =?utf-8?B?R3doMEtQK1cyMGxGVHFJNlcyb2VRPT0=?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 616af61d-7820-46c5-498d-08dde623a235 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2025 11:11:27.6928 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Pib+GXGGE3c4hRwLyH7hB9isoyc7iLtKH4FPRh5Ka7FGQFbFM+540FAXqHirh2SzJsDbyyj5iTfsDGjj19uiEqeuVSeLSxoc+iBTVzHUqPM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR02MB8077 X-Proofpoint-ORIG-GUID: rWncA8Y27KMs9JP5DCuPs9TlGgWkGquV X-Proofpoint-GUID: rWncA8Y27KMs9JP5DCuPs9TlGgWkGquV X-Authority-Analysis: v=2.4 cv=C9vpyRP+ c=1 sm=1 tr=0 ts=68b03961 cx=c_pps a=hSYwUsMu3dPAZ0NekjkltQ==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=QyXUC8HyAAAA:8 a=VVXk-92eaM9LjyQm6BwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODI4MDA5MyBTYWx0ZWRfX+mu32bhub7Pb ZHrd3/2xFNJvtCTARdUG75sLrOaDFNtyyGO4ZpSSyy9qY6vDJXjGAbPw4SdH7NDcr7kjFoyeoFW bDXmARaoKc88PepgfrOwtSMaUs8rUxMWVGqx/ReFD+7BdRmS5W+YSPMangqGf/FBiGHWs9xZyQa jfKlPWYOb/OOW2UbOTwdiDXqQP/sQEPfKDoD6ggvXyyJOg6wpo1lljB4Q8NROTk5BTGdBv3Qo3M vCMVGu34fuBT3WzGKMAKDHmS2phZy4Tc957kCobySG7GjcCabwJbduStTQRcCpBI+e6FXtELJdS 2c/4O4KO4OhcblGmlW1lNUC8nSDX5/JQOJaPeB9MIFIs87Rv/G/N7NXf0u0HIY= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-28_03,2025-08-28_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1756379630354116600 These are based upon the PIIX4 PCI chipset and so can never be used on an i= sapc machine. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Xiaoyao Li --- hw/i386/pc_piix.c | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 5ae265bd53..57b02da5a8 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -441,8 +441,6 @@ static void pc_init_isa(MachineState *machine) MemoryRegion *system_memory =3D get_system_memory(); MemoryRegion *system_io =3D get_system_io(); ISABus *isa_bus; - Object *piix4_pm =3D NULL; - qemu_irq smi_irq; uint32_t irq; GSIState *gsi_state; MemoryRegion *ram_memory; @@ -618,23 +616,6 @@ static void pc_init_isa(MachineState *machine) } #endif =20 - if (piix4_pm) { - smi_irq =3D qemu_allocate_irq(pc_acpi_smi_interrupt, first_cpu, 0); - - qdev_connect_gpio_out_named(DEVICE(piix4_pm), "smi-irq", 0, smi_ir= q); - pcms->smbus =3D I2C_BUS(qdev_get_child_bus(DEVICE(piix4_pm), "i2c"= )); - /* TODO: Populate SPD eeprom data. */ - smbus_eeprom_init(pcms->smbus, 8, NULL, 0); - - object_property_add_link(OBJECT(machine), PC_MACHINE_ACPI_DEVICE_P= ROP, - TYPE_HOTPLUG_HANDLER, - (Object **)&x86ms->acpi_dev, - object_property_allow_set_link, - OBJ_PROP_LINK_STRONG); - object_property_set_link(OBJECT(machine), PC_MACHINE_ACPI_DEVICE_P= ROP, - piix4_pm, &error_abort); - } - if (machine->nvdimms_state->is_enabled) { nvdimm_init_acpi_state(machine->nvdimms_state, system_io, x86_nvdimm_acpi_dsmio, --=20 2.43.0 From nobody Sun Sep 28 15:28:19 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1756379611; cv=pass; d=zohomail.com; s=zohoarc; b=cJmcgUR5DfI5n4s9l/6NXqtRPYJ85yPqtjaG25Ad5Gje7U38PtwzGCD/6kHV717wcdxeFetrzwxCqNVyaTP08H6KWHQMaKlz0lCDABqWWvwBHfDzTWKzEyVS0YuUyRYarwNCIYBjkyDX4i65W92K7ocKBGELj02XJ6MkjwJD3nI= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756379611; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=1k2zklC0fAbTyvFiKp+v5RWKIyMFPDpsdEsSBa9s/aE=; b=ms+cuHEF7aReuKmn45g+a7ChiVuyHd7SqSRvphj/Ws+VYcnfd5Z9no5t+tCUGHsCe+Gbu+eLlbzRBiBobdM/EHWksz2aliX1Fmg1EyzsjcUJ48m7W56zzFcabN3Fk5I+ypwSjhRStFPNU1s6yusX86E+eXj8qhV081tQHOcpaKg= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756379611557831.0236509917842; Thu, 28 Aug 2025 04:13:31 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uraXb-0008IQ-RH; Thu, 28 Aug 2025 07:11:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uraXa-0008Hw-BA for qemu-devel@nongnu.org; Thu, 28 Aug 2025 07:11:38 -0400 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uraXY-0005Da-Cz for qemu-devel@nongnu.org; Thu, 28 Aug 2025 07:11:38 -0400 Received: from pps.filterd (m0127838.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57S6cu3N2960418; Thu, 28 Aug 2025 04:11:33 -0700 Received: from ch1pr05cu001.outbound.protection.outlook.com (mail-northcentralusazon11020097.outbound.protection.outlook.com [52.101.193.97]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 48t7xvhnp5-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 28 Aug 2025 04:11:33 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BN0PR02MB8077.namprd02.prod.outlook.com (2603:10b6:408:149::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9052.23; Thu, 28 Aug 2025 11:11:31 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%3]) with mapi id 15.20.9052.019; Thu, 28 Aug 2025 11:11:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=1k2zklC0fAbTyvFiKp+v5RWKIyMFPDpsdEsSBa9s/ aE=; b=mGDmQXGUTNsGvEmHuiCEa6FAZrDFIW40e7BPjtA2Wy9NuLC1KS4xp6TAg nFbbPP+Msk4D7m3NR9QxDKw6FsI+nZmMKk/Uz1QzXW8r6DBHuMq37lMJyPycqNqe cQhsDTn3y5Bihj423y3BBd7vUrd7AU3YiqVOTzc/dpxfhB+/9gie85+ZHx6g5jAl lPx7oZjC62yMbK0t6+fvi2igOfQwWnmWBxGZDp0GJYhJNF3+3l2Tw27IdI60Qp5Z grSUJhZVmxGRQnJVCKzKnLO9STsOlXpCBdzaeNa7Md4H9jLeaxx0vyLMupqzAmY4 TxyuhLmOgWxZZ3QEebGqU+EBzI2NA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OHn/CpLgtSpCRNGBbioyhWwU+FfU9c+whZWfiBv+nNIt5drMv4bVN8N9tfyLvQGa8hDuK1SI7L+CMie3w1jU0UDmV/mdNhNl+L7y6adJpB612NGLlhjlZ7HTMdrq/1lG4ah6AOy/t8wuvNk4GJvFu11Evvjdc0HD4Su0WrctwozzptC8NAhcER9hjLFIeJkWO2KZNwci4Dekdfa0gX+Y79LHT9FXZ5Tf9tKptXgeFavrpUAQZKHO7sdi0QRdWeFPKqvs2Vec+VDYnpOZT8E95cXtVdPwXvfc5AXh+rCd8EZuYEGBHIq9qPUS60Ls9rpC6iq6Cq1kGMf/K+CkoMTeFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1k2zklC0fAbTyvFiKp+v5RWKIyMFPDpsdEsSBa9s/aE=; b=q1v9NfUhHrZqSxEequo2kUe/dTKJKR8dyC5cvtjEn2r0BZFefV/0/aKp/vXDqoS2f9ZUMff7x6BL/g8UMKb2Ukq8iaqwWSDpSs9WRV4AQB1ETTrL2desCo0jCS5AZMWFC8MKibu0kn/jxeNrnkuNoysu+fZclvKJRJVHeZKzLlExdoEZGBmypRDUiShZpYCSgJG4aRlJc2OHkdwxBfHpPzeZqaaX/w4C7fVK0FqY61Sp1z59ezvTROp4+3CP8pC6KAnCU9+LTTOEtlOnIwCpaOpG6Psy74UjnYKlV9JVMX4GGRFi+IwEj7r75lZorCYdVZX0/KWpWe/2LAlwmt3L0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1k2zklC0fAbTyvFiKp+v5RWKIyMFPDpsdEsSBa9s/aE=; b=smM1KuDQb7uTLQ3ADSlQlbZ1v82kTUbLQjew1YejUhiN9eTEtK+k25If+g/xWRrvkbM0jTX4mvKh9FTucFoFLpYGQ4xgBNvCzc0cd1rIAtV9ikvnYM7OYegJrOqivD509WjarljBwAPgW2MVibOwSHgelKlmUDeEvYH0udSe71pVQAPSXNLRasI35/HVdy0r22av0tZkI/dYwqALmriTEtL2+80csZGcZprfbuQuLU5Lsy8eqpwTjmU6TpwM3a5+bH7/Riq5xMOSaS6mml9Watm4JlyC8b0yJ68UADAKXmYkRes+6c0f+lpQpQu6KziO5sJStOno9frLL1VX9EyPJQ== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v7 09/19] hw/i386/pc_piix.c: remove SGX initialisation from pc_init_isa() Date: Thu, 28 Aug 2025 12:09:52 +0100 Message-ID: <20250828111057.468712-10-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250828111057.468712-1-mark.caveayland@nutanix.com> References: <20250828111057.468712-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM0PR10CA0044.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:150::24) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BN0PR02MB8077:EE_ X-MS-Office365-Filtering-Correlation-Id: 519e683e-caea-4442-228a-08dde623a428 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|10070799003|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Wxb8UC1Ew2OTyzJKOTYYTjZoq2i0smMrwxKHBlUjykXXPr/B/rLC9+FcsBAE?= =?us-ascii?Q?fs27VFSxUXTAPvKyKPVSps0lJiBnZ2te5tGCrvj9Kt4nbkGmGsaHb7b9JDO2?= =?us-ascii?Q?DL4hjPMN8qQd5UV16GZn8ZU02/z9uEr3+Ys5fb4hHlnEVF5fe8Zza5xV5oIb?= =?us-ascii?Q?g/v1DU04zyLICZC/qjypaFhHoWiWmrk9s7B6q1a9DJAYjYtU4AlCNGrY7TqH?= =?us-ascii?Q?vUcuIA0H9NIx53JAYAOWA8XbqLvD1DfpSX7eZEnCmFkE9fsOIVgUA/NiY/J/?= =?us-ascii?Q?itJUYomJhpZW8XpmXUwMSP9lhuaolOMCP37htgBmJmaM2ojkF98KXzDNivQx?= =?us-ascii?Q?ByG8TSqeydOoz2P9Owj9QKUhKXQ9SA47v3qWgi0fvQNvHLqVxNI4mfENX4JG?= =?us-ascii?Q?6CD+kv6A7fncok+P9P1voWZHSUdavA1D/8DXQj22RMlFjXCypvVveyl2d5Ib?= =?us-ascii?Q?2E6wdBJm9WYgUIVODs+rVyKAGw0WHqwzr1vU9lkAlZgl278CI+2GOAQVlwxS?= =?us-ascii?Q?TfSZeDovCJqHSCy2lkxqAEQCqY4QbckJv6B0JWluUyPocdet95M7vCGa1Jat?= =?us-ascii?Q?YQHBmonhV/GaDjS+jLGhUFmXnlgG+rXdSw4eTlDVKB3ho2SSl1dIqSFj1YlR?= =?us-ascii?Q?IAr08vruGQ21ngoS2Zr8LeZ7YIdL5kMZUc1Dz+wx06ySZhH4zSUAAvUNV8Hg?= =?us-ascii?Q?zGDvOzPSz2m2c4FOqOW5mHpTLQRM+gWHGbSxFzIWR2UtIPaIpfW8DjBKpK4S?= =?us-ascii?Q?PcdCu7JOg7dTip+mNhAirWf7ejOtKzKHXkPSTzxw+IsZgOKLvv1vM9Fxb7YO?= =?us-ascii?Q?ICjIktYUrWBO4HNyZaa/RQ2sExfFMi2xzuL0rluvkuHEhHj2zINIjBj9+g6L?= =?us-ascii?Q?i3W76BZjhsoS/sRsQT5IB9RNYzZlVbmN+vIH/eax3We3YXzj11D4kNSEtDNu?= =?us-ascii?Q?HGT8AH11pEqkE8tNZIkwtkkLALYfThE/2D0Rh59ySZbq4+6Xxsbb4ugHzlHy?= =?us-ascii?Q?maBt2LbNhqwWF/05wkbkm3emWXSUGrPcuSYga96OYp4/moWM7wgbwaK8g0lS?= =?us-ascii?Q?dyDV/WKisCq70Wae5s9LlIgLnXtG5gwFGpHqsxr1CwrCTXFonWGCpZ+7y+V1?= =?us-ascii?Q?KUfqs+AJUd72WzwW2+LBSevFjLUFWot5OiZ6JvQmdfQ0zDldBXb3hmBhk5+q?= =?us-ascii?Q?U9hyUus9Uh0/PtqgTD0KVVAc2IwqhPlfg40b2HdLu7HW6H/TiSbiZooOac4F?= =?us-ascii?Q?jFLn9X2jJtlALUzw4GsgI6GOI2E/tTy1VNfKRGIL3lRYrfPXoefmg+D2ioFq?= =?us-ascii?Q?nxCmJMccB6jCbh5kRVoiOrUDYZQcT5Eb65XA5KA/wnLyG+BhR32iDDPBdDBI?= =?us-ascii?Q?OjSupNln/Vq2sEZq3UK5t9YC/3QbW5EpgbixVQq/LVXhV4iMLqSck4G6We9W?= =?us-ascii?Q?/qitguC0eOM=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(10070799003)(366016); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gVVwysDDOm9110eSNmOV04zunI9h1kESOMXpRAfnRT/BAV3eIex8HaF/PdSI?= =?us-ascii?Q?FJM5UvpKIcLZp5qWRy9aUS8Vzkfsp+2h4sMxD22kJ0+Kha+TiAsYvyS6mIg/?= =?us-ascii?Q?GVPp2o2sAZPBl8LMBtoA5joLnUWaf8ux6RKh88fFTCJyyOlhR5mBKKpXwZso?= =?us-ascii?Q?Tb0h5ll+mqCqZBJD1thSN3n27sBGwS8HB+us9prRCNLMJm1FDtq0YLKguD2c?= =?us-ascii?Q?oK7UVn06NH1LaIF8NK6wa1/Iq3i1YgZQHtHBTjCeJRDD2rlI9tvrLDictw+i?= =?us-ascii?Q?Bfvb67CG9+PnGPrtFWuYue5haje+J6x0qhX71YkmOQGAN0waB4o0YgFlZdB1?= =?us-ascii?Q?bHa5Q9JDaNcF7vVSX3bIyYxCh+epOfuQORuWUkGFIX6Q8uV7+BL4dIMKj4ns?= =?us-ascii?Q?qrAaGGwg6JpYi2jKkokgTZht91s0RggN+Aj32YZ4cVJ3vfDhDiNj+1bwI90h?= =?us-ascii?Q?3t7fP6oellHWRXvLBVrZN0gmvIXdQ5HSwnvlatx9uWItQEdMcd/JyO40w6Yp?= =?us-ascii?Q?P2c1lrBC2LQtAjI14V+tuIa8Z5yhcoI1aUt5oEJt1WWDSLrM33yj78xdolTl?= =?us-ascii?Q?s61500hSQkKCd5Y2yMqSTWctC2Cw07AWLHM2+8Q9+QLwj/Ad1mygJm6dULiD?= =?us-ascii?Q?h0Mm2aLEcN5Bcq3J3ypifOM5M44afInXBP3YvLoGCCPbxNlPsx6JSaXP0BCI?= =?us-ascii?Q?QhbeZgw/w5p/yq3CpgLimJOybCYmXnlOrhxmZchVyC/SMPUdnMGB3dyyOo6G?= =?us-ascii?Q?elxJr0w5uNiZrhTXYmzc4yKaQyzgfQMgiGXiqJNWlGEqGzKZnC33yDtbZck/?= =?us-ascii?Q?xlRGmTa60AAesTTqE2cpM1Mt42DJhRoa4mKIIt+5G4xwxDTy210AYA69SSl7?= =?us-ascii?Q?ecPWEW9shGnTLEvzY4qPFtXERPhEte8z193342QK4dqIjAIn+MusKYUuEAkk?= =?us-ascii?Q?oYgmngqCJ7hIQxc99oRKgmdUVxunRCAQhRKzkva09NyskWWI0Az8n7fKQlz2?= =?us-ascii?Q?in0o27PaTpvCoBki1eSJ8h7mBSOX0/QAygTmSt6uISiWSo+WzPQhnO34V12m?= =?us-ascii?Q?mx1FYwNvFuGjTZWwh+N3QupzqFTANHInoEWYsikcNo2b71W4hAz8W4JROv8H?= =?us-ascii?Q?VSl12KkxaMDY6HizlowTtrkuwNKG12WCNFLJeKnr+TgzR6BrQDai5L6+ExwP?= =?us-ascii?Q?6Cdo4m1U3ICMtYpNMtWmyoIABtDFVamdMEGutXuPhaN87PK0nu2bsdO//8Oh?= =?us-ascii?Q?i9Q6wDemF7Rx0TsbvVxK37qQvIB/qkf7BWVLilJtrq8ZX+c+rTODk2llp0YQ?= =?us-ascii?Q?1ZJlu1AzebOAQYd9ppJUL8ZTJYghy+7ghFRlCTtZGjkR71sZ872gy0cnmTe+?= =?us-ascii?Q?pTDhr/jTEb4PsevFe93tvdLRskUE0XSwvOMYnSIzAMe8+7tddsvQz6qm2D83?= =?us-ascii?Q?dcxdN5rW1uU3cUSMxhqC8A59lAmt+GiffDoBrAB/tj790iGUojh79TGQ1Afn?= =?us-ascii?Q?xewUPZ4LcbjVzUAw/LwP83QdfY4CT+zUEgYVuIMYHBmyM/X/Ylq+XJH6Cz7U?= =?us-ascii?Q?zf3eVru7YiZ53C5ooiFsQICZPJhKVHsj4ByZgYGc6JPRPlYAk53kcc7O6o0x?= =?us-ascii?Q?R2eRikXNDACoBjWxfo2bsoO+l5QkzUhjHzRWh5tiCGcR96oT6v4Tljt62sBk?= =?us-ascii?Q?nbYDkw=3D=3D?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 519e683e-caea-4442-228a-08dde623a428 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2025 11:11:30.9589 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rM+9C9jvmiuvE54elYmTK1b5VJroj3oi2tk/kidHJSAovA0EEVe2YmSOoubBH8ABlTnmPAmHrVHEa+gsvQqzOmyKN+ua4IfCdT4ZVb2tLnw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR02MB8077 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODI4MDA5MyBTYWx0ZWRfXzL0/BXEx4IUy 6rUZy4GsVbulR6ZNBrIVVu5LbU3K7/kdBwuw0LFZFcz9hi4WjBWkP3jAAwJPOCUdUb1XWVRqfWn qU1uGg2Vp6NFvRqZxm5XzH4oNn8/YdzJbSO44Dj6ZlZEP4Im8QkrrifXN0jNMEOj9IyyIm4+vmf +y7D/Plf0JV2f5HqLTT3aysBu6IdsV5jY62fFGvERCB8OzLf0eWVzpl9Ob/yRfuSvMdEnxZ82wZ Lu/3rDFkrJgfqHnxQmPCRnQEZ/WtxFiN54rRT6V3b+3KeZsu/63U2RQsxk9gIfxqVUkddY4rs+D AjWrZMbxdx4y0oGOlChnSaFCLPr6qyvUT90Xqo1HHdErEnuvFSLnaE8WlsPJ/Q= X-Proofpoint-GUID: mshAr5fnN2rM5mrHvcg6-OQzRJsxv979 X-Authority-Analysis: v=2.4 cv=Coq/cm4D c=1 sm=1 tr=0 ts=68b03965 cx=c_pps a=WuGjf4t6T1Q5vm5Y5Z/RWw==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=2OwXVqhp2XgA:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=QyXUC8HyAAAA:8 a=rnFr0Qxienu5vtaJ29UA:9 X-Proofpoint-ORIG-GUID: mshAr5fnN2rM5mrHvcg6-OQzRJsxv979 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-28_03,2025-08-28_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.151.68; envelope-from=mark.caveayland@nutanix.com; helo=mx0a-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1756379612161116600 Content-Type: text/plain; charset="utf-8" The Intel SGX instructions only exist on recent CPUs and so would never be = available on a CPU from the pre-PCI era. Signed-off-by: Mark Cave-Ayland Reviewed-by: Xiaoyao Li --- hw/i386/pc_piix.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 57b02da5a8..9a2eee8ab0 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -541,7 +541,6 @@ static void pc_init_isa(MachineState *machine) } } =20 - pc_machine_init_sgx_epc(pcms); x86_cpus_init(x86ms, pcmc->default_cpu_version); =20 if (kvm_enabled()) { --=20 2.43.0 From nobody Sun Sep 28 15:28:19 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1756379629; cv=pass; d=zohomail.com; s=zohoarc; b=FmfL2NwYqEVRv8F/IIDn/hL2i7Y8CUIVZQw5i4oqEFJT05AB1MTzBoyAIUBZnNxhw8zIqxqUzYozyID6vPg/7TAePmEbwG4qd0z/muZyWb1O1A5BpPxI+tpErse4XYZ6H7dFURDJO4aWXgMpOSPaE2mXYLsRxS6ulpf2xDiGPlg= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756379629; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=ro2PcbKiDRS63Cm4YqhBmRjd9WzcxE5GFhsJMGBFEqA=; b=QqdVqR2ULP12Ll5bNWxjwJfMl/4d6s1/4O+vROXt3x1ZHKrK3tXV5k1ReiH0wY4PJGVf+6xEJHAlzYYD0sTrU+cwxSFpegQJkcJyN/ja25bRmDPqMVIYJo5FKk3wpprkDrPa72UgEFAyBb2geOMaTCj8TEqmqMutth3us5nJXYI= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756379628939440.19839702522506; Thu, 28 Aug 2025 04:13:48 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uraXl-0008L0-Sh; Thu, 28 Aug 2025 07:11:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uraXf-0008K3-VG for qemu-devel@nongnu.org; Thu, 28 Aug 2025 07:11:44 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uraXd-0005Ge-Qf for qemu-devel@nongnu.org; Thu, 28 Aug 2025 07:11:43 -0400 Received: from pps.filterd (m0127844.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57S6aJVM2725983; Thu, 28 Aug 2025 04:11:39 -0700 Received: from dm5pr21cu001.outbound.protection.outlook.com (mail-centralusazon11021096.outbound.protection.outlook.com [52.101.62.96]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 48t6kjswg7-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 28 Aug 2025 04:11:39 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BN0PR02MB8077.namprd02.prod.outlook.com (2603:10b6:408:149::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9052.23; Thu, 28 Aug 2025 11:11:34 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%3]) with mapi id 15.20.9052.019; Thu, 28 Aug 2025 11:11:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=ro2PcbKiDRS63Cm4YqhBmRjd9WzcxE5GFhsJMGBFE qA=; b=rC7i2+vuHfuP/YdWTmddptWbrnejJFrj6Ni35mlV42yp5FQeOU+KM7beT Y9N/1fSlko8F6ckQ+j8DpZR5Ashqi5bHNc2YzUwwjdlf2f10a11HFTLBArPo726e BO0LX3jXIxLYQRLZB9rL3VEhafD33GT/L12p6PP9ScpoBG0weahn/4BhPKJrQet9 wSMwa775dnTwgT2GEfFVW7UyHoBWwebl+hbB7zluGVms81Ukhw7I5eXChYiUxETC 1Yq8rDvNfmWtRJlQiJU9e6P6vnSlloliOHMGkHJ1Zk42Hd3vlvHLicJQe5Gj1QY/ ZO9NcWI3DqwbuXoEkzEEnQm0Iy10A== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KYAC3yXivCf8Wys0ucdVo7n7HMEIppn51yrHndMlgFidGkv9zeMaaH38cmJCRuLQSCqCynvuIgDKZwzRZzgXtlx2pL0eiC2bN4QZxaT1QrUwB8c5hWcqKAH56j4z6+6LgDwOfHlAlaoQWVF051GYZmRpE4knPh0d3PXnZh9uABxZc5xPk/KINXEFCrYoK8H0GW6vf2lu9lpgHaq9OcnEWfkOZjRorobJK5O7B+1jhCJfw8xULnHlUQ6iMLAfoT03BcgBvqENFjmvYPsW5fcYIuhH4S2xP3mLLs66nZw3J8RFY5K/wQu8+d1XUMXTSpb5dCRTRdDn2WyDyXi/EyYBnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ro2PcbKiDRS63Cm4YqhBmRjd9WzcxE5GFhsJMGBFEqA=; b=sqkwacG//lrGvXa25dwY3/gSeFTmOdNFvJFxnK4AH4tdGWJNtovH1rlWf/gaSbw/2gr1ltIv5E+IVmU9i17IfqplaSbMhvfNQ/CA/+ZM65AXTWnsEM95YK9RRpRY92qUfiIhY9DesWvKeCG7HQKYxDeGymPvAMRU08R8CJmjI6jpX3uuMmaW6HBhjc13UGWZhERG7PwvpLAU+eallAe2cm+5uomAyKpBFE0Ze356/8+qujUMwzBdrqiJpyywRRTzX5UCanBln36cam5XmyboV7ypp4/caxO+QF0Iamx/BtbrYh7UVf5Bi73iytdddlvcUvekpyM5Kdr9lQt6MPbWTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ro2PcbKiDRS63Cm4YqhBmRjd9WzcxE5GFhsJMGBFEqA=; b=pXGxIhbzDfyrWnXGbjHh/zDaXUL4sq56TjaVpZySsD26iuQ8T6iEs0uYUyZNW4h33kt00jdrAaqRyC6Qb84KOy6w8y0MgHyphiD9csN58PfeP7sbHb/OkAJ2oKto7S4yel3uc2+kDDIPa8HNvRhG1TGaNcr/XN4B/Jwf/QpfeiO7IxKrVNmX3C7BRrOdmdMP5VfCQ6wJk5K5aEDj2Z5HiVPXbXC8IAc76zx5Z1ibLTEJedboLDG+y/UU1iJ9EXdLqEiOLU4fEAyb4oerQdpXgr9vuxAWITGhZ01dmx9Juaj2/V878M0n9g4tDjdFCrjZFWRhQFJTMRPdIEs8Rky1Fg== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v7 10/19] hw/i386/pc_piix.c: remove nvdimm initialisation from pc_init_isa() Date: Thu, 28 Aug 2025 12:09:53 +0100 Message-ID: <20250828111057.468712-11-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250828111057.468712-1-mark.caveayland@nutanix.com> References: <20250828111057.468712-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM8P189CA0006.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:218::11) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BN0PR02MB8077:EE_ X-MS-Office365-Filtering-Correlation-Id: cf1c8d56-9929-4911-5a08-08dde623a603 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|10070799003|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?aUhvdTl0akRWK0g5V1FObERDNzV5d0l2OEI4YzY2UEt6cjRTZnBOa0xXM2xU?= =?utf-8?B?Yk5VTGxzMzV2Ukc0QXpCSEhHM0JJemlmRFpXbHZIcmhmT21PUS94aW85YklO?= =?utf-8?B?cXBDY2t2Y2VlMHpWR0xuRG91TXRGRk0vQ2pLSFFBYmF3dUw3MUFQbWRYaXQ0?= =?utf-8?B?VjZ2MGFPUUNkcFY1R3REdGVPUjhaRGJPZE5LOXE5N2YvNUhEZWZHUjl0emVt?= =?utf-8?B?YzkxbUtxQ3N3NkJMOVlDd3AzbXJJK25VeWtjU2dqZGZDUkJrV21UQkpGSUdN?= =?utf-8?B?YUlxSmNHSE9rZ0VnTHpRaDZqdUtVNE5mVEhyK2dlT3pEakxNd20zNmpJOFJU?= =?utf-8?B?Ym54ZDlJVndmOStDVTVickRsbGZwbWVRSXdlZGQyR1VWMnNBcE5nb1pyWmw5?= =?utf-8?B?U2ZBZW1GUFRlYjQvUEt5cjBJQTZQWG5XNkJYeVZLYUlCZ1N5a2tEUks4VE5o?= =?utf-8?B?Mk1rWlBoZzRqOUNwMnFOdlo2YllQQzhoRzVOeGdiaCtWY1d0OWo0ZUxocFp6?= =?utf-8?B?SklxUDR2elE2ZnBqbFpqY3dIMWo0YlIwZ0lJWCtsNXlXR3NHRUVOTEJMMVdl?= =?utf-8?B?V2ZxanNEU0JJOEJ1eWx5ajhSaUNtdXhSVVpER2htL3pET0JYUGdHTG9KcWRQ?= =?utf-8?B?RXJVZ1d3WDlrNFpLeVRCZ1ptRHlpdSsrTzZvdjB2SmNIUVlsTFZaMkJIVGlK?= =?utf-8?B?ZjZuT3VjaW9ocm5rUVluMjhhMmxQNG9iTFptS2NIb1ZIdU9oZml5MURxdVZl?= =?utf-8?B?eExNeEtPQnhBK2txSzRlQmVOaVVNL2RsRXNKY0tlWHM5VldzdDRtNnMwdTJ2?= =?utf-8?B?ajhPcnY2dndUeGdOZkxWUUJ3dEFjUEFlNzZ1WGg3cG9BUVZsTHFYT2ZSMk44?= =?utf-8?B?UTc5Q1dGQ2FMTzdqdTcyTXpScUpJSEIrQjhNVUNadGdqbXZxcEV0UUtZdXEr?= =?utf-8?B?VzNnVENqTzRhY2VXSWJyb0F2OUJxT1BIMlFLN1BwbVB2RXNsaldZbkl4VDA2?= =?utf-8?B?WXJsU3lUTXpCYkdhM3JtbExjajJnU3JINmp4ZnhReEZHdzFrbWdlR3k2Zitw?= =?utf-8?B?RW1jWEdNNUN4RThBblNhcVVEemRaaFJ0OHlsZXRtVEZNREFqNnphYWxNQTJr?= =?utf-8?B?M3ZBeDVYMllSRnBPK0p1endrZ3RWV1FFOE9XL1VoQ3pUb0tMeUUyWWpmN1My?= =?utf-8?B?WkZQVldiZFFLSDRnS0VkU0VieVRXVURnRjB0OUtXQjNORDI4amVNYU9MdEZx?= =?utf-8?B?R3VUS0RkUVlGdmEvellGKytWZGsvc3B5VjVsV3MrOHdseXV4T3lrcDNkSjhv?= =?utf-8?B?dFhYbllMQlJ5dUhORFR4Mk9zdVUxYUVrUEppeVZGYkJLemM2VWFDWmlPcUg5?= =?utf-8?B?VXoyMWVxbDVYY3Mza3lzM2ZLVGtGb3lzMWNvU3c0aUJ0SXdOckVwMVVwNUN3?= =?utf-8?B?S2RRU3RwRFFhdWdBbU9oK1RCc04vUVlIMTJFZkRTMlYxRExGRTJPNk5hbjFn?= =?utf-8?B?SFlZODhLZ2tlN3ZSeUdSd1dkZnNRYlBid1owSVhaY3hFQ0cyU0Z2aWhZOXNw?= =?utf-8?B?cFMyS1FNNFVjdGtBWUZxbFlkMmM3TjZXNXRlakYydXdidFNnR1ZxbWtFMWNj?= =?utf-8?B?ek53eGorN2xCUFBrNEF1UmFkM1pXRnAvR2NRT3VCME5jZnQybWxUNXp1UWdF?= =?utf-8?B?Mk53QlI2clFMa2NCRjcwTGVFQUhWOU5GVVUrcmxYemg1THhERWVzRlRHL0gv?= =?utf-8?B?TExDdzY2Q3RKMGtBME9zNXZjbm9lVlBSK09CREdxUU03akVDQ2p0MEdxbzNl?= =?utf-8?B?U2g1N2VvS09TbmdhMUU5TVpLTDZoM0k3dXErK1RzTGh4cnpZTW1YUmk3RW5K?= =?utf-8?B?RDczVE4xWHdXdWxyUlRoTjhOWnpPaVo4UVZLcmkycjZ2VTJpUENldGVYV1lB?= =?utf-8?Q?9fgLVvk3B4o=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(10070799003)(366016); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OXRUV0s2TUlwUzZWeHJBeHYzeWsrMERBV1VCVjAxZ1M4THBOK3pGT0hpQWtG?= =?utf-8?B?NlZ1VnNCSmV4T1RycWp4eEU2MjNNZ043OE5VeVJJNXhCdWJ1UTgzQjg2V1FQ?= =?utf-8?B?YTZTaWFBTGh4b09zbnNCdlFUZjZNcS9KT1dLRzlWT1UxbXpyZXJ3T0d2b3VN?= =?utf-8?B?WWlHS0NpczNPTlR5aERib2RGSGFhVFUvd3VqblFzWTZwUnRNK2pjNGNiZXJD?= =?utf-8?B?UWNHeHd1b1JYcmg0aU1panl1T3ZiV1ZWeUNMWmo5bGptYXRzTGVsWm5aSm9u?= =?utf-8?B?Vk5URmVOUWxYeS95c0M2ZjRhUUVidlI3WjhBaDFYM1NncEtXMkRVWHNNWlRP?= =?utf-8?B?V1NsSVVBejduTWRQK2R4MDQrTXlUdWNXdklGL01lb28rdTg4a1ZCZlVnVjB4?= =?utf-8?B?U1JzeUp3VlZkTWVVSmZiYmZyYjBsaGxPdGEyR1pHM0tIcThQdXJlRno2SHB4?= =?utf-8?B?M0Qwa041dllxTld4ZnZJd01CRzVTSk01NGlXMTRRcU5Xc2lFRStYUjgyQjRt?= =?utf-8?B?ZEM4MzVoYUdSOTVTWkRlOWRva0l3N0FNaWpHV0o3RVBhVk42S1dwN0JDUy9X?= =?utf-8?B?WnN2bTVPdmIrcWIzY1RvNHpHendMN1NlWVhBU2RJZ1lMaUw1cDhwcjRCNGNG?= =?utf-8?B?WjdjQWUxSzN4dHF0Zlp2VEtENTlzcVRhVWFYUEhhOEwyRndRUmpvaVo3c1h3?= =?utf-8?B?TUF1Vy9JSFFoRTBRSjVGbGYxaXBZV3UzU3hGNHk0R25kSmlVN1NxSG0vSzdr?= =?utf-8?B?b29jckcwNVJuYXI2d3FoRlRVRlVpUFQ2eFBYSW1MUXI2U2Y1Y0lUOFhvd2F2?= =?utf-8?B?OCtGQStGTjVZZWwrVFpPT0c4aFBwKzVvQ3F2ejBSMFhKcVRhcS94RGt0NUll?= =?utf-8?B?YWpyRXgwbThWN0tiWE4wTjlhMStZMkxiZ3o4bXljTnN2bkJnWWI3c2MzTnZF?= =?utf-8?B?Y1N5N3RZUTFoaDN6dmNMdGI4R1l3VDQ2L2pmamVWNU8vS2ZGQUYvRWRkS3Fq?= =?utf-8?B?a1BSMHpNbTFzYmJzTXJ1bUZWSU9nOEJFSGNJa0RuRGJEVVNNTkFhQitWM3BP?= =?utf-8?B?cU5PbGhBZ01ML3B0NW9yZ0VuY1JTNFF3NVhPeTZpbjA1Q050Q2t2U1pST2VU?= =?utf-8?B?ZURlMGVyZnovOVVXSmlhSFZBZVVSNVlOZHZMQzNyaklHa3pCblRaU3BycmRx?= =?utf-8?B?MGNPdjY4bSt3L1pxUTZHNlRJZWEvQ0xrUEkrT04xZHVPZTZNRy95NnR6SG4z?= =?utf-8?B?ZFdaNlVnQXlSOVBmeHJKVm1EaUZKZElGaUJyS3hjeVdNMzBLdlh4UDIxeWFD?= =?utf-8?B?eHlDSWFoOVdHVXR3a2wxOXRWQTRJVTBIc1J5OVVjMU5EK3MzNWNodXBaeXZ0?= =?utf-8?B?bmZuVitmbVc2bVdQMGtZN3NURHBIcUtrS3F3OXoxN0NWZkZwRURZTFpkcWF6?= =?utf-8?B?bHVPKzhuWWZkdFVjMmw5QnhXenM4QWZ0aVdTUG9FbmZHSHVXbnBxeURmQTJW?= =?utf-8?B?OTZVcTd5S2pvWWNEZ0hkYnV2cnVob2ZpUXRCMHZHeUxLSUhXSGV5cHRHdEtT?= =?utf-8?B?azYxQzRvRUJ2bXlScEpZRHh2TnU2QUZCcytxVEw0ZlRxUjVwajdCU0dmaThp?= =?utf-8?B?cjVGUTJneU9jMFBqQkdaQU9sc1ZlNERyanh6Ukl2T0VpblJhcEkxNUxrS0tp?= =?utf-8?B?RDZNNE5xRnB5NTdmRFFVM2RMV05Hdk8yQWxjaHBaS0h0ODB2NXNvU3lac09O?= =?utf-8?B?N3lOUjY1UUp5ZXg2cWR3U1FWSkwyUE5qd2k5Y05xMFBzNi9wTmRBbnIwZGg2?= =?utf-8?B?ZXFFNnppL2VDcTRhTnlweXcwWHQ4NmpLRW9WdjdNT3pDMkh4S0Z5Uk5hVkk0?= =?utf-8?B?dmlObXNOdXJHRFM2WkxNUDB1QUVoOEhKOVpJTmFzU3ZRaUZjNlRydG5yZ0ha?= =?utf-8?B?REt4Z2EvSXExK3AzL1RZNVFTYXVsVW5qUnJ6MFA4TUtPRnp5aHRydnFyT0h5?= =?utf-8?B?c1pWUzNSTitldDJ0Z2I1QlgrOE9pM21lODMxME5WSzlWN283L09telBzQnM0?= =?utf-8?B?Nys3UlhSQ2VpK3o4ZUtLcmtjbStKbGtHejNwbm9GOTBHdldMR1Nhb0dFQ2Uz?= =?utf-8?B?d1lXWVhGM0pNajFRQmtaRFBYNGc5blB0N3FQRXFKdjVUc3dNb0ZBWmkwZUdr?= =?utf-8?B?WWtwcEFmS3FXT3VFMktqMHFtYlB5a1ozOENRMFMyd3ZuUmdTa1VlV2hBRlli?= =?utf-8?B?SStzTzNsTGtVam8vSkJmVUdSem1nPT0=?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: cf1c8d56-9929-4911-5a08-08dde623a603 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2025 11:11:34.0850 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: saVlwoxUwJ2bY1bfN7e/4EJOOsLaM0sVawG1mUIE1J8AechW0/5MxWFus0kwkMbJy0bUOXIqkg8pj+Jn/ZxSSoDHOch6t/tm3dqEiNczUOA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR02MB8077 X-Proofpoint-GUID: GEi--rgy-7byQxDVxvTYi7kHuEp_VCMi X-Authority-Analysis: v=2.4 cv=c+WrQQ9l c=1 sm=1 tr=0 ts=68b0396b cx=c_pps a=kOv5NEUV9vKuAQ6k4lCurw==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=QyXUC8HyAAAA:8 a=XL6wrB0Zc_gxRR1ig4QA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: GEi--rgy-7byQxDVxvTYi7kHuEp_VCMi X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODI4MDA5MyBTYWx0ZWRfX6qsJnUHWCeQm YFhz2LEp0s548P3P7ls/vU1wNVnCQZdD82dNjyox1m4csMGVYxahu2/nYb6AQ++F6qCBSCR7Zr2 WVtC6XqgA530tMBrU1I6klWjTX1S+91PZ6Z+R/RNgor46oZ4qDUhHYTbOGWrSgW4JlbVXcSxjld BO0zlhVDnRYFdrVuHbgtKo2J+Rfw7hv0N0PnBqnIDC137WZYag+EZqk5NmefGJVUodoQRtV4F+l eaYFQlzEKBomrD7vpwvO8Wbe7yWkkVGQ5pzYsqYnZetCVdFDnpDhuIzjMldSpOSCbnxxEDPG54j r/20LFKYNgxTsLZuKW6+RvhlF/+ajwkeIkAOMZwLgChMtILSmdCrSDHvZB2WM4= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-28_03,2025-08-28_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1756379630279116600 NVDIMMs cannot be used by PCs from a pre-PCI era. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Xiaoyao Li --- hw/i386/pc_piix.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 9a2eee8ab0..daf63a326b 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -614,12 +614,6 @@ static void pc_init_isa(MachineState *machine) } } #endif - - if (machine->nvdimms_state->is_enabled) { - nvdimm_init_acpi_state(machine->nvdimms_state, system_io, - x86_nvdimm_acpi_dsmio, - x86ms->fw_cfg, OBJECT(pcms)); - } } #endif =20 --=20 2.43.0 From nobody Sun Sep 28 15:28:19 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1756379700; cv=pass; d=zohomail.com; s=zohoarc; b=J4+NmrhEfOf7bzUrTYbOAvWNYhQOVQdzWb7wdfvqcwzC9RUqJMjFw5EcxgwFUo1K81zudmJ6f2y8GHvElEox/4wJUuUKX+F/5RTuu3dLeeoiLV8Y0dFlb6RG6Ah14aeP8wbmPT0g22sAJGkJ9a63wLyvjPecFl5coaWkjXaG8yU= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756379700; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=6gCBPmKb6BDo+hi4fwxAhnQKMn1ewxL0KMetUel2lSI=; b=iodpPwsr7psUVGJdYlVkwO4Yl7HbamKGVBqZ+rbTFIrtivu7ZQGNBBE5bO8ymg0fwMCLn5jdAE6tLbfBekEbSUxIyymiNbfCGGiAKylXGV2mVcUmUYBw87SYkKNNmDUriF7z6j4S2LqGH2hca3nwFpOSh+npbwdX4X8+2V3xHOM= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756379700209592.7160706346726; Thu, 28 Aug 2025 04:15:00 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uraXm-0008Mj-D7; Thu, 28 Aug 2025 07:11:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uraXi-0008Kl-8E for qemu-devel@nongnu.org; Thu, 28 Aug 2025 07:11:46 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uraXg-0005KD-Ga for qemu-devel@nongnu.org; Thu, 28 Aug 2025 07:11:46 -0400 Received: from pps.filterd (m0127841.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57SAsHOr3583439; Thu, 28 Aug 2025 04:11:42 -0700 Received: from dm5pr21cu001.outbound.protection.outlook.com (mail-centralusazon11021077.outbound.protection.outlook.com [52.101.62.77]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 48tcc316ke-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 28 Aug 2025 04:11:42 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BN0PR02MB8077.namprd02.prod.outlook.com (2603:10b6:408:149::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9052.23; Thu, 28 Aug 2025 11:11:37 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%3]) with mapi id 15.20.9052.019; Thu, 28 Aug 2025 11:11:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=6gCBPmKb6BDo+hi4fwxAhnQKMn1ewxL0KMetUel2l SI=; b=iEGmm5pBBcRCITySu+gF3QzS9vmGrdaWReG+yyFXNF5EuE2zuLZQxflan gtofgpKPKoVuU5+nQa6qY8CYAWp2Ddx3K2innzCguLqxA9a33SHJdrErmUmm8ZoR E9EidTNG3ap3f1vbqVSP4Z9/Hk9ceUTTA293qNZsh0lbTvfv1LysypMhuiSX2V/M S7OrPTr+YzL8DhFT32RvyLKb2iMLb7W7U0L6vHwAGv+oRXi2a+AbY0O9zvbDZOmU sfRsO5KxOKYAgpDj5zLz11ErDvIDP5pb+q0TARxCQmW0RBk96XTuFJbxqf/hAKHt fGPZ5WJ54MjuJvva+Otc7i1sr9OHg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TQ9TcL/XPQAKdzi9CC6yI1dQWvQcF9WNZ+6z9pUZbjDD+SSIGJzncQmTC/ZSdXtygofW1U+A4+Xtx/+scP6wDhqhZt9NlLHJlwaiY7V2qX88TXmKpCMShm2FtMK9vIVdBjxHkz/HNplbp22WDLbZE7Zvpvq8XEX1Bt+wpWTUnNlaqg5VF4c64GcOtjMa77JoKTAvRTiODHK7f/qpNP3YUwdYaVDyyNLwCQRbpRSe5TURk6ki8SKit0fZ8ml1oBWKYx/ZHKwDLTkgO+MyBkqA0TQQa/vKoBaBCw+Re1wFWTgLu2DzZK7ahkvEzH4lZrU+dK/XhlydsCjQiT5Um01w5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6gCBPmKb6BDo+hi4fwxAhnQKMn1ewxL0KMetUel2lSI=; b=jjNAcs54R06/uiGByb6itJRRyGTlcyZFFpWA4Is2+JyrAUSsISIotYi6AQZ+60oaJH+bUKr8e045Z7hMzbLRL0Xn9hGOpDBaJXPPfy3KODKOA82w8HKcA0wyIme9A/1J1B5kd5wtiaAFvEBhefzMlcuhSn5LNnGFm5aSDvhxZVlO/IgfPUZLtiw+Rh2gasfi/Q5uNRIY7prDfmBO0CtXCPciRMzR/OdBw9IJ0oJ4P7r+8ECIjxLeCUauuoBdbU9iuCdfmBK8n+FSJEloFQfS2CE6fo6PZ8Mq8y0URs8eTLu4BxxxaVCE7YZVooqpvRybiPUeh8zr0etEcZSwBK2yhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6gCBPmKb6BDo+hi4fwxAhnQKMn1ewxL0KMetUel2lSI=; b=Q/SqIn3RReaTKaa3ubLwgURXzXYwp8OSsHFUZOffHSUEhdF3RVVSLmOf8aeleumSJHaPi5Lg7Zxl41FA/JHiiLFENlYIkzOzpWDLzB3+x33eLGbCIyBT093iPweWj2QX7O4Q525v9ByBK6MbzWkPMyPXOV/poBl4xg00JM4XCtCjlX23Jx8JzcuHYenM7oegD6BqdtL40SwB0xamiGgB39X/IRKI9O6fFrdmbltKP4ZgNlb+oNFhn6lyTR680vhAgvDIQLIcE5MZMjTQWkuZFSYTeQ/gvOqst52X/tDUnhO4Guyi2OucoD6iV6aHnCAm/IRTh0f/P91+7t5pUUvaqg== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v7 11/19] hw/i386/pc_piix.c: simplify RAM size logic in pc_init_isa() Date: Thu, 28 Aug 2025 12:09:54 +0100 Message-ID: <20250828111057.468712-12-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250828111057.468712-1-mark.caveayland@nutanix.com> References: <20250828111057.468712-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM8P190CA0002.EURP190.PROD.OUTLOOK.COM (2603:10a6:20b:219::7) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BN0PR02MB8077:EE_ X-MS-Office365-Filtering-Correlation-Id: 2e543af9-78dd-4d26-ed7f-08dde623a7bc x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|10070799003|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?V1JxdkRjSE90enNOdWNxY1B1bU80elpyY3RhT01SRmhIeEl0eWRXcy9JekM5?= =?utf-8?B?cnlraWtEbStiRy9YMXlOeFdhUkwzeW5PaFBOMFFqYmgxcEliL2c4b0FIcjlZ?= =?utf-8?B?T3RQT1diN2NwTjZIMWZ2b2JZazI4OHhEaXR3STh3SXhMTmZHclJlNjNKRkNX?= =?utf-8?B?OC90Q3NLeW1DanAvOUdJUCtVSU1HYnljTmtaeU5DcnRyeHdwck5KZ2o2WGg2?= =?utf-8?B?MjJ1QmQ5Rno4NG9BTEZsR2xnaHRXdFQrVVBWa2J6ODJxa2ZSNnNJVVZvNThH?= =?utf-8?B?SDFuc05aRk5Hc0hsR0Q1VjRacmluUE9VMGNRUEtRSTMwMHlUVEtER3pTNmVE?= =?utf-8?B?RUxSSVZEZG1PUVNWUFkzSFNyaTY5TW5MQldYYlArc1FaZU5LOHhHRXlONlhR?= =?utf-8?B?Nlc3Qkt5NzY1UktEbk91MFZEUXZzbjZOdnJFckFJTTJVQ1F5WHZlVTdKazU5?= =?utf-8?B?WUFRM2hsSGJzYWV3bVVtdEJXZEVOeUlxK3VVdkNrcHgzc2plQkVJZWJtcUdX?= =?utf-8?B?ZEl2K0czdnJxb3JmRGwvRUNpajdNUEhhQnRQNktnamIya1ZzMzBKQnRFbGNJ?= =?utf-8?B?TDYyamlhUm1XSTk1MXNkK3JUM1hBWGd4WkdRaXgwSGg0WHhkTlN4aGRFYytL?= =?utf-8?B?VVF2c29lUVl1SDM4bjhVNGJFaVJ1NXJFSjVHaXlZUXdNbDRZb25IL2VDYUxJ?= =?utf-8?B?R05tOUhERE5ld0w2NjZSQmhHTmRCamtSK21nbk44UmFlcTdzcFdmRTZFVVNn?= =?utf-8?B?a244NEthQUZzVjZvdzdLc2Fnd2FRQzlwTjluNTlqanpveUwwZEwxZDJUYmUz?= =?utf-8?B?OUN4dERSZTJqRGdVR01yVytyUDA3VVh3dnZObmN3a1FiWURFaXNvQ0Jpd1pV?= =?utf-8?B?Q3ZTKzZRdFJBU0hCck1LSnVGOUpVSFl6WmlJb3RHNzBkVjk5SWhMcW1mbStW?= =?utf-8?B?WTU1TnlJTzJMdXZyU1J1eFd2M0NHT2ZBMTBKVDJsUGdGZTR4U20yYVV0Ynl5?= =?utf-8?B?Vjd3dE80ZzJGQXBOL0c5ejZOc1lZVkFxbnQ3V0x2TTlBZlRXS0N6aXR3QktL?= =?utf-8?B?S3hUOE5Yd0NQbFUweS9LSWV2SlZ0OGJEaVhDMDVFelI2SVJ0N1BieTB3R2NC?= =?utf-8?B?cjQyY2pnUVp2YjdzTmxrRGVOczNFVndETXd4UTd4NDFmZERhT1phMyszc01z?= =?utf-8?B?ZlphemdWR3k4b0VIcC8yZUNMa3VOVWZZaWw1SkdETFNrTnhZWHdLSEdTWjQw?= =?utf-8?B?bVMvMkRMMlE3UGxCbW80emNZclU2OFVNZkV1eTBIMENtZ05CcS8wNTBkUDk1?= =?utf-8?B?dVkxcFlod1FlT2J3cmhxazdEb2JFSFMvYVgxVUNKcXQ4RUt1N3NoZ0xPWFIy?= =?utf-8?B?M2N3bnF0b2cvS1pmOStHbi9HT1ZneXlUWlRXaHoxdWJYMStGZEpiaTQyUGp3?= =?utf-8?B?TUJYL3Z5R0pYWE1wMzN6SUM0UmpjWnNHQlhwVkhHT2Y4L0EzeTZwTEF5a0RX?= =?utf-8?B?b1V6aVl0bWpzZDZTUmlyZm9HM2NFN08vcTRYSlpsTE1HenZzcXpKRUd0ZzR6?= =?utf-8?B?dVgyeUMwZDVzRUMvQnBGS0NhTkZqbzFYblBBcWZlaXBUblpQbnZRQ2xnQnpF?= =?utf-8?B?VHBFRkgwaE9rT0pLUlhaT0ZVRUErZ1M4Ryt1a1liRCtrVzFITHRQaTg4NHRO?= =?utf-8?B?U0cxbUhWQk1XQTh3VmRNeko3UjVhWlRicWEreERDekVVZHk5aFZuejlYVHBa?= =?utf-8?B?ZDRCcklGbFdpZE41RVVqVUduMk9LTmZIVmhpOXJTSGRYZDFqZ3hIbDV6Z3g4?= =?utf-8?B?Y081YlhsQ0RkWTFXZjBGRzBLekJIaXFlOVh4SHFtZmVUdW9pOUg5YW05dXZs?= =?utf-8?B?N0J1OHEwV2RoS3VTaW5uWEltdEpqV2duaS9uajF4WmthV0xxUnlScGRTZktH?= =?utf-8?Q?Gdi59spa5+Y=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(10070799003)(366016); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SXRERGhLNmM3UllQa2xqOE5GL2tyczRlbnpiWExaTy9aMzF2YU5oQnovQU5s?= =?utf-8?B?bVBxMXNqMnErSDh3OEdMUUNxY1pDaW9JdDB6cjMzZjZFVjZ5b1Q4bjQrQ0tv?= =?utf-8?B?Zk9wak16WmZqbUwwMnI3dkhOcDZ2L0x4ckc2UTBOZ2lmakNCR2RkalYrQm5l?= =?utf-8?B?aDRrRjI5YmhUUC92OTU2aVVhR2tDeEFFcUlrUGNFUFZhcndBelhSTGt2RlFk?= =?utf-8?B?bzNHWEZBcVhreE5ZUnNENVUrTmRuSmIrdkFucHFYczhLR3UvZU5xV3Q0OU1Z?= =?utf-8?B?c1NFSEVBOHNHcGNtbExzU2l1MnBzNEdVTElwZE1WUGd5UmxrMFVZbFNyOEYv?= =?utf-8?B?c1lrZUxudGtnY2R1MGV1a1lzczJDVmVTTG5VVmVTdjJvT2lRdSthdGRRRkxm?= =?utf-8?B?dFI0SGV2azR2T1FjRlo5MjB6MW5aTVhaTGZYUHRPdTlKZmtoaUk0Vmg5SDhq?= =?utf-8?B?SWk0NFE1bHlSK0RvVnJUVyswcWFrUnBJVjhpcHhhTHlVNHRPTW5lWmZxTEhO?= =?utf-8?B?REZCZ3FoQzdWT2cybFEyYmc5bldtWFRodnBKbmN6eDFBb01jSmJnRzBIbjE5?= =?utf-8?B?RFJ4ZmllaWJwdHZ3eFlob09xVXRjK3NvZyswZDFocDAvNUJiOEVFalgzU2tC?= =?utf-8?B?c2pNZWRvc29sWTVjQ3V6RTNSdnJuQ2FKbGFqVXkxc29uK0ZXNHZodTZ1R1Js?= =?utf-8?B?OVJURjRPa1ZHUERhSlQ5a01HVVpUdStWRmNPQ1pjeGZzM0NrK3VzdGlHVU0v?= =?utf-8?B?T05IVEZoTmxrd3lsU0JwaThzTDQyTEUwK3AvNHNaQ0YrRVVpZ3Q5RkRQZDhS?= =?utf-8?B?Z2NXWGZBZ1dzTTJXNi8rQ0dqZHd0Qm5Wem9VOXlsenU2TmY3YTdxMmYrWHk2?= =?utf-8?B?SlBhUmV6N1hQSnJtWjVVYXFQWXVJUzRnN25keWFjWTFJaGZpaHMrbmhiRllj?= =?utf-8?B?dmtEcUxib2czTDdjOEpSRksvMWF5aUs3TXl4M0U1c21sS2FlNzVzQ2w0Z0Rx?= =?utf-8?B?cGw4T2JpdFRXaG5Ra2FzU0RJS25OUWpKcGpiN1VFdElVVWgxcW9DK1ZPOVh6?= =?utf-8?B?bnFrL1dmQ2xRQ1lzT2QxZjJjNWFucEo5NTc3K09RMzZiNnkyYlJPZVc3ZE9J?= =?utf-8?B?M3RGOWRaQWhlYU5ZM1dIRlFNOVIvY291djBtVHQrdEVQUjErTlJCMWlNRnFL?= =?utf-8?B?RXhuYS9udlFuN0tST2tuMXpBd2Fod0dLU3E5NjZSQXAvQkFBSVVXM3VOV3U4?= =?utf-8?B?RnZldWN2ZjNJMngrYVdhZHdZTWNHUm1qWktSODI1WDAwdTFCRDZZc1VTL3dG?= =?utf-8?B?aVQ2bDNIOUJDY09uTlZhVGJ0S1pXemV5TmNYaFR6RU1NTld2NFlxOCtVMUpJ?= =?utf-8?B?TUJlWUxXc25KajJxcVhma2JObkY0ZTEvMmdOYktKUys3RU45eGZBbkpGWkM4?= =?utf-8?B?VXhVOG8yK0pjQzlnR2N4VGxTQVVTaUtrUVV2UlFRaG1IVlVWdXk3UUZhS3JX?= =?utf-8?B?UElLYi9MTVI2Njc5dDVRS0xQWDRjMXNNeXdYNnlJMHdTMFFPZjc2Yi9kZjBU?= =?utf-8?B?YVl3M3FadnJmZzh2ZlZMZnR1bFRydE1xZk1nUDdDV3JENkQ0UnZaT2QwU3di?= =?utf-8?B?eDVXbmJralQzeVQrcmF0QkZkNXhkelBGYzNyV21QTUJoK0Z6cWpXU2czUWV2?= =?utf-8?B?WTU3N001MGYrWlRNaU5KMFZtSytxWXFGcTZXUkRpSkdsMjB0R1NPQ3pNLzZ4?= =?utf-8?B?TVVlalNGa0lBekVwMDAySDI5WjJKd1BTbEU4SzZCbE0zUGtyWis3T0E3MVox?= =?utf-8?B?Z1VDN3hXV3JjYWE3OXU2aW1pc2V2YnF3aVRaVEc1NGZQVGgzeE5XRDhmMWJX?= =?utf-8?B?VnMwc0NscHJRYWRNeUtyaWszS1JVcXNDMkV4Z0RmT0IwVFVVTi9rckZncG5Z?= =?utf-8?B?VFRaZVJLNkJ4d1FTTkVnSVFzS0JzWk5IOUZ6VHQvTzRsYnAzQUNNWWF3bWcv?= =?utf-8?B?bDlyejQrdTBpaWhsUHVtUG9tbHU2NGxqMlJSZVdEcUFlRkNlT21QOUZxbjVq?= =?utf-8?B?a092eVFaWTNTek5VbFQrclowQ3JvZ3BySUUvdEZnaDFYYkFaUUhmMHlWZ2Fa?= =?utf-8?B?OEpkaGhvT2VTWCtac21ZQm5oSmd4aDM0YXNTeDUvaFF6QTltWGR2aGRVSGx0?= =?utf-8?B?R2tQeDlPdWxrZm5JTElNRXhLYldtTWlCZVRVSTlISXFPa1pzZlkwVWV3ZkI1?= =?utf-8?B?Um9xcTBmSy9PL3Boei9pd3Z3Z1pnPT0=?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2e543af9-78dd-4d26-ed7f-08dde623a7bc X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2025 11:11:37.0772 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: moxcwZ11rFNdhALBTN8+xLv3/YMvzFcNYHFB5mAxV/HF22Ies8B36/vcHzyKFWmB0GZt/q3DJlI5CPH5okLvDVZ+AnQUY1ur7HQgXGj1By8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR02MB8077 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODI4MDA5MyBTYWx0ZWRfX3BXrVL4jxaY2 nRCDCUHjnNHos0EXMw+2HQ+Y9dTM/zhbDtlh7aYAjlCSb07awJWALIYxpXkGk7xBW2MPzBJrk9R ywTXTLXVJjiasF4tcBoGJFKtgKAQGa9qvygNOIVElnYbmgCbPmWQ1xP9lHdHKp68hOJVVMn9vGp 95ZUHHxN/VcaSv116J/la5pSuYl+kY9PGiR1sQUX/4+iZ3or/WNihB8qUuxLllKpSbvgL7tA+mI Fc6N/D1Bydba3ScuE30MUIXaeHgO5bdZk4fqpoXOVcv46soI+3ZBi41Pr+U/dCDiIeJgvWUqblt 9TSH0SjDQDVldRtOPHNb377swWuvoriy9pl2xaca2SGyOkW3b4IJ7BmRgbXffA= X-Authority-Analysis: v=2.4 cv=JaS8rVKV c=1 sm=1 tr=0 ts=68b0396e cx=c_pps a=Qy130IFfx9qnCPISBCfGtw==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=6UsSGvHFbd2T1CAoJbIA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: yddBwrHaM7pBgPuwDbQVB1lg07LZDqaI X-Proofpoint-ORIG-GUID: yddBwrHaM7pBgPuwDbQVB1lg07LZDqaI X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-28_03,2025-08-28_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1756379701349124100 All isapc machines must have 32-bit CPUs and so the RAM split logic can be = hardcoded accordingly. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/pc_piix.c | 58 ++++------------------------------------------- 1 file changed, 4 insertions(+), 54 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index daf63a326b..0bc033943c 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -445,7 +445,6 @@ static void pc_init_isa(MachineState *machine) GSIState *gsi_state; MemoryRegion *ram_memory; MemoryRegion *rom_memory =3D system_memory; - ram_addr_t lowmem; uint64_t hole64_size =3D 0; =20 /* @@ -480,65 +479,16 @@ static void pc_init_isa(MachineState *machine) } =20 /* - * Calculate ram split, for memory below and above 4G. It's a bit - * complicated for backward compatibility reasons ... - * - * - Traditional split is 3.5G (lowmem =3D 0xe0000000). This is the - * default value for max_ram_below_4g now. - * - * - Then, to gigabyte align the memory, we move the split to 3G - * (lowmem =3D 0xc0000000). But only in case we have to split in - * the first place, i.e. ram_size is larger than (traditional) - * lowmem. And for new machine types (gigabyte_align =3D true) - * only, for live migration compatibility reasons. - * - * - Next the max-ram-below-4g option was added, which allowed to - * reduce lowmem to a smaller value, to allow a larger PCI I/O - * window below 4G. qemu doesn't enforce gigabyte alignment here, - * but prints a warning. - * - * - Finally max-ram-below-4g got updated to also allow raising lowme= m, - * so legacy non-PAE guests can get as much memory as possible in - * the 32bit address space below 4G. - * - * - Note that Xen has its own ram setup code in xen_ram_init(), - * called via xen_hvm_init_pc(). - * - * Examples: - * qemu -M pc-1.7 -m 4G (old default) -> 3584M low, 512M high - * qemu -M pc -m 4G (new default) -> 3072M low, 1024M high - * qemu -M pc,max-ram-below-4g=3D2G -m 4G -> 2048M low, 2048M h= igh - * qemu -M pc,max-ram-below-4g=3D4G -m 3968M -> 3968M low (=3D4G-1= 28M) + * There is no RAM split for the isapc machine */ if (xen_enabled()) { xen_hvm_init_pc(pcms, &ram_memory); } else { ram_memory =3D machine->ram; - if (!pcms->max_ram_below_4g) { - pcms->max_ram_below_4g =3D 0xe0000000; /* default: 3.5G */ - } - lowmem =3D pcms->max_ram_below_4g; - if (machine->ram_size >=3D pcms->max_ram_below_4g) { - if (pcmc->gigabyte_align) { - if (lowmem > 0xc0000000) { - lowmem =3D 0xc0000000; - } - if (lowmem & (1 * GiB - 1)) { - warn_report("Large machine and max_ram_below_4g " - "(%" PRIu64 ") not a multiple of 1G; " - "possible bad performance.", - pcms->max_ram_below_4g); - } - } - } =20 - if (machine->ram_size >=3D lowmem) { - x86ms->above_4g_mem_size =3D machine->ram_size - lowmem; - x86ms->below_4g_mem_size =3D lowmem; - } else { - x86ms->above_4g_mem_size =3D 0; - x86ms->below_4g_mem_size =3D machine->ram_size; - } + pcms->max_ram_below_4g =3D 3.5 * GiB; + x86ms->above_4g_mem_size =3D 0; + x86ms->below_4g_mem_size =3D machine->ram_size; } =20 x86_cpus_init(x86ms, pcmc->default_cpu_version); --=20 2.43.0 From nobody Sun Sep 28 15:28:19 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1756379740; cv=pass; d=zohomail.com; s=zohoarc; b=DQhw+uKRpHvibcFOdBELwwMsjMAGqLTmvAhJfOHwmOe2lxKJ8JYsHacaUGl5Fmlq3QzOh9I7ZIKJWnDaIaKpkgXf+MmXgoVpWUiKY7EqGUmpG2WWhMXoF+rx9515l9VKGIhSLNdE4QPp0KWbuBpSPmP9wrball14lHfXo7oL3dc= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756379740; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=a/urwUXHjEYKhPmT7pUu/Stl3Zm09Y9o+oLA4A0fo2o=; b=BhJsgbdNvf2bTO45IjMaiQdGl+d6RVzYXC/8AxFQW4inlpvnSky2eWCuQwJSJcOFniqlZQYpTgK3Ysw/fjtX3ciFvZtNFpQnquMyentxdHr4DyBJcl0k1GnVeV+mGu9xZ40fNqqVeXC9jf+j+uai6kmvMLhkB7sw6VxFLoHqPyw= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756379740929216.5616807754568; Thu, 28 Aug 2025 04:15:40 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uraXs-00005z-S8; Thu, 28 Aug 2025 07:11:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uraXm-0008Mz-CZ for qemu-devel@nongnu.org; Thu, 28 Aug 2025 07:11:51 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uraXk-0005OH-I2 for qemu-devel@nongnu.org; Thu, 28 Aug 2025 07:11:50 -0400 Received: from pps.filterd (m0127844.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57S77Yjg2726376; Thu, 28 Aug 2025 04:11:46 -0700 Received: from dm5pr21cu001.outbound.protection.outlook.com (mail-centralusazon11021078.outbound.protection.outlook.com [52.101.62.78]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 48t6kjswgd-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 28 Aug 2025 04:11:46 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BN0PR02MB8077.namprd02.prod.outlook.com (2603:10b6:408:149::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9052.23; Thu, 28 Aug 2025 11:11:40 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%3]) with mapi id 15.20.9052.019; Thu, 28 Aug 2025 11:11:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=a/urwUXHjEYKhPmT7pUu/Stl3Zm09Y9o+oLA4A0fo 2o=; b=R7ZlMK7PozTKTsmvyhNMWMv9Iw1YApo9A/ej4iVZF5/1kTmUy/C6tyPfD bc4TlNtFgnD93F45P6GyS2IKjwpSFo4fUVz4wqn/CL/veN3hpLKIb69BhTbh1hft b8IHY++EM0ZOY44azVttUZhpCwq07F8IFh/blOMupkEdFqpO7zbKw2ejkFxeE0Cd flR7GZq7dac5ZsBY7pbJ1WHkP/kWxm5QRDMUZF/M6VPf8ZuFHSW3JdEogHzFjWGp IGnVQn424X4Xia4bv6TMfvxYQj5OOXLu7hjlfjla2iZ0y1E+bp9MQo8cnXJgHuvj kbfq2upChGkWrqdoNWqYBQ0/rHV6A== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rqQu0/Iym/NfNmqBBEGmgzePRTvCu/c6d4s5+6RGmUYvflX8u/DLfczMlcEutmorNDDz/K9T0DljR7afyWAyGwnwEKW7TDGykGN80DuJahG7xXC8dSvhPbLaY00eoqYa0ptdmcv7du2Vhd250vt2dwo7GVJEJsZ2BiXeKyuZ7/jQyPbIBHOca8XLFxaqMtPUPbjNbYUwCLGFn2UQSllFAL+1ZXf0MlADtS74/ZV4dudaQbcFJmDABrMZgHFDvHEd+8YnJ4hsv/KfZHqQa2QbCUoalutMs7FxArYzJI/GEwi8XzHwokUQeDxCuoXXMC8qcOUGb+ShpOz/A4qIduRdOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a/urwUXHjEYKhPmT7pUu/Stl3Zm09Y9o+oLA4A0fo2o=; b=rTPv4vFUJKf/XR+yl3Lr43e8lPi6he0eEGu+lMu4G5P6ok4CJoCiRRAkLvNMLMOPe6AXK6vnMOaXkDaWMZisDPyLOMi57fUYswuycxZ6U5rcKsMVFxh6QFokIW6OAQR4Y1/GJvv7mU17MgmZbUAPCQw5w1M8ypU/9t4mAjW5ehBF4U7gua9EKMhSoH1K7hEa9JJA50H9DvQCh7KvTTYYXrm60wha5xvHf+i8RQ8s89NTQSjIwcqaY5XkAby1hdJVrcQhyuuXNgDtz53AiH7SWeNNLonwWro0ZmCFVeD+Fr+x/RyzGA8iJJCHnuDkEKKfI7duv/16RylebJ8tjA45SA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a/urwUXHjEYKhPmT7pUu/Stl3Zm09Y9o+oLA4A0fo2o=; b=CO85yoissP4LV9dmrIiA0TNVIfS9xS3cr+k3IP9U3lCWyN9ar6fv1dsKm7n3AjmxS2N2FQ5WzSTDe1dtb9aI/N7KRhR5EBSr4wB4cX+6CCuuMLPOHs+wMXfLC9B8WXhlqftNLZB4VioJfQt7sPgtF6caXrVXvitgrJD5UmRx0ePthHy5ZHzctjGbqjWked9XbyhNF2cWYQFNiEJTNBub3qEKkeP2R0JXFKpOrev+NRjHRD86n/AkOBZFiLC+379EIqVnVo8RwnllzIkOJnoc1/6TUvSCQ+x49qgO5NsBs9v7ta4NBB0BbtG7LPfRZy6pAaJ7pmxvgwY5OzcKydJLPA== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v7 12/19] hw/i386/pc_piix.c: hardcode hole64_size to 0 in pc_init_isa() Date: Thu, 28 Aug 2025 12:09:55 +0100 Message-ID: <20250828111057.468712-13-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250828111057.468712-1-mark.caveayland@nutanix.com> References: <20250828111057.468712-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS4P251CA0001.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:5d2::19) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BN0PR02MB8077:EE_ X-MS-Office365-Filtering-Correlation-Id: 126035dc-d7aa-4413-5db1-08dde623a9b2 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|10070799003|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?T1ZEMFg2dU5DWUp2TGdNQmg2RnQ0YWk3ck9mYXBlLzN4VHZMY2x5VE9ZK2ha?= =?utf-8?B?NVNpZ0dtMmx5UXZhVjErNXBYYUtIQnhqQ1ZGWjlTTDhCWWIveHhGNUdmZ1NM?= =?utf-8?B?WU94R3hOc2p2VGF0NVNYMnpyR2Vkb2wxcmdpd2dSZ29hUTVSNXljTHgxTDZz?= =?utf-8?B?UjVXWXE1cGdFeVhsTGFac1JncFlFbndyOE9kQTZMdHA3NENURFVIem4xU3B1?= =?utf-8?B?VWxvaG1zbEx0YkExSllmd1lnaDJTTmdKcEVzSW04aEJHYSt6RGhuQVJ4Ritj?= =?utf-8?B?VzZXUnJPWFdKTWNYQnllcHpUVnJjSFY2YmF1ejI1WDFHQmxwQWEvbG94UmhI?= =?utf-8?B?OGdQS1FCby9JZmtpWC9jZm1iVit5bFlrZlBGSGt0SjhRZ24zZnd3NXF1blo5?= =?utf-8?B?aklNZlI0aDB6NCtrWGpPUnJkU1N3bE9IbWM5UGtHZjBvYTlGcU1nWTdnQVZN?= =?utf-8?B?SSs0S29ER0xxZWY5NkJVdlI2UGoyLzFMaDlxbkpDQ09LZTM3dmh6dUhWSmRV?= =?utf-8?B?cU1mY0dkUE03VjJpU3dIWHdCbml3NWsyQ1haMDJ2ZDNzM1NabmZaSFRLbFlU?= =?utf-8?B?c1ZSZkNaR2owalZvY3RBUjZiU3NJYWJCcFNmRysyODBmamdmOWt4ZFZHZ01u?= =?utf-8?B?NFp6eExXT0FrVVdURDBqZjBYb21NLzVyQjlaUE1qSHZnVjNaa1RPcmh1eDY3?= =?utf-8?B?QTFaU2ttbHhIcnh0bWpxYzFiZTVKM29mQWQ1Nll2akVOUkFUWDArN0NZbGdw?= =?utf-8?B?bGN3RnQ0bm1FM0tCTGs1TUpZdkFOYkczN1c5UHc4YUhLUE1pNUVFSk9sQTNU?= =?utf-8?B?eEV4aU15Mi93Ly94Mmhpek5GWlZmVUIydWNPeE5lWkRVWi8xTGs5aHNSemNx?= =?utf-8?B?SGFHRHo2S0w2emkxRkxCS0FqdG8zZFdrbmIvSkJxSlRxL3BrVkd5dkhzYjAw?= =?utf-8?B?UHpHL3BwRjJPZEs0aTAyNmtuVDRXR0VWbDdsTlF0SjZYcCtUU1NLb25ZNWFi?= =?utf-8?B?UGdKWSt2T05jRjhUdUcySXlmOU43dWgzZHcyT1p2Vk9Ud1JNMWJ6b3BFcHl5?= =?utf-8?B?bDArcHpkNVR0TlphRmJDLzRXcktvWFMzWlJreGp3WUF6QWlNbm1OU3JCanBU?= =?utf-8?B?Tk9wOXM5djV0ek1pY2JuZTFRYit6MzNGWUlDdklYYURJWjlVd015TnBPdVlq?= =?utf-8?B?ZGJvRUlpYWprRTQxcnA4UFYwSzZicXpXNXVmWEt3MTU3cnY0b05TZnc2YmNW?= =?utf-8?B?WC9PWVV4MUlzN0Z6NzcrY1plZUdCOTAzY244TEF2akg2MXpESzBVdE1mWTRS?= =?utf-8?B?Njh2OUsya1REMDIyVXRmWFhzMUlhTGM3MDhiVEFtWFNiN1crZ1ZTWHlqbGEr?= =?utf-8?B?VEhrbFBEZFFSckVKdTlqbHhRdHZxQS9hWXJnOHRiMjBmd09rTE1MQWhWVjFs?= =?utf-8?B?ZG1ITVkvVm1OTXBLWStVeUdTRDBpSmJQeGpjNnZxckpMa3htNGpOZDFLM0ln?= =?utf-8?B?S1E1ZHNUQTY3Y1I1eExLelloaTlQZ25YQjdCckg2ZHVNRlJGTTdZbGJncGJ0?= =?utf-8?B?VjBHbUU0SHFJSjR6dkYyMlNTdnlKMEc0aTdraWJzRk44emVlVWlFN2E5MlA1?= =?utf-8?B?QTR0YXZrcnhaanQxNUR2Qlo4YXlHVW5xRVZhc1Z6U2tIQmRVcmxQTWQ3aUZN?= =?utf-8?B?QytPVHRBcU1LbFdJUitOR0lMQm1MR2QzQ1V3UmtCV2ZxZHZiZWVGZTEzcHNQ?= =?utf-8?B?VVNURUVjUGp1V1E4czd0SjVZRjlpZ0ZJdmRjQUlZYmhMUVl5WHpuZkkxZU5X?= =?utf-8?B?clk0WnVrRThkWFRiVjlRR1Y3aTExUUo2WS8xcHlZbmhWcEt1SzJ1cFRjRkhQ?= =?utf-8?B?NGJmVzdyNHZoSkt0cGpDWVlFcnBuYXJtdFltUWh6MkE1MFE9PQ==?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(10070799003)(366016); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OEhPK2R3S3RseGJ5TGVaazNYTzFQM2t5Ti9UTnp6VDlqWkgvM3J3VklPeUVE?= =?utf-8?B?N2NZVzBuMFVsdit2WXV6bDczQjNicjFOU2UxM0hZMEdqUm4vYTZjNlY0UThV?= =?utf-8?B?Q1BnSDY1Qlkyai8zK3k4cGhWUHZORjQvZHdLdnlueWFSUXhHR3ROd3J0QjFF?= =?utf-8?B?azJNZlFyZ01lbFAyck9Sc3RiS203Mk9RR2VhcTB4R3hhOWdaa01TZzRXbUhQ?= =?utf-8?B?RkFsQnZOaFJBeml6Sm5GSE8zcXJGMnhzTlZTa0tPaE1lYXptZk1ScXgwM0hD?= =?utf-8?B?WEwySjBLcTdleHV1dks0L3N3bm5wS1VUNFZ6bG5YbFRnYVMwb2FWYmJPb3Bl?= =?utf-8?B?N1VaSDRUMGVYNDV4WjNoaDZuZUluODl1OHc2c21URWdqbFdIR3EyajEzeDZT?= =?utf-8?B?cHBZWUowVlhhR2U2SjdPQmN5bEx3cmF0ZlNYMlZvMDFCRUR2aXZXUi85alJJ?= =?utf-8?B?dGwxQm9xaW1yMHBCYlZlb1VMaEJjQmhZZ3NrTDFTRWx5UURzcVpGSUI4aGJR?= =?utf-8?B?OW5OMVNDb1AydXVGVk1rYUxBcGE4ZCs3c3Q5Q00zaXNOSFhFZlRxbXVaWk4v?= =?utf-8?B?WDcyUzUyeHVLQVA1RmVZaCs1Q1YvL0lqbFIyWVBOTXlUejN4UHUzem0xb0FP?= =?utf-8?B?L2dOcEp1VG1FWnZkcjRJSlgzSmJBbG5rZW1RZ0pLNkdYa1FYR2hvTVFmMXB1?= =?utf-8?B?KzNCL0ZoQXd5OHA5NWlhM09zdmtYd0tNSXdsME1PVkR5M3JLRTNST0syZ2E5?= =?utf-8?B?akdKa3VzQTJaclRGWTRSU001M0g1d25iZjg1QkFIOFU4aVdpc3pnZCt5TFBK?= =?utf-8?B?MW5sdFcxZzhhalFZamFFeHJiOUNFSW8xZDZJMU05WXBFWVZVbXZrNk43U3V1?= =?utf-8?B?L05pT2FiSWl3NVdtQjBrT2FOVTk3eGN3NHFCekZQeHBtRnNJNStOckZFMEoy?= =?utf-8?B?WXNuQW1waU44R3BVQ2xvZEhMNnMrNS8rekp4V0lLeG9rODhWcldwWCtPYmQ2?= =?utf-8?B?blBvNFdTMWpESGpkcFN5RDV6ZVlad3VUTU1YV0tkdHZUV1NTOVlqOUU1ejB4?= =?utf-8?B?WWFLMHNCanJBVFNwQWhUUlNNdHoxRFEwRzhpTjh0bkp1anZlUkVyQXhvcnJ5?= =?utf-8?B?ZmhjVkFNL0V3Mnc0STYvS2hVQitvaWloN2RqY08rYkhsb2IzakR2L3drNWJT?= =?utf-8?B?V2xmN25yaXlOYmNpYWFkSVkxUWd2MW5ZTkxIVGRkb2FJYUhuZmFVTEVVbGdW?= =?utf-8?B?cENhNUoybklPNFRtNE1uVWt2Z3llZHArMGJMVWlCbGEyZkl1cS9SRG02SjEx?= =?utf-8?B?YVdJUjBKNmg4QXNxWVd2aEtEYjdpbFk2YUl0KzUxdUREczVlNnN1RlMzb3ZP?= =?utf-8?B?bGNSWlVEMUVxd2ZaQjdrZmt3ckc2TWV4OS9jaUc2eTdpc2x4c0x3M3FMVi9U?= =?utf-8?B?dDZwck84R0JvTk45L3BZZGprK3dITGs4UEViV21nVEw4Tzc2WEZDckMrT3ln?= =?utf-8?B?bUhlV0dCK2xTZWFDM20ySTBEdkpMR2dWMFZ5eTBQMnhCb2IyOEt3MFA5ZGhq?= =?utf-8?B?cVhkNk1YUjViTXdtVUlBdWJsNEJuMmh0QjFpem1BeHhGcEs1Yys2cmhESmFH?= =?utf-8?B?VHZZeTVTTS9yYUdUYU1SS1dGdlh4SjRDSmhMemV0UDFhcDVqVXdpTFh6MmhV?= =?utf-8?B?UWIxZERaeDFEdElqY0s0bEtEMjBZa1hkYlNUWFJ4b05Ea2ZDL3NhWk14RjZB?= =?utf-8?B?VHU1SlZ2clQ1R0RZeFREeDJHYTNianJzVEU1M0JBZnlUZzR1dnF2U3ZmaGlV?= =?utf-8?B?cWNSNEIya2ZyNk9Yc2o5SjZsOXlnbFRTcUxCdnc1azB2N2VaL0ZDQklEeGgz?= =?utf-8?B?Q1VVYXpzSE9tcTExbi9NY3FuQnN5bG96WHpFU3YzZVU2UFFjNmdqYkhJS0ZG?= =?utf-8?B?eTkvYVIwb3dWYXRXTkFYNVh6cGx2cHRja1IwcHpVZVNOZWxOaUszeTNsdmRX?= =?utf-8?B?RkF0MU9sS3phbGFWSGhxZHRsRFltLy9FOURvZXRhY1MzcVhEVDUrblBRMXZo?= =?utf-8?B?QkI5YnYrWmV5RUlBTHdUaGxuaXlabW5tTW1xbWhyRDdMMkl4NzJoYU56aHUw?= =?utf-8?B?TVVmMjdHTXY1QXN6Qmt6TkxlUms5NHZKZFJLbHM1RVdrdjcxTkVvZnpPNkVl?= =?utf-8?B?SzEwNTFGRk50N3pmdmJmMzlTM3d1bEIvUG5TcEF4K0FCZkdIOEVaS28vOHhi?= =?utf-8?B?T3N1TC9oY0pXWTRqYmVVVmhXQitnPT0=?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 126035dc-d7aa-4413-5db1-08dde623a9b2 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2025 11:11:40.2484 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nMNQgWwIJ5lz0RlnJjQ2IcrUFf2rhBeO1epnz+do59ehBmKcVaLezFL8wHK6CjcTvGFfSWnAbfvMueO6nocPAwhbE3Psl0Z8bP+fDVn2RGI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR02MB8077 X-Proofpoint-GUID: PZy06PjWdU5_05jt1DpvdkOjnGc-VzkC X-Authority-Analysis: v=2.4 cv=c+WrQQ9l c=1 sm=1 tr=0 ts=68b03972 cx=c_pps a=c/RC1Hvpwd1gfJZSTjwoVw==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=QyXUC8HyAAAA:8 a=VVXk-92eaM9LjyQm6BwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: PZy06PjWdU5_05jt1DpvdkOjnGc-VzkC X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODI4MDA5MyBTYWx0ZWRfX/7mPLbbrRB+X fr8G5r1tJCNo+ASgb8GMvNKlOGLjWuKgGy0XUYch4XeUlbsXrww8xRPeEo9iKPjSpEMH5n9fazc ISJurHWriczJ3DXr88tOq9c61HEo6FD/DXYbMltxUJ2vGRX/Qq3j9+u0KiMAQDfBMVKFMDGXP+/ st26jISAfIBHQhI4DA5JmOwp/TyKkL2dVwJ1FWjx+CpCxX3kIaHn6kVDof23NgUX6Z8UBhgbOnv arLWotYoY6LsSiJAGyz5RE+9yeNcGuv011l/jNZ9JzTQ3jHVBbviAli6npyKDm6t2YbOvLu3X97 4vBi1kE5qsLDaDjR/uCJtDq0DlYc83opl8vpuXHYtZPyzmeE+rqoZUaWS9bZcE= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-28_03,2025-08-28_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1756379741865124100 All isapc machines must have 32-bit CPUs and have no PCI 64-bit hole so it = can be hardcoded to 0. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Xiaoyao Li --- hw/i386/pc_piix.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 0bc033943c..66dc4a5186 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -445,7 +445,6 @@ static void pc_init_isa(MachineState *machine) GSIState *gsi_state; MemoryRegion *ram_memory; MemoryRegion *rom_memory =3D system_memory; - uint64_t hole64_size =3D 0; =20 /* * There is a small chance that someone unintentionally passes "-cpu m= ax" @@ -499,7 +498,7 @@ static void pc_init_isa(MachineState *machine) =20 /* allocate ram and load rom/bios */ if (!xen_enabled()) { - pc_memory_init(pcms, system_memory, rom_memory, hole64_size); + pc_memory_init(pcms, system_memory, rom_memory, 0); } else { assert(machine->ram_size =3D=3D x86ms->below_4g_mem_size + x86ms->above_4g_mem_size); --=20 2.43.0 From nobody Sun Sep 28 15:28:19 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1756379593; cv=pass; d=zohomail.com; s=zohoarc; b=XW0IwwV5rX5AoSsfGFrBasZCpD3s2dl2hQ9Y8K2pSDsuGLImZrl3jbrQGkQa2kZSAIbWhJEEZTeabU2YLap18YFr/KzZUNdxvvIY/g0uyP8n+KN9G5FU6b4aoUv9A+4xIF9+XjmtZUkIstHLFBB53lG+eNiE1XfMbSUyZ8QfLiw= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756379593; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=Zm1F9op89tc4d4oP/vmKD+56ikoXGlSHJGplnTa7zyk=; b=VhcgN7DbgS5Jf4xlUOS118YoE6YjADqWhdOtkyDa8BmxQvgzm4tVAt9nDr4C47bi7S/9okqtduYj9qkaJH68lLrV8hdgAmC7jJcJ4YU31Kq3EeyIoFF90p/qn6K9kDmIbzjAAOzfaaFftUQnYQsMaX/Pg+9nsgJoGFPNQ3Sj57I= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756379593740537.4487328214468; Thu, 28 Aug 2025 04:13:13 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uraXr-0008VD-NQ; Thu, 28 Aug 2025 07:11:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uraXo-0008Ng-JT for qemu-devel@nongnu.org; Thu, 28 Aug 2025 07:11:53 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uraXm-0005QF-TO for qemu-devel@nongnu.org; Thu, 28 Aug 2025 07:11:52 -0400 Received: from pps.filterd (m0127842.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57S9SlST1760097; Thu, 28 Aug 2025 04:11:49 -0700 Received: from sj2pr03cu001.outbound.protection.outlook.com (mail-westusazon11022092.outbound.protection.outlook.com [52.101.43.92]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 48t00vjx2t-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 28 Aug 2025 04:11:49 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BN0PR02MB8077.namprd02.prod.outlook.com (2603:10b6:408:149::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9052.23; Thu, 28 Aug 2025 11:11:43 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%3]) with mapi id 15.20.9052.019; Thu, 28 Aug 2025 11:11:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=Zm1F9op89tc4d4oP/vmKD+56ikoXGlSHJGplnTa7z yk=; b=TrI/JQjQSvs5jpp+FCjkHSWkE59O1rnF+xiCrWxELph9nxzynmwcCS8op Snc2NtyC/UkyKiui80VVhHQzpxQVlaAYgUZHj5Ryg1cF2V3WKYHw0JwGbn1xxfgO ixMAq3xMu9G8j2FPJ3wnPyHatPs/kgrEDZOxF0mrwazyoyPAdFokJS5X94fltJTR hXCUH7EermiqpAl/MhUG6/58jrt5uG7eLpyoEbj+eCW3vNrrkQU4h1U9UIU13DHA b98MBwvw3vAjoCWnR+ek7W05BxWXALr5OuVSSMof1rU1HD5IDE+Y65oZbU9736lU HhxBcFa0n1okkXfQTvXi17cXpQcaA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=p3vvIxTa6/G5jMlFmxScWFwE8ZvQ9I5j47uOX+MJ7ITw+PSS2vy+v2A/iwaOp0YvCmfT7LQBxewpak3qlbBe3rVYqdqUGPLvmNlrwXBmcW3V24/yoxgvgBoBwIiCeryUSyyMM0gKxrPaTcrUmIHam6RBfAT418W0WhMxxV9Gxd1y3COLOlXJxW/0+sctqokdTxASfkLlByobLA3VbiaWO6QG/VbBtvtMU3VWPJwXrMcn/Xvz9kAxreF78X+6wCEmRnJ02f6fNM+XAwghi8V1Q7bjgVpwG9YBUg6WufgynJPMIwUWjS6wExgSrTUTZgf2AgCnfep74AWSZnFVIzoPcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Zm1F9op89tc4d4oP/vmKD+56ikoXGlSHJGplnTa7zyk=; b=NlveT6CyUvdRGoeYw7cIflgBPvmPnVcwLwG3PECkn+jBVbhaHMvImQHLHbEnFfAxYi6urYl9W6LXZ1rjvCvh33aS7v9HrmjWzZBbxdqu88j+ENS/gsqHmRPHECVRd0nllTPqkVEpN7UeBdnCTRVeAgQZihzbjWpg6HAlXoj5lUXxGtjZOE7ERPZ4CLiDufzOQsjTBmAcnlyvbUtE/ZRThU1jGkyw+NtxRfrtwtOrdyX48VuOzDTNFcQM1rNQhUGMizVX7EtuTw1H98zmZ34zbUBhK2GDhh+wQv9AG6eo3hsanQajHLuEjX85L28Y0tOTQhchWiV/H6g50aRhg2gZew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zm1F9op89tc4d4oP/vmKD+56ikoXGlSHJGplnTa7zyk=; b=s/zBxXIdC3lVGhD/4Sp5iZTRfakQkkgcQSPRPBSSx/u5MLpPlKT8eDVsBXPk5JiDDNy442tji9QvnDzfke3TPkIA9ezLtavWlByRRk2M8kAEOA8lC7DnBHpjPLMJm38zSwMDjqbrOfiaC9Dl2dClWXVdQ+Th9qW7dInwclJwMRvkwwId0fpKMXxaVnRLyNWiwsmwK+tMAcgzBpnJ18f/ZIcrs/IfM+CJdt96CuJnVCsClehrqCRZyt3/2ulFLGkiR3C+xuk+2IExHH9gHl70XDUKtwf2YZ4TccQGyK+A484sgR6zHD/fJgiE4ezQA7Vf5FU7y1RpPXWqNMpctqQZDg== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v7 13/19] hw/i386/pc_piix.c: remove pc_system_flash_cleanup_unused() from pc_init_isa() Date: Thu, 28 Aug 2025 12:09:56 +0100 Message-ID: <20250828111057.468712-14-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250828111057.468712-1-mark.caveayland@nutanix.com> References: <20250828111057.468712-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM0P190CA0026.EURP190.PROD.OUTLOOK.COM (2603:10a6:208:190::36) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BN0PR02MB8077:EE_ X-MS-Office365-Filtering-Correlation-Id: 317bc7e9-ae29-47ec-5635-08dde623ab81 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|10070799003|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cXlPbTRpQ2VIWG10QnBLZmRpVmxFVVFEL2ZEdVV3UE1qbEhveHpvYTI1U1d3?= =?utf-8?B?eDgzd25iMGE5M3NEd3hBVVRUWHMrR3hWMmhTdzEzMHNLSTg0QndtWWpudjRr?= =?utf-8?B?MXhsekk0TU5xaVd4VXd3TXFyTWxTdzBRemNkT3FkQTdQOFNuYlh6UjdNRUtU?= =?utf-8?B?S1FHZm5UODB0RHZTNmN4OFkwU0FDZnpzWVZiT3psR3o5eTRGSzNyUkc5OVlX?= =?utf-8?B?ODhBMS9TbkRBcnY0K0MzU3FOMjV2VmVJNnlhVUlhL010VnpRSkp4ZmxHWURC?= =?utf-8?B?bU1PMC9mRkhiRDdQajBJN291ejJXVnd6VDk4Zk92UlMzSU9UYWo3c0l3citm?= =?utf-8?B?U0NrVHcrajV6MUVFS1RJUmVXMFZmclRja2JTdTc0clArWTcwajVXOGpYdkl3?= =?utf-8?B?emY2N3ZobTlPL3FseTl5YjNqL1BUcnBHYzdRc3VXZ2RKL3JGcjUzc0xGY0t0?= =?utf-8?B?dFUxRHF1SlhhYnh5V2h2UzEydWwvRlNZWkszM0RQTC9BY1V3RFZlRFZpeDJL?= =?utf-8?B?MnBma2hPb3dFVXVMdUZDcHpDamtLRGdpbDZ3eVo3N1pVbkF0Yk5PdVlLc21V?= =?utf-8?B?TzVQY3JLS3Y0MkpySDArWkx5dGtXNmtpTGwzcTJMOGM3N0hvN3Q5RTk4Nno4?= =?utf-8?B?QTlyZW16RWZubTZOZCtZdjVRcWgyVFgwZXI4YmIwMkZhVXIwR3dqa1NxSC9q?= =?utf-8?B?bTRpaEI5YjlrMTVKVmNhNVh5YXN4ZXE4T2xyS2FsbGxXNWt2Y3hueE5Fdk94?= =?utf-8?B?N0wya1R4WXlvR3VJeFM1Nzg0clRsa3pDR3dVUXpEWXFrMFVHTlpyYU5KUDc5?= =?utf-8?B?bWxPMS9vY0ZORWZQODRBRG9kMk9mVkVqRnFtRmx4VENMZUdLS2xjazNtVWg1?= =?utf-8?B?YnBmRXZBYVEyeC9hemFjanlaUGwyMDBQZWRLTUZGdi9MZnN4TFdxRlB2dHF2?= =?utf-8?B?WUk0MU1mNmRLUUR2d1BBcTRmTFZvYXFpRFhzME5iRXpNaUZwSlhzNzM3S1VQ?= =?utf-8?B?UVF1eEJIaWF2WFRGVkhuVWR1dGVSNjdjQXhmZ2w2ZkUwTExEMnFBemlxTk5i?= =?utf-8?B?TURNcTNCRVFtcWJxbGlRUGQvREJtMDBGcEI0aDZoQ3Ivbmo5a2ljNTk2SjNw?= =?utf-8?B?ZTl1cUxhbysyWjhja3dUYW5QdkIwWXBxZE9CeURwQm5ZS2tvWG12alJYbEMx?= =?utf-8?B?enU1dnBzT3dWaDduamYvQXNwc1l6MGlDL3Uybys1TDdiZ0VKcSt0eFFWOFIr?= =?utf-8?B?VkhOOGZJbFh1ZjVESTlvdW81LytwNktReVZKcGhtMGRha1BTUFc4RTB4R3NB?= =?utf-8?B?L3RNL1lqc2RYR3lDKzJpcjhZODE3SmhzZmovVmV2dWlHeWJ4Nmx5eEt1V09s?= =?utf-8?B?TlhBUzJTbytGYkJOZ25RWjRkOFBFa3pqd01BTFNoaFB3SitCekRnazlCZVJJ?= =?utf-8?B?c0VsSnA4VXNWUlQvazB2TFR1WUdFUkpQS24rbGJab0drT1YyN0lJWDdnZ2F2?= =?utf-8?B?MExjMWF5TW1SekhBWWhOaTQ1dG5pTDM4SmMxemdQakx5VGFneDdNbHVmQ2NS?= =?utf-8?B?WG5pQWVGQjlOMS9VNis1Vk82ZEpoN0Via3V0dFRsaWxBbDJUNmd0SW16azBY?= =?utf-8?B?YVJmZGMwNE5DUG1JcjlLQjNiQTNhc2trZjRlRGI0RXJQbDlnRVhYdTdlTS9O?= =?utf-8?B?VC9MMjRTcnl0dU1NOGpSK29LWGJ3U3NWbFd6eXRWSklEbXB6Z09PUzFycXZT?= =?utf-8?B?WldDenREaXZ2RGtmSnpQVk9LclJ6dFAweWx5N1VodWRMSmFZNkRBak5IM0JC?= =?utf-8?B?MTUzdk0vQ05JSTNaYVVhekQzZkl5ZDA5RHloSmh1WmhhZVFlT2FsNXNwa3Bt?= =?utf-8?B?RTU3WlRjVHZlbWJoaVJVUzBmMWtDRzRUOGN1R0xJUW9FTC9pSEpleFAzZlpa?= =?utf-8?Q?cY5+KpGQDP0=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(10070799003)(366016); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UlNvQXE4cnByMkZsMWRiM0N4bmcvOTVEUCtpd0xLV1JlU2JzeFZqWTZjZHZl?= =?utf-8?B?YS9kRHEza2xQT0VwWmJjWW5taTdNazdNSnF2NG03NnhZNDFNaW5TVmVObGhR?= =?utf-8?B?cWpUazhKUzRIWFMxSCsrQmxwYXdPNi81b2xiT3dTUW5Mdm5CQkhMQXpVOVRr?= =?utf-8?B?cE1HcW8xUHJPdnhpK045TE1WWDdPb1NWbk5KRmRlMEJhamJHV2hObEpoaDVH?= =?utf-8?B?NTR6bXFrT0FuMDdkZzZ3cnN6YnJjeFg5T1hPK0NjSGhUQ2xMeDB3OTFielVR?= =?utf-8?B?V0ZKL09LbnpaVzQwcmFWZVIwZHZBUnI3S1RXNkhOTlhEOFcvaWptUktXV3E5?= =?utf-8?B?QVRoZGZjNFV0RnkrK052RzVXa1NUZ01zalFJQXJwR2V6RG5vVjZOb01BaGtr?= =?utf-8?B?MWprb05YRXVmOHY5Z05iYnF2dUZGdnEwOFZNbWk2UHdYTHhTYUZ0MHN4QXpi?= =?utf-8?B?cmxsYlRvSTR5Z2xqRGJubDJPN3E1Q1haU29kaFFIYUZkWDRSVitUa21pMWhN?= =?utf-8?B?ZWxKMEVuZTdQRGNqN0h3QnRIdlRiT1djMW1HdGhXN0Y2ZjN1T0RCL2E4M0Mz?= =?utf-8?B?ZXcyellDaGJLN2JMMWcrYkZRTEZ6MGczZGE2bnRRaDBlOFdadkhER3JJNXZU?= =?utf-8?B?cEE4bUk1MUJRdGNxV2w1cFZieW4xUVgrcC85dHFpc0F1ejYvaGpVdW1tVyt0?= =?utf-8?B?cVBHNUNpSlVBL1JGMERQUjRTZVVxSFNaV1ozc1hsODloT3dTYTUxTERZY3Ro?= =?utf-8?B?TDZsMTdJcVZVNm5YdWZNNmtPelpQclBGSGFTa3hQekFPOFlJK1laNlcxZW5O?= =?utf-8?B?eC85bkZTeFM0OXVuMkZKOWRna2ZibmlqWTl6TkhvKys5SENkSVhLMjBsbk1m?= =?utf-8?B?VnhmcExMTG14YzZjdmlDUU1WNVJMVmxBNzZYSWVWUFJQb3FUOW1ZVzlQM1Q4?= =?utf-8?B?eXRCaVhFZW5xR0M5SFNnV3J4Q0pKak5YajdST21hay8ydzhmdEszdVJGVDBP?= =?utf-8?B?bHJMUUxZU3Z2LzdZKzIrYkZnelNaMVgyVTYxbzlOQ1FVTTNocEtpNGhTVWxZ?= =?utf-8?B?Z01YOFB4WW8xdHpFUjBFaHp5RlJtQ3k4dmZRNDQvTmZEZFNzU1hUaXcrUTF4?= =?utf-8?B?d3A0N05SallSSjVoU2JRNWJMS2NOaVM0QjIzR2d5RzllTTB6dWdqM2J4dWov?= =?utf-8?B?ZzY1SmEwUEo5WmliazlQSTRTSzltL05uZ0daTzBGN1dOQXhUTXM4UTFkVDh4?= =?utf-8?B?S0FmN1c2UmVLck1NVGZrZHVzN20wRmZ6QTNlVWpVTEsvOHVGVnVjMW1FSVNI?= =?utf-8?B?RDNQSnlLaEJGNWpuVk9PdlI5NmttVGwxNHJ3cHBtRlVSbEFzTlBuNCtHcU9Y?= =?utf-8?B?OER5T2wwRStjcytLUmR5dVJIbzR0S0pWRnhURXJjVmtBdWdzNm11NnJkVWdr?= =?utf-8?B?SDJhbnJGVU42Qndna1I0QUZQejJ5QSsvNHFIYXNzdE5MZFAvTTQzeUxxVjhV?= =?utf-8?B?d3NEazU2MnkzNzlsM01uUHV0Y0dyR1oyMDVsc1FOTC9vZFRkek5LM3JaY0Q0?= =?utf-8?B?NlNIV1k1NklGeXVKN3FlZjQ0bHZCeWhsSGNpYVBmNzFCY1pMUXhQa1p5aWpP?= =?utf-8?B?dGQ4MjZoc3EvMTBTZmlMZ3hnaVUzL1VqYzU5Rjd0UkZtSmJ0dm5VVWdhVjNi?= =?utf-8?B?UDQzMzJJb3o3SzNtZ1FNT3FVRDA1RXE4SVc1Y0FBUnVqZTkzSE5hS202TUdY?= =?utf-8?B?K0lvbWFuU3V5NXArUVFBUEtEeFZpbXluai9OUWZrNFFpczFVdjUxYzYwNnhj?= =?utf-8?B?ZXJuMzRyZjZnMDd5KzQvMWFDWTZQM2xYcERHWXQvN0wyc2YxTWlBblhCdStl?= =?utf-8?B?MFVObDVZaWlnM3BaeG4zUjQrYVBtc1RsbXMvY2I5cjBQWTJsRENhY0lsd1FL?= =?utf-8?B?TENkcGRlS05md3pqc1RjQjV2TklOZXJORm9KNnRINWVDeVByYWNPS2IwMnZv?= =?utf-8?B?dHd6WTVCOXZFdzlXMS9GTVRDMDQ5ZmVySTI3eWp5ejJMb1JZRWI3UUFmbklY?= =?utf-8?B?UktXQ3JwdllJTERKS2NFT1RFQjJxUGIrdGZRSFV6UXhRQklGVmI2M3QxcktP?= =?utf-8?B?aHJLTmhaUTJRWEkvVVVrYWdoOXpyaitaa3dDZ3UrR2s0UStyNDlPNlhIOFY3?= =?utf-8?B?VW5aVXFFdzVNYm9VN3VuRnZhVE9xbnZKZGtHaFBxcUZONTZHZ3ZGME5ubUpw?= =?utf-8?B?UDdpRHVwQ3YwY2I0MnFWZzRlK2x3PT0=?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 317bc7e9-ae29-47ec-5635-08dde623ab81 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2025 11:11:43.2849 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: b0e3+7lMrZlo68g31BnExlB0YcAoGafddY3ggOCuqKbm91zNPhbwOhDFG+NK4t2pSwMISSmRStQHlpU9Z3NPoMHIbOeCtCJQTZ4iZeEN0ng= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR02MB8077 X-Proofpoint-ORIG-GUID: sZ_ojRBU2rMJLkGtKllGLmWvVoo-dXpZ X-Proofpoint-GUID: sZ_ojRBU2rMJLkGtKllGLmWvVoo-dXpZ X-Authority-Analysis: v=2.4 cv=C9vpyRP+ c=1 sm=1 tr=0 ts=68b03975 cx=c_pps a=VT9wVgPwsxARPCPuKYV0eQ==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=_jvWDQGc8cL8bECqUo4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODI4MDA5MyBTYWx0ZWRfX+bZm6lxMW5r8 tlzb3l1qHllqluTLsoK8wWdb1JbRbt9FM9WbkEMV/p3VmCCsFPbUZ27jzRAD5NzstsaCsmCwSvw sj6cLMSVdKAAnp1UhtG3VqDxa+ZYL+jKaQ86GN+t+Wbh01rncllg/v6AapZt8i6HdMRMJDDAUSp nDIRaLjRX8mMgwZK0SLVDEy8YEJqdZOiPdwPTkKy86KsTePjNnNinpeLXSZpGXIiU45fmJcDhJF yts0eklnBzEz+ZMLVzODpQ9qT0eyaBaUcqYHy6Iws7eMcGpO2EPAB1Vn1YKtF7rU4xaayWfjqxG kFH14WtzfhCNtArO3J0V6pGi1jHMqDwFdEM5wZnLVCLYqFLcONgkJaA0+eU4cA= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-28_03,2025-08-28_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1756379596098124100 This function contains 'assert(PC_MACHINE_GET_CLASS(pcms)->pci_enabled)' an= d so we can safely assume that it should never be used for the isapc machine. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/pc_piix.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 66dc4a5186..fb936748bd 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -503,7 +503,6 @@ static void pc_init_isa(MachineState *machine) assert(machine->ram_size =3D=3D x86ms->below_4g_mem_size + x86ms->above_4g_mem_size); =20 - pc_system_flash_cleanup_unused(pcms); if (machine->kernel_filename !=3D NULL) { /* For xen HVM direct kernel boot, load linux here */ xen_load_linux(pcms); --=20 2.43.0 From nobody Sun Sep 28 15:28:19 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1756379627; cv=pass; d=zohomail.com; s=zohoarc; b=WtPRanufx4yVZuZi7AER4uH8jhtq4+7HcXinfIbvc7DYuEAEVj4N1uPEZWSveeU1/ozZsJkBVjtP5I3PIifEqlG0+yAsweffyGpGx3m0HXM1STNxiGRRF+jCuOJpPwQnlTHk36OqhuS8PNIgvmdV74WpUDKBuwxSoeXoc+kLyIk= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756379627; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=t/aq3Kyfbbbp2v/c+E04KedQxfbtJa87qBRWGYV8TEc=; b=Rc2iV7NNr1bN4nv3xtvRpYpmTudBVWSoyLJNPO/zfbgg144Qm9cAyUuXPWhY79uT30ZQ0MpLnJNmBdgiO9CxuSV/OVAmJud5Dw2MMB2S/NRa+lxYUhHnb/S450Mq43XwIxIsaIlNENrAZbUF2ieyZk2wBp0o2a3nR/GkZ1+xG4E= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756379627814628.8024684849067; Thu, 28 Aug 2025 04:13:47 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uraXu-00009R-PV; Thu, 28 Aug 2025 07:11:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uraXs-0008VT-4C for qemu-devel@nongnu.org; Thu, 28 Aug 2025 07:11:56 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uraXq-0005TS-Dl for qemu-devel@nongnu.org; Thu, 28 Aug 2025 07:11:55 -0400 Received: from pps.filterd (m0127844.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57S77Yjh2726376; Thu, 28 Aug 2025 04:11:52 -0700 Received: from sj2pr03cu001.outbound.protection.outlook.com (mail-westusazon11022143.outbound.protection.outlook.com [52.101.43.143]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 48t6kjswgm-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 28 Aug 2025 04:11:52 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BN0PR02MB8077.namprd02.prod.outlook.com (2603:10b6:408:149::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9052.23; Thu, 28 Aug 2025 11:11:46 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%3]) with mapi id 15.20.9052.019; Thu, 28 Aug 2025 11:11:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=t/aq3Kyfbbbp2v/c+E04KedQxfbtJa87qBRWGYV8T Ec=; b=R+ETV4NFjwSjNtoSBsUGiAYhcOGj1fVyNUTELlFi/0uXTxSvesoiDj0Nr fnG2IWzuDQC2e09qTaQFpwUznNfKqnJ3p2ZBJACf7rANGIXbfvzQAV8wxkANGHs7 t3b8O1IQjMwUJid67St8OuVV1AZCsjBK3tfsSyM+oHg7WFot9uGFIZBKVprtNFas IZV588JAVXCWGUP/GUC3l7E2yQ/w8LwYfqQUZ/ZsWaMI/TzlkKQbaJRxyY8v70s7 oP/mPIS+bGBw/OqoSXYr37poBe2Y4kww8tV4F9cZ+HYtu2efp2cCcy5g4fMHYk8z XHu7CimqdscBhTUC3FUl8NAqwn9dA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MABOxmJ+XXNREsRpnGY1QqmumkskiIg5LcEmYD3PhxSIjvI7EeYLOO6Z5+tw3nVX0SYv9eBa5h6bGqg6QWcFsUsjV/yX9wWc9BZ8YZYw5Gr91jbqqcAPKRAHjODONh2dKklzALZ2VB1YmdvljRWhUkKe/yf/yIbflYu8f2KcnbIRE872bLp1j3znCgCu4APN732VCzztdlcWhPMt3RSZUqaSaZ9ApWsUc1U08lLZkdxoYpZfLpuAspi8xkmALXv/QB09rxDt6dIKsVaH2mYXyr2xqOHiqMFwbGUAFWob8ye+sMzzPm8wZ6T+z2EXiEYTRJbCzSUq4pLvJC95vVFnYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t/aq3Kyfbbbp2v/c+E04KedQxfbtJa87qBRWGYV8TEc=; b=q5UMVXIIHibwcjd2EXlbg35TDAP8obxOv4BnjYUSI1+1bIgy7Db89Q8vYWK07jkz1fVTPFS1L4YOUnOotoX4hxPQUSsI8dgX8qJ0ucJBkgVwfzZCCocClLvQmoPVwobyLNKwce4/fCL12cXT0Ny0vVRdCgX3KjG7uQszw1Q23ZHRFQAyBZSnRWa/dHi45crcWs+eytH18BwE1LA1Eho8Z3kJQ2EsintTZQvUlDYG7y2ATZPg/WI+wPyXnMHo2DhipDLghe7dbvuc7/S7rVytLYZ06FUWSHvq2aEbINqJ82NVklVkjVedIxvE6QXtUw4HYODB3Gk0pPvOYTErfLhCSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t/aq3Kyfbbbp2v/c+E04KedQxfbtJa87qBRWGYV8TEc=; b=NUA0mwzMVEKcxM7K/3mwwjG8+WMlFzzi4AclB3fgmWB/OYwdTWX0j1Wv5297q3z+5BmZjT3CJ0+kRCrKCD3OlH41uifggMZ6+Wy9maMOg0PaAfYy5pWX0gb67ypOhktnFtMb7wSU6MLAlonYwF3JAKTWhViv0NEox666a0vjW+RA7x8uXRLp0Pwvz37wwYsd78vFq6Ugio9MHHP8w3VCnBuUOlq6hvQfS7af/sCUg2b+qnfc7mu5r3eFdAfYW8NYiDESOQHbxxCBfBXzaBuI7ZCMGFkX5OClLhmDgqr0nmziNnyX1NIMEaaMhfxlEkc/OCce4KNy1lQgrb66nsIzyg== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v7 14/19] hw/i386/pc_piix.c: always initialise ISA IDE drives in pc_init_isa() Date: Thu, 28 Aug 2025 12:09:57 +0100 Message-ID: <20250828111057.468712-15-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250828111057.468712-1-mark.caveayland@nutanix.com> References: <20250828111057.468712-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM0P190CA0023.EURP190.PROD.OUTLOOK.COM (2603:10a6:208:190::33) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BN0PR02MB8077:EE_ X-MS-Office365-Filtering-Correlation-Id: 3a89a0ef-a89c-4d62-b93d-08dde623ad71 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|10070799003|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?UEFES0QxRytPYm41bU9KaG5XM3BadzdBSGx1VE53M1N4OUIweUtpWnRadjFP?= =?utf-8?B?amJ0aHhVYi9iTGFQQ0ZzTEJYeGx4Um5hOEZxOUhYNjlhK0M5OWxLUENEdmN4?= =?utf-8?B?WnhxWktzVndjamFPc0Fqa0xWVmc2QVhuWW4yb2RKa3dxQmxGRUw5ZllEa1dX?= =?utf-8?B?RnVCSVRGb2s4YkhXTEg2VU5BT3BHRDBOYnZmbjdGMkVwaEZYOXBsWitMZkFx?= =?utf-8?B?NHFndDhvQUI0aDF1bXU1bExtbG92S0VHSWNnNDUwMXlUc1RlZzlJRjA4aHZz?= =?utf-8?B?K2hGZTVRY2MwZ0RUYjNma2ZtNGRMem9MM2V6SjlFQTdwQk9pZ3g2Z3M4ejN6?= =?utf-8?B?UFhNWXJHNXVyUjVwc1hOaTlhNTlkRFFzN1dTTEJLbWtkWndnKzVvUWhsMDR2?= =?utf-8?B?N3RVWk9ldXloWXJKd2UxbjFDdmlsakh1UENUWjRoUzFpNTFiQlYyZUZEQnNi?= =?utf-8?B?aDNKWnoxNTMremtDRjBiZ0xjNkVtbzd3dUlRM0VjNzF5R1NEdW5lcFFZYmEx?= =?utf-8?B?NUpWb2JrUE5haXJmUTZvNUM3R3U3RW00YmZwWjEvOE5yS0h3Q2NQaDNpZzVo?= =?utf-8?B?NUJWbmNyNlJQR2VVMTJVSXNLZXNHeXltY1JwQUR5b0J2NmJQMTJHVHRsNi9P?= =?utf-8?B?QUFKL2l6M3VQNVRKVjZUZmNxQ1JmRUI1ZGo2ZWxDU1YvU3AvUGUycmV1OHRx?= =?utf-8?B?TUpwTnJUTmYrR0JPNXVQczBuR2YzSjZSTHRNSDBzT0tReXZMbHM0VGc0a0hS?= =?utf-8?B?RHZ2VUV3UW9tNTAwQTFtS3ZTdTdWaHRNVm0vTC9EYmNmeU9hUHVpd0FmVmpR?= =?utf-8?B?d2E4MFA1WG9iL2l6T0ZIbDJQTWZxdnBWK2p0S2xITzVSK05abWd0aVJCbXA5?= =?utf-8?B?UlBlWVNOS0xtZUY1UW5kS0U1WTdFVHdrTURXSEU3YnZBVUdwK2FPUndOVU41?= =?utf-8?B?VnBjaFBGTnpsL3c3bjh1dkl2aFk1QUVjVS9EbG96c0lwYzg1K2lySFZ5cUVR?= =?utf-8?B?aHFFVmdOc3F5alV1V1JDckppR093UGltRElHSG16RE1va0s4L0JEejRDTDY1?= =?utf-8?B?UDJubFVlSWkvR3FpWXE2a3h3M3Nkc2xVNWVQRHVNVCt0dnRVcjExallFZ3Yv?= =?utf-8?B?R3J1YTljd1pydC90SDVUT0ZURmFPcEJXOXJWR3V4Z25UeVROWENjdVQ2YldD?= =?utf-8?B?aENnUG5iWTFMRkhqOXh1ZmRhYUJ3cElFdTFQUDJaZ0liMS9PNjh2WDhXUS9S?= =?utf-8?B?SUNxanZDRVR6RGFrdDFybHpCK2o1MTRSSjNGL3VTaTJ3K1Vhd3BiOVhsSm9O?= =?utf-8?B?Vi9rYVBreUN2MDAxd1doMTAvWnVmSTdNQWFVVDhRSHFwSUpLbWgwb09MbVFX?= =?utf-8?B?MlNDbHF1bi9wQ1dTWUtCdmQrMG1LTXF6RTM1K0xVaGNHQmt0UUlUTW9GN0p1?= =?utf-8?B?YTVpR2llWi9paDM1LzF2K0R1My9IRERpdi9VMWZsZzNFT29lZ2JXdURuWGpE?= =?utf-8?B?a1FyT1hvRi8vaTJFVmtaa2hRa1BjT0w2djhEUWFmbitOdXV5MlFDMnY5Rm01?= =?utf-8?B?T1loZ3ZVcVVtOEN4VUhKeldPbFRLUnExS20rNzJMcnZsNmFvbE15V005djNw?= =?utf-8?B?MW43WHg2OTNnRzZXR0Y4Z1dTNmlBY2I5aWd0aHArUVNSUFVtMXFLdzc0U0x0?= =?utf-8?B?bnhYSlFhY2huRVhyZE5XQ2J5VFVXTnY5U2h4UlVkU25Ycm9LeThxUUF0aWdn?= =?utf-8?B?OFFDQnIvRlBhSzNSKzFzNkVUNVhTbHpHSmxuNUNpSDNEc01NVEhySFZDcEtO?= =?utf-8?B?WkhSZis4RFphTldrUGVpc2taRFhoN25JR0dsZitnTzd5ZEdmb2U5Ulp0emFO?= =?utf-8?B?Zmg4a3Job2ZteFlWek5adTJ6d3pDMzRDL0E1YnBaamlGNGc9PQ==?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(10070799003)(366016); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RVp3VkMwUE5MV1Fway9kaEpNOEEzWXlmaVJ2Rk9GcW54TWlhc1pDTGVGRit2?= =?utf-8?B?QkdlM2pNL2E5dHhKMHNSRExRV0Y1Vk83eGRvQkV2bENzSmJsRk5xNDRHUXZx?= =?utf-8?B?aHBLbnY1R3NEZlFaL3pmNnozQTlIR0ppRHNpT2lGVHBhRkkxVU5KcmhpcE9r?= =?utf-8?B?OHF4Si9MYmUvdy80d3RPMmdZU3VxT1N3NXV5QXNHSzVScGM4MmdoUmJuVk5U?= =?utf-8?B?bTJrckFWbUlEVFpGSC9jaTh3VlVOVERwdVAwaEVxS1c1Mk5EcmZZT2ZDR0tE?= =?utf-8?B?Mk9YeHM3SnVtVDI4Q2V0c3EzSC9WVVArejd4VDNSV0hpbEhSV21CQmk5dnNt?= =?utf-8?B?QVhQMWhMZi9yWUV0Z3d1a1JWcHU4RnppY0lROGFUQkN4azNkdm1lamRaamVY?= =?utf-8?B?VG5HaWxxMU5FNEV4QU5BS2RxSUJxeDJKNW43NkVOVFh3a0I5VTIvVXQ2M0xH?= =?utf-8?B?cFNtNlZFVVpIdUZtZ2VuM2RIUXEwMzRqYjcreFFCdHI5bDRzOU9STXl6djll?= =?utf-8?B?amxDYm4xMjZva1JzL1Erc1NETXNuSGQ4dzFaNUFuNDFLcStEY01IODQ3RmEr?= =?utf-8?B?TlBoSDN2V25kM092MTZXb2N5MmxEODhRRmY4MUFEZjNNZG04ejZWcWVQTTFo?= =?utf-8?B?LzNxMDU2VTdiRVUxcU53TUE3Z1VqSU55a3BBVDBqb2c0c2c3ZXhqMnZ2QWJH?= =?utf-8?B?SDdSc01PZkE3UDY2Rzd3WEJ6cDc3MFRzVlU4cnM3b0g1dVpzSTViVURWVGZv?= =?utf-8?B?YStwL09udVRnK2RiMnhGa3dQeUowek42RGpCbkFrLzBENVcrSC9iWVIyLytu?= =?utf-8?B?MHVJTjJ0UEVBZGxWUklEOTVUMHpHalR4K0h3L21lUjA3OGYrK09YNXo1WHh1?= =?utf-8?B?R3c0aDVYSmVFeVNCNXpWRWNFeDlQbi85VC9HZkc0bjJ6dEFOcjVpSm8vYkc1?= =?utf-8?B?NFlpOWNCb1dBSWkxd0RnNUxnSzZyVUt3L3B3TWZ0KzFqTmRodzhjLzlyblgz?= =?utf-8?B?Smw4WmV4cUdqUjZ6ZnRtQ0V6UUIwK1JSTHk5UnpwRnZEQ3lxWTZMQ1ZWbk1O?= =?utf-8?B?aGdmUC8raTZscEVPMURENStUZVVpdGs5amlZOEcvaXZQd1VRY2V2U3BtOWtH?= =?utf-8?B?U1UxWnAxNzdZVTdZOVhMS3MxWlkyV1ZnMjJZSTNtSUM2cDFMNnZBUVBNK0hE?= =?utf-8?B?UzVlVmtOY2Q4UW04VG5FTXMxSEpoVEVYKzNRZkJXWHloZTJ3TFFxdWwxb2NF?= =?utf-8?B?ZzlRSWVGWXJEeEExdllUZ1NYcmdNd2R6dmJSeWpYVWFSWTJTK2t0aFliT3li?= =?utf-8?B?ck95L3JkeFU0R3lOOVFiZ1ZSVWxsUE15VDFSQUVIUlU0OVpYcElva1RSZFZZ?= =?utf-8?B?ZjVwOTI0b2lMV1R2eGpjOXc1S0tIUlpIQXhLZHRiS21ZTHdpQm1CcnBqWU9o?= =?utf-8?B?RitKUTVmYWJIdUFOMmVIYk9EQ1VweDhHN3p3VzhoMUJ1QUNNV0k1NkE2Tnoy?= =?utf-8?B?b0o3OERGbHYzbHdGeXpLOW9lUitScXh6NTlWRTRVWVpEeWVta0E1WG1uU25X?= =?utf-8?B?S1VGcmE5S2x4UkZxaEFlOE9LYVd5VkhVYmQwdG5OVWFlWENoZGNpekxFT1ZN?= =?utf-8?B?WjRTYU9JYW1XWWMreXV1Nk9STXIwN3UwbFdQbHUvWmR5Z0lQanF6VW5zNDBL?= =?utf-8?B?RTJXaUtienQ5ZzRBRmRERGVjQjR3MWdNWCtMcHllanVVUisxS0pMS1RDS3Rx?= =?utf-8?B?c2JnVy8xU3NXUUc1VUpkVDNBK1ZoM2I4MGZWZFBRL1BGYTZvam94RDZXNTdP?= =?utf-8?B?UVd3cTJPeTFCWk1lS2FiaEhWcG9mZFZKOU9uYVJ5eHp2Rm45K05NakIxdU9X?= =?utf-8?B?d3FLek11enloVGxYY1VNdE93cFUrWWVLa0Foc3BqNGVKUW5Cb2JlQlNqRFV0?= =?utf-8?B?V2lERTFkUlpGcGZOMlJoY09lK1JZNjVTWWFlUFpvUnBzdElMQzI0VDgxRk5o?= =?utf-8?B?VkVSUVVHT3IvbVlDNnd3dmhNek01SmJwWmhOZzV6WVJadXZucnFjQXd3dFdF?= =?utf-8?B?R2RLdzYxVDBKbXNpajQxdXlYbnp5cXg2eG1lOGtRaGFCWnlQeUI0K2dPd0Nr?= =?utf-8?B?MkRXY01Sb0pVZmtyU3cyU2lzek1Md1lqbGp0YUlZdk90SEJUTjN0NmU0SS9h?= =?utf-8?B?ZlFPSFNtQzFKM0dKdURYdzdaT3gyMHk3NG50RTlWc2x1UnV1WkF2dk0yRzdN?= =?utf-8?B?RlkxVy9GaTB4Qi80d2dLVkRaYUFnPT0=?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3a89a0ef-a89c-4d62-b93d-08dde623ad71 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2025 11:11:46.5223 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cNp8aHM/FYpnG1Pmdwb4u047kkhW5iGCXFT9c67A6upX/bVo/A9ydLQFDXaUljRp1/V/JmGDFqwAAwKZeqO+sXN/YW7w7FYn6ko1usLc3GI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR02MB8077 X-Proofpoint-GUID: P1MGptFVdlL2u2kG8XUuEhYfc5DBQlhH X-Authority-Analysis: v=2.4 cv=c+WrQQ9l c=1 sm=1 tr=0 ts=68b03978 cx=c_pps a=ofxP+VRvIeXlqxG7dm9PvA==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=QyXUC8HyAAAA:8 a=jCzY28RqhW9EaxlX9oYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: P1MGptFVdlL2u2kG8XUuEhYfc5DBQlhH X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODI4MDA5MyBTYWx0ZWRfX13sExPD9NYyQ st4YG6Dguz5UQasBliqfL8ZFc7zWQOe9v64lTyUmsnG7MrtqVuT1botCmm9FhTkJXaBkeZjn6lV GYRt3ITSe8VBDx7QL0EExqsXXNUG1uHXqSCZ/EYJlJgSv1tZqlmQxt3iVchIJxibdnoWjScpHin p6oii191L3h5Q2nGrboJT8X0IkI4N98aS8ErDJbCyAKlj0dm9CZHrZtzdEf0Fd/Y+2GN+vZFj57 qkThdxm66WmjzT7147DzBKx1pr36LQpesXA/tbX6gkFVhA9wsA/Nig6sUMG9Ipt8DwoktnhQMZW GmGMR0V1qt+D5RYZ9sjbv/nuP67GBm5QiST/WHG+eeRPPVBn+aPSuy85KC4mBQ= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-28_03,2025-08-28_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1756379628351116600 By definition an isapc machine must always use ISA IDE drives so ensure tha= t they are always enabled. At the same time also remove the surrounding CONFIG_IDE= _ISA define since it will be enabled via the ISAPC Kconfig. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Xiaoyao Li --- hw/i386/pc_piix.c | 35 +++++++++++++++-------------------- 1 file changed, 15 insertions(+), 20 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index fb936748bd..72ddd9b149 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -445,6 +445,8 @@ static void pc_init_isa(MachineState *machine) GSIState *gsi_state; MemoryRegion *ram_memory; MemoryRegion *rom_memory =3D system_memory; + DriveInfo *hd[MAX_IDE_BUS * MAX_IDE_DEVS]; + int i; =20 /* * There is a small chance that someone unintentionally passes "-cpu m= ax" @@ -541,27 +543,20 @@ static void pc_init_isa(MachineState *machine) =20 pc_nic_init(pcmc, isa_bus, NULL); =20 -#ifdef CONFIG_IDE_ISA - if (!pcmc->pci_enabled) { - DriveInfo *hd[MAX_IDE_BUS * MAX_IDE_DEVS]; - int i; - - ide_drive_get(hd, ARRAY_SIZE(hd)); - for (i =3D 0; i < MAX_IDE_BUS; i++) { - ISADevice *dev; - char busname[] =3D "ide.0"; - dev =3D isa_ide_init(isa_bus, ide_iobase[i], ide_iobase2[i], - ide_irq[i], - hd[MAX_IDE_DEVS * i], hd[MAX_IDE_DEVS * i += 1]); - /* - * The ide bus name is ide.0 for the first bus and ide.1 for t= he - * second one. - */ - busname[4] =3D '0' + i; - pcms->idebus[i] =3D qdev_get_child_bus(DEVICE(dev), busname); - } + ide_drive_get(hd, ARRAY_SIZE(hd)); + for (i =3D 0; i < MAX_IDE_BUS; i++) { + ISADevice *dev; + char busname[] =3D "ide.0"; + dev =3D isa_ide_init(isa_bus, ide_iobase[i], ide_iobase2[i], + ide_irq[i], + hd[MAX_IDE_DEVS * i], hd[MAX_IDE_DEVS * i + 1]= ); + /* + * The ide bus name is ide.0 for the first bus and ide.1 for the + * second one. + */ + busname[4] =3D '0' + i; + pcms->idebus[i] =3D qdev_get_child_bus(DEVICE(dev), busname); } -#endif } #endif =20 --=20 2.43.0 From nobody Sun Sep 28 15:28:19 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1756379594; cv=pass; d=zohomail.com; s=zohoarc; b=TuVC7ZgV7fIPrtsb3Ljl6M1F68kgD0DUvgC+oOXx5TbqSRN7E1HCBUzOa39Du2/iUSBgoQQbMpQs96zowPuvB6O88OzgvcurSVs0U/So2gDnDTWb1mWML8mgkz25iA97aHViaCnC9imqCAePbPXOVOHaD6JcGEg9HIugtUDTBLY= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756379594; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=QHcAeR+EpXqVB9y8TieDU+ngh8CXRMNMEc7Met7IUYg=; b=hJtxz/Ej/dICAGZ6EqYe1aDJ8ewcCZFAXh8UAycF6xEpwIfOZzpO72FjmcHC4JO87u+8eivcI8cFK+qWYtR81PAheMnrkoTHNWkC554JTMBVWhyeh9AwW9zpdOEbHKoqPWszB3uGCu/1Bungu4TCyP8i+fIhHyqZ92ofd7iPpg0= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756379594088120.29247166001346; Thu, 28 Aug 2025 04:13:14 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uraXx-0000CG-Ji; Thu, 28 Aug 2025 07:12:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uraXv-00009f-0b for qemu-devel@nongnu.org; Thu, 28 Aug 2025 07:11:59 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uraXs-0005Uw-Ut for qemu-devel@nongnu.org; Thu, 28 Aug 2025 07:11:58 -0400 Received: from pps.filterd (m0127844.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57S77Yji2726376; Thu, 28 Aug 2025 04:11:55 -0700 Received: from sj2pr03cu001.outbound.protection.outlook.com (mail-westusazon11022082.outbound.protection.outlook.com [52.101.43.82]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 48t6kjswgq-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 28 Aug 2025 04:11:55 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BN0PR02MB8077.namprd02.prod.outlook.com (2603:10b6:408:149::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9052.23; Thu, 28 Aug 2025 11:11:49 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%3]) with mapi id 15.20.9052.019; Thu, 28 Aug 2025 11:11:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=QHcAeR+EpXqVB9y8TieDU+ngh8CXRMNMEc7Met7IU Yg=; b=DD64/y9aCnvl18BcnL3dgbuDA7WjaxXHz1r/+EOkrwXB12GqRZyxQKQmU VXgqchmn9VPbKIm5ZplKOeP0simVuNfwMo5fZJ7Mt38OEqFdABuCn6b6GcbvGx+X mNm6FU4Xt4TFvzammlCb177f28IpsiyFUExJEW5YRqd/XFE8YfGpTR31yy0Mw8Ri V+xWqRSQJ9rq6fUBnX1a2Y4UdyM0M+25YP8I43cmiYU0yCXAadvaCD0OK/tv6J9l tDBpi19U3LtJpIj3DxXqNMcDm/OmisugdCwOtPxIho/9k7GN40oqaEup0bDMIGf7 jNXpTKepy3gVu+ALrrQxcEicPnkiA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WBJ090qN8rPzNql8pOT/lb6bu7NlfbGiqLTq8Dpa6zfMHybfxA+o/2RfdWuOzbjU1GBXCMj9/6WiY0JKPPz/nPWibMnd2YQjLawDE2kEat1BljC+LmQOsTLKTIDF+Th/ufHdnvpyh/2XQzuEzOBQnEUBoOPtd8ViPMuppylra/WVrXyAN64EX+IpoC/rlgxXlzNnpycI5SCtjw8H4YnmZRazYmVfixCE681ulxAPQTyN4bR/nseH4Btmndy4zCh+lWnBZZwyYtVs4F0wDmv/WuDf2Uatah96MqgO9trjvg03sDNVhs9pXNZxBufJ++nYelOfIPYZBjgEoso6LDqe0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QHcAeR+EpXqVB9y8TieDU+ngh8CXRMNMEc7Met7IUYg=; b=r+G3e6oh6KHyCqzzHDQAMPhSekbx1C+xkeHxI+CitWtc/ZUcDN+Bd66FpA05bntcRlKKGxLVp18kkwrNu3Hes7Y/xbKBcpMHF2qTfQE95rqad9YKXb5z/7gnc6TCFmy4Y3sm5Sotr4imH0nPCEHG6K84sAPoVIfvI16ckvOh7YRlUiW0MUl7RaMXCJhyi2rmFge5stw30blSlSjdrMf6dVeuQCiMZMb5mZQ7388Jyh0Mkv/Ia2f8dLKwKCI8WotFCXF4ojIWO/o6dOBO/QF0cGadg0AOdR57RXucFdMJ3XrQjDdkGurYgoKwRIjyv0t8965cfaa7tE/7ZXT4Y0MmBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QHcAeR+EpXqVB9y8TieDU+ngh8CXRMNMEc7Met7IUYg=; b=K9FGOHQMMJxfd2Z2l8MauloWyxU0ZFbV7iJwL27DGzFUiXFDLETDg6tX9ypGBzfI3x/Sc4U2N4JrdlIFV0fHWVS9gxHGO40CxAOJRnW3T+OZogByYwYlS1CLaim/AYLL+oyzQwMIj7qB0zti1vDyvCE+ZgQQj4pJpAktvaI3Vi357M1uHSH0odLU7Qyoay+6wriJBqIY2mzCco7NtTZ1W9stUt6BfVEYcjWlyW5NiYqxV2Wg8dgYBIDCCfnIv+CSUNE+OvrVhojiVZ/eDJzko5//xOrf6Vv9kzKt9u1pMWkzdusCIk4yjYPvgLqIKpq+wHZ8QtueATiOG74yxCkErg== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v7 15/19] hw/i386/pc_piix.c: assume pcmc->pci_enabled is always true in pc_init1() Date: Thu, 28 Aug 2025 12:09:58 +0100 Message-ID: <20250828111057.468712-16-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250828111057.468712-1-mark.caveayland@nutanix.com> References: <20250828111057.468712-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM0PR02CA0207.eurprd02.prod.outlook.com (2603:10a6:20b:28f::14) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BN0PR02MB8077:EE_ X-MS-Office365-Filtering-Correlation-Id: bb47a90d-6b00-48d6-e382-08dde623af3e x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|10070799003|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?VDZSRXRTeU5CbkRoL21RV0ZtUXgyQzdRbTRpaXgxUStXUkNPYmJrZW15aEYy?= =?utf-8?B?VTRybFJPeWZ4R0VyVzBNZ0lrQSsyZ2tTTEg5cFZDd2tybGZ3M2dtTFJZem1O?= =?utf-8?B?eVpvQnpxWTBmZVZSdHU1ajlhcUNMRlgrUmxkKzBJU0lqSWlTa05aN3RGM3Ns?= =?utf-8?B?RlgxV3lzVEtwUFBHSXRXalVYU3RLS2VyMGZvRnZLOEg3SElxMVhXeHdrUXYw?= =?utf-8?B?cHZFQTN3RXVVM0FzRUlsOUlIdjYwUEg3TStPMnlNN0luN1BXdHdQYmZia2JE?= =?utf-8?B?V2s3NHA5c1lxK2NyRHBIRGY3Q29ldTZaeGdZbEJMOGNMNXhkTlpBZ0U3Ny81?= =?utf-8?B?VFdzTFUrczNPRmhuT1pObEJpRklSM0R6eWFVWUJJdlo0QVZiaTN4aUhaY2dY?= =?utf-8?B?b0xoWS9kNlo5SVZxbEU2dW8wVTd0Vm00T1BJT3UrcUZwcWJNdXNPRllmeVd3?= =?utf-8?B?aUFBVUFrdDFHMnlNREJMRkV1dEppQll5bDBXVXlTdHlJS0p6VVZhMklxLzM5?= =?utf-8?B?NGNUb0lTOHdReWsvNVVON3lrdkFLUXc5SVkzcUVtVTVFK1gvQ0hjR0tmb05n?= =?utf-8?B?VGNlbW5NZXA2VVB2SndVYk1vTVR4S2VDK3NBV1R0MGN5d2ZHcWR3U1B3aXVo?= =?utf-8?B?VzRsTDd0ZHZYUGt1UkRQN1hEbjdHbWd3anJiUUN6M2VwVlIrcit6cHl4ejg1?= =?utf-8?B?S3h3NlR0RTBVME1Qb1NXbm5La2ZrL0U2b3IrQXdrdmZkWTNxaFBoUG9zaEhz?= =?utf-8?B?bzJLY3RWNUo4Z01rN2htcDh5cTY2RGVibVROVEl1NytwZDRUR25Od2k3a0tZ?= =?utf-8?B?SUg2NWkybVU0V2tzRnpzRFV1c1V4aFJLbkF0WEdONVY1OVN1Zi9wTWtOSmpN?= =?utf-8?B?U2sxb3ZmZU5vU1NIQlBQcDVISWhvRHhqOE5jZytZZXgvN3NLa3FOUFd2VGVG?= =?utf-8?B?T3cwTVVaRWRkbjJxMFdta0N4TUc5ZkxxQ3dxcVQvdmhrbDdCcUYwNVJ2R2tU?= =?utf-8?B?ODNuWnRLVHJQanNBckJCd1V0RW1MS1dTWHh1SFpiVS9jZUliMC9hMDFlRXlh?= =?utf-8?B?dm1OV2t5SWM4Qml6YzRRZTVTZk1tcTJvbUVvUXovY2ZvNnFoa1E2ZmxKVTRy?= =?utf-8?B?SXNydjlQUUFwanR2Z3YwT0dsQ0N0QTRnQjVYcGN2NU5XMG9MZXR0RElXS3ND?= =?utf-8?B?QisvOEhRaVJMTk1SWkVPYmlFRWdXVlk1Y04vYVprU0RuUnFHVjdwUmgrWHVR?= =?utf-8?B?WExmWk9ZYnNlQmVoMHhpSjcxcmxZZXA1WE9pYmVmMVUxbzBId0NSYlh3VnYz?= =?utf-8?B?SlFSWG5wby9SbjdqZTBDM1Z3QVBjRi9jeVFESkhWYnVUb29VUTNTRjNSUnhT?= =?utf-8?B?K0dTRStXUDRCVzBneXpZcVZ1di96N29RM1VINUlCU3V1bmFyNGhTeGdhNVBU?= =?utf-8?B?N2tNYnNRZk5pSlFYUGJoVi9wUVo5MjF4Z0lDK0gyRDF3MzFkR25rUk1ZSkpj?= =?utf-8?B?WHF6ZGpZNHBUNjFzN2NLMjJFYzdhVkM0RnFGYVRUcStXYmt0cUxBOUNwQy9B?= =?utf-8?B?ZzY2ZjNoOUViRGQycnFGWjRqSnVXS29hRXoreUxYbU9mRGdQKzQ4UW8xWmpl?= =?utf-8?B?bEN2b1BoOW9YQnlLRlJlT01HQXdpTVdoYUlDVXR2Z2h1L1haMm4vY0huWmNV?= =?utf-8?B?cldwaXYyaHRPTDFZVWNPOTduMVNSV1dVem9IeW9NWjZGeEtMdkN6Vk84RVRZ?= =?utf-8?B?bzVlTllSYU5oL3VFK0RvSnpudlJsdWZKbXFkOVk1VkRHdG0xc21RZ1hTOXRv?= =?utf-8?B?T212cVk2U01WV2tLdUdjcjJrWkYyOXp1Um5aT0prMkp2ZnR4NncybEdiZXBp?= =?utf-8?B?bldaRTFzRFJiNzFlRUQyN1lOTEJUeTQ0NDVhN0M0aWRvN2RBdG9vWjVyRHJr?= =?utf-8?Q?8q6Ozgz4L3I=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(10070799003)(366016); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a0hOTjNxVmZtRkdxcGFJSXFkaDJINXpZbEEvdjJ2TzVBWmFoNjRld1dkZTVk?= =?utf-8?B?bTByYWhJUjBBODJnejJaVjZBU28wUlZCcmZhZTM2TW5VWmxiRDdwc3FPVll3?= =?utf-8?B?b2gyYnZuVXJSVHNPVGFKYVpJRHA4Y1pLbFMyOUY0Tkd1Rm9TRDJaSWNhakFH?= =?utf-8?B?dTJvZE1IekFWa2dzUkl2ZHdLRUlmZmwrbEF0UGNsaTA2andSdkUybEx3M1Bk?= =?utf-8?B?T2JTV3IrWEJDK2kyZjhaSStFMXZkb3MwRkZKbFhiSnlwRVJBb0JEZ1JXTFFV?= =?utf-8?B?RGdodmJIR0NuSEwyV0Y1Z2VmbjMyS2hOM0xRQ25lNmQwTkpkR2dZYncyeVpV?= =?utf-8?B?YnZua0lNZTE1N256YzFOMHR0R3J0eHp2L0xJUFQ4Qm1leDlQdklZTWFZRDdn?= =?utf-8?B?SXAzSDJVUHpGL3ZCVFhNTW94SVBOTWZveXZrT1JSTEhlNHhybHJ2eTBJOWtx?= =?utf-8?B?QkNaSWVTYklwRS8zajRMdWYwNmVNMThxbExTNldUSHVicXlINzRQakFoa1Qw?= =?utf-8?B?K0wzWXhVUVRxNTVvelhsSGYyci92Q2ZiMDA2V3ZWeGcvcmZFeTF3ZytKWkRl?= =?utf-8?B?MExhZ1kycE4wVnVHT3V3L1lZcW1RWWFNUjhKS0Jaei9KeCtUY21ka0pQRUU3?= =?utf-8?B?YmhvclFFVHpqTFB0dWRoYWZxUWxnYlBKMlE2Z0hTZDhSME5CM1lZTGhQTkk1?= =?utf-8?B?bmN4VTN6eWFLZm1xU08vUHlQcm5vMG54Ry82MmJHenVHL0pzQVNXS1hzeUQ0?= =?utf-8?B?YzBTa3RWV2czSUVHM1Z1WThiS3lzUUh0NDk4aGxCZjJpVndwQmRUOVI0NEsx?= =?utf-8?B?S0thS0VjQ3VXY0dxcTJFTFI2S2g5aFVpR0hNYkpFc1dzNkZtcW1tai9NZndG?= =?utf-8?B?Y2ErV3BXa2d0K002SURoOUdkb25JTm5zdVBuUWlvc2JyeVFSdGpsZ0o5dmlI?= =?utf-8?B?bkNyeEpBZHR3ZjR3NFB3V09heHFFNkYwc28xb3MwU242ZmZjMFBsdENKMCsv?= =?utf-8?B?WDlNOHp1OFJINGx4WUZoZ1JhdHNnV0tlRkxOaGE2NnRpVlVRd2xYRzRGZGdl?= =?utf-8?B?SmFFTnlJMFhNbkxWZWl2bEcwclJnZFFqWXBVSVZXcFFKWXFsQlM1a3dxeGRV?= =?utf-8?B?RTJpN1pUNjZwQ3pzV0lSeTBvbjNHa0s3aXpBVEd1eGppWWc5YnIyNHgrenNC?= =?utf-8?B?dGV3czRXUlNaWmVqeVY2Y1VIQkhtQWFpN0ZDSldwTnRlcXlId2tkT2J2ZFl3?= =?utf-8?B?L2ROQnlQV1FyM045S0tQNlhWejRLM3hKdGpURnlFMzk2a2p0TFh6RDVMVXl4?= =?utf-8?B?aTYwZ2piaFhHYklTWXRMbGE0OVF1VGZLbm1XTnR1MS80clVXVnM3OG80djdL?= =?utf-8?B?T1p4WkFmek5obDVETlI1WGVJWnVCNlNwTnpVekc5b1NqQ1FUTG5ZUTV1Z0g0?= =?utf-8?B?aG4vUmZRb1dHdmFLMHFxWUxHQUVhOHNtanZOSGtrSTRaZUppcVBQTlBLOG9u?= =?utf-8?B?UTFNNTVaTmdid2ZjUmpLcVRyeEtNK09HSWZONGZxQlpXYnpqTUprZWJYTzQw?= =?utf-8?B?aHNkcjRzc0xtMGE5WWRLOWNQOHo3REtqZGFnaDZaV3pudktyaWM2MVlEcnQ2?= =?utf-8?B?em1KV1ZVS0ZXU09pVUJZaEp3UTlLc1hMdDZlWnF3dDNsc2dMZUhDenUrcjZO?= =?utf-8?B?VkFEMDg2U0E4Y0MyU2lDMGFvRGs2Z0h4NlJHMS9ReEg4bk50TEg2UGxKK3Q2?= =?utf-8?B?cFQzN0czR2dTWmhuV2lsVEpUdm9xdjdvOTBDb3VEYWlPeFZKRkVzVTAzZVJu?= =?utf-8?B?VTlKc1ZBT2VMYVBFR3J4bERNdThQRjNud2pnUVFjRERVZm5hZFFxWk0zcjVB?= =?utf-8?B?UXRJd3JJTTNSZUROTFVXbVpUdjBralFRSUpIRGpzTUsrbUFnekpQSjA0UzBY?= =?utf-8?B?NG1qWXQzWTQvMkNLQVE5L3ZNY3NnSmhQc2t5ZjhVOXF2U2YyV25rajdaZld3?= =?utf-8?B?ZThKVDlHZE5QdU1rSE5TL3d1TmpXeTU0S3Vlamo3aWp2VlFUcyt5NERoM3Rx?= =?utf-8?B?WXZQcjZlYUxjOStmc2JWU3dGRG5qNWFPUEtLbnlNK1p5ODRlOVdLcHJEc2No?= =?utf-8?B?ejkzTlZSZ01uVUdwMGdSUVV1Uy9RNG1mbXVGckRWMlk5a1ZMeU5zdlAvNFJR?= =?utf-8?B?YUdXNmhRaG94TSthaG82Z2VBSWU1VHJGcmZDU25vZDF1bTNPWDliMXhGalVO?= =?utf-8?B?eHF5SmR0U3M0eitOMTNuUUNmSGRBPT0=?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: bb47a90d-6b00-48d6-e382-08dde623af3e X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2025 11:11:49.5654 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7QhSbBXONV4jRWTLhJxYmFKHg8YhS82A5Q6rqw3ck0XSAaOldhZbVkmAfmy1kXRcYV/UMkD+bt0yF+GpkILeVhtSyn1M8HFhnHKNoDfISug= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR02MB8077 X-Proofpoint-GUID: bsTvExJTwySrb2iz_1Znvd1x-Rq_OC74 X-Authority-Analysis: v=2.4 cv=c+WrQQ9l c=1 sm=1 tr=0 ts=68b0397b cx=c_pps a=MPeZxNXPLKxVoTdC8D++DA==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=QyXUC8HyAAAA:8 a=siTUgUNpisOazrLkBMQA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: bsTvExJTwySrb2iz_1Znvd1x-Rq_OC74 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODI4MDA5MyBTYWx0ZWRfX3S+P0SvevhOK yRRwRhCQugEjXdGFi1iL++IqG0VjNd0AB83pAkGiAL5xzcoeK4HNvuU7Y/p26QrzOV9LWtsnPBB LggYNjIJXF+YNP5NrugMb7x8LLag1A5ahctz3UMudvpCdDN++rzXYQAISVp7bZ5M2M4u4wJmdLZ Zyy8eiCo/Dw2vx9RQnBrxF5t34q/cKRiiY+bJsUGg+7bNry4DJswuu147WdPU7a+Qot9QBzdPMf 1zXzOocQ2CLI8ESwitGmR6G6i3LSronB2fVpf+Zm5+jyGbdbBcnzhtMTERTU4keZpGVtDiIzY6V cBqOe5/ZuC2sQJ6YasQQunlP1crZrA3TP5exrH+xalW05BTp2vKvaDO/7jPHRw= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-28_03,2025-08-28_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1756379596354116600 PCI is always enabled on the pc-i440fx machine so hardcode the relevant log= ic in pc_init1(). Add an assert() to ensure that this is always the case at runtime as already done in pc_q35_init(). Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Xiaoyao Li --- hw/i386/pc_piix.c | 194 ++++++++++++++++++---------------------------- 1 file changed, 77 insertions(+), 117 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 72ddd9b149..3ea77b2c44 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -125,6 +125,11 @@ static void pc_init1(MachineState *machine, const char= *pci_type) MemoryRegion *rom_memory =3D system_memory; ram_addr_t lowmem; uint64_t hole64_size =3D 0; + PCIDevice *pci_dev; + DeviceState *dev; + size_t i; + + assert(pcmc->pci_enabled); =20 /* * Calculate ram split, for memory below and above 4G. It's a bit @@ -195,38 +200,36 @@ static void pc_init1(MachineState *machine, const cha= r *pci_type) kvmclock_create(pcmc->kvmclock_create_always); } =20 - if (pcmc->pci_enabled) { - pci_memory =3D g_new(MemoryRegion, 1); - memory_region_init(pci_memory, NULL, "pci", UINT64_MAX); - rom_memory =3D pci_memory; - - phb =3D OBJECT(qdev_new(TYPE_I440FX_PCI_HOST_BRIDGE)); - object_property_add_child(OBJECT(machine), "i440fx", phb); - object_property_set_link(phb, PCI_HOST_PROP_RAM_MEM, - OBJECT(ram_memory), &error_fatal); - object_property_set_link(phb, PCI_HOST_PROP_PCI_MEM, - OBJECT(pci_memory), &error_fatal); - object_property_set_link(phb, PCI_HOST_PROP_SYSTEM_MEM, - OBJECT(system_memory), &error_fatal); - object_property_set_link(phb, PCI_HOST_PROP_IO_MEM, - OBJECT(system_io), &error_fatal); - object_property_set_uint(phb, PCI_HOST_BELOW_4G_MEM_SIZE, - x86ms->below_4g_mem_size, &error_fatal); - object_property_set_uint(phb, PCI_HOST_ABOVE_4G_MEM_SIZE, - x86ms->above_4g_mem_size, &error_fatal); - object_property_set_str(phb, I440FX_HOST_PROP_PCI_TYPE, pci_type, - &error_fatal); - sysbus_realize_and_unref(SYS_BUS_DEVICE(phb), &error_fatal); - - pcms->pcibus =3D PCI_BUS(qdev_get_child_bus(DEVICE(phb), "pci.0")); - pci_bus_map_irqs(pcms->pcibus, - xen_enabled() ? xen_pci_slot_get_pirq - : pc_pci_slot_get_pirq); - - hole64_size =3D object_property_get_uint(phb, - PCI_HOST_PROP_PCI_HOLE64_SI= ZE, - &error_abort); - } + pci_memory =3D g_new(MemoryRegion, 1); + memory_region_init(pci_memory, NULL, "pci", UINT64_MAX); + rom_memory =3D pci_memory; + + phb =3D OBJECT(qdev_new(TYPE_I440FX_PCI_HOST_BRIDGE)); + object_property_add_child(OBJECT(machine), "i440fx", phb); + object_property_set_link(phb, PCI_HOST_PROP_RAM_MEM, + OBJECT(ram_memory), &error_fatal); + object_property_set_link(phb, PCI_HOST_PROP_PCI_MEM, + OBJECT(pci_memory), &error_fatal); + object_property_set_link(phb, PCI_HOST_PROP_SYSTEM_MEM, + OBJECT(system_memory), &error_fatal); + object_property_set_link(phb, PCI_HOST_PROP_IO_MEM, + OBJECT(system_io), &error_fatal); + object_property_set_uint(phb, PCI_HOST_BELOW_4G_MEM_SIZE, + x86ms->below_4g_mem_size, &error_fatal); + object_property_set_uint(phb, PCI_HOST_ABOVE_4G_MEM_SIZE, + x86ms->above_4g_mem_size, &error_fatal); + object_property_set_str(phb, I440FX_HOST_PROP_PCI_TYPE, pci_type, + &error_fatal); + sysbus_realize_and_unref(SYS_BUS_DEVICE(phb), &error_fatal); + + pcms->pcibus =3D PCI_BUS(qdev_get_child_bus(DEVICE(phb), "pci.0")); + pci_bus_map_irqs(pcms->pcibus, + xen_enabled() ? xen_pci_slot_get_pirq + : pc_pci_slot_get_pirq); + + hole64_size =3D object_property_get_uint(phb, + PCI_HOST_PROP_PCI_HOLE64_SIZE, + &error_abort); =20 /* allocate ram and load rom/bios */ if (!xen_enabled()) { @@ -242,72 +245,51 @@ static void pc_init1(MachineState *machine, const cha= r *pci_type) } } =20 - gsi_state =3D pc_gsi_create(&x86ms->gsi, pcmc->pci_enabled); - - if (pcmc->pci_enabled) { - PCIDevice *pci_dev; - DeviceState *dev; - size_t i; - - pci_dev =3D pci_new_multifunction(-1, pcms->south_bridge); - object_property_set_bool(OBJECT(pci_dev), "has-usb", - machine_usb(machine), &error_abort); - object_property_set_bool(OBJECT(pci_dev), "has-acpi", - x86_machine_is_acpi_enabled(x86ms), - &error_abort); - object_property_set_bool(OBJECT(pci_dev), "has-pic", false, - &error_abort); - object_property_set_bool(OBJECT(pci_dev), "has-pit", false, - &error_abort); - qdev_prop_set_uint32(DEVICE(pci_dev), "smb_io_base", 0xb100); - object_property_set_bool(OBJECT(pci_dev), "smm-enabled", - x86_machine_is_smm_enabled(x86ms), - &error_abort); - dev =3D DEVICE(pci_dev); - for (i =3D 0; i < ISA_NUM_IRQS; i++) { - qdev_connect_gpio_out_named(dev, "isa-irqs", i, x86ms->gsi[i]); - } - pci_realize_and_unref(pci_dev, pcms->pcibus, &error_fatal); - - if (xen_enabled()) { - pci_device_set_intx_routing_notifier( - pci_dev, piix_intx_routing_notifier_xen); - - /* - * Xen supports additional interrupt routes from the PCI devic= es to - * the IOAPIC: the four pins of each PCI device on the bus are= also - * connected to the IOAPIC directly. - * These additional routes can be discovered through ACPI. - */ - pci_bus_irqs(pcms->pcibus, xen_intx_set_irq, pci_dev, - XEN_IOAPIC_NUM_PIRQS); - } + gsi_state =3D pc_gsi_create(&x86ms->gsi, true); + + pci_dev =3D pci_new_multifunction(-1, pcms->south_bridge); + object_property_set_bool(OBJECT(pci_dev), "has-usb", + machine_usb(machine), &error_abort); + object_property_set_bool(OBJECT(pci_dev), "has-acpi", + x86_machine_is_acpi_enabled(x86ms), + &error_abort); + object_property_set_bool(OBJECT(pci_dev), "has-pic", false, + &error_abort); + object_property_set_bool(OBJECT(pci_dev), "has-pit", false, + &error_abort); + qdev_prop_set_uint32(DEVICE(pci_dev), "smb_io_base", 0xb100); + object_property_set_bool(OBJECT(pci_dev), "smm-enabled", + x86_machine_is_smm_enabled(x86ms), + &error_abort); + dev =3D DEVICE(pci_dev); + for (i =3D 0; i < ISA_NUM_IRQS; i++) { + qdev_connect_gpio_out_named(dev, "isa-irqs", i, x86ms->gsi[i]); + } + pci_realize_and_unref(pci_dev, pcms->pcibus, &error_fatal); =20 - isa_bus =3D ISA_BUS(qdev_get_child_bus(DEVICE(pci_dev), "isa.0")); - x86ms->rtc =3D ISA_DEVICE(object_resolve_path_component(OBJECT(pci= _dev), - "rtc")); - piix4_pm =3D object_resolve_path_component(OBJECT(pci_dev), "pm"); - dev =3D DEVICE(object_resolve_path_component(OBJECT(pci_dev), "ide= ")); - pci_ide_create_devs(PCI_DEVICE(dev)); - pcms->idebus[0] =3D qdev_get_child_bus(dev, "ide.0"); - pcms->idebus[1] =3D qdev_get_child_bus(dev, "ide.1"); - } else { - uint32_t irq; + if (xen_enabled()) { + pci_device_set_intx_routing_notifier( + pci_dev, piix_intx_routing_notifier_xen); =20 - isa_bus =3D isa_bus_new(NULL, system_memory, system_io, - &error_abort); - isa_bus_register_input_irqs(isa_bus, x86ms->gsi); + /* + * Xen supports additional interrupt routes from the PCI devices to + * the IOAPIC: the four pins of each PCI device on the bus are also + * connected to the IOAPIC directly. + * These additional routes can be discovered through ACPI. + */ + pci_bus_irqs(pcms->pcibus, xen_intx_set_irq, pci_dev, + XEN_IOAPIC_NUM_PIRQS); + } =20 - x86ms->rtc =3D isa_new(TYPE_MC146818_RTC); - qdev_prop_set_int32(DEVICE(x86ms->rtc), "base_year", 2000); - isa_realize_and_unref(x86ms->rtc, isa_bus, &error_fatal); - irq =3D object_property_get_uint(OBJECT(x86ms->rtc), "irq", - &error_fatal); - isa_connect_gpio_out(ISA_DEVICE(x86ms->rtc), 0, irq); + isa_bus =3D ISA_BUS(qdev_get_child_bus(DEVICE(pci_dev), "isa.0")); + x86ms->rtc =3D ISA_DEVICE(object_resolve_path_component(OBJECT(pci_dev= ), + "rtc")); + piix4_pm =3D object_resolve_path_component(OBJECT(pci_dev), "pm"); + dev =3D DEVICE(object_resolve_path_component(OBJECT(pci_dev), "ide")); + pci_ide_create_devs(PCI_DEVICE(dev)); + pcms->idebus[0] =3D qdev_get_child_bus(dev, "ide.0"); + pcms->idebus[1] =3D qdev_get_child_bus(dev, "ide.1"); =20 - i8257_dma_init(OBJECT(machine), isa_bus, 0); - pcms->hpet_enabled =3D false; - } =20 if (x86ms->pic =3D=3D ON_OFF_AUTO_ON || x86ms->pic =3D=3D ON_OFF_AUTO_= AUTO) { pc_i8259_create(isa_bus, gsi_state->i8259_irq); @@ -321,7 +303,7 @@ static void pc_init1(MachineState *machine, const char = *pci_type) x86_register_ferr_irq(x86ms->gsi[13]); } =20 - pc_vga_init(isa_bus, pcmc->pci_enabled ? pcms->pcibus : NULL); + pc_vga_init(isa_bus, pcms->pcibus); =20 /* init basic PC hardware */ pc_basic_device_init(pcms, isa_bus, x86ms->gsi, x86ms->rtc, @@ -329,28 +311,6 @@ static void pc_init1(MachineState *machine, const char= *pci_type) =20 pc_nic_init(pcmc, isa_bus, pcms->pcibus); =20 -#ifdef CONFIG_IDE_ISA - if (!pcmc->pci_enabled) { - DriveInfo *hd[MAX_IDE_BUS * MAX_IDE_DEVS]; - int i; - - ide_drive_get(hd, ARRAY_SIZE(hd)); - for (i =3D 0; i < MAX_IDE_BUS; i++) { - ISADevice *dev; - char busname[] =3D "ide.0"; - dev =3D isa_ide_init(isa_bus, ide_iobase[i], ide_iobase2[i], - ide_irq[i], - hd[MAX_IDE_DEVS * i], hd[MAX_IDE_DEVS * i += 1]); - /* - * The ide bus name is ide.0 for the first bus and ide.1 for t= he - * second one. - */ - busname[4] =3D '0' + i; - pcms->idebus[i] =3D qdev_get_child_bus(DEVICE(dev), busname); - } - } -#endif - if (piix4_pm) { smi_irq =3D qemu_allocate_irq(pc_acpi_smi_interrupt, first_cpu, 0); =20 --=20 2.43.0 From nobody Sun Sep 28 15:28:19 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1756379682; cv=pass; d=zohomail.com; s=zohoarc; b=QwaQath7e34Xay1zc2rreNovSIeSfW5Q7MybFBjALP7nlaXV8+QyFCX9ireXhmNfY/dEbnzL8sXljoPwBAtESd7cqzT1qwQ6QI3xWsicooB8pcL5wDd/La78mjP6hFx7ftysuZPCy54TdpGJYPAQEFWc8jtvKzRmzkk50Lt8V5Y= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756379682; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=iOHedt5jRSDxiY8AuLdAuf0HAnQDiIeeTfNX5c0mrog=; b=f7iH0A3hdF5VEOt+XfeoD/VCTFEUqw3sl4AccRTr1ukbG41D+Eo5wFjwec2gxzcVp4v0lh5IiqFK7AMETSjSIgGMUtFpw20q0f0Df4cw4TD5MCBZA5kFkLgODjnXxvKXGpgY/ZnZII7Zfu7Wcn0VCyrwtOlHwXV7IubVpIdLUSc= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756379682476406.5808596648304; Thu, 28 Aug 2025 04:14:42 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uraY1-0000FL-Bv; Thu, 28 Aug 2025 07:12:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uraXz-0000DG-2c for qemu-devel@nongnu.org; Thu, 28 Aug 2025 07:12:03 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uraXw-0005WR-Fs for qemu-devel@nongnu.org; Thu, 28 Aug 2025 07:12:02 -0400 Received: from pps.filterd (m0127841.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57SAR2b23581295; Thu, 28 Aug 2025 04:11:58 -0700 Received: from sj2pr03cu001.outbound.protection.outlook.com (mail-westusazon11022109.outbound.protection.outlook.com [52.101.43.109]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 48tcc316m1-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 28 Aug 2025 04:11:58 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BN0PR02MB8077.namprd02.prod.outlook.com (2603:10b6:408:149::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9052.23; Thu, 28 Aug 2025 11:11:53 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%3]) with mapi id 15.20.9052.019; Thu, 28 Aug 2025 11:11:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=iOHedt5jRSDxiY8AuLdAuf0HAnQDiIeeTfNX5c0mr og=; b=xABoy/svVf4XCcmy7voHVMQbS9CfSfgntezhme/GVKEbBLi1cPbN+QPrQ DynzzKKIFLJsnzUexD8E7RuVKN1ozWgbdEhI0o+J8QeMBejUomVgEcdTp347Phha fKUXnLpLs1k8nk9Olj0UqBrYAYswPuipV+FRQN2kA7YRQg6VNTd6fesq89jhx+7u zEr9MH3v4b5J0POnu18aoqSQruwaIWPU//WQdVrpddcU/RfxwUfsG6O5DUtTHlc/ PIquYSfA4rG59DD8k8zR5qhHBxVVDjs7fcUZ9/0qygFNgWoHhTuI5H1WU42vf3aR nG0h2jlAeeQ85UQiSNGkc4gmKQDNg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AaLZ683oMBGkKJSmZw8jq3HHhSNGOZeZ51Mu4CI3g82qbw8mRcYIGqEm3WqurO+LTw3Dtm5ba8z6pRx4SVIH3ikd0vbyHQBaL2WIsuhQ9fwdc2p5EW1dfNh1Q1VAQw4iBKnfB9RkVQGQaefMh9/Pu+c+wnZwLe5AFdHNWqdbFlyDRyQSnj9wla9fT+6uIeS6IDjbxVR77ACU1dyZI6QRrzZCig0oOGC0YSltwOSAsI84nP+WurWA2vjuiAkg8fDQXD3LwZqzJ9CiE1Jo/p2ddZnTRyklhCyaOqcuieAIAKmt714VwEdLtoiH2GANJtkx95evC5SBXnG+CbkdaTFeBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iOHedt5jRSDxiY8AuLdAuf0HAnQDiIeeTfNX5c0mrog=; b=OkR2Xju4qz8K+MOBdnXLHJeJyofviLym7qdyBt3DsLy1xChVzNMzEIDfXYRXuegNgP7jAw5zHs6o2vkIcP+YYC3pXhU/dODMhb9FF3zE0Lyq9aSh5zSCAGsOl1XKpZopiyfKTl69uCYp4HaTztcxAX+cPrBYDn4N3EQCZkQAsMKscVLNv6s879upq2pzk1r2h3IhD8yfvQDA5L6h8gqFv5EAk83UZ1oT2lUksLnQzhJJLWCrErXeEVB03BdAlnBI/tTin8uVfVHJxKLG6imGUvOj/wBVraKixu3oM6Ra9FkJRC0l52y0xWV4lOlGPD9N3mTX9GT6hJkzyqS8NRAxag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iOHedt5jRSDxiY8AuLdAuf0HAnQDiIeeTfNX5c0mrog=; b=q1uA8p3ad7mHNU5jUCaCVHM1bqcsertd2LzoDvhGaNLfFRMU/Gc2eDckb1n30FioAadDysfuH37ztQoTgXXBNfLTFD7wb7v/O5uMlb2Q/08zm9F0k0UJ+igdWM/YxhpUA2BkSYdc9P5LXpu4DNtrHTHz9cmx3/CPkgYsbCloUhSER8+1ky8LbBm75N6wG1Te+eBwJw18JlPtFZ9UvEQWgQO1r/EoIpLfLcoa8DWk/h+dUw6mXrvqsX/qfETWMvgvH6on4C7F0+/msfLZobV1z+/VplJ9E/diKpjrGDJgwmte1NPgr1vbLi2e+NRNm2uKywSnBdh5XiMszQoJQrOTKw== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v7 16/19] hw/i386: move isapc machine to separate isapc.c file Date: Thu, 28 Aug 2025 12:09:59 +0100 Message-ID: <20250828111057.468712-17-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250828111057.468712-1-mark.caveayland@nutanix.com> References: <20250828111057.468712-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM4PR05CA0008.eurprd05.prod.outlook.com (2603:10a6:205::21) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BN0PR02MB8077:EE_ X-MS-Office365-Filtering-Correlation-Id: 43ed3f62-d0b5-4cc6-34de-08dde623b151 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|10070799003|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?lrnWHdzbn602I4MD54AkbmOug4uKPH+nFpGopuQK7ryxwTJSWVlGnuo3GFIN?= =?us-ascii?Q?8kuniqJ7GT5V/wgvXLU6DAxrXKgCqekJCi2RlLBOdzilVzA6V71ntiIscDJM?= =?us-ascii?Q?hpqxp6ASLYo1EOsSUs0/T6V8h/KzGNxZYTe0Y8piOBjBjhfVMwEk5KknVlaH?= =?us-ascii?Q?EcJ0DmCt6IS+AwKUq4O7VdWZnzdPg8u4SMdFrBKTcLYmchdMuU0T1QYlaF3R?= =?us-ascii?Q?NmhjDOiQayfmZ87cR9Czrei8s2k5KU1wzBaaCWKqwNOMhxgwP2BjqnvyPwcN?= =?us-ascii?Q?NIFIVho4sGlVolv4O6ISvObTKb+CrDLZCIo/YJdXg+EbO5nI6orgIpVlb6BV?= =?us-ascii?Q?3S7OZI2hPTro7LX/NCSCE059Ygveen70Q5O6AX0RlkdLKYNySozEa76IVieG?= =?us-ascii?Q?M5wm+l1NDX6Yw76TBQfGswujD0HDPAp5+D5l/sbxbzW42IrVTkIOOj4D826L?= =?us-ascii?Q?M6EbSW13WshNvLmZOdAkmvl07jIMfP9s1Eubu6MN+zcljM/ngCK0D9GDXWaL?= =?us-ascii?Q?DdnqVNsif4wsiv4h42RrBK60b/CPHsaZlPOnH/wplgZlNlSBJTiIL60hEPot?= =?us-ascii?Q?poYdjnfYZvpm5MLJvz8sZtAsp4iOQOAweNfDRVcrKMc3nW+Oa77krSGQMyKV?= =?us-ascii?Q?eSrRK+ZvaPntkJVGRRrA2gml95vksltBVCN316XvaxtMpNe7H4awxiYbVpw3?= =?us-ascii?Q?xwK7Ut2xQazjv0zygCZwWdSgwLvNL5eMEP+1tsylikCVP0n9dR1dOpdgrZkf?= =?us-ascii?Q?zJ37O08iDGN26zejceVlh3r98FO+Te8hVKgnuNTeN8IYXiwee5+vK4AV9YO4?= =?us-ascii?Q?Qqewivhem0wr1GhbGSa+tyje4sk6BQunR0T6QnssxBwkU/9Y2S7lCv2VNTcv?= =?us-ascii?Q?QG4597eeS6weSCaKAN76k0SAAstGjRFybw0vU0C+eZFpFIBd4DGkRixl0Wkx?= =?us-ascii?Q?r1xhe4LuAUHBgA3b3xYUt+QXS3dmBDBeqU0Bba2Xp0REyeg/IuvuaJv5YRhp?= =?us-ascii?Q?xMGaC8bTm3hpOGR0ayRqq/odIn5lkP2e72BCx1tUOquwHZRGPS5f+acrghQ3?= =?us-ascii?Q?sQ2IFT3gV8QJ7Yx63Tf338vxDVyNI7hDBuLs7meeAhoyfa/S/pElcW8vMsJS?= =?us-ascii?Q?DOhWleZqXpuqLhoHRdf3aRGrWwcoLZGfHPJt1zSpm9zUfYSJ7lc6qLHVIb8N?= =?us-ascii?Q?R9xcAvfpZZ2QPgrys+hbL5AmaoY4charGYH0oAQZrZrK38B6Zu6Ni3/SWJDl?= =?us-ascii?Q?U5rk+E7hMVnkMk2mQBrV2CH8DF2k/xj02Euj7wHIZAvspmJucDTxe4yBa7UU?= =?us-ascii?Q?CIVNUPQqJvrv1BvT2VEpItrQCwmjLg8hlIrJoU7phYiMo1dDu1X8i5bXMIv5?= =?us-ascii?Q?KKChZSgGg0mCR9lGkwz7I3FAHBDApMVfl9lQ5iBehWdf6PnUbwszuRh/Lm4J?= =?us-ascii?Q?JS8EmX/Mux0=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(10070799003)(366016); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?W79byzbmU0yEVKtEzlvsePB42jaUJJayf+40yA9wHFFT+u6u25MU3s/ohLNs?= =?us-ascii?Q?IKuU/1+K+gseNq1SAdcihyXPwcp9Hl66dNNJg2dJ4G3SoDLOHiRdIFlC9O6q?= =?us-ascii?Q?KUUs39jHAB/x1AQLVg1aOIfptQVT/pX7evwW8cy8hqPUqff19D/wjpdRwYuL?= =?us-ascii?Q?eQZdKpwDwKBTgCZIhtOiizHGBVZeQEcQh72nx/GkskwuLn+eMW4+bKA/CXQW?= =?us-ascii?Q?1bGNX29e8ZV8G6vG3XTiFNzIQ5SV3xVlpIe8frCJqcBhduK/mfRDRkVB6ok4?= =?us-ascii?Q?Me1MC551rZQicRNVJI4vhS8NhzApDQT9FlFyFrxc1h94AyGcIda8WOJrJJ7J?= =?us-ascii?Q?SXjvM6Qx4XIW1SSfFkVqCNU99KFNcvcJLuLPABv1HX4YXUbflqqlVlVlJC5I?= =?us-ascii?Q?leJonQhAgnT3gca+9QM+TSxK4quGuKba74L8yK4qgvP4u4JGfCU4kdACUDHD?= =?us-ascii?Q?aADVK8aYJ/DdP64mWWG/uff97GEt2mNcJtPL266v6kp0K5Joer8+vbZIpSor?= =?us-ascii?Q?fqY0Ff5DlqMskMvqdI0p1tlNetdtZINFsqVPc+l8hKKhTaKtdtCDsMx2QoYK?= =?us-ascii?Q?u1qJAz/ZJe7jhUrkNlzccVhoPg2v3HY5tANAdkHXKgBe5SdlAgxTS4GcHIG0?= =?us-ascii?Q?1L84elr9GrCiJTuFzcKYvk8DE3zQK1FNSC6emVw+/RfYv8KVEeDNJ9w6MT3I?= =?us-ascii?Q?kzf49zO9x+lciZoWLZwrsQyS6nemZBN+ynFjRiu1BkKhB/WBRNDPDapN6WnI?= =?us-ascii?Q?N01Itv+83nOrH6biWueMvO2My8LBid80L1amqjT6Gw4ocQQUEO8om7B4Ez7Q?= =?us-ascii?Q?KEhYh5m8PrkbCVaAnG5BgZbsw8zp72gTsFC0+uUF2Y2mJNBp5ounSOQd8EBQ?= =?us-ascii?Q?uWrcF0Sh391HRFWp5o16oAG5Np+o9lZgaRUF2NBhMPq4KgMMF+JOZw/8zVLB?= =?us-ascii?Q?2dEOOP8x3g713zRYXt13OiRPYK9ZXjbLJ6OsmWSsZrIRjtBVtWduDvDAB0/3?= =?us-ascii?Q?z8UX3uvbDMtcdOZVsuyDazA+6n2mAyJIwsu5WnwZkfDXwRmw6uJEbhHRzqzJ?= =?us-ascii?Q?cJvjj4y1yvhPJ0PdNJg7Nbjc8cQArNHrra5CVfSwuQraJ93pVR2imlXn4J15?= =?us-ascii?Q?eNeB2nXw3iNN+W68i8VdSp+ooZ8j/b4Obf2mEo9ytmK08q/Rwd/9UX9Pybnz?= =?us-ascii?Q?oJ3yBCUPB3tx4bJOpdGrn7KKIV73ljEkRTXQ2s/OlTt8XceIjqgSR47aePUg?= =?us-ascii?Q?Cty2mMKX4fCSzIcZHYOOFgqc/goroDZd5OMAlMag8kthqOAdtckxk6GYBhEA?= =?us-ascii?Q?cWVeIW2pc0f0rDE9YdGoVWEDCHjorBOJfrq2BFIXZOy6GFLNGqL/paHLo7ca?= =?us-ascii?Q?7DlZ3OBbzRWVGB0b1er0MAvCugGJUZmNcFdHVIPNKg8r68eYHNWOy3GmbGrb?= =?us-ascii?Q?VeiroFg7GPmBN4CWzmLLySWh+T1PtY+5Hz1N3B0Y51EXdLK439vVEk8YPh+d?= =?us-ascii?Q?MiMCpyxr0rVP8mL6MEZOUz1DzhCWW0Q/v6r9swSJTHQejU50R1hnYUw7MmuS?= =?us-ascii?Q?DZo4Ywn2eD8eo26UZ90YCABpS55LslRDTPjcy1L8QUSmbyERdsbMDT5xTpAV?= =?us-ascii?Q?mRwGMPkTwhmHt/yFfRqsgjwq5RGMr03+M+5xvNDAbNeZkF+J4Uw/dwzSb0q+?= =?us-ascii?Q?E+oOmw=3D=3D?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 43ed3f62-d0b5-4cc6-34de-08dde623b151 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2025 11:11:53.0553 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hB4GvYiXrW8O1DpaM6QN0vBoGex2X/GHxpd9KOyRmnnzO9vsKuuW+2+4bRtV3ZtPQk5MzB6mbTlR+ZgUn9pIYTfSMof5imU1ixjkc/Ed2nU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR02MB8077 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODI4MDA5MyBTYWx0ZWRfX1G7oHdxNK78F cxtB6kN/jDjPWQYNHINZ3/1kuj1qnwuQ8hA/4oKmTRZG5hHyEPdtxCxb/DKmuIMUePjPXPmSU43 IQQox097EFGxQjI4PL/R89xDRg6soXWC/H1Q7v+A15aEpvX4Upcq8ZTtce/5P5sNWd/Yqy/xgU9 WkhpGTWtt9dexWHqZMeDAFh174suqBZjb9Qp38UwppuBXekeyAlgu5s9KvMrslQXaSTdZ2hoW9C uckql3qoUnnUlQK3nMcgsCvWX2aNJ2AngtVS7vIn5v0/DdfsNp2aNcSIXMAZ3MvNYuEdzbqROC3 jLiK9FeJv42hyZuqoFi6nvX2r2QM1Llg6uXUVfNZUC1mxhqwXwoLo3JHboCXRI= X-Authority-Analysis: v=2.4 cv=JaS8rVKV c=1 sm=1 tr=0 ts=68b0397e cx=c_pps a=lEAIQdlJR7AYAfTETB4wFQ==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=2OwXVqhp2XgA:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=pGLkceISAAAA:8 a=QyXUC8HyAAAA:8 a=7bRSbqZUHoZiyr9U6aYA:9 X-Proofpoint-GUID: 6cFOOKENSzvCcKEd5njdH0KX9yW1IvGv X-Proofpoint-ORIG-GUID: 6cFOOKENSzvCcKEd5njdH0KX9yW1IvGv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-28_03,2025-08-28_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1756379687607124100 Content-Type: text/plain; charset="utf-8" Now that pc_init_isa() is independent of any PCI initialisation, move it in= to a separate isapc.c file including the ISA IDE variables which are now no long= er needed for the pc-i440fx machine. This enables us to finally fix the depend= ency of ISAPC on I440FX in hw/i386/Kconfig. Note that as part of the move to a separate file we can see that the licenc= e text is a verbatim copy of the MIT licence. The text originates from commit 1df9= 12cf9e ("VL license of the day is MIT/BSD") so we can be sure that this was the or= iginal intent. As a consequence we can update the file header to use a SPDX tag as= per the current project contribution guidelines. Signed-off-by: Mark Cave-Ayland Reviewed-by: Bernhard Beschow Reviewed-by: Xiaoyao Li --- hw/i386/Kconfig | 3 - hw/i386/isapc.c | 190 ++++++++++++++++++++++++++++++++++++++++++++ hw/i386/meson.build | 1 + hw/i386/pc_piix.c | 172 --------------------------------------- 4 files changed, 191 insertions(+), 175 deletions(-) create mode 100644 hw/i386/isapc.c diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig index 3a0e2b8ebb..6a0ab54bea 100644 --- a/hw/i386/Kconfig +++ b/hw/i386/Kconfig @@ -96,9 +96,6 @@ config ISAPC select ISA_BUS select PC select IDE_ISA - # FIXME: it is in the same file as i440fx, and does not compile - # if separated - depends on I440FX =20 config Q35 bool diff --git a/hw/i386/isapc.c b/hw/i386/isapc.c new file mode 100644 index 0000000000..300d64b7ad --- /dev/null +++ b/hw/i386/isapc.c @@ -0,0 +1,190 @@ +/* + * QEMU PC System Emulator + * + * Copyright (c) 2003-2004 Fabrice Bellard + * + * SPDX-License-Identifier: MIT + */ + +#include "qemu/osdep.h" + +#include "qemu/units.h" +#include "qemu/error-report.h" +#include "hw/char/parallel-isa.h" +#include "hw/dma/i8257.h" +#include "hw/i386/pc.h" +#include "hw/ide/isa.h" +#include "hw/ide/ide-bus.h" +#include "system/kvm.h" +#include "hw/i386/kvm/clock.h" +#include "hw/xen/xen-x86.h" +#include "system/xen.h" +#include "hw/rtc/mc146818rtc.h" +#include "target/i386/cpu.h" + +static const int ide_iobase[MAX_IDE_BUS] =3D { 0x1f0, 0x170 }; +static const int ide_iobase2[MAX_IDE_BUS] =3D { 0x3f6, 0x376 }; +static const int ide_irq[MAX_IDE_BUS] =3D { 14, 15 }; + + +static void pc_init_isa(MachineState *machine) +{ + PCMachineState *pcms =3D PC_MACHINE(machine); + PCMachineClass *pcmc =3D PC_MACHINE_GET_CLASS(pcms); + X86MachineState *x86ms =3D X86_MACHINE(machine); + MemoryRegion *system_memory =3D get_system_memory(); + MemoryRegion *system_io =3D get_system_io(); + ISABus *isa_bus; + uint32_t irq; + GSIState *gsi_state; + MemoryRegion *ram_memory; + MemoryRegion *rom_memory =3D system_memory; + DriveInfo *hd[MAX_IDE_BUS * MAX_IDE_DEVS]; + int i; + + /* + * There is a small chance that someone unintentionally passes "-cpu m= ax" + * for the isapc machine, which will provide a much more modern 32-bit + * CPU than would be expected for an ISA-era PC. If the "max" cpu type= has + * been specified, choose the "best" 32-bit cpu possible which we cons= ider + * be the pentium3 (deliberately choosing an Intel CPU given that the + * default 486 CPU for the isapc machine is also an Intel CPU). + */ + if (!strcmp(machine->cpu_type, X86_CPU_TYPE_NAME("max"))) { + machine->cpu_type =3D X86_CPU_TYPE_NAME("pentium3"); + warn_report("-cpu max is invalid for isapc machine, using pentium3= "); + } + + /* + * Similarly if someone unintentionally passes "-cpu host" for the isa= pc + * machine then display a warning and also switch to the "best" 32-bit + * cpu possible which we consider to be the pentium3. This is because = any + * host CPU will already be modern than this, but it also ensures any + * newer CPU flags/features are filtered out for older guests. + */ + if (!strcmp(machine->cpu_type, X86_CPU_TYPE_NAME("host"))) { + machine->cpu_type =3D X86_CPU_TYPE_NAME("pentium3"); + warn_report("-cpu host is invalid for isapc machine, using pentium= 3"); + } + + if (machine->ram_size > 3.5 * GiB) { + error_report("Too much memory for this machine: %" PRId64 " MiB, " + "maximum 3584 MiB", machine->ram_size / MiB); + exit(1); + } + + /* + * There is no RAM split for the isapc machine + */ + if (xen_enabled()) { + xen_hvm_init_pc(pcms, &ram_memory); + } else { + ram_memory =3D machine->ram; + + pcms->max_ram_below_4g =3D 3.5 * GiB; + x86ms->above_4g_mem_size =3D 0; + x86ms->below_4g_mem_size =3D machine->ram_size; + } + + x86_cpus_init(x86ms, pcmc->default_cpu_version); + + if (kvm_enabled()) { + kvmclock_create(pcmc->kvmclock_create_always); + } + + /* allocate ram and load rom/bios */ + if (!xen_enabled()) { + pc_memory_init(pcms, system_memory, rom_memory, 0); + } else { + assert(machine->ram_size =3D=3D x86ms->below_4g_mem_size + + x86ms->above_4g_mem_size); + + if (machine->kernel_filename !=3D NULL) { + /* For xen HVM direct kernel boot, load linux here */ + xen_load_linux(pcms); + } + } + + gsi_state =3D pc_gsi_create(&x86ms->gsi, false); + + isa_bus =3D isa_bus_new(NULL, system_memory, system_io, + &error_abort); + isa_bus_register_input_irqs(isa_bus, x86ms->gsi); + + x86ms->rtc =3D isa_new(TYPE_MC146818_RTC); + qdev_prop_set_int32(DEVICE(x86ms->rtc), "base_year", 2000); + isa_realize_and_unref(x86ms->rtc, isa_bus, &error_fatal); + irq =3D object_property_get_uint(OBJECT(x86ms->rtc), "irq", + &error_fatal); + isa_connect_gpio_out(ISA_DEVICE(x86ms->rtc), 0, irq); + + i8257_dma_init(OBJECT(machine), isa_bus, 0); + pcms->hpet_enabled =3D false; + + if (x86ms->pic =3D=3D ON_OFF_AUTO_ON || x86ms->pic =3D=3D ON_OFF_AUTO_= AUTO) { + pc_i8259_create(isa_bus, gsi_state->i8259_irq); + } + + if (tcg_enabled()) { + x86_register_ferr_irq(x86ms->gsi[13]); + } + + pc_vga_init(isa_bus, NULL); + + /* init basic PC hardware */ + pc_basic_device_init(pcms, isa_bus, x86ms->gsi, x86ms->rtc, + !MACHINE_CLASS(pcmc)->no_floppy, 0x4); + + pc_nic_init(pcmc, isa_bus, NULL); + + ide_drive_get(hd, ARRAY_SIZE(hd)); + for (i =3D 0; i < MAX_IDE_BUS; i++) { + ISADevice *dev; + char busname[] =3D "ide.0"; + dev =3D isa_ide_init(isa_bus, ide_iobase[i], ide_iobase2[i], + ide_irq[i], + hd[MAX_IDE_DEVS * i], hd[MAX_IDE_DEVS * i + 1]= ); + /* + * The ide bus name is ide.0 for the first bus and ide.1 for the + * second one. + */ + busname[4] =3D '0' + i; + pcms->idebus[i] =3D qdev_get_child_bus(DEVICE(dev), busname); + } +} + +static void isapc_machine_options(MachineClass *m) +{ + static const char * const valid_cpu_types[] =3D { + X86_CPU_TYPE_NAME("486"), + X86_CPU_TYPE_NAME("athlon"), + X86_CPU_TYPE_NAME("kvm32"), + X86_CPU_TYPE_NAME("pentium"), + X86_CPU_TYPE_NAME("pentium2"), + X86_CPU_TYPE_NAME("pentium3"), + X86_CPU_TYPE_NAME("qemu32"), + X86_CPU_TYPE_NAME("max"), + X86_CPU_TYPE_NAME("host"), + NULL + }; + PCMachineClass *pcmc =3D PC_MACHINE_CLASS(m); + + m->desc =3D "ISA-only PC"; + m->max_cpus =3D 1; + m->option_rom_has_mr =3D true; + m->rom_file_has_mr =3D false; + pcmc->pci_enabled =3D false; + pcmc->has_acpi_build =3D false; + pcmc->smbios_defaults =3D false; + pcmc->gigabyte_align =3D false; + pcmc->smbios_legacy_mode =3D true; + pcmc->has_reserved_memory =3D false; + m->default_nic =3D "ne2k_isa"; + m->default_cpu_type =3D X86_CPU_TYPE_NAME("486"); + m->valid_cpu_types =3D valid_cpu_types; + m->no_floppy =3D !module_object_class_by_name(TYPE_ISA_FDC); + m->no_parallel =3D !module_object_class_by_name(TYPE_ISA_PARALLEL); +} + +DEFINE_PC_MACHINE(isapc, "isapc", pc_init_isa, + isapc_machine_options); diff --git a/hw/i386/meson.build b/hw/i386/meson.build index 7896f348cf..436b3ce52d 100644 --- a/hw/i386/meson.build +++ b/hw/i386/meson.build @@ -14,6 +14,7 @@ i386_ss.add(when: 'CONFIG_X86_IOMMU', if_true: files('x86= -iommu.c'), i386_ss.add(when: 'CONFIG_AMD_IOMMU', if_true: files('amd_iommu.c'), if_false: files('amd_iommu-stub.c')) i386_ss.add(when: 'CONFIG_I440FX', if_true: files('pc_piix.c')) +i386_ss.add(when: 'CONFIG_ISAPC', if_true: files('isapc.c')) i386_ss.add(when: 'CONFIG_MICROVM', if_true: files('x86-common.c', 'microv= m.c', 'acpi-microvm.c', 'microvm-dt.c')) i386_ss.add(when: 'CONFIG_NITRO_ENCLAVE', if_true: files('nitro_enclave.c'= )) i386_ss.add(when: 'CONFIG_Q35', if_true: files('pc_q35.c')) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 3ea77b2c44..988c9edc32 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -71,12 +71,6 @@ =20 #define XEN_IOAPIC_NUM_PIRQS 128ULL =20 -#ifdef CONFIG_IDE_ISA -static const int ide_iobase[MAX_IDE_BUS] =3D { 0x1f0, 0x170 }; -static const int ide_iobase2[MAX_IDE_BUS] =3D { 0x3f6, 0x376 }; -static const int ide_irq[MAX_IDE_BUS] =3D { 14, 15 }; -#endif - static GlobalProperty pc_piix_compat_defaults[] =3D { { TYPE_RAMFB_DEVICE, "use-legacy-x86-rom", "true" }, { TYPE_VFIO_PCI_NOHOTPLUG, "use-legacy-x86-rom", "true" }, @@ -392,134 +386,6 @@ static void pc_set_south_bridge(Object *obj, int valu= e, Error **errp) pcms->south_bridge =3D PCSouthBridgeOption_lookup.array[value]; } =20 -#ifdef CONFIG_ISAPC -static void pc_init_isa(MachineState *machine) -{ - PCMachineState *pcms =3D PC_MACHINE(machine); - PCMachineClass *pcmc =3D PC_MACHINE_GET_CLASS(pcms); - X86MachineState *x86ms =3D X86_MACHINE(machine); - MemoryRegion *system_memory =3D get_system_memory(); - MemoryRegion *system_io =3D get_system_io(); - ISABus *isa_bus; - uint32_t irq; - GSIState *gsi_state; - MemoryRegion *ram_memory; - MemoryRegion *rom_memory =3D system_memory; - DriveInfo *hd[MAX_IDE_BUS * MAX_IDE_DEVS]; - int i; - - /* - * There is a small chance that someone unintentionally passes "-cpu m= ax" - * for the isapc machine, which will provide a much more modern 32-bit - * CPU than would be expected for an ISA-era PC. If the "max" cpu type= has - * been specified, choose the "best" 32-bit cpu possible which we cons= ider - * be the pentium3 (deliberately choosing an Intel CPU given that the - * default 486 CPU for the isapc machine is also an Intel CPU). - */ - if (!strcmp(machine->cpu_type, X86_CPU_TYPE_NAME("max"))) { - machine->cpu_type =3D X86_CPU_TYPE_NAME("pentium3"); - warn_report("-cpu max is invalid for isapc machine, using pentium3= "); - } - - /* - * Similarly if someone unintentionally passes "-cpu host" for the isa= pc - * machine then display a warning and also switch to the "best" 32-bit - * cpu possible which we consider to be the pentium3. This is because = any - * host CPU will already be modern than this, but it also ensures any - * newer CPU flags/features are filtered out for older guests. - */ - if (!strcmp(machine->cpu_type, X86_CPU_TYPE_NAME("host"))) { - machine->cpu_type =3D X86_CPU_TYPE_NAME("pentium3"); - warn_report("-cpu host is invalid for isapc machine, using pentium= 3"); - } - - if (machine->ram_size > 3.5 * GiB) { - error_report("Too much memory for this machine: %" PRId64 " MiB, " - "maximum 3584 MiB", machine->ram_size / MiB); - exit(1); - } - - /* - * There is no RAM split for the isapc machine - */ - if (xen_enabled()) { - xen_hvm_init_pc(pcms, &ram_memory); - } else { - ram_memory =3D machine->ram; - - pcms->max_ram_below_4g =3D 3.5 * GiB; - x86ms->above_4g_mem_size =3D 0; - x86ms->below_4g_mem_size =3D machine->ram_size; - } - - x86_cpus_init(x86ms, pcmc->default_cpu_version); - - if (kvm_enabled()) { - kvmclock_create(pcmc->kvmclock_create_always); - } - - /* allocate ram and load rom/bios */ - if (!xen_enabled()) { - pc_memory_init(pcms, system_memory, rom_memory, 0); - } else { - assert(machine->ram_size =3D=3D x86ms->below_4g_mem_size + - x86ms->above_4g_mem_size); - - if (machine->kernel_filename !=3D NULL) { - /* For xen HVM direct kernel boot, load linux here */ - xen_load_linux(pcms); - } - } - - gsi_state =3D pc_gsi_create(&x86ms->gsi, false); - - isa_bus =3D isa_bus_new(NULL, system_memory, system_io, - &error_abort); - isa_bus_register_input_irqs(isa_bus, x86ms->gsi); - - x86ms->rtc =3D isa_new(TYPE_MC146818_RTC); - qdev_prop_set_int32(DEVICE(x86ms->rtc), "base_year", 2000); - isa_realize_and_unref(x86ms->rtc, isa_bus, &error_fatal); - irq =3D object_property_get_uint(OBJECT(x86ms->rtc), "irq", - &error_fatal); - isa_connect_gpio_out(ISA_DEVICE(x86ms->rtc), 0, irq); - - i8257_dma_init(OBJECT(machine), isa_bus, 0); - pcms->hpet_enabled =3D false; - - if (x86ms->pic =3D=3D ON_OFF_AUTO_ON || x86ms->pic =3D=3D ON_OFF_AUTO_= AUTO) { - pc_i8259_create(isa_bus, gsi_state->i8259_irq); - } - - if (tcg_enabled()) { - x86_register_ferr_irq(x86ms->gsi[13]); - } - - pc_vga_init(isa_bus, NULL); - - /* init basic PC hardware */ - pc_basic_device_init(pcms, isa_bus, x86ms->gsi, x86ms->rtc, - !MACHINE_CLASS(pcmc)->no_floppy, 0x4); - - pc_nic_init(pcmc, isa_bus, NULL); - - ide_drive_get(hd, ARRAY_SIZE(hd)); - for (i =3D 0; i < MAX_IDE_BUS; i++) { - ISADevice *dev; - char busname[] =3D "ide.0"; - dev =3D isa_ide_init(isa_bus, ide_iobase[i], ide_iobase2[i], - ide_irq[i], - hd[MAX_IDE_DEVS * i], hd[MAX_IDE_DEVS * i + 1]= ); - /* - * The ide bus name is ide.0 for the first bus and ide.1 for the - * second one. - */ - busname[4] =3D '0' + i; - pcms->idebus[i] =3D qdev_get_child_bus(DEVICE(dev), busname); - } -} -#endif - #ifdef CONFIG_XEN static void pc_xen_hvm_init(MachineState *machine) { @@ -887,44 +753,6 @@ static void pc_i440fx_machine_2_6_options(MachineClass= *m) =20 DEFINE_I440FX_MACHINE(2, 6); =20 -#ifdef CONFIG_ISAPC -static void isapc_machine_options(MachineClass *m) -{ - static const char * const valid_cpu_types[] =3D { - X86_CPU_TYPE_NAME("486"), - X86_CPU_TYPE_NAME("athlon"), - X86_CPU_TYPE_NAME("kvm32"), - X86_CPU_TYPE_NAME("pentium"), - X86_CPU_TYPE_NAME("pentium2"), - X86_CPU_TYPE_NAME("pentium3"), - X86_CPU_TYPE_NAME("qemu32"), - X86_CPU_TYPE_NAME("max"), - X86_CPU_TYPE_NAME("host"), - NULL - }; - PCMachineClass *pcmc =3D PC_MACHINE_CLASS(m); - - m->desc =3D "ISA-only PC"; - m->max_cpus =3D 1; - m->option_rom_has_mr =3D true; - m->rom_file_has_mr =3D false; - pcmc->pci_enabled =3D false; - pcmc->has_acpi_build =3D false; - pcmc->smbios_defaults =3D false; - pcmc->gigabyte_align =3D false; - pcmc->smbios_legacy_mode =3D true; - pcmc->has_reserved_memory =3D false; - m->default_nic =3D "ne2k_isa"; - m->default_cpu_type =3D X86_CPU_TYPE_NAME("486"); - m->valid_cpu_types =3D valid_cpu_types; - m->no_floppy =3D !module_object_class_by_name(TYPE_ISA_FDC); - m->no_parallel =3D !module_object_class_by_name(TYPE_ISA_PARALLEL); -} - -DEFINE_PC_MACHINE(isapc, "isapc", pc_init_isa, - isapc_machine_options); -#endif - #ifdef CONFIG_XEN static void xenfv_machine_4_2_options(MachineClass *m) { --=20 2.43.0 From nobody Sun Sep 28 15:28:19 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1756379604; cv=pass; d=zohomail.com; s=zohoarc; b=PHAyRjARNteAdK3yokV+/PmpZ/fgSCq6A2qJgxkX1MljMPbmjzqpIMzu04owZLCrC+j6qcU8GFiK4UAP6QBE3BiBtzjlbTJt6yjcwJCVBBT9WpKXO/xG0tYmJT64JqqROiiBPARxRA49XiOqncVJ5KEU3Iq1y39s/VaII7l77p4= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756379604; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=vsWN1p64wfTMpat4q3DpLYXXNHcQKGKjDoP0jdwRhxk=; b=UvMUDvG0UWaPyLxBKxhpE8RV3qlDT4cIPqctOh5rJojZqEJenz22AAco4oy/cgEniFFI9JgRR3hC9uLXIfd4+2vIA7i/nZa806Vvv39ZfhxMdPaVe3p9YXPdzY3qNt+v1x1LCmRa9uSX0u0fRQhP8ZSEvJQ519VnU/p4kMDEbMY= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756379604295809.4363052305084; Thu, 28 Aug 2025 04:13:24 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uraY8-0000LS-25; Thu, 28 Aug 2025 07:12:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uraY2-0000GF-6F for qemu-devel@nongnu.org; Thu, 28 Aug 2025 07:12:06 -0400 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uraY0-0005Yy-IO for qemu-devel@nongnu.org; Thu, 28 Aug 2025 07:12:05 -0400 Received: from pps.filterd (m0127839.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57SA34ev3413602; Thu, 28 Aug 2025 04:12:01 -0700 Received: from sn4pr0501cu005.outbound.protection.outlook.com (mail-southcentralusazon11021128.outbound.protection.outlook.com [40.93.194.128]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 48tbd9s9bk-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 28 Aug 2025 04:12:01 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BN0PR02MB8077.namprd02.prod.outlook.com (2603:10b6:408:149::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9052.23; Thu, 28 Aug 2025 11:11:56 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%3]) with mapi id 15.20.9052.019; Thu, 28 Aug 2025 11:11:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=vsWN1p64wfTMpat4q3DpLYXXNHcQKGKjDoP0jdwRh xk=; b=VLpsUWudoeJm5+gCdYCucbp93qznC4X2TqFXviORLm/yGSooNxdCjNi/D FbAYRt0b28Gp+EEJJxyF7eKI459h7utxZrebQtS+8ymk9T2gLjCUdw+v2SunPvLz SJPNLIg6OMmrTFbZK+EQY8PghLpvGT6yZsyeUYE5yQEMrkfe7RCEueNF6bZSk/OX 0kooP2V/1XvKcBaA2Oi9MbFLTDOXtMTWd/vBABeD3WJXUVhAnlKdT59RXz1ixs5D s2hrbCUe5g3zC8Yx6VZMaXetb3TjHUvRYdxL6C8U1RpXmsfUTt9LL/fKnZACW4jk fHtaTgNVt1a0Im95n0dXsOykhYhyw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Tt1egR44QGadK67d0Dxu9DXVJnPf0wbLv85QQcjFN/+Ps8y3Mx57VvvH7p0Kv2ZPrdC/UEyIb8nJlwAcVdqymeXoGfw+cp713WlHPDeSRcJxPy6Err6menVkPxpOznYcDeyqeJ22rQ/RccmjvHWdCkjU4cNH+bKf5zCX92YGW2LwQR4z3BSpElc9xm/FNYk2Mh+KDhcsiwtNQgaJYYYz7K0cXlSxzOzaTm7OG+1dwp+G1mWH6a10lgWQCht8/gVdjKPfxd4fdpoYZDszRFI8K78o7dwE6I2SaCdkGJvZ8reh4XXTgPriA+PbOeuTfzKd8hDIb3BdiSXJziVZWSHJIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vsWN1p64wfTMpat4q3DpLYXXNHcQKGKjDoP0jdwRhxk=; b=YDS6BpOFQrsa8+QLpMlPs1cH2fSN5w+in3zKmEqBuHeKeWUD9YWkh1tE27Dq6+3kRwyXIuSvwxxhAbVxTGstA4jbIyFcF5qZMFqxA2ehIHN6tQE7yKcwJHIBAsxw412f9eNsUo+2Hl0i5deKz70GK2+AlF1zbqYw3dhfYl6dndBEbYrzEie+aPS8r/EADoModcoNu9VncCePFxxMgwWZj4ouRxH/o4fKlJ44sZvDYJDyoFlaoPACXW9QfFK0oyGOelc77lThuBw8VHQbIsP/nCHKarozDkxk2kT2aGOVC70cf4GzmtxKt0xHGguJ539ZTKiwVCsFvmiTHobT3qOyPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vsWN1p64wfTMpat4q3DpLYXXNHcQKGKjDoP0jdwRhxk=; b=dAUwgLsuqaDOluyyHlS1gM7frxH5vX7HPOlWtEA6byby3KyqvX+2yuYgtekHX17EPggHBABU7ZWbtyt1M/fbMvdqM59z0awkSP4UzQ3f9MgZDYwKWO58zfa0KokXDJjhsMSMX68hYycZQ0c740s0qgdVaYmNn33mLQ5v/WgP5B+7MjvdKovqYesi054mtrXM9EwUfBHGbXsR/l6GoDdRDnsqtJ/iXtHUZzkc4Ty7/n2Kg/Leo4Qkj+FNSe7xo9aNdi0OfgX08kIS8bbGYcxfog052c9cQJnp4jJdD8Be4c5/tSGTC4seXpJA7kHEiOYjMuhLHqsWdaCgvK9POPoBMg== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v7 17/19] hw/i386/pc_piix.c: remove unused headers after isapc machine split Date: Thu, 28 Aug 2025 12:10:00 +0100 Message-ID: <20250828111057.468712-18-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250828111057.468712-1-mark.caveayland@nutanix.com> References: <20250828111057.468712-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM0PR02CA0008.eurprd02.prod.outlook.com (2603:10a6:208:3e::21) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BN0PR02MB8077:EE_ X-MS-Office365-Filtering-Correlation-Id: 7cbbdfda-528d-485a-a133-08dde623b310 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|10070799003|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?MkpGU0FFdVhrUVdNUEhvVGRnYTlPODZJRVJIVDBhZG9GSWdvbitjS3JsQ2xq?= =?utf-8?B?M01rd3dxY1J0Q0JabkFxTTZ2bXFwNXVNNUVOMG5kc2JlQ2lSTEpzcG9tTVR1?= =?utf-8?B?RG04Mm9vdGdxd0VQTFdFZ3VrdVdWR3ROQUpVaWx2YnJ5YmVnNC9CZC9PTnRN?= =?utf-8?B?Q3JJY09SY2pLR01LdWxMUlFwVi9ncE5yQTY0KzRPTExCSHd2WjdEakhzcktk?= =?utf-8?B?RHZXd21sMkZ2NUxnK2VWU08wZm1CaUR6cm1lMW1BWVYvc0VFMVI2YVNtUzhR?= =?utf-8?B?N2Q5aXg4T3phQnNFQjI3bmpNcDlPZ3pWQWxXMnpBV09UME94dWEvWGZwTnVH?= =?utf-8?B?TWZEMW4yRzB0anlsb0hlNE1iNUY3c0JFNmZrODMybVFuSWd5SWF5YXdIV1VF?= =?utf-8?B?elhDRDUyRG1tYUNBSnFhcEF6TDJZY01TZmkvZUR6SUk5bjVnR1JjNkJ2SGdp?= =?utf-8?B?NVFGN0NIY280T3loK2NNelhNVSs2Wjd6UjVvckxDODZjL1lZRU1lNW5MclpG?= =?utf-8?B?MzZnVmdveGZqM2FqZTkrZmMveGxYL1FBU1RqZUpvYWVoaG1mRzRnS3I4a0xN?= =?utf-8?B?QmZ5V0lpSU9QUHIwUi80K3FGSEdWaHRTQjk0NXFFcHBPb1lkaGord3BJQ09i?= =?utf-8?B?bW4veUZtM0N5NklJSW8ySDZzdmkrM21ROUpJcVJGek0vUkdjNWZHQ0JUWit5?= =?utf-8?B?Sm05R1p1U01uSnRrRWMwczJYQ3Jyckw3d3JtUU1PTGt3NXMrck1qd2NoNWw1?= =?utf-8?B?VGkzVS9rRGg5bC81bkxPT3Bxem53dk10ZjlwTnl3U0ZoV2wzWlNLSEw3Zkcv?= =?utf-8?B?Ky9PelROVllPb01Gc1lvT3IwMXRGbTdFWDNkZUIxZXArSW5NdUd6NWY5MGdZ?= =?utf-8?B?R29PcG1tQmoxeXRpU3JxYkx3VG9PbTZzbFppRXZIc3VGenE2M0NQQjN4Z2Vu?= =?utf-8?B?dHZNbysrU1BSMjMxM0RCRTVlSm9wK284eXdyRVVZQlpaWTFJTy9kdXd0c1Np?= =?utf-8?B?MlB3ZzFTSTdVb01WOTdIMi9NaHdTUTNZaG90VzNFeUtUeDNIY3Y4T3JRK2Ux?= =?utf-8?B?THoyN2ZlMHp2U0s1VkFjcnp5VXN4VU50TTB1ck1uSVIrV1E4L01VaHFrRHZr?= =?utf-8?B?bVdiZmdIOFlIN1NvTDRPR25WUFlsUHRudExlV0JtMEZxdi8zY05PKzh6bEVH?= =?utf-8?B?YUlvZEFtRFdPa0ZBSmY3REJzS3MzTHYxT1NQZ2xnUFB2ZzlzWENJVDEwaWpn?= =?utf-8?B?cGRQVTVSUWJ2OTR6YjdmT0JwUFJLVVMxeS9icnlsRkRlVHFuMFhwRkVjQkR4?= =?utf-8?B?OGllV0xnaGsvYi8vUWtnR1VXZmh4bzFGYVFVUk9ydnZwdVNGZ2pocW11SGpS?= =?utf-8?B?bnUzV09yblZxbHdlQWN3TnM5SHI0WHB0US9OU3NMM0l4dGpSbjQyQTNqM2Uz?= =?utf-8?B?QWJZMXVvUUZyQXpXaFJQUU9xMU82NVRZSVp3Mzl2UGp6ZFhScWZMdnBKVktj?= =?utf-8?B?cWY3WDMvQVpYUHdWU3ByUnZ5WXJUOGJydkFVdDZLeWxEUkJ5Y3VxcU5vdy9k?= =?utf-8?B?cUZPTmtHUU41UFY0bXdMQU1UWTArL2w0d0luZFZHM1NNdi9LeGE1c2ZNS1Bm?= =?utf-8?B?QU9ISnFCWmRLc0I5dFk5NTVNMWF3VzBZUkQzK2E1NkowajIyOHdLZ0NXWm9W?= =?utf-8?B?MVZ6MWxFWFNFdThsSlZsVXdvYlVmZXp4eXQva1liSFVQbU9ab00wZVpHQWhE?= =?utf-8?B?SjcxSFNaTXZHS2JxVDR1TG5wK2Z4YWgzQWxKOGUyRzBEdVhVVDMxMEV4ZlM3?= =?utf-8?B?L05SSjZrVUNKYWtsMnZzdEp1bHNYVkkxKzNrcTZPYkhpSFdTcXNuWW1ndmRX?= =?utf-8?B?ZlpjaDJScU91ZldNc3MvMlFNMHVxS1J0V2VqRmRGQ3d2N3c9PQ==?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(10070799003)(366016); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L3h2ciswRHltVHUrcE1KbENZN0hUajczL1hpK3lScW9oQ3FvclJWUVVqanIw?= =?utf-8?B?TENSVjN2WnIxYTlnRkJvalFFZHFOZzg1L3R2anF2UlRNQkhYNWxJaTFNV2RV?= =?utf-8?B?MDdQWFVXY0xOTnpHaGlkd1QvU1hITTdkckR2ZkxCTnVDdTh4TDJ2RFZsYm1V?= =?utf-8?B?aHE1enlMbGZiYVA1dUlNamczcmQwY2piZnNvMGhrSW1vTHREdUVnTmNtbjhY?= =?utf-8?B?Zm9QWUx3N3VncVFVNFFoM2c2NlZpbFlPR3VaTWFvVnVpbGZoRFN1dGo4ZFJG?= =?utf-8?B?SForN3NkUmt6eWdDUEk3U3NrVWdlOFNZY0QxcWk4WVYwdFFycXRPeEw3K0px?= =?utf-8?B?SUFSWnJZejFiZTBCL0hnSUp1NVlEZndNNnQvSHE3YXNBOWJibmVGU1Nra3Q4?= =?utf-8?B?T2Q5a2ZJK2lHNlBEUWNEenM4azgrcGkrS2JwK05ySHpRMUFTaVFJZDkwVjFi?= =?utf-8?B?RFdNN2ROSGQvejZEdm41b0ZtQXFndzZmYTJvdFY0dTh6TS9jTktrMU5PU3Rs?= =?utf-8?B?REd1aWNzWjdhOFJwY09VN0piWWdkRXhrMU5EQWxjNG50R29lUWdYTStJQkpU?= =?utf-8?B?WGphU2tidkZMRkN5VDFPQkFoUmFnaEM4amp1dFBZRkhBNEV1UklYV2VnNHo1?= =?utf-8?B?Z0ErZXZtbG5ZN2gvUFgvZkJIRFhjQUJya1p1bSs0eGx1eEFKNXBiSjhLTHZK?= =?utf-8?B?bUM0RElFY3NEZVlwclAxT2JQd3EyQm9wWFFzMmZYdGxQUzcwa0d5ZzN0cTNI?= =?utf-8?B?MlByRFZDMnZyL3hKMlhCOXNteU51Vlg4TlBtWkNLbFR6MTZIL29UaTVUQkJ5?= =?utf-8?B?aXpzT2k3ZkRsVkxxU1ZqZlJEUkFxMkNCOVAyeURFMnlnQVBNTDh6bHBGMVdS?= =?utf-8?B?ajRYanNTUm1XQ2hvdXdsWnIxT0NGQjlhYXBOcGtDZ0djNkU5WlRtdVlSK1My?= =?utf-8?B?MmlsTEtnRllvU2tWU09mSU1ydXdQK1RZSWFyRHUrcUNkMzRVa0RweW9YRC9Z?= =?utf-8?B?UTFQcHNKREV1TjJMTUdGdisrcHhSRHhmUGhwd1ovSHpmdnp1Q3JhdnNJeGFS?= =?utf-8?B?dWFxMDFqQkNodHRzcWZ4WlI4YUl5bVBPcXd4MHloTW5BRndDdzdIdjJpK3FR?= =?utf-8?B?RVp4aGlvUnRWWWovb2luOVN5YXZqMVZJSDRCUXZjT3VhR1ZYZUx1WmVIYzNI?= =?utf-8?B?cW02VXhBUjV6bW80U1VrcVZ3aGROQlFRc092TXBYWFZIWWtIdll5b0xiTU5o?= =?utf-8?B?TlcrRy94Uk4vY0VMSjdrL1Qzb2I1OWlVZW1HWHN1T05jcEJtR2p5alp4YWU5?= =?utf-8?B?WHVmdGxhcnF4OTJmeVZMM2dhN0ZkbXJKYkN6ejE2QWhPMVpXN2k5S0RVVUQy?= =?utf-8?B?OFdpRlkzZ0hDUk5rVUtuakZTSy9kRDhmc3lUR0lRZjh3M05zUDB0YzZuZXB0?= =?utf-8?B?UlkzYWN6RXoraGp2bytEbnhwRnBualh0aEFmU1JmYlhLZUNOY2Q2dWlGSDI5?= =?utf-8?B?cGFZUHdpK3NlOXNWNGtsS0ZJZUdhbWtWV3RxNWxIMUwxNGlnbUpBakZJZzhU?= =?utf-8?B?ajVkRlVwR3V0M3k0bGFjVDY1aG5zR1Y0QXJBb0I2bG1WUEFwcTVBRTVIRlc5?= =?utf-8?B?NmVjU3lVbkMrNmczT1dKVWRTUnVWMlk4UEJpVlBnU2FSNW93eWtnRHNUSm1R?= =?utf-8?B?RzVvcHhCZEFscWpXM2s2RFVWMHhVWlBURUR6MHA1cTNrQUd2YmFFcGlrU0tV?= =?utf-8?B?dzIwbUt4dStoSVBQWHJwS1YxRlpIbU5EUGRESmZKaGRJVnYwOXE5V1FUdE92?= =?utf-8?B?UWxhQlhuYUFsVlJROGRCeDhjZWRLUDRWUmkxR2t1SysyZUo1RC9wS2M3MTdh?= =?utf-8?B?d2dBWUNwSEdVQTJvYnpxdmRKakFtZ3ltUXRBbWdLS0VkbXE2U2FFSDJWdzd0?= =?utf-8?B?bVdGYTF4WGZiaktWak5LM2ZYTERHSysyTVJCeGdvWGRnSFFPL08yME41Nit5?= =?utf-8?B?bTVCUkp3Y2VRVFd1RGJpekM0TlJrQjFZRXZ6NVNNYmhlYWdyWFNWdUhRUXlZ?= =?utf-8?B?ZXYrN2ZBSFJPUWkrSWhaNXQvL2xPWUhRT0pveVJpTVEwZjZhVVN1WEJ6Tjl0?= =?utf-8?B?c0Q4Y2FQQ0ZyTFZoNUV3ME4yREEvWGdZbWZ5UXdac3lTRFVIKzJkbGhlTGM2?= =?utf-8?B?KzRTbzNzOUNaYUYrZldNdkhnZUV2cEVuUStTaVBnYm9SejE1VS9HK1AxR0JY?= =?utf-8?B?RStGckdkalNlTTZWN2JWNVUzWEp3PT0=?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7cbbdfda-528d-485a-a133-08dde623b310 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2025 11:11:55.9527 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mmPNgTcwUpKoHOCGLhkb6VrDjAwbAYh210PHqOwKO7uiZ9X1e3fRYRY1AdGvgerfj5w+6MY5YjmguLQCIOuTUyDP5Ylq0cQ0P6z5MMCop/4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR02MB8077 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODI4MDA5MyBTYWx0ZWRfX1tWQbCuIStlH vbvC5r4BJyeFvuGCMGsfz34slRIYBPPg27V3cgyYHJkCuUU6Y0I5BCkP3Q2JVL2sZ061iJUtQgs 9OZ2c76t8V/4pCBwIieaakGyTcH06WfBiC7b/3twTsLx6HBLnFP42KsXgfUxT+1GOrDLmrUp3Ep YKAoZHqxPaegN9qJydH1EFMOn9yQlBHtYHVY4C18E5atSntS/RJ9+i2cKrvp/FcT6GMdEiwqqmR mkwu4prEG2FAejidQ4Rv2qlal/fYiyeLgzR0ZIGSxY6K3xaQlwiaDfA6mgdHkIg3dii5mqb/rVd NONzV2uIeca7qapFGTpwfWBgL5U2l1yLNu3ctDOv+EJ6Fk0yzWejKfZz0pA3aU= X-Proofpoint-ORIG-GUID: X_dbuVZVf7fGUyKq7BsP1MQaeO1qIrAt X-Authority-Analysis: v=2.4 cv=IZ+HWXqa c=1 sm=1 tr=0 ts=68b03981 cx=c_pps a=iGETFsOoOHXRiUW2e12q2Q==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=QyXUC8HyAAAA:8 a=VVXk-92eaM9LjyQm6BwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: X_dbuVZVf7fGUyKq7BsP1MQaeO1qIrAt X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-28_03,2025-08-28_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.151.68; envelope-from=mark.caveayland@nutanix.com; helo=mx0a-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1756379606123124100 The headers for isapc-only devices can be removed from pc_piix.c since they= are no longer used by the i440fx-pc machine. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Xiaoyao Li --- hw/i386/pc_piix.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 988c9edc32..627de09c70 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -27,19 +27,16 @@ =20 #include "qemu/units.h" #include "hw/char/parallel-isa.h" -#include "hw/dma/i8257.h" #include "hw/i386/x86.h" #include "hw/i386/pc.h" #include "hw/i386/apic.h" #include "hw/pci-host/i440fx.h" -#include "hw/rtc/mc146818rtc.h" #include "hw/southbridge/piix.h" #include "hw/display/ramfb.h" #include "hw/pci/pci.h" #include "hw/pci/pci_ids.h" #include "hw/usb.h" #include "net/net.h" -#include "hw/ide/isa.h" #include "hw/ide/pci.h" #include "hw/irq.h" #include "system/kvm.h" --=20 2.43.0 From nobody Sun Sep 28 15:28:19 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1756379608; cv=pass; d=zohomail.com; s=zohoarc; b=HE6IdjBwmZvsMntBLu6pqtTPft53P9m0lUUMJtrFSbE2yTik6/S2uA9VK5Kr0nd4Abr1kevJxH8iotW2Y2E1gaGbEYZbdmZ8NZ+W8XqPbnVKW7MZqlfSJ/r9YU182mR4JmVHZvLT8P6I/fnhgnijmxUv9F4oKDOzMW3S9d4fGXE= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756379608; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=mJyHaxDaoCTIveZgNIzqGivkD8tmG9DEtYNbbzgiq4w=; b=PlAY7L/g3Oqpv4E0nAMEdrDi3n+uNdcBu7AkioVadcOOxKiXJnT4ZjQV5Um9SDjaXecgJPfP70weCjtLxOzZLplBMernh61HWc56DVQdb7P7RFLIbzDyrj6q/PQ1QtgwpYN66Ea0DUDarL+VHX2sTR62cHwIlVe8RVJG0Xy7474= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756379608324803.0851035886745; Thu, 28 Aug 2025 04:13:28 -0700 (PDT) Received: from [::1] (helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uraYM-0000Vc-SL; Thu, 28 Aug 2025 07:12:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uraY4-0000Kn-B3 for qemu-devel@nongnu.org; Thu, 28 Aug 2025 07:12:08 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uraY2-0005aL-GX for qemu-devel@nongnu.org; Thu, 28 Aug 2025 07:12:08 -0400 Received: from pps.filterd (m0127842.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57S9n9xK1758810; Thu, 28 Aug 2025 04:12:04 -0700 Received: from dm5pr21cu001.outbound.protection.outlook.com (mail-centralusazon11021072.outbound.protection.outlook.com [52.101.62.72]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 48t00vjx33-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 28 Aug 2025 04:12:04 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BN0PR02MB8077.namprd02.prod.outlook.com (2603:10b6:408:149::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9052.23; Thu, 28 Aug 2025 11:11:59 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%3]) with mapi id 15.20.9052.019; Thu, 28 Aug 2025 11:11:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=mJyHaxDaoCTIveZgNIzqGivkD8tmG9DEtYNbbzgiq 4w=; b=Y60EYpdtOc4wzzYKDUrF2dqX7B0aOvudSwU3RTlCnTbyYXF37ANhvsGbg b3U6wiltN4NqPiol1FcyLec2Ts7lTHMAFbFP8+Xtve8Vnk/MiI+o0E7kp5cDdlMy wiQ0AGpU5biWDhaP0PEKZWnnrUKGS/ZrN5UjUvSZ+mbVlVZAH0INtr/PGphE6OCV PUXNDA5YLgaIu7SvgTQF7C7bmuoyy7+e0jq1ayYQBsNeXBoFXuROlTlUELU3x4Aa 4iF6eZTRNWRM8sthOXEfxY5l+y9Cbn+XxD8npnrW+c92AoydznRf9ZyRQG+Bxxb4 TSRToZcklDgTi8dhLc6Xk1gTSua4w== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=s6qm59xCarVno5qiZg08ToTvv0fP80Z0NayA0lGjznTKFRsJZnXR9GU0RqLROh3SD/KUQLn8/Oho7cyKaJyDJXd/dL9mEMDMCJSI9BHttUUKUmvPpk7zMSNgH1OMywILOeJL6KJO86lmsQN8tpbY8/GI0EZ6hU0zq7f3/nwl0/qb7vYN0jyYEFoQj2Ee6U/ucZ5gNziwRa3GyEOVdHAEyA6yvnjRJ87Uih8FaEX805elZNznWOGeKW7xBrEKesPze0AmhNF+gd2C8bMpmKwPdMZxrj7xqvx4gPjLMzXVsii6gW1GJiVynSI7vPUaL530gC4SHzdwc5RlWuHN8/GIsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mJyHaxDaoCTIveZgNIzqGivkD8tmG9DEtYNbbzgiq4w=; b=sXcjLU8jZdkIaw8MMmz0XH8wljsUNEXYT2B5xDLZvOUt4TY26/gjMnvDw50b3Jv912dmiLRiXsay1dXQHtJnl9MhuVCV3I1UcCq4GfxD0CfVRcdbtkrYI7dxTia0GTKcxQWnMHX+pJUbuFN/6tETcz+wtjed0/goLadFprmOugi24XJz0H7c5diARkPG62YmjV0Ot57rUpbzaA5gHtRGccbyqllLALPfKGLD1I1fWCmNc1v65XpM5Wnwpr6T2jZ016xGAx93iM56ArC7CgFfgP6MqDOKI022LGXsOdsb0PuBjPfcyymPNTNfawZZ8vMmY3NACY7Knh9BJJPLE3lC8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mJyHaxDaoCTIveZgNIzqGivkD8tmG9DEtYNbbzgiq4w=; b=ANPuJvhs/BS/jRkjtXFRzuDESmqx56nlvb2fxQaimhFfaMwnmxzZq8YYtmA/fLkZc2fVTFj0Kf2XTks9cD5VIirtLdmZrcWTQyhFYXCLmTRnktdjdmf4T4Bje8C0HPpjm6DxL1eP6M0w0GXi8clOYQfRT9wmhtb6W3IC8gi0y+YJ43W5NMWRPRULUNVj9ula2UZFgjuNBNE/lYKnaz1Y5fZ9HtU8Wdlp44ToD7/2V4+Yjv8OItsPRI9LjvblDfTp5lBT6rofwwewmeabcIgRTAgtNIacPCenIFXFHFP0mPuAZz2JXIguLXlf754NLnb0gsIXZeQiNBQOUXCpLYchpg== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v7 18/19] hw/i386/pc_piix.c: replace rom_memory with pci_memory Date: Thu, 28 Aug 2025 12:10:01 +0100 Message-ID: <20250828111057.468712-19-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250828111057.468712-1-mark.caveayland@nutanix.com> References: <20250828111057.468712-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM0PR02CA0019.eurprd02.prod.outlook.com (2603:10a6:208:3e::32) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BN0PR02MB8077:EE_ X-MS-Office365-Filtering-Correlation-Id: 93343b23-90ef-4825-e282-08dde623b516 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|10070799003|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?NEl4T1ZTb0haSXFVTnRxZFpuUVYvSkx1RkY3ei9VYmxkNmdrTmJ1MFlSQWJ5?= =?utf-8?B?NWd2MFVNdjFYSS9HWS84V2NBNlBwK0tJNjBmT3c1UWorb09wNTRxMk0rWWFq?= =?utf-8?B?dmFId3h4a1plSGhEbUhiaFh1ekJsUEJTK1VnRlRsd0VNYVJ1VmdpN2lVYkVU?= =?utf-8?B?MERCRDhtWk45TjAzdDVpM0E5NzFrNThoMVRjQUtTMjhzVVcwVWJkdHhXZVJS?= =?utf-8?B?SlJGaXgvTXFWRmpOKzdhOXpDUFlsSEVLUXJGYlZ0dW5ycWVlU1c1aTVTR3g5?= =?utf-8?B?WTgxY0JybE5NT1FvNzBrVGZiY1JOSEVDalZOdFZyeW1CQmJ2bk43TG4yZSt1?= =?utf-8?B?SHdESzBaaE16VGFSWWhjTXhSdEttanA4bW9GQ0psRHJnSVVXTzY3QjNzdXNh?= =?utf-8?B?OXJobkdETnhubjdqYWN4ejdEV3g3MWh0WU9RU0t6Q0JnY0NXVi9udWFuNXdH?= =?utf-8?B?RksyREZ6aFNPQlFjQXRqNzRSU2xjanVUQ3NiYm1UOFNyYkxzdnREZDlGUmxp?= =?utf-8?B?VDl2WVdqNzJCeUNmYXJlcE1ERWJqYmdmdVdmRytFK0I5R1plMkNMUHkzaWIx?= =?utf-8?B?aVFDaVdIZlRGOXhKMkc4Qnk2Tk9YWnB3Q0tibWxlL0lsZFZnVFBIKzhZb2Vs?= =?utf-8?B?dEs4NnFXU1RBZ0dOSmJBUFNrMmNVTUNtcTJOZk5WUC94SGVRYi81cU9JZzVP?= =?utf-8?B?REpnNjd1M0ZreW5QelBVWVUrQnMvVmgxbS94UXgyUWQvYVNqQzdoM1B1NHc1?= =?utf-8?B?T2hHTm5XR214V3FSU0Y3Z2ZLT25iTDdRblRVSTIrSGl1eGVsakhMeVV1RmYy?= =?utf-8?B?WGx1aUpWZmU5dDF3amJraHZmVzlQdjFhVTBVMzFXRGQzcjN3L2tIU3g2T2VN?= =?utf-8?B?Q3pvNk1Ha09WNDhrZFphMVBKUHJKZ21lM0ptUWlqVWJ6enl4OCt0ODR1SkMw?= =?utf-8?B?MGpYeE9BckVma01yeUpOYUEweDRrZ0tnN1VhSmhZcWl4QThpMmg5SnYvbjl1?= =?utf-8?B?MFNKZ2g4OHc1T0lNNmpkRTYxNmZWaWJnR3c4RWlXRjFTeTdtd0VVblFiR2hV?= =?utf-8?B?cnZvYVFKcnNpUEtDQUw5a0ZtU05KaWpaUEp5MllIM3dXY2FZeVNyWVF2amFj?= =?utf-8?B?VHVweWMvWEtTN29rY0xvdzkraVQ1SG5ZcjM1b3NhZWZuUGJyNld0SzFSMFVY?= =?utf-8?B?NnlZV1VEUFFxbkJnUldsSjJjU2djMTNzSDdwUmhuN0hWbUp2NUdKVmt4M0N0?= =?utf-8?B?VTc1cytWZERUUDhXaFUxV3pXTHRQeTk1akphK3lLbktkanp2VGJjMWpIZkhr?= =?utf-8?B?RERBK0s0cGtpQVhYZm5JOVppeTVTS0Q0UDBjS3owVW82N3VoQ0E2T3BCenhI?= =?utf-8?B?L0l2eEk2ai8rRmM3d0UzZ0Y2eXMyWHB3bHhyd044RFRUSjNyY2ZBTGlyODgx?= =?utf-8?B?VldhVEM5K2ZMM3hKRzJqKzVVb3ltb1FLSlNlZStjUXlPZUhrc1ZNRWVXalhZ?= =?utf-8?B?RzRUcDIzYklJalc0TWdMd2tKM3Q2OTVFdWd5bTlFdXlIczk3QkNLT1FqL1U0?= =?utf-8?B?S3JYMzZJdlZTVHEwYWZtN3B0YURvU2NEZzI4eTFMNVB3UlVaVGtURHExMVNN?= =?utf-8?B?WEV3dVJHL24waExzdjVXMG44RzVSVEw1aEdmMm1aRGFpb3VhYmQ4czNBTFNF?= =?utf-8?B?S3ZQOThUb1BWaXorTHdYOEN0MGlIM0RMa0tHMzE2UEVmWlVncFQ3Z3lTSFdy?= =?utf-8?B?YmVBeHg4eDhYcWFaU1cvTldWY2hwWjNUaEw5Q0grN3JZVTVkTG5vWFJzRWF0?= =?utf-8?B?blZjZTNnM2dPaUpzMUNBMkRQT2cveGFJY0JlSEplRlFITGdtL3cxQXgyRGQw?= =?utf-8?B?V044d051ZDVodFh4dTFybGo5Q0lKZFRIS3l0U2VKWC82Wk1hdjRzVWJ1NUs1?= =?utf-8?Q?TQDK2a/t73E=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(10070799003)(366016); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?em1qZ0poTGZpU3FFZWQ1eXNnRWtRUVhwY1lITEw4QUFIYVVSbnhRZHl0L3dZ?= =?utf-8?B?YnphV1NCMkgreWRXOTZkWVpvM3NqYjJIb0JTcGw0TE5LVDlRUWsyaEgzY3lk?= =?utf-8?B?RURCV1RNNk1XaGpTbTR4VlkzZFJ1dW5oTWFkUlJVZXFjQjE0NlJLQ3M4aGp0?= =?utf-8?B?ZmsvcHBGUHVtN2xuZ3J2ODAzUkxsb1lVTG05LzBrVWZUTEVEVXUxRU9LeWo4?= =?utf-8?B?VnBwdE9sL3FpYjVUN1pSSVJOc2lXcnRzVlhhMEJrb0VHdW9aTDZRQVU3Ui9W?= =?utf-8?B?dWtXdXNreUJmb3ZsK0lIbzV6TUloRmswSUh0cktxQjhLUExPbjdvWk9zaFM3?= =?utf-8?B?VDZ2alZITTU0Slpxc0tva3g2d3JiMjF2S3EzNzN4a3U0Ti9PSFdxdjhVelRY?= =?utf-8?B?NHNJczF0Y0NRRTg0NE9MSzdsc1RhelZjelVKdlA0QmtLQWxpYURNeVAyLzFQ?= =?utf-8?B?MGZ3MExYWG1ER002eEJ1c2FQZ21ZcUNYRlNXL3FzUWFRSGVxamhTT01oY3I5?= =?utf-8?B?Wi9mT3dOWFQ2aXpmZmhSQW1tYy93R1E1RjVqay9pZE5iZm5BWlNkRlFjZUtB?= =?utf-8?B?NE51TFR1YWQybFRiYVE2NFhZUEc1Tll2OGFPSXl4Mmd2N3E4dnpDa2pXcUM4?= =?utf-8?B?OWlQTHFaTFQ4c0dXenhqSE41NzNPSUp5dEtxTVdvUjExRUtZditnaGhDZ2dW?= =?utf-8?B?aStQTUswb0NDODJDQ3lJeThtRmFzVWNvV0RublMyT3pBb3JBOW92MU9kSjZS?= =?utf-8?B?TXFVSGZGbHZ0Z2IyZ2dUUWZCWUhNOGE0L3BuU0FVV3ZxdUloKzNaVFYzZ1VL?= =?utf-8?B?TXVqTjRUMVlkYXNiR1dlM1hxUGNnTS9vWWQrZ1NYaG9GalNVUndxOHcvcFFD?= =?utf-8?B?Y0ZDWnRzMFJEcWF2TmxmUjA0MTlhcHErMVliWTIvL1VOMzh2bUpNL09zVWtR?= =?utf-8?B?djNadmZzVlVDWEZ1RWc3OWRmekxwcUN6bHA5bTAzeG8yMVlSejM3Snp1MGpq?= =?utf-8?B?VjE3VVF1SFNISCtHeWFxSEVEUXo4Qm95OWNNV0EyVm5lb0NSSXVmdHB2a25k?= =?utf-8?B?VWZmSUZhL2VvRmt5Qmp0RmJjVUIvNHpxSzlQZGxFUUlQS3pBemhsRHduSHJE?= =?utf-8?B?OW4rL1VWVlNMVElUZHdoSGhwdFloWlJ2bnY4SnNQMmd6aTNaSGVGc0NJL2w0?= =?utf-8?B?NVJqZU5zRU5hMVllV2xWNERYeWFlSWlHd0RNVm9iRkRzMEF1MTluQ1psd0Y3?= =?utf-8?B?ME1Bb3EwQWY4Z2xyYWhZTVo2L3BoSDVzOVFycmdtMkp3eDJTcW0veUI4K29Q?= =?utf-8?B?SGx5aHQ1ZWpQcURPaHI2c2p4ZVIxTndDMkZGWXd2NVgvM2dpU3MrUEJjYURW?= =?utf-8?B?ZSswT2E3QmNqM0F1cjI0MmdzbkhxVDJwUWdpVDdaNUtIblVIU3RtMnk1RDRp?= =?utf-8?B?bDFSM3hHbXhHUGczcCtPTjE1V0ZxVGRFWDQzbldNelpXdnNtajNnSkt0YVhz?= =?utf-8?B?VkQ1VkIwL3MyYWYycGg5UVh5WjFCeUJqV1U5T0E4bFp1bFNwYllDZ2trdExF?= =?utf-8?B?My9PQnlzeHh5dFJaQXpmLzFaZi9EUjRqbjI3T3dOUTgvajRNSDZlZVY4TzRj?= =?utf-8?B?ZGV2RkRrbVZJOUcvZ2NXeXE4YTdGV3o3TDBrc29tUEJXSVBReWJpSVhvTDlq?= =?utf-8?B?M2dJWmtqRTdXY0c5MVRZaDRIRnVZRmFsUXFvV2ltQ0pqU3F3bEY3VXdFMjAw?= =?utf-8?B?cUhwazlyRjhjTjZwOG1TUkJ4a2JlTnd3S3VnT2cwTGtBeGk2OWxPUmc3d24v?= =?utf-8?B?UVlSYnhsWWVZWjhjZ2FscDg3VW5Xb054TjZJRHdRQmdZRHhkZDRDOHA3VkR6?= =?utf-8?B?cG1iVzlSKzBIeHEzOUZMWWFlMXhDMlJLVFc4NWJPZWhVNk84UEZhUnR2UCsr?= =?utf-8?B?bTJzM3FKTkVGRE9uczVuR3lyZ1NGVGhMYnU5WGNpZTIwVUhrTSs1N0xKSml6?= =?utf-8?B?UG9mS3ZIalNmaGlkQVNvVVlkUjNGTkdWL1Npd1MzeE1uMW5GMFYzRWxuUjY4?= =?utf-8?B?cGFDcHFIRUdlQjFpak5lbXlwZWdtRElHRWMvV1BkbW0rYjU4S0JCb3JIT3d0?= =?utf-8?B?dWtPSUMxM0FWU3ZWUlBoV245ZDZrZUVwa3lKTkwvd0hQQldMR0VjTHdQTFl0?= =?utf-8?B?Z0dPZTB2VXRPQXFsRHd0ZFVXUk1YMFZrOGU5ckx2NDRPMHk0bjJDZkJlRlNF?= =?utf-8?B?UWErUWZtdVFsSTBhamhMTGJXUW5nPT0=?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 93343b23-90ef-4825-e282-08dde623b516 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2025 11:11:59.3578 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: p/qwblWHUNXV23BXYuvYxz8AqcImWpsX3lYPBr0yveNkgHmhfLN4WE+nxRY8J9gCQI8/JsZeDaV9zs2gkLbULt8E0s0IJsjR5eCURFmr1Us= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR02MB8077 X-Proofpoint-ORIG-GUID: U4_bCH6XqrdXlkOTmqAyOCg84uIYaR_4 X-Proofpoint-GUID: U4_bCH6XqrdXlkOTmqAyOCg84uIYaR_4 X-Authority-Analysis: v=2.4 cv=C9vpyRP+ c=1 sm=1 tr=0 ts=68b03984 cx=c_pps a=F9Mk9h/5U8Q1eoeBjDhbew==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=QyXUC8HyAAAA:8 a=VVXk-92eaM9LjyQm6BwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODI4MDA5MyBTYWx0ZWRfX4b5qdjOXslgM fjD2fgUOXc9C4TwVSWJc/0yOUEgPvvgldjnIjdkA9K//XET/SKk9WxYvim7OKI7YnCPU8k25JDa VJc5dRI9KTh3Ahm7U+zBGeb8j1SIPLVx2Ynf7PPj5TjM5KoudPLWexFS+JHP19vARz4tFeiIyHx 4Tcn32KNaIVWPCDA8FxU6zkw1smsRCQdUBZiy3WDqoR0SvhoVDQJQATd/EUfZTqnWqNc8Ss8I2h zq5o/IDpUBZHHsXguozSDh8PfN60nE07Oaj8/x5IgKNWOr0iOhNIYqeQxxxZYGjRvcMgvfpJGzg hqC5Ace0x9HJAYYXjoyI4NEw+E/Fw1/cMmznLi/T2INj4ZZl6bCeBHSeQY7n9U= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-28_03,2025-08-28_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1756379610087116600 Now that we can guarantee the i440fx-pc machine will always have a PCI bus,= any instances of rom_memory can be replaced by pci_memory and rom_memory removed completely. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Xiaoyao Li --- hw/i386/pc_piix.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 627de09c70..7e78b6daa6 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -113,7 +113,6 @@ static void pc_init1(MachineState *machine, const char = *pci_type) GSIState *gsi_state; MemoryRegion *ram_memory; MemoryRegion *pci_memory =3D NULL; - MemoryRegion *rom_memory =3D system_memory; ram_addr_t lowmem; uint64_t hole64_size =3D 0; PCIDevice *pci_dev; @@ -193,7 +192,6 @@ static void pc_init1(MachineState *machine, const char = *pci_type) =20 pci_memory =3D g_new(MemoryRegion, 1); memory_region_init(pci_memory, NULL, "pci", UINT64_MAX); - rom_memory =3D pci_memory; =20 phb =3D OBJECT(qdev_new(TYPE_I440FX_PCI_HOST_BRIDGE)); object_property_add_child(OBJECT(machine), "i440fx", phb); @@ -224,7 +222,7 @@ static void pc_init1(MachineState *machine, const char = *pci_type) =20 /* allocate ram and load rom/bios */ if (!xen_enabled()) { - pc_memory_init(pcms, system_memory, rom_memory, hole64_size); + pc_memory_init(pcms, system_memory, pci_memory, hole64_size); } else { assert(machine->ram_size =3D=3D x86ms->below_4g_mem_size + x86ms->above_4g_mem_size); --=20 2.43.0 From nobody Sun Sep 28 15:28:19 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1756381148; cv=pass; d=zohomail.com; s=zohoarc; b=ZnPRyWhG+NE4hayYt8rowaeUwfKsMzPq8zmeS6IJyieHO3fM3aa8Z8o2q46v8P3qUc2aPPPsZkcBrmr7IAOe3MgJPrRj0k9jTeVzaY7yG+F6GgVY8d/kuRYs53cF6YdIYTuOHLkC8tuQCqxKgC4MGDySqIvk5NGblteNeC9vnLg= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756381148; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=3yF+RkTzEJskY15DmAWCcxHBU7lZcaAA5Py4pflpwAI=; b=Zw+SbSaEt4RXY8DRgo0taO1FoMi3c4XBw62gRpm+JL3UIpDdrYqBrmDhcK6uNGHwF9lNY97dcPrxDhP/PFbOPZJbUkn4jlxYNPWBJeMI0azFSRgMgZ2kuzl4NhL01ZDPmFY/J4iLo0shvxNaYFsLUfh+yD36/bECh2at8a5a2OE= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 175638114807814.381642214164003; Thu, 28 Aug 2025 04:39:08 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uravu-0008Pt-Ly; Thu, 28 Aug 2025 07:36:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uravp-00084F-13 for qemu-devel@nongnu.org; Thu, 28 Aug 2025 07:36:42 -0400 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uravm-0006Rt-Ic for qemu-devel@nongnu.org; Thu, 28 Aug 2025 07:36:40 -0400 Received: from pps.filterd (m0127840.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57S7Kus52893289; Thu, 28 Aug 2025 04:12:09 -0700 Received: from bn1pr04cu002.outbound.protection.outlook.com (mail-eastus2azon11020081.outbound.protection.outlook.com [52.101.56.81]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 48t7sy1phh-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 28 Aug 2025 04:12:08 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BN0PR02MB8077.namprd02.prod.outlook.com (2603:10b6:408:149::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9052.23; Thu, 28 Aug 2025 11:12:02 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%3]) with mapi id 15.20.9052.019; Thu, 28 Aug 2025 11:12:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=3yF+RkTzEJskY15DmAWCcxHBU7lZcaAA5Py4pflpw AI=; b=P77b9j0R+FHbktsbE9MfKncXeidLyhYdMGIgcojhfhuLa1pnrRVRhTkIw YJuwzM7GQyNwjy6xWYoqiYHuzrN9MjfoVUNi+DzBKASa4xndPzsrXjwOIu/abQBi KsmusaBESJAFPBHQ/9loqW41AYM5vyWs4vUZx7APFL/mwPuktgM6yzsceMBUAnwq 4lJyMJvpXQUd3KFA1KNVZu4kbMZujbVkls72u5FpP72H5w2tQDDcvKQufX0qAEXB D41gyWC7tG8w57Wc8lLhbgbbIsRcdXxYPlQC3LDXWBlUWrULYRPLNq/QLniLQTfz tDxo72cnSS3LXvgJx4gr0Rpzj9ISA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Ch9dtcn6m+zuMHuYQrAD8SvxpG+MHOBYgtxMHaVOEknpXuGz29QDTy98Ftl3tkPFLLoK03IYBR07Se6JnNbizYp8Pgl0/vcIG//6S47T7aF9iTNf3IoCa29jmyl8+qTKjgk+OXouB+oG9Bk7v3AmiMOIIJEVkbO3HJ21HO4xaC2mf7f/4OADYRPxz2+MOapzTjj4/iYC3f+Y/qVDr2nZYa0TMQ6YrgXQ6VFl2HOoBceOmOo3sUPyZprOgbgGYj6XfEHEG8jNJVUbjUuSo21d7WO6or18zTXiNmaTnOPrXLbeSap+WUHO3AmvXYzvVk4O2wIDjukW4vIXaOWRkQ7RHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3yF+RkTzEJskY15DmAWCcxHBU7lZcaAA5Py4pflpwAI=; b=ITwAJ2Adgfl+fj9wAWLEA4ZAWO7+fTGon8Np15Sl/UO5/rP+ZICFSOH7BCbfFrV6B5nl7C3c3J2vIhXhLhCpInrfQf6CtL7nJQPVxsdPxlWfMI08MDLTC65QNwuEovbXPIXEkeDG8PCDIkNPzY9FhZUXKxa8O8XzUjCmNM/dkaiNcFKQdHrBXLsfiudqfFO52UHg22WdZgoiW1/aaJPK2HKemySdX3S08XkL2qgztZLznLE8IBK+zVjJH43T3b3jk5IfHxDRk82TYQDBkzhTR2OhD+LeyGUJnDn7KzQssV/1FVnPzsiQaTOyL4/Ts9WA+67bQqkpCwQMoYFek3J2sg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3yF+RkTzEJskY15DmAWCcxHBU7lZcaAA5Py4pflpwAI=; b=TIFZdqJKPlffqrRbf3PQNbrMLnDtO41j4N5JLM9KYAeWnVtLTO7k5Cz+g4zK00lWAg9M9d9BF4QAZqyA8KcVa1yjwD5JSM7fIV7HJAQ41X+2QE9FYDEgqKwrXTmC4gkhwppoAiJYivo92Wbo0/bORYioLS2z/zIjfJkRsvaRLjVKzw8dKKkyFRyPgLA2g+8vO6OZ9DYzPWFi7ojwTgxUwXowbzgU4nMble0JpXOrIgdcrf4gfI9wAaUDI+qcfrVuP02EU+5vBNEw3PsK88Z21BTjl1wiRkqsqXhMYAGmzEArorm8wKCRIQqxSvWcwOcd4zWRmI0+fsU6p2qKjcrkfA== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v7 19/19] hw/i386/isapc.c: replace rom_memory with system_memory Date: Thu, 28 Aug 2025 12:10:02 +0100 Message-ID: <20250828111057.468712-20-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250828111057.468712-1-mark.caveayland@nutanix.com> References: <20250828111057.468712-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS4P190CA0045.EURP190.PROD.OUTLOOK.COM (2603:10a6:20b:5d1::16) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BN0PR02MB8077:EE_ X-MS-Office365-Filtering-Correlation-Id: 172510a0-dfc8-4a32-f43a-08dde623b6fa x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|10070799003|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?VHJ1VFhqUDFYZDRuTUxWUzI1eGtaKzh0Rk1XOC8wZEIyQStDa3pVa2tGWm5S?= =?utf-8?B?L1FRVWM3NTVaNC9GN3YwcjBqVW5DY3NBR2NRRmJlek5sNjlJZ2M4OVJuZm8y?= =?utf-8?B?K3hicEI1SG1vbHNLdUFLako0c1Yvc2dVMkozd2NhREcwUEhvRVNlRlpRb01K?= =?utf-8?B?QmpxNlA3WDYyaUEzUnFuYmh6MXNxWUJXKzIzNGlFa2VQVXJqSmw0aHB0RmdE?= =?utf-8?B?YjVtYTVCZjNESWRnVHVocnEzeTYvMW1sVEtuMWowbDdod1hIVDMvVXZZeFJP?= =?utf-8?B?VS9nemdzd2x2L0pVVUk3OVQ2N0Q4UkZaK1UydFpqa0UzOUI3emtpeDIyUmpt?= =?utf-8?B?dmxKZ1I2Mm5jN1lXdVpVQnJ6QjJyQ0p4bXBFSFkyWVNxVVEwelJLMFhubnlO?= =?utf-8?B?TlRTN1JES0F4WEttbUhLSVphR08yem4rNlEzZG9IMndKWElBcXpGZ2pPWWR3?= =?utf-8?B?b21EaUVBK1JJWUlWU2JQenZXTEdlRFU2VkFhbFJESjFiLzF3K3JxL1Y1ajI2?= =?utf-8?B?MFFnWTcrQmRhVHNjUVhMVzlBcHI1UWYwYm1HK25aTDczWmswcG8rYUY4UVFw?= =?utf-8?B?aUptU2VUNG05cjRYUzhmdGdEazZucTZRTEM5aFhETzhVWCsyOXdoclpzQ2ta?= =?utf-8?B?M29xMWRBYnVZS2lRNzA0OGRNZUdGK0JRaTVvQkdPV1lmZEJKWTlaeXBVWHVS?= =?utf-8?B?ZDRJR05sRlFHeUZHT1JwL1hxVHJGcVZ4K09xL3h6b0pWSHA4WVZjWWpXd3pi?= =?utf-8?B?aWVmeHVYb1ZDUzhHeVkwL3ZQdUx6YUdRdkM1WjJlbDd3Mzk4ZDYrdzhjTkN6?= =?utf-8?B?Nm4wd1hQYTlsMEhHdG5xSVA1SVlPRWNrV2llanN6Um8rYnpXUGtIUWs5azJi?= =?utf-8?B?U284ejhnWW1wbGxPa05CMFcxcWZwZ2FiQ2NpcTJ3bW9ZeXBOb2NDaTVuMVBL?= =?utf-8?B?ZlYycU8wSkc5eDlWM0JDZHNlZnpzTEhXYkxyQ2N1a3FuL041QkdpejlRS0Rh?= =?utf-8?B?dHpteUlBM3l3aDRGTEtZUFZFQ2NhTkFVbDBEQkM5SnRreTdzSTRiQ1NKYita?= =?utf-8?B?cFZnL2ROQ0haZ1VaeVNKOW5WQlRrNG1sSzkxZzliRnN0dFU0MTZvblhTaU1B?= =?utf-8?B?cUpHNXJLcDZIellBS2FETTdJODFvQlYwWkxDUC9EOFZEYVloRERYQ2FUTm1D?= =?utf-8?B?WkpZdVovUXZERGZTSk9SVEY4MEtKQlRPaVZLc1ZPVVNxbDVPeS85aVJSaUxL?= =?utf-8?B?eGwzVTB0L0J4V0haclpwZVo4MlR1OHJOUVRtSHRQOXB0eW1rTEl1TXFleXlQ?= =?utf-8?B?ekVlSDZkUkRWamIzbWZqc1hUbW56cFNRamxRSU1ER2hBb1FxczJwNXNaNTBY?= =?utf-8?B?SUlBd09MNGEwQk9NWlozcmJLbkZxb1k0ZFZXT1VBOTZ1ODA0QWRDd2xueXVM?= =?utf-8?B?dWRuZCtQUGNac0pCTkduRVlWdEV3QXZPSG9jd0NLbDhRZVZBeXBaYnhtTHp2?= =?utf-8?B?dVFiRGNWNmJDRWxINXZ2aXRHMVBLWkhLeVlGdUgzclNkMjVYQ2YzWUQxelll?= =?utf-8?B?QTNvKzA3LzlRMFM2Y0J5eHJKY0grdnJrdUpBRS85UnJGY3ZvS0h5aG1mYzV6?= =?utf-8?B?dHN1a21NcTFsd2I0OWJzTEhzRnF3ZXhHVDNhMldlVDRSUlZ5bGNlQjRZQXZm?= =?utf-8?B?dCtCQm8zNU95bE81ODBOQ0VNaHJqOXpCT3pxMGtyVXo2V2lBSWNNNnhMbVFw?= =?utf-8?B?SXB3VmdsQjc0SGR5SWZQaUcxaFJUU3ZKZUVHbDhDek15TkVTRGl6SDdGUlNP?= =?utf-8?B?Q1d4Q2xtbkN5SW1qUnhhTkI0YXBZMFhYMnFLSVQvRGVXZUI0ZUlEYjM0ejQx?= =?utf-8?B?a0Y3eVhNaXpqU1NvZHB5TDFCaElPTFdwdHYxUTNXcDdZcUxzdDI2Y3NhSUVF?= =?utf-8?Q?JdwrYFLZBuk=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(10070799003)(366016); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YXFub1NMN2wzMFkrU1E5UkRPLzlEMEoxSXkrTWx0bG05MVNPSnBCZ1lCdS9U?= =?utf-8?B?cHlRVFVDYXJHMy9XV2xXNWJZWTNGaWcxT3JPMmhYV0p5SmxnNThub05UamJP?= =?utf-8?B?RXhEMDlYd3VKaFNuK1BYaStRQ2o5bEszcEQyRkhMTGVHVU81OTVJT25KeXJ4?= =?utf-8?B?ZUtJcUJ5V3BRbTlsc2M0VmNUWThhdjRtSmd1M3FYQzRJcW00TnJYZzNMRHRy?= =?utf-8?B?NzJrL2VzeG84VVg1c2ZYZldqblc0aFZSeWw4M3dMcWQyV2t4eUthM0VSZmdw?= =?utf-8?B?WWRaK1BiS3Ywb0MvOGNYQkNxUTl0SmtwNFlSdFR6Z0FXOTJCcmVtQ1I1OHlT?= =?utf-8?B?K2JBVjBmQ0tpdHZFWllJVHFMRjgxQTlybHRkRGNpQWxjaG8zQUVEZCthRE5S?= =?utf-8?B?ZmQzVWNheGRnaDk5MXBtbi9LN0VueENCQTBSelkxSHVPbm5YOG1Jb3JZUUVa?= =?utf-8?B?T3BCd3hKZFpFZDhTT3lXWFh3NExVMEJKTENQbTd6Wm82V1ZGUlJjOVQ5KzAy?= =?utf-8?B?dFlWdk5IUWJUMlh0bWd5bHFQS0RyNzJXWDZ6cUF6RE45dDNCRjBtL3AvaTVP?= =?utf-8?B?bmlISDdyVlhSTTJzSVJKZ1JYSjBQaDVoNTYxaE56TUNuRzNkSTNIcjVkMjl0?= =?utf-8?B?MmxxaHBYZFMxenpENVdhRVpMb2Q1T3g5aXZISWVZK2hwVHRucXlBNStMQzRi?= =?utf-8?B?dGpIbHNKeSs2Q090anlrUEpOeFhwOFpsNEpSU25hS0ZsWXF3aG9BM08zajRN?= =?utf-8?B?eVBRRnlocGpacXE5SlN3b3YzMWo2ekNIRmVZalJaRmJNWnZxOVU4N1NJNzlF?= =?utf-8?B?SWVjaHpjOUNDdFAyaUdGWHFLUlBDVWVmRFJaSTdubllqYXE5TE1rbHJtVUFT?= =?utf-8?B?aVFUNGJvZytMM2xPeDkwK3YzR0dsVVNYNlV4bFcwL09wOXdEb0dRbkNvaUhE?= =?utf-8?B?MnRvcGIvVDUvdUE0WmwyNjU3eTRaQ2pmdUN1ZS83UkxsdjZKdTZhbmVUbDFI?= =?utf-8?B?OC9paWIvcW9weU5zR0ZiMVNzSG5DK3hYVmVXT0g0SmRCSDdHTTJIR3NHckZS?= =?utf-8?B?TkE5WGt2RFNaMjVLdktGSUJwT2lrd0VpSWRlcHdMOGI2WXB0NitmLzdxYlh1?= =?utf-8?B?WkxYRCtBM2o1WWU3V3pobjZWWFJ3UkUySmF0cWNtaFVrNDdrNndIVmt0bHZW?= =?utf-8?B?TXU0WmRMMkhzTldaenZhWEhpUGxYNkFtZGNFOEY2NGlzU0JQdldLNWZRNi9K?= =?utf-8?B?UHFZN0FHWmE2TTZtTU9qTVFURmM2SDRTTFJPLzNoMUpndDhHTFlNSEtWMUNk?= =?utf-8?B?VHEveERDTzVYcVJOemFoa0IzNlJXVWZQb3lrRUlVQ2c1bkJDSWVYby9pY1Y0?= =?utf-8?B?anFubWVRdkYxTHg4c3dLSUVxRFhLd2t4SmFBVVdPM2dZWkRDUEdNazYvbTNQ?= =?utf-8?B?QUhwTERHNW5Zd2RhRFJpZWJqeTZIODd5TVhaTmQ1SmYyaGZmOWUwc0tzSEJa?= =?utf-8?B?MFFZc3lHQm9EaTFtaWc5S2paWkkxK29sRXNpY044dlJybmQrTEkzbEY2RFhU?= =?utf-8?B?eWpUSmYvOHB4dHF2ZUlwSXFjd0htVlRHdWY1Z0VmSmJ3QVdSL0Z4YytHWXIx?= =?utf-8?B?RlRxbUt5SC9zSm95QmgyQ0RLQktPbC9TK1NjajNiaEl6bFFLL3VGanpjS083?= =?utf-8?B?eVA1QlR1Wk5FVkZ3Z0crUEJIRVlnM3lqNGFHTVVqRk1vdjB5aFlZcVRsd0Zo?= =?utf-8?B?aE5aUTJpeVplWWlhZERJRHozL1dWUjFQVkV0M3JpZ1RmV00xSEV3TVBXbEp1?= =?utf-8?B?YTlZTkN1UDlPaExXVjB6WVJIcGhaUXNEUTF2ZnVwV3pGb242QXV4TWMyK2I5?= =?utf-8?B?ZHhWS0RWc0p2TTl3SmFhNnpLS3Q2cEtRa0FrcnVFeVU1V243THpZd2QvVnZY?= =?utf-8?B?OVBEbkVsaEZKS3p2aGMrTTg1NmVHNUVxN3JKSU1MWE1SYTZHRkhpVkk4aTE3?= =?utf-8?B?S3cvUU95c0JBdzJ4cUpuY212YURZNmRtUUg5dmJnbTMvS2E3a0tKQWVQNEdr?= =?utf-8?B?RXpiVTM2cVNOaXJoVkJESmlscUx4VDEyTGlSMm8xMGdJZTNYTHBsVHVZKzJx?= =?utf-8?B?WG1aME11b0tKYmFiOFR3dDJFZ08xV201cnd3Ry95NTRXa2tDcWxoSnFPZ1M3?= =?utf-8?B?M2g4dndJM1QzTWwxdmcydGhoOXpzTSt2dmNacHM2bVhJcWJsbFQvY2l4WHhY?= =?utf-8?B?aGJsUTk1TzZidlFmaGF6aVJMZCt3PT0=?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 172510a0-dfc8-4a32-f43a-08dde623b6fa X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2025 11:12:02.5329 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 16Jhguf5Eg7AYj0wycBBfvwdmc5TopPnBx0UCTk4qU6rRn+q1RjSVt6WgZvIWXaKpooi/ySseeZ6i2IftX3nnx16Zv2928OYpBqe5qvkPGk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR02MB8077 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODI4MDA5MyBTYWx0ZWRfXwwo478j8Gwhh 8rThNHBHFWCUOvFsUojeBe3QUGNAVZJu6dylxQ5Ut5AWNlNC7ocgasgMt7zhsbroCDkmlFpJgd9 JnukOSSSZ3oXSvLLWk7dW5g/GEKH3QDdecIxBy2nivE73lyMjpn+zoaCCYQxToaIiGmfXCO/Nk/ Un5W5ElEAWrGZV/nSYtu9Jz1XU9sg3X7+r32Yo9XMcBFecLb/yxtPyVS4NPSsmgXKYzSXY0b2oS agQ/+syWADX3EqskR2tZMdYBt3fNMZGkkBmyb30L7hTRWSE3oGj39YAhkhYDjrykTbWbxtnqkjx uXh6qFkizhX1QOBjbRSqmiRwbzd1YsbFg857l5WPHLbwsbmHjzu+K2PuQgZN1Q= X-Proofpoint-GUID: pb8CtKTy3ODHEGFH5K4APhPQv5wv0gyx X-Authority-Analysis: v=2.4 cv=M/VNKzws c=1 sm=1 tr=0 ts=68b03989 cx=c_pps a=H8KQetTyUVx2NtQIo3bL5Q==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=QyXUC8HyAAAA:8 a=VVXk-92eaM9LjyQm6BwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: pb8CtKTy3ODHEGFH5K4APhPQv5wv0gyx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-28_03,2025-08-28_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.151.68; envelope-from=mark.caveayland@nutanix.com; helo=mx0a-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1756381151119124100 Now that we can guarantee the isapc machine will never have a PCI bus, any instances of rom_memory can be replaced by system_memory and rom_memory removed completely. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Xiaoyao Li --- hw/i386/isapc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/i386/isapc.c b/hw/i386/isapc.c index 300d64b7ad..44f4a44672 100644 --- a/hw/i386/isapc.c +++ b/hw/i386/isapc.c @@ -38,7 +38,6 @@ static void pc_init_isa(MachineState *machine) uint32_t irq; GSIState *gsi_state; MemoryRegion *ram_memory; - MemoryRegion *rom_memory =3D system_memory; DriveInfo *hd[MAX_IDE_BUS * MAX_IDE_DEVS]; int i; =20 @@ -94,7 +93,7 @@ static void pc_init_isa(MachineState *machine) =20 /* allocate ram and load rom/bios */ if (!xen_enabled()) { - pc_memory_init(pcms, system_memory, rom_memory, 0); + pc_memory_init(pcms, system_memory, system_memory, 0); } else { assert(machine->ram_size =3D=3D x86ms->below_4g_mem_size + x86ms->above_4g_mem_size); --=20 2.43.0