From nobody Wed Feb 11 07:13:24 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1756257315; cv=none; d=zohomail.com; s=zohoarc; b=BbbAvhu8PriJzTEQqCeyb6PGTIETRgfmoDed8GQRUTCenb14zWHG/4xxWK9zEztFCjzPhn5R1Y3bIaJJr1OxHCeZBPZMTPKrrkObKzrJb8l/U+058oX+D5zoyDn2R1Q94X6zgI4Aqq5K7SxRfsSO+/4Y8h+gkAdMYHU0AnJIN1c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756257315; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Zq68Nh6Pb9LNdIJ5Ri5el2wLAJJswXT0LQtr5jRjjiE=; b=cmafBCy7Q+QhVQj3W8eVEgt7rysDh7cicFqc//2VHp34czXR8Bzz/7RPJJ5KrS62mzT0V2m4lrC2aV+uyIFZTxPdW/+Na1c0gIavQxN+zhKp5ZZ/X43BAzgfDXl4HKiqoF3uyA39A9K77CtcLNlb0qtYnGjE7RtsVCQzwpu5zwI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756257315303171.85855037462056; Tue, 26 Aug 2025 18:15:15 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ur4e4-0001h1-Dn; Tue, 26 Aug 2025 21:08:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ur4ds-0000hh-Vr for qemu-devel@nongnu.org; Tue, 26 Aug 2025 21:08:01 -0400 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ur4de-0007dK-M2 for qemu-devel@nongnu.org; Tue, 26 Aug 2025 21:08:00 -0400 Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-771e4378263so2437636b3a.0 for ; Tue, 26 Aug 2025 18:07:42 -0700 (PDT) Received: from stoup.. ([144.6.121.55]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7720274534esm1419241b3a.47.2025.08.26.18.07.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Aug 2025 18:07:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1756256861; x=1756861661; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Zq68Nh6Pb9LNdIJ5Ri5el2wLAJJswXT0LQtr5jRjjiE=; b=krK38b9UlJStO10cV3kpW9zYtIXeXbmPoK6we4icMmNAae1H29sV7BIuioYqDOK/GS EzIz4SFovfUkxkaccjv5yzpx6oqA86dQDVwEwmxPPNXDe/Zb+rJHRiuhdHuaKmwjQVCr qH3uRfElKSNCyNfQDgGvY4t3+L/JMpDu+FIwAsUnzQ78NABenxYU/69snpnb0PO294xl oPDF5TmnEhvYbP17Kv8hPZvuSUopoRaGipQJckjBsAH2AH6M4yqYbDB3yN9AsvcqIrWy IOEmq9lh4DgbrSKXeCZ1e74J/rexY+mkOoMvc2TDfPQl+qEmmhEx+AEkcGadCt2JzTz7 GDTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756256861; x=1756861661; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Zq68Nh6Pb9LNdIJ5Ri5el2wLAJJswXT0LQtr5jRjjiE=; b=H54Sm1sF5WxkXNjbVnEDhaZChlnT8yO/vU/k6CMhTO1X+cfD3WT2BkcJAhOD7RMqZB PGkF3ubzTiAxyYDN0qoiIED4VUIKqqxezMAADld/y0zSab1KdTdqDqtauBGFRE6f4/qG BpIYFumJkgB9SKLDhj/UbNa5MkcrI10ZYAy9kvbJTmvU92Ikn/EjIOpUkZEEAprIEVmN HobJbWGaI07cif0b96rVkQb8ywMoA8Di+X/PK+2fJonSMWF1m2xhmEhE/gpFnK9lFX8A AmwbG/kRJT4BD6NEgqMIDxUy/RkfXu6+yd67kW8fo1InhItakWjJoP4DqzVpf5nKpJ2S hdRg== X-Gm-Message-State: AOJu0Yx6KfhRPqVGQhd7NegkoVKdT/68+HW7xDR3oqZlxKB2vJnOHacn H1//6q+O8MEAOM8RMVrfVtrlSDC58RlXjujYFGgkurUUuqg0DGjB5W6qdozw1SRvrHrOaR3pn3U 3EcZs6CE= X-Gm-Gg: ASbGnct1azzmeYCuS1nVL380mMpcl0thDSSYlDi1ses4MHVUdDiGoMMDJv81OLGo6tD qdhzaYhVkZJFxFbnfAPMC/tj5WYQCGx6PeusWkTdUh5HHHxDDJ9iqr5TkcgfVyk6+ArnlJrjV3R 7MVU9PidiewY5fVcE6CcAMaD66/PfkKlAREy2IMCx1QHuYeHvk/uuBHC9wLDYM1aGIPXms2rs99 ovT26tT7uGgUQuZPc/nlYPP7CJAgD9dzeT/UW+P7kv26ih1vV0XECOrVJA5vsSU0vVfzPYGx3Ue o9lizaELlOVr4hlxEQFkWABLf2zycx1gB+k57oODC158DCRhQAFY8EMhDFHHLUiefnxrXJs8SMi npGo5LA0GViD1nABaRjXlipBQWQ4vzhCT1At4 X-Google-Smtp-Source: AGHT+IEZ5FLXvtTe6GUIXzOW3rp/Ki481RPdi1xKwncHmK03L23IVd8caPQcdOcACqIyqkfW8nWfAg== X-Received: by 2002:a05:6a00:a03:b0:76e:885a:c32b with SMTP id d2e1a72fcca58-7702fc47b79mr20834702b3a.25.1756256861098; Tue, 26 Aug 2025 18:07:41 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org Subject: [PATCH 30/61] target/arm: Move endianness fixup for 32-bit registers Date: Wed, 27 Aug 2025 11:04:21 +1000 Message-ID: <20250827010453.4059782-35-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250827010453.4059782-1-richard.henderson@linaro.org> References: <20250827010453.4059782-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::432; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x432.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1756257316830116600 Content-Type: text/plain; charset="utf-8" Move the test outside of the banked register block, and repeat the AA32 test. Signed-off-by: Richard Henderson --- target/arm/helper.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index 66e70abc76..d0ccc23811 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -7339,14 +7339,21 @@ static void add_cpreg_to_hashtable(ARMCPU *cpu, ARM= CPRegInfo *r, */ r->type |=3D ARM_CP_ALIAS; } - - if (HOST_BIG_ENDIAN && - r->state =3D=3D ARM_CP_STATE_BOTH && r->fieldoffset) { - r->fieldoffset +=3D sizeof(uint32_t); - } } } =20 + /* + * For 32-bit AArch32 regs shared with 64-bit AArch64 regs, + * adjust the field offset for endianness. This had to be + * delayed until banked registers were resolved. + */ + if (HOST_BIG_ENDIAN && + state =3D=3D ARM_CP_STATE_AA32 && + r->state =3D=3D ARM_CP_STATE_BOTH && + r->fieldoffset) { + r->fieldoffset +=3D sizeof(uint32_t); + } + /* * Special registers (ie NOP/WFI) are never migratable and * are not even raw-accessible. --=20 2.43.0