From nobody Wed Dec 17 16:13:35 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1756234049; cv=none; d=zohomail.com; s=zohoarc; b=RfKWXGeDP97xJHws7Ku0+kFsYuIUFaPF01qSAfrsFGCZBUr9xOVP8yYytH6S4u2x3Io7RNzOv/6bGnMCfJcXD2ZgYTy1yh+2HWQQpsgfOWpn16z/YhEnpFjZt0POB6t2yXc5jvvcwGbLM1ROZLQiW7sNlJCfqdnVM0A6CMCTxRg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756234049; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=hYcRMIyLWQvlXfcTsmqq0jOfVzmmK99eaBq5EKBXMsg=; b=nKZLTDcKRpBUOHemhrUFS73NeSjxsjDbFk4C5GpXn/KIb9ABkItElb61FcbBort66Z1mQDsJwXZvS6fBCJ1KYilZh2quTBl3NgXMPcKJZHYur1GSf1rPH7z+56VDWgteI1XSDQ7jk29iRzPOE17YTBUIfi07ncDGVB4U2XxWVZs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756234049661334.26418537129064; Tue, 26 Aug 2025 11:47:29 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uqyfi-0004yA-Pa; Tue, 26 Aug 2025 14:45:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uqyfe-0004w6-Kq for qemu-devel@nongnu.org; Tue, 26 Aug 2025 14:45:26 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uqyfT-0008Se-HB for qemu-devel@nongnu.org; Tue, 26 Aug 2025 14:45:24 -0400 Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57QFhu7L000432 for ; Tue, 26 Aug 2025 18:45:10 GMT Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48q5xfj15k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 26 Aug 2025 18:45:10 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-3274f7e6c1fso785067a91.0 for ; Tue, 26 Aug 2025 11:45:10 -0700 (PDT) Received: from admin15.qualcomm.com (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3276aeef8b8sm220661a91.21.2025.08.26.11.45.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Aug 2025 11:45:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=hYcRMIyLWQv lXfcTsmqq0jOfVzmmK99eaBq5EKBXMsg=; b=ehMRCi7RYVh3YVFF+1mDh0NYDcj 0rRCElaeWfwMGSVWzCDZ7vkof7hJe9tE3iTIi7hnPlIob3CcFYCU7Z6kW4+vApN/ FxILcxNJwpEocUZmia8UjK9kOhkG1LKHIUf9kg2Dx/ez1tGeVTHV4lU7aLE60EIL KEPGT+Ir9BUXn8WeuJFw36ZsmNipPYcUQnxIEQ42hOXq+qmUMWmXsZDn8f14XKmP GErFi8MQx/U9FHdPZ1fWfNoXI74RpvHWKfLgcBHZiOxX3lSxDKccs6v0vQ0LVTNs xvKOs7Z7v2spsjcReU4Nh0deYVFy1T/PTPvWaZIXc/Dd+HIIz4hrT89Ql0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756233909; x=1756838709; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hYcRMIyLWQvlXfcTsmqq0jOfVzmmK99eaBq5EKBXMsg=; b=DBEwfG7V0/N++pEX0PuHs/zsqWMcazBAoHJ4OwSylNSEjUd21jWZ6tqBYHEp2oLMiQ aE/cSxvak9JkX8hLX0lVVvAbeMwBkfSWG2DzZOExkPdQCwYbDpT5QR8WF/EKR6GjABQs bclUMr+AU9c2CBjrCfyjECa1WbQNr6eNU0zpeCHLfu5uBo8qDhtXFr3Pz8TAALa67+wQ BVb0WXb8N9u1lfChpOmWZoM8Sv/lQvlZyYIOJc6io4eVzUyUNNdPySZuJqe9M+0ovMyD a/bZCNnWhMyhzOXUiCkozPgB2pT33BmHHovRikb6ZhiEyohQU1S5ibhYLASK51DB6K1S mk8A== X-Gm-Message-State: AOJu0YwmbdIL8ZPvxjh3SCqjWgYWMBkcqlz142avL8MR3SpK8r0IUP2l WzAot3utJVAEEDO+IN/JvfBkRUzZBF0zAKmFZKUXTvfgQ0oTbF0BbJZOw2GDE7Yuf9QggerD/9Q JjNFd6wjUke+i54L6fm5OPufqZHYNXprtbp9pzOXkOeEPEwA2AyGXBT30QBdr58dNbB1O X-Gm-Gg: ASbGncvOmid4pq3IWGuPEQdW+Q960PMYRLC/s+uLpI2edVIYwOCp/aL/NI2XEYjWQIx M7HYM9thUsDsobJdnosZJi1FlMINYjcgbRpqEe3UmCR5VfpBCujBcP4H/gjauvq6EVZPW9z8ZWe WIYnyU76wPkTLyObn+mo5OfCNkeufEuXtwS+Hly1ZR8hBeWVKE6laUcpo70D9MJqgxrH1YhIwSF K4ipr+dsaDxVWep5dlvLwZLAqn5jM/hIlroWYY2AyaaUdaQePyAeK3qR+JkTypUVK3aQWES/g3N AIaslcvwE0fkpJ+Lz2yMhY+TWpVnUxQv0tPj+T5Opbf0RUqVUXpSkGfR/YPS/sU1PTImVLjr+6U yWKY44xX4pTfordI= X-Received: by 2002:a17:90b:4a4f:b0:325:7fc0:4a9c with SMTP id 98e67ed59e1d1-3257fc06a2amr12375308a91.27.1756233909061; Tue, 26 Aug 2025 11:45:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE/zRFG7+G9zMsi7dgEtkFDSv6GNsntMMu7y6CUttwJ/yQA10QjxO11Pd6Hs2DVdUm/uCB7xA== X-Received: by 2002:a17:90b:4a4f:b0:325:7fc0:4a9c with SMTP id 98e67ed59e1d1-3257fc06a2amr12375278a91.27.1756233908577; Tue, 26 Aug 2025 11:45:08 -0700 (PDT) From: Vacha Bhavsar To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Peter Maydell , Thomas Huth , Vacha Bhavsar Subject: [PATCH v6 1/3] target/arm: Increase MAX_PACKET_LENGTH for SME ZA remote gdb debugging Date: Tue, 26 Aug 2025 18:45:02 +0000 Message-Id: <20250826184504.510279-2-vacha.bhavsar@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250826184504.510279-1-vacha.bhavsar@oss.qualcomm.com> References: <20250826184504.510279-1-vacha.bhavsar@oss.qualcomm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODIzMDAzMyBTYWx0ZWRfXydkC1b82qaAR QRwW/dnevQAEXULTG7VYz14/3Jqucs3puAsXlSmRFq6ga+fbGgLl92LG2qwIA8hgt7oBqoNqVxH hC1NhDzjexq/KPYeDf3wWT676zHUeZFPgO7C5izM2PcW8n+3WnfLFiSUAk6Z5z8LqU/CpZvZlxP 9XlduY9fKUQOYHbJmyGNO89qjx/VP9l33IEO5G2+mN/eCk/ZvDz+ZiypB2OYtFjVF0odkgKll7N 9TkSDzvKyS6an3dtIdQzruOOs9t5qPV3BcdqCGDBggJQ/nZbZ1Ox+eGuCtvMWg3u8JO9Z7jsZES AvieFGiJ9XARkCQobJ3750a5UcIaGukJpSYGphIbGp0Ge1LrxOyxXHAHpx+/qrWljQ0GSy02S8O fLHcHSaf X-Proofpoint-GUID: DO6B85865xW8K-00Ru_Ak1HzUycv13qO X-Authority-Analysis: v=2.4 cv=MutS63ae c=1 sm=1 tr=0 ts=68ae00b6 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=2OwXVqhp2XgA:10 a=CCpqsmhAAAAA:8 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=XJBTR8SIO4LSYOdVysIA:9 a=rl5im9kqc5Lf4LNbBjHf:22 a=ul9cdbp4aOFLsgKbc677:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: DO6B85865xW8K-00Ru_Ak1HzUycv13qO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-26_02,2025-08-26_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 adultscore=0 spamscore=0 malwarescore=0 suspectscore=0 clxscore=1015 bulkscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508230033 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=vacha.bhavsar@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1756234051397116600 Content-Type: text/plain; charset="utf-8" This patch increases the value of the MAX_PACKET_LEGNTH to 131104 from 4096 to allow the GDBState.line_buf to be large enough to accommodate the full contents of the SME ZA storage when the vector length is maximal. This is in preparation for a related patch that allows SME register visibility through remote GDB debugging. Signed-off-by: Vacha Bhavsar Reviewed-by: Peter Maydell --- Changes since v4: - the value for MAX_PACKET_LENGTH is changed from 131100 to 131104 to align with a similar update made to gdbserver --- gdbstub/internals.h | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/gdbstub/internals.h b/gdbstub/internals.h index bf5a5c6302..87f64b6318 100644 --- a/gdbstub/internals.h +++ b/gdbstub/internals.h @@ -11,7 +11,27 @@ =20 #include "exec/cpu-common.h" =20 -#define MAX_PACKET_LENGTH 4096 +/* +* Most "large" transfers (e.g. memory reads, feature XML +* transfer) have mechanisms in the gdb protocol for splitting +* them. However, register values in particular cannot currently +* be split. This packet size must therefore be at least big enough +* for the worst-case register size. Currently that is Arm SME +* ZA storage with a 256x256 byte value. We also must account +* for the conversion from raw data to hex in gdb_memtohex(), +* which writes 2 * size bytes, and for other protocol overhead +* including command, register number and checksum which add +* another 4 bytes of overhead. However, to be consistent with +* the changes made in gdbserver to address this same requirement, +* we add a total of 32 bytes to account for protocol overhead +* (unclear why specifically 32 bytes), bringing the value of=20 +* MAX_PACKET_LENGTH to 2 * 256 * 256 + 32 =3D 131104. +* +* The commit making this change for gdbserver can be found here: +* https://sourceware.org/git/?p=3Dbinutils-gdb.git;a=3Dcommit;h=3D +* b816042e88583f280ad186ff124ab84d31fb592b +*/ +#define MAX_PACKET_LENGTH 131104 =20 /* * Shared structures and definitions --=20 2.34.1 From nobody Wed Dec 17 16:13:35 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1756234017; cv=none; d=zohomail.com; s=zohoarc; b=AlhHgrtGgypmSDQg/18xdt6myxJ22qv3skvmT2ooDbDbYaDj8oQGoe9mD88H/rCqnc55Xk7UWIaiw8Yswjjke/QHU7QcMtiayd6RRbxiL0DnLUlcoOQtRUqPTE8WHpIW0pmVMQgYR5u4Wzbr6aos2eKJ9mMIMFsN5Y4dsfIOXis= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756234017; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=N/cJ1VigX5TamwRxQg27K5ECt0YK3rjIAflQIFqgDpE=; b=EcZ/e8y/olcn29b1vaWK04Mj1XSwB9pWhHns6Lw2pxgjZg+IlBe0bxdYfgWHu/GN1ONqD7EQF0xq0aca3lal0WuQYjYTEpM7GlmAzBS34G5X3wR+K+zJacKe+cFtTkBRDTFEQCJSfMzqrLUCk3gmo9PNU48E57wQkvWRRsHN1QA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756234017390402.59758225874157; Tue, 26 Aug 2025 11:46:57 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uqyfe-0004vX-9I; Tue, 26 Aug 2025 14:45:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uqyfb-0004un-Fa for qemu-devel@nongnu.org; Tue, 26 Aug 2025 14:45:23 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uqyfU-0008Sv-0b for qemu-devel@nongnu.org; Tue, 26 Aug 2025 14:45:23 -0400 Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57QCRS1q004082 for ; Tue, 26 Aug 2025 18:45:12 GMT Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48q5xpt6qq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 26 Aug 2025 18:45:12 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-246f49067bdso23372545ad.0 for ; Tue, 26 Aug 2025 11:45:12 -0700 (PDT) Received: from admin15.qualcomm.com (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3276aeef8b8sm220661a91.21.2025.08.26.11.45.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Aug 2025 11:45:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=N/cJ1VigX5T amwRxQg27K5ECt0YK3rjIAflQIFqgDpE=; b=ga0rQ9zhXMkM6gR5QZZ7qtIGbJF 4oKO+nFIJtmYSSni+7GoGxxvR4ygnWhZFpdMaHmaR2XcSEqEEuMgFdydq0bDbNEH 6DHNOAh0xfuW7Jsu0WsIMxuq3c79keqyNdzHJB6T0KjNRG9JsjziaW4/TuLQB7yB ke2lLEMlX9G0IvyOdI4hrq7zGT3vqfjJJgg5bdJnYRQ+raLKDHG45rrAe3bZWHTh nb/UAmjxrfC2s98hv9JpIJs0rLMwFOc0OyRpnP7jgsWt8Sf+guj1NjrODwxoQidR sJSXizqGvQVNf8o0JiQ8XgbLF6eqYTj5uV+hBtNSbr3IS2/R+E/gpuDh7LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756233911; x=1756838711; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=N/cJ1VigX5TamwRxQg27K5ECt0YK3rjIAflQIFqgDpE=; b=c/JtWCE6b9by7XMopE6SpDxHZpkanlt4MpGxYJTt4296h6O7aHmNJ2vvk4i4lJx1SM JUWF1k/945C0F5Gqzsj/47CVgvsmgjfuCSMuPNg1eqAqRS4gS92sbg+lve0JGl4K2xfx dTFtNmqyPuydXD+ieEL9TAkfqa76Hp1F3jaFtLvuZfH60pbxKk79x5Hc0TBFEN2RBVq/ bm3TjOGavrnUMIEsQTxh6rF7ObzGkmS0CqQUHnmwSGNHiTxuysl1W19+vC4GLiRmObzC ClcXTJWGk51hZoCUjoxg/EF4/AHSehvMHcs3KtIPzC17nx4DP8atANo0v0PYdQoAw+Oi DEYg== X-Gm-Message-State: AOJu0YzivwWzWZLEqOKYCyupunaDfKSaWOzxQSVF9FA2Jtv1HVos8Y6x qJSpjAzvUINAa4N6cm2rw7Dx9wohMjGNkJe8uRLtkVovfPscP7nzib0DNJ7AWzDiTg2QfJf2C4w J3efPoZjt9sv29zs2RTCKieYuhfpTCjirw/PefXNeQXv7x3fsSuu5RlRKCGpVgxTAbFV9 X-Gm-Gg: ASbGncuy7PZcrMyOZV7EMtZPgsaMGN9s/Fcl/LAgcbH64BO/DHDnKcZzaNIVKTsDIcc frSY3RRlYD0FwRmvGuYx9O4gqw39VI9eASlBMjqGqg7ldizrNPLl9gF3TmA9bKXol5xXdbP56n0 zgi2FUdppFHlkGqsz18JjvrHYzzYxE1CGPLmgxvixmuWi5fSFiMAZvqRg/kL9LUnNhbZKjGmKhD uwG5ysm4AFbzPJJ3Lhefj47j7UjgXoY7mXS0U+ppcijtp97TJ8amQsmxhnArRenmXQXZ0jkwoJ1 YMOY1CWKQjSoFgs1QmKGiAqudVjP40aGhh/YDAFlxWQhNb1YXOfLReLmFePblkMNsw8fdfcLSMx PdDorjG//Q/Joysc= X-Received: by 2002:a17:902:e786:b0:246:80b1:8c87 with SMTP id d9443c01a7336-24680b190famr149128375ad.43.1756233911044; Tue, 26 Aug 2025 11:45:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH9HnvJ9dEZOIKH20ityDwao35hmppm9k0kcAS/YV/wZgjhfUi73rgdrU6+DJL1x89N1dULnA== X-Received: by 2002:a17:902:e786:b0:246:80b1:8c87 with SMTP id d9443c01a7336-24680b190famr149127965ad.43.1756233910507; Tue, 26 Aug 2025 11:45:10 -0700 (PDT) From: Vacha Bhavsar To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Peter Maydell , Thomas Huth , Vacha Bhavsar Subject: [PATCH v6 2/3] target/arm: Added support for SME register exposure to GDB Date: Tue, 26 Aug 2025 18:45:03 +0000 Message-Id: <20250826184504.510279-3-vacha.bhavsar@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250826184504.510279-1-vacha.bhavsar@oss.qualcomm.com> References: <20250826184504.510279-1-vacha.bhavsar@oss.qualcomm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=KOlaDEFo c=1 sm=1 tr=0 ts=68ae00b8 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=2OwXVqhp2XgA:10 a=EUspDBNiAAAA:8 a=JRRW1ReKSft4RaJC_60A:9 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-GUID: T_HCbiUH8wKIjC16wDFY0z24qc_V_ri2 X-Proofpoint-ORIG-GUID: T_HCbiUH8wKIjC16wDFY0z24qc_V_ri2 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODIzMDAzMyBTYWx0ZWRfXz54XwALcxT4h Iz4WzepBYkMXaWoyWBTVUzJR6U+Mpb6dUJIkbK813r5hQgSqfeFKNTIq/jaeFPWNzYU7mWqBIYG /HKMvgatKjDwuOIPAeoUB5FAq483osAWwSQIQmuqOxTuB8APDBvmvBC/yCH52fpRomf5BUZzsTv DIIsA0dE/bjixnREMO1l5bYw+Sf01SweFc/eDE5s/3Zzh00+h638NOGsJ0RA8EoJW+FYTy2G/5I gzj3KfQFCYQqSFR6dg0Qlaqz7RZ7/LxICslFqqsYVO3gzSTJS2fQLQaLyVbxBDXS+YF/uJrpthy e9DiYVCyNiPFumif1z3NwixsQ5ZZU6/codCJ+KkfBZxdGUWHq7jgtCFj12Ctmx0klZlpAhnKlX2 E+Z3FnpQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-26_02,2025-08-26_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 bulkscore=0 adultscore=0 phishscore=0 impostorscore=0 spamscore=0 suspectscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508230033 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=vacha.bhavsar@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1756234020208124100 Content-Type: text/plain; charset="utf-8" The QEMU GDB stub does not expose the ZA storage SME register to GDB via the remote serial protocol, which can be a useful functionality to debug SME code. To provide this functionality in Aarch64 target, this patch registers= the SME register set with the GDB stub. To do so, this patch implements the aarch64_gdb_get_sme_reg() and aarch64_gdb_set_sme_reg() functions to specify how to get and set the SME registers, and the arm_gen_dynamic_smereg_feature() function to generate the target description in XML format to indicate the target architecture supports SME. Finally, this patch includes a dyn_smereg_feature structure to hold this GDB XML description of the SME registers for each CPU. Signed-off-by: Vacha Bhavsar --- Changes since v5: - added code to handle the case when we have SME without SVE - added comments to indicate th cases in aarch64_gdb_get/set_sme_reg - added/removed braces where necessary - corrected capitalization in comments --- target/arm/cpu.h | 1 + target/arm/gdbstub.c | 9 ++- target/arm/gdbstub64.c | 121 +++++++++++++++++++++++++++++++++++++++++ target/arm/internals.h | 3 + 4 files changed, 133 insertions(+), 1 deletion(-) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index dc9b6dce4c..8bd66d7049 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -933,6 +933,7 @@ struct ArchCPU { =20 DynamicGDBFeatureInfo dyn_sysreg_feature; DynamicGDBFeatureInfo dyn_svereg_feature; + DynamicGDBFeatureInfo dyn_smereg_feature; DynamicGDBFeatureInfo dyn_m_systemreg_feature; DynamicGDBFeatureInfo dyn_m_secextreg_feature; =20 diff --git a/target/arm/gdbstub.c b/target/arm/gdbstub.c index ce4497ad7c..110258ec18 100644 --- a/target/arm/gdbstub.c +++ b/target/arm/gdbstub.c @@ -527,7 +527,7 @@ void arm_cpu_register_gdb_regs_for_features(ARMCPU *cpu) * registers so we don't need to include both. */ #ifdef TARGET_AARCH64 - if (isar_feature_aa64_sve(&cpu->isar)) { + if (isar_feature_aa64_sve(&cpu->isar) || isar_feature_aa64_sme(&cp= u->isar)) { GDBFeature *feature =3D arm_gen_dynamic_svereg_feature(cs, cs-= >gdb_num_regs); gdb_register_coprocessor(cs, aarch64_gdb_get_sve_reg, aarch64_gdb_set_sve_reg, feature, 0); @@ -537,6 +537,13 @@ void arm_cpu_register_gdb_regs_for_features(ARMCPU *cp= u) gdb_find_static_feature("aarch64-fpu.= xml"), 0); } + + if (isar_feature_aa64_sme(&cpu->isar)) { + GDBFeature *sme_feature =3D arm_gen_dynamic_smereg_feature(cs, + cs->gdb_num_regs); + gdb_register_coprocessor(cs, aarch64_gdb_get_sme_reg, + aarch64_gdb_set_sme_reg, sme_feature, 0); + } /* * Note that we report pauth information via the feature name * org.gnu.gdb.aarch64.pauth_v2, not org.gnu.gdb.aarch64.pauth. diff --git a/target/arm/gdbstub64.c b/target/arm/gdbstub64.c index 08e2858539..d3fd94b93d 100644 --- a/target/arm/gdbstub64.c +++ b/target/arm/gdbstub64.c @@ -249,6 +249,90 @@ int aarch64_gdb_set_sve_reg(CPUState *cs, uint8_t *buf= , int reg) return 0; } =20 +int aarch64_gdb_get_sme_reg(CPUState *cs, GByteArray *buf, int reg) +{ + ARMCPU *cpu =3D ARM_CPU(cs); + CPUARMState *env =3D &cpu->env; + + switch (reg) { + case 0: /* svg register */ + { + int vq =3D 0; + if (FIELD_EX64(env->svcr, SVCR, SM)) { + vq =3D sve_vqm1_for_el_sm(env, arm_current_el(env), + FIELD_EX64(env->svcr, SVCR, SM)) + 1; + } + /* svg =3D vector granules (2 * vector quardwords) in streaming mo= de */ + return gdb_get_reg64(buf, vq * 2); + } + case 1: /* svcr register */ + return gdb_get_reg64(buf, env->svcr); + case 2: /* za register */ + { + int len =3D 0; + int vq =3D cpu->sme_max_vq; + int svl =3D vq * 16; + for (int i =3D 0; i < svl; i++) { + for (int q =3D 0; q < vq; q++) { + len +=3D gdb_get_reg128(buf, + env->za_state.za[i].d[q * 2 + 1], + env->za_state.za[i].d[q * 2]); + } + } + return len; + } + default: + /* gdbstub asked for something out of range */ + qemu_log_mask(LOG_UNIMP, "%s: out of range register %d", __func__,= reg); + break; + } + + return 0; +} + +int aarch64_gdb_set_sme_reg(CPUState *cs, uint8_t *buf, int reg) +{ + ARMCPU *cpu =3D ARM_CPU(cs); + CPUARMState *env =3D &cpu->env; + + switch (reg) { + case 0: /* svg register */ + /* cannot set svg via gdbstub */ + return 8; + case 1: /* svcr register */ + aarch64_set_svcr(env, ldq_le_p(buf), + R_SVCR_SM_MASK | R_SVCR_ZA_MASK); + return 8; + case 2: /* za register */ + { + int len =3D 0; + int vq =3D cpu->sme_max_vq; + int svl =3D vq * 16; + for (int i =3D 0; i < svl; i++) { + for (int q =3D 0; q < vq; q++) { + if (target_big_endian()) { + env->za_state.za[i].d[q * 2 + 1] =3D ldq_p(buf); + buf +=3D 8; + env->za_state.za[i].d[q * 2] =3D ldq_p(buf); + } else{ + env->za_state.za[i].d[q * 2] =3D ldq_p(buf); + buf +=3D 8; + env->za_state.za[i].d[q * 2 + 1] =3D ldq_p(buf); + } + buf +=3D 8; + len +=3D 16; + } + } + return len; + } + default: + /* gdbstub asked for something out of range */ + break; + } + + return 0; +} + int aarch64_gdb_get_pauth_reg(CPUState *cs, GByteArray *buf, int reg) { ARMCPU *cpu =3D ARM_CPU(cs); @@ -413,6 +497,43 @@ GDBFeature *arm_gen_dynamic_svereg_feature(CPUState *c= s, int base_reg) return &cpu->dyn_svereg_feature.desc; } =20 +GDBFeature *arm_gen_dynamic_smereg_feature(CPUState *cs, int base_reg) +{ + ARMCPU *cpu =3D ARM_CPU(cs); + int vq =3D cpu->sme_max_vq; + int svl =3D vq * 16; + GDBFeatureBuilder builder; + int reg =3D 0; + + gdb_feature_builder_init(&builder, &cpu->dyn_smereg_feature.desc, + "org.gnu.gdb.aarch64.sme", "sme-registers.xml", base_reg); + + + /* Create the sme_bv vector type. */ + gdb_feature_builder_append_tag(&builder, + "", + svl); + + /* Create the sme_bvv vector type. */ + gdb_feature_builder_append_tag( + &builder, "", + svl); + + /* Define the svg, svcr, and za registers. */ + + /* fpscr & status registers */ + gdb_feature_builder_append_reg(&builder, "svg", 64, reg++, + "int", NULL); + gdb_feature_builder_append_reg(&builder, "svcr", 64, reg++, + "int", NULL); + gdb_feature_builder_append_reg(&builder, "za", svl * svl * 8, reg++, + "sme_bvv", NULL); + + gdb_feature_builder_end(&builder); + + return &cpu->dyn_smereg_feature.desc; +} + #ifdef CONFIG_USER_ONLY int aarch64_gdb_get_tag_ctl_reg(CPUState *cs, GByteArray *buf, int reg) { diff --git a/target/arm/internals.h b/target/arm/internals.h index 1b3d0244fd..41e05066b9 100644 --- a/target/arm/internals.h +++ b/target/arm/internals.h @@ -1802,8 +1802,11 @@ static inline uint64_t pmu_counter_mask(CPUARMState = *env) } =20 GDBFeature *arm_gen_dynamic_svereg_feature(CPUState *cpu, int base_reg); +GDBFeature *arm_gen_dynamic_smereg_feature(CPUState *cpu, int base_reg); int aarch64_gdb_get_sve_reg(CPUState *cs, GByteArray *buf, int reg); int aarch64_gdb_set_sve_reg(CPUState *cs, uint8_t *buf, int reg); +int aarch64_gdb_get_sme_reg(CPUState *cs, GByteArray *buf, int reg); +int aarch64_gdb_set_sme_reg(CPUState *cs, uint8_t *buf, int reg); int aarch64_gdb_get_fpu_reg(CPUState *cs, GByteArray *buf, int reg); int aarch64_gdb_set_fpu_reg(CPUState *cs, uint8_t *buf, int reg); int aarch64_gdb_get_pauth_reg(CPUState *cs, GByteArray *buf, int reg); --=20 2.34.1 From nobody Wed Dec 17 16:13:35 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1756234049; cv=none; d=zohomail.com; s=zohoarc; b=QtS1e69guEbFDEqakQ1X4ouyn0lCc4/FqcYyx4oShKlcbihAmvoZNdwqlw+v9x24YgJLVhr9sZj0ULrOIChKxUVcXL432FAewllX1PsQHcbCSWlIxG94nBNDVvLoj9xCSvyvQFL1S5aRwHJZgnehKg7+popgsy5ci/cA+dil20c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756234049; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=GZr6fKIuBP+n56Ge2gnAV7k/J3Lgs0gnOtTgNmdTKt4=; b=fLz5PURVSNT3oLWV/0Ks7eMRn0SLvEwWE5ZuhifBU+CUy1GYZP5WxiTLb9OiVARosmgT50Ep2fdhUDOSM2rbQ0SgJYw4niFfVqP3Tfnb03H9f7bTD0BVRgmN3hh9JXPOnb/k/dtXwsc4ZEcMOCp/Conz2h5BGu7BcV/yguj6cug= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756234049709196.2235648447554; Tue, 26 Aug 2025 11:47:29 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uqyfi-0004y4-5B; Tue, 26 Aug 2025 14:45:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uqyfe-0004w7-Kv for qemu-devel@nongnu.org; Tue, 26 Aug 2025 14:45:26 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uqyfW-0008T4-5I for qemu-devel@nongnu.org; Tue, 26 Aug 2025 14:45:25 -0400 Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57QD1vk2028616 for ; Tue, 26 Aug 2025 18:45:14 GMT Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48q5we1v99-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 26 Aug 2025 18:45:14 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-32326e72dfbso8654620a91.3 for ; Tue, 26 Aug 2025 11:45:14 -0700 (PDT) Received: from admin15.qualcomm.com (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3276aeef8b8sm220661a91.21.2025.08.26.11.45.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Aug 2025 11:45:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=GZr6fKIuBP+ n56Ge2gnAV7k/J3Lgs0gnOtTgNmdTKt4=; b=GhKunerxvNicJTn52Mb7Ju8u12X M5B1uJ9ixKLxuoGe5yjWj8M/5uff4zCoBvNvpgOQod93WjZLdVjKeVFVivuBKOSr TQy89oX+uvD1HD3MdzoeOObjFKGSKc3ZZMZ/lFdkOFPDdSeW/Av4NAOkUcqVlJvo 0eQcYgxQGwt4zEuEb0McdLuGr2N9CmEvgL0wUCfSanNf0o3yOiZTfVHJvcPDl/En X7TjiDeb5CPbmC0HgYfMIr1grUNQLcT2fhMI1ar6IDollCRD3rCg9+nnUhG2HxPN zSvkvWTCMGV0ZLgVviCj+mn06BtC5xfdJX7cvA8oA/nDQrqdhkGySah///A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756233913; x=1756838713; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GZr6fKIuBP+n56Ge2gnAV7k/J3Lgs0gnOtTgNmdTKt4=; b=PsBUhDmp9o+nVyfyAqhvyrgkZMwlpgUs6CibnT0dtD7EU3Gy29syifBsLy+wGCZyqp zvyACuqbPSxcA8+TsgqXZ5yH0TZUINyskbWS+nQtRRxB8LoA1PLrIGBxF6aoSSSGKAqV R5BhC39pgoplK7fChVKPK6wInwYAZXWeEg7ERH2g5zHKAFhOLP1GiTdRDKf1dP6Zgydb wFdMkGenaNUv0az//x7K5+qcxMHoKzRsSZZCHxh60nH7BgEQ0RMvO7FMYncfmKDeZ7nH TgVjYLbcsVfe6qahTHX587dBx/006M1R+/UTnVrF+g0WGWNvsGW8zazbs2xpSiqLKPbe Rtxw== X-Gm-Message-State: AOJu0Yz/R5ZS8pakAFHit+TAxL3VlKpTmtPNjh/OIDO0oGk91d7//2h8 IAXFSiLLPQ4xGys8vL9yLyrRTIH7ODrDELdLISip4zKZ70FN5CfMnAvGFyTt7Vt98XCRKek7+dO i7PlMvEdBHsVt7VczMQ9kvfLOhtGFFtBOFtVdag0skDMQ0lIgJ85R6xjdwwa6+ssCkweU X-Gm-Gg: ASbGncvNona96QnfXzcrN+roMYnAFWiR+YTyLhzH64LrmVSUXgkpZAaUrZ+XuE+i3on ONajtw2GME3oL4dd6dasclHISDOfKzQpndltoITKlhYOuPqXP9w/ZkMbr3p46F/3NLL5kyrQ/B6 MTbM6IZdL/x5DbleAvJoND7TIUsX0o52aMpzxnoAqm4K+vGmCYJq6Hn4PD5xoaq7XKPhN+QeOGT khPaOqwjqIr+p2kb2atGY9dv3FeZsjFJ9BZ08jX7AYif9TcHqm4jq/Ka/bHF0weyIYhaoYgJSxx irN91q+04hIvXUUc2bOtyUHS5IetAOoRp7wwe/uOqhOvAKjEzY9th5UDMTntLxzFS8CfqjLGxAW QupNhzdJKyjkZC3I= X-Received: by 2002:a17:90a:d60d:b0:324:e3cc:d224 with SMTP id 98e67ed59e1d1-32515ee54c6mr24462178a91.4.1756233912679; Tue, 26 Aug 2025 11:45:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHw59f7XyhG6WglB2EH1+eozjdh1SVOUOxSaVdHEa4Kj9otQLbtySDs+RdCaqDTriwQqcrgYg== X-Received: by 2002:a17:90a:d60d:b0:324:e3cc:d224 with SMTP id 98e67ed59e1d1-32515ee54c6mr24462136a91.4.1756233912183; Tue, 26 Aug 2025 11:45:12 -0700 (PDT) From: Vacha Bhavsar To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Peter Maydell , Thomas Huth , Vacha Bhavsar Subject: [PATCH v6 3/3] target/arm: Added test case for SME register exposure to GDB Date: Tue, 26 Aug 2025 18:45:04 +0000 Message-Id: <20250826184504.510279-4-vacha.bhavsar@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250826184504.510279-1-vacha.bhavsar@oss.qualcomm.com> References: <20250826184504.510279-1-vacha.bhavsar@oss.qualcomm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: ZrORalPsGNMt0Xhj5evq91Ay7LZxnbsL X-Proofpoint-ORIG-GUID: ZrORalPsGNMt0Xhj5evq91Ay7LZxnbsL X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODIzMDAzMyBTYWx0ZWRfX1tIW7kj3Jnob 0o2RrD9Sb9Zl1Y73+oDN+ED/7s6weQY31gTpOkzfbNOsGQZOE4aEI4Bzhw0M0wOfe5sSP8bR1FY 6GiKG6JL+QrhjddoMjOC2jPs7p5kmblSqo8rWDFJRpOW+KY9sKkHgk4RHIYTAvV6yAnBm/9pEgI 74xIRw8wUvs9wvrSZ5qh3+t+EvfP/+pIL+z4URaUiuhGGowhJNPMHQu84bpq910HihXsPCkO3P+ GAOLkXll749St60+Ta5WOh+U1RBvK3TXBFzwfBxbkOlEkaM8R0lzQBjLvKKtELK/8LNMru6Qd1U D+k58GyPDMO9deCHLrNwvlV4ESEVzj8jiIhL6rhzjTsWgbjUwuKHJR+frpDq9hH/hIx1URIF4/T dEAhw/F5 X-Authority-Analysis: v=2.4 cv=BJazrEQG c=1 sm=1 tr=0 ts=68ae00ba cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=2OwXVqhp2XgA:10 a=EUspDBNiAAAA:8 a=NuJLd7iFDieCY-iTVAkA:9 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-26_02,2025-08-26_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 priorityscore=1501 clxscore=1015 impostorscore=0 bulkscore=0 phishscore=0 suspectscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508230033 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=vacha.bhavsar@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1756234052462116600 Content-Type: text/plain; charset="utf-8" This patch adds a test case to test SME register exposure to a remote gdb debugging session. This test simply sets and reads SME registers. Signed-off-by: Vacha Bhavsar --- Changes since v5: - added copyright and SPDX line - added functionality to avoid casting a gdb.Value object to int when testing the za quadwords to address bug found during review, this change is declared to users via a warning message included in the test results file run-gdbstub-sysregs-sme.out --- configure | 11 ++ tests/tcg/aarch64/Makefile.target | 33 +++++- tests/tcg/aarch64/gdbstub/test-sme.py | 165 ++++++++++++++++++++++++++ 3 files changed, 208 insertions(+), 1 deletion(-) create mode 100644 tests/tcg/aarch64/gdbstub/test-sme.py diff --git a/configure b/configure index 274a778764..9e2ae174dc 100755 --- a/configure +++ b/configure @@ -1839,6 +1839,17 @@ for target in $target_list; do echo "GDB=3D$gdb_bin" >> $config_target_mak fi =20 + if test "${gdb_arches#*$arch}" !=3D "$gdb_arches" && version_ge $gdb= _version 14.1; then + echo "GDB_HAS_SME_TILES=3Dy" >> $config_target_mak + if test "$gdb_version" =3D "15.0.50.20240403-git"; then + echo "GDB_HAS_INT_CAST_SUPPORT=3Dn" >> $config_target_mak + else + echo "GDB_HAS_INT_CAST_SUPPORT=3Dy" >> $config_target_mak + fi + else + echo "GDB_HAS_SME_TILES=3Dn" >> $config_target_mak + fi + if test "${gdb_arches#*aarch64}" !=3D "$gdb_arches" && version_ge $g= db_version 15.1; then echo "GDB_HAS_MTE=3Dy" >> $config_target_mak fi diff --git a/tests/tcg/aarch64/Makefile.target b/tests/tcg/aarch64/Makefile= .target index 16ddcf4f88..f9304d29cf 100644 --- a/tests/tcg/aarch64/Makefile.target +++ b/tests/tcg/aarch64/Makefile.target @@ -132,7 +132,38 @@ run-gdbstub-sve-ioctls: sve-ioctls --bin $< --test $(AARCH64_SRC)/gdbstub/test-sve-ioctl.py, \ basic gdbstub SVE ZLEN support) =20 -EXTRA_RUNS +=3D run-gdbstub-sysregs run-gdbstub-sve-ioctls +ifneq ($(CROSS_AS_HAS_ARMV9_SME),) +# SME gdbstub test +ifeq ($(GDB_HAS_SME_TILES),y) +ifeq ($(GDB_HAS_INT_CAST_SUPPORT),y) +run-gdbstub-sysregs-sme: sysregs + $(call run-test, $@, $(GDB_SCRIPT) \ + --gdb $(GDB) \ + --qemu $(QEMU) --qargs "$(QEMU_OPTS)" \ + --bin $< --test $(AARCH64_SRC)/gdbstub/test-sme.py \ + -- test_sme --gdb_sme_tile_support --gdb_int_cast_support, \ + basic gdbstub SME support) +else +run-gdbstub-sysregs-sme: sysregs + $(call run-test, $@, $(GDB_SCRIPT) \ + --gdb $(GDB) \ + --qemu $(QEMU) --qargs "$(QEMU_OPTS)" \ + --bin $< --test $(AARCH64_SRC)/gdbstub/test-sme.py \ + -- test_sme --gdb_sme_tile_support, \ + basic gdbstub SME support) +endif +else +run-gdbstub-sysregs-sme: sysregs + $(call run-test, $@, $(GDB_SCRIPT) \ + --gdb $(GDB) \ + --qemu $(QEMU) --qargs "$(QEMU_OPTS)" \ + --bin $< --test $(AARCH64_SRC)/gdbstub/test-sme.py, \ + basic gdbstub SME support) + +endif +endif + +EXTRA_RUNS +=3D run-gdbstub-sysregs run-gdbstub-sve-ioctls run-gdbstub-sys= regs-sme =20 ifeq ($(GDB_HAS_MTE),y) run-gdbstub-mte: mte-8 diff --git a/tests/tcg/aarch64/gdbstub/test-sme.py b/tests/tcg/aarch64/gdbs= tub/test-sme.py new file mode 100644 index 0000000000..e27a37631b --- /dev/null +++ b/tests/tcg/aarch64/gdbstub/test-sme.py @@ -0,0 +1,165 @@ +# +# Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. +# +# SPDX-License-Identifier: GPL-2.0-or-later + +from __future__ import print_function +# +# Test the SME registers are visible and changeable via gdbstub +# +# This is launched via tests/guest-debug/run-test.py +# + +import argparse +import gdb +from test_gdbstub import main, report + +MAGIC =3D 0x01020304 +INT_CAST_SUPPORT =3D 0 + +def run_test(): + "Run through the tests one by one" + + frame =3D gdb.selected_frame() + rname =3D "za" + za =3D frame.read_register(rname) + report(True, "Reading %s" % rname) + + for i in range(0, 16): + for j in range(0, 16): + cmd =3D "set $za[%d][%d] =3D 0x01" % (i, j) + gdb.execute(cmd) + report(True, "%s" % cmd) + for i in range(0, 16): + for j in range(0, 16): + reg =3D "$za[%d][%d]" % (i, j) + v =3D gdb.parse_and_eval(reg) + report(str(v.type) =3D=3D "uint8_t", + "size of %s" % (reg)) + report(int(v) =3D=3D 0x1, "%s is 0x%x" % (reg, 0x1)) + +def run_test_slices(): + "Run through the tests one by one" + + frame =3D gdb.selected_frame() + rname =3D "za" + za =3D frame.read_register(rname) + report(True, "Reading %s" % rname) + + for i in range(0, 16): + for j in range(0, 16): + cmd =3D "set $za[%d][%d] =3D 0x01" % (i, j) + gdb.execute(cmd) + report(True, "%s" % cmd) + for i in range(0, 16): + for j in range(0, 16): + reg =3D "$za[%d][%d]" % (i, j) + v =3D gdb.parse_and_eval(reg) + report(str(v.type) =3D=3D "uint8_t", + "size of %s" % (reg)) + report(int(v) =3D=3D 0x1, "%s is 0x%x" % (reg, 0x1)) + + if INT_CAST_SUPPORT: + for i in range(0, 4): + for j in range(0, 4): + for k in range(0, 4): + cmd =3D "set $za%dhq%d[%d] =3D 0x%x" % (i, j, k, MAGIC) + gdb.execute(cmd) + report(True, "%s" % cmd) + for j in range(0, 4): + for k in range(0, 4): + reg =3D "$za%dhq%d[%d]" % (i, j, k) + v =3D gdb.parse_and_eval(reg) + report(str(v.type) =3D=3D "uint128_t", + "size of %s" % (reg)) + report(int(v) =3D=3D MAGIC, "%s is 0x%x" % (reg, MAGIC= )) + =20 + for j in range(0, 4): + for k in range(0, 4): + cmd =3D "set $za%dvq%d[%d] =3D 0x%x" % (i, j, k, MAGIC) + gdb.execute(cmd) + report(True, "%s" % cmd) + for j in range(0, 4): + for k in range(0, 4): + reg =3D "$za%dvq%d[%d]" % (i, j, k) + v =3D gdb.parse_and_eval(reg) + report(str(v.type) =3D=3D "uint128_t", + "size of %s" % (reg)) + report(int(v) =3D=3D MAGIC, "%s is 0x%x" % (reg, MAGIC= )) + + else: + for i in range(0, 4): + for j in range(0, 4): + for k in range(0, 4): + cmd =3D "set $za%dhq%d[%d] =3D 0x%x" % (i, j, k, MAGIC) + gdb.execute(cmd) + report(True, "%s" % cmd) + for j in range(0, 4): + for k in range(0, 4): + reg =3D "$za%dhq%d[%d]" % (i, j, k) + v =3D gdb.parse_and_eval(reg) + report(str(v.type) =3D=3D "uint128_t", + "size of %s" % (reg)) + report(v =3D=3D MAGIC, "%s is 0x%x" % (reg, MAGIC)) + =20 + for j in range(0, 4): + for k in range(0, 4): + cmd =3D "set $za%dvq%d[%d] =3D 0x%x" % (i, j, k, MAGIC) + gdb.execute(cmd) + report(True, "%s" % cmd) + for j in range(0, 4): + for k in range(0, 4): + reg =3D "$za%dvq%d[%d]" % (i, j, k) + v =3D gdb.parse_and_eval(reg) + report(str(v.type) =3D=3D "uint128_t", + "size of %s" % (reg)) + report(v =3D=3D MAGIC, "%s is 0x%x" % (reg, MAGIC)) + + for i in range(0, 4): + for j in range(0, 4): + for k in range(0, 4): + cmd =3D "set $za%dhd%d[%d] =3D 0x%x" % (i, j, k, MAGIC) + gdb.execute(cmd) + report(True, "%s" % cmd) + for j in range(0, 4): + for k in range(0, 4): + reg =3D "$za%dhd%d[%d]" % (i, j, k) + v =3D gdb.parse_and_eval(reg) + report(str(v.type) =3D=3D "uint64_t", + "size of %s" % (reg)) + report(int(v) =3D=3D MAGIC, "%s is 0x%x" % (reg, MAGIC)) + =20 + for j in range(0, 4): + for k in range(0, 4): + cmd =3D "set $za%dvd%d[%d] =3D 0x%x" % (i, j, k, MAGIC) + gdb.execute(cmd) + report(True, "%s" % cmd) + for j in range(0, 4): + for k in range(0, 4): + reg =3D "$za%dvd%d[%d]" % (i, j, k) + v =3D gdb.parse_and_eval(reg) + report(str(v.type) =3D=3D "uint64_t", + "size of %s" % (reg)) + report(int(v) =3D=3D MAGIC, "%s is 0x%x" % (reg, MAGIC)) + + +parser =3D argparse.ArgumentParser(description=3D"A gdbstub test for SME s= upport") +parser.add_argument("--gdb_sme_tile_support", help=3D"GDB support for SME = tiles", \ + action=3D"store_true") +parser.add_argument("--gdb_int_cast_support",=20 + help=3D"GDB support for 128bit int cast", \ + action=3D"store_true") +args =3D parser.parse_args() + +if args.gdb_sme_tile_support: + if args.gdb_int_cast_support: + INT_CAST_SUPPORT =3D 1 + else: + print("WARNING: The version of gdb used (15.0.50.20240403-git)\n" + "does not support casting a gdb.Value object to 128 bit python\n" + "integer. Thus, the testing for the ZA quadwords will be done\n" + "without int casting. Refer to tests/tcg/aarch64/gdbstub/test-sme.= py\n" + "for details.") + main(run_test_slices, expected_arch=3D"aarch64") +else: + main(run_test, expected_arch=3D"aarch64") --=20 2.34.1