From nobody Sun Sep 28 15:28:20 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1756215216; cv=none; d=zohomail.com; s=zohoarc; b=FVTZtPyLVlLDSdKWCs/5ulUoYyP+fZGdS4+1p4BT5S9r4jqruXQfiK34gIjvAMCfOB6fLzlaoRRA985wJ7qRgpe3Dpm60EXvakK6D/fX/2fHv+oT1ZGaI651Mv6nKdoBldlVOdKlVm6GJh0dfcPaG2n6NZcULVJV9NCAjgt9V9E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756215216; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=P6ZAzxZ4kYZdwbPijMw+l3qRLkMiqoJ/gdJ3+rS2Ges=; b=m4TdS3kFTyMJcL5yQ9gHjZlsGBMtg0fcTjH0cc/NUpsaSmSq7shmynG05yjiOvhdgtjC2imGyfAlJgAUTONOw19Vaga9WVth2TQyDnPMV1c57vH/02v94icKq0YhrHZYvQJ/yMo0/UnBAAM6vd4JntfiitMG9kTUl4ZsZqXWfVE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756215216391327.80313906525873; Tue, 26 Aug 2025 06:33:36 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uqtmN-0002yP-C8; Tue, 26 Aug 2025 09:32:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uqtmJ-0002wp-4H for qemu-devel@nongnu.org; Tue, 26 Aug 2025 09:31:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uqtmD-0001j9-FK for qemu-devel@nongnu.org; Tue, 26 Aug 2025 09:31:57 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-682-qDixAtaQNWagAclzFga5XQ-1; Tue, 26 Aug 2025 09:31:43 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3F4791956096; Tue, 26 Aug 2025 13:31:42 +0000 (UTC) Received: from localhost (unknown [10.45.242.16]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id DC37819560AD; Tue, 26 Aug 2025 13:31:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756215106; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P6ZAzxZ4kYZdwbPijMw+l3qRLkMiqoJ/gdJ3+rS2Ges=; b=Kd4EdqeKTaiwx0CYsCGt39TOmyyd7JsFheSKd/9xI6DyybHq8+WhLonvBJaXPJQXy90Gvi LWIAHVCJ6WY5gsBoSUPxn2P5etdkEUCnJ1GuhkZZBRymukjFClSU12iaFBO8zNw4RXiZoe VaZPSuc+OVz1vmvtdDcJR5z2JB4Wcds= X-MC-Unique: qDixAtaQNWagAclzFga5XQ-1 X-Mimecast-MFC-AGG-ID: qDixAtaQNWagAclzFga5XQ_1756215102 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: Manos Pitsidianakis , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , pbonzini@redhat.com, qemu-rust@nongnu.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [PATCH 1/4] rust: run cargo update Date: Tue, 26 Aug 2025 17:31:29 +0400 Message-ID: <20250826133132.4064478-2-marcandre.lureau@redhat.com> In-Reply-To: <20250826133132.4064478-1-marcandre.lureau@redhat.com> References: <20250826133132.4064478-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1756215218261116601 From: Marc-Andr=C3=A9 Lureau Usually, rust projects have CI bots to do that and check that nothing breaks. We should add this to our TODO list. Signed-off-by: Marc-Andr=C3=A9 Lureau --- rust/Cargo.lock | 40 ++++++++++++++++++++-------------------- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/rust/Cargo.lock b/rust/Cargo.lock index b785c718f3..3433cdcf6e 100644 --- a/rust/Cargo.lock +++ b/rust/Cargo.lock @@ -4,15 +4,15 @@ version =3D 3 =20 [[package]] name =3D "anyhow" -version =3D "1.0.98" +version =3D "1.0.99" source =3D "registry+https://github.com/rust-lang/crates.io-index" -checksum =3D "e16d2d3311acee920a9eb8d33b8cbc1787ce4a264e85f964c2404b969bdc= d487" +checksum =3D "b0674a1ddeecb70197781e945de4b3b8ffb61fa939a5597bcf4850373766= 3100" =20 [[package]] name =3D "arbitrary-int" -version =3D "1.2.7" +version =3D "1.3.0" source =3D "registry+https://github.com/rust-lang/crates.io-index" -checksum =3D "c84fc003e338a6f69fbd4f7fe9f92b535ff13e9af8997f3b14b6ddff8b1d= f46d" +checksum =3D "825297538d77367557b912770ca3083f778a196054b3ee63b22673c4a3ca= e0a5" =20 [[package]] name =3D "bilge" @@ -46,15 +46,15 @@ dependencies =3D [ =20 [[package]] name =3D "either" -version =3D "1.12.0" +version =3D "1.15.0" source =3D "registry+https://github.com/rust-lang/crates.io-index" -checksum =3D "3dca9240753cf90908d7e4aac30f630662b02aebaa1b58a3cadabdb23385= b58b" +checksum =3D "48c757948c5ede0e46177b7add2e67155f70e33c07fea8284df6576da70b= 3719" =20 [[package]] name =3D "foreign" -version =3D "0.3.1" +version =3D "0.3.2" source =3D "registry+https://github.com/rust-lang/crates.io-index" -checksum =3D "17ca1b5be8c9d320daf386f1809c7acc0cb09accbae795c2001953fa5058= 5846" +checksum =3D "bec05eb9c07a3f66653535e5e50eb5eb935eb00d3bb7e06ea26a9d3a1d01= 6182" dependencies =3D [ "libc", ] @@ -78,9 +78,9 @@ dependencies =3D [ =20 [[package]] name =3D "libc" -version =3D "0.2.162" +version =3D "0.2.175" source =3D "registry+https://github.com/rust-lang/crates.io-index" -checksum =3D "18d287de67fe55fd7e1581fe933d965a5a9477b38e949cfa9f8574ef0150= 6398" +checksum =3D "6a82ae493e598baaea5209805c49bbf2ea7de956d50d7da0da1164f9c6d2= 8543" =20 [[package]] name =3D "pl011" @@ -118,9 +118,9 @@ dependencies =3D [ =20 [[package]] name =3D "proc-macro2" -version =3D "1.0.84" +version =3D "1.0.101" source =3D "registry+https://github.com/rust-lang/crates.io-index" -checksum =3D "ec96c6a92621310b51366f1e28d05ef11489516e93be030060e5fc12024a= 49d6" +checksum =3D "89ae43fd86e4158d6db51ad8e2b80f313af9cc74f5c0e03ccb87de099987= 32de" dependencies =3D [ "unicode-ident", ] @@ -146,18 +146,18 @@ dependencies =3D [ =20 [[package]] name =3D "quote" -version =3D "1.0.36" +version =3D "1.0.40" source =3D "registry+https://github.com/rust-lang/crates.io-index" -checksum =3D "0fa76aaf39101c457836aec0ce2316dbdc3ab723cdda1c6bd4e6ad4208ac= aca7" +checksum =3D "1885c039570dc00dcb4ff087a89e185fd56bae234ddc7f056a945bf36467= 248d" dependencies =3D [ "proc-macro2", ] =20 [[package]] name =3D "syn" -version =3D "2.0.66" +version =3D "2.0.106" source =3D "registry+https://github.com/rust-lang/crates.io-index" -checksum =3D "c42f3f41a2de00b01c0aaad383c5a45241efc8b2d1eda5661812fda5f3cd= cff5" +checksum =3D "ede7c438028d4436d71104916910f5bb611972c5cfd7f89b8300a8186e6f= ada6" dependencies =3D [ "proc-macro2", "quote", @@ -166,12 +166,12 @@ dependencies =3D [ =20 [[package]] name =3D "unicode-ident" -version =3D "1.0.12" +version =3D "1.0.18" source =3D "registry+https://github.com/rust-lang/crates.io-index" -checksum =3D "3354b9ac3fae1ff6755cb6db53683adb661634f67557942dea4facebec0f= ee4b" +checksum =3D "5a5f39404a5da50712a4c1eecf25e90dd62b613502b7e925fd4e4d19b5c9= 6512" =20 [[package]] name =3D "version_check" -version =3D "0.9.4" +version =3D "0.9.5" source =3D "registry+https://github.com/rust-lang/crates.io-index" -checksum =3D "49874b5167b65d7193b8aba1567f5c7d93d001cafc34600cee003eda787e= 483f" +checksum =3D "0b928f33d975fc6ad9f86c8f283853ad26bdd5b10b7f1542aa2fa15e2289= 105a" --=20 2.50.1 From nobody Sun Sep 28 15:28:20 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1756215231; cv=none; d=zohomail.com; s=zohoarc; b=aed7bHamBq0a6LPFb+DcxpOXL7Az4g8G+rsFzb5DSc+UssSSO6HXCqOeXqyXIJxlbIme0CQNp8z7pbcL7LqzZZErKLk+eeEQxONxFqRMHp8KkSENLLkNzeJHyvie+SL18kMLNTp+e0v4VqTftIu1xq9F99gi9x2ui+bYeNnRE9Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756215231; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Gpr5BEiJG98iqlxJYetB1UMIinIuIwew365BsOdINxM=; b=jBoQvWZ+hx9Kx9q2j3d2+Gd123d2DmPqccnbvfvKfXWxhNTJ6ukyqa5yOYavvYmItlBUjpJBuST891i1STE2xkRpl7IptjbTALgHas5IH5vI4SQsDLI29CRE7gunpFwKd3spB4o0w4RoWavUIA8fb1X/dMjAHdOLZyK1q9OzNwI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756215231752841.1867349699193; Tue, 26 Aug 2025 06:33:51 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uqtmb-00035h-QG; Tue, 26 Aug 2025 09:32:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uqtmQ-00030U-53 for qemu-devel@nongnu.org; Tue, 26 Aug 2025 09:32:08 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uqtmJ-0001je-Q7 for qemu-devel@nongnu.org; Tue, 26 Aug 2025 09:32:05 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-625-f5gw5KF_Ma63ga4nOJsmLg-1; Tue, 26 Aug 2025 09:31:48 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9AA3218002AE; Tue, 26 Aug 2025 13:31:47 +0000 (UTC) Received: from localhost (unknown [10.45.242.16]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4BC0E1800446; Tue, 26 Aug 2025 13:31:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756215110; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Gpr5BEiJG98iqlxJYetB1UMIinIuIwew365BsOdINxM=; b=bQuhYvDa8Oo/V4Le93znpJr2UJwget3dVlmTYf9JP4s0X5CkIwjx+dTp0FHUls24o8yfuh QqUnNXHQpNfkWRRi8iW07dtFi1+Q2Z7I/w+GpY4IiuYggVTtUb1qGhFNDRLwE8JREH5jmo C4eB00LCjsTOxDeYosoXdNj6kqZ94VA= X-MC-Unique: f5gw5KF_Ma63ga4nOJsmLg-1 X-Mimecast-MFC-AGG-ID: f5gw5KF_Ma63ga4nOJsmLg_1756215107 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: Manos Pitsidianakis , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , pbonzini@redhat.com, qemu-rust@nongnu.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [PATCH 2/4] rust: remove unused global qemu "allocator" Date: Tue, 26 Aug 2025 17:31:30 +0400 Message-ID: <20250826133132.4064478-3-marcandre.lureau@redhat.com> In-Reply-To: <20250826133132.4064478-1-marcandre.lureau@redhat.com> References: <20250826133132.4064478-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1756215235521124100 From: Marc-Andr=C3=A9 Lureau The global allocator has always been disabled. There is no clear reason Rust and C should use the same allocator. Allocations made from Rust must be freed by Rust, and same for C, otherwise we head into troubles. Signed-off-by: Marc-Andr=C3=A9 Lureau --- meson.build | 4 -- rust/Cargo.toml | 2 +- rust/qemu-api/Cargo.toml | 1 - rust/qemu-api/meson.build | 1 - rust/qemu-api/src/lib.rs | 135 -------------------------------------- 5 files changed, 1 insertion(+), 142 deletions(-) diff --git a/meson.build b/meson.build index 50c774a195..ebbe9f8785 100644 --- a/meson.build +++ b/meson.build @@ -1090,9 +1090,6 @@ glib =3D declare_dependency(dependencies: [glib_pc, g= module], # TODO: remove this check and the corresponding workaround (qtree) when # the minimum supported glib is >=3D 2.75.3 glib_has_gslice =3D glib.version().version_compare('<2.75.3') -# Check whether glib has the aligned_alloc family of functions. -# -glib_has_aligned_alloc =3D glib.version().version_compare('>=3D2.72.0') =20 # override glib dep to include the above refinements meson.override_dependency('glib-2.0', glib) @@ -2706,7 +2703,6 @@ config_host_data.set('CONFIG_GETLOADAVG', cc.has_func= tion('getloadavg')) config_host_data.set('HAVE_COPY_FILE_RANGE', cc.has_function('copy_file_ra= nge')) config_host_data.set('HAVE_GETIFADDRS', cc.has_function('getifaddrs')) config_host_data.set('HAVE_GLIB_WITH_SLICE_ALLOCATOR', glib_has_gslice) -config_host_data.set('HAVE_GLIB_WITH_ALIGNED_ALLOC', glib_has_aligned_allo= c) config_host_data.set('HAVE_OPENPTY', cc.has_function('openpty', dependenci= es: util)) config_host_data.set('HAVE_STRCHRNUL', cc.has_function('strchrnul', prefix= : osdep_prefix)) config_host_data.set('HAVE_SYSTEM_FUNCTION', cc.has_function('system', pre= fix: '#include ')) diff --git a/rust/Cargo.toml b/rust/Cargo.toml index 0868e1b426..1a24859cd7 100644 --- a/rust/Cargo.toml +++ b/rust/Cargo.toml @@ -17,7 +17,7 @@ rust-version =3D "1.77.0" =20 [workspace.lints.rust] unexpected_cfgs =3D { level =3D "deny", check-cfg =3D [ - 'cfg(MESON)', 'cfg(HAVE_GLIB_WITH_ALIGNED_ALLOC)', + 'cfg(MESON)', ] } =20 # Occasionally, we may need to silence warnings and clippy lints that diff --git a/rust/qemu-api/Cargo.toml b/rust/qemu-api/Cargo.toml index db7000dee4..603327945f 100644 --- a/rust/qemu-api/Cargo.toml +++ b/rust/qemu-api/Cargo.toml @@ -21,7 +21,6 @@ foreign =3D "~0.3.1" =20 [features] default =3D ["debug_cell"] -allocator =3D [] debug_cell =3D [] =20 [lints] diff --git a/rust/qemu-api/meson.build b/rust/qemu-api/meson.build index a090297c45..062009f161 100644 --- a/rust/qemu-api/meson.build +++ b/rust/qemu-api/meson.build @@ -2,7 +2,6 @@ _qemu_api_cfg =3D run_command(rustc_args, '--config-headers', config_host_h, '--features', files('Cargo.toml'), capture: true, check: true).stdout().strip().splitlines() =20 -# _qemu_api_cfg +=3D ['--cfg', 'feature=3D"allocator"'] if get_option('debug_mutex') _qemu_api_cfg +=3D ['--cfg', 'feature=3D"debug_cell"'] endif diff --git a/rust/qemu-api/src/lib.rs b/rust/qemu-api/src/lib.rs index 86dcd8ef17..0f9231f398 100644 --- a/rust/qemu-api/src/lib.rs +++ b/rust/qemu-api/src/lib.rs @@ -32,139 +32,4 @@ pub mod vmstate; pub mod zeroable; =20 -use std::{ - alloc::{GlobalAlloc, Layout}, - ffi::c_void, -}; - pub use error::{Error, Result}; - -#[cfg(HAVE_GLIB_WITH_ALIGNED_ALLOC)] -extern "C" { - fn g_aligned_alloc0( - n_blocks: bindings::gsize, - n_block_bytes: bindings::gsize, - alignment: bindings::gsize, - ) -> bindings::gpointer; - fn g_aligned_free(mem: bindings::gpointer); -} - -#[cfg(not(HAVE_GLIB_WITH_ALIGNED_ALLOC))] -extern "C" { - fn qemu_memalign(alignment: usize, size: usize) -> *mut c_void; - fn qemu_vfree(ptr: *mut c_void); -} - -extern "C" { - fn g_malloc0(n_bytes: bindings::gsize) -> bindings::gpointer; - fn g_free(mem: bindings::gpointer); -} - -/// An allocator that uses the same allocator as QEMU in C. -/// -/// It is enabled by default with the `allocator` feature. -/// -/// To set it up manually as a global allocator in your crate: -/// -/// ```ignore -/// use qemu_api::QemuAllocator; -/// -/// #[global_allocator] -/// static GLOBAL: QemuAllocator =3D QemuAllocator::new(); -/// ``` -#[derive(Clone, Copy, Debug)] -#[repr(C)] -pub struct QemuAllocator { - _unused: [u8; 0], -} - -#[cfg_attr(all(feature =3D "allocator", not(test)), global_allocator)] -pub static GLOBAL: QemuAllocator =3D QemuAllocator::new(); - -impl QemuAllocator { - // From the glibc documentation, on GNU systems, malloc guarantees 16-= byte - // alignment on 64-bit systems and 8-byte alignment on 32-bit systems.= See - // https://www.gnu.org/software/libc/manual/html_node/Malloc-Examples.= html. - // This alignment guarantee also applies to Windows and Android. On Da= rwin - // and OpenBSD, the alignment is 16 bytes on both 64-bit and 32-bit sy= stems. - #[cfg(all( - target_pointer_width =3D "32", - not(any(target_os =3D "macos", target_os =3D "openbsd")) - ))] - pub const DEFAULT_ALIGNMENT_BYTES: Option =3D Some(8); - #[cfg(all( - target_pointer_width =3D "64", - not(any(target_os =3D "macos", target_os =3D "openbsd")) - ))] - pub const DEFAULT_ALIGNMENT_BYTES: Option =3D Some(16); - #[cfg(all( - any(target_pointer_width =3D "32", target_pointer_width =3D "64"), - any(target_os =3D "macos", target_os =3D "openbsd") - ))] - pub const DEFAULT_ALIGNMENT_BYTES: Option =3D Some(16); - #[cfg(not(any(target_pointer_width =3D "32", target_pointer_width =3D = "64")))] - pub const DEFAULT_ALIGNMENT_BYTES: Option =3D None; - - pub const fn new() -> Self { - Self { _unused: [] } - } -} - -impl Default for QemuAllocator { - fn default() -> Self { - Self::new() - } -} - -// Sanity check. -const _: [(); 8] =3D [(); ::core::mem::size_of::<*mut c_void>()]; - -unsafe impl GlobalAlloc for QemuAllocator { - unsafe fn alloc(&self, layout: Layout) -> *mut u8 { - if matches!(Self::DEFAULT_ALIGNMENT_BYTES, Some(default) if defaul= t.checked_rem(layout.align()) =3D=3D Some(0)) - { - // SAFETY: g_malloc0() is safe to call. - unsafe { g_malloc0(layout.size().try_into().unwrap()).cast::() } - } else { - #[cfg(HAVE_GLIB_WITH_ALIGNED_ALLOC)] - { - // SAFETY: g_aligned_alloc0() is safe to call. - unsafe { - g_aligned_alloc0( - layout.size().try_into().unwrap(), - 1, - layout.align().try_into().unwrap(), - ) - .cast::() - } - } - #[cfg(not(HAVE_GLIB_WITH_ALIGNED_ALLOC))] - { - // SAFETY: qemu_memalign() is safe to call. - unsafe { qemu_memalign(layout.align(), layout.size()).cast= ::() } - } - } - } - - unsafe fn dealloc(&self, ptr: *mut u8, layout: Layout) { - if matches!(Self::DEFAULT_ALIGNMENT_BYTES, Some(default) if defaul= t.checked_rem(layout.align()) =3D=3D Some(0)) - { - // SAFETY: `ptr` must have been allocated by Self::alloc thus = a valid - // glib-allocated pointer, so `g_free`ing is safe. - unsafe { g_free(ptr.cast::<_>()) } - } else { - #[cfg(HAVE_GLIB_WITH_ALIGNED_ALLOC)] - { - // SAFETY: `ptr` must have been allocated by Self::alloc t= hus a valid aligned - // glib-allocated pointer, so `g_aligned_free`ing is safe. - unsafe { g_aligned_free(ptr.cast::<_>()) } - } - #[cfg(not(HAVE_GLIB_WITH_ALIGNED_ALLOC))] - { - // SAFETY: `ptr` must have been allocated by Self::alloc t= hus a valid aligned - // glib-allocated pointer, so `qemu_vfree`ing is safe. - unsafe { qemu_vfree(ptr.cast::<_>()) } - } - } - } -} --=20 2.50.1 From nobody Sun Sep 28 15:28:20 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1756215216; cv=none; d=zohomail.com; s=zohoarc; b=T4K3SR62Q5ipLFv8Wb2c6MFnt6ZJb/mnW+vKJNUby2IuqGOQ0Q9CLj/mMj/tHR/i9ScUGqomckRvVaov7tcsPS+XZ4aDmpLCnySd7X1O9RT/C0oxd06doVl14k7MiW3tu9K8JofgSi2TRKcAiw8yw5vJHDhDEzWS5MyIdZBT11w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756215216; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=DkPZsGp6ZeVYVc5x6Vipyv12yXqNlG0hQZLJpmHsBmQ=; b=kiKGl/voB8x5WPjBl87QcFn2fEQfTmz1EzPVVtnA3JAz7k5BWPWS5HoO2KYhUALBAeFGxJMAnC3slzXdUVyI6hNtpDRdX9pNvSJhCN8LGzoyojcHmTRHCdFZoLTUEaooiGYtAWgufUVJpiMeKJJidsLpQeQavCTEuYJCakbaBK8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756215216937135.24158436151413; Tue, 26 Aug 2025 06:33:36 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uqtmZ-00033k-Ce; Tue, 26 Aug 2025 09:32:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uqtmV-00033B-PB for qemu-devel@nongnu.org; Tue, 26 Aug 2025 09:32:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uqtmM-0001kd-UX for qemu-devel@nongnu.org; Tue, 26 Aug 2025 09:32:10 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-134-UQ5tiD64My2THa0PPvLGxg-1; Tue, 26 Aug 2025 09:31:54 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 037001955F06; Tue, 26 Aug 2025 13:31:53 +0000 (UTC) Received: from localhost (unknown [10.45.242.16]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D20D91977686; Tue, 26 Aug 2025 13:31:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756215117; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DkPZsGp6ZeVYVc5x6Vipyv12yXqNlG0hQZLJpmHsBmQ=; b=PNTymDzYmxDEF2+gyKBxcCH8eiNceR0bj0ORn/V340Q7SRItAkIXFYV4575BODPjZQvFd/ lumHa/CcL3dAuPCd4bEIExHoyRGZvQ14jxIt80txBKvqzXokvQrSqezx4v9EAva6ZSvGEY 6b//pI/1rDQNFRmjWxC4C2oMx9TuRXg= X-MC-Unique: UQ5tiD64My2THa0PPvLGxg-1 X-Mimecast-MFC-AGG-ID: UQ5tiD64My2THa0PPvLGxg_1756215113 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: Manos Pitsidianakis , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , pbonzini@redhat.com, qemu-rust@nongnu.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [PATCH 3/4] build-sys/rust: update syn to v2.0.106 Date: Tue, 26 Aug 2025 17:31:31 +0400 Message-ID: <20250826133132.4064478-4-marcandre.lureau@redhat.com> In-Reply-To: <20250826133132.4064478-1-marcandre.lureau@redhat.com> References: <20250826133132.4064478-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1756215218156116600 From: Marc-Andr=C3=A9 Lureau Necessary for the following patch. Signed-off-by: Marc-Andr=C3=A9 Lureau --- subprojects/.gitignore | 2 +- subprojects/syn-2-rs.wrap | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/subprojects/.gitignore b/subprojects/.gitignore index f4281934ce..0073d61003 100644 --- a/subprojects/.gitignore +++ b/subprojects/.gitignore @@ -18,5 +18,5 @@ /proc-macro-error-attr-1.0.4 /proc-macro2-1.0.84 /quote-1.0.36 -/syn-2.0.66 +/syn-2.0.106 /unicode-ident-1.0.12 diff --git a/subprojects/syn-2-rs.wrap b/subprojects/syn-2-rs.wrap index d79cf750fb..560942befc 100644 --- a/subprojects/syn-2-rs.wrap +++ b/subprojects/syn-2-rs.wrap @@ -1,8 +1,8 @@ [wrap-file] -directory =3D syn-2.0.66 -source_url =3D https://crates.io/api/v1/crates/syn/2.0.66/download -source_filename =3D syn-2.0.66.0.tar.gz -source_hash =3D c42f3f41a2de00b01c0aaad383c5a45241efc8b2d1eda5661812fda5f3= cdcff5 +directory =3D syn-2.0.106 +source_url =3D https://crates.io/api/v1/crates/syn/2.0.106/download +source_filename =3D syn-2.0.106.0.tar.gz +source_hash =3D ede7c438028d4436d71104916910f5bb611972c5cfd7f89b8300a8186e= 6fada6 #method =3D cargo patch_directory =3D syn-2-rs =20 --=20 2.50.1 From nobody Sun Sep 28 15:28:20 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1756215218; cv=none; d=zohomail.com; s=zohoarc; b=Cf5Jev1JcMbsAhuTj3/iPKjfpyw0YqnxrHHAAGXUiY0oiMbU2bPCIeghkG8EW8nbISgj/nef1GDWpcsJkqDZS8WEOBCoRfQlNrq5lBwBTxUlGNrvryGvYoHnkh+PPeSn4ZudaBE40e/NbGe1BbOSr7ZM+CGk5fEDIGb4phk5pxc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756215218; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=RR4g8tZJYaGJJKv2wytLuzgUMVl5cxS9qnE1E7u/Aok=; b=NRu6fCHlUlwhU8i0u17ndTbEO787ZrzGDG+qJIIg+0//C+oF+YmrCvFupfeE1u+f9/RoQomEyvXyeyofdPgdLkhv04dtzLQo2wpmCKcoejgTr3dtAibjvgOS6yvBqe/EDjSR6+yrEpRbaMJCwLNeRpFqyoV/jnuOG1yHJEo3Y9g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756215218849966.8280488800341; Tue, 26 Aug 2025 06:33:38 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uqtmn-00037D-8d; Tue, 26 Aug 2025 09:32:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uqtma-00035A-J3 for qemu-devel@nongnu.org; Tue, 26 Aug 2025 09:32:16 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uqtmQ-0001lm-BF for qemu-devel@nongnu.org; Tue, 26 Aug 2025 09:32:16 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-35-XlJcgt1KMw-iKnXx8pL7Xg-1; Tue, 26 Aug 2025 09:32:00 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E7640180029F; Tue, 26 Aug 2025 13:31:58 +0000 (UTC) Received: from localhost (unknown [10.45.242.16]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9205E180029A; Tue, 26 Aug 2025 13:31:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756215124; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RR4g8tZJYaGJJKv2wytLuzgUMVl5cxS9qnE1E7u/Aok=; b=A7PZJDI/AEacaalwKGT0Cg2VNd4pHy4eiNZCotFgXUvJyfuPmpqK31qhs5LowRAxVZK8RD WkMCt1NFbse87/vTxWnQmSz7cZUiEeNfpkFEIHTTAHPT0N9txfUrqfL90/+K8Wm+rVgeP/ /H6AL59wzo89sjxBFtuEzy3vOb7Pomk= X-MC-Unique: XlJcgt1KMw-iKnXx8pL7Xg-1 X-Mimecast-MFC-AGG-ID: XlJcgt1KMw-iKnXx8pL7Xg_1756215119 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: Manos Pitsidianakis , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , pbonzini@redhat.com, qemu-rust@nongnu.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [PATCH 4/4] rust/qemu-api-macros: make derive(Object) friendly when missing parent Date: Tue, 26 Aug 2025 17:31:32 +0400 Message-ID: <20250826133132.4064478-5-marcandre.lureau@redhat.com> In-Reply-To: <20250826133132.4064478-1-marcandre.lureau@redhat.com> References: <20250826133132.4064478-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_PASS=-0.001, T_SPF_HELO_TEMPERROR=0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1756215221258124101 From: Marc-Andr=C3=A9 Lureau Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Zhao Liu --- rust/qemu-api-macros/src/lib.rs | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/rust/qemu-api-macros/src/lib.rs b/rust/qemu-api-macros/src/lib= .rs index b525d89c09..a614741889 100644 --- a/rust/qemu-api-macros/src/lib.rs +++ b/rust/qemu-api-macros/src/lib.rs @@ -85,7 +85,15 @@ fn derive_object_or_error(input: DeriveInput) -> Result<= proc_macro2::TokenStream is_c_repr(&input, "#[derive(Object)]")?; =20 let name =3D &input.ident; - let parent =3D &get_fields(&input, "#[derive(Object)]")?[0].ident; + let parent =3D &get_fields(&input, "#[derive(Object)]")? + .get(0) + .ok_or_else(|| { + Error::new( + input.ident.span(), + "#[derive(Object)] requires a parent field", + ) + })? + .ident; =20 Ok(quote! { ::qemu_api::assert_field_type!(#name, #parent, --=20 2.50.1