From nobody Sat Nov 15 03:05:04 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1756132400; cv=none; d=zohomail.com; s=zohoarc; b=izLgjOIh1GKrWpRHH/9MpzuMEq3W9Z/Y8eKQSg00WA02ztdBt2xleTAwmCCSsWVuY5ccq0rGmMbJgXQHwdRUraOfmaa7U1Q7x8nXgKU2a4yVOCTDNJ0j8Olbc2bMynZedtdQ3fDSdZ03rTTtg0KpeousGXx7a3V1ETABYYbLz2w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756132400; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=zjc1ieJeYMHPFoFkYve/rIbERvx3QuOeuutbH4Q0Goo=; b=LBaQwcWmTcHH6MjHUaYFM4Q6kIxbpM64O2bID2+EWDGqWxtZ9woSpThp/DVpORuQA+shlN0+CpusHBudJFJ1XHwpgAgYTudhH9rrNxs1s8MvsH/WcEY8fylFjYP6S4+bDb/5ibTdoFcmBBq6TeiwDhLaxbAzHerZtycIAuNPPPQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756132400556630.7797469282664; Mon, 25 Aug 2025 07:33:20 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uqYF4-0003GI-To; Mon, 25 Aug 2025 10:32:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uqYF3-0003FN-7f for qemu-devel@nongnu.org; Mon, 25 Aug 2025 10:32:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uqYEx-0001e0-VA for qemu-devel@nongnu.org; Mon, 25 Aug 2025 10:32:12 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-21-aTKqwkC_OSqkrk6bgoLFlA-1; Mon, 25 Aug 2025 10:32:01 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 32D2918002CE; Mon, 25 Aug 2025 14:32:00 +0000 (UTC) Received: from srv1.redhat.com (unknown [10.45.224.207]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A29DE195419F; Mon, 25 Aug 2025 14:31:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756132322; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=zjc1ieJeYMHPFoFkYve/rIbERvx3QuOeuutbH4Q0Goo=; b=IFOX3hUhYS3V2hT+5Y4sLxCqzDAuijp6O6HxC9HIPqX6icv/iqyn3Q7O30PKzRtWpREYtw GwBozt2f0PhJAvN4pHU90jc0NRFBQfF1RdvnHwMjkQShwXJImvMHLH+ElwE4TOE2qMfORc kxsc48QQ/GQuUg0TTonbD2XoQiIby58= X-MC-Unique: aTKqwkC_OSqkrk6bgoLFlA-1 X-Mimecast-MFC-AGG-ID: aTKqwkC_OSqkrk6bgoLFlA_1756132320 From: Kostiantyn Kostiuk To: qemu-devel@nongnu.org Cc: Kostiantyn Kostiuk , Michael Roth , Yan Vugenfirer Subject: [PATCH] qga/installer: Remove QGA VSS if QGA installation failed Date: Mon, 25 Aug 2025 17:31:55 +0300 Message-ID: <20250825143155.160913-1-kkostiuk@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=kkostiuk@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1756132402673124100 Content-Type: text/plain; charset="utf-8" When QGA Installer failed to install QGA service but install QGA VSS provider, provider should be removed before installer exits. Otherwise QGA VSS will has broken infomation and prevent QGA installation in next run. Signed-off-by: Kostiantyn Kostiuk Reviewed-by: Yan Vugenfirer --- qga/installer/qemu-ga.wxs | 23 +++++++++++++++++++++-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs index df572adb4a..32b8308728 100644 --- a/qga/installer/qemu-ga.wxs +++ b/qga/installer/qemu-ga.wxs @@ -151,6 +151,14 @@ Return=3D"check" > + + =20 @@ -174,8 +182,19 @@ =20 - Installed - NOT REMOVE<= /Custom> + + + + + + + NOT RE= MOVE + + + NOT REMOVE + + + Installed --=20 2.50.1