From nobody Sat Nov 15 05:18:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.ru ARC-Seal: i=1; a=rsa-sha256; t=1755965301; cv=none; d=zohomail.com; s=zohoarc; b=eV4iX4v8ugorUOR2l0BxtWSj/j4/WBwH9jAWHoUOcqfaTiG65SYYA0yZBoWY0WIt3FTtTnKo98kJ/HWK0A2uOvg6hhv8Yr1Z58leitsiUcWetkCTY3cRJQRSwxZVxfGEMmq5wSwEyO7njTNqLdEzDm6aZPCv+9H6/say3ZZjekA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1755965301; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Nvib2fMtqDGabRyCVUGnIIQ+vzpiececeackpu4+gjk=; b=Z7MicQ+oX+GmseJFNC9rL7aTfppFCZDUeRlUijlJ99zKxpW57DquYH9sAlmXbGGYIwQ1NSZq6xMtjDKOl07qH1Kd6l/F/7ydY/XJQUULr4YYOjqBVM+X7N2CqDUGZlrml5ZemDpT3MaLTA2BVJH4/04TYlwOykRP3ByIf+Qr2FQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1755965301700359.86036936796665; Sat, 23 Aug 2025 09:08:21 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1upqil-0005QJ-CL; Sat, 23 Aug 2025 12:03:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upqiR-0005L6-AQ for qemu-devel@nongnu.org; Sat, 23 Aug 2025 12:03:42 -0400 Received: from forwardcorp1b.mail.yandex.net ([2a02:6b8:c02:900:1:45:d181:df01]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upqiP-0000Ik-9j for qemu-devel@nongnu.org; Sat, 23 Aug 2025 12:03:39 -0400 Received: from mail-nwsmtp-smtp-corp-canary-81.sas.yp-c.yandex.net (mail-nwsmtp-smtp-corp-canary-81.sas.yp-c.yandex.net [IPv6:2a02:6b8:c23:36c1:0:640:5f85:0]) by forwardcorp1b.mail.yandex.net (Yandex) with ESMTPS id 7F50F80776; Sat, 23 Aug 2025 19:03:32 +0300 (MSK) Received: from vsementsov-lin.. (unknown [2a02:6bf:8080:c91::1:b]) by mail-nwsmtp-smtp-corp-canary-81.sas.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id Q3YUrj0Gl8c0-z0jzwlq3; Sat, 23 Aug 2025 19:03:32 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1755965012; bh=Nvib2fMtqDGabRyCVUGnIIQ+vzpiececeackpu4+gjk=; h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From; b=dT34IYi27lR+kA5QnTxwAQo792mC39rs2qhsPJR4XmWqCxHLl4MPbhWPhmzDrBuJ+ 0NM7mwmE97oDl6VTNeUBZBVdgmxVz1J+hFXOHIRKYtLUmO+DRYpwOeXwZMLz+k/O1f qvMVWfQ7cTqEVSgMU2pF/JyNz0yNVkAZ40XaOAtw= Authentication-Results: mail-nwsmtp-smtp-corp-canary-81.sas.yp-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Vladimir Sementsov-Ogievskiy To: jasowang@redhat.com Cc: qemu-devel@nongnu.org, vsementsov@yandex-team.ru, leiyang@redhat.com, steven.sistare@oracle.com Subject: [PATCH v2 10/20] net/tap: drop extra tap_fd_get_ifname() call Date: Sat, 23 Aug 2025 19:03:13 +0300 Message-ID: <20250823160323.20811-11-vsementsov@yandex-team.ru> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250823160323.20811-1-vsementsov@yandex-team.ru> References: <20250823160323.20811-1-vsementsov@yandex-team.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a02:6b8:c02:900:1:45:d181:df01; envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1b.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.ru) X-ZM-MESSAGEID: 1755965302926124100 Content-Type: text/plain; charset="utf-8" tap_open() cares to update ifname, no reason to call extra ioctl. Signed-off-by: Vladimir Sementsov-Ogievskiy --- net/tap.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/net/tap.c b/net/tap.c index ac8d955050..eab0a86173 100644 --- a/net/tap.c +++ b/net/tap.c @@ -946,14 +946,6 @@ int net_init_tap(const Netdev *netdev, const char *nam= e, return -1; } =20 - if (queues > 1 && i =3D=3D 0 && !tap->ifname) { - if (tap_fd_get_ifname(fd, ifname)) { - error_setg(errp, "Fail to get ifname"); - close(fd); - return -1; - } - } - ret =3D net_init_tap_one(tap, peer, "tap", name, ifname, i >=3D 1 ? "no" : script, i >=3D 1 ? "no" : downscript, --=20 2.48.1