From nobody Sat Nov 15 03:14:59 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1755865212; cv=pass; d=zohomail.com; s=zohoarc; b=FY537LMblqkbTDBEQ/tAxpMOjm92IYWyjjIcJQiGH4LzjNpWUh4WLmoLUX2/9PhwUx0nou2gxJy5kJAK1VVdQqJhvxigwhN/z552kaNq3FIm+SvUvwcaoJpII0Pa2VaUljN4yEC30X5zrrLoO4pAgtIu15UVo5qXd9Z2lZPFioI= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1755865212; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=fUXH7kZvyzaepKiFW9WCwWOQFVqPfIbSWzRnfWUyuIk=; b=nFCyQQJhXbwGR2zR4jGdTQ6gS5P1kq74atP8UmI93LfRBqVSFUoKqZODwv/mgrv6x91mWoER82zwVkG6PDM6q8jXsH+F9JSF8osXFHOS2lvbvibF0ZCULE73yqmhFdHHJw9mhPT+oxSbxpJe28AhtA16y7KU+UvqT+CtbhxMXsU= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1755865212026706.6862531902458; Fri, 22 Aug 2025 05:20:12 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1upQeq-0001Z4-UH; Fri, 22 Aug 2025 08:14:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upQeb-0001WE-Mr for qemu-devel@nongnu.org; Fri, 22 Aug 2025 08:13:59 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upQeZ-0000e5-7z for qemu-devel@nongnu.org; Fri, 22 Aug 2025 08:13:57 -0400 Received: from pps.filterd (m0127841.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57M8BBrr703328; Fri, 22 Aug 2025 05:13:51 -0700 Received: from nam04-dm6-obe.outbound.protection.outlook.com (mail-dm6nam04on2124.outbound.protection.outlook.com [40.107.102.124]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 48p6uaa6fp-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 22 Aug 2025 05:13:51 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by CH2PR02MB6505.namprd02.prod.outlook.com (2603:10b6:610:34::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9009.20; Fri, 22 Aug 2025 12:13:49 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%3]) with mapi id 15.20.9052.014; Fri, 22 Aug 2025 12:13:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=fUXH7kZvyzaepKiFW9WCwWOQFVqPfIbSWzRnfWUyu Ik=; b=eILrqnquJm7iX+/h0oP2k31nkxKfA8mbipL6hbJ/qh1PqC9x/DC098QOc b5Pb6GmlzIO42nl/+0eRaIV+B/G/tzB8pf9i7o24UVmpYaT6U6eLabUoSSFJjqJw Am2Pk77YAdsj5SSe9bSG3lHUA3zAjicgeWDb3MWTqYk8G886s700pcFwGkYf2mhn UzIv1p22W2kt/QQoEyvDQeHx4NSJ/JtEkRpn8eWS/QP6cTXT5dlLK5nsUr69k3Uw 7PLWhoDFX+27Y9GlhcXJmY3V6BSqcv5AJiQkTTbO8imeHIKIKh+L4V3RBiSbq5ZK lzQzGIzE4T2RnaAULXZFRD2C9uBhQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tsrZAjL0VmlMkpRnGogBuwJth4+banMXbekLHnwRIIFkNewMW1gZAt2GcT82uWltZWQpWUTT04Zr63ntnE58lVByXP2pQYXN8JO7XOr6KLUWTvp6u0p/Nx+wt+c/JJpZ3TmWHFQkMIm667+OctI43aZqZB9oTkA/8Yn63abALnTmoV06g8gbXJXCZ7GRXyHUbMx0CY8RsL8/aaR/FaAyRHAiu3fa/XnHBSfCB1tk0+E4uWAGc3+ndejqcN39cwnozK0nXfROZ+kNuWsX/SWqp5+LrGRqztI6SYNpUvXQdaZgfbyGuEYv5FTRsmaHANC4jqJhH+spgYarG3txXmYV4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fUXH7kZvyzaepKiFW9WCwWOQFVqPfIbSWzRnfWUyuIk=; b=AMYY5htwoJpEhQsaP8TU2puL/IN6UtPlvcKOPTWXXlKh7KFCHNVyCweZevxZqtl3qxrR4VHD/LaBku9hsmGZsj+gqpW1Q81cgOO2XnvOyGXJwVYxNjGRmFzMILypQEvPt/rZcAA4o2P8Yri+qUKeVMuIWa6ES6vEN/SUvWeROS3oKFIxnbbKKVYPQ/FoJEtuorFU/jhyBof8bG1UCIiqev2Vw3zhYn2QhT983cATGYBxGvuocZGkMZjWMS79+TcW18bbgkaJITXh6ksZxNgXG9JfXx2LO8nzXdJ44Mi0EWVqkKnJH9AFfKG9di5G64+cYjJ9sr/H4K0lumA6k0ogNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fUXH7kZvyzaepKiFW9WCwWOQFVqPfIbSWzRnfWUyuIk=; b=XEOmCpMzHb8g9UZ3aNGCR+7jyhfOGvAHXMZi+Ia7igwyZ9tZYwEb+B53DFrOmF4NQaLO0fwAV2tgItfQRlII6Kvv+tznjXuW4uDMRuT5zOPrgpHjdaTNBV/ONwOlu7EDRmyZ0W3u1o7Vh1DH7iMlvxYn4JteLuNcORyAOb8v3Pwx+FH9JTLy1Y95yV+GYhzts8iMuiml7IsbixjgBx7FdgBjm8y/d8hITg0aTeUiPoYlsDhTk7k+4I5E2kSMkzs+g8cWNzJDOIEVG6J8Wu+Wlc6noKgSxtxU4VF2QRXTz4jhtIi1TMIVZqlysypMr2SKdfxZCNDd2VFVJ51rFF3ZaA== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v6 01/19] hw/i386/pc_piix.c: restrict isapc machine to 32-bit CPUs Date: Fri, 22 Aug 2025 13:11:47 +0100 Message-ID: <20250822121342.894223-2-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250822121342.894223-1-mark.caveayland@nutanix.com> References: <20250822121342.894223-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS4P251CA0026.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:5d3::15) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|CH2PR02MB6505:EE_ X-MS-Office365-Filtering-Correlation-Id: eb60eee8-7aed-4509-8a02-08dde17559f3 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?RUpYL1ZCWUxWYmp6T00vRTJCemhYeFZMdzh1VXE4Q2dKelFKb1pjVDFRRVNX?= =?utf-8?B?andNTjhCMThnNzVPQWFISmNXU3NaNVl3SDVkSFlFTDBIQjkvQlBCNXZsanh6?= =?utf-8?B?MnZRSnh5dGJvdWEyRC85b2N0R2dJeEpuSEhJUFZqSU1EL0hMZk9OZTd4UWJ6?= =?utf-8?B?NWhYTTIvQ2NGTUQ0UEU1eDVRM0dJL01UcEgxanZ4VWZwM0pEY1I3Y01BdGF2?= =?utf-8?B?YXV6R2d0dWxDK2NmdlZVYVpZcnpPNTdCZHdKWmIwb2lyOWhjWXpSblhTT2tJ?= =?utf-8?B?QjdYUjVEM0ZQbllvOFVXVU1MMStkV0NWNEhiUEZ4SlBSdkE0T2lKVElVNkNs?= =?utf-8?B?cG9uajJQT0o5T1RCbkR4OWtvdHp2djJkdHNIWHJvdFJ2WFJHK1R5TVNwS3BI?= =?utf-8?B?WE90RVEzMW1oekdNcnJ4U1AxbnpaMEVIcExEY013em5ESEdhSExHMjJPeXJQ?= =?utf-8?B?SVIxQWRiU3YxWlVXajhPY1BjLy85ZTZ4eXNWTDhJZm1NSWs2dlVxbXJxbXdM?= =?utf-8?B?dmZZWEpwK1B5NjJOL0tqaUI1Vno0c21OdHEyUWt4K0wvT0c5cXZUWTBxMWJB?= =?utf-8?B?eHMyWVFPbkdXazdzMDZ2WWgvZFVHcDVTK2szdE9hTk1zTmszbzJQMEZQQ0Fn?= =?utf-8?B?a29FcXFrRlp4OEhhYmpac3V0dlpZaUFJZlkrQzI5ZVRQWjVPOGJvL0pwOGVr?= =?utf-8?B?TW00ZS81ci9vNjhpaUU0aGZwR21zMW5YTWMzd3pWNEVIaFBySHFxNnVLQUwr?= =?utf-8?B?ekdjVHR4ZUdkZE45L3MzR0F0V2dsbkNxczBYYkZSRGRQL1NiTFpQd3o0WnA4?= =?utf-8?B?TnUwcFkzeXVCaElOTDhQaFdJU055c3F6RisyNVdUOXBxOUxFVXpqSWNHSmM1?= =?utf-8?B?VXIvenNYYlU5OExaTlpmdE0zZTZYSWlub2hldHIwbHdSQUZNS2dsR0RtaCsy?= =?utf-8?B?VW00ZVg5K3V1Mm9MVGMrZzc2L3hZTFZhbXoyZnlHUnNCck1NajlPY0VBZGQz?= =?utf-8?B?MUZJdVQydTJ0ejZTeEN2VGVqMmF0N2diV0wyUG1vNHdYYmE2ekliUlUrK3By?= =?utf-8?B?bUtUNlM5aEVYVjZxSTZNajVqRUE0RE5VSysxVVZBSEo4ekhRK00wOHAraDFL?= =?utf-8?B?TTN3bEFZTXdvUk0zK1NkV0IvYXByUTQ4TnJscnh2K1RqV2R1dDhIYm1tL05X?= =?utf-8?B?ejdCdzVieFBTcFF1VHZuNHNNckJxOWdwUFVtaExGZHlaWXBEa0REYnQ0Nnd3?= =?utf-8?B?bk5NY1l3R0ppbS9HdHFwWWsraUxOZ1E0M0Y4dytxYUphNUhSbFRkMEpUeitE?= =?utf-8?B?RDNTNXpoR2Zib0ppRWRYK0laNk5BSjVtZGNoVGlLQnJ2bGxwaFo4dkJmazhP?= =?utf-8?B?bFVBbTJRZjZoUTZtT3RPU2hTV2VJU1ZMUFo2N2UrUUZwc3EzR1RPWjRXSUs5?= =?utf-8?B?c3dTblh2d0tPZGFiNkFjQUVFTGRoL3ZQbjFXczYvaDgzRHBrTm1QNnB0OWtB?= =?utf-8?B?TTlDR1BiZE9EQ1VkYnBSVjZPMGdpRzdReFo2N201aFg0em1Tb2p4Wi9zZG1Z?= =?utf-8?B?MXErMmVubkR3cVZJY0lKVGdFQXJMejhabVlIQnNiaVFDcUFLaUdMZUpab1g0?= =?utf-8?B?S3RwZUtXaFc1WkhqUFdFeEwwODVmdVk3QTNFaVJDUXRVZjFmUnZqYzJld25O?= =?utf-8?B?UHZJSlhMSXN5ekFGQitIMjlmbW8rRmVhU1FmVTVDenJVKzB3YVgwU2JVKzZY?= =?utf-8?B?aVZkVmJNaW10dUJCME5sRnN1Qi9KQ0NQYWdMRzJxQ1I0THRBSFhOUjhpc0ty?= =?utf-8?B?aTQ1N2Q3RG5SSCtGendMenFEZ05kV2FDb3lwZEFzVFh3cUJxQ3pGemZHMVB1?= =?utf-8?B?SzVwKzlJNWk4V1FCWkt1ZjVpdXVZMzRXUW5rZ3BCMndXTEVpdUZLa0swRnZW?= =?utf-8?Q?SvC6kqqV+q0=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UzlOLzZLWC9EMHNyUCtIVG80aEUxNHN4R2xSeVlrREJzbVRmNzNPeldad0Zz?= =?utf-8?B?Y2lXVDdKOXdaOExscHZjYmxYRjlCVUM4a1pZY2RVYjNSSFREKzhNTTViUEdK?= =?utf-8?B?bGxvQ2dzRzNGdFlaaTJQRFhjYTdpK0NlUGd6RDBmMFFZVUU2WjZudk5LL3U1?= =?utf-8?B?VVpnWWpoOXBRbWdwTzZsYXlyRE95WEYycCtJTkN6dzlxNUl3bXVJVzdDVklF?= =?utf-8?B?b0w4UmZUS01NVE9pSktaeFE3MkQvenF5QjVxWE9Lb2VYVXhBWUFQQlNjekZX?= =?utf-8?B?UEN0YU9TamcrKzhmNEcwQmMxR1Zpb1FrdFhUSE9PcVNVQTZZTWhiZGNSNDBW?= =?utf-8?B?dlFGRVJzTTIzWVZSOFNLYUFxamFjUU95RkNTeHpSenN5MElQTzNVU01Nb0Jt?= =?utf-8?B?UTArMVlvaGVBZlhCM1hheEVYbkRndTBaWVJIWnZDcmtPbyt0SDRpdFFpR0xq?= =?utf-8?B?cVAreXhkV0h3VU54N1BpME56Y1ZTb1VPQnliY0k2ZnNHMnhCMGN5QmlPSnFP?= =?utf-8?B?K1VoSktvRkxCR1RQb2lXMXVVb2dFcGVkOWFUU0Z4WTErNndEbzZ1MWU2clli?= =?utf-8?B?UXhoWUp2dkR1RXZyQldaL0dpY3pQazJ3MXJybnRDRlZINzg3SG9laXhkblBi?= =?utf-8?B?NEwxclBZMm40QXpKVVc4ZTNXc3VvSmVYOXlwK2Z1UHQ1TFpkeE8ycXhoWVFx?= =?utf-8?B?U3Vtd1QyVTFsZXV2VmlaMTVKRVVxM0U1OTl4dGdaem5jZUZsMjZPZ0w5OXRV?= =?utf-8?B?dmxTbnRPQTc2VEtla1lMYjgwL1dEcFVVMkRKK2Y3aTY5TkR5WnhCdGxCamt1?= =?utf-8?B?eFNMbEd1K2hDUnYxVFJTTHRwN3VGOVQ2MEtTNW9ENWdGUVVCN3gzOE5Ka2sy?= =?utf-8?B?V2ttdzlxS3pZSHdNQVhicFl4SHU5b1RrOXlpd1hCcVlNNUFxdUZ4aUord0g5?= =?utf-8?B?cnZZL09hL2s2cWYxUVFkTjc1THpON0lsajkzb1JPMDcrSEc2N0JyYXF4SVFn?= =?utf-8?B?OGQ5K3lvNytuSDFGSkNudWV4ZWRVazdsT0ZQS2syVndoTVhCaW9jWlpMeWlv?= =?utf-8?B?VkJ3K3dudkdKQzRhZnF5MlBxQ1RyRmlxSm1xYWh6UlpCQXhYM3MrK25mRTkv?= =?utf-8?B?eWtGWEQ2WkkxVlFpRlpMY3dRdHVPeThaQkhmUEIyWEFEOTcvZ2JZMGxCaHRm?= =?utf-8?B?Yk9zeWZaRE91R2t3c3BLMksvamo2LzhzMkpxYXBhdGNhdnNTcGpCT0czRnZD?= =?utf-8?B?QlJwSU9LaVBDYVhuZWJaQTI1ZHB2Q3ZSQWJQSk5mVVNQU1JEbmJmYm1tamxu?= =?utf-8?B?cy8xMmcrc0g1M2w2MXVuQ0xjRDhUSThwdHpaSVB0VWwxdENjMlNHZDRpL1Nm?= =?utf-8?B?bnFkZE10SVJnbHM5SkFta2hsSDdKeVVQMWNwS1JkWXZ0MWgxRFZXV2RFU1lz?= =?utf-8?B?MGxJWHBHM2tXcG1TYmZwc3ZncExrcFFtbHgrYVA3MFd4aXFjOStGejNqYVFK?= =?utf-8?B?SCtjNDN4cGdPbXNjblpQdVpQZmdSL2dCdjVQUGNTdjF0a09nOGtxc2JwSGxy?= =?utf-8?B?a1F3SFZ1c0Y0RnJHaWdwVHpWcll6K1ZjQ1ZlNk45VXJaSnlUZnVSNEtuVnZN?= =?utf-8?B?d3ZORW1HZDZPWUpaTzBNSlZHQ2o2eElGSlp3QnVVa29VNm5YVjJFL3hMV2x5?= =?utf-8?B?bGgxZndDeHZQUUozSFBUNGxUNDRwODBCR1N6VE4waUZiSXZRZGZlME95ZTBy?= =?utf-8?B?aTB2TUJtVWxxVS9jOXN3RStxWmpub05xQU9EQS9mTkhBOWdvRkk4OXpIdnI0?= =?utf-8?B?TzhDc3ZwZWNaVjFLM2R6K1BUVFRHNnNrbVA2UGdEaTRmK1NGbjZHY3ZSd2dl?= =?utf-8?B?UU9weUYrcTVWS2NkalJDQmRYWEZSN294RUJQeUpmcFlKZkJFS09aTmZmV2Ix?= =?utf-8?B?d2xLakRDbkFxNWdCZFNHYlBMYUUrOHdLMkl5VFdBWmU5WTVyeTBwODlOM2l0?= =?utf-8?B?aWpKbFF2eEVVVGsyTG1vTXRRRm10aHIrVGwzWkpzamQ1cGhPc3c2UGo5Rlhj?= =?utf-8?B?Nyt0eE9CaUFQMTNnbnM2RSt2WUZFc0JSajl5U051R0FMaUlON1hrS2xZa0k3?= =?utf-8?B?N3ZkWEdJMDdVNlV6R2RvbU9leW9UaWo0cDRta0o0NW12ZzNFR1N2ZndnMUla?= =?utf-8?B?aXc9PQ==?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: eb60eee8-7aed-4509-8a02-08dde17559f3 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2025 12:13:49.6311 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sxUa0qdQ9w5oh93CqkIwTwN9CFisUE863Y2D5SdzlFkLn7lsNTtZFYR4RVY7p8Ipxutss6PLTQ3l9nv0rIvzG6Qwztp9cPZjWQOZn7dEoD8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR02MB6505 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODIyMDExNCBTYWx0ZWRfX6jJd641ukJm1 m/S/YDm50jbkaL5FXh3KtjCBFw1ELS9/aDoXMWA6CxUwmsFf/7BE/FtyzwaqxIcKJz8MRZpvz6t 9lAENbXJUhHYToRwf8qGVhdlO1Jt37BPVPVNhjT62Pvy/3Oix6kQzJCt16ICCJfD58xqQdXyROA y2JCoju8rpt2mKMFboJu3zjUtrOOY/wf07ng6XbuWPdf/Sptqz2SsnuC3P9LPvWHtcfDdYyzPzF Ze2rA1zd0mXS+kp0FKcwUFJRqvSjef1ZDK0Ho5B0Zac4bhMYFLX800smZinxCS7t29+a2cp+bGS wvzm+s0c3Qcx0tj6tJJUk4xGAt+jLI5A3CQBZ35qNuJ+HiTtbikN376tb4TZvBSVD0xhDQLt0Xj COaBLvxitACBHjzz6muy2AkPLSTMeg== X-Proofpoint-GUID: 4fQ4PqF5dzUq5Sjd8GwRUIe1rgGKP8Kp X-Proofpoint-ORIG-GUID: 4fQ4PqF5dzUq5Sjd8GwRUIe1rgGKP8Kp X-Authority-Analysis: v=2.4 cv=Zsu0697G c=1 sm=1 tr=0 ts=68a85eff cx=c_pps a=MHwok5EG2MSMEd9B84SlyQ==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=nuetpX4ixqIVgyrW5aIA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 a=cPQSjfK2_nFv0Q5t_7PE:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-22_04,2025-08-20_03,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1755865214574124100 The isapc machine represents a legacy ISA PC with a 486 CPU. Whilst it is possible to specify any CPU via -cpu on the command line, it makes no sense to allow modern 64-bit CPUs to be used. Restrict the isapc machine to the available 32-bit CPUs, taking care to handle the case where if a user inadvertently uses -cpu max then the "best" 32-bit CPU is used (in this case the pentium3). Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/pc_piix.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index c03324281b..5720b6b556 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -436,6 +436,19 @@ static void pc_set_south_bridge(Object *obj, int value= , Error **errp) #ifdef CONFIG_ISAPC static void pc_init_isa(MachineState *machine) { + /* + * There is a small chance that someone unintentionally passes "-cpu m= ax" + * for the isapc machine, which will provide a much more modern 32-bit + * CPU than would be expected for an ISA-era PC. If the "max" cpu type= has + * been specified, choose the "best" 32-bit cpu possible which we cons= ider + * be the pentium3 (deliberately choosing an Intel CPU given that the + * default 486 CPU for the isapc machine is also an Intel CPU). + */ + if (!strcmp(machine->cpu_type, X86_CPU_TYPE_NAME("max"))) { + machine->cpu_type =3D X86_CPU_TYPE_NAME("pentium3"); + warn_report("-cpu max is invalid for isapc machine, using pentium3= "); + } + pc_init1(machine, NULL); } #endif @@ -806,7 +819,19 @@ DEFINE_I440FX_MACHINE(2, 6); #ifdef CONFIG_ISAPC static void isapc_machine_options(MachineClass *m) { + static const char * const valid_cpu_types[] =3D { + X86_CPU_TYPE_NAME("486"), + X86_CPU_TYPE_NAME("athlon"), + X86_CPU_TYPE_NAME("kvm32"), + X86_CPU_TYPE_NAME("pentium"), + X86_CPU_TYPE_NAME("pentium2"), + X86_CPU_TYPE_NAME("pentium3"), + X86_CPU_TYPE_NAME("qemu32"), + X86_CPU_TYPE_NAME("max"), + NULL + }; PCMachineClass *pcmc =3D PC_MACHINE_CLASS(m); + m->desc =3D "ISA-only PC"; m->max_cpus =3D 1; m->option_rom_has_mr =3D true; @@ -819,6 +844,7 @@ static void isapc_machine_options(MachineClass *m) pcmc->has_reserved_memory =3D false; m->default_nic =3D "ne2k_isa"; m->default_cpu_type =3D X86_CPU_TYPE_NAME("486"); + m->valid_cpu_types =3D valid_cpu_types; m->no_floppy =3D !module_object_class_by_name(TYPE_ISA_FDC); m->no_parallel =3D !module_object_class_by_name(TYPE_ISA_PARALLEL); } --=20 2.43.0 From nobody Sat Nov 15 03:14:59 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1755864902; cv=pass; d=zohomail.com; s=zohoarc; b=hybxjvyNoGtSv3BGJaDM1cM1U5qyXtBBeQrp8v9BoC9tWiPrIAv9FvKJ1aNzWtTnM+qirZMeJ7oHsKKI+PIQZeQrUCnMEKwucmRgyQUG+IV3SM2IcQPhlioB4e4xA76KdAKInXYgXvDPzU+/d2yuXavYAieTZnPkXCSXXcMhII4= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1755864902; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=aRgwk4voIlw12rP9kq7VeM9BY3duphheUTbg/o6EDEU=; b=dOeYtX7328wVSVHgg/hQY++kzVj4Ft4NHqxBOYBmj9rFeRKdnjU+kWhyZxQm8vtTVTET3WxB7+Wlr5DovIBak8rq/341LY7CwcgKFIGLV+LgGxfznPqSomkUFm5cFoBSbzbzvwpXBcPe2tiUrwyf4nbpTXDp6Bd0aeXWsRk41PA= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1755864902490998.774907641042; Fri, 22 Aug 2025 05:15:02 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1upQen-0001Xc-DF; Fri, 22 Aug 2025 08:14:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upQef-0001WX-H7 for qemu-devel@nongnu.org; Fri, 22 Aug 2025 08:14:01 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upQeb-0000eE-H3 for qemu-devel@nongnu.org; Fri, 22 Aug 2025 08:14:00 -0400 Received: from pps.filterd (m0127844.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57MAgEHM2873070; Fri, 22 Aug 2025 05:13:55 -0700 Received: from nam04-bn8-obe.outbound.protection.outlook.com (mail-bn8nam04on2112.outbound.protection.outlook.com [40.107.100.112]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 48pq1g857u-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 22 Aug 2025 05:13:55 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by CH2PR02MB6505.namprd02.prod.outlook.com (2603:10b6:610:34::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9009.20; Fri, 22 Aug 2025 12:13:54 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%3]) with mapi id 15.20.9052.014; Fri, 22 Aug 2025 12:13:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=aRgwk4voIlw12rP9kq7VeM9BY3duphheUTbg/o6ED EU=; b=Hv+L7vsucv2teay6xj/4Tf9ZoSTPwppQ56JMgX5Gp3IMp49jpwTJelLc0 JtNZM1Ddz2KCD+XgVwQ+Nf2/rsftPEjexBFsCRzSLflxZ/PEGfVBDcKfJTL3drRk IoQWV4g2GsLChUGAERMdOEhOlGRSKslQa0nCLE07YiXWoCLGOUSjEPo6uXxuVdZF rfcUEjAIalPvYrcu8WjsVzGkGTpZTelaoiEh5hCpO4mvPiai0H0Lv/Tv9NxihO3R GYmIT8/08Qvn0CRXqjUX3v8/2ktFzDhE/xsES20SBbWTO4vet571ZtLVZJdjkv8x KnowqOXrUphayDjX+oRagF10LCZ7A== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rq5xbU7PioePBhTdjaPSf1EVXJYn04Bjg1C+G595QDVXvIU5Fx2/A1yge11N+kKgH1yIseetJlzPgUCXsJ17wWdT1ciWi657bz1mmkRaJ3VbuSwgskR7TRSKBxXlixlhy2SJ9cusEOOG++lYH4zWg8u1jO9gp9yntlnewpI9Ufaj8Nob8J0giHg0vJD9gr12lHAOhT61M3L2aJBD9yoO264JkZP6KNaNql9aFfXwBcBOLvOvoDhLY9Nbb81Mtn8pnu22SXpcnvEC1m1LrptebX05dgo3zt04J9cgV4/qT4xTyfG1Ev5TZOqwRNKsk90Pd/S09LOkK+nDIMUX6ClgBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aRgwk4voIlw12rP9kq7VeM9BY3duphheUTbg/o6EDEU=; b=VGW3u89qwe2Zv2Bt39y+KIq0Jrr5JE9cAS5SZkbT+oyKyBckPBR2sUJlFACHgh3uvID7Eq4bOtVN2My+0LC4vytd1INt7+zRbaESnez2j0hfndMKCP4iE4aPQt0XXlbAdM4/UREwNu90VisZwvpVR0aUdc8+FFRaEskVYWLhJMmGANNeKDASHuvcTPWA6FFpUi0LhFlBPXsq7LL8S73r5i0xDAOuEgVra5Y6+EpUxghssVuul0tawQwC/EJm0afnCRi8sW50f38nmmd8FLSjC1z4EoP61AegbKPHi2g4e0a4sL4qzFPO+KJjQ7s8oqh/j9QJDhueex+6BIdKZpq9mg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aRgwk4voIlw12rP9kq7VeM9BY3duphheUTbg/o6EDEU=; b=aanNaE7GInI0Nj6jispY2+Sazmnmt3EoIb1FjeCr8VNTwnUe1cfMl+caEn0lw0e8XBGwBwZ0ouMPg6cORhcpPuyPX1/Rgj3XDA3I5VuWm7+YHZ+j4BIP50pgJ9znp/VPl8vEvOegUBjk7j8/+irniCvXVNH4FfnqrTc6O6PIrXZFQCXHKeNPqZ/qJvMyBWpD2kQaVAB3ju1drpMn7NtJS/CGrNoRzk3h9mIRuJyuaVnpsv6QT+OP0G3s3yOHSiSWVIRYN8bx3gEghkxIQZUiQ+WJISPy9iHY0zs9Ex1fFNbgdS6uOeiW8e1Bm8wqul6ZcDks3h2bAt+ijQAkCbU/6g== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v6 02/19] hw/i386/pc_piix.c: remove include for loader.h Date: Fri, 22 Aug 2025 13:11:48 +0100 Message-ID: <20250822121342.894223-3-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250822121342.894223-1-mark.caveayland@nutanix.com> References: <20250822121342.894223-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM0PR02CA0035.eurprd02.prod.outlook.com (2603:10a6:208:3e::48) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|CH2PR02MB6505:EE_ X-MS-Office365-Filtering-Correlation-Id: b53c8893-2401-4bb5-1711-08dde1755c62 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?d2gzN2UvWjFhYVFIT2N0WmFjeUttQUZJeGpPeitkckxST045MTA4SFUrR0lM?= =?utf-8?B?eUtpMzArSXE1TENoWU9LbnYwcFJobkh6SlNlNXB0QjBvUHl0UldOeHFiZ2N1?= =?utf-8?B?RWZnQVlZSzBjbjBwNVlXcEpiN2pBZGJVZmZjVE9vTTZUNlk2akVmYlRXVXNO?= =?utf-8?B?Ynk2Zm1TNWNPSUlzMStuSWlpSTloSzdDT2gvdnBjYmRReUs2Z2RicWJISGd4?= =?utf-8?B?NThWTC9KK0dKNWVyMnRjT0swV25YSnJ2ckI5STRaYzQ0RlREM2ZldWpyTXo4?= =?utf-8?B?eDVzWlNwVzhGMExVa1dxeUZtU0JNOW52aTU1bXgxV2FpMWJxZnB4Y2xReHgz?= =?utf-8?B?VFQ2R2lCSUJ6OVJxdURkR0dTQmErbFdqZnJTU1N2TVIvelhvQ0hiUzFkSEM0?= =?utf-8?B?Rmo1VTFINEIyY2xJZ1hvc285OGFUS1RCRDVrS25Lc1ROSExXdDBieGZiRUdT?= =?utf-8?B?Smt4V09uQXkxcExid2c0bFdEM0FmUEhzWjRvNEJ2eUFMVzNleGpxcWwwT2VM?= =?utf-8?B?eER6UllJQ2E4QUxnVUEwUVV5NXZWQ1hwR1E2cm1FY0RlNUJCNk41NGVrY0Y0?= =?utf-8?B?RW5QSmpxb0dJVjZibDhyeHZ0ak5sWGRJdFI1NHhKaldxZkxVc3JCcEpNZ1VE?= =?utf-8?B?V0p5ZDUvWHV6dndCcFdKZjVZRGdNbXJEdlpYYmd5OTBrRzUyWnU2K2g2ekty?= =?utf-8?B?amFpdGRqWkh1UldMZmRubG9xR2NHUUNSOGRZK1dYOTlMZHhTMWVpUEF1UEkr?= =?utf-8?B?MVpFbm9Maks4cWhyVzdNbmJmMXdjbTdWdEQxM0tabVE5WWt2VVBTZjBMa2Fk?= =?utf-8?B?SmZDeDl0emRuK0dDMy9Id2Noek5KVmJ0VmQ3bktEY0tGQzJnSlUzTzJzOEpL?= =?utf-8?B?MWhNU2hTbUtibUZRTEpRWTZlRG5OeEM3ZjhpRmFpWmJoK00zM2VxU29KWkxk?= =?utf-8?B?SHlFMWJaMDUwd3l0eTRyM1JYRUc0MXVQM3Q3NVc4MjBJb2E5QkxOb2NHWFUv?= =?utf-8?B?NW5SNFFJYlhVTHFySzVVV283cS9HQ1ZxbDFES2lKdjFHcFVmOUZzVVNjNWJO?= =?utf-8?B?Zk9MNDQwR280Y3RNUDJJcDkrcUJkcHM5eEE1bnUyaWJEaFh2V2hIa21vdFZo?= =?utf-8?B?czdVcW5DTkJwUXJsS0l0Z2c3bXhuNitONnFrdlJUb1M4MjBUR3h1TkJVa0ho?= =?utf-8?B?SzNHUHRRSjQzQ3hheWlCVzN6SmJVbHM3RE5FZ0MrVjhKSUo3dE5HeUt0bTJ6?= =?utf-8?B?SWM1SEdKeWlpYi9MWFRsTUtweXB6UXlUendBbUdSYXpQcEFuYWwvL2l0eFhT?= =?utf-8?B?cTg1UTRMQm94QkV6QnU5QkpJMVFZdEMxblJGZDkxSStUNGgvTTFVQnR3aDBH?= =?utf-8?B?WUJIQytOVHl3eWtPUmtVekQyVk5SQXRrazJkc0hBOVNMT1VUSm8rY1ZIbkRt?= =?utf-8?B?UTdNL004ZWxjbVBKeU5lcmRZbHZSeXIvQnJUejF6Sk10elZ3VlJPR0FUYitj?= =?utf-8?B?SWdjVitydmw0dThsN3NnaU9HWEtWRjh4R3NRRW5XT0FZb1o3QUlwTC9tMm02?= =?utf-8?B?bFBuekJlRFBWalBoUDgzRDlqYlNIQW42MStkTVhId09UTTVqb3hvQTJqYTU4?= =?utf-8?B?ZGRNWmVaWW1aU05CdmZGS3dWMkFRVnVyR0h1QTRMR3JESFJweUhuR0MzM0s5?= =?utf-8?B?RzI4dTExeWZkYmZzTDB4M2RDKy9vM1pVV0M4aHdvR24ySG1Sb2ViOVlnbldT?= =?utf-8?B?UXpMLzIxdm1HUjZwd0dQMGhtOWpLWVQ3c1VRbCt0aGkzQUVzbldPTm5iM3dB?= =?utf-8?B?cE9maXNtbGZYVFdEWDNyRkVXblhLZnlQSEVaQ3I4enFiTGYyWWRtbGQzUjQ2?= =?utf-8?B?OWtNcmRnUGllK29naDVVVGtyeDJtYVhDZlhsTlFZRWNXUUE9PQ==?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Mm9QZEs1TlY2aTl4cGtaZ25IbHVqamh5SUVMMFBaaVdMR0VxaWpnZmZoMzk2?= =?utf-8?B?TExBTk5Mem04L0crUkdlcUNMWHRCQUtiVXFMcjVCem1JMHhYeDd4K0FrVm41?= =?utf-8?B?cVZrdlVJbWJCZzZib0lOdGRZYkZBWGVmS1U2L1RUQ1V5RGRSTzNHUlpUWFln?= =?utf-8?B?YnNIWlR4MG1vQmZTYldqVWV3TWJwTlJlbmhCaW5hekFhQjNycXd4MWFJUEkz?= =?utf-8?B?MmRkWG1McEpVVjRxUHpWcUg0ekhrTHppcExFcUEzUE12VTBhZDJ0bVorc3NB?= =?utf-8?B?ZGo3UlRyaWlGTjN6SXJOQjFUYzJuSkpFeC9wOXcyRVU4TXlNdnNvL2lnMUtT?= =?utf-8?B?NEZDajEzWWhZSkEzVFl1bTk4S1NlbG8vdklDR3QzalJTci9iblVPdXJENDAv?= =?utf-8?B?Vy9lLy80RUtjL1I0ZXo5YTU5T21JRDRZYkpIZXRFSG9PdzhNQTROS25zaVJR?= =?utf-8?B?N3A0cTNWKzQ3NEljUHpNTkRUaTB6akhGcG44ME1KREsxNEU0cVo1YldTUTBn?= =?utf-8?B?WmcydXhaY3BQbytUbWtXT1hTNE5TV3lUanZSbDd2QkFyekN5K2wyRFdsenZF?= =?utf-8?B?eWNkdnZZSlI0ZnVHdXRTaDdlNzJmd2sxVktuM3NRa2t6dWdDN1pSNmlINU5U?= =?utf-8?B?aENRUGNrN2ZFSWNpaFFDWlJrR2lPUC92ZEhobUk3eFpaUHQzS3dnZnYxUFBZ?= =?utf-8?B?ekFlYk1pL09VOE1sVS9qRFBLakhMc3NwVmxKaXVxNUxFbVUvOVFrK3RkdFNL?= =?utf-8?B?eUgyaElnelVnUVNiTitFM1lWZ25QdWUxSFN4QUwyVlhaU3Y1N0s4cm5tQm5O?= =?utf-8?B?V3QxSVRqa3gzWDdDMThVZVZ5SWovL0M5U1Z1NCtkamt4S3BBajdvb2JtRWwy?= =?utf-8?B?Z2V3QzdHUGlnd213ZEcweGUwNGJGNVBReFdPa2VQN28rYXFSczRzb09UcHJR?= =?utf-8?B?ZDBEL3N0RWZOOVJsQ0VjdnNHUVRHSVZSenhTYkw0Z1JnUUJ5UUpIakUvOHl5?= =?utf-8?B?anI3ZGxqNXRIL1dldnlKQXo1M0diQVU2ZXNmNzVVODJEemR1aVdWSzRKMW9x?= =?utf-8?B?UjJ5clg5elBldDlVTUhnWHJFMmxFRVRneksrWDZ0ZlRUME5WTW9aS1p3NE5C?= =?utf-8?B?WlY2aTJ3N0g5QnIrR2VzWk12OWlBMVM2eGRjMWVFaGoxK3JjUDZPcmc1N2dz?= =?utf-8?B?aXMyaUUxdStpdS91TjFFTi9QVFdJaXZEMkRDZHczQ1QvTXdSQ21veXg5SlE1?= =?utf-8?B?Qy9BNVJyRjFCT0hDMm4wZXFLZlh5ZkVuOEg2bDhUTFhQS3JLT1hOSk1FWHBV?= =?utf-8?B?RFZOM1ZWVGFsMktNSkpaQnFvMHRhRG1qdUlFQTV3WkhkbmhTY2FkTTJDQk94?= =?utf-8?B?am1nWUduMTdNSFUrOEM4L3JmZm44VElTVlBadk52S0FISWRoeWVZUXczNkp4?= =?utf-8?B?YnBXTThvcHk3SFNQOEhuN2pybnlPTzdlNFhpNjRlSkFTMnlXMmtoUTV0MjVZ?= =?utf-8?B?YTBhY2pHK0FCeWlrKzRJL2NkdVJORWhndlRKZlo5Zjl2c01EMnVXblRJdEx6?= =?utf-8?B?cDFtLzBIQXArTXFLbUp1SG9UdjY3dFRBczhhTDdUdjhnMjZ0QmdabXh6S0U0?= =?utf-8?B?VnF0cVVCNkxLN0c3TWtreGRYRGMvcjJVZjNVZTEwMFlOc3IwbEZNYW9yVkNp?= =?utf-8?B?NmRXL2toM3I3RmZIa3hsNjBSWWt3UThNMnBIcUFFbXExOXNDVE9TL3lWOTJ2?= =?utf-8?B?T3NaakVMSk95Qk1mSURLTGUrZ2UxRlYwTm10b1ZkRFJIbEMzMFhKK213dk9w?= =?utf-8?B?UDdQV1p5bGVkd1B4Y3I5aXQ0VXY2eVJKYVEwMDFxK3F1bUVxdURwVWZQdEMx?= =?utf-8?B?QU5SMEZualRGYTFYbzY3bjM1KzIvcExZUnVOaTVRdXc3ZHVrT2U2WE0rV1ky?= =?utf-8?B?bTZQUVJRcmZlZ2JWbUd4dm5Xa1V1Lzd3Q1ZYeCszNDllL3BQWmRXRjY4UFN4?= =?utf-8?B?cW00b2xBRGVLRHVjQ2EyU1Y0TncrRlBGTmtyZjE0alR5emFXTUs5VzNQVW5l?= =?utf-8?B?ODI2U2k0aXYzNFNiQWQzMzc4cE5OcTQrWkc5VTk0Vm1SdVZFdmIxNDgxNFpJ?= =?utf-8?B?SGlEWVRXSE5ZSkhTV2REUmlqd25yd2x4bFJjZG9UckdMalhDUzAxOWpaMGN3?= =?utf-8?B?RGc9PQ==?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: b53c8893-2401-4bb5-1711-08dde1755c62 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2025 12:13:53.4661 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: o5uylB291UczW+RryGQ3qEFT2L5qbMfawcrCeFzsTR6Br25WWoPs3gRvaoUh9jxKyl9nhvvhnU4rv84C+OpJ4gDFiPA68xhe7eSdbG0UCck= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR02MB6505 X-Authority-Analysis: v=2.4 cv=drqCy1g4 c=1 sm=1 tr=0 ts=68a85f03 cx=c_pps a=vBA6s9seywRwt/5CQUiZAQ==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=_jvWDQGc8cL8bECqUo4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 a=cPQSjfK2_nFv0Q5t_7PE:22 X-Proofpoint-ORIG-GUID: 5r-meLKoUTKTvUKpxc1d1ySyaXPaVqIL X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODIyMDExNCBTYWx0ZWRfXysmYLNOh9X2x Olh+krFJGBtsyqqxYWqT5NosNksXBX5PBcGND+SteKxm38vRCQplRdYfT9fmdfeOfdhgHOLPwgB hhHDYcGOPTVihsqJzubxxZJM+ze3WOxiF+j7VSG8MM0GbgUXqH6hqI77AL6jRPehIRdAJGDVaH4 CnVoaCyNgG1vaIAhTzAfcKY3Pl6V3CP3a7Q04KDb68TMfq+cUtU0MydUN4j4YNigQvYH51gOLhd 4uygO6T6Xnpx6+Wb+VTtolUViVvka2jwiiUH3Q5OYcuzyE51ncvHxbB8wKlY50r1U9H8PLIz0a9 mswmwHLtbfqHIp8STl2fyQ/l+Frcmox4cT28/nHkspySjKIMyA+UFi2sSq5HBC556VtpLx3Ne58 xFALVOytqsYpt/nB15RjoUY3JIvGmg== X-Proofpoint-GUID: 5r-meLKoUTKTvUKpxc1d1ySyaXPaVqIL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-22_04,2025-08-20_03,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1755864905653124100 This header is not required since the loader functionality is handled separ= ately by pc_memory_init() in pc.c. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Xiaoyao Li --- hw/i386/pc_piix.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 5720b6b556..bc8fbe46a1 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -28,7 +28,6 @@ #include "qemu/units.h" #include "hw/char/parallel-isa.h" #include "hw/dma/i8257.h" -#include "hw/loader.h" #include "hw/i386/x86.h" #include "hw/i386/pc.h" #include "hw/i386/apic.h" --=20 2.43.0 From nobody Sat Nov 15 03:14:59 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1755864996; cv=pass; d=zohomail.com; s=zohoarc; b=TISuTy9dswkXk2uMYr3SNdH6erVXSnfmQSsRj7Gc+ysMh41bINTNj56tYzmNtLCWbBmZQn/056DNP7h9EHM3FRYiN50O2zdssE3jXCa0LTXTBqSa08836mVYxwLMqUsT4njdoTtPolCcpRTb3TcAbtfWZ7pZyExHggQ+92w7dMk= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1755864996; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=p833WsOxjGEEWpUKPWpxdnHFs0t8JtXrvnTNCtTlbRg=; b=T518L1kE/b5X/JmT716THMVRs/quQG08Tp924sM/IRujl4013m5PJ68Jqm3nzCwMMtVqykAmRlUI9UC+zPjPSH7BY6Z+8P4fq85/IJo8bsxxwjMueTEqeFXLR/9hZv7wTEZdDBzzSTTHo+6XrWwWqgy5Q5hjtjLNfolU383KBUY= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1755864996572680.4849640704856; Fri, 22 Aug 2025 05:16:36 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1upQer-0001Z7-BP; Fri, 22 Aug 2025 08:14:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upQel-0001Xa-8t for qemu-devel@nongnu.org; Fri, 22 Aug 2025 08:14:09 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upQee-0000eT-2K for qemu-devel@nongnu.org; Fri, 22 Aug 2025 08:14:03 -0400 Received: from pps.filterd (m0127842.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57M8V9UG656748; Fri, 22 Aug 2025 05:13:58 -0700 Received: from nam04-bn8-obe.outbound.protection.outlook.com (mail-bn8nam04on2093.outbound.protection.outlook.com [40.107.100.93]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 48mye7yjek-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 22 Aug 2025 05:13:58 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by CH2PR02MB6505.namprd02.prod.outlook.com (2603:10b6:610:34::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9009.20; Fri, 22 Aug 2025 12:13:57 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%3]) with mapi id 15.20.9052.014; Fri, 22 Aug 2025 12:13:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=p833WsOxjGEEWpUKPWpxdnHFs0t8JtXrvnTNCtTlb Rg=; b=G/vFzqPdcN98RTyBb4vEINg2ilQbFCTyZK+m8NXnMQOWyHvCBLd7+NDer 7hRyNKnkvr5qxF5RcgMpseAgiq8hnnqWkSxObUXqWMGX6BGAXkuKCcT+3RCBdUAN LHk2PNKMyY4Vp9rpZfTYobrFWyXIPhIE9DZKLCXyl4J6Due6b1bdKzbYCqX7G490 FpKaR7Zf4wpAOCURufSrpTMcZ+mA4G0IS42Ggtek6Jp0Qqr63XYnmNuGBQgCFos0 HANvUf4J+S7wHmKa5J3fwE8JJdCaRH1lamea11sK6mljikv+ovsu+GXQZMhDxUMR AMLrvWOjFNfY7OA+WX+eRSPe7LNnQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AKXs0r8NZR7SDUajifNRdU0HAdHROb0vuI6NY27cdTr8X5MP3vmYORf78HMskBY5JqFVKy+WYi1IxNN++fTAVszfSJqmM/R5X1SSGqpkQBl4P6eflMTdud8+g/V5lXoqpNTH9+mJoyY5plyr0xdT0uac88WspFpWgWMVsw9TvdhJp0blVtsiXvgvSvVu2uGgEih0/JtJR0fGTkxte2qoT5tFw5gD/vZ8Q25hB9P9/AACx5qEc83ov7mTtnG5GG3hoB0282qp6R28Qh47GZlHZ9/YoRMzwXAiBV7uLE96OFm1oW2pux9IUalH/Wm9KCkR/39lUdVTZYV9KwMJJhHyFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p833WsOxjGEEWpUKPWpxdnHFs0t8JtXrvnTNCtTlbRg=; b=JY7MC/vmQz9O9L0T77Lat3iy35f0Iotu9MP/pu931eOfl907N5lMAGAYfMwkUG0MY70KCZNFYM3BJ9F2tZoL56u1W02Ff8yOjIFA5Bd20Y7p6VTk7spEwjjixL+mL/LqPMEouquTtworlD+Eb5hP2DzTMC7cgaQr7ktN0zAHeJ5IFUBQQkzKRlu0l31L/n92C5/mEEwTNELMzAMibFJKI0LIAym+xQrsy9LktabTyC/9deGgvoT55LwMKRVnfgIwK0adNEMpj6/RKIL2SOakOuujsPvduSpNnsuW3oao97jAJqZ/vrXqntK7UE8q6mg9xovBr4iOhs5glXkDRCZhiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p833WsOxjGEEWpUKPWpxdnHFs0t8JtXrvnTNCtTlbRg=; b=wgFiV6zlDjsvP0jVrp0nTcn21N2QwZz4JWxwrTYUEagEMth+CFTxlSNDwlRjNfsBGUhxuGXkq2DPAxz0Lw2xEvBDRUgNZhd6/jFJSod/o04qCGEhNJMmMd6K1yFs7nCy5G0j94fotDgY6T0/xx+He8jeofjgQrG1FxR97fssA10vpbpyIsO6NHKzM1eaF8WN9kPmjewf1L0KLZQLKC7VBJrHr5N0p8XamGBcYAVbYPcbWsxz87sTiagJFpLicxqLG9y81ifxMifg1apVg+s3FH+/0gPVo04Mp/2HD3zBDs4OYcoXTddIoEktpHEG0VvQhlm+JUVsXs1jz4f6kTPdjA== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v6 03/19] hw/i386/pc_piix.c: inline pc_xen_hvm_init_pci() into pc_xen_hvm_init() Date: Fri, 22 Aug 2025 13:11:49 +0100 Message-ID: <20250822121342.894223-4-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250822121342.894223-1-mark.caveayland@nutanix.com> References: <20250822121342.894223-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM0PR04CA0043.eurprd04.prod.outlook.com (2603:10a6:208:1::20) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|CH2PR02MB6505:EE_ X-MS-Office365-Filtering-Correlation-Id: 6dbb56af-adf9-4675-5c79-08dde1755e6b x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?VDlZRGdjUmREbjRNSk1GNDJyNklOclBlSW5obnB5SE5QMnRTSnM3WkFOdi9u?= =?utf-8?B?aFd3S1R4b3Mra3VNR2MxMW1CVlc4Q0NwOHFaNnRHQWlveW5IalJkWHlzMENr?= =?utf-8?B?dGN6WnA3RFB2eE1xQk5YRVZSaVdheEFKMjNQcnU0ZjBlRUJ3VUptV0d5MGg3?= =?utf-8?B?Q2JrTHNkMzU1T21EOExJY2hVOXIwVDN2ZzltQ0U4VzhoUnBCc0U0ajh4ejF6?= =?utf-8?B?SG45cDJ2L0dVVUdQR1ZvWFlQWWtyMnR4NDdkeVF3V2FSM2hLR0Q4OTgwSk9j?= =?utf-8?B?YWVEVHp6NGhmRG9wVEJ2YnhIWTFiNTNQV0tXWHpMSitkcmkwZHNISmtqZkhW?= =?utf-8?B?VXRRRDEvZ2VNZ0kvWStLZzNtdC8rN0kzempUeUVnSmxsYlhqVmpQUk0wOXcw?= =?utf-8?B?dnc5Y2hUT0dDeFd5RGJ5Tk1yejd3QUQ2bkpuZFY3OTUzbDBwZTIwSXJKZDVu?= =?utf-8?B?cTJhc21CeC94cThhakg4NFZIV1huaWtTaU00K09nZnFIcVFvcVJoYitpVzAz?= =?utf-8?B?eXF1UHNsK2JTQThESlMxVlhMTTkwNUVLQ1owWjRPNEtOaW1aa0k5UTVsSGZt?= =?utf-8?B?NkNwa0ZOLzVpd2diemNPd0xIRllCRUlna2hwMDhBeE1zNE05Uk1yK2hJU0dv?= =?utf-8?B?enBjTUtOWk1qb1RFQ1pSSXhCTmNPSzlEQ2h3V3N5eWYxSmphVTJHcDJYc3lT?= =?utf-8?B?QXV5WDJQVlZlZE1ybVdoZHdTZ3ZZNmd4ajdHWlpUYlU2b2ZCNE1HYW5RUzZt?= =?utf-8?B?bm13akp1S2h2TXlkM0l4eitFKzZtOTBDVTNVOVVIUUFmUGkzdXNqWGpQMlRx?= =?utf-8?B?S0k5bHg2cjFzVTZUSTBWLzhBWEhEb0VMV0R6SmtVbk9UMUo5UEFMa0gzdFA1?= =?utf-8?B?aE9LbEJBSzdxWEExN0ZONmcwUzJpZTQ1RXZ0K2lCVVdGMk8zWkJmZnhpaSs5?= =?utf-8?B?eU85bTl1dnNVSzQ1UFY1Q1JnUTJxTCtEWWhBaDZFQ3hzakYrK1Y1MHBLUmQ4?= =?utf-8?B?d3k4N3k5N3g2QjRrMklmSys5WUxRWVl3Qng4akY0eDRtckszZU55eUxoQW1F?= =?utf-8?B?MTFlckw1aXJIcjBWcktGVzBNejJ6WkxxaE9lbStYUHpXVlZKbGwyUmpjZGRI?= =?utf-8?B?THRrSi85S2pkTVVJZ281TXhja3l2WEQrdVpNVms1V2IyOVVUOVNjVmM5QVBZ?= =?utf-8?B?bkZ3WWtOa3d1YUxXakdxeGtkeVJ3Vzd5VE5UR0RoUE4wUFZSMW52UCt5a1ZM?= =?utf-8?B?WVFDcUdmY2h4cHVFUFl3Sys3a0NpMEpsY0lIbzhHUHhnVi9WWTRiK0xzNW0y?= =?utf-8?B?ZFhoYU9PRjY5QWVqS3Nsd1piOGloSjB5UmJFQTI2cXdkUWFKQS9NSVpGQ09U?= =?utf-8?B?NHpaRjRNd3QwZDd5dDlYOUZTbFBodXVZbUtSUUkyVUNseS9XQ0UyQ3MraHky?= =?utf-8?B?cDhkRG9xOGRaZVM4a3I0dmxuN3p6TnlmMHpXL2ZaM1RuaXRzUXdhVHB5Ullr?= =?utf-8?B?UnBGSXo0T0tBdjNTSVU1MXN1SXBkUHpkc3BPMjQ5WkQ4SjMxS294STAwS2FT?= =?utf-8?B?Tkx0WjY5ZGZYb1BOemt0WHZUYktRYktMazQ1UWh2Q0VIREN0TGZXczdUNURU?= =?utf-8?B?THdKVlVCYURlVTgvZC9sL1c3ancwQTRrdEVaMDQ3L3dyaXNpelRpeWJ0QmNt?= =?utf-8?B?TnJ2YkYycjBJQ1Jub0s1aUZ5L1I4bHg2Q3lUK2dWWTF1UXpUbTluNmhXS1Rk?= =?utf-8?B?UVFzQllMcTVkMXFnZVNnOXVrQTNwVTY1OVM4SG5uYUZxU0JLbTRYZVNKNGY3?= =?utf-8?B?bWFTaVUySC9ueTdOcTlFdkJzSHFsYU1WbGcwakc0dE1xYTh2Yk40aFVsWkxn?= =?utf-8?B?NUMvb3B5ZGR1THJRcnQ0UkJBc2xRcS85MHhXTm8vdFVKL1E4bEZ2aXplWGIx?= =?utf-8?Q?k8S7ec7Wki4=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R0lqUEFTeXo5UW1icVVXUDc2eUZCeUxpVzgySVhPdm9nNkRsU01Ebmd6SlpB?= =?utf-8?B?Nkh0R0gvOW4vV1RzczhFbm81ckQvdkQxK3VvVnFQQUszQnN6OXFQZDlDRy9u?= =?utf-8?B?djJuN2g2SjRvbzQzSXlHdWszaFdlall2WkRNMERUdVRuKzJlNTcyWVhsRk5F?= =?utf-8?B?RFBXSGlmZEhja05oTzBiUGROZHUvQy9oUk1PU1V1Zm5hcXRIMDZxckZrZ1Nn?= =?utf-8?B?S2pPVkdkbWNIMytLaEtDSnJEUy9UTlgzT2t5bWlpbm1SNnh4TC80R052VWxu?= =?utf-8?B?WHZZK1I1VDBkckcvdG1lQkJEOTRyQm4ybUwxcUdqdXloRUd1VjExNzJsNFhX?= =?utf-8?B?b2xYSXphZld4d1cvbE4wUk0vbElYNTRSVzh5bGE0djh3L0pQZTJ3b1A2a3V5?= =?utf-8?B?KzVFeXowajdnV0l1SXZNSkVPY0hPc1NSM3BuVFpaa0pKTHBQZ0xHcFVaeS9h?= =?utf-8?B?L2dVWkJ4UnN5WVBEOHBRU255NHdKQ29UUjFIc0dHdlRGNmxkd3owb0srRW5v?= =?utf-8?B?QlRMR1NXMkJkR2pSclhUTWZ2NnZOTHl1RjBnTERiQnI0N2pYa3hkaGpReFVj?= =?utf-8?B?dUlVSzVSYThmcmNIRVVkbnl6VzlERmNjRmw5eXAvbHl1dnRBcGJxeG91OEhr?= =?utf-8?B?T1c2d2ZsQ2RSTTFqKzVwbmtxdm5IN2NQYkw5Q1lycnlqMXJJZEZ6Mkpka1Z3?= =?utf-8?B?andzby9Db1BlRVpGTG9Cb2VvRkc5ZGcwejIxTXVnbWUvaGQ4SC9Jd25meUlY?= =?utf-8?B?UkNNT3FXMnAyT0Y2aXRCZWo0UzNtd256a2FjN0gxWlRtdldzdkNQdW5BTGYw?= =?utf-8?B?RTFIKzlDQWtyV1ZjR01wNStWaGJGeTFzNVZ6eWdtU0tDdmt0algyaCtRaDV3?= =?utf-8?B?VFJGTll5bXJTT1A1N1JiVlZRYWVYaEo4WWxzY2xNcDVlNmxweEVJeC93REt6?= =?utf-8?B?M3FHeE1iSks2QW5EUDJBTnBPa2VYWlovTVlWS1pYRjE3SlpOaS8yMGFudSto?= =?utf-8?B?QUMxOTBOZUNaWStta1VhMGJTeGFnYkUyZFN6U25aRWZIS1Q4VzlPZmdyNWdp?= =?utf-8?B?Q290SlE5bzk2UW53YzhyQnhIL3hTSFF2TEpYaHIrckMwT0RtMUg1UWlZOHNK?= =?utf-8?B?RVZ0N1ZYb0NlRGp1OHE1UFRIYVU4bEx6ZFJEM1ViZDlmL3VuOEtzN2ZaaXRk?= =?utf-8?B?ZlBIM2sxYnBzOFh5WGkxbXVyazhHRzZZSlhESSt1RjJuRWFtdGsvSzRwVUhy?= =?utf-8?B?L2Fqdi9MQmYrV3FlcDVJZ0t3WGQ3OERWNEZHS3dPcFBrMklMUTNFekw2WlJL?= =?utf-8?B?dGJlM01kdmZWMzh1dER4ek1CRGtoOHpOVjZsMklVeC9reTZQTEs1RGQ2U2hR?= =?utf-8?B?TjloNHc5WjFSTGVTNm1UWVNMM1JkMFpweUtnU2tTS2JGZUs3OGNKWUdIbTd6?= =?utf-8?B?bEQ3WmpEMTgvQXpVK2FkdjE5eGdvcTA5QTZKNDU4cm1pS1czcmNUY3pHOUtU?= =?utf-8?B?TDJCRm1mR0RqdDhjV08wd3lCb0J0RjFkM1hZdkRYd0tqTytnMWx4WnA3MERW?= =?utf-8?B?THlqaE9zUTRlMENaUFEwVkl5b3BodndqRW9OQ25Cd0VRbEE1Z0JTLzR6U0dn?= =?utf-8?B?eFNMcUp3T0tFdktWaFloaEg4UmlYVzFxZ3JSREtCWFlnQnZ3dmlmMG1Mc0Vt?= =?utf-8?B?aFdMcVRVUCsyYnNPa0lsNnFkZjNTRWNaaW9FRzg4Q3ZJTmlWNWtraVVIeVN0?= =?utf-8?B?QzFFTjdQcVBJZmVXaElncmdCbE5oWkJJd2dodmdjdmQ2SzduUEZST1R5Q0dz?= =?utf-8?B?YkNFSmpVdWVmdlBvQ0UyaTFQbFdwdEJsV0hhTE9iZWx4RHl1aTk0VG9FaXZx?= =?utf-8?B?ek13anNMdU5OVm9VdGhjUU1lUmhJOHM0eldGc0lDcWFkR2xKR3NjNnJjbkE5?= =?utf-8?B?cXREQ1ZqN0lYbzNBdCtJODRpSDUwdzIrRy8xZkQwd2xRSEdnYmc5a2dtUzJj?= =?utf-8?B?ZWhOU2hEV2xnd3dqYkxzZDNPb3VGanEzKzhmZTA5MGp2d1gxLzR0dVl5OXpW?= =?utf-8?B?VkI4eW5SRXQ3U0xpZmtSeEorRVVIM2JCUEFOYnJrQWk3dEkrdFR4bTJhZTJi?= =?utf-8?B?SEpRZUwzT3FLQ0h5WWFkaFgwTnIybGtPTGE0eVhIOFJkUGU3YnZUSUlMZHdG?= =?utf-8?B?Y3c9PQ==?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6dbb56af-adf9-4675-5c79-08dde1755e6b X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2025 12:13:57.1061 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ikGb1JTM3Xpif7O4k3aYTIzyL7n2kNyuDYz/cFUyEU5A8E2arz2LoCeCHnL/nG44gA8PRFVwzbEz9uHeiRqTsbs8OCQ/rosu8xcmF85Vy3o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR02MB6505 X-Proofpoint-GUID: VRG6Wx73kdJshPDzIPbeu8hxAOPnR7F0 X-Authority-Analysis: v=2.4 cv=CoXmsn4D c=1 sm=1 tr=0 ts=68a85f06 cx=c_pps a=mCqc6FuyCKsbe1oGyU/0mQ==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=0kUYKlekyDsA:10 a=KKAkSRfTAAAA:8 a=64Cc0HZtAAAA:8 a=Nl9WzMjVwZFxynAfEmwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 a=cPQSjfK2_nFv0Q5t_7PE:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODIyMDExNCBTYWx0ZWRfX6cdVl2f+cl0b yNVlVoDgGYu4sMPi+xFOCzh2mFK7RQz2h6kRhtZvbkzo06u1uvj5zTybPI8MbKzID8BGLjkGL1f WnTzRBqsc56iAc5O9nNDw4ieAtgOt9WHa7VT/v8iXCFYollPUPQwpTuS3BI5d1xVf9KPrQ5SZ/y hFjXsO1tInj0efQXtq0Dv4/oPympddxD6RY8QhncYNgB6dFNnJIjtT9VjSKVNsC8O/Sm7cB9JKc agnYLNWPkaVFmd4MmcknQW/C7Xtx6sSg/mREliTzvzNcJ/3Qf+XKa1gHo0ZRQ7bh3C7mGKMmqjY BxLUldm1ItrUuh0xGLV8H+miiIX+sB6TrdnCxG7SQ2jkd1XIXy5w9wvGThUMio5L+15qu/+Ifpb Z4/YdBnVchX8gC6P1Y6HIQeeNNq8/g== X-Proofpoint-ORIG-GUID: VRG6Wx73kdJshPDzIPbeu8hxAOPnR7F0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-22_04,2025-08-20_03,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1755864998049124101 This helps to simplify the initialisation of the Xen hvm machine. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Mark Cave-Ayland Reviewed-by: Xiaoyao Li --- hw/i386/pc_piix.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index bc8fbe46a1..071bf7412e 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -453,14 +453,6 @@ static void pc_init_isa(MachineState *machine) #endif =20 #ifdef CONFIG_XEN -static void pc_xen_hvm_init_pci(MachineState *machine) -{ - const char *pci_type =3D xen_igd_gfx_pt_enabled() ? - TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE : TYPE_I440FX_PCI_D= EVICE; - - pc_init1(machine, pci_type); -} - static void pc_xen_hvm_init(MachineState *machine) { PCMachineState *pcms =3D PC_MACHINE(machine); @@ -470,7 +462,10 @@ static void pc_xen_hvm_init(MachineState *machine) exit(1); } =20 - pc_xen_hvm_init_pci(machine); + pc_init1(machine, xen_igd_gfx_pt_enabled() + ? TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE + : TYPE_I440FX_PCI_DEVICE); + xen_igd_reserve_slot(pcms->pcibus); pci_create_simple(pcms->pcibus, -1, "xen-platform"); } --=20 2.43.0 From nobody Sat Nov 15 03:14:59 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1755865172; cv=pass; d=zohomail.com; s=zohoarc; b=SSxCyib2dDMRh9CqnEVUATh+G+VLLpSpRww9JmtjmcmpHrLd500/Ao0IhZFdgP9pXVliwE1qpHZ1thWs51rBpTAM1JCl/Aw1NC0KE0mIFPCOTom2nnucgtEuiRrQdaeFpZor6eRkqLvGUO9a05YNme+2ajKm9/E69FgBESYEsOc= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1755865172; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=DwF1VtlVSnRcAdnsRSy2kAhakyuvuz9Nu5UTEr4ZGOU=; b=nhP/hL0yjiS0IpTPBbDu1ScEyY3zlJcavGtEoT4QCnQm0V8tlKU2CyWqZrHmp7+3ND4JtwOaiEWyyobtled1h9G8SyIyNLBhGonF5+3zUI4WWkxLN6Z4i4+YCo/W9nvQzirY6DQ0N69q6DctzhqxKb+48JZ1YaXpwij8EOV6xNU= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17558651724851012.8261115501426; Fri, 22 Aug 2025 05:19:32 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1upQeu-0001ay-Rv; Fri, 22 Aug 2025 08:14:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upQep-0001Yt-8y for qemu-devel@nongnu.org; Fri, 22 Aug 2025 08:14:11 -0400 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upQel-0000em-0O for qemu-devel@nongnu.org; Fri, 22 Aug 2025 08:14:09 -0400 Received: from pps.filterd (m0127840.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57M7qHtr676687; Fri, 22 Aug 2025 05:14:03 -0700 Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11on2124.outbound.protection.outlook.com [40.107.220.124]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 48mye5qema-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 22 Aug 2025 05:14:02 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by SJ0PR02MB7725.namprd02.prod.outlook.com (2603:10b6:a03:322::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.24; Fri, 22 Aug 2025 12:14:01 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%3]) with mapi id 15.20.9052.014; Fri, 22 Aug 2025 12:14:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=DwF1VtlVSnRcAdnsRSy2kAhakyuvuz9Nu5UTEr4ZG OU=; b=NFtyFGg1larMVRN17sDAwTppRm0QvVzIAkPbZhVkQ9faKVd73VQDaxy3O x4jc2dN1dSjAkmr+7obxjqZNIwvEzYdcXKJjXe5aVeAzmY/OKxyVmVj0sv1lU1Yv pe5kBTWK23axKF8B/be89fVkxj1sA2CJSvFN5OjqEM91irplpmE8cQ/cCzhSV8OQ MpYJM/0ft145oYpWjbx4AGKF11S1Vld73eN9YEln30GQOQzlU4bOhYL58BZKWih5 B94za4w/N/utcAPwR8bl5QNmBiPBKDQm86HnGMqFeLUNfwAdiYKnOBB5GSJUHt2x p6EEh9svqtI3rbtNIjqqrxfS2Nhsg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=j8FsWQyaZo3il4PJ8+PG5wIfc5+feh3MMo4fJH3JDzdV/b+2DmxRl74ewOAArqMW9fECITIHAMWdkROeyvrkxtHh86kXggObt0id6zEdwZE2wUxtw2HG6G0qi2lL10m5IZpdtaiw/nUNgvqtOlhdvEleY/SXQaFcHp6iWFekJD7W5dHA+ZxrvJucyyr9j8P9RJdBZORpbhHZV0OHtxO8BNiOvtFk6As3nVAI8AHV0edJIXkmtPUX6eObTzkKAcLvKUEz0VTChwuFh0bBNtufxkz2n/wTKMbv5Dal3SPAGefn76JBBV/IOAACXTnXy0uoamEfJm9OuNuRvTT/Akojqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DwF1VtlVSnRcAdnsRSy2kAhakyuvuz9Nu5UTEr4ZGOU=; b=KIQpIwjnWob4X2PVpPNah3ZdbVtKtRhTA8SpfvG4pKluEs4SLsjVsMGIYhxVOeSRXbtTUBr0hMi48dikHhCLcFTmDBYZPkon4NCRsEEAy+v4ZcsVARBN6r7OObpNxPY5qoNP1BDMNtqUAlq9/D7hgI+/fLbsWT3BKoLgr2XRLEoGGn0u/MYjGERQqIjfUsJCPIZZ5IvxWJ0nO7caYPae4rkddCGU+dtVStI4mqZjXe7jAlEb+0PozxJhoMVDGmTQv5SJIL7ySIl3PC981yIfbnHNJv/jN1o2wFUGI8lwL/n3KhV9N0ml9dbTI5IjtVEzDZn5/tsFcYOCYn49HMCUqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DwF1VtlVSnRcAdnsRSy2kAhakyuvuz9Nu5UTEr4ZGOU=; b=GKqEQEIEE5N+r+QkVRf9npm6/z5O1qZxvZVhtl5MHBFA+Bt5GwndCPk6UI/EL8aNV6IyrLXr3ZRcivJVO1ScLK3OMNhzcnX3tfmYcjXcBYtUiuPZFod2W6e1bVLc7iHH9bROtm4r+fN+wvmKvb8AQgkjswSXBhyfuns+0TE8uE/MFoA4r6HAl9tQhTOMuJIX9FC5Niq8pqnqevWRJTWFyMwcAj/i47s/U8GmfCRZR8SoMvUS5EC/qRWxQaWhmUHd6RFinhnBQN724NdyYiTomMgGfKR3Yux/W52lOSoKHpV0XspnnXhNJ3rmPMzSR+zH4Q2NYPXbIajsUMR366ZYOw== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v6 04/19] hw/i386/pc_piix.c: duplicate pc_init1() into pc_isa_init() Date: Fri, 22 Aug 2025 13:11:50 +0100 Message-ID: <20250822121342.894223-5-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250822121342.894223-1-mark.caveayland@nutanix.com> References: <20250822121342.894223-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS4P191CA0024.EURP191.PROD.OUTLOOK.COM (2603:10a6:20b:5d9::18) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|SJ0PR02MB7725:EE_ X-MS-Office365-Filtering-Correlation-Id: 5a753473-e44c-49e7-9e49-08dde1756081 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?SWpiN0Z5bXpYcytmVC9pejVZVzRYMndIb3krMnZYeTIyelFuQ0toKzlMYUVQ?= =?utf-8?B?alhRRXFXeTZjaDI0Q1JDUEFKVytvankxbmdrdDE3aCs2NTNKVEhxN2F4ZWZU?= =?utf-8?B?aVN3VW5ndmhjbkZBRlYzOVJOdEFFTWk2eDNPNzNFK3A1NmpkRG84cWEzRGFw?= =?utf-8?B?S3UwYnV0Z3BXb1pSeTdJRUwra1QxVE9TN3JNOEZMZzJQdjMvY0ZGenZLMEgv?= =?utf-8?B?a0hpOXRyMEJWNUljcU1HQzQzUmJWMUF3MmlxNmNYSlZjQTk4cXNBSWVRUVpi?= =?utf-8?B?bHE3TERWVkJmT2hXZDI5SGJaWi8ybE94aUkrckNWUnhNTXRDaDdBT3YvVXpv?= =?utf-8?B?dVVkdW9UMFRwK0VpMFozOC91Y3lNT3p6ZFAvTWNqR3JwZXg4NUVzNUVWVVB4?= =?utf-8?B?RXZqM0p5SkJhY0VvTlpGTzAvVWpUK3BYbzBWV2NhTGtBMkxxcjVZSXdTV1FN?= =?utf-8?B?aVU3RG93UWNzakJjMkp4VVZ6eVNrSVl3VEZ2OURLb2R3NXNvZ1BRMmhUTDBN?= =?utf-8?B?cml5THpwcncvc0dHZURKRXVSOHBlY0F5S08waXhKc3pDRnpOU0oyTkxRR0xY?= =?utf-8?B?YXFOV3JXVjMwdVI0WndseEp3ODd3QlN2b21RU0QrREIzZ0NMMEc5VEJkQWFD?= =?utf-8?B?T2NaYzlXNmpieDFiNUVwY3kxZlBCNDErQjU3QXN0UmNjbENHWXNUcEx2UzA1?= =?utf-8?B?NmpEUElLSmc5M1lsNUZ4RnBxU1laSWNPMkRTY3hkNXVoeFl3Q1Nja2VwL0Zr?= =?utf-8?B?K0pickNibkpDMTFDaGdweTZGSlEreDZ4NlplTnVnMjBZaFQ5KzhUd1pYcElJ?= =?utf-8?B?SnNBbFp5cGhxTkV6Wk1NMzhwZEh1d2xmdWRZVng2QStvb2t4eUw2K1BGRE5Q?= =?utf-8?B?NUtwOTNraU5RdkxNMFNmT2MyZ0pQYUdWd0EzdFBXTjVreXYwbXE4UmloRDA1?= =?utf-8?B?a0RZRzhiUnlGMkE3T3lPdVFyaDZFcGRIT3M4b1h0Y0NYblZPV2dlNlFJVENY?= =?utf-8?B?TlNQb1djRG9lVFBabThqK296eVJnSzU5ODZEQVFQa0lNS2xLalUzOVhjdHg3?= =?utf-8?B?YTRxSHNIWU1ocyt0ZlJDUkg0cDc3eFpIdHlEblZHN0tmUmwrenBrdU1LaDV3?= =?utf-8?B?MldnQUNHWjgrSS9oY2Izd2M0NjUyNzBEMUFYOG4zaEZkdTVjV1NkRVNpUFo5?= =?utf-8?B?by9hbXFFZy91aWMydGN3d29DU0hvNk9CQ0dFMkN2a1VrckJsbDlQamxybWxL?= =?utf-8?B?ZGRIaU9peUxLOHRpb2NrMncySTVKY3lSeHE1eHgweUZ3ZkxPaERLcnBTRkFM?= =?utf-8?B?a2NSSmd5dzB5UWhvbjRrRFRWZXRjQVV0NlNITHZ5azFwd1BlMkRVSGdHWFB4?= =?utf-8?B?amp3dEx1SGFJWnZqd2pEc0I0QkdYa0FiU0RZblJPaml2ME1GTUhXNjBobDZw?= =?utf-8?B?V2NvQXIwYWpvZSs0dTZLdFI5aFRCWlpWSXR3ZzhMNkFaR0thdmVmRTF4cG5n?= =?utf-8?B?RXhSaUJrV3JYYURRam1tbkZpQ1lRa3RxVDZETDI3Y3hSOFFZdWl3bVlKUXNh?= =?utf-8?B?Q2lzY015M2xvYnR0RW44Vm56WTY4STNHQUVCKzB4ZU1hd2hyV1RNRTB3Tjkx?= =?utf-8?B?d0xoSjU4S0o5RFdpRmVJdThxL1ZoYUFCeTJuQk1mU2ZXZ0ZWWmlSVXFlVkV1?= =?utf-8?B?M29YVkZ5NEpCQnMxU1ZQczU4QjdFbFluWkJPNWVDSUlwRGxwejNvaFlIS0pq?= =?utf-8?B?Q2hpNDh1Nm51N2crWko2aHJuVUY4enkzSGJHSlFENFFvWDdod0t5OUdWTFV3?= =?utf-8?B?NHNyVVRXZzIxalNzcDdXaHJvM2tzdVNUTDJxRG5aUExVdVE5bEk5LzJBR2tm?= =?utf-8?B?WmQ4S0pETjdxWjZ1eUpKSVZza1p3d21nYXlRalVEcm96K3FxemJNd0VaVGg5?= =?utf-8?Q?jGzxBMLqwYw=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dTVxMnZ4WVRzdWViSVNPY2lTMHZ2enNOWW1iN0pmVUdjYXdDRU54RkVaWDhp?= =?utf-8?B?UkV4am9LQ1lwRzJQSzFhd2dtRkxtbXBrRnkwblF3bDR3Z0lEVEh2RXpvNHNH?= =?utf-8?B?aEQwVHdXZVo5VnpFTHYyWEh0dXkvaTRCNWVrZksyZGZRUE5mS091N0ptczZw?= =?utf-8?B?WTlWS1lPM214ajZVMyt5UWlESFl1UVAzUzFacnlpdUNndnF3c1pBa2VQdytI?= =?utf-8?B?K0EwTEJrSTFsakdHNy82cFVGU0dJa3JORWo3VkorRkZhTDRyNTljMnJGcHNP?= =?utf-8?B?ZjlwbkRycXBVaG41MEsrbHlGQjJnYjIxTGJYQ0xNRkk4SFhqWFBSZDVVNkFO?= =?utf-8?B?c052L1RNUVREbXJHZlFUdWw5NCt6c2h3UDgzcjErZDJNRE11OUszMEVWV1BX?= =?utf-8?B?dmxDdkdHWU1LNTF3WFFJeE5LZXhYcXlMQ3E3eWpFWW5NMTdtZ1pzN29XZnk4?= =?utf-8?B?VHVOVDdVR0FrOGwwN28rU3NzRC9DWTRwOEtnR1ZkT0ppTmthQk9ITjhQYkwz?= =?utf-8?B?bExaTS9NR0t0U2JjelRpM0cvMStUM2hzNFhZYzA3L0pmVk9ISkdxMXMrT21H?= =?utf-8?B?a3pMSHBWSGsxN25XVXkzb2dnT0FsSG9KWEJqMmNYaDc0YUxMaCs1RGJ2R0ti?= =?utf-8?B?MFJ0T1pwUGtKVG43aVc3dXBocFE2OWlmR1JYaEhrYUM4cm9Pa0RCNTkxVktP?= =?utf-8?B?YzdHRDRmOVc1a2cvZHJZMWZNdDA4QzFYSkNHODNqdW1XWllGajl0NU14bzI4?= =?utf-8?B?eHpadEx6dHQ0RWZlSHQ3aEFucGZodGRQUnBXcTVpd3oySkxhempIN1pjSzUy?= =?utf-8?B?WFlYT1AxeitHaC85c0UvWWk5d2U1NThDVWs2cjFoYzNqTi9ONWROYUR1TE00?= =?utf-8?B?bVRPZFh0d21NTmVQMFRCLy9lbTVZZE9SUEtxWGZibzdYbXd4YmlJdHphY3lO?= =?utf-8?B?NCtkM1g1S3JubnAwRGp2em9WQU1OZW8xQVlBZE9TUkRpOUJhUGhSeGZvV0Vq?= =?utf-8?B?cVJXMStkczJkejdWMm5YeXZMS29aNE9pcWJleG5MOUVWVGYrNk00YnA2TURV?= =?utf-8?B?eks5MjloNWl0WW5aQ01XUkZpMzdDSlFwTkdGVGZsSUxUL2lnZFF0VTAxRDFC?= =?utf-8?B?bHkvd0JuWm1tVFhqYUdMYVVaYnhRNHhkTzRJaDRNc2tuY0ltdnJkVFpYQ3M4?= =?utf-8?B?TzFFNllta1Q3eDdUWkp2V0xQdmMwdVNuZFBMY2lpN2xqL21EWW9pRDBvWmR6?= =?utf-8?B?OW13ZW1uVXFJeHVJNHFXanFaZ3NuQ3lTVTUzWldzSmowMFIzenVXOXl2YWg5?= =?utf-8?B?RHNEUWFwVk96THIwejlyOU1QTEcxLzhUQlhzRHhOSXVzTjVsMHJwYWtWQ3Q1?= =?utf-8?B?TmhrL3NWYWRFalhnRzUvQVVwcXhPeEQ2cCsxQWJBR3M2Um9UKytibEpPV0NL?= =?utf-8?B?UzcvQUFSZHEwUThpVTdLTytSWkVONXhQNnhEWWNneHlyN1pHYWwzNHY1K2I1?= =?utf-8?B?R1RlaldTK2tEWnBTMDFkcEw5eCtoY01tbTJGSU9MRXQvNGNKR1dnZWI3bXEz?= =?utf-8?B?WmVnRElOdnNubXJhdDlaSEtmeWYrRTdRVllWZnZha0dZV2Y5c2NpdkFVQkw5?= =?utf-8?B?NE5DYnduaDJTOGhhRlBTUDJFcHZuRWJaWXlNaEZ4OWZ0Y3gzc2dKeHEvdTc3?= =?utf-8?B?UDRBZWdyazl5bURCbkYyUDBVTUsvNTNrdndTRkU1eHI3eWZaTHdXRHZyQ3FQ?= =?utf-8?B?c2pHYk9XNm5kZlhhVzRIcFNwWTN1YTFsOUVnUEZ2QlE1TmVkQ0FlZlIzYi9H?= =?utf-8?B?T0c1N3R5eHh4UUZSeEtLeHkzaFlGYWgxdXRvZ2VudytweEh2cTVVbG9Hbjg5?= =?utf-8?B?aUhjRE5xTUtGSGJKTm5KTW8zZjlGMnpaTGpmYUNFZ2RJTXBqdjQrcUpUVXdS?= =?utf-8?B?SklWZTFCY05seGdRcVlKdXRERlhFTWpRSFJpQmhEcTZwMzF4MjBiYWVnejZp?= =?utf-8?B?MSs2TmhqbDhLNUl3QytPaEZxQTE4YmlLUktoeXRDb01QOXdJcDdUYmorRSt3?= =?utf-8?B?UHhKcW9KSXVVckRNNk9yRGo1eWxabEtVaUJpTEE0SlFhQVZlcm92eXpKWm4x?= =?utf-8?B?TEpMR014ZVFaVHhXc3JFbHlVaHJyVDZ1NnpDZkFnT0FuSW5lSGowT1AxMmNQ?= =?utf-8?B?TVE9PQ==?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5a753473-e44c-49e7-9e49-08dde1756081 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2025 12:14:00.5097 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1o/Enbq/sUVNnTEzbbabFGDsA03msA4R1BEuudjajio7BenTO3B38II/Eebk3lzvU3LImzy1scyG9rC41iNWDVMV0fLZgsFlsgALUapKRGc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR02MB7725 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODIyMDExNCBTYWx0ZWRfX+lNZgeejek8h FQgPAbikyFbW787aRKjPUs4GbgXcubwiltLHC85+bkPSKjBPZBlsTcm44MJSOG/kyzFIhBRdl82 PjToetg/KCwSBsAG1FcMtoKKc7Xw5jcWOtjSIbEsHbo+D5qHy66urUCuPxVjlm7bGjCdRYsPneD 5LkqlDxX4wjVAEYDPYksVQ9NPl4Ps/oPDKXf+XfD+MIkN0aN6CrsoDgH239FcFL7OroOnJSOBM6 d9oIvaUJcL23y6Lz5EVj96KJhyAsOU4j5cLy3PguoxvBHIK9fI0t9O6nUSeVLJxpe5TdbEP5AsF oKxEHgLOn47xBia4Ne6uI7h/9E9CEvTSyafSsdRAPPngBlTLT0NXDhHxGNfYNRrtedFdKsDMEi/ TIsIEYy4stkYQ1B76GcRS3dqkVNQvA== X-Proofpoint-GUID: Zwy01-pncgumBGA1sWtXQ-n8VPWkbZ7B X-Proofpoint-ORIG-GUID: Zwy01-pncgumBGA1sWtXQ-n8VPWkbZ7B X-Authority-Analysis: v=2.4 cv=bt4VxEai c=1 sm=1 tr=0 ts=68a85f0a cx=c_pps a=vjxJhJQncZFfyFE+Ha1XfA==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=EScErfUSVzH1iicdKiYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 a=cPQSjfK2_nFv0Q5t_7PE:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-22_04,2025-08-20_03,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.151.68; envelope-from=mark.caveayland@nutanix.com; helo=mx0a-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1755865173652116600 This is to prepare for splitting the isapc machine into its own separate fi= le. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/pc_piix.c | 261 +++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 260 insertions(+), 1 deletion(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 071bf7412e..5b97ad2cea 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -435,6 +435,87 @@ static void pc_set_south_bridge(Object *obj, int value= , Error **errp) #ifdef CONFIG_ISAPC static void pc_init_isa(MachineState *machine) { + const char *pci_type =3D NULL; + PCMachineState *pcms =3D PC_MACHINE(machine); + PCMachineClass *pcmc =3D PC_MACHINE_GET_CLASS(pcms); + X86MachineState *x86ms =3D X86_MACHINE(machine); + MemoryRegion *system_memory =3D get_system_memory(); + MemoryRegion *system_io =3D get_system_io(); + Object *phb =3D NULL; + ISABus *isa_bus; + Object *piix4_pm =3D NULL; + qemu_irq smi_irq; + GSIState *gsi_state; + MemoryRegion *ram_memory; + MemoryRegion *pci_memory =3D NULL; + MemoryRegion *rom_memory =3D system_memory; + ram_addr_t lowmem; + uint64_t hole64_size =3D 0; + + /* + * Calculate ram split, for memory below and above 4G. It's a bit + * complicated for backward compatibility reasons ... + * + * - Traditional split is 3.5G (lowmem =3D 0xe0000000). This is the + * default value for max_ram_below_4g now. + * + * - Then, to gigabyte align the memory, we move the split to 3G + * (lowmem =3D 0xc0000000). But only in case we have to split in + * the first place, i.e. ram_size is larger than (traditional) + * lowmem. And for new machine types (gigabyte_align =3D true) + * only, for live migration compatibility reasons. + * + * - Next the max-ram-below-4g option was added, which allowed to + * reduce lowmem to a smaller value, to allow a larger PCI I/O + * window below 4G. qemu doesn't enforce gigabyte alignment here, + * but prints a warning. + * + * - Finally max-ram-below-4g got updated to also allow raising lowme= m, + * so legacy non-PAE guests can get as much memory as possible in + * the 32bit address space below 4G. + * + * - Note that Xen has its own ram setup code in xen_ram_init(), + * called via xen_hvm_init_pc(). + * + * Examples: + * qemu -M pc-1.7 -m 4G (old default) -> 3584M low, 512M high + * qemu -M pc -m 4G (new default) -> 3072M low, 1024M high + * qemu -M pc,max-ram-below-4g=3D2G -m 4G -> 2048M low, 2048M h= igh + * qemu -M pc,max-ram-below-4g=3D4G -m 3968M -> 3968M low (=3D4G-1= 28M) + */ + if (xen_enabled()) { + xen_hvm_init_pc(pcms, &ram_memory); + } else { + ram_memory =3D machine->ram; + if (!pcms->max_ram_below_4g) { + pcms->max_ram_below_4g =3D 0xe0000000; /* default: 3.5G */ + } + lowmem =3D pcms->max_ram_below_4g; + if (machine->ram_size >=3D pcms->max_ram_below_4g) { + if (pcmc->gigabyte_align) { + if (lowmem > 0xc0000000) { + lowmem =3D 0xc0000000; + } + if (lowmem & (1 * GiB - 1)) { + warn_report("Large machine and max_ram_below_4g " + "(%" PRIu64 ") not a multiple of 1G; " + "possible bad performance.", + pcms->max_ram_below_4g); + } + } + } + + if (machine->ram_size >=3D lowmem) { + x86ms->above_4g_mem_size =3D machine->ram_size - lowmem; + x86ms->below_4g_mem_size =3D lowmem; + } else { + x86ms->above_4g_mem_size =3D 0; + x86ms->below_4g_mem_size =3D machine->ram_size; + } + } + + pc_machine_init_sgx_epc(pcms); + /* * There is a small chance that someone unintentionally passes "-cpu m= ax" * for the isapc machine, which will provide a much more modern 32-bit @@ -448,7 +529,185 @@ static void pc_init_isa(MachineState *machine) warn_report("-cpu max is invalid for isapc machine, using pentium3= "); } =20 - pc_init1(machine, NULL); + x86_cpus_init(x86ms, pcmc->default_cpu_version); + + if (kvm_enabled()) { + kvmclock_create(pcmc->kvmclock_create_always); + } + + if (pcmc->pci_enabled) { + pci_memory =3D g_new(MemoryRegion, 1); + memory_region_init(pci_memory, NULL, "pci", UINT64_MAX); + rom_memory =3D pci_memory; + + phb =3D OBJECT(qdev_new(TYPE_I440FX_PCI_HOST_BRIDGE)); + object_property_add_child(OBJECT(machine), "i440fx", phb); + object_property_set_link(phb, PCI_HOST_PROP_RAM_MEM, + OBJECT(ram_memory), &error_fatal); + object_property_set_link(phb, PCI_HOST_PROP_PCI_MEM, + OBJECT(pci_memory), &error_fatal); + object_property_set_link(phb, PCI_HOST_PROP_SYSTEM_MEM, + OBJECT(system_memory), &error_fatal); + object_property_set_link(phb, PCI_HOST_PROP_IO_MEM, + OBJECT(system_io), &error_fatal); + object_property_set_uint(phb, PCI_HOST_BELOW_4G_MEM_SIZE, + x86ms->below_4g_mem_size, &error_fatal); + object_property_set_uint(phb, PCI_HOST_ABOVE_4G_MEM_SIZE, + x86ms->above_4g_mem_size, &error_fatal); + object_property_set_str(phb, I440FX_HOST_PROP_PCI_TYPE, pci_type, + &error_fatal); + sysbus_realize_and_unref(SYS_BUS_DEVICE(phb), &error_fatal); + + pcms->pcibus =3D PCI_BUS(qdev_get_child_bus(DEVICE(phb), "pci.0")); + pci_bus_map_irqs(pcms->pcibus, + xen_enabled() ? xen_pci_slot_get_pirq + : pc_pci_slot_get_pirq); + + hole64_size =3D object_property_get_uint(phb, + PCI_HOST_PROP_PCI_HOLE64_SI= ZE, + &error_abort); + } + + /* allocate ram and load rom/bios */ + if (!xen_enabled()) { + pc_memory_init(pcms, system_memory, rom_memory, hole64_size); + } else { + assert(machine->ram_size =3D=3D x86ms->below_4g_mem_size + + x86ms->above_4g_mem_size); + + pc_system_flash_cleanup_unused(pcms); + if (machine->kernel_filename !=3D NULL) { + /* For xen HVM direct kernel boot, load linux here */ + xen_load_linux(pcms); + } + } + + gsi_state =3D pc_gsi_create(&x86ms->gsi, pcmc->pci_enabled); + + if (pcmc->pci_enabled) { + PCIDevice *pci_dev; + DeviceState *dev; + size_t i; + + pci_dev =3D pci_new_multifunction(-1, pcms->south_bridge); + object_property_set_bool(OBJECT(pci_dev), "has-usb", + machine_usb(machine), &error_abort); + object_property_set_bool(OBJECT(pci_dev), "has-acpi", + x86_machine_is_acpi_enabled(x86ms), + &error_abort); + object_property_set_bool(OBJECT(pci_dev), "has-pic", false, + &error_abort); + object_property_set_bool(OBJECT(pci_dev), "has-pit", false, + &error_abort); + qdev_prop_set_uint32(DEVICE(pci_dev), "smb_io_base", 0xb100); + object_property_set_bool(OBJECT(pci_dev), "smm-enabled", + x86_machine_is_smm_enabled(x86ms), + &error_abort); + dev =3D DEVICE(pci_dev); + for (i =3D 0; i < ISA_NUM_IRQS; i++) { + qdev_connect_gpio_out_named(dev, "isa-irqs", i, x86ms->gsi[i]); + } + pci_realize_and_unref(pci_dev, pcms->pcibus, &error_fatal); + + if (xen_enabled()) { + pci_device_set_intx_routing_notifier( + pci_dev, piix_intx_routing_notifier_xen); + + /* + * Xen supports additional interrupt routes from the PCI devic= es to + * the IOAPIC: the four pins of each PCI device on the bus are= also + * connected to the IOAPIC directly. + * These additional routes can be discovered through ACPI. + */ + pci_bus_irqs(pcms->pcibus, xen_intx_set_irq, pci_dev, + XEN_IOAPIC_NUM_PIRQS); + } + + isa_bus =3D ISA_BUS(qdev_get_child_bus(DEVICE(pci_dev), "isa.0")); + x86ms->rtc =3D ISA_DEVICE(object_resolve_path_component(OBJECT(pci= _dev), + "rtc")); + piix4_pm =3D object_resolve_path_component(OBJECT(pci_dev), "pm"); + dev =3D DEVICE(object_resolve_path_component(OBJECT(pci_dev), "ide= ")); + pci_ide_create_devs(PCI_DEVICE(dev)); + pcms->idebus[0] =3D qdev_get_child_bus(dev, "ide.0"); + pcms->idebus[1] =3D qdev_get_child_bus(dev, "ide.1"); + } else { + isa_bus =3D isa_bus_new(NULL, system_memory, system_io, + &error_abort); + isa_bus_register_input_irqs(isa_bus, x86ms->gsi); + + x86ms->rtc =3D isa_new(TYPE_MC146818_RTC); + qdev_prop_set_int32(DEVICE(x86ms->rtc), "base_year", 2000); + isa_realize_and_unref(x86ms->rtc, isa_bus, &error_fatal); + + i8257_dma_init(OBJECT(machine), isa_bus, 0); + pcms->hpet_enabled =3D false; + } + + if (x86ms->pic =3D=3D ON_OFF_AUTO_ON || x86ms->pic =3D=3D ON_OFF_AUTO_= AUTO) { + pc_i8259_create(isa_bus, gsi_state->i8259_irq); + } + + if (phb) { + ioapic_init_gsi(gsi_state, phb); + } + + if (tcg_enabled()) { + x86_register_ferr_irq(x86ms->gsi[13]); + } + + pc_vga_init(isa_bus, pcmc->pci_enabled ? pcms->pcibus : NULL); + + /* init basic PC hardware */ + pc_basic_device_init(pcms, isa_bus, x86ms->gsi, x86ms->rtc, + !MACHINE_CLASS(pcmc)->no_floppy, 0x4); + + pc_nic_init(pcmc, isa_bus, pcms->pcibus); + +#ifdef CONFIG_IDE_ISA + if (!pcmc->pci_enabled) { + DriveInfo *hd[MAX_IDE_BUS * MAX_IDE_DEVS]; + int i; + + ide_drive_get(hd, ARRAY_SIZE(hd)); + for (i =3D 0; i < MAX_IDE_BUS; i++) { + ISADevice *dev; + char busname[] =3D "ide.0"; + dev =3D isa_ide_init(isa_bus, ide_iobase[i], ide_iobase2[i], + ide_irq[i], + hd[MAX_IDE_DEVS * i], hd[MAX_IDE_DEVS * i += 1]); + /* + * The ide bus name is ide.0 for the first bus and ide.1 for t= he + * second one. + */ + busname[4] =3D '0' + i; + pcms->idebus[i] =3D qdev_get_child_bus(DEVICE(dev), busname); + } + } +#endif + + if (piix4_pm) { + smi_irq =3D qemu_allocate_irq(pc_acpi_smi_interrupt, first_cpu, 0); + + qdev_connect_gpio_out_named(DEVICE(piix4_pm), "smi-irq", 0, smi_ir= q); + pcms->smbus =3D I2C_BUS(qdev_get_child_bus(DEVICE(piix4_pm), "i2c"= )); + /* TODO: Populate SPD eeprom data. */ + smbus_eeprom_init(pcms->smbus, 8, NULL, 0); + + object_property_add_link(OBJECT(machine), PC_MACHINE_ACPI_DEVICE_P= ROP, + TYPE_HOTPLUG_HANDLER, + (Object **)&x86ms->acpi_dev, + object_property_allow_set_link, + OBJ_PROP_LINK_STRONG); + object_property_set_link(OBJECT(machine), PC_MACHINE_ACPI_DEVICE_P= ROP, + piix4_pm, &error_abort); + } + + if (machine->nvdimms_state->is_enabled) { + nvdimm_init_acpi_state(machine->nvdimms_state, system_io, + x86_nvdimm_acpi_dsmio, + x86ms->fw_cfg, OBJECT(pcms)); + } } #endif =20 --=20 2.43.0 From nobody Sat Nov 15 03:14:59 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1755864978; cv=pass; d=zohomail.com; s=zohoarc; b=IPkkkBPH7HMYyg9ixpC8V/Ngl1m8w4L76ExABhLw2OiT9tPgRiuHZVwZBKCgZPwJU8FY5dFpsRgHcAFxdEusYUhC/xHxOuYqie6AUnjNDpLTuqR5vJ6xS1xxR6byOZxDQO4BRdH7FotWF+HH9VG+Wnw5/90Pn+Tuc9wxQLK7jdI= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1755864978; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=9LtUU0ByhpZOBLQZ6b7tWiLIVdVkbKIs7W3LY3iapCA=; b=M76DImatVNPBn6K4nEH3RPPK62DsZafMJ1lFquYHIqFRp+mD3cO0YeYudpq0HSOuuoX9kbgKk5+/VUM5NWBZO2hj8Yvkv4ydpONZbiGcTS0cmANFdm+lh/7/qnaJmcwCIfblw3Kx/JJRoYK7mJCARUhcNA5Zgzd5Kl848DIsCbw= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1755864978123774.4382199692645; Fri, 22 Aug 2025 05:16:18 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1upQeu-0001ap-Oc; Fri, 22 Aug 2025 08:14:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upQer-0001ZC-8o for qemu-devel@nongnu.org; Fri, 22 Aug 2025 08:14:13 -0400 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upQen-0000fL-EJ for qemu-devel@nongnu.org; Fri, 22 Aug 2025 08:14:12 -0400 Received: from pps.filterd (m0127838.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57MA88oH2824615; Fri, 22 Aug 2025 05:14:06 -0700 Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12on2097.outbound.protection.outlook.com [40.107.237.97]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 48pphe07ya-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 22 Aug 2025 05:14:05 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by SJ0PR02MB7725.namprd02.prod.outlook.com (2603:10b6:a03:322::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.24; Fri, 22 Aug 2025 12:14:04 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%3]) with mapi id 15.20.9052.014; Fri, 22 Aug 2025 12:14:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=9LtUU0ByhpZOBLQZ6b7tWiLIVdVkbKIs7W3LY3iap CA=; b=2NPy7+XjNUYMKlXjJX8PXCuEC2SQFd+LZ7h/angtzf5cwcEKw3riI1l5L SXT8D/2axGXOvD9vwnGi7xHCy/YDXCHR9y02SYZhD5Z9xoNhRVPdOPCTzuSV7uMY Vybnzyy2gNaVIxa2FbjNajG9f3WPFaqYFfqf8P9Chckaan1zvo4To1ZdgyRvqGvV LwNE66UN4flxHIH/Ya7OB26MzqdsOqFBqZWxdP7s7e3wzP0raFw34vu5S0Upc8pL Uy1r/dswcpEKgA6TybhFImauG6ISvsvLC9VLEmcxFfxXfrd440Wy16G5Josu20ke 5hMXgNMvnljLT1QOSodvHON+HprDQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=alrkJe9qaL1H//YYWkUJ1tAsPQC/Dx6iDxqanFqZaoRP61IOz1g6E2NIgR3913dQb/efa6cqaJOPz7pw/dGs3NjYWUZOcLg0/XO6Sh1KMPqRht1nJpfPcK8GfIRXQkscVgyGyhYNGV0UdTk/RPoh4WwWJBGBCPzbdpdPSNY6pcNrY4SFlVGmc/4WMbGLvbFfC9yQCS7iohC899sY8wBf2yBvIZ9D46roHHHojyN6/1irqNtIoXiqGTuxBsvM3lG9ZIKi17zjO+yU3eGOLb61p3DuyywPsLV1hW+SC9u7aJYBvd721cpfCpEMmt9g23dp6WAZoObNKBicH79REr3d2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9LtUU0ByhpZOBLQZ6b7tWiLIVdVkbKIs7W3LY3iapCA=; b=kgSNzi4G6Znt7eoZqkui9XxPKjuEAy9uHO9kefnELXUB+Lh2PHADHeO+hQ/yxkPOLFFLAuPkOZHTTC3PNbGtcHqTD+QcSLG+pKwQrLPIO0/oDnFHteqqHvsL5Myu7Fk1ud+QRnMPr2Jzew2kochYScWPuaMtRLFW+i5DaO+ZUBvNpKXc14NBM0AV3xgXZBIn4R/y69vm/OKPFtMX2RULf1HFqdL+vR2EbDwsBy6fAa7nT1xdGtbWYFzVkAIu4kGCE2L0pZvixH5eBL+P8ZZR9zNu1l/RAnfAvkCKY+BX04NHSrbRvV4aX7rg4qLdf/dYW4Iyq7gPn2xGrBt6JuUpgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9LtUU0ByhpZOBLQZ6b7tWiLIVdVkbKIs7W3LY3iapCA=; b=kYchPiZ/P3sjqeYg6KIzDX/RTjf9vjUIRgB/ZiWy9Ld8orfCoN7nfeD0mndindHBx+wYRXWyfMOCNMQFlbjO/mZJYaaPTLNAMCzipHuW3wnF0ALm/2Uot7Sc9CJpoETI3uM4MXrbKfzRp9SpHAc5WbpgQmMqtcNfZhJEQfR41SHEczxCyFtSW4Pcf+IeLAq/pkwFIGg7XrbK8FmCToksp0vWwkykYNoQPIqhvpul8/81n8xc3nOMNuiz41EgHpyItyj3c6CCPEs6yQuitg5TqHjLsn6xV15vHDrBChesq7F19Ey1eE/hF5hJFbeAW+R33oUTA4QL9bG24xpqFfFEeg== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v6 05/19] hw/i386/pc_piix.c: remove pcmc->pci_enabled dependent initialisation from pc_init_isa() Date: Fri, 22 Aug 2025 13:11:51 +0100 Message-ID: <20250822121342.894223-6-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250822121342.894223-1-mark.caveayland@nutanix.com> References: <20250822121342.894223-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM9P250CA0013.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:21c::18) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|SJ0PR02MB7725:EE_ X-MS-Office365-Filtering-Correlation-Id: 3faa6c8a-09ae-4c14-5261-08dde17562c1 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?c3hVYTVNSGkzclJzNloyU0Jjb0cvRkU4cXhVTmo2OFRnelpQUWFXeldKU2Rt?= =?utf-8?B?ZVYvWXJtdTh1YU12TmJWL2pUVmRRcXlCS2ZtNHRYYU1jL2IzK3Y0d0Nzb3ln?= =?utf-8?B?ZEFNclNOOE0zNUFaSC9UT2s2NmphMWxjQkhobUxpZExzajFOWXJxdU0vNWRq?= =?utf-8?B?ODNGRU9XVGUvak5aSkQ5WlpNRGFOTUVGckFpdG5HK3E4Rm1LOGdwcGM0MTdi?= =?utf-8?B?L2V3eUFNd1F2ZnRWMlBRbmVZUWxoUVZjaUJjUVcrU3RQcVhzR2FqWFpqRDdG?= =?utf-8?B?YWxWM0g0TjJRTWgzNGszbnJxaWF2Vnk2c3d6b1JQOVRDMG1Ib0dpc3hvZnA4?= =?utf-8?B?ZFlSVytmTlE0b0JXVDd3Z0oxMHBIL2tyOTk1UHJndVhPUTRidlZpRnNFaFNi?= =?utf-8?B?TjQrTFRFS2tTTm1xSFprQlY5T2NSdkRENjMvYi9mY0pqV3lZd2ZQL2wvUGcz?= =?utf-8?B?WnBsRW5rbDFDcjhaR2Rra3dUYVdabVRrYXk1d3dtTENnc2o2NU1CWTc3K0l3?= =?utf-8?B?OG5FejdCa0IyU0lmNk43TjFTL2JXdzVkK2hNTFpyMkt1VXAzSzVZaFR3elNS?= =?utf-8?B?aklSVzlUMWNuN0V6aVg2UUNzT0NqVlord2UwMkxWR3Z3S0tBZkg5YUhmV3BK?= =?utf-8?B?R083MW1ONStLZDBaWDkyV1J1cGlqZm9ucTRSN1VKZjdPL1RDK1R3Rm1Xa1lu?= =?utf-8?B?RldzSWlwTDIwdEtOR291N1UzelZuZ3ZuN2dVbGpqSnJnak56elkyeWNYa1ZH?= =?utf-8?B?WlVRMFQ4K2RXdDFTalpUMi82VDJURjhJanA0dXUvVW94cXRSbDZidm1uVnBt?= =?utf-8?B?WEhjMVZrZHFQcEdOM2lUS25XazNHTlpqVU93ZGpRRVdxUWViZW9vUExQWHFY?= =?utf-8?B?OTlPTzlWZmRwVWdTb00vb2lLOUVHU3FVaVhPTWlUeVNrZHlKZ21jOGMvUkZW?= =?utf-8?B?eHZ5d1FZcXRBN2RqZ2IvZWp2WnFDakh3dEpBOGtaTXFwTVM3WHpocTZLQXJT?= =?utf-8?B?Y0ZMZGtxZkhWa2xXRzBOakFQTkJTa09kQWtsSlJsRmNhUXRXcTY5cFUyUitN?= =?utf-8?B?YUR2VCs2ZWFJZ2s2Uy92eGVuNlhKOU5jclNyYmt6ZjJlRkQ4VVkzcVdsZWdB?= =?utf-8?B?NzVySEtuUU51eGtRdjUwSWpXRkNuWVV5TjVqUGpuSjRuckFUWmt2TmVjUXdP?= =?utf-8?B?bjBKL21IYVBJeGRFaXhFcU9VSXlpWm9ZbzUxMFZKdVl3eVQzMU11WUg2NzBN?= =?utf-8?B?MGFwSjVCQUNGcEYzZk94SUs5QUhNaWVrbjVjSFhQd0NCMXZXcVorOEsxL2pG?= =?utf-8?B?cUxWQ3p4eGhrMFlzeXArV1ZETUYxaXBGVlVvcUVvWVU3WVdabndwcUpOaW9I?= =?utf-8?B?TFJjNDBiS3Z4VXJwdktvQ0FKaEIxS05EaUdqb1hOWXZZcWZwdDd1WUROSERx?= =?utf-8?B?b0hnM09FbEl1b3MwQkVBcnlQT0lGZzdqRGdDVEFTYURZMGRpQzQ3SUlvcnFv?= =?utf-8?B?TWllMURzSnZjb214MTVXaWs0U0Q5andCTzRpaHFkaTVCYXQ5Uld2cWIyVkR3?= =?utf-8?B?ZGhEZTQvT3FtTm9jMW9tQTRQOG5GVUNNUFM1MWQrMnkzSHpodXNBUkZrREla?= =?utf-8?B?WVBxMkJKbTRVYkRPMkVOQWFFSlFCbElscWJLMlB6eUh6Q0h5NTdlY09hdFpI?= =?utf-8?B?eXA0RURzd0I5WVB5Y3JLTWx3cXh3R3VGTm1rcVVZTE9NYkt6MHUwM1dvRWxV?= =?utf-8?B?QTdRTXM5TUl2VHRQcjkxUlQzRURkTnMxbkVBVGJkYXJqenFibGsyZEpzcmNB?= =?utf-8?B?NzZGSTc4T1RtbVA0Nm9VdVJlMWNiVWcrTnJsemVONDJ1aHJ1SThGS0JlZ3Nr?= =?utf-8?B?b2E5bW1hdWZ0UkdRQ0h5VnF6SUVlM1B5N3hRNmdNZGZlUWVhcURMSTlHdkcw?= =?utf-8?Q?7xDPcGGyNh4=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dXgvSzZudU9hRU10aVFnWjNsZnZIQVY4SCszL2swRWFXWXpLUU1hekhJdjYr?= =?utf-8?B?UGZGdFdGOHFudTdLL0FKWTNaODhTRFBicHIwT0J3UWhrd2NoUENSeXZ3d3J1?= =?utf-8?B?ckMvZDB5SW1jeVVwa2F0dUl1Mjlmb0VhaTFhL1o1d3lZSC82RDY5K3kzTEhK?= =?utf-8?B?RUV5OS9KVU5XakFlSUhUM01RZ2JlQXpnRVZjNm5RRHYwci8wNTRJcCswNVNi?= =?utf-8?B?dnZCVUlldVJneXJqdi8zMzV5M1NkR0s2U2NpbHBtVlpCM0ZQdEdWelZnd0VR?= =?utf-8?B?Y3o0Y3haRkQxTXpjb0QybmV2a3hQNERYQy9pQUI2eE8rSWt1bFI1cnovMFJo?= =?utf-8?B?NGhiMXgwaFEzV3YrRm1wZjNrUjdLQzkrc0R1UDR4eWo4dlVjdFRDMWFraVdy?= =?utf-8?B?bEJUR2VsNkVWWE1IZ3B5ZW1tTUZaQTg0VldQTjZQeUhLWVdDWnB0NXFvRmpu?= =?utf-8?B?aFBlbHhXZGMvWCt3RlYvdDA3S25EaGlaaDBnK1AwY3pZdHZGa3hsN1Aza2Fr?= =?utf-8?B?VFFISEZpV2g3Q09NMmJpZktNMDJkbXNucGxSNytmbnF2SkVVTjUxZnhINmlv?= =?utf-8?B?dHlVT0VnOGpKNndyamp2cjVQbzlGZ3UxdjhQVytHNW9LSTlhS2h4dWVlZkNs?= =?utf-8?B?aVhVUG51SXM2cDhiem5QZG44azBuU0lEekxvbWdOSDlacnpzL0xFV3E0MjdB?= =?utf-8?B?amRaOG1CM04vR0xwR2gxYWVCZ1B6MUw0ODRQZU1TZ0tEZmVKcG5BM0xCSWxy?= =?utf-8?B?WEgzKzRJN2xWNFkvNXg1VXNoVFQ2VWRaNWl6TjF5WlRMd1V1R2VmaXZPUnZ2?= =?utf-8?B?cW9Ub21uUTBTMisvR2R3WWxIK0xYRjg3Tzh2dkV2eHBqcDNPLys1Sk0raTJq?= =?utf-8?B?S3FoWnRxa0l2YXFvTTFpMmtxbkhwcEEyVmx6cVpqNS9Wd0Q4WFl2N25OY2xN?= =?utf-8?B?MURwMmVqOXk5MVhLSzVtOWdjZ1dGOTZQb2N1SkV5YTFYSTJwUGdUY2VqY3E1?= =?utf-8?B?bXBWUGVBUElYdUV4bll4N1RDTVkxQnZ6WkthNExuUmJzcHJTNVc1NkRlRnJ2?= =?utf-8?B?VnZGMHFObHJKRlBUS1BFZWZ5MEZ3MzVVVGF1a2Fpc3VnckVzekFMSEtEZ3Rv?= =?utf-8?B?OTBtWGxyUFE1TlY1UkdoZTF5N0UzdkFuUnQvelRVVXFnRE5GZElpTk1uK0NU?= =?utf-8?B?akNVSXVtU2xTVGpUTXJNRys3UTR4b0s0elM2VHErWGhacTFIZytSZ09iUFF4?= =?utf-8?B?TjFEdXM5Wkl5YVZ3cmNjejRmTFR0WHVCWnNOTUV3N3NmZ0Vmck1DREIzSXQr?= =?utf-8?B?eXQ3bzhJbGpSZ2puZ2FRbVU0cXZEeFNIaXBqRlR3MjRVbDZLS3hFc00wVVU0?= =?utf-8?B?a254SWN2NG5ZS3FMak1SZFZiajFjT1NhZHZMa0M3ZThmR2ltZGtkWG5OcDU1?= =?utf-8?B?dGVieTdzem5JMVFOSWxocm1oajd6UE8yNUdWUk5PV3VZSUd3bEN5bWN1VVI2?= =?utf-8?B?ODdxR0svMkRzWHhCMWlBS2tiNXpYNW82eGNNR21DOGgvb0JBTlRwdEh2M3N3?= =?utf-8?B?WmphcnJtRlFzZWEzaHViKzR4aytzeCt0UW5FckMwUm1RQ0ZzSXBrVC9OQkI0?= =?utf-8?B?Z2liWU9xVWlmQmFTZjFpajBhYXJReW5sNng4dlk2a044QlB6cmVySmhMd0pP?= =?utf-8?B?STM0b1UwOXI5aEZpdEFOb0VId2NpT0U5dVlmRm00d3o0NTFDUnBnNUN1L2FU?= =?utf-8?B?UWhkYkh5SEpvRWp5TWZXdW1ES0FPN3l1QStjL3hNRkxhOHU2NEU2SHJQWnRN?= =?utf-8?B?VHR5alFFYVZtNTNqeE9UYTM5b1ZacWN3b2ZKV0swVGJhZ0VPc2dFZUU5VlR2?= =?utf-8?B?RGhsQjlreWNxNjNmQjd4MmoreGFvbDdYbW1iSHFXWUVoT2tsWWs4NGUyT3hz?= =?utf-8?B?Q3dVaFdpQ0VCWjRDbUFVVHhVQXlud1RQekVWM0JBRmNTWFU3SUJYSmNVR0JI?= =?utf-8?B?QXFuWjNXUmZtdFVNMS9JN2Z2dkszbTJSVE9RR1crbFdGcFhjV3RScExpSmxR?= =?utf-8?B?OXZhUGJ3bXJ5R1ZtaU1FSzJnMjV3enVON0JoL1Z1Z0tWT05sTkh3MUx2MHRJ?= =?utf-8?B?OGVRZEcrcHhxZFhBVHJRaWJML0QyOU50c09uY2wzRkpZb2FCNWJMQlRZNTBa?= =?utf-8?B?UlE9PQ==?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3faa6c8a-09ae-4c14-5261-08dde17562c1 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2025 12:14:04.3034 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JMwCt/7xC/UCTgITboreyb1bLOlYuUWUkCzKxtnLAjtHBBllTYfe42thJU9h4aWD9IXuIKt+c74Zthv41qfvqPhS6SnFucBRO3t7CVRTlP4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR02MB7725 X-Authority-Analysis: v=2.4 cv=PvLKrwM3 c=1 sm=1 tr=0 ts=68a85f0e cx=c_pps a=0X7mRi3vmuUbB4YAiuF6EA==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=pDVciPHeplB8fhom_mUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 a=cPQSjfK2_nFv0Q5t_7PE:22 X-Proofpoint-GUID: QbaA8wi5e7omjihpuYQYt0P97HAm5NJH X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODIyMDExNCBTYWx0ZWRfX11eEY1Nb7scb yDZ8jgCF5dElVTVhltUKCss2AFhDymXlDU2at2v9yaHfhqmHf6jwgeDak9ijULzwwHMYMrZ+1Ln GNF7L2nn2e3+mRtuFvqr/237TMemMY8k6dctmpj9YHZWLoZqkotVkZO1j5EmUSsNDTFJl39+LIB 9eupmvtufJLloOE9z9FXwagdyx4BWRj9nhPHgYKvP2qHMZRFlIYHGBf8HchxVSLIUZztq/ig2/q K1DGed3pLrOM9+6BBNYqcm4SCy2XXbcn6wcS1NQtrOX/R3ylcu/tYxJyV3ulUyocjAnic1fubgb aI/8Jw7PQOR/6hePjXcqwlyj2ei22PH3qposM8MOeJKW4qzRvK8TaN7P37mXVbCEc4PmaLx2i5p tb/3VhK2DV+HDYeDf6fQAvpn6yQApg== X-Proofpoint-ORIG-GUID: QbaA8wi5e7omjihpuYQYt0P97HAm5NJH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-22_04,2025-08-20_03,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.151.68; envelope-from=mark.caveayland@nutanix.com; helo=mx0a-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1755864979002116600 PCI code will never be used for an isapc machine. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Xiaoyao Li --- hw/i386/pc_piix.c | 105 ++++------------------------------------------ 1 file changed, 8 insertions(+), 97 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 5b97ad2cea..da2de88383 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -435,19 +435,16 @@ static void pc_set_south_bridge(Object *obj, int valu= e, Error **errp) #ifdef CONFIG_ISAPC static void pc_init_isa(MachineState *machine) { - const char *pci_type =3D NULL; PCMachineState *pcms =3D PC_MACHINE(machine); PCMachineClass *pcmc =3D PC_MACHINE_GET_CLASS(pcms); X86MachineState *x86ms =3D X86_MACHINE(machine); MemoryRegion *system_memory =3D get_system_memory(); MemoryRegion *system_io =3D get_system_io(); - Object *phb =3D NULL; ISABus *isa_bus; Object *piix4_pm =3D NULL; qemu_irq smi_irq; GSIState *gsi_state; MemoryRegion *ram_memory; - MemoryRegion *pci_memory =3D NULL; MemoryRegion *rom_memory =3D system_memory; ram_addr_t lowmem; uint64_t hole64_size =3D 0; @@ -535,39 +532,6 @@ static void pc_init_isa(MachineState *machine) kvmclock_create(pcmc->kvmclock_create_always); } =20 - if (pcmc->pci_enabled) { - pci_memory =3D g_new(MemoryRegion, 1); - memory_region_init(pci_memory, NULL, "pci", UINT64_MAX); - rom_memory =3D pci_memory; - - phb =3D OBJECT(qdev_new(TYPE_I440FX_PCI_HOST_BRIDGE)); - object_property_add_child(OBJECT(machine), "i440fx", phb); - object_property_set_link(phb, PCI_HOST_PROP_RAM_MEM, - OBJECT(ram_memory), &error_fatal); - object_property_set_link(phb, PCI_HOST_PROP_PCI_MEM, - OBJECT(pci_memory), &error_fatal); - object_property_set_link(phb, PCI_HOST_PROP_SYSTEM_MEM, - OBJECT(system_memory), &error_fatal); - object_property_set_link(phb, PCI_HOST_PROP_IO_MEM, - OBJECT(system_io), &error_fatal); - object_property_set_uint(phb, PCI_HOST_BELOW_4G_MEM_SIZE, - x86ms->below_4g_mem_size, &error_fatal); - object_property_set_uint(phb, PCI_HOST_ABOVE_4G_MEM_SIZE, - x86ms->above_4g_mem_size, &error_fatal); - object_property_set_str(phb, I440FX_HOST_PROP_PCI_TYPE, pci_type, - &error_fatal); - sysbus_realize_and_unref(SYS_BUS_DEVICE(phb), &error_fatal); - - pcms->pcibus =3D PCI_BUS(qdev_get_child_bus(DEVICE(phb), "pci.0")); - pci_bus_map_irqs(pcms->pcibus, - xen_enabled() ? xen_pci_slot_get_pirq - : pc_pci_slot_get_pirq); - - hole64_size =3D object_property_get_uint(phb, - PCI_HOST_PROP_PCI_HOLE64_SI= ZE, - &error_abort); - } - /* allocate ram and load rom/bios */ if (!xen_enabled()) { pc_memory_init(pcms, system_memory, rom_memory, hole64_size); @@ -584,74 +548,21 @@ static void pc_init_isa(MachineState *machine) =20 gsi_state =3D pc_gsi_create(&x86ms->gsi, pcmc->pci_enabled); =20 - if (pcmc->pci_enabled) { - PCIDevice *pci_dev; - DeviceState *dev; - size_t i; - - pci_dev =3D pci_new_multifunction(-1, pcms->south_bridge); - object_property_set_bool(OBJECT(pci_dev), "has-usb", - machine_usb(machine), &error_abort); - object_property_set_bool(OBJECT(pci_dev), "has-acpi", - x86_machine_is_acpi_enabled(x86ms), - &error_abort); - object_property_set_bool(OBJECT(pci_dev), "has-pic", false, - &error_abort); - object_property_set_bool(OBJECT(pci_dev), "has-pit", false, - &error_abort); - qdev_prop_set_uint32(DEVICE(pci_dev), "smb_io_base", 0xb100); - object_property_set_bool(OBJECT(pci_dev), "smm-enabled", - x86_machine_is_smm_enabled(x86ms), - &error_abort); - dev =3D DEVICE(pci_dev); - for (i =3D 0; i < ISA_NUM_IRQS; i++) { - qdev_connect_gpio_out_named(dev, "isa-irqs", i, x86ms->gsi[i]); - } - pci_realize_and_unref(pci_dev, pcms->pcibus, &error_fatal); - - if (xen_enabled()) { - pci_device_set_intx_routing_notifier( - pci_dev, piix_intx_routing_notifier_xen); - - /* - * Xen supports additional interrupt routes from the PCI devic= es to - * the IOAPIC: the four pins of each PCI device on the bus are= also - * connected to the IOAPIC directly. - * These additional routes can be discovered through ACPI. - */ - pci_bus_irqs(pcms->pcibus, xen_intx_set_irq, pci_dev, - XEN_IOAPIC_NUM_PIRQS); - } - - isa_bus =3D ISA_BUS(qdev_get_child_bus(DEVICE(pci_dev), "isa.0")); - x86ms->rtc =3D ISA_DEVICE(object_resolve_path_component(OBJECT(pci= _dev), - "rtc")); - piix4_pm =3D object_resolve_path_component(OBJECT(pci_dev), "pm"); - dev =3D DEVICE(object_resolve_path_component(OBJECT(pci_dev), "ide= ")); - pci_ide_create_devs(PCI_DEVICE(dev)); - pcms->idebus[0] =3D qdev_get_child_bus(dev, "ide.0"); - pcms->idebus[1] =3D qdev_get_child_bus(dev, "ide.1"); - } else { - isa_bus =3D isa_bus_new(NULL, system_memory, system_io, - &error_abort); - isa_bus_register_input_irqs(isa_bus, x86ms->gsi); + isa_bus =3D isa_bus_new(NULL, system_memory, system_io, + &error_abort); + isa_bus_register_input_irqs(isa_bus, x86ms->gsi); =20 - x86ms->rtc =3D isa_new(TYPE_MC146818_RTC); - qdev_prop_set_int32(DEVICE(x86ms->rtc), "base_year", 2000); - isa_realize_and_unref(x86ms->rtc, isa_bus, &error_fatal); + x86ms->rtc =3D isa_new(TYPE_MC146818_RTC); + qdev_prop_set_int32(DEVICE(x86ms->rtc), "base_year", 2000); + isa_realize_and_unref(x86ms->rtc, isa_bus, &error_fatal); =20 - i8257_dma_init(OBJECT(machine), isa_bus, 0); - pcms->hpet_enabled =3D false; - } + i8257_dma_init(OBJECT(machine), isa_bus, 0); + pcms->hpet_enabled =3D false; =20 if (x86ms->pic =3D=3D ON_OFF_AUTO_ON || x86ms->pic =3D=3D ON_OFF_AUTO_= AUTO) { pc_i8259_create(isa_bus, gsi_state->i8259_irq); } =20 - if (phb) { - ioapic_init_gsi(gsi_state, phb); - } - if (tcg_enabled()) { x86_register_ferr_irq(x86ms->gsi[13]); } --=20 2.43.0 From nobody Sat Nov 15 03:14:59 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1755865023; cv=pass; d=zohomail.com; s=zohoarc; b=WmnA0hE06QbVL+k63j9QvTFQQkiG1QySbl58N+eGsfiShGbbRSucx3NRa3WQSMzLtxxLimTNn0GnzB0Mwe0ebVlkS5xyn7XhwsLNi+b2SeKRwVe8DF0QT1yPgRpQ35RXEmxofRm6QI2KwtOl2IuWOX8Yh9rIOgcBjj5xTGJIrqc= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1755865023; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=9sTPWbzOqodGv1XXh1UzXSeIPVVlneSSNU9XQz3WhCs=; b=XIteCouO0q5J+V76uDRqm6WPqoB0WRht5rowSNdbdbSP2m6z8T/IvIAmwD/JbQqtlqPGXl9wcFSfUxc3ai+aL1tKELvykrIc4c8AvVjFQe8EfLK92tXHaAs4C9k7tI4DIv5wbq5YHQFmcaPME8oIuF88ZzSg3bgutVBYSbSGaEY= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1755865023709587.1846661659523; Fri, 22 Aug 2025 05:17:03 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1upQew-0001bK-Oy; Fri, 22 Aug 2025 08:14:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upQer-0001Z8-45 for qemu-devel@nongnu.org; Fri, 22 Aug 2025 08:14:13 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upQep-0000fW-0o for qemu-devel@nongnu.org; Fri, 22 Aug 2025 08:14:12 -0400 Received: from pps.filterd (m0127841.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57M84BpX703317; Fri, 22 Aug 2025 05:14:09 -0700 Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12on2093.outbound.protection.outlook.com [40.107.237.93]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 48p6uaa6g2-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 22 Aug 2025 05:14:08 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by SJ0PR02MB7725.namprd02.prod.outlook.com (2603:10b6:a03:322::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.24; Fri, 22 Aug 2025 12:14:07 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%3]) with mapi id 15.20.9052.014; Fri, 22 Aug 2025 12:14:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=9sTPWbzOqodGv1XXh1UzXSeIPVVlneSSNU9XQz3Wh Cs=; b=f1WAgPByi1zsdaPLuHwA23j2icX5DVQ8/a7xgxRiMybokCYAAsyxi2FT0 CbVmw998YNWVuF4q1KpPH6w59jea/ygh13sv4+fmd5cz/2loDg7RM+euz6atEP5W yRrNZ1xBJLe6+9Ua6MDc2eS/SCRmz1htg4CZxt8bl+/9jglMHRaznJLG9xOTukTE zVEYioZCIN6Ojp/KGU7DGxcguWO8vrJb4ZSBaCFc+5uX1PeLAuwT5ITzOaO544Dt GXukrtiqy3dOj4dRLzRb2eekAOuhaBKRN0KQ+cvJSS2UGJrm6Pcd2TllZDSFdMsC GIl9nnS9iW/Vc2GZ7o6Id/4bo1qCA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=eVO8SJ/wa0sq/AksLrFaAmdHWQW9vkv6buKfvBwsLd7zYlg7qxHw0h5epmrG/M/iN2tIzTFEFJNIivSWaMZGStdo7855W7bvKnxeWMn2qIETunQyVNfOymCSxjQeZDgyO+5XN0vjvjsj1aZvrtHJ5IOOzXwL0oTtpgICNAGG+hcCRT627WHzj+xAHUc/PR+UT8Onz00Oub4OnE+e7p4f2lTMB/EsYV+L+W+w4v8HmR/xAlcSOggAHzTGYtrQFtlDCKoOFTtlQCjQ2lrn07Nlrla7r1zRUOVO5WICw2l/8P+qbM4f29Fkywm9gKFNb9cvAI5QZy4wXFMnJq15RaX5OQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9sTPWbzOqodGv1XXh1UzXSeIPVVlneSSNU9XQz3WhCs=; b=Y2lQkw/wfFzVW1/5YRIe2PCHX1660Jkm/oQxGoobAUvIX0ilT/94akurSjIUaSekL0FGAjrGDe1/m0whn6Drv7D/Vs0ZfkPHt/k0Vc92wIpD/mjrqqoEOTr1NXX6fvEIoOJcnXpxs+zZzThl70M46Kea0cvLg4ydtu1m4v72IJ/JR9m2DEfNraleEyb2d+tVgow1RMQ4bb8ntvKsYozS2AG5rywVo19MTAxULIbIaWVNt8u312NzgrN/kOqfRZFhFs9pTv4+isAxzZgMR1sGF7Kf9ktnge+SXDd6YtKBmgLh7HQ6n3BHzekapavxB7mKn4zzDSRoIwvon5zPTXFaVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9sTPWbzOqodGv1XXh1UzXSeIPVVlneSSNU9XQz3WhCs=; b=NvPWQJ0qyFLTgAAbXfbi2MPGGt31AgP0FPnfpOr/zziY2z4C8L4+cZMnixAB1YYci5hsogveJV/2a002sI8CTvgJFykUhexcdUfiTDED6abgtXz8/J4xFJfvIPXi9nF53kPGoaNdYqu09OTEZa0fVWxJAAuE4Sd3MLXY2FJGfteP9YNzhexds4ou+XyHaHnzPYWs1XO6mtWoMCK8yt/qPzN0QfXfifiN2oIaQ0zy0oRHLKCRXthaeCjtr6x8ZoOoWH1g5n7BNcmr6PFfAoM5xpMhd+mrq13KG2CNUoAnOq2Ck83EVqlBZ0zlXd6Lan/qB4Rkuuf4Wr36O03NEwJiiQ== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v6 06/19] hw/i386/pc_piix.c: remove SMI and piix4_pm initialisation from pc_init_isa() Date: Fri, 22 Aug 2025 13:11:52 +0100 Message-ID: <20250822121342.894223-7-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250822121342.894223-1-mark.caveayland@nutanix.com> References: <20250822121342.894223-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS4PR10CA0011.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:5dc::14) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|SJ0PR02MB7725:EE_ X-MS-Office365-Filtering-Correlation-Id: 777ff153-0641-4b9d-ab0e-08dde17564bb x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dVp6WkZ3bC96d28rV3padEJrSlZKTDhVaTBKaHNEaUdpU0p1WWhlaXdRSnZp?= =?utf-8?B?ZmRtT2lTRVlQTjBWc3BhaTQ0K3hJRFE2TDlGRmMyWjNzcUU5dFRVK1U1TmNO?= =?utf-8?B?aWlueC9obERyQWFMU0MwVWZWNnpHTmM5ZEFKVFlmMHNTWmlBeHhzUnhUbytP?= =?utf-8?B?VGFjL04zbDBMVDE3UkszU1lpOE5mbG5hSDdQRmQ3NzRvTkhGeHUyR01Qblhm?= =?utf-8?B?ODdERFR1aFU0K05vZER0SnczbjN0QzVXWVgxUDU5LzVhYktjN0xHNGU1M0NL?= =?utf-8?B?bjF2UEttTlRVVFNVSFRObDJKcGZVL01yZUl4TFlhSFB6dityT3BSd2QvMGlE?= =?utf-8?B?ditPaG10QXVGSm9zTjB0V3VlVFhPSnpQTVR0OGlRcmtVbjhaQXIvUGVIUWcr?= =?utf-8?B?bzhEQnJrZm5lWlEzMUxNVzVwRFhCVGdTK0s3NVN3RStCNTF6U1FSTm9PTE1n?= =?utf-8?B?VUNndnJ0UU1QUEtpRFdkS0R0V3dTR01ZcEx0TEJDOHZKSk44TnNFSmI0aDlU?= =?utf-8?B?WmhabkpuQW9MSnRJNzVwckZPUEZrbE1lWktSb1ZVMHNWY3RzZUY4NnJPUklz?= =?utf-8?B?dVBlYWZkOE5SUWZ4NHJNZG1nRUZ2aXVXWnFyNGhEcGczbkV3QmtyQ0NOc0d5?= =?utf-8?B?WnA5ODZjTzRiUlhUZlpCV3Q3MFo4ZzROdnpLUlFUME1QL3dLRzRMTDFXS0V3?= =?utf-8?B?Y3lMazhXRkJwSTUxc0VDL2lEcjQzY04vcG5hb09RSzRnOWQzdEFqU3hNTDBs?= =?utf-8?B?WHpPdnRFc0drcXBrdi84QTBvdG4xTFgrY0ZBUTIvVDVGUjBqdDdwY3FKUFFX?= =?utf-8?B?R3pHQjJQckRJM2srTy9aYWJISDRwTkhBUXBjdmJaU0FYT0ZiZE9GTFZNUnIw?= =?utf-8?B?SzRkWnFVU1ZhaUZ2ZUhrRmViUk1CdlJyc0Mxd0ZTWWN2OVFodFBhZVJXQkwv?= =?utf-8?B?c0lnOEMzaHcvcFRyNkNVNVRhMlNybiszOXNMSjI4ZnFKVVkvOUFuSVZxNitD?= =?utf-8?B?OUNtZFE3NXY2ck1ITDVLcjJTMzJaOHhFZ0V1MEw4SEl1TFZRTzZaeGdEYk5S?= =?utf-8?B?blI0emRMWGZKVkNCKzZVNDB3SUxwTU9QbEdORVdkemZUY1hSMi9HUCt4N2R2?= =?utf-8?B?aHk1TzYyY29oa0o0clk3ZGFja0t6RWNtYStkSkpXc1lqdjF4VzVibHR2ZmZo?= =?utf-8?B?RFdtT3VlckpkZDg0TjBrNVNZMTUwbTNCcVpLcmMrbTlSYStjZTNXMG5GV0Ew?= =?utf-8?B?dEI2ZURBVW5zOHBmU2s1am93b3JPc2dwajhuQllja3BCdk9FZVZnbVlnRU96?= =?utf-8?B?bEt0UDBBckZpZ0lDQU9ZNnE4QitqRWNjbG5yWkk5bmp5QzhhRXc1eUZ4MmFI?= =?utf-8?B?SFUyU3M3bmpuMDRURE1LdzNuVGI4NWQzRmJWbnRvWXRTR3RpWERBWGJHUU40?= =?utf-8?B?eGxEeE1ud0ZHTGNYZnFvVTgvQ2Q2bEFTc2VkRFJUUDZQUWp6NzQycE84N0wr?= =?utf-8?B?WjVWUGhsVUs2TFJEbTVUZXEyRFlvMGVkUmVhaS92bG1xMVdieDdRd3BLUE1s?= =?utf-8?B?WE9TUTlLZEIwdndUQUJZbmc5RUxYSDVDMXlseCtJL3VRVVVWWVFUaXNLZmtj?= =?utf-8?B?TVMvZjU1dGZlbEF1WGRHS08yV2tsemJZVVA1SjNRT3ZlWXkwS1dmYmUvYjN3?= =?utf-8?B?SmFtMlBsS05YMTdUS2hjOU9Sc0szcklnTlRYZHJleTdSUEN4VnphSEV6MWRz?= =?utf-8?B?K1R3U0lOOWxQbDVOb2l5QjhzeDB6dTdmL1QzY2NVQ1Nsdmtyc1R1c0pQNnlI?= =?utf-8?B?ams3c25UYVpGY3UxWi9NclpIMExuSmgxMzVublA5OFBNRVpNdi8vWjgvSnB6?= =?utf-8?B?bXhMRXFVY1VPWW9qL2VtME92NEJxL2hEb2drOW51LzBwc1hzZDFUaVpKY1Jn?= =?utf-8?Q?YRxbmLvwNSg=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eVNkcklwU1Q5QWNRbWhBZUwwOXI2Z0pyOHpRZzU3SmI2U0hUc2h6TFVQMUJQ?= =?utf-8?B?NE1IbHhOZVU0NjlJOVoxVDVoRDMxdVdNYkQxOVRKTGxUNnUxMUY3bld5Witz?= =?utf-8?B?RDM0RDM1YytlWisrUzFCSnlDOVVrL3FlbTNMdGJaTzgvTGtRcDlvdjdpanZX?= =?utf-8?B?YWFTZlJOMW4rZ0tZaVlGS2VyRHFuREhEdjM0VEdnaG5teXVrOE40R2lRM1JV?= =?utf-8?B?WktnSGJUeDc2N1ZQbzBidjVRNkhMQmZTWWFEcVEvOForSDdwVjdJWVJ1bitE?= =?utf-8?B?NU84U1oxNE12RFMvT1N4cW1acktxWXhRdG0rcGtYSy9yNlMyRmxxaHo1bVBG?= =?utf-8?B?Nzd2WEd6WHRwcTZVU0h0cE1GWkdsSHFma01XVnBjd1B1dmRkbmxYYjBMY0Ur?= =?utf-8?B?b1Fub3JMdVlHcDNaVlV5enUrNk90ZzRrSENjcGJnK05GK2VyNTBaVk1zMXV4?= =?utf-8?B?ajk3U3BkTVpkcmFKSkN6VFF3a3llV1o0ajNJNE5yYVExcTNCelpYNDB2QnFk?= =?utf-8?B?aEhldTRGYStQbm1oakF0cXNDWGw4ZkxqcmJTdVFGUWQxZ1ZuZnFEZHY1NVZ4?= =?utf-8?B?NlY4bEFNdEZkVGpZMXI5ZTFlOUZqeVArWWx6VGxCZ3lOdFlZM0NTNnFpMHlK?= =?utf-8?B?SEgxc2xockZtNDFydUNWd2Y0bWtWSzAxaTh6NUhrQ3planpweVVDVWhFeFRu?= =?utf-8?B?ODJ6cXZOTGNRN3NBbXNSVWpDS3lyTHEzZ3dralVINDVwcVl6ajd3aGJKSW84?= =?utf-8?B?WDc4WHpGSHQrbkxuSW5YOVVGZTBkUUdQQ3FQRVByK293VE40U2h4QStQYzRv?= =?utf-8?B?OWEyamhWeTBMOTdnMitSUmJXQkNmZGZ1RnJWQVR1M0Y1cnUyNkRUTDdDMVJx?= =?utf-8?B?cXIyZFFuNXhYNUd1YXdrSHdIemtpWitvY1Vsd1ovYWk3eC9PS1hpd3MvdUZm?= =?utf-8?B?cHdEUVByeGo4aGZ4dmE0bDIwNWM5TlZaTEhVVnpFMFVndUVsSE9nTzc2ZnhV?= =?utf-8?B?TUliREpOVENHczRqWGpMRmRLSUpTVE5xSGxLTUd2a2VmcGRTYWovMWJOYXY1?= =?utf-8?B?NXB3bVM4M05pUFZWOU9iajdqTktFSzVMQ21LbEZ0WHNhcHhFREV5Z2grQThy?= =?utf-8?B?RHkxb0dvZDdaVnNsa3VOalh4NFRPZzI4aVhBbkxQbnY3TklhZ29hdmdkYnpG?= =?utf-8?B?QlpHMGQ1TnNVR01EaGViN1FBODArdEgvenpXV0Z0RnVsQU83Tm41K1MwOTNE?= =?utf-8?B?YklGaGlJWklaWFBJY1dpOHNvRUZJaytwM2JEZDJEZmljVThJbE1KbUc4dTBG?= =?utf-8?B?anBXbkhmVS91ZUh1NjVnTHZnUjNBZjRBNDRjL1pXNGw3QzBDTlNwR3JuSkIw?= =?utf-8?B?RTVPN09vdGJGdTlLMDRvaGd6Yk9tQU1WMzErWUtQOGVFSlk1Smp5YkpScGl4?= =?utf-8?B?MFdUWHRoVHpRaWN1ZTA5RTZnazdCUTFFcnhKZEYxcUg4TVZuaitZNG9nbkU4?= =?utf-8?B?TmtOc1pNUlRaK3I3KzI4SFMzYXJGRWZxRDcxSnhHRWs0RjlycjNCUTIyN2JH?= =?utf-8?B?bjhYQ1ltcElGYzNLQW5mVHozSmN6blNXL1RzTlpCNlZwWG9reGwrcC9ERjhy?= =?utf-8?B?d01aNXp4djZZNnJWVHJIcFlDcVB1Y29Pbjc0MVJ2U0hXenFaeDA2cEt0WGEr?= =?utf-8?B?SmlDTFVEZDgzNkRTMHIrdzZqQ0RiYTZaeXJWajJIa2swYU11cFhUT1dYL3h2?= =?utf-8?B?alVCNWtFMlk5b0xhaFZpbmNIWmpwYlhRWXVWUXUyaC9nRTFMVzltSlhLQndw?= =?utf-8?B?SEVCL1pOTExnMHZnV0JYSVdHaWFxWHZ6blFBQ2s0Rk9vOVE4Y1FKZUhrNENN?= =?utf-8?B?eGhTWHZyRmZwTkVscEg2UExwU3dUaVk4ekZNRllKNFA3WW54YklBb2gwVUJi?= =?utf-8?B?RVIyVnF2SnFTbzdXTGdybG8yQ3NiQmZsWFJOb0NxakFKTVVuSktOSU9odGZn?= =?utf-8?B?blhPc05OUHkxd0dzbVQvT1pGWVE4NXhKYTdFN0xzeFUvcm9ZOG9CUUFrWDla?= =?utf-8?B?eEI3OUNTYnJ4R3lFSU9CZHRmbHYvUFp4c2QzV25uVWhDYURvSXNZL3ZwRlFG?= =?utf-8?B?bERGVEt5V1dXNHhmTlNmc05waEdraCszVkhLWFBzUXVMTnZIQU1zbWNzd2l4?= =?utf-8?B?M1E9PQ==?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 777ff153-0641-4b9d-ab0e-08dde17564bb X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2025 12:14:07.4665 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TXvjKEQYSsKORiWh6xtYZGaaR75RC3rvLUfBrs5bRElK2LfuRPebP/wMyJpoRcHSJ7cSEP20sCAeXrN0KIYBdnKXwpRe5SQCYqtpYc4J0Oo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR02MB7725 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODIyMDExNCBTYWx0ZWRfX9LRRAVrRS6d9 J4xoDRCZY9J0/NByYLg2L9IEMKbQ+AT2dbILrW93aQo0ZaZJqSoRnYx/pLb6HpuOEU+6H8KqL/i ZSb3gAWiaf4nWwy3qq3vZ6oHFC/vReYBwluIVWygoSiwLVocVYfJ5lqxfhoXYu8w7w5lnfOsILP 8mbqavgolgKJJtLCSnWSI2ZyucXZtBNCBpq8ncvpFDatEKuqbb1yQhmdjXKXSn+eJ45y+SuIvMu Ck+r//a8QjkDkniKBT6VVNOGQtSTeZPXK+ZakPbJ+OTHAxD6kdQhJ+Y3MqYRBP7+uBbYmegyYoN PrjgG2RjitxWHmnOXfP4moF4NQuLmt9CKUReh26Q+KkS8Oh3MfSYi7LNa8ln+ka3FYYbR4FubKg p1GQLqolegwNLTfOXEikhNI6BcQ2lA== X-Proofpoint-GUID: OBtpBhWQOYA5n2a-KGJxuDOCj-x1qapf X-Proofpoint-ORIG-GUID: OBtpBhWQOYA5n2a-KGJxuDOCj-x1qapf X-Authority-Analysis: v=2.4 cv=Zsu0697G c=1 sm=1 tr=0 ts=68a85f11 cx=c_pps a=DmRYdR+pfzj2fdMzxedsIg==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=F9lpminiuFHZMRiaUDYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 a=cPQSjfK2_nFv0Q5t_7PE:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-22_04,2025-08-20_03,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1755865025561116601 These are based upon the PIIX4 PCI chipset and so can never be used on an i= sapc machine. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Xiaoyao Li --- hw/i386/pc_piix.c | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index da2de88383..e58a7b3977 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -441,8 +441,6 @@ static void pc_init_isa(MachineState *machine) MemoryRegion *system_memory =3D get_system_memory(); MemoryRegion *system_io =3D get_system_io(); ISABus *isa_bus; - Object *piix4_pm =3D NULL; - qemu_irq smi_irq; GSIState *gsi_state; MemoryRegion *ram_memory; MemoryRegion *rom_memory =3D system_memory; @@ -597,23 +595,6 @@ static void pc_init_isa(MachineState *machine) } #endif =20 - if (piix4_pm) { - smi_irq =3D qemu_allocate_irq(pc_acpi_smi_interrupt, first_cpu, 0); - - qdev_connect_gpio_out_named(DEVICE(piix4_pm), "smi-irq", 0, smi_ir= q); - pcms->smbus =3D I2C_BUS(qdev_get_child_bus(DEVICE(piix4_pm), "i2c"= )); - /* TODO: Populate SPD eeprom data. */ - smbus_eeprom_init(pcms->smbus, 8, NULL, 0); - - object_property_add_link(OBJECT(machine), PC_MACHINE_ACPI_DEVICE_P= ROP, - TYPE_HOTPLUG_HANDLER, - (Object **)&x86ms->acpi_dev, - object_property_allow_set_link, - OBJ_PROP_LINK_STRONG); - object_property_set_link(OBJECT(machine), PC_MACHINE_ACPI_DEVICE_P= ROP, - piix4_pm, &error_abort); - } - if (machine->nvdimms_state->is_enabled) { nvdimm_init_acpi_state(machine->nvdimms_state, system_io, x86_nvdimm_acpi_dsmio, --=20 2.43.0 From nobody Sat Nov 15 03:14:59 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1755865012; cv=pass; d=zohomail.com; s=zohoarc; b=B+lVx3XHV0BwZtHtWHZV9yNZzOUUOo411EXMKc0hGOOso+8V5RbsDUM1ckrEgo9Q0eIIrlZb4t8S1tmve7TQcKzNsZK4jgzlNNbLMmvDxGcXPuK9Za5qVdrVDNacRu7F6jgoazacqFo5vJsIDsgzbIuQkU9Enmcruk4r7/8G8Oo= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1755865012; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=N+qiT0nqUmdJhakAAc3rDiADkBdYEZ9eTC0ZLEQgrfU=; b=E8rYWdWRGc7PLoNxByRu4rE3bRgrvDGyHGM2Pwkvok+cbh8a2u/NdlBA/SChhGmtAb/CaZxaBjuC8aVcis35z+/hikmKHbORRpGoL0Nq9up6dOlQNw8ESBMNYwnVdkwJmtXTRiIGwLEmkEglmrYQNsBQ8U4iohmpmlsSESDK/s4= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1755865012935720.4867463087407; Fri, 22 Aug 2025 05:16:52 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1upQez-0001cO-QT; Fri, 22 Aug 2025 08:14:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upQew-0001bO-4J for qemu-devel@nongnu.org; Fri, 22 Aug 2025 08:14:18 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upQeu-0000gb-4s for qemu-devel@nongnu.org; Fri, 22 Aug 2025 08:14:17 -0400 Received: from pps.filterd (m0127843.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57M8KHZ7714386; Fri, 22 Aug 2025 05:14:13 -0700 Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12on2109.outbound.protection.outlook.com [40.107.237.109]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 48mye6qgdm-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 22 Aug 2025 05:14:12 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by SJ0PR02MB7725.namprd02.prod.outlook.com (2603:10b6:a03:322::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.24; Fri, 22 Aug 2025 12:14:11 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%3]) with mapi id 15.20.9052.014; Fri, 22 Aug 2025 12:14:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=N+qiT0nqUmdJhakAAc3rDiADkBdYEZ9eTC0ZLEQgr fU=; b=Q5kDOf3ToaO3OwzdKN84QmxDl3EnjA7pEXxVNaMib0EWg9dUSEruTsX/l h4zINbYNMnpfoUB9N0UmXGjXXJ9WRfOtmQ7Gt3tBnFc7O0btFCT3vkQZNGPdPxCk GEEgbTvGUi5NYM9V9gda2W+CPenffGkyGvpQE5z5fteIS99E3xA2C29Cjr/03OK4 pSXljPn4+DErRnaZtB1Paki7G/u3BbGErNbw3jmdGbxeAGUF+cwkEp4QMSyHc6uW itDiRiSq/urzqZkoGrOxyN8P46Tv/tR4irHIgO5+6OSPGZXQJxHIlOv7PJa1NGcn RNqkVAayjZT1RamsYG/ojJK63aL+g== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UI+bWCtUjrJDfJlK1N6wP6iNVQwq8iav9Nhrq0DIlJrPeRr3uR6qCSF58TiXO+Wmvre3ij/7JIQVB0VYux8mPHrby5enlbypBF/Z+OUvHEiyafCkdBS/AA+79p/PBgV9Mngv0yRE3tlocus2m2jWYk1jyGJGZJSp9bD/ytiBunnSMf5vgRF0U2WnY29flPLrzu2VsmPtqB/2W4pXBj9zzJV0bDzqSGTPS689dPZBsJDyos2Ztrcwv6Q+1tghluQiuqbs6AkDMT7GaGpzRlgp3WxJpHgH0AtJE9HR4VthfhO/st/z33BlAXQx0uVsjRai/3oPqn40OwjcHtbrrLLeCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N+qiT0nqUmdJhakAAc3rDiADkBdYEZ9eTC0ZLEQgrfU=; b=S1JJ04uSfFtCBJBicR4FX1SEpUutYxZlxnkHDOeL0hmB3d0CLOvk/Xcd+1R1vQ7JHuLSjoI9UhZ38IAGawOTA8ocxN7nwMj6i9lv7C15TvL0gJR/IAYC1LhuIatY8Y177cCYM+5GOg4yzfpZ1soyY1U/GjvSJD0vqSv/95Aq74uyt9lXMChi9VEj8jPMiz5wGHBsUXSKTvsx3vaJ7vPxQJBdbfGs756sj2BmRBsaEb4pJMTo4tOWu4Ts2TAj+QjeyEcENLRU8HcLD8gurzb3xfPhijMA86BENSFQTV91MJZA1/mZGXCBbazAMFWV23P56LT4wyDOmouRqcLnGhogLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N+qiT0nqUmdJhakAAc3rDiADkBdYEZ9eTC0ZLEQgrfU=; b=PAEPvFgcUwn9RuP0JfYAw5z+gZpno6zkNmBV9qPS91hN2I2FjpW8L/y2lBGRKk/CANdNXfWwEXLttjoCW6FLJ0OBksjiUAcVu32tO/hw6VEX5JuObeDEOPaOrqnwVazUKkKRN8nUm8tHsMO6adLjavdnOs5trvS6FYV3KsoZA1BgtrSfAPHc0D0+dSbiHVclj9lwL4GBtCHeA6gXv994tgHTNUgkltRi4/MVviLOhX72pfBYzKOJ5UwmQ3YgAJ2FeXOdwT+WFNaiw9Iqv7FzJZKae2VjQP0yd5Dzr9jMvb96dvLMnnoZeGDfw72VzLS7gKe7Bi1tezLs4nS/j1iJcQ== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v6 07/19] hw/i386/pc_piix.c: remove SGX initialisation from pc_init_isa() Date: Fri, 22 Aug 2025 13:11:53 +0100 Message-ID: <20250822121342.894223-8-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250822121342.894223-1-mark.caveayland@nutanix.com> References: <20250822121342.894223-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS4PR10CA0030.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:5d8::11) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|SJ0PR02MB7725:EE_ X-MS-Office365-Filtering-Correlation-Id: 19d01d1a-afcb-48a8-c17a-08dde1756720 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?lfQCKdQpH87ig5S174oSTUEb9x/sY6P65p8CbPF5P7vfXapyuKpEj8rIEsEE?= =?us-ascii?Q?sewFvLQ18WkBoQEc3dM0ox+HncoxYc5s1kh2WIHTC1wBhMA1g0rsUmw2wMV0?= =?us-ascii?Q?mKmlLH/MQSgmLbtxoUqS51ET1Cqqvo1RPrbDjw27lJd8QpuiCrCCxJ5CmAsN?= =?us-ascii?Q?ujOq/O977P50eiFLKEx1zv4OAsro8hx/oVTsFvA3+osqSLDgPe2UbPbvuhMy?= =?us-ascii?Q?AYhZqfQgRUvPW2ycgsC0XYB4hnp0q10KvOxSVbaMdwiWMfWVvzNCswc5kJIQ?= =?us-ascii?Q?KVjvv32Ia9S+9kBPPL1Qm4+PrB6ZN0caNDp4TDSPyLPNJSXcKXjgJCusS952?= =?us-ascii?Q?ews9eY856678Kfkrn1s2LeqTaPIgVnUTGDGh0pWfi8ljR0SszSbzWxsWPO9s?= =?us-ascii?Q?HmLp2Ftd3SQuEaTO3vNUOk5noYO7U70THsuZI5+Mkbz71vMIzn3Uqpi+q3E7?= =?us-ascii?Q?z8dm0bb1wveMQKTXS5Jroez8dHWd0PKa9D4WWH6B6SdlKFz6m9JoBDjaW3Su?= =?us-ascii?Q?e9La4/AuP/+M5rFhl9sUTPXSplfQT6PU17xRnnGZsq3sAK0T25YT+PCztz99?= =?us-ascii?Q?gMpsbvbtL+lM56VzLRWC7obJCD+gVzIRcWxG9HtUo5tGEaEI5VkkhibN5w3r?= =?us-ascii?Q?9o4JE1fMOH6dlvbapYke8hr6MLnNSL9IDjLRq/8YZeI/qMdzQrYQHttMcOP5?= =?us-ascii?Q?u4GYa6iHdQZFBJCvhluvXmacFcLjE40l0k69wJAkdMGcSVEJmWcl4cn/8dy5?= =?us-ascii?Q?dMPQInL1YnbSzd5PM4dkpTRz+BqDyU8enEOiIYzPVWkZrAUM1OXPlElKr1OQ?= =?us-ascii?Q?l8qoo8VlH7lR5ffOELnLFjvf4vB8X4PkwUSrBy8hOSkdCmswQ0OlSWO/KD8c?= =?us-ascii?Q?AwWQMHjFE3TYQyGbYUw+DFlYy6yr2T7CykhzGt1/n/X2JYBI+iOezSDvZTiL?= =?us-ascii?Q?o3mHrWDKExS6IfdfbdmaexxDucpQ0EaWewjhNTMMY/k324mWar/iUfzdvgzo?= =?us-ascii?Q?hJWSnGYebWbwCMfKScHFl7kezXahUw7Ul5TwplSz7/3TwnHAJ5cVw9+QztAq?= =?us-ascii?Q?LDWfulL0XzK7vpIhuYazUkTYpXQet8K4mFhI4xAwQ79fqlrKlg0KfMOK1fOS?= =?us-ascii?Q?dEy+VzFiSlvLLhAZ3ZK2j1RwY7Nx6w++5dJfsIdoU4azBltd2oSq6X6AvxNW?= =?us-ascii?Q?lFU2GuEEwfJ885eogN04dniRNksXGiUefsEH4D2FQWfyn6of7iS+Bh92F4vG?= =?us-ascii?Q?ISeP3huUa7g04CxcBVyYNpcSAKM+C2BDLCmredDlwFLsLkAQKVbl7YZTO6Yu?= =?us-ascii?Q?RK3Qvmzs5xjqLhEV2KEC7EOropZGiTPElA111XFmG4inKsSlG7lTnCIAiPsU?= =?us-ascii?Q?sM4x+Bjn9rPMq6RMVpy6tpDuvz0L5ERBJ7UTlbsfFTYpuJUgcZK1f0IF8H6R?= =?us-ascii?Q?jKeH2lKIxrs=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?GulMMRJOpBVC9cS311nzzccFEijBusPpEM3Uav1iJi29Y3OpU16kgT1ndSb9?= =?us-ascii?Q?UjnzqZQlJdItBujdA40tP1OVGbDf7IdUrLNHr+8DIkeCRnC6NS2uUTx4a1Ml?= =?us-ascii?Q?iqIy+XvH3UTOgKvfTPkP790S7wY9Z6fhY+VQ9i3oODJ07pw27LdToZdkqC6X?= =?us-ascii?Q?rzLjiOo9Tyxiloma4aVYIj+DMzEwdcZUD/+eZCfazuL8YnBlo4JuUkwf+dSs?= =?us-ascii?Q?LdgOpEKlBEjIPKuXNrZyfkU4ib+ZnOcvtrHrg1foiNG6mf338BcCw+VKztBF?= =?us-ascii?Q?C/sSksjcauyEKOYlqgGbCzdrFdW3V9LvVW5K7QdYXoufI7Z4j7ICXMlnxMmv?= =?us-ascii?Q?fAxic4Jw+sEYU02jfGgwcP7P/6fqO68VUazs3rniaMgZrj1BAFnwCYky6g9p?= =?us-ascii?Q?6rZxgzz4kO7WzGCZfnriNUga+f4r1DEc/hSq1ugVdyfmSYF4zXy30t9hCcsH?= =?us-ascii?Q?BnW+XJgQvWLAmU9nGpJcqrH/m//27z24uQ+4nnDXeTDySOfr66ySMHjbHn2R?= =?us-ascii?Q?A1wJCr1wz13O8h/gsaKPuu5bGPJsPZc/Y0sw0V3XgcNEiITNjHa7OUzIxOBt?= =?us-ascii?Q?VfHCgeB/zr37rPGXzJHlObQUBJ1CT/Q2HS2g/tzIQTCkN5EG0LK8Ivzq0wmT?= =?us-ascii?Q?TL0UKI2UWI7qiNgfvNLZ1p82AdzqsIisUibj/spu8qRwvE3g7HFX0+XDktCz?= =?us-ascii?Q?7w+ggR0hJfFnHEIQ99Imn+eEbtUCgX27NRmgcB3HUm2anVSGTgpjA8JxeDm2?= =?us-ascii?Q?vwR6YRA/r26bmMhcwB3stvgDAWM48j51UHH1LDLF9jTg3V8ofUKETpbRRX6M?= =?us-ascii?Q?owTAwuRR8uqHQP3DL8CuvSvt2ClBjUrchZYjJdmJIRcnSS+UHwAElZWadMoA?= =?us-ascii?Q?qrb6KceZq+LHMU7x7KAHsi9P0Wej4FSrQJ3s2nXAHEqv4ETSQynXMGDlcXom?= =?us-ascii?Q?W5+gx8NGKDiDGr/fr/PcCIIMbo5d8gwjN5Ei/SKO9BFeqhzBBEkHnbNzNxLd?= =?us-ascii?Q?cZ7IhQTPr1zwoQw5SAPutgu2nWW7sZf6aK7ZRXTFVQiYIL3po46mUL9qyiby?= =?us-ascii?Q?S43Xl+lSH4cmlg9nZxTh1ju9DpYMo3K4aSKrzJYV/HDrpBIjERBoIkauP4Pj?= =?us-ascii?Q?AmpZz76cMJmBvVKfk9FHEM9KcQ32mmuSCziz44bdiTnVNAQIA5syfGIDfrvQ?= =?us-ascii?Q?TzbvogKd3xPd1EFBdX73TJthdUJNaKSjMPqPEr41tNMYamF3nhGzdA/+ilWq?= =?us-ascii?Q?nKZD5KO0VDEMxBFPyoFqiyisp3aDFvI5bbq/TipesjNx4Nu3lCblRZaAxjiz?= =?us-ascii?Q?a53p7bdFucUBh6ZG0y5WzyQrRcOPoxTqsNSq+CoFDUMOvM52+3YXdq50RbK9?= =?us-ascii?Q?vKT7tuUppkzy2cFqe+lYTekXThtH9j8zbAgqPcKtTFiIez1miNx6wN6rHWqB?= =?us-ascii?Q?u85f+wFvRt/Oij4ysl0NCkeWduPVd8p7u+LYGdfzZ8fXBFeybHXMQAv7x83q?= =?us-ascii?Q?HM+jaUwKX3hNdvzQmuH99ufqviuJpnUmKWvBYJxkk2b7sVl/RqHQ/qyUazYq?= =?us-ascii?Q?EpGBFSjkbUXFKXksegwFKz1j7OLkYGUusQNr3zxtcGHol42cUU9BJzNY7DOo?= =?us-ascii?Q?rQ=3D=3D?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 19d01d1a-afcb-48a8-c17a-08dde1756720 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2025 12:14:11.6418 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1UIGel5KroYwrwXSyn51GUO1v8SAvIyVf3LRXk9KbRxv4O2jTjJekO+E6fTmiEGKwictoTjY8Y6fylJYJDif/b8sGscA04iJSOGEtmMPoJ4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR02MB7725 X-Proofpoint-ORIG-GUID: iqPVchY2hmTX1Q1dOsdiKHvwtAilS_Yg X-Authority-Analysis: v=2.4 cv=QLwxhgLL c=1 sm=1 tr=0 ts=68a85f15 cx=c_pps a=IZtX7zTm26LBIsBaguIpxw==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=2OwXVqhp2XgA:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=yiTRickECGlooSfTVXsA:9 a=cPQSjfK2_nFv0Q5t_7PE:22 X-Proofpoint-GUID: iqPVchY2hmTX1Q1dOsdiKHvwtAilS_Yg X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODIyMDExNCBTYWx0ZWRfX3YU2pwwhbBe3 zv8bsLxgqdG1VpIS1yl/l4L4dk96WPkUufiMFs7r6jfl7QQdN+pTZ3V1ef46I5sbQZkaSXiljq6 vHfIGdGWbhm0Dlab+bG/54ag7Y04djMdpdFqkbrJZJUYqswCdHEoIZ5aJ1fDc0S9e7Eo7/NAukR Fj0xofBa0HMWPgnTjYNUnourRkr5mY3u1gxxXoGvBqTsJjacLfriszw0uEx4VsdKaU253e4lOtf 7GVDkRQeBGkTXeVoC4tZbfyW7Kv8YY5I+sq4HBWIu8ni/PsqB+XFoZosabUEz/qwvO2PSn40dhk TrSJp1+K/EpdxjnsFpiCY+CwqKdnZ0vJN8gUXY52yX9g4716i1SXNzTSgPddmZ8DB70Hr+nEs4J /MQ7khQB+aijGa1Deb4cWAWz45I3Qg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-22_04,2025-08-20_03,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1755865014011124100 Content-Type: text/plain; charset="utf-8" The Intel SGX instructions only exist on recent CPUs and so would never be = available on a CPU from the pre-PCI era. Signed-off-by: Mark Cave-Ayland Reviewed-by: Xiaoyao Li --- hw/i386/pc_piix.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index e58a7b3977..129a3e2524 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -509,8 +509,6 @@ static void pc_init_isa(MachineState *machine) } } =20 - pc_machine_init_sgx_epc(pcms); - /* * There is a small chance that someone unintentionally passes "-cpu m= ax" * for the isapc machine, which will provide a much more modern 32-bit --=20 2.43.0 From nobody Sat Nov 15 03:14:59 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1755864910; cv=pass; d=zohomail.com; s=zohoarc; b=ij+h9Nnx+n0mEaSNyAhpoySuUy1HYmIfu2OqWOJYhRSP6dS8JvR9zfbD7PXLyx+VInLO6sMBILKkYQN2RHgVvfxK8TXi2h6l1r04vNWNkbXiQPpbERSjALw9CfahMB5viVJne7lYHmN0L3QK8/t0Spq3m5rcb7TRtKmt8OloKVU= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1755864910; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=oMENsTxKAzt+cZ2f4vsSr6hMerF2FMMiy3ZsC8SQDAc=; b=HdJUcrisS2w4F0lvfomtty6wA4AVU/MOROVPATxSc3kQ41Ss/wDFqY1jKce90fGVlgv7d9B7P6ZKEditkfdyuLI0d5f9OoCtq7us4DyfUurbTrvRd+4dVdVGBbFM+bruM/E73dN7w2o6WHzT96X/u/X9hHm4HQCjBTGA29OcIIk= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1755864910867394.76692105407983; Fri, 22 Aug 2025 05:15:10 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1upQf1-0001dC-Hm; Fri, 22 Aug 2025 08:14:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upQez-0001cQ-6n for qemu-devel@nongnu.org; Fri, 22 Aug 2025 08:14:21 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upQex-0000h3-18 for qemu-devel@nongnu.org; Fri, 22 Aug 2025 08:14:20 -0400 Received: from pps.filterd (m0127843.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57M8ANuC713908; Fri, 22 Aug 2025 05:14:17 -0700 Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12on2123.outbound.protection.outlook.com [40.107.237.123]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 48mye6qgdt-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 22 Aug 2025 05:14:17 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by SJ0PR02MB7725.namprd02.prod.outlook.com (2603:10b6:a03:322::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.24; Fri, 22 Aug 2025 12:14:15 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%3]) with mapi id 15.20.9052.014; Fri, 22 Aug 2025 12:14:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=oMENsTxKAzt+cZ2f4vsSr6hMerF2FMMiy3ZsC8SQD Ac=; b=WMOh1VDsXb9wDUk9fnu2RkfZkgHygcL8LdGenj1I4fhCtfygWUkuSqrxi 0l9EJ77z28OMycLH+YqH3L2XlvUms4+kD8Lm6dRCgiloWjtYi1uxtqvgzQ7KsH6+ 74bhr8j74r9YYgZmlP0d/QzdNGLdW1I6tAs0KWKF1yOwrQQZTRtSQEF5yYZXGWdX zxrkBOmf4mGgMeJmzPXLPsTfUgX+iI7bT7EU23nAcHTuuRW2F1+q+g9XXK4H2nEX OnmKo0C6b+JKp/mgFKWeFTzZSkTpxfL9Dx/xME28Zkt2AZA1kFpOYijV+lHDaQFW 1FdRoC6O+ZoKL/pOJbHSvr1n0y96A== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BtWQaaNlooIR7s3imlpd8zwZVH3+FQ3Fgx22yrqgeduoNj22m/9gHnGNNqGSm8t9ydJ90ThKrCPWrZ5St+33SYIdAJm0BQwIlEI9kpTjfrjKzHLnD/R2EfoHLz0RjZIDKKnOk1w1nMs2RDx+Wh0uaXhVclt+XDoQKkUyGbsPUPLqJiFwGiERVw40JeB+XprYoTZCgpXK+EUF23k0a9cyqLwtg4zpWa41DFcLiPnBgBydpmqix6x4FcQXytjSTbtP7GwgU9lPXcwmNSZbxtqn1sLt+MmzczHJ2uhSCqnEjDzOoZ37z3hdkqixuJhE2LMKkM2K0sPawwt/RUHTxQ5KXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oMENsTxKAzt+cZ2f4vsSr6hMerF2FMMiy3ZsC8SQDAc=; b=Ebzq7XfCHOoH4e2sGzTOCgweyQ+fCs7LzLh0l2RJ2Vx09bApFOpz3NWBu2chWmzT788a2zSkNTBOU8zyyoNQGJzv5kHWagKFblHI3QGlU0u4sfq2GBsUlz9i47mpECVJolX6ssJ0VRSOP3YI/E/6WqaruJeqoShAenPKKBfM/zECOHl+D2w1NtUrzvM8eoOjtg1HN/UswkdG7+qKnbXjmw9XBEqPX4BFhm6/y7nWN75Q9eIMTdLOP8s/7kMikl6eoXrF6cwQ5Oo2qnVBmcOSP/cslfJlfpwGI1ZlChg+h5S8r8SoaOzfeyrHmYU1YhMeMu22w1Pmz5cEQ/Dstl8cQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oMENsTxKAzt+cZ2f4vsSr6hMerF2FMMiy3ZsC8SQDAc=; b=UjtEGs3m11gk0jX5omaD6XQ3izZy7VEx+eGgLc1XF/2mVnFY6GWQAdNg47IxLRw1pYx0KbcS3dAun6r2x7YdFtLwKXt38E4zw/sq3u8bnHDwknzhRk3npTJC52C8eMo3f0CLoGSceDd5gG2YgrUfzMx4q9OAaSum/olLPMgXjHkzuiz03d9bwwjjfHTRwVjI7vXgfhseq/rIv/edQdwID7dNSSzwonD55qVNf7g8Ixi1BNhBojqEJeTFdRm11RM1rWANxKyPMQcM3Qm0pUcOVHxT7VKJJ2mZl/c9/iG2jkdhs5hgDnQButaUXVytj5Gq40SV1uilnou+1cOi7vtG0g== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v6 08/19] hw/i386/pc_piix.c: remove nvdimm initialisation from pc_init_isa() Date: Fri, 22 Aug 2025 13:11:54 +0100 Message-ID: <20250822121342.894223-9-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250822121342.894223-1-mark.caveayland@nutanix.com> References: <20250822121342.894223-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM0PR03CA0009.eurprd03.prod.outlook.com (2603:10a6:208:14::22) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|SJ0PR02MB7725:EE_ X-MS-Office365-Filtering-Correlation-Id: 0f2cdf46-9ba7-42fb-4933-08dde1756981 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?b0JsQVI2M0tYVi92Z3Z1eVE2aXdjMzI1eGdVL3lJU05MUy9HR09YaDRCTW1B?= =?utf-8?B?aWNoVmsrK25Uazd6SjVpR1l4U1hCcmw2OU8vczRPZ1UydjEyUUVWRVA5NE9w?= =?utf-8?B?NVJtNGlJU2ZGb3VWOVlMZklJR2ZsSXJLQ0FQZFdVS1MwNTU1QnMwclo0R1N2?= =?utf-8?B?b3ZPNmtGME1hcjZEbGNDK1ZheTdabDZrTHl0SUtjUE1UekZmdzRRdUcyb1Rr?= =?utf-8?B?OVp5V2VlclJFVVdJTU1mQVlJYnFlcytsS0dyRVJ2dXBJQ0Zka3o3TXJrcWEy?= =?utf-8?B?UHR3emFUczhoY3BNS0NmcndjcnU2N2ZwNkF2Z0tRSytYZThhR0dEZ0Q0dTQ5?= =?utf-8?B?OFpZSTV4T29ua2dISkV3SVE5cEJYTy8vdkRheDhKVW9tMHduc3NLN2xVak05?= =?utf-8?B?cVJjUmdRK1dKcFoydFVzWHV0SHd0emJsSUgzU2RoRVNrcTJkK0FyOE9Ub3JN?= =?utf-8?B?NG9KNXpTWVBickZ2MC9GVWF0WldWYndwak1FSjZPYXlTeW9iSWpoTWVKU1U4?= =?utf-8?B?LzEyT1BkZXNycTcvOW1SRUwrbmJkZFJDLzM2WnJOaFNXOHRoRlcwcFRxQXFi?= =?utf-8?B?MGx4cUxKL3hDNFFtMW9zd2k3QkxmSy81Vng2NExINFQzSkRETEFLVjhJYk9k?= =?utf-8?B?OVhCWVB2ZWxWekZTc3ltQjNiZVpnbXJvTDFNS3ovamlSUDBoenVTVnk5a1NH?= =?utf-8?B?cTJqdHNWRUE4SndnbUZ0dGpvS3Rua2lVMDdRMlpERG9XRGN3TjBLWTJyRTdt?= =?utf-8?B?cnFRN1E3V242elJjKzlkcnUxTlBFVVRxSlc5Y0Jqelo2VWdZT2tsRHVFd3Rz?= =?utf-8?B?SlN6OS9FR2NwNHBIQ1hSNG94Y1M4Z1RMd1c5aGRMeEZiSEF0NTBjZWFoVndr?= =?utf-8?B?cGtYMjNtbXRDQmJiZTRYNkNZRkVQdWFNbDRqMDRabnV4YTVobDhOSDVJdlI2?= =?utf-8?B?OWExWnZVNWprN3hUM21OUmtTNnp2c1FDd0NhcXFCYi9idVFHLzhiQnVWOHdC?= =?utf-8?B?WHJzSFl5dHNsYUR3N2ptMVBiQWN6MTVqL2d3bk5ERDJhdTI2dXFBTm5aSW1j?= =?utf-8?B?a0lSdnUreklNRmM4V0xHckZ1OXBaUTVuaHF2YjJXU1dZai91aVp1UThhdGxS?= =?utf-8?B?bUhKRW94dlZTRGtlN0pYMTBMYU52aFkwdjJ5dWFseGcvejRCRDhIbEZKOW1w?= =?utf-8?B?UjZoRXltVDY1Nlp2ZzdibWFqYjU1YTNzNjNybS9BUGpnTEdOdzJhVTVsckhJ?= =?utf-8?B?eC92U2U2bE1wdFNPbHRSWDZ6aHVHZ2pmMCtkN2Y4cm1qSUo3aHhydjNQYzZB?= =?utf-8?B?c1pIbk4vcmJlNTluODd4WUtya2dOVHFVbUkySUdvYVlJZThEN2JuYU9KOXZi?= =?utf-8?B?dFlUSktKdWRmbkNKSWRpSWp4VHgxa05UN1d5cTZhUEh2cG16UWd2czdVaXdN?= =?utf-8?B?QjJDTUg4MVpyOVhtOExBY1d1WDNZdDliVDY1b3JJTEh3dmFGdUpvTnRxTHBa?= =?utf-8?B?QVAwNEEwK1VMbUxGSSt1MHRETy8rS1RVOGhvTFlIZEFuZVFxQ1RXZVV1dzBN?= =?utf-8?B?Z1lqWi9DRElRYzhUTGVOcElRWWtmTkIwOE14N1FpVC9zSXhNR3lxTjJpUVZq?= =?utf-8?B?OVJ5dFM5NUZwWk11dHdRMlcwM09kbkhNcjcrTkkxWEY0WExaOFc3VjZ4QTJU?= =?utf-8?B?TEtITEdYKzN3M2dvdnd1N1NGZ2xSOTZ2cjRpN0xSaGRUMk1BOVdNajIwOFBw?= =?utf-8?B?YVB0WGIvZFBCaGZLNkh1bzI5b1piY252d011Y3ZteFdtUkZ0dExPMGRpRHBp?= =?utf-8?B?MnZyTnQ5VFJkU2pnVWt2MGRmNklQUjc1YkhHd1FHTkJLZnlEQzJ2a0FMa2tt?= =?utf-8?B?UkpFOTJvcW9aTXkwR2lib1dvTG9WZ1l1MTVpdC9vNGg2RnkyT2xkT2dnb1VE?= =?utf-8?Q?V73Y8vTRthg=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Yjc3QmNmMldZVmRXeHF3b3hXWUVhUmFkbXZLTUx6R0VhREJONkZRRVB1dWxE?= =?utf-8?B?NEJsbGE1V1pWT2ExcHR6dXIrNkxXbC81RDBaNWEwWEh4a1J6cUlLVUc3WEpi?= =?utf-8?B?Vm8xckcvSk9xd2NqMlJmQ2VEekZIN3BrbW1mUXREbFZxeVduSzh3UkRZYXg4?= =?utf-8?B?aHJTN3dkMG8vVkJ4NHVoeVgyTHdtdVZlSUtGY0NMQWRidmp1MWU4cEk4Z0VT?= =?utf-8?B?cFZnQUw3Z2UzbkZCYlpDQmpaSnBrSGUyVGk0TXRBbGZWekduZTZCcU5WRjYr?= =?utf-8?B?d3MrUHc3MVQra2FvT2RKL2h4eTN2OUkwdTZabnRGcG9aOGRwSnVBb0lMK0Nw?= =?utf-8?B?b1Nqem13azhtZHVoOHRTZENON3ZTRERjcTl6M3FrMGFvUUFkNnQ2RWNXdENj?= =?utf-8?B?Sk1xb1pZaHVCSEw3UmFQQXZLNEJ4NitGd1NhdnZBYlhYSmkwQ0haZ21DVkhU?= =?utf-8?B?MDRZbWpXbDJuWFd5cTNQTGI4dVZlVE41bGh3RU9paVJ0R3NLdGxLdllHNG9j?= =?utf-8?B?Qmk4aVVWREh4MHIzUGNsV2ZUaklhTmM5dVgyZXA5WVVjRE1sZVZXS1JEanp5?= =?utf-8?B?VDRxcWcvRzBiNE9GSkE1MGJCeW5RTkpwdEhkSnduWWx6cTRQa2JzdWUrTVRI?= =?utf-8?B?YkZCRG10SDhKZnFEUXRCaUtJU0dMeFpINk0yVmIxRnJWbkFobnAzT0tvMU5B?= =?utf-8?B?U0NEd3J6RllSb2paMnY1Q0lGNmM0R0RGVVAyNVJydXJvTThHZUZLcS9wZzRN?= =?utf-8?B?eURIOUxoa0lFWStoUTdIMEt2OFNkZkdvZllveGFEV1JTQ09yaDFzOTF4NldD?= =?utf-8?B?M21wUmV2bytZWXhRU3hDelNWaWJBYVBjVkVkb0VqYUVHTGNRakZWT1FOei9M?= =?utf-8?B?UVM5cFhYalBoZE5iaFkyQWhyQ2dDWkJpdkdqUXBjQXl1RUFyQk83cTRxYkdO?= =?utf-8?B?YndJcHBHS0w4Y1Y5bk9jeEJaNDBSWGV5VjVMa0FINDRPRENiM1pxUEtkdFp1?= =?utf-8?B?QVd0c3FMUzl5N0dxamJVWGVYbUJraHhoTlBYMWl4SWJIcDYzNm5QNm1UdUFV?= =?utf-8?B?eW52Uk1SeGlvNGNBSHJvdzMvTnBBZ0JZRFBQZUJLa3NrbDlwSXBqVDAwNnU0?= =?utf-8?B?WXZkRmczbVEra3g0STFpQzhnbjlSVWRCSXorRUtaUzJlREZQd0djY1RnUlZw?= =?utf-8?B?ZkF1QjhuN2Q4OFlSZE5Mc0VLOW5qY25KbGd2ZlNneUFtaVFEMWpRVGZuU2hy?= =?utf-8?B?TWwySmg0QnVJaUc0WnRRMmdRQWg0SitMQ3VTbUdQOG1NMUtnTjByZ1B0UnVR?= =?utf-8?B?WGRyeWNONkcweUVVVW1HWndCYkNPOU15Wjg5cFRUV05OU1dReDgwSEZpYWhY?= =?utf-8?B?Yld5NUNpamxhWHlLWFZ5SWxmL0Y4eWttQ203RjBaTnBBZVp5MnE3QzBMSFhm?= =?utf-8?B?ejhuOFVpRk9XWHpwYm9JTDJETFYrMkczclhKajJzN2hOdisxVGNPYmN4NHFR?= =?utf-8?B?TWdSc2FGS1lVQ01BZWpESVQzLzZ6aHJkQVJIZVZLSlJtNDJqek5wL0Z2VVlR?= =?utf-8?B?RWtWTytpVEtTWGJ0ZjZ6TUlLQzlKTE5UVHB4cnVORHhVK2pRK2I4YjByY3BN?= =?utf-8?B?SHR6a1MyUmFYc1d1ekw1RzZJZ3hQdkxRUStqaFErdWhuMkxIODVmZlhUYitj?= =?utf-8?B?ZGdmVTVadkwyRGxYVCsrUnFRcWNYaDRScnljajNnZXdyNXZQS0R1ajBBOFhR?= =?utf-8?B?bjZYbDFjb1p5NGJVa2EyUGJGc2dXcXlqRG4remdhc3RyZWxiNUZEUHQwbGlZ?= =?utf-8?B?Z1ZIRjFmWHhFbTkzbmxpL3FIOHdWeGRPNE9nRkZsV01pRktPZkkyc25IYkdT?= =?utf-8?B?VmsrbHFLMCtRNVg4MjhiY3p5YVFnU2RoVWs1MHRqNktaeHphOStxTUJVdzdM?= =?utf-8?B?WFhubVlWMG9kelhjaklad1IxZ0FHb1NwdDNIVkJwVVZBYm1EQ3lkdTRrME01?= =?utf-8?B?dVFsbENqWG5NVEVONTZUS1hWMHBpcVp2RndYVUY1RHBad08zQzdSS3YyOEtj?= =?utf-8?B?K0wxekIzcDY0ejhpaWJROENFVFY2eVIxTFpQSllrNGpXWHJ2SW8zSzRxRkhh?= =?utf-8?B?YVh0R0tIUFNOeENpVUk2L0Frck9yM0h1T3ZVLzA5N1RtZjNuUmJMdW1zTytH?= =?utf-8?B?L1E9PQ==?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0f2cdf46-9ba7-42fb-4933-08dde1756981 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2025 12:14:15.5820 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GjhJGTYD0A6UOVv6z7eC96WGxvH3CxEH6YQIu/ebqi6yAROkO6eWfqPJTQBID68GS7SHCNf8tgqizMJV0UKBKXlWKeZ5fokyuFEwtVYT6x8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR02MB7725 X-Proofpoint-ORIG-GUID: hJqLuYdOrRp_Jm7ceiu1DvbhOJipiB66 X-Authority-Analysis: v=2.4 cv=QLwxhgLL c=1 sm=1 tr=0 ts=68a85f19 cx=c_pps a=sXP4CBoXI4FFEMmoTRPjnQ==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=XL6wrB0Zc_gxRR1ig4QA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 a=cPQSjfK2_nFv0Q5t_7PE:22 X-Proofpoint-GUID: hJqLuYdOrRp_Jm7ceiu1DvbhOJipiB66 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODIyMDExNCBTYWx0ZWRfX/zXBZaGr8Mwx b+DJGOWRi7T0rU6DQ8AldfTrSymdhsOuTlg82fYCoGmEwhAFxZ0QdQoh50sqQ0yPG3axEu34zeK 3/LGn48lkeGOdSofCf2VSWQwLNGbTlDW4BXpgA97uko+stbJOdlG3DPX76CgA+7lyyXYEUCJwa/ eD4iNhZSDin292tLuVY8fs3hXMhHHYVDWRokmGj0qToqWajIjqGUVk7ZxlJ7vDYdkro0QEu5WDf Bi0ryuOCR2xMOawDJYrajq106KIJr+YbbgBjmpFjm5xi+RC/t6zBsXaOwlXe7IR6FkqKaCgEmS+ ahzW1G5lV3CE+NmXYwbnU77kX8xG0OmFZU3I2tpcp/njBWyZHVI4eR/DD718ZhcsdVoE2JajygY y9XClz506x9FNEHNE/Pjz7smyUKgyA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-22_04,2025-08-20_03,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1755864911862116600 NVDIMMs cannot be used by PCs from a pre-PCI era. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Xiaoyao Li --- hw/i386/pc_piix.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 129a3e2524..816124c027 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -592,12 +592,6 @@ static void pc_init_isa(MachineState *machine) } } #endif - - if (machine->nvdimms_state->is_enabled) { - nvdimm_init_acpi_state(machine->nvdimms_state, system_io, - x86_nvdimm_acpi_dsmio, - x86ms->fw_cfg, OBJECT(pcms)); - } } #endif =20 --=20 2.43.0 From nobody Sat Nov 15 03:14:59 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1755865494; cv=pass; d=zohomail.com; s=zohoarc; b=JE79fdAOrpWaArB8ovAUYiB19TnuP/g5T8EyHyse83a4LgN6s4USl/9z2yWYN3DYpZfN13rGK8YulQa/zxYc273wS4TsTUPpHbJQu9Uq+pK4l72vyoHBKElcCohIsMHjtnVnCORJmp3cyNFSCenJVs7tew5l9OrfYESIevfSl6E= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1755865494; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=dWFWovc2KtPVIaOEbxetuia65GMUJCJkkmz1pITsBng=; b=QJKJnsm/RV3jURaMhmvlM0KWGYmjAkx2ZMX7OStpk0My/DF5Z2LA//JQvx6Sw24vcuwe6Lo7gu9rc0Cx7KLKix1q2DBlt705MS+AWw4MXnMcSL3LcxHb0XzS9YAlqbQI2A3Cq1oM9M7KWgFc23CxdREzGK35Psb66H62BDQvdhg= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1755865494043558.0291616161821; Fri, 22 Aug 2025 05:24:54 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1upQf4-0001eE-4s; Fri, 22 Aug 2025 08:14:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upQf2-0001ds-JE for qemu-devel@nongnu.org; Fri, 22 Aug 2025 08:14:24 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upQf0-0000hS-Ej for qemu-devel@nongnu.org; Fri, 22 Aug 2025 08:14:24 -0400 Received: from pps.filterd (m0127842.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57M8QQU8656691; Fri, 22 Aug 2025 05:14:20 -0700 Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12on2098.outbound.protection.outlook.com [40.107.237.98]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 48mye7yjfv-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 22 Aug 2025 05:14:20 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by SJ0PR02MB7725.namprd02.prod.outlook.com (2603:10b6:a03:322::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.24; Fri, 22 Aug 2025 12:14:19 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%3]) with mapi id 15.20.9052.014; Fri, 22 Aug 2025 12:14:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=dWFWovc2KtPVIaOEbxetuia65GMUJCJkkmz1pITsB ng=; b=v1FnDGoXmADQ6BEpEXnNXyoBKXASwefXehSdxdLlagLyKbLXt9uHj0e0E IrZC5zQYMrBCbhBk/sOKbFP1R6tZmuKOI2uGLcWrsAZjMMXvvl9LptjQL99I3M3R 4KETIc4Me78AuEcd4X1no4IufOBaeoZqf5fsYSxPNE+lOk32uRIxCoyhnvSpOdlg YQLIZ0EVs+wKEQZAMEZHS8ExVzFR1nknNCwi9BKPxkXz1qp808uT2oaP48ET+ZM1 VoJqvlpwLHVvDbtcGfp+TgUtE778s0z4cDmRNsy6OZVzu9JHwOwXhJfoanw9LYvn vwR/BLOBx2CcL5U8iV69H93E9DUtQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=v97CmLdKI/h5oLXhjgijHNqNTGw7J1MOaKr6dWrt5/AcSdf6EfWgBcjqqjjsiMz+Dt8fDb+ELk7SG8/r4OiyNB8Ejd0WySMLJQ/ZKRqvlPJXz6UqhP1AqggBvySPoeFUReaUYZJlYWNoMardLVUQSV9vSm0GmoA4OSlPOfIFT4AJkDZnq4jMDhBegDQjfnHfvhc5nU2BCxPtSwKfy3V/nwKmeyMuQxdaOtKVFa4w3h+rkvTxfd+0pW8BD2YDfEEoXBzH4pXcYR4kN+Uin+OmBq97NtaRX4We2zKdVzt1jWIQCBhw5tshVrOrTHOODzHxlVsUaFDaka5PMwORVD9iXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dWFWovc2KtPVIaOEbxetuia65GMUJCJkkmz1pITsBng=; b=sWWclY+sxnm+vntiPN1AbZGgSEkatQzlC3eoqYElTMdlYiVBn0Dy3dt6E8yUT2lClbkjxqO29ExU303tgVPHy2F4LIGoAAtKnIT1antRdHHV+mKFNkwLEh4kW39uBlRgL+UAEgeLoVEKlz5ciCQmYgEMwjIGToiU1sesZ2Etak+eQ5qlwAJuREDTsG9IBmP9EXSW50fzL+YYtjTj/Sw6JLkicvPnWcG7IIRMhWlSqXShekAInY+8XHu6OdcXuf4yTs4yuwDqy3t0A37ATBSBVqPYHO9K4EX+3ox2DkyGSC8NyCk8xWCGDA2k7v4O65n5vf/2DJHXmCw+sWPtz/AtUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dWFWovc2KtPVIaOEbxetuia65GMUJCJkkmz1pITsBng=; b=hzRbjOZwKsKhA+3MJ7YemNNbw+XD/TKfmQ8wY1T9O8yBP8CeBliSB1gIIxbR8PsUnIia1uf8oOrxOwLLDGMewSIpeFE8t6T4TKzZxQbHGogjyDFfbcscMjhnhCoJ240indK+wF6pef3ILZmRhdyfcYUoFXWgYEWrlvW42YhJFe3+baU1qK91Hgf1BmV2AFlDzjzOY0+o1zfto8x7IsCsiuVBcS2XjOKogbuMUo6Hy/NnQnCwSHw3jo9AEm9UCjN//wobhBfpHNbRy30S2FWDekxHS5+VsUcksBHqzXg7V0e8rnZFJsUYz5VJy1ogf7Suz59y96PHkCvBE/cMlNmSqg== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v6 09/19] hw/i386/pc_piix.c: simplify RAM size logic in pc_init_isa() Date: Fri, 22 Aug 2025 13:11:55 +0100 Message-ID: <20250822121342.894223-10-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250822121342.894223-1-mark.caveayland@nutanix.com> References: <20250822121342.894223-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM0PR10CA0076.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:15::29) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|SJ0PR02MB7725:EE_ X-MS-Office365-Filtering-Correlation-Id: 6804789b-f86a-44c6-a259-08dde1756b88 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?5XJbgOxEGUqdvO6xwcoBsYCFXuSUN5eBXiG2HMJqqUtdD21AMmIgXzHqn/Ww?= =?us-ascii?Q?NrQAvyUJnYxRKSAZLQjQ90ubhhCFm1wh66qHZMz5md33NoqqB6VOXUMsx5ep?= =?us-ascii?Q?ApTz29JTfaXeuKVWZlQP9YS84KLze85vjy2u2QXrWMrUpCUEmSD1VDXfwaUk?= =?us-ascii?Q?X9ZoC3WSnbpN3QP3ASqEBv6xyfscYPzfTiRd8kALW8/9gswdcIkP59u7FeND?= =?us-ascii?Q?csTQRptSkOvUDLzD95PmbRvi/Yf2Lem34H0IWcGPFS0nJvX4xKTkhfxWY/xZ?= =?us-ascii?Q?kFbHP9yOWhAnFZ+q+dfqBwg+uEL8kifUwzEDQSg6iEIl9JST9UNMzvQIfRic?= =?us-ascii?Q?F6rTFDcaId400uL7+8KEjM0T1UWNKIhWkebcW7az3E1gxAfIfd8noN2lBaWk?= =?us-ascii?Q?UJ0iktryEFhjpK9Sp/yLIFtI1HBBNtyTm3f24qbL9ubg+K+lHDCTl6derrWY?= =?us-ascii?Q?KDTmp+4maFI8ezgU1PTqk/8CQSIOdijBUTO/+5EHpSJNz+qHMCf2MTSIPsB3?= =?us-ascii?Q?r0bZUH92BSSldo76WH1+MRompEfGPdgA3Yech/VaimqgzIwwV54tvdptFnYP?= =?us-ascii?Q?uVoIAoi7m7iUT+Eittu+DTMFrpjFqUlqPHo4PESfCLdyE1X8jX9ny/ldL/62?= =?us-ascii?Q?/fLNd//Pp1J2VTaYbrdGen3h5y5Up7a52mvDyqhqUm1jHmECQbPMbIK8nS4C?= =?us-ascii?Q?c6PykwvkHJFrlApB+1vlfTieoyjfG1WLeIqFV0wKvWmythiz/ZbrTR0cqDp7?= =?us-ascii?Q?qe6E8u5+TSq48fND3DbxFgBUxqsWtny+xzY9LiPXftwc0pJqAy9FauQESP5T?= =?us-ascii?Q?b+wV+D0HZLMb2UMTSGRf3asw3GNNq/5rpcNureYsViH3V3NM1tMbNdNKniR5?= =?us-ascii?Q?X/d1o+Rt1wSYArsPV798dUju4A3fJXSAT/oS0OnNeMbUwD6lff/0XER68mpF?= =?us-ascii?Q?JMlRQXuYjj9muzKJOLhwwcLsKZXRPHDtE9v3EUBeVn9iwIIiR2z3XleKQrpH?= =?us-ascii?Q?zXs4YzaLioleipGBSVuYpBG8dQClBRldnPPc981yrWmvmYxLrOO9/Eveggao?= =?us-ascii?Q?X1HB5kX2oH+o8wV2jRmukzYqigroz6it2QCgRagDYZrLpSps+OYVzAQ03h3k?= =?us-ascii?Q?5Fdyi0RUWEDc2kINT3QSqaCgosftmJ7uum+P4mZ7vIcgaAzjjXFBYHn9gFh2?= =?us-ascii?Q?E6cV1rii2MNjDIBBqErb+oS6abAnI1zovVE3oFwlQuS1MqavVh3xfgtz3oh7?= =?us-ascii?Q?vpiN42oAwGYHNt1tYS0wG1iFGf6w1x4faCDph0bXsjfymTs7rJRMrby0Uong?= =?us-ascii?Q?SgyAupFagwwDjOWTL0DazFfDBKYOb8QUxMV+8AZb66rS1rr69PPma5byFC2v?= =?us-ascii?Q?UvfGSeumvwoQ2NFLiJCJq3tqkZRjau9a1df9si+w2mzAFL9GsRlR0Pp2GBLR?= =?us-ascii?Q?/L0BN3CJ04o=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?A/bDzUfn2CQtPOxkq3ZPhSKMDdBiIQPJQpBK33WInJUzITOtInYogrntcIlA?= =?us-ascii?Q?pJv0uNJW9Uny5ZNaED1qz2AGjj6ptXEgODRZS/Nuyt7eYV7dw90I1RQdzczG?= =?us-ascii?Q?g5Jiz8VRZz0YGxfyvIzOurLUL0PlCchJ8eqk9B2ptWLxwzngXv5Ioa4I7UuS?= =?us-ascii?Q?tpasR284RAiLXFsZsN1TOozxWbh7m+euDKMTkXhLv9KykPF3/B1m1UkeRHni?= =?us-ascii?Q?G74ZbbMGR/ArgtBY0t9nebspK1o6JQByHtrF0xLQqD+GkTlme6d+HaDH4fNp?= =?us-ascii?Q?cuxicfnFFZ+avMNlU8K9Jlc0CQrY6aUFD2XJ8lF+iv7338Hq3v7pTwudCCKs?= =?us-ascii?Q?uCPkP/NxpORVuhDm98DpYM1HL4KDSLiJHIlKTOI2dNlJf4HpMu8NEB/ntsDR?= =?us-ascii?Q?tLol1zKoPTj0mMt/A57u+VWUVacJxj29SLW1Av19CPSKUvxYjiX/czy9WKM+?= =?us-ascii?Q?kR/OJ0TODt28GP2lLKK6DyhYKeOhnFrq6F/Cnw2nsWZ977+VccNFx5f6UDtq?= =?us-ascii?Q?elZBdH/dia/SORP+rpsty2sN5vwbzCYVN9V6jlZ8mK2ppcA1OGK68RS2vDM/?= =?us-ascii?Q?8btW21iPDdMLzPu/Qb9u1l1LJufgyEYdBcuMYDaHBL/7j6IDTv/4baMu7Jfv?= =?us-ascii?Q?WF+dyRBBdICTnpb9CzjJzVe0iOUc8VYks32oHXha9oypf+QwBr+Jd3P1KKmO?= =?us-ascii?Q?FWv0da7nOd+nvdFdmSy/TaMl1Nr7RvKzbbDJj3RFG3DvjWtY9pxT3ps+d6b5?= =?us-ascii?Q?PRFmGSqU7ZwvxBFE0koOl8X/iFrZa8GFS6ezd4dmxcwiQ1NGgL3c1NtgFk3d?= =?us-ascii?Q?btTSUXfAJlHenyI32UdmLwAXEcvdaW+qKEOC7lotiv4KKZKFc2zu9g4I9hE1?= =?us-ascii?Q?OK0Ldja9NqoljTQiH4ZTPmr3sdxCRD/LCX7Qk022lml5223f+fnyTcA7rwSs?= =?us-ascii?Q?ax+7FkrxSO160puKUDgYvI4OsAhrZ4aNTaO+nxI2Ryqr/mBl4mWnJ34Smkh5?= =?us-ascii?Q?VZ4noCdz50EyWDvt6aU4PU+Azp/VCr66KJWSkdSrM8bn7Qa7E1w899zMn6uC?= =?us-ascii?Q?P+1nHC5pHDbsy2Z6wop7xs4EF2q9TVb3kf4G2d05Z57rh6nJ0hMiOcC0jtb5?= =?us-ascii?Q?64eUWXhgCk/ux/o/T3E10XYhGeDrKy1lkA+MtswkXJs79sLZK+m7DB1dNRko?= =?us-ascii?Q?da4ofetga4Tn8qrt2UpSY3ZU7L+tTz/JhOfZ3LZSYSO+1HvTnO+xS7gQ7Iqz?= =?us-ascii?Q?njZAWtauRf2TwIzqeJZd8KVQ5U+joIeb/F4xkuukvKB1jj0PyEtgsjJmbdol?= =?us-ascii?Q?0hbNNCJLBwrTiF8ZjVEqDzGNVWzD41ArDnTdx6t9efHVY1sb3oW/YO0qVWvF?= =?us-ascii?Q?Q0zNPMOXZeN0H2byk1EmIEVrDCTHAE0UdBKsIjY/8KOxdm4NsaKDKjGtQ54Q?= =?us-ascii?Q?c5zlxGSIGL+XvhbNOTtB3AZUQIDymwFAq5IV0lQ4bIw0qvYpkIhqB36pf+ZB?= =?us-ascii?Q?6AjRQwMn7qAxXGUR4ccUY+t1V6JihiXRMjad/hrRv4zLlI8eF7fZSd8ycFve?= =?us-ascii?Q?I0aQSGOQi/Sn69lUQkUV480yi17MA0OUswYOFaVpHxQamba7OYEQKdO7hKE5?= =?us-ascii?Q?RA=3D=3D?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6804789b-f86a-44c6-a259-08dde1756b88 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2025 12:14:19.0636 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hWiQ5Ln36tcEMtU32m9xM2PvskJOIQW0TolMSiBwOxlv/fa44YAaSi4h7+iHsZqG4RwA+GXXXs0Ta1qkQUrb8hf1GfCsXrTwM5fZOnaFFmg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR02MB7725 X-Proofpoint-GUID: _44SQwIlUndCiTgop2JaFBaIrDv8cPwr X-Authority-Analysis: v=2.4 cv=CoXmsn4D c=1 sm=1 tr=0 ts=68a85f1c cx=c_pps a=EhLtey9IgjUMM8ik5sEfyw==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=2OwXVqhp2XgA:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=puX-rZ3iWx3qy-NnaecA:9 a=cPQSjfK2_nFv0Q5t_7PE:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODIyMDExNCBTYWx0ZWRfX46eVr1JLEB6x v15AzDfqnKGmkGl6ys5WzzvJKNofpCCNJfDS2+cavE3TqpxvvAbm01op4nI1C3oF8NGMA+cFbmU 9TbSEo6Qu7PBsVcjug++c6KTC4g9bl8n+z/wQyktdVBOeTqfzyBr8+/Q+Xh4SjDinfdmdUT3L9z n2SCQD1w/0c30jqUfecT2mO/lGEg9+4OxVGwv44a6m4bhWExwEf1xzNmdjrThE/svmrBr602rLe YjSic/NFMmE1pRoftayqcCLgE0Mia8bg4Q6THetQFUjzQfp7jYsoy+lv/486d4jEiz1s5q5JKYg rP+TKnj552PlYS3//Fjc8OyyV7eaGWdVpojGcVwlRE1pAabmjWyhRBImaEcDFZebi/Dwbhq8H/Z yUx+fyyfh/hOpUW/ghtYeTGKtrYeFQ== X-Proofpoint-ORIG-GUID: _44SQwIlUndCiTgop2JaFBaIrDv8cPwr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-22_04,2025-08-20_03,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1755865495670124100 Content-Type: text/plain; charset="utf-8" All isapc machines must have 32-bit CPUs and so the RAM split logic can be = hardcoded accordingly. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/pc_piix.c | 58 ++++------------------------------------------- 1 file changed, 4 insertions(+), 54 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 816124c027..fc94937ad4 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -444,69 +444,19 @@ static void pc_init_isa(MachineState *machine) GSIState *gsi_state; MemoryRegion *ram_memory; MemoryRegion *rom_memory =3D system_memory; - ram_addr_t lowmem; uint64_t hole64_size =3D 0; =20 /* - * Calculate ram split, for memory below and above 4G. It's a bit - * complicated for backward compatibility reasons ... - * - * - Traditional split is 3.5G (lowmem =3D 0xe0000000). This is the - * default value for max_ram_below_4g now. - * - * - Then, to gigabyte align the memory, we move the split to 3G - * (lowmem =3D 0xc0000000). But only in case we have to split in - * the first place, i.e. ram_size is larger than (traditional) - * lowmem. And for new machine types (gigabyte_align =3D true) - * only, for live migration compatibility reasons. - * - * - Next the max-ram-below-4g option was added, which allowed to - * reduce lowmem to a smaller value, to allow a larger PCI I/O - * window below 4G. qemu doesn't enforce gigabyte alignment here, - * but prints a warning. - * - * - Finally max-ram-below-4g got updated to also allow raising lowme= m, - * so legacy non-PAE guests can get as much memory as possible in - * the 32bit address space below 4G. - * - * - Note that Xen has its own ram setup code in xen_ram_init(), - * called via xen_hvm_init_pc(). - * - * Examples: - * qemu -M pc-1.7 -m 4G (old default) -> 3584M low, 512M high - * qemu -M pc -m 4G (new default) -> 3072M low, 1024M high - * qemu -M pc,max-ram-below-4g=3D2G -m 4G -> 2048M low, 2048M h= igh - * qemu -M pc,max-ram-below-4g=3D4G -m 3968M -> 3968M low (=3D4G-1= 28M) + * There is no RAM split for the isapc machine */ if (xen_enabled()) { xen_hvm_init_pc(pcms, &ram_memory); } else { ram_memory =3D machine->ram; - if (!pcms->max_ram_below_4g) { - pcms->max_ram_below_4g =3D 0xe0000000; /* default: 3.5G */ - } - lowmem =3D pcms->max_ram_below_4g; - if (machine->ram_size >=3D pcms->max_ram_below_4g) { - if (pcmc->gigabyte_align) { - if (lowmem > 0xc0000000) { - lowmem =3D 0xc0000000; - } - if (lowmem & (1 * GiB - 1)) { - warn_report("Large machine and max_ram_below_4g " - "(%" PRIu64 ") not a multiple of 1G; " - "possible bad performance.", - pcms->max_ram_below_4g); - } - } - } =20 - if (machine->ram_size >=3D lowmem) { - x86ms->above_4g_mem_size =3D machine->ram_size - lowmem; - x86ms->below_4g_mem_size =3D lowmem; - } else { - x86ms->above_4g_mem_size =3D 0; - x86ms->below_4g_mem_size =3D machine->ram_size; - } + pcms->max_ram_below_4g =3D 4 * GiB; + x86ms->above_4g_mem_size =3D 0; + x86ms->below_4g_mem_size =3D machine->ram_size; } =20 /* --=20 2.43.0 From nobody Sat Nov 15 03:14:59 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1755864941; cv=pass; d=zohomail.com; s=zohoarc; b=G6yIEa29o6Ujt3AITfmJGR+qlnnL6AC5J8JJTqdIx8mrZSRGexedvilrFLR5ldggK34fi9OhzzdHY+HZH28B5n7hDrquEbS51n8TvCvhxH7qKI0qzuvW1fZN3oJ4bNYPVOIBmkp6hvaPDX+867kohJJuHWc9xXVrGW/unIyRwOI= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1755864941; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=u6zNLt7Qh69BjrPCHnqv5HHknreOucEItrzNywo3k8o=; b=XOnUWPqxRIQv3yX2epvYHr3x66SdYQ9dJIYhy0xofB2SPAGCwy65hyrv/mk/fzxrnXzpKrTQrmN61KBNny1uqBCT5QRlCqcmkCjBmryi3n01DQ4IEf8IBnVJP5kL35PBhYsGoK0pCZnPSw/ZIDWDos2iKU7NMMQZz8qdSjXuRIk= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1755864941447592.6497431593684; Fri, 22 Aug 2025 05:15:41 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1upQf8-0001fG-4n; Fri, 22 Aug 2025 08:14:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upQf5-0001eX-QZ for qemu-devel@nongnu.org; Fri, 22 Aug 2025 08:14:27 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upQf3-0000hm-Oo for qemu-devel@nongnu.org; Fri, 22 Aug 2025 08:14:27 -0400 Received: from pps.filterd (m0127843.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57M8EEUh714063; Fri, 22 Aug 2025 05:14:23 -0700 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11on2117.outbound.protection.outlook.com [40.107.223.117]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 48mye6qgdx-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 22 Aug 2025 05:14:23 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by SJ0PR02MB7725.namprd02.prod.outlook.com (2603:10b6:a03:322::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.24; Fri, 22 Aug 2025 12:14:22 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%3]) with mapi id 15.20.9052.014; Fri, 22 Aug 2025 12:14:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=u6zNLt7Qh69BjrPCHnqv5HHknreOucEItrzNywo3k 8o=; b=L9clwnVzylkqcuqVWenxAVLeV5k3iQql2Q5YTczFT1VGz2X1umTgXHx23 B4GRSdVvxNnHUUlSFxAKbWnhiCoKJB1zc6qxzWjpsovLXY4B2L3mCJUzR+klWB1f /giJZAZ92t6bQubNI3hc+6L6R7Vo95gZsRAeSfShgu0jb30oIPrygMseUJhg1sow dIfOmjzryillrJQ8X4R/PRV2Qs3EnVNXAJDekckLa7VwEezhvUVfdfm/Cts3UvVx Wdj26ehOri8jvMnUzIZs44xsjngguhVyNm5ubRgjRtfptvTG86fQLvs2ClhgnaW6 Rv0VaQHycUvisLxKJHb2LUP2bFOdw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=b9+G6pTBjEb5lbRRIFwNy9vph23MP1Ywo4nql4c25PvlCOH2gwaV/X71KrqV1oW4fZvTI1bgj4yljhGc8sS7RxctzOVlqHNQ+bbw39xk7oCwSILX91YrMGhFciqf/skhdbZCb1DEb7NNZoKTZPNyEhtVvRQcROSHmFnfvBdFfJrzzbCw9hWG6xMiUmsNGq9VNXY6trpZ7TrZFnFGr1KZd+BolkoZLTOFHpJ32b5DHgKS3GwNOEZiCxMdIto7K7V4uOX4xzhM5Wgctft2W57Kgc5fs01MSqanSCihGaoW3cl6meRa9HOro4o3trLvDxrIuOdO0jjTROxUUc4Hq2E+jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u6zNLt7Qh69BjrPCHnqv5HHknreOucEItrzNywo3k8o=; b=bXVj2ju6e/DApn7uyIQjyJvQbuXxullcjnFqAI8hYsvIUngnWuUM15wp6VFXP75c6Niun91V8tM6z/RnFqUqsV/eWUBOqHYcT8kB7pTmBb+ZonHKQCMV0g95Uv0/HxksUQCQ+ilj7y+6HXocMv0TDSitOLSoagnZfSeB7Dkk/pPtviBcLTzq7VE45XTJfpW5ImHa8nmO2k5Hy/HYtgQxx4IMlYk43S0+XK33IYtCgFTfmIvW2HVSItc5a5Re9lwqaRawMRwH6vJ2cfOEVxLP63lX6X9oHSGUSq8u3+PnQm0UfixB1+cBqx2ezUCjhYsAX5vcRMXQBLiZXdva3f6INA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u6zNLt7Qh69BjrPCHnqv5HHknreOucEItrzNywo3k8o=; b=YkNgs4v9zVTb7jwX7MYPEEXcteHXcgBFcscEmAoc/xDa4+y2FzucGbtvo8t8d1Fe9bzw8aAnume6H+AVk5EYD2f4/k95PAYY70XbINFlUQnHL/Ei3v5zjG28kKO4ZZcwNx4t5ER2ahfyvxlAHLJ/lS9CXMJnozrZKxGNCQCQ9eu/uPehLIUbmfhwFDFCxwzUJ9V9956wc2jW6FHi+FR2JwgvwV7ATqv6GpVynOqvUsuBb2M+Hod7MFFwZcjLbsFGKNxBeUHrtsj6yIhDuu/2TZqvCKcpyPkQMeKy5yGy8U9a68DHQ0OkERPIAOTl6LyR+TVVCmoJaEJD5sh/ePw5PQ== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v6 10/19] hw/i386/pc_piix.c: hardcode hole64_size to 0 in pc_init_isa() Date: Fri, 22 Aug 2025 13:11:56 +0100 Message-ID: <20250822121342.894223-11-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250822121342.894223-1-mark.caveayland@nutanix.com> References: <20250822121342.894223-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM0PR06CA0124.eurprd06.prod.outlook.com (2603:10a6:208:ab::29) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|SJ0PR02MB7725:EE_ X-MS-Office365-Filtering-Correlation-Id: 168913ed-a5ad-485a-4b77-08dde1756d56 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?VWtJS1hlcFVSTW1Hb1o2MDZORVJXR2RXdlMyWUlXOGtXaVVSKzRwSlRxU3gx?= =?utf-8?B?a2VaL2lsdkxxODRMemFyNGVGWEdJRFFwVDQ2N1Z2YXVzT0JPWTJLZ2JRUmJS?= =?utf-8?B?YnZ6Tk5lYzJ4SXVRd3RSUkp2M1hpb2F4T3lMTk9IWjZ6VGhZa1hMNVY2aGdL?= =?utf-8?B?UXRiU0c0a2YvckhwQ0xwbVdWRUtpdVFvUmJld05hbmZHcGsvU3NVL2tmelZz?= =?utf-8?B?dEFLYjFFSnhwdDV6OHYxdENCWk81aWNmdmtmVitEZGtpTDdwc2pPbVRMd0oy?= =?utf-8?B?V00zODk3R3Jhck5VNlZmMUFRdkNaQWwyR09wYjZXMkRVUzhRcWpXd1FrM0p2?= =?utf-8?B?SktJdjA3Z2phNnVQWm01eGloUzR5dmtPZ0tITUZRNHBKWDhRYmpoZTFsU1hX?= =?utf-8?B?VThyL0RoMGtHbXdHZythWFM3VmMrbGx1Y2lmS21lcEw2QSs3dmZDdCtlNE0x?= =?utf-8?B?clBOUmFaS1R6QzI3cDEyaHFLeDV0eEl5WERaUTVkSzk3eFNHRlRqd1JaOWxm?= =?utf-8?B?bGZpbHVqMlI2Vm9qNW9SaXFjVEVBeVl5Mm1JdjZLa2ZhZGVvNHczeWlZVWVE?= =?utf-8?B?MkNpbVV2aFYvdTRaaVl1d0E0bncxVjFoYnlkWnRsTUtDRVhpZ1NoeGV6RnE1?= =?utf-8?B?cjdwL1ZoRVhnM2dvblE3cUhaaXg0MVZpUHg3R1p4bDdmMkoyNWFkSU92ZW5Y?= =?utf-8?B?S2NZNVJGSW1PWFhJSVpGcXpnMjhSMWh3WGdrTFh3Y2lrWldDMmFReFcxWHVK?= =?utf-8?B?TFV6d2l3bHJrMGlJcit6dFdFdElSUHFQWEpTTytjQVMva2Z0a0Nlb1E0MW1Z?= =?utf-8?B?Z2UySzJkR2h4eEhBRkJyUkpNMS94TFp2RVpVWFg2ZlFhcC84Nkd1dnJ6MGtt?= =?utf-8?B?UGxUYnZaSUpOeElPRWt2UEZvUk04Rml0UTZWMUVCMXlnbUwzQjF6MkFuSG1F?= =?utf-8?B?SkZ2MWprN1dSeTdDdHFnZEpSOFB3U2lIeFJUWTczS0FmcFhqdVAvTVJpS01M?= =?utf-8?B?cVAxUU11U01iMG1Pa3lLcUprUWRvUDVYNko2Z2dsRW5jN3I5N2NoSEdIajdI?= =?utf-8?B?RTEwTzI2akF0MS93RnYyemkzTC9ERktPdnpNaDdPUnVEYTcvNWZKNWZYN2h6?= =?utf-8?B?WUZPUEVnd3VQUE94ODJ6YWZhMkVtd0xYK3d2RG9IUHlIR2pueUY5V21JWXI1?= =?utf-8?B?eXo3NnM3bGZwNUFCdE5oNGlvUE1CWmFZTkZ3UGVCL3FTWkFUME9QcG01Sk9x?= =?utf-8?B?eGdzV0Q5a0svMzd1NVhjRmZKQmpGbklMUGdveFpWOHJNWmQ0NzhKSTZoL3JT?= =?utf-8?B?SVdmL3IvbW5qYTVIUW5IajdlWEJaZE1laG5RcUd3Q3JrQzR3c25MMngwcjdh?= =?utf-8?B?a3VZNHhCNHhlKzF6WVdWVHU4N09DNHF0V0wrd1lMcUNTeE03endBRkNnMkhC?= =?utf-8?B?dHE4NEZadXRpVUxZaTFWRFNvWmo5a29ycWoyb00reDhVUWs2Yk0zMk1tTHUw?= =?utf-8?B?QWFqSms3TmpZQTdrQ2NOSUZkRjRxNVBIaWJNODNyNC9XWjlPdEpnWmoxckVr?= =?utf-8?B?MElURXdTQ204ZGxDRjNQQzcvWnY2bmxFZE9GdE56L1hUaHhNV3B2QkZQWVJl?= =?utf-8?B?K1MxRkthM2FzNzdSaW1LN1ByakFtTHIvQms0bTBjQmdCdHAyM05sN3RMLzk3?= =?utf-8?B?VERSSnUzOEF5cW1vcWd0VXVTdXRMZmo0RFk3SGxRK0E5cTh6Sk9nV2VzY1c2?= =?utf-8?B?dEFPR2pla2dua0srV3ZFc0t5VmwxY0Vod0ZneGpmUFZ0WVBHU1pmVGVuYnNL?= =?utf-8?B?SnhiVXBxcUV4TytVbGl1T25BYUgwVW4rWVdKSkFDTThPUEVTRlpycjdjWnpR?= =?utf-8?B?SnF6TUM3cFpsL1hPWi9ZL3RaaFN0cm9yVUE2YjcxVmpYLzg0bEl5Z3BKU0RR?= =?utf-8?Q?5/rp7P3sF+s=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RzluU2hPeXJKNGI4MXUxdmVkbWEzNkZpWDVrQ1ExYmlxNW1PSW10SzEvRXVR?= =?utf-8?B?THY1MDZBYlFyQmJHQ2s0cWNnbmprM0VkenFCZ2hoWUYySi8zbDBkQTdoajJM?= =?utf-8?B?OGYwSDNSK3o0S2NXQVQ0RVJqTkVBUWJHdFdMUTFQTHlMbVRRS2JialAxdUxn?= =?utf-8?B?YUZ6WW0wTmVtL1AzbGFzTW5IVkVVN2RWWkhkOVM4aitpOTBqTTN6V1Z2OXB4?= =?utf-8?B?SldlYXU1QzZpSDZMbEFaL2dka0xhT1N1eWtrL3dHMW1ib09PSzNKeTd0WnU4?= =?utf-8?B?SGMwNWY0dVdPOHNKQ0ZRZkdNbGM0Wlk0NjMrNmVvSkR0ay9oRkNCbnBaNkRl?= =?utf-8?B?SnZrWVBvQVRWbVhUciswWVVsODlRb0tFSFN1dTh1WldUNHdkNnpPYjU1cUdq?= =?utf-8?B?bElrMDR2cVpmSXRxR3d0bUxxKzJmUjR3TEpnR1pFODZMazhxNnIvaDh0NTRq?= =?utf-8?B?UmI0dStvcnRUSmVqZjZ3Z3J1TTB1aGtCV1RyQnVpMTVXdlR2c1RNY1Qzcm1W?= =?utf-8?B?UHhZb2FVZ1RiWk1OSmcwS0hDYzJSNVk0RE9hNXUwTmVLUTdrZGNERWtydWFF?= =?utf-8?B?U3RHMGJZSzJzTFNoeVAyQkRtKzY4dnh0YlR0WjJIa1hyMnNpQW8relJOTFZt?= =?utf-8?B?VFdYY1VHREFzdFd1c0g5bWJFUmNieE1jWHhRNm15QTFLbUNmMDVxQkFqa3Z2?= =?utf-8?B?d2pkWFB6bCticFJGTmFTSFUxSTY2czJhM0pGMUxUekVxcTVtQWpvR2djTTRI?= =?utf-8?B?RFoxdStnSjBWa1k5UnBLQVBZSlcrNGp2RFU0SUo1Sk5BR3hkSVcxN0w4dnRp?= =?utf-8?B?dnk0ODYrcG5PS1dQYXQ1dlVIcjNTRHJTNzRTY2M1Y1JjYXlvSSs1dzVBTnh2?= =?utf-8?B?RjdlVmRPaytoSjdxV28zR3Jja2VvTkw5K3NBaENTSVhsbXZzRGZrUm9wY1Bj?= =?utf-8?B?K2h3Y21aaXNCZU9NUCt2QitVRkpaS2VqaExHNWNPd0xBeHg4R0dNYUVLN25K?= =?utf-8?B?UHJPYWtENHJOVE9NSHY2Q3FRa0IzVU8yUW01c25xU3djakhKSzI3MDh6SElq?= =?utf-8?B?LzRzK1BYdEF1S2JXVHB1T0hRdExtd2ZOSXU3NkN5dml6Z2FIVk9zZitLMUV5?= =?utf-8?B?TGJnTkM0K3cvdzN0bXNtMUFWMzJxWkVlcU10TVphMlAvOEI2YjI5cllCM3Nj?= =?utf-8?B?aTMvU2pWVGlDbW9KLzVtbmcyOS91TytsMXBING5qUDNTSkFkK1FHblFHcnd5?= =?utf-8?B?MEMwek8xSXduQm5kVmx0NUJQcEpxT2U4SHFxL3RsNEV0dFlBWnBjSTBjanlQ?= =?utf-8?B?dEZLbi9XUFRhSDNXY3JEMGN6Z1VodkFXWmZaWlZzQ2h4N25aZCt0ZjM0N1pN?= =?utf-8?B?V2ZyMnpNcnVpWEhwcEZjYnFVdGxCN3hUWnk2UWhvZ2hjSmM3NGtpbXAzWkRW?= =?utf-8?B?a3JOdWNiNEpLVXdOWUF5cllmazFOWkI4MXZ0MnhtRWcwc1JtV0VNQ0NIcEFI?= =?utf-8?B?LzdjaTFmZFdQcnpRdEdHbXpuR0MwRmoxak5xMnN5MzFDemFkSmgzY3cvVmVY?= =?utf-8?B?QW5ad29lekNpbDFDbStYbjVsQ3Z4MUVzTGp3MGlKUC9sOHdDRUdjMWxZV3Zi?= =?utf-8?B?RGFmaHdjM1RidHpTOHdjVG54aExLZU1kK1dtbWx2T3FEME5ESm9EeXd5WUJ5?= =?utf-8?B?MGVLb21CZGFjTlNIeXdwaGl1L3pmSFRzbThUMzAxU2pvR0kyenhibXlJN0Nw?= =?utf-8?B?WWo2aXFjQmlSUlVZYTRqRUhueDNHRkUyKytkaGhNRFRTMUlrbE5XelFieU81?= =?utf-8?B?c1BiUldnZkcrY1QrVGU3eEFIZGFQU2JoZ2FWejhhQUZpSUhOOUpzaVk0ZmxC?= =?utf-8?B?ZThOUnU0anNZSVFXSVJPdlU2WlUxZXJFWW1CQjV4VTZIUTk1UjE3Zzdna0lx?= =?utf-8?B?WXpJaUtGdzJZRUlwb2hrVmFIL0NMckZ2citvU09jVVVhUWNzc3RtdDd5T0hW?= =?utf-8?B?TnIxdXhSQXZYQmZTWU5wenhhSmJKTnkwWVp2b0F4RDFHeit4c1FLK1plV29n?= =?utf-8?B?SnZzcjZtVzdiRktRaFN5UitodVV0L1ZFOHdmSmwxOFRVVGlYbUhXRUpvMlF3?= =?utf-8?B?cGtlWWY1eStCRW9Bd0sxMWJ6K3pHOEN2ZXJCLzlWdGJSNm5IL2Q1MTlFWEIy?= =?utf-8?B?SUE9PQ==?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 168913ed-a5ad-485a-4b77-08dde1756d56 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2025 12:14:21.9273 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wZe19QcvACj1s8jld0ALi/F2Ql9JS6Fc9DBW4lh4LaIAaGg38fAhwjkm1yijbEo/VTVWjpIHuWirt/pYLmPPVo7BEWYeLFphdFNwbScj/BE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR02MB7725 X-Proofpoint-ORIG-GUID: jl-EqLI8AuIF4GTHs7kgivpK0WgotAaF X-Authority-Analysis: v=2.4 cv=QLwxhgLL c=1 sm=1 tr=0 ts=68a85f1f cx=c_pps a=gSfga9H3o/hfQwPnBHsPpQ==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=aqeCdxMHYQgX1PSeTiMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 a=cPQSjfK2_nFv0Q5t_7PE:22 X-Proofpoint-GUID: jl-EqLI8AuIF4GTHs7kgivpK0WgotAaF X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODIyMDExNCBTYWx0ZWRfX1W6KaRKKrd3k NAstOnO+9ZYR6bL7jbST6rMcCLw197cdch7cb5Hs0pUtrvQisNY/OnveT9m7hmt+NnZsL2N3q4A 8ivMbQbdfUzg3S4jmHKCKa7MZZDZwLLFTBPKBYY9RhGJIoB6WkKiAgE1cKfUp8R4gXziRUfiax8 Fpz+ceviaSqJ99vT7avHWgxmb6Dypzf3AQXzIcDOGBeJoAZmMs8ycUSKBOguN2QR43ortBUMv5u sT4ryaMxziFVni9JPMnszbr+EmZm+R8CjUrnqd3/+dUKke0N2lHCC8pAmUDPz5HePD8veq/W6Va euAr8ok3h3vKjgE3Rt/lp04yb64jbq5ZC7bh5lJqSyz4DtTPLal58vMlXSrNFxWhxZPtUok5Sp7 xsXZTuq2VK99b0vQR/NiQOrKQ5eg8g== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-22_04,2025-08-20_03,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1755864943080124100 All isapc machines must have 32-bit CPUs and have no PCI 64-bit hole so it = can be hardcoded to 0. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Xiaoyao Li --- hw/i386/pc_piix.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index fc94937ad4..7c9f4b78b0 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -444,7 +444,6 @@ static void pc_init_isa(MachineState *machine) GSIState *gsi_state; MemoryRegion *ram_memory; MemoryRegion *rom_memory =3D system_memory; - uint64_t hole64_size =3D 0; =20 /* * There is no RAM split for the isapc machine @@ -480,7 +479,7 @@ static void pc_init_isa(MachineState *machine) =20 /* allocate ram and load rom/bios */ if (!xen_enabled()) { - pc_memory_init(pcms, system_memory, rom_memory, hole64_size); + pc_memory_init(pcms, system_memory, rom_memory, 0); } else { assert(machine->ram_size =3D=3D x86ms->below_4g_mem_size + x86ms->above_4g_mem_size); --=20 2.43.0 From nobody Sat Nov 15 03:14:59 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1755864901; cv=pass; d=zohomail.com; s=zohoarc; b=ZzIte9QgeGaf4VZDIPP2sTILF0wYzbKk9ewWYzHqTTY6V/eVzEnSH6jzvOZOCDwlQumBEZQMv3J0Nup4WzAWEoxxKpcXS6tSrfddDZw6RF5dR0ChwGsFwdj3SPPVdgqSyYGeCAzHeUk0CJ6JUmP37d0gA5wf31PT4yEeyG2P6gc= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1755864901; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=9PhzxtRu0oEj7RLfe6zCAOyBXC5fSfW3FCO2c0/L4bU=; b=GdJ88WhoF2P5OjX++iCWxV67PsDbQ4X8X/TkC57mzDzFqis1y5NfB9FE4rjtoLwFW5J67m242X+aB3b+v0hxwHrUNSziqDvGywN2zy9fK0tw77I5/MP6cO1jnc7GCiU/8JfMgIwCszkOgyWDP9LEBaBET8f8fhs8eWmxP9+i1dw= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1755864901586349.4050498048547; Fri, 22 Aug 2025 05:15:01 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1upQfB-0001g5-TA; Fri, 22 Aug 2025 08:14:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upQf9-0001fL-Kv for qemu-devel@nongnu.org; Fri, 22 Aug 2025 08:14:31 -0400 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upQf7-0000iF-JS for qemu-devel@nongnu.org; Fri, 22 Aug 2025 08:14:31 -0400 Received: from pps.filterd (m0127839.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57M7YANe668459; Fri, 22 Aug 2025 05:14:26 -0700 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11on2135.outbound.protection.outlook.com [40.107.223.135]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 48mye8qdwd-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 22 Aug 2025 05:14:26 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by SJ0PR02MB7725.namprd02.prod.outlook.com (2603:10b6:a03:322::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.24; Fri, 22 Aug 2025 12:14:24 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%3]) with mapi id 15.20.9052.014; Fri, 22 Aug 2025 12:14:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=9PhzxtRu0oEj7RLfe6zCAOyBXC5fSfW3FCO2c0/L4 bU=; b=TFAYP1bumP8D3G+VcaRRA+Zh7vRNrJBScHATN6E6EQa5E4B9su/jFXRTn kVVuRw/oILV/tFyM1YonuaH9UgnVdtmVdqXNTsC6UvuIQn8AdbdHbBjrRvgN3TMa jFgvrCPvWBKnvU9x5w/v9Zxi8w5ciMq2zgqWHNgTXUcq3vwH6atZQveKA6QUzu7T vGBTEClBhFkW0eaRfOJ0Vy6E2XGwoOIic3aGqBz5CCysXJn4m2pkleuqUX3cqGP8 YZ6ZzcuryC7R5IntnOmwviDqGS6MeJX3QLcUtSG9T+C54uHqLf5+cABFTBsme1b9 cyZkSOwQDUfXIlDxIyE9DnxKUKOVA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=be4vDOPeDt7Danm7EqJ0pehDYRk2qkhlnxTcY7ZXTYL/vCbpu42JruVr7RHv17bi8oWzktIXdybVLKhSob2jmrTX85JO0lBm2nZiCcx81AEo5Wm0BLYNDcAKXw+u/6ebb9JgZtTrjgYrdMiQvU8JzSjzcUlxhmuV/DZQ4LbVIU8y5R8+nuDVxwyUYM4R8+/A+TeYydNPrm8thqpaGPMJIH/PJDXH8EZek5PFY8s2kkbQTo2aIzEzd7rbNbncEOH/Vph4SDhvydCoe3TqABQRUG1zIYXLrk4mz3ZUYrKSM1I7mZgqj72S0Ft0iwHYaM+T32HRkgJTjX2zIK9KFkWQEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9PhzxtRu0oEj7RLfe6zCAOyBXC5fSfW3FCO2c0/L4bU=; b=cn+zklnrovVSaPe+hLnLj15j7h1yte1iQDD6jndtyFNI+6PBZeONDaVbNK67ehizZ/DXzPqPL72fhaYj6puqDXQhOP+bU5yv6RGC2hkul8QeDX29UdTECjR8T/D7fT0jgSJ4Bp8wqP/1ui2cKIXp/M3C5Sb8uUqXWrXz0L8DmDKqyl5Kq0T7q9veyIChCoB1j5wk5nGHnLbed3bxKn7x4FoJcsCOOqlBfj0CwxBuqMaTTa/Yv189Ys0vmgYQsAHw0hlSdDDf2KgtPAGfDglPiMrJZD6IX3zIIYMKTJMWENwgOSBhJme8Ph0qRtEu0IUMSiJw9PcGNoYY79yTCtbq3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9PhzxtRu0oEj7RLfe6zCAOyBXC5fSfW3FCO2c0/L4bU=; b=yqJ6SkBcsYOV3NkAj21n2+rvbzxuaHAEEWPwf4nNj0/yHZ+tVG7qiJIJDuH5Wq65QH1kfRKjVP5IuM36oTcbTehF605NiuWXNg5YoJ6ikIrSFpA34fP+liIabHy5Qja7/91lnwK8LLylKUhpUPI7xs7IJ1K02PF1x2IvbMUK11ANL1+BHm4SabeXJ6hIzxqegywb229fJ07cRJITZlqrb2M5VAjLK7gsSYqLvHDXHoQmm7DkcPp07fUWfDfD/AiPlSrRop+fc8uo/mjxc7AG+dKO2mSbwAPBlbB5fmv6fDAj2JyNGkn5dCwge6DeL4OXe2CTN4Xh1jbQFnRcv4fJSA== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v6 11/19] hw/i386/pc_piix.c: remove pc_system_flash_cleanup_unused() from pc_init_isa() Date: Fri, 22 Aug 2025 13:11:57 +0100 Message-ID: <20250822121342.894223-12-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250822121342.894223-1-mark.caveayland@nutanix.com> References: <20250822121342.894223-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM0PR06CA0115.eurprd06.prod.outlook.com (2603:10a6:208:ab::20) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|SJ0PR02MB7725:EE_ X-MS-Office365-Filtering-Correlation-Id: bcd1c9ac-f717-4629-4d99-08dde1756efe x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dG5zWTNaSHdVRjYvby9CMjQ0RUhSRGZBQ1BDenV1bFdWYWNyOVFYd3dhU2Mv?= =?utf-8?B?ZGx3YlNFYVhRWHBKaWsycVNyek83eEJxZnJvRTY4RS9waHltZ1ZtbWh2eUQy?= =?utf-8?B?NDV2M1dZSmUwOEYxMVdIaVExdjVPYVlvRUJUZDVDaVpyUDM1RHlNMkF6TXZC?= =?utf-8?B?ZjVJMXlpenVVS3FtQ29ONUlhaGZsWnMrN3hvd3U3UTdoaWZYSWNmSjd0RHJL?= =?utf-8?B?ZVVueXFaREliN2Z4QjM3VVpnbFFKRXAzZ25uWk9Eb0dCQWhLMEdDQmRNWkJw?= =?utf-8?B?UzkrRzFTcExFcjhON2huc2pscmYvWkVEVnZPS1FiT2JRd2FtNnIwZVErNzFr?= =?utf-8?B?bk1ycUVxOHIzYzIrbzFNeWRPTEpybjFjOWJZUWpDWFBQMWJ1U3VFU0lYV1M5?= =?utf-8?B?L0tuSnRralBGZ3hlWEVxblJEZ3V0RE02djQwYUJXWDlCU204WnJNOERaVnV3?= =?utf-8?B?Q2FxTnJ2SFlwbUNSMmcwUmNKRThLeDBwV1R3blU3WlRKZWdQWTNmQWVJU1R5?= =?utf-8?B?TzhER085YXo3d2w4SG12UHNGVlU4TWI4a2FGUlRtWWU5bTBlYXlzNUp0UHJO?= =?utf-8?B?YWRlSm9HNnNRVm01SGpvcDcrV25QdjF6ZkhwSEN5bkRFMmZvOFByYk1IYzQv?= =?utf-8?B?NlVGdTZJR1pPVkhpKzJyRXh6Sk5BODQrNDJYWnk4eWg2blZ2aWlDS0VmS29s?= =?utf-8?B?WE5hSXdKRkRhMjNHd1RhY3FDeTRoNE1ZczMzQzJLUGEwSzNqN2pHNGo3UWVr?= =?utf-8?B?YTlkcU93SzN0SU9RU28rOUlGVHA5SFVrSXdFSzAwZ1ExdXdvZWVXUEd1NnR5?= =?utf-8?B?RzdKYkRsQ1R2MGJHN0x6WGVBOEtRRTg1VEFTRStKTUYwRWRyVlVoNDZOaHF5?= =?utf-8?B?MllvMVpETTFsRkZ6eXdjLzJQOUtlWmZwbDdRZXV1ck5pZXg3cmg5WVk5dk5T?= =?utf-8?B?YWpiUGV4UnR3dS9CMTB1TzY5QmgweVAvVmJyZGU5enNEeWczYnVSeFljYVVx?= =?utf-8?B?bmZST0MyUkg3NVd1ZnZ6Ujd3UldMT1diUkYrK3pVZm1Ed1oyL2llejM5ZUMr?= =?utf-8?B?MzlKdlJVa2pFYTJPdDJUVmJNWWZzT0g1bEsvWDg5YWg1U1JtVUhkN0p4ckpN?= =?utf-8?B?ejN0aXBlNklHUVB6b01wQnBsOUQwZDRhQ1QzV3J5NGdtMFloRjdLaGpMd1l3?= =?utf-8?B?ZUlzanNoL3RyUEpYOFEvMWNNSmhvSllkWnd4RUdQbyt0Z0hIVzh0VERHLzFC?= =?utf-8?B?UENJSGsrcVp2UTlCNGVBeW5UT0xjeUNMNDlhSG16UFBZUENTU1RKdWd2T3pJ?= =?utf-8?B?RVVsbjlSSVQzdFVpOU5LNG1PNlFyeExTOFp0cW11OVlvcHc1c1BqekJBSHRu?= =?utf-8?B?bERKRW5ZY2xLMU5BY1ZWNHk3R2xYTE8zenZybnpaVjJKUStacWNlQXlzQUlU?= =?utf-8?B?Tk5lUXBCa2pmT09OaWpqLzcwTzdCVDFvVTRkZ0d2U0x6WXRmRW0rZmg1Ulp5?= =?utf-8?B?ZFBKbmpnRFZYbTR4dzhzN3p3YnVSVURVcUFlSzh0RGVvSDFjM2lZb3VRdUdx?= =?utf-8?B?cXh1V1BUSG1wcHNKZVUzS2d3WWo2RUYwVDF1Y0lHZmN0ODBMVC9QSGdKR3RV?= =?utf-8?B?clpSQURsL05WQmdUaCtuYlpBMVRlU3VwUHJtQ3lBYmpGeTY2ZUNYd01sQnlI?= =?utf-8?B?VE1RZnEycFNVT2wvcXAzaUNVR2k0MXcrWVNIaHBBSVkvQ2t2L1RpQWgybWd4?= =?utf-8?B?YWVGMGlCWkF3NkdCdTZrekdMMUtlODBhWGNnaEp3aWgzNC9scWdrV2xJSnh1?= =?utf-8?B?QTJCekVQV202QnI4M3Z2cGhsdGVCSzYrcjA4ZzFBMkgvbXZGMmNjczdSQzlr?= =?utf-8?B?OXRiUjc3ZExsZWlnSFdzVDVsRUtaQVF1cUVnOU1BWEp6clJFTkdqS2wxaGZR?= =?utf-8?Q?bBs/Z8mWjbI=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cE5BSHd0RVJsMFBsRVdyQWUyeXB2TDd4WHFMZWpDWjQvOTBBQWVDQkMyRVJH?= =?utf-8?B?ZXd4eUtIVmQ2M2lMZVdpdkQwWkZZMWFVYVJ4RWdISDhCOXZqaDhvZHVHWmtN?= =?utf-8?B?RDN0SlprUE9ON1ZZWnBaUUQyV1pucE9wb1RsU3Y3VWNTYTVaOWJ2NjJlR2RY?= =?utf-8?B?VXhzaWZ0cmdQVjZsNDNSQU44ME8yNERMOVZNWk50WjNiRlFZY2YxU0JPWVd5?= =?utf-8?B?V0FkNXVaOVg0RUltN2xQVTZYR1k0b3cvaURRQWJNWTdvS2JhTlpteXFLblly?= =?utf-8?B?ak5CYXlJRTJHNTFVY2IvUkVacDlnZmRXZy9COEp6MFZKYUh1WVpUN3lRRGpl?= =?utf-8?B?a3hpR3lCYUpLY01veis3bjZRWEduWnVDcmdvZ3ZtOElUZUtvdXJ0UDJrd0Y1?= =?utf-8?B?YmZ3eGhTWG1jTWNwWDZiekE1NDVqaGlmQUc4cmN3bkhKanhyQVFHYlVINXBu?= =?utf-8?B?WVVFY1RBNnJyamRVY1FWMmU0Z2lsM2xrQllRVEVudXpjZW9oYTV2enEwTzVz?= =?utf-8?B?VFl3dkUwdXF1eG93ZlhpOXRwTlVTSWp0N1VrRHdZUUV5R2pHQWhhVzNDQkh3?= =?utf-8?B?eFVyUXB6RFIvdXE2MGZ2SUVBYWppYk01dmcvWDJqbjY2d3BOQXp0OHNwYWIr?= =?utf-8?B?OWNYU0NsL3pjMUNBZG93TzQ1cFNmSk1MN2NGMXd3d0ZlOXFRMFQ0WHZ2YUZo?= =?utf-8?B?NjdRQks2Rk8vNi8vc1BEQjVJTEJTejlUYXNYT1BoaEZmRXNzdGdiR3pLT0tM?= =?utf-8?B?MGtQNTBQQ2pjZURFQUVmNXNhaGJCOVo2ZDZpTVhjdG1vNjYrVEtJMGtNdGU1?= =?utf-8?B?MktmUzZoOVNaV1kvMkU0N0puYWphWVpqYk5GeUM5OG91UnVJQVdMM2tCb0cr?= =?utf-8?B?VjFYZEtGZWRUM09vU2RTbDFYZUhwemRwWUM4SXR0WHJjMnJPN1JhbGFxbjJh?= =?utf-8?B?RXpDTStjajZLNmhNTnhsckc3cGlqd1pUWmdHWGRXVkpnVGZXZ0F5MWl5NHdO?= =?utf-8?B?Zlo4dkhSbi95SURmby9nOHJlMVN6THpCQTgwbHZIS21FQUxPUVBlZjlYSnhv?= =?utf-8?B?V1lnUmUvK3ByS0pZWXBKaGtJZU1IZ2JIdXg4eFFBeTZlYkU5WStrVHV2cWpK?= =?utf-8?B?NStyQ2c1dW9IOVk3TVA2dGJVZFJEVUc4b010L1cydGFOa0g3WTByUGxlYlhZ?= =?utf-8?B?T0hWRVNtZ1hTSFR4QmkrN0lLNnNmR3hlQURmWnhZTzRLZ3lnUWxkNTFNUDdZ?= =?utf-8?B?QlBDZ2VrdVVlOGE3M09aejlSRTA4K2lXZUJNTEdOU2tiV0hGS1NmY3ZLbnFt?= =?utf-8?B?cGE4YnRQVXlBelIrYmVUL0hSSUNiZUMzNFRxQkpDdXZqY24zZG1GS2xvL2FJ?= =?utf-8?B?RUdoZFNyVDI1R2RMYVdGN1VhS3p2K2NJdEljM1ltY0pwTXFvcGpEcjh5K3k1?= =?utf-8?B?ZzVIUkQ0U2dudEU5S3NubG8wZXM5Y3RUell3REQyYkoxYkFkbzlLMmVJc1VS?= =?utf-8?B?OExlckRQb01XY1pXc1I0M0NpU0xneENOeVY3eXFlUEZjRnl3T1JvQ3B4cWo4?= =?utf-8?B?THVmUGJNV2hJTVpoKzhNUjNMbVZkL1BwbllVeHR3TnFGZkxoSGxEV05zMzV1?= =?utf-8?B?djZYd0txa0VEcit6NE1oTGkrMGthTVR5cG9Eb1BlbE5hTVFRVDRNNjd3akZ5?= =?utf-8?B?L2pjSFZsYjA5QkRIdXU4cjNBS2VTZzhqSVdYZ0JvY1NEZDNyOFFLcTFKZHlq?= =?utf-8?B?bnZiSGVneW1IQkVWeU01SGUrb2EwVENyWWluaVpBWmM3U2dxenpDRkRGbFho?= =?utf-8?B?UUZ0bTdsRE1udWk2MEt2ZVdEN2tDUXdVeTBLNFVqNEJ5Qm1pUG9NVG1GdExq?= =?utf-8?B?Ymw5V29VSVdwK2h6QmZERU5ORDNtK3JHYlJVVWhsTEs1c0VhR2Z0N2ptK2du?= =?utf-8?B?aFJqYk1sUzh0azd5aitveTRZK1FFVWxZaktCSTE5Y1F6RSs1K1JKZUJtbjVZ?= =?utf-8?B?U0dtbHgxeTBEWDJ2WVJQWWd3bk10YnpWcFV1eEUwdDNuejhsWXNVWDZBLzVt?= =?utf-8?B?ZlN1UmVLdVA1bFNlUlV1VkM1K1JyOExDMDgwZHNCTEgyU3g5R3YzMHk3LzJP?= =?utf-8?B?UVlSb01iNEcxb0hqOFZwbC9lSGtvdlJjRFJoUXhMaGJLbTRTMkVjVStNQmFr?= =?utf-8?B?TWc9PQ==?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: bcd1c9ac-f717-4629-4d99-08dde1756efe X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2025 12:14:24.7341 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AjnTIMslyx38Tie1BwNK7M5oJ1RvMNSl8UpFt0p/DdwsFhKUpqA/iMl19bZiey016qNwnfRfBfJtaY2wJHWXWuTtqBgcKDJd7g+ouotDBEE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR02MB7725 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODIyMDExNCBTYWx0ZWRfX41mIRRiIh7Et eBPIzsTZ6ySMe3DXBiJ26znV8w/fkH+i2LVsWh2SbGVCsHO6Sdr4Cu+W58hMd5ufZ81bRk8COvE IPc9jRhcmV3yAFjO7qA9D61u+ttlwdWe00AhYj42o91lZhbGSx9HhgLI6BGb6w66OcErE4KKuqb 3CuKk6Woj4ScBeTFq77xWscpOOSQaPR/Ws6zNeFz1ajHgEyUZyr2HcI5foGnrhk1w/PqJI+qX1v 3qiHEY8nWIzyjzKc1CeN6mb75JgunVy7Eym+2Z31Yn51pEzEqVZvd8drQJ/A23mb93ENseFCrMW rAWDBP3mq1dyU26KqXruGwIWvtOTnfTTFHOrh6GeWLbqdUbiRwlOc0HnBtwqlLS9nnQpHgn5APM mijywoPCndIiCnfP8ovKgUm0wrdaaw== X-Proofpoint-GUID: uAj6Izd2e4HXSEug6CfkDpVv1cNBWIAt X-Proofpoint-ORIG-GUID: uAj6Izd2e4HXSEug6CfkDpVv1cNBWIAt X-Authority-Analysis: v=2.4 cv=A7Y1/6WG c=1 sm=1 tr=0 ts=68a85f22 cx=c_pps a=SfKpAED18FmY9QLmYdbp3w==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=_jvWDQGc8cL8bECqUo4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 a=cPQSjfK2_nFv0Q5t_7PE:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-22_04,2025-08-20_03,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.151.68; envelope-from=mark.caveayland@nutanix.com; helo=mx0a-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1755864904886124100 This function contains 'assert(PC_MACHINE_GET_CLASS(pcms)->pci_enabled)' an= d so we can safely assume that it should never be used for the isapc machine. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/pc_piix.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 7c9f4b78b0..bbd5f9d17f 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -484,7 +484,6 @@ static void pc_init_isa(MachineState *machine) assert(machine->ram_size =3D=3D x86ms->below_4g_mem_size + x86ms->above_4g_mem_size); =20 - pc_system_flash_cleanup_unused(pcms); if (machine->kernel_filename !=3D NULL) { /* For xen HVM direct kernel boot, load linux here */ xen_load_linux(pcms); --=20 2.43.0 From nobody Sat Nov 15 03:14:59 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1755865036; cv=pass; d=zohomail.com; s=zohoarc; b=Xfyk/e7LCE+SduOhb2YHuabKpMBIVAP+pP0D9+UGTUAAsW8iU87wqoHntrbyJfbSNvenTEuhDqY4I0sfPxDfyi79ijSV04jRK1r4/pI0FE0fYdP5M37ZHh1sxL+fD+bFEVlAl08chTsbSOjomrQJev3o6Q24rJN1n+b4GIhQWcY= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1755865036; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=zC2zegcy5Q3sDW2eQ4Z4NjH81g35SFGs4pMT/LwFVRU=; b=R5x07F0PX3ZS7AyRGdnmniFtoCmInEkNVbjUQknbN2oZ0udKrDEEcvAom7nna1e3h3O8WGpMiVdQly6bz2E5ZoIvzVORcSOm8Je1JR1T2d1GAkKvH4hn5yzlWfElHOYXmVL4msVSF0+JPo/Nbc2fN7UWWdz5v8DiufSYG+tkvx4= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1755865036565627.0724334560746; Fri, 22 Aug 2025 05:17:16 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1upQfG-0001hG-Ru; Fri, 22 Aug 2025 08:14:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upQfE-0001gf-Nu for qemu-devel@nongnu.org; Fri, 22 Aug 2025 08:14:36 -0400 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upQfA-0000k0-VF for qemu-devel@nongnu.org; Fri, 22 Aug 2025 08:14:36 -0400 Received: from pps.filterd (m0127839.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57M7eB24668464; Fri, 22 Aug 2025 05:14:29 -0700 Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11on2111.outbound.protection.outlook.com [40.107.220.111]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 48mye8qdwf-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 22 Aug 2025 05:14:29 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by SJ0PR02MB7725.namprd02.prod.outlook.com (2603:10b6:a03:322::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.24; Fri, 22 Aug 2025 12:14:28 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%3]) with mapi id 15.20.9052.014; Fri, 22 Aug 2025 12:14:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=zC2zegcy5Q3sDW2eQ4Z4NjH81g35SFGs4pMT/LwFV RU=; b=aPe0mPZ78f2v9nKvlw9WZyBFfS8/6W1pEL7rA6paiv4ANCtJ60ZJq3DTK 6mHZeg4XOBLOnVZwuyL2/o5WRNIlwffA7GcxQpY6giBSy32eXwtg3wU2fhJOgDfv TyKmDv0Jr4eBwohQ6fnA8lx3ifEi21zHs6S1wUlRwYDpXx5BTpImXlcO6WnTbGpy bOoGtRdrCVsVmT5/GBxTQqj3ONbiXp0HriwH8z3VjlaZP+teSzSMTCx5HHP/phLu af10tRrAXuhanJ52if4WHMdCR3e6XaZS4H2mW1es6dKT1Bm1tarY5QTZBfnFehGB h/rSBBqA4TxKYVv1K2c3PWnPA5q2Q== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=r3Rn/J5d032LAsESFvN/C8vZZPvOMBxqOSmW0zZ6to0Raayk1tiJcC/bVTt7pPXZSiXdq03HyWpcWF42XLUJElZp3WcKr9ULFHnka5zsoZ9RvlmDKLTZl4hVNWmDiUEBm6El0JCZYqlwDOsABJ9fJWtA/jHYBdVb9Q4gaG5H4JtVdZvsiomi98MqHX2L4yRJBOCuiEzS1AWYYvSOyHwq00jIo4PfizGZLoXhkb43UqWiYJXchTQrkER5kaF43pCNix175GI2rtDrGVdqdOp76iEf4fiugODFUNgxiXRNzjF2/LIFswtpImEz4ltgTbNjpw8LNu0TeCULHnML/UD7hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zC2zegcy5Q3sDW2eQ4Z4NjH81g35SFGs4pMT/LwFVRU=; b=CBCxsYXTncw5iV6DrOViN7N7eRc7yfYV2MhQYgF4mA2XRRiC1TQqTsounN8zv+p+madH0/tX+DhwXPuzSXtk6C58BwEnNZdCUA3EWkVe6PFuR6KgTCibu1DHyQds667z7PqZb/Lzu/NoaaxXURKblSNJC+HDAdfBEUXRuY+I+gDShrujHDSWBXOhboIhasGk5D4FuAQsoumP9KhfWVhSdgHrZ8HJ2soRHyVNYf7FFD3gX88P+YmZoE4dBzW91EmcDJkFQyoQEYBorltpByRzPrYZZm24WwitowYbsRWLN0y0e+RT5FG+vronPX4ak2wSdcp7PxMg8PE6xFLCQqQtBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zC2zegcy5Q3sDW2eQ4Z4NjH81g35SFGs4pMT/LwFVRU=; b=CZu56H3ZqK67nUYjELHNNAKse7dOyZn05XE5kozy2YK/a+Y2bMMYBE2AnTP6LdKnTok/tggTSq/4drMw0Pr2bxc69pfLpQBlLUcMA3HaJUYlDa1kBkS4mVaG1sOF1qq/qDOLoB3iGGuCR7LklSMJR6VfbKb4PPS0kmlcgAEMsOPpS1CCAjVPgt6Vu6KWLxaHhhgveRNhEkDKUYsSTJTApLC6o0d/HLNBd/kesLgRz2gX1AN0k/bSeIy8erIvhR98rpj5o2RMn4y7x/xkq0RPytT3dDmBExpX7uRJyPskmQ8hDt+GVxrEteYg/5dhzvS3cZuCvxlAmDK0pLGKVG48Fw== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v6 12/19] hw/i386/pc_piix.c: always initialise ISA IDE drives in pc_init_isa() Date: Fri, 22 Aug 2025 13:11:58 +0100 Message-ID: <20250822121342.894223-13-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250822121342.894223-1-mark.caveayland@nutanix.com> References: <20250822121342.894223-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM0PR06CA0143.eurprd06.prod.outlook.com (2603:10a6:208:ab::48) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|SJ0PR02MB7725:EE_ X-MS-Office365-Filtering-Correlation-Id: ba587772-75f6-422f-c139-08dde17570ef x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?OEhxOWk0SE4zR3g3a3hrb3k0bmpobnlIVmhRQVFoTlFEaWhNOTVQWFcrOEtX?= =?utf-8?B?UVpEMllQYTZ0RC9CdnJrQXNTU0xVMjFCZWtSTUFJOENnTmx5bTVQV0g4RE01?= =?utf-8?B?aXViVGZKNDhWeXJXU2JCRStOc2NMZUsvdlJ6VHRPSTBNeWZEbkx5a1ltUTZM?= =?utf-8?B?SnZUK1poczBEcUxHYm5CMGhNc2x1Z3RCdVlqRCtlQVBjSk5vY3g0eFVOY1Rk?= =?utf-8?B?Qm9nRVlBYmE3SGVZVTNtbkxwbXkweVY4TUhDNGVPdXVwZm9WdVZpcThXZnJH?= =?utf-8?B?UENyUlpGUmlnNERra0JWSTE0NXVEY2dMbGpYYkRlRmZLbDRGQzFjOVU4Z1ZT?= =?utf-8?B?dTFJK2QvMXV5Y3A3NS92bjAwR3F2aGY1bUl6bURmQ1J2UFoxNTUvMkVBWWxp?= =?utf-8?B?M1V1WGFxYUtyU3FCT3RFK2JkTitqSVB5UlJDUDVDVTRTeTU1WGlyc2ZUcTJX?= =?utf-8?B?NWpNZUNiVDRDSVhUWFprRHdxUmE2dFpTUldXNEYrUUcxZm1nSDZTR1gzM0tD?= =?utf-8?B?SStBVDlySllvNjVTa3BpaWNQM3dPeHZMWmU0QzIyU252MDM1RHpianMweWo2?= =?utf-8?B?N05MT0xaQ1JkQmVIVXpIZmRtclgyUlo4SkFEaTY2U0FxR3QyTkZqUVd1alZ0?= =?utf-8?B?QlVYUm9BODl0Nkx4Q2tod1ZwK0M5dnRqQXZvcDhiVHBLRWR1bjh5VmdIeDJm?= =?utf-8?B?c3h1d2NnbnRTR0J5bnZCb3J0L1l5SzVsVkd1dE1Qa1VQTVkzNzFOTTlOVlAz?= =?utf-8?B?dG5qREU4cDF3UVBtbWtwbmV5WDV4b09nSnRseVNtY0dUaU5OeStkWlNZcjBB?= =?utf-8?B?aXdxemFSR2VrSXZZTVpLNHJGdmcyYVJ5RTFaRk0wMnhYS3FtZmRyWHpKZGgz?= =?utf-8?B?MHZ2MkdraG5QaTlHQXNGQXZrR3FkSVYrWlRsZmxhSThrYmNLdVFVSTErSmNv?= =?utf-8?B?UnJtTGxnRDB1dnlSOVljRDM0UTRvM21URHBJLzVSQVF3UTRMbG04Mk8wZjRZ?= =?utf-8?B?dkxrbGVkSGxxVmV0TXJyNGtuM1pWQ3VBVDFrb1RsUlBmVVVxY2RFZVlTOHQ4?= =?utf-8?B?TnhTbzFnOGt1dDhTdE0yVmErVGNUNEJwK25RdW96NUhJL0dFcXRicEtjT0p1?= =?utf-8?B?N1c2R2lDbDd4TDJ5VFFJemJEaHEvVUpHSHhnak1DY2U0cFV4NWV2OVJDZm9x?= =?utf-8?B?SndSUWpMQTR5UjVNeG5TSDRVemIvYmV5N2xkMHhWaldHdmJUOVFmMDVGeXAr?= =?utf-8?B?eWs5ZWx5QTEyMnAvZHVUcGhqd3lQK2xnM3N1NWt0dG80bVc3WXJxM2xoZ0J2?= =?utf-8?B?b2Q0MzNwYTdkcStWbU0veVJseVZWajNDL0VmeDRmdG8rcTEwMTBLcU92RWZ1?= =?utf-8?B?K1VtaGV6NU1aek1nR0hrNE1OWGd4SnI4M21GejNReHFUSTdiVXJqdU9wOTVH?= =?utf-8?B?WmpHZThreXp3dHFoYkhXOXVuMkNTSWYzZFZDdE10SzRjOFpISHMzQWF2ZUhC?= =?utf-8?B?Ny9lWm9YWDhrQWo0K1loSTYwNXlhNkhJS2h3L2dQYmttTFpjZzZHQ3d0N3Fu?= =?utf-8?B?empoSnpjL0lweHVOcTdZaFYrc3BFR1dXZFE3amR0U09TZmlpb3ZWZDdMdC84?= =?utf-8?B?Qzk5ZFNNYkpock9lS0VEdnJjSkp0dk1jS0ZXWGs5MFlWc2hOZGUzM3dNWlRI?= =?utf-8?B?NUxPMko5azNZZUF6bkNaam83S01EelJwU1VSZFIxSkxFdFdWcU96RlVjVG5R?= =?utf-8?B?VmtkN045YlJFWG1xR1hwSndudUkwR0t2S1dBa1RCMEppREJTcUk0b1RjOVVa?= =?utf-8?B?OExFYkk4MEFEdEVISEJRS2tYems3ZlZmSyt2NGFVUnJJNWR5NWxhNjA4eVZK?= =?utf-8?B?TEZoVUpFcENpVCt4UnFYblUxYnd0T2dCaUFGYWZvUS9qWGR0dWRmcnpQTGsx?= =?utf-8?Q?gDMXQl+RKHs=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QVp2L1JyeEpMajlJbHpCNGt6Sy81dzVCK0xOMXRxK3ZBQTI3RGNsUXg5RGp2?= =?utf-8?B?aXVua2hBeENSU3NibzFBQmR6TTAvSlpuNElyZXFOVFpjeTBiTm9zcHpZcXRw?= =?utf-8?B?Y1RDR0NzRnlybENJUXpkUE1RL29hamtFbVJ4QXh3ZTZFMlJZdTQ5NjVyMllI?= =?utf-8?B?ZHYrVnFmdzg1cGtpSlRLbUxrcGVJMmUvdXNCdW9MNHoraThBZUkxL3Y3UVlj?= =?utf-8?B?OTlNTXBCVThEVVBMblRobVlCYXFyVTdaSS90Rk9Wb1NyZWpqam8zVitTSStI?= =?utf-8?B?ajBqbnAzYTMzWWFyRUcvc1hHQmgyTi9yUnlLeUtHbW1TdHJvRUpvTi9SaEJO?= =?utf-8?B?bitxNi94eFNJcFByeTlIamJ0T1NPREtiYjJVZlZuaEJobjNsVUlWQWszOTEr?= =?utf-8?B?S21rbzJQRy9sdDJHbzhXR3JoeG1pdUM1ZXRPVG53dVZIeTd0b0hUemFJVUFP?= =?utf-8?B?bUhCK1hPMG56ZWxNN05CRlBSSXBvdjEzYlFrQnkwN2JWU0hyTThob09XMnlu?= =?utf-8?B?cXV3NXdiSDBrN05WeEZ6SzVqVndwU3lPWllUWXRhMXV0NnBwNnpSQ0lCL3ZS?= =?utf-8?B?Mi90YlRoZW5MUVZ1ejhJM3BWMFBSZkl0TEtvM05iY2dJaW04dUlYS25nbkor?= =?utf-8?B?VytCSTM1VkVRWVFBT2lpK0ZuY0h5LzdPRUdrQjVNTmFkRlRuUUtzWHJXWnB2?= =?utf-8?B?WE1MTVZnRm92ZzNtYXQ1cTkxQm5JKzlYNEVGUFhXQ2ZzSnhjSkxsTkpPcFJk?= =?utf-8?B?a3kyOGkrZkZDUENYckFRVGZCdE1XWDVDbndjczNyTXFONDBjcC9pdnJJakVj?= =?utf-8?B?S2VwYk4xUUFwa1hvY1pXam9IN3NjZ093YUMyZlN0Qy9EQ0xGMlpERzdTR0I5?= =?utf-8?B?dG5Kc1gyclBTY2Q0Q2JscjJZVGpSekNwb003TXNjMldxTVZnMGF6dzgrL2k1?= =?utf-8?B?UWtQVzEvMnFobE1rYWxKRUM3VVBEWWdRQ01MQUc2UGdiWG5QbUN6T0VrakY2?= =?utf-8?B?aWJSZVllLzQ1RVFidUtGWWdIZTRLRFFOSzBScXIyenhleGVZdXR0SnlVQTJ0?= =?utf-8?B?T3lhTElEUlROUkt0NFpnRHl6Ykd3Y1JTZ2h5QmhCWGZycG5CajhrUFA5UW1B?= =?utf-8?B?NDVSVzRYWGdrTmpCYnNNOHcvUnVDdGZ6V0QwbGc3MktPTk1FZTJ6SDY0YUVp?= =?utf-8?B?dGFHTlJxTGMrQVdOZkZOQ3Z0WUxsbGU3MTJVMlQva0E0dm9oaDBjQ0dXTUIw?= =?utf-8?B?b1g4UHVFUDdqWlRsMUFtQ3pTb3BCMjVSV0FzSXN1eFJETktYMi8zLzcyUnJF?= =?utf-8?B?cHNWSlAybzJXOFNCWXB6eDVBN2tsekFkLzBVeFY4ME1PRy92ZGVwT2xTZGE1?= =?utf-8?B?eWR6SkdHSm1nZ040d01nc0FVZGc0QTdUYzdDNUowQm5rWlBaZElmd2xyWWk0?= =?utf-8?B?ZCswWW10cjVta3U4ZllsSk1zTk5mODlOUDRRQ2VPejBIQTBINlZQQmlaaFRJ?= =?utf-8?B?THdjZFpPY3czVkRLVnFhUTJRSGR3d3ZuMHcxTkhGcUVIKzd5VFNRNE5ieFBr?= =?utf-8?B?dHljRnhsSWNiTGJVMm90b2tnRUdYek1qRE5HcG9MZTcyU0pOYWVLN01jVHZW?= =?utf-8?B?bG5RTmVudWV3bVp3ZjgrT0xMYXpQM2RxbWpmNFp1MWVrUzlWRlcrMTJCcGNp?= =?utf-8?B?MlBwNDJ6ZWtneVBvMldBM1NMWUdGYi9xNGhDY0NpZGg3NnRtZ3F4aHdvcjJ2?= =?utf-8?B?L2UySXJBYXJJZVJucXA3Y0diRTZXN09sdTRlc2FTSmFMdFpUYnpLWkc5aUJu?= =?utf-8?B?M210ZENKMHQyVlgyZkx6RnRzOVJrMk9nTWJ3VU4yNm9mMFZFakloQXFxcm5x?= =?utf-8?B?NjFRZkMySUFjT0xJeVRTU2VheERnM2QzUHluMmlWdHZZdnBCWGNWUlN1YkZ2?= =?utf-8?B?SUFKRTZxc2xuYTNHMVB4NjZVVTE1eXVDRERpSjhDek9nTHJsY1JTTXdwVFRG?= =?utf-8?B?Ui9jU3lJbGd1Q0FWME0rSFg4RzVGV0dYL0hURElFU3NCRTJ6MDBjbnFpMHM2?= =?utf-8?B?VFhtSHZzTExvOUV1cjhuYXh4M1N4QVN2eUN0Q0FsQnZmSXUycnlRUkRQeDhQ?= =?utf-8?B?RU9PSUIrTmtBc0xhdWpQTEhqb1o5U0sxWUVsZllZaUhkTW0wVHRobll1OGlZ?= =?utf-8?B?M0E9PQ==?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: ba587772-75f6-422f-c139-08dde17570ef X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2025 12:14:28.2001 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: R1YxL0lVzEk3wgaUOCCRDOawbXP4AQWugFZZlR3YX4g8mgbTFunuH1ZwRJHIyUEh2ZpUbZCTXplNyBFDkiS6jQHmkookJQAqMqUfG46L154= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR02MB7725 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODIyMDExNCBTYWx0ZWRfXwJORPdy7TQA8 VyHba0wfDbQLe+unVN6HtlhDcKsOzCnxOggo40LJ8sDTfT0tY58Ao9oME9+/b6Q/Ulhtq2UmIcE sXaaUXwTLp085N/cA9N9aaR5WRCb7pdwZErXYDn/yO/jJmR3zKGkyu9sZLB+Fb7XsOuFss7plU4 nQYc+LDCY6CjB+2sX9jlJ8Uf+NjeDEsWiLROXHMDg4SBntKgAcIftlWBWw3xqQahjRgLKxHrQ8u 8gtfW0UzagzZXQVBMkzVbZjLq4tGZiKTsPx0Jkr1iW3JDWILxiayoYTnrfbjGaQlMCeYD+Tkc+l R5KA5EsLyqjiBlfuVdUEZPwr1xA+wA4gxGYx4iFFD2818qiaHazRgOmxFeB2oWrA/gajrPfwKPv IFE63rupGrKQ58uVd6nyazlFa/DHSw== X-Proofpoint-GUID: gV4rOK76-7EyuX-2-IwrWiSVqxkGvuF7 X-Proofpoint-ORIG-GUID: gV4rOK76-7EyuX-2-IwrWiSVqxkGvuF7 X-Authority-Analysis: v=2.4 cv=A7Y1/6WG c=1 sm=1 tr=0 ts=68a85f25 cx=c_pps a=EAC/UdV2w3Vk3F7KeXBmxQ==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=qN5ve3sCTOSH2ZO3jx4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 a=cPQSjfK2_nFv0Q5t_7PE:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-22_04,2025-08-20_03,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.151.68; envelope-from=mark.caveayland@nutanix.com; helo=mx0a-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1755865037675116600 By definition an isapc machine must always use ISA IDE drives so ensure tha= t they are always enabled. At the same time also remove the surrounding CONFIG_IDE= _ISA define since it will be enabled via the ISAPC Kconfig. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Xiaoyao Li --- hw/i386/pc_piix.c | 35 +++++++++++++++-------------------- 1 file changed, 15 insertions(+), 20 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index bbd5f9d17f..924888b59d 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -444,6 +444,8 @@ static void pc_init_isa(MachineState *machine) GSIState *gsi_state; MemoryRegion *ram_memory; MemoryRegion *rom_memory =3D system_memory; + DriveInfo *hd[MAX_IDE_BUS * MAX_IDE_DEVS]; + int i; =20 /* * There is no RAM split for the isapc machine @@ -519,27 +521,20 @@ static void pc_init_isa(MachineState *machine) =20 pc_nic_init(pcmc, isa_bus, pcms->pcibus); =20 -#ifdef CONFIG_IDE_ISA - if (!pcmc->pci_enabled) { - DriveInfo *hd[MAX_IDE_BUS * MAX_IDE_DEVS]; - int i; - - ide_drive_get(hd, ARRAY_SIZE(hd)); - for (i =3D 0; i < MAX_IDE_BUS; i++) { - ISADevice *dev; - char busname[] =3D "ide.0"; - dev =3D isa_ide_init(isa_bus, ide_iobase[i], ide_iobase2[i], - ide_irq[i], - hd[MAX_IDE_DEVS * i], hd[MAX_IDE_DEVS * i += 1]); - /* - * The ide bus name is ide.0 for the first bus and ide.1 for t= he - * second one. - */ - busname[4] =3D '0' + i; - pcms->idebus[i] =3D qdev_get_child_bus(DEVICE(dev), busname); - } + ide_drive_get(hd, ARRAY_SIZE(hd)); + for (i =3D 0; i < MAX_IDE_BUS; i++) { + ISADevice *dev; + char busname[] =3D "ide.0"; + dev =3D isa_ide_init(isa_bus, ide_iobase[i], ide_iobase2[i], + ide_irq[i], + hd[MAX_IDE_DEVS * i], hd[MAX_IDE_DEVS * i + 1]= ); + /* + * The ide bus name is ide.0 for the first bus and ide.1 for the + * second one. + */ + busname[4] =3D '0' + i; + pcms->idebus[i] =3D qdev_get_child_bus(DEVICE(dev), busname); } -#endif } #endif =20 --=20 2.43.0 From nobody Sat Nov 15 03:14:59 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1755864946; cv=pass; d=zohomail.com; s=zohoarc; b=XVNJdWaibgsXvojSqQB9/tNuC77Un+bojczq+ThETc4pCfxkzgCO8wA3/dDcZ0QqwQvQ+simc2lfpI2Q3qxBwid1uHL+AayyU7Kjg/1W8tN+J9tQxfwrS8k43QJ360WjsuN4vaqR4ZLzf+oteBGRi7IwgrsWsYfy10PJZHSsQn4= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1755864946; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=hqVCDIy2KRR27aDRiYr1f0LLOv6zNVLHQMYYw/h+hbo=; b=TI23s6UC8pESvoE4jRecOF6mNx9jW12rzz7iw17ZscG+qSir4+qxf5N/GYseJGV2K6EDyQLXtxAxmyL6yalrogHTsyqXfTIcs8EMGnKMP3tpBbwN4h468j9fxIB3uWhoFJ79+nIHGnzWwZpDnGGufg6wgmeBTKnwugACxkjOvCs= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1755864946328990.2254345940404; Fri, 22 Aug 2025 05:15:46 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1upQfK-0001hu-GO; Fri, 22 Aug 2025 08:14:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upQfG-0001hF-Bd for qemu-devel@nongnu.org; Fri, 22 Aug 2025 08:14:38 -0400 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upQfE-0000lC-0J for qemu-devel@nongnu.org; Fri, 22 Aug 2025 08:14:38 -0400 Received: from pps.filterd (m0127837.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57M807Lr667100; Fri, 22 Aug 2025 05:14:32 -0700 Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11on2108.outbound.protection.outlook.com [40.107.220.108]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 48mye8qef1-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 22 Aug 2025 05:14:32 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by SJ0PR02MB7725.namprd02.prod.outlook.com (2603:10b6:a03:322::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.24; Fri, 22 Aug 2025 12:14:31 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%3]) with mapi id 15.20.9052.014; Fri, 22 Aug 2025 12:14:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=hqVCDIy2KRR27aDRiYr1f0LLOv6zNVLHQMYYw/h+h bo=; b=iwpU3/wBw7/NAg2OmyQFHpk+e7hgZjI3r44YBAN98TzRDXh/3uVP2QVYS qKCpb2dbeowVr7kqZLkw8xDbCad/5J+I9rI/fIG9FzbfIovPrFiKb9ug0UJ41hMc qzpXC+vKbIExSyJSdSn/heqhjnYT0SA2WPueyBMdz53piOZb977kVVJ9F3wVs13i 0fIz5THqEjSskZLAuWe7Kr3PFRkKHmNb1khn+0WzD8QGcPOMpK5lqGVzhXBKsj/D hQj1bSBx9ei2hLuTR5+ANB7HGXgkXM0E5p8OPHossucJwSe0pvfNtuqhXm9AgcGE t3mmUfDJ+WxRtiC3cfam5wH+HmldA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=o/Waaow+q8FHQ0mSK23HEixtwCtAaeTwvPQh1MHgYuSpPCUaXTBYw3H4SyLPnVsnrImUTMuzvTnuA0aMzOvlebnONbyNgkedaFTXE9O7EIq82UJvP/GJ95h/BvIMpU1hgMaXe3otkST3eREhrSqy8EzynmI1se5SL4vEedeKEj7j02ORzFdzmZoDNcDdMCYkof0kP3Ql776JE0X0puqFUGhzh52+/4RyJRHbjkEcqZ/4bg5K4chI3CYdAO60/LYeFFAB9/1qPhtxG/9wxVIydu9bOS+/fkDhny/3f/B78Nkt3EQFmMmQI1SjCQl+MtAqeRCPeNDYNKzigYwRRNMYtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hqVCDIy2KRR27aDRiYr1f0LLOv6zNVLHQMYYw/h+hbo=; b=o6Shx5oDK00riK1deZPwXjqTh+26szrTrjEuhUXAecndHPDCKQq7qr0ii59Kbadu8NUnuFPb/rapDqBsPnj/7Nz9GnzlxNBfNECo01XBX/zvQzKZhmN23UyeRhoikZ+CigdfOb8bcOJR+JiQbC+lJe/INrrEWfGbUV5VHKbpJ1dZTEnw54cboSuyizdWhA4/BXJkLirpIX3/PnYxOlhClQlpBK87zkgaX6Rc0lFxgWFrq20lQ9VBLFnu4ZGJcvLrtDgHX2RLWtbRWvmUeyrUaFIwaw/CddBo6xro+oFyvKuYumFEaphdC5UBoTBQPSxVVbOkxT8P148NTiyRZCl3lQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hqVCDIy2KRR27aDRiYr1f0LLOv6zNVLHQMYYw/h+hbo=; b=SQAJ9i3ezIh8noDNgsHJwskLt/BT5Li6LHSIbuEfEKAa9lozIBU6HYYd0YxFvTA5jm09dgTXjJO21/82eqWW/sXdjekAAwXwEy8a/veer4YAEcXeVLB1IBOaPbz9ZSIIR+1WoTQRfcpVllmTviOp1JSPSaaval1M2E5AiiGEI5z93TkLwZp/duDkuUgNsUmc6GOXaO2EBBUC5eoptH9WcJqCpssVF7sLmJTGYwzBggXk8BU+PvWHI6v/VAYKps7RchQPorV9mrvjRHN0kiOXDi0lFcCVcnwtUBxJpV4Gdo4/jhRIpa7U4x14kipD0I18DkdiSIl4GKr+H2WC7dNTnw== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v6 13/19] hw/i386/pc_piix.c: assume pcmc->pci_enabled is always false in pc_init_isa() Date: Fri, 22 Aug 2025 13:11:59 +0100 Message-ID: <20250822121342.894223-14-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250822121342.894223-1-mark.caveayland@nutanix.com> References: <20250822121342.894223-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS4P189CA0052.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:659::21) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|SJ0PR02MB7725:EE_ X-MS-Office365-Filtering-Correlation-Id: 287e221c-6c82-42b2-abd5-08dde1757313 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?R0dsdmFKSmt1OXNza0w3cWZZQm9UdVgxb0t3b2NMUzFVSi9sWDREbGZNeE9v?= =?utf-8?B?NGdRUVpzREV0U3VQYjRLYUlmbTBJd3lzcjJiWDd5S21UdVhIZ0FxbXE1c1N1?= =?utf-8?B?Vk9XTjhsT2lNamU2ZzE4TkJoNjZqYXBDM3huQnVsRmlOZ0RORjVsaUozQm1L?= =?utf-8?B?ekdFbUVZVzU3UXE0SklBY2p4WnIwMVF4U29BaXprNmVYSzBVU2d4VUJXNTFQ?= =?utf-8?B?TXZibVdzcGx0TWFYOXR5a0NUbDV5NHM4bGhPNkpOZ3puNUxPNWtKTXBoNm5i?= =?utf-8?B?K1FZcFVIczlTSllzYVpvVHU2YWpDMlRZdkIzWng1Um9jQ2dJOHVoODlLVkM5?= =?utf-8?B?c09mMmVMYW5qeFFvczQ0UThDaXUwZ3N6R245SG5PdER5Vk96bEREVThrMU1s?= =?utf-8?B?M3RST0hPeGg0M3JMQk5ZejVqbGt1eTV1b0tJMXk0U2Z1VFpqQ2RXa1UwT3F4?= =?utf-8?B?NlgxcnlUUktNRWRLVTlhcGNmSmppL01KY1V4aExaR21henZ6UUJPM0VRMFNn?= =?utf-8?B?cU45ekRqRithSE5jbHlxR0VtRldjNVllYk1FMjZEejRCaG9kRkpVWVdYQUpJ?= =?utf-8?B?ZjBzeC92NitNOHEwQnZXdHZ1V09ibTAydUxUQmc0MTgvbFlVQlpWSENzZzFG?= =?utf-8?B?U1FKQ2d6MjVkV0d5WUlvZGpMdERJRjNIK3NLZzBqWi84RjcvQUg5QXpRUkxu?= =?utf-8?B?YzBNdzlVbjNRY1pQVUlyOGpIUnNNRkwwdHN3ZW0zbVN1R3UyY3F0dWJJTEZt?= =?utf-8?B?OUpDdDNRWmlVUC9BQmc5dkJZRVAwblhLN2c1dFBuWExKU3hpVEdrQ2w0aStC?= =?utf-8?B?V29Fb0VqWTB5SXM3NDEwbERBOXlnNE5DbE1iMU8ybjVIUXZIY0pWTHdBVGRE?= =?utf-8?B?bnBEWnBBVGpTUlo3MFJpYWZrT21LQzQzWUwyeStkSC9adTY4R1cyckVSalhT?= =?utf-8?B?Zm5VbnlPT0QzMlVzbHRyZkRlekJBZUcvQ0lIRWxac1JXYUdMZFpWUU5aNStx?= =?utf-8?B?dkprR1V1L1VrSlNaWEN0UEp1T0tiWk5vOGdyUWU4T2gwdTVIQTF0Qzc2bDI0?= =?utf-8?B?NS9maG9XTm96dUpQMEtHUFRJR0JrdmtvUEdzQi9INGNhOWc5TEc4TURMUFVF?= =?utf-8?B?NGltOTRjQ1h1U1BSclhFYi9Od1lQR2pPcnpFWXg0V0xuSWlUc0xmSzU0QVFy?= =?utf-8?B?dHRrOHlPYXVtdy90WmZ2ZUtxa0wxN1g4bDJ5SE9aNTk1c2RQVVZhZHhyTEtM?= =?utf-8?B?Vjc4OGxUTzR5UjZZaU1BTk53aEpDenBwYjI0a0pId2hzcHQvWVBWaEh5TkRy?= =?utf-8?B?V054Q1FyZ01BNGNpWi9Pd3kyUUlZeStTdDljSGlhSXFyWHM4UlZLZXZ2aWNZ?= =?utf-8?B?aGUvOHRRclgrZXd4WDM0VDE1YjFXbVBhbzVSYWk2WE9SWWlFQkowdzBPTXA2?= =?utf-8?B?bmxPOFAxV1VwbUE1SjlJNU9Hbm9xdnhiZlRUNFhxVm9WYk93WkI5MGVjdU9L?= =?utf-8?B?NEFUZWxSK1Vwdm1wQlNRekxYS242SUtTWjN6bm55YUN4QXZaVmY2eENxMlBV?= =?utf-8?B?WGVZK3V0MlA5b1YraEQzbjd6aDBFTUJiTi9TTFdCSzRWaHlpVFp6ZldRVGQ3?= =?utf-8?B?TUtBVXd1RnhVY3JwSkRmV0tFR25zVHlkei9randMcVFkcmYyTjY3dXprR1cz?= =?utf-8?B?dmlndG5xQ2lDandpOVdLZ3NPTGFMTmlxM1Z5NnhiazNEN3BGWThoUi9vOXRY?= =?utf-8?B?dU9qM1ROV1B2OWM0amRyUWljeVpoZDBQc085cHZaOHloODZQMFJBT0dZVGZU?= =?utf-8?B?TFczSnA1VkZYWEczVnhBbFdHMXlDSGY0ZDlPVzlybUF4UjU4TDlFdEFOVXVY?= =?utf-8?B?VC92SkdSdnhWRHpTai93aGk4YVZkbGNWYy81SUFIVzZXN29NMEZZV2g0OFhV?= =?utf-8?Q?Ejuw1l0z930=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y1JmSlF2VVAxWDVxeHBzbytpaFhvNVc0c2tpWmduYU5xYXZBdnR1U0RtcXZv?= =?utf-8?B?YnR4REZjNE1TR0FzeVZYdEpIeXlwcGVPb0lsb05rMVUzRXNhVFliWGFGOEcr?= =?utf-8?B?T3ZtaU9VMm9yZldTNkNtOTVPNDVDd3crS3FZcVhTOXpLMmIwQ3JDdGhVQUNh?= =?utf-8?B?ajMyZS9wRnp4cklORU9LQ1pEQkVFUDBJK2FzQ0lZanl1OHF3bU1mNUVRSW5R?= =?utf-8?B?d2czTXRodTYvYzA5eC9UUEZrOUsxWkNZckluMXE5RVI2N2FCSWF1bW5xeHZr?= =?utf-8?B?M2RwTjNIeFhwLzFnUVRRRkVkbnQ2Z2p2WXJiRDMyK3phNHdxNG52VTNZWjJY?= =?utf-8?B?VG9Rakcza01mVXhlNTNhZmF1eDZFd3NOc1A5UktQNGZFQ3BWdGQ1ZnZxRzZG?= =?utf-8?B?akRNU3E2VmhWOXJwemNhN1JncHRoSDk1cVNNTmhwWFFIaGNMMFJLYWVtcW9I?= =?utf-8?B?Q1IvWFdoREIralB5U20wYkt0elJTcUdnRXBaRmxYSWlQbHorVFR1YkdpUmpF?= =?utf-8?B?NitlQWsreWptTStOMEltSkFXTnVodEpaNjErWkVSN3dTVWJqRTlTYkcyY2o1?= =?utf-8?B?UkpodkRSQzhRaUlrNXdybk95Vzl2WVJqNEQwc2Q5WVorV0FoWGk5Z2Iva2k4?= =?utf-8?B?dFN2ZDVXOXpxc3pJWWtkaVdhQmVPcHA0VUc5K3UrK2VWdlA1QW9YL2RuMTlF?= =?utf-8?B?a2FXWE10SFhwNDVNb1RGNXRGVlg0aW1uZFNQRGY4Y0QwM3htN2NrMXpvc2oz?= =?utf-8?B?MVRSTllLa1p6OHdPVXRGWlprUEVwbUVXdkdxSmVvTHpOUTRvZXFIbHE4RERs?= =?utf-8?B?MlNWZkpJV3ptWUlLM1RGdkJNTlV6WFBnU0dVMWpBQkZnQ2s4SDcwVHFheU9h?= =?utf-8?B?OVpnTDFkLzA2WDNhRGpxNHMwQ2VSc0JDVUM1dW9vRkNLdWlvSWZBbkltenAz?= =?utf-8?B?cVg0bTlNcXVhV2JDYmFxRUNxQ2R3ZnhwZ0NhUW1FNjVYK2lzUGtRMlJNYkQ3?= =?utf-8?B?WnZXTE5ZRjY1TC9OdWcrYkVnMmZaaVB3K1JQTzFEMEozN1JkK2JBUzRRaWNa?= =?utf-8?B?eHJ2bE1lWGUrUXB6RmNrWHd4TG00c0hER0NFNW9RV3BOSk1JaWRSYVRneGU4?= =?utf-8?B?UFV6R3o0Y1JqZXhxWStGV1RnWm4rM240c0tuV1N4VTBnbjZuV0pNSnQzQXJO?= =?utf-8?B?Z0xNUUdrOTR3Q21nMG1TTjhqanJVNnhXSHFuQ2NnMlM4d0ZEMFNZM2UzNVhI?= =?utf-8?B?RTlmWFJ6YStXcm5PR3dvZVNEdlFvaWJncjlDVkhVYUUxd0NyZjBscjU1TjRY?= =?utf-8?B?a0VTN2s3WSsxbUduNGtuSEJkZExwWmFYaU40dmFNU3hERDF1bGxTNnZUcm1W?= =?utf-8?B?SFdWclJKbFc4WW1EUzkyT1NQVndzZTBQVjZzZExMQ001RGpoYzVOR2NFQ2N4?= =?utf-8?B?R1dQQ2tuQ2tVOXNrQy9VT2xKTkNqcFRjcE5aSHUxd0RJcHQweWJ3alhvSXJs?= =?utf-8?B?RnlsQTk3dG9XUWdtTE52TXVEcEdKK1F6cjhNQUxKTWRoTUNza0NBVnNZY2xy?= =?utf-8?B?c1g0VVd2NmdYdUxIbGNKL1pNazFRRExreEFzRzQ3UGhGM2dmT0ZWOEFZc09W?= =?utf-8?B?SnQwMzNDOTI0aDRNaXhVVHZuNFYzUGpkS3dOTDR2QVJ4NDdVR1BKSE45WmRz?= =?utf-8?B?dHRkM2pwYnlRb1JBNjZHYXRVRVBFNjRwejcvL3VaNEVxaFZZUVY5TGkwc2N1?= =?utf-8?B?Mit4czhEQmd6WUE4TzBGYkZadDgwemlvZUhtcGk3cjlHSmJiUWoyQXFMWUVp?= =?utf-8?B?WjU2OVdQWVFGZnJNbXNmSzcxOXhxejgzOE9BK0lMbEd0SzdxNVFNRDFNN3Ir?= =?utf-8?B?UGwyVnBiQ0pnR3ZDSHVhNmhYb0tMMk9XaVNYZlBHWFphRjYwWis5azhkdWpm?= =?utf-8?B?M0YyWW5QTXhWV1pwaUQwM01SYWlvdWpQWEh0S1BheWYwaWtmUGVwVWI2elNx?= =?utf-8?B?STBaeXlzODZydUpKZjdEc1JtbzZkdUN0VUdPVmFzcjlYVURkUlZOVGVsZWZ2?= =?utf-8?B?TklNaTMyQTg5R0c5aWc0dll6eWc3NitHTUJYdHVoMU9IL25LeWpVWU9sdU9y?= =?utf-8?B?bXZmRFltNmhjbE9aaHhuR3Bjd2VraXY0TGdGZ2lSTDBNbmY4U2M1ekNhRVZr?= =?utf-8?B?VVE9PQ==?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 287e221c-6c82-42b2-abd5-08dde1757313 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2025 12:14:31.6198 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EG2dH+47i4udjII4HNUP98Grq+Xm0aNlz94OpY9Ycu4yHIUOIZ+vfhrXTYDCZK88wxYydEgYnzkY3hYtrR7zp8f17Fd7/SnX3aKV1iSDp/g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR02MB7725 X-Authority-Analysis: v=2.4 cv=TdPPdRQh c=1 sm=1 tr=0 ts=68a85f28 cx=c_pps a=z2Lz5URPHFYbctzabGIk+w==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=XqeNvJXGgvzUN9CD1PIA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 a=cPQSjfK2_nFv0Q5t_7PE:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODIyMDExNCBTYWx0ZWRfX0gNG6pZ6Ejzw oNW7nfMBPXSOkL7czbkFyKdW9xsxtodzRDn9pvPvhE7yRvdXXmBB6kvfhCIy8l6NJ8KTmKh/cHy P0bY0FgFzyFuol/nKnDSGPlF6H/1D5RN8TDqYujK2wVOsJwTbWGMc+4NYakuGvyyiNo6fTp3Edt PzMsnbTeuS9fdYI+QILttzZQ18VqmfpsayhqR0fldf0saBJJWPt7TXkQC3ubOr+O9gjFLeIiIIe gUvFB6lP2JTHS9JQOV4V8OYEk1CLSZt7Po3kP3wEu1pQonpD76vxL+pTz0vvlPcXzDbxfmaBDnf HobfcyC7/k8u3clCfZjhTOK1vm2pzUTuGpXS5awLoKfy0XILYYNbs5qG9Ov5B9IxJMjM4Ve9dSD 4NyVf/9q31Kv3KDFYDP7SheoH4J78Q== X-Proofpoint-GUID: NrHTClghmTJm-YTUnXUOBcy9quwX-4PL X-Proofpoint-ORIG-GUID: NrHTClghmTJm-YTUnXUOBcy9quwX-4PL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-22_04,2025-08-20_03,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.151.68; envelope-from=mark.caveayland@nutanix.com; helo=mx0a-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1755864948730116600 By definition PCI can never be enabled on an isapc machine so hardcode the = relevant values set via pcmc->pci_enabled. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Xiaoyao Li --- hw/i386/pc_piix.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 924888b59d..e8603b585a 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -492,7 +492,7 @@ static void pc_init_isa(MachineState *machine) } } =20 - gsi_state =3D pc_gsi_create(&x86ms->gsi, pcmc->pci_enabled); + gsi_state =3D pc_gsi_create(&x86ms->gsi, false); =20 isa_bus =3D isa_bus_new(NULL, system_memory, system_io, &error_abort); @@ -513,7 +513,7 @@ static void pc_init_isa(MachineState *machine) x86_register_ferr_irq(x86ms->gsi[13]); } =20 - pc_vga_init(isa_bus, pcmc->pci_enabled ? pcms->pcibus : NULL); + pc_vga_init(isa_bus, NULL); =20 /* init basic PC hardware */ pc_basic_device_init(pcms, isa_bus, x86ms->gsi, x86ms->rtc, --=20 2.43.0 From nobody Sat Nov 15 03:14:59 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1755865426; cv=pass; d=zohomail.com; s=zohoarc; b=MIT+RcitTd0lwNu7ADeQHMNkYycATV1/VqPyQYczwe24vdSduZxwiabrZLIln5oHYfpOvrhoasC8KVIY2oziCQdxkJtWehmteJko/wMb15h145D6y0jriFUDpRSKIhJwF0edTCp/5goadTeIEL4YsJqIKy9bF8oYHKk6t2Tf0V8= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1755865426; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=CGmhTVBvt85m8HvBjKXZAGnavsORO1zMKAvKw9f5iJM=; b=BWqnD7A6XJ2A14hVu/bAgFaAh9xpWAcQRP2isxhMMQr9thqIleZuG8+0xxvE418iokUVi4jE1VDGNS2ipPcLOJXpWi6xHm9sQrmJ1T73OD0Uhm/bVsnGzSpj53UPcxdcdR9YT/fkqZqF3PJF3sez1QR6o9fLTK9G8dF4lcBrMFI= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTP id 1755865426187773.5265786964217; Fri, 22 Aug 2025 05:23:46 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1upQfU-0001jy-BH; Fri, 22 Aug 2025 08:14:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upQfK-0001ht-3s for qemu-devel@nongnu.org; Fri, 22 Aug 2025 08:14:42 -0400 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upQfH-0000mV-UF for qemu-devel@nongnu.org; Fri, 22 Aug 2025 08:14:41 -0400 Received: from pps.filterd (m0127837.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57M7Ln8I667767; Fri, 22 Aug 2025 05:14:36 -0700 Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11on2099.outbound.protection.outlook.com [40.107.220.99]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 48mye8qef4-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 22 Aug 2025 05:14:36 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by SJ0PR02MB7725.namprd02.prod.outlook.com (2603:10b6:a03:322::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.24; Fri, 22 Aug 2025 12:14:35 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%3]) with mapi id 15.20.9052.014; Fri, 22 Aug 2025 12:14:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=CGmhTVBvt85m8HvBjKXZAGnavsORO1zMKAvKw9f5i JM=; b=s6yxkbrV9JJIgzHMxhpxZxKs6E5r1HqFg5a5KbwB/IvdSHGVzKWKzexMj 0uSRM31k2Z/g0NYfdVErLEnj7+8HGHgvHMyp0labf9LumMnXJYS7oSdG0XETZEIt l9JELZl27a3iIrTNFuHB2m7v4KsnDJu96RDu3V45q+e1z8h/+mfEZQ4vCdvPt7hd 6fSN0RqE/P+S1gj3xZBS9g79io0GIawx6qDeeqOzokFb6xJ6xrtIBEuBTSWvVJJI aNfW/CyfWDfYGLNJSXAJbSkmcXdFcVaJ+sR/1GbtVk0IeGUblHHVUVBfThX9eBK1 ZK1Z2zGM3SraWSFsjH/60GprrF+GQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cQ3STedCBVFPX1FB597l0VnqE7pcOERdv+RmJpp7Hx6PFsT+rMXHCNiniamyQk1nGYuwEGYLulvxkVDvBMOutnjt5o1zVA4pa0vYbo6wMfbSkyC8yz/z++DVrEYMUhBgIGnYOfdC3AXtRLmLbjgCT9Aw7ByGkTZbk9B/8KFqje+DR0gzhLvvOJ4mziLcRJIcjxXqwNy8RqANM1bTk0Yro45qslxnabrJ24UBpEJcmNnsMaxuD4Ts9HgNGdmjuox5L6LBMFOTuWdtC/z6eS+dgOFSpXuwDn2Y5PxeiJ/PC17i3FL+AqPrZ3AisGSDJD2fGbmyYl2BGh5XhhRL/w0w9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CGmhTVBvt85m8HvBjKXZAGnavsORO1zMKAvKw9f5iJM=; b=DkFdcjqWa66e0WcT4YXXrCycXlw0zOu6P2yqdMb03JpSS9+Au4JQRqLj/ULBfAK26Np1QGAsDOhfbGqe/Jqgt+o0KmegCgZRCIhjHQIPH6jSzvC4YcA4HdC+3Piipcu9PNPp57C4jXB2K+H+y3Tjq1BaYZskMrsPpJk/9YBMdeCSD+C7i6lG4ztLnq/yi+0yiFDo3t/GevgzaAnpqVOANTQvxNX23cAsuO0WozN6t5w6scn4kXE0E08YX/mcfhTEkes+98JV/U7IVoccmr7JXx8PeSrDytwLSaOdSVeSa3kUNEo0oYgLUsriU2x2tPE0o1ACclmkmdXgEFUSmSt/8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CGmhTVBvt85m8HvBjKXZAGnavsORO1zMKAvKw9f5iJM=; b=IMTez+Su7TqX3czDlbEan627mAMQXyOLzMMyjZxFNACD23VXu8y3S1U0jQLUGVvFeuHaelUZO0w1xY93SQpA/5rAO+uuxZ4w9XnYbcB95fwwr7lt5XLW8LJr5vj4gmoN+yc9RzKfJjlShZrquAdH2vwDPe/g5Z4gm/rmHSoHOdsmDZw6JWDV9N2t7fhA2eNjZ/pg0hRtbIA4aEARutGlQjNRgecWxooShng9FG4EcikNkjpCoZKmtLxVtvCiVjkK58B85l4Lqctj/8mMHeTGfyKHkf4awzMlhTEGkgG9U8Fx5H3JfK24hTl++eKyxwGCEq4r2vciDhDkptFoXV2JoA== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v6 14/19] hw/i386/pc_piix.c: hardcode pcms->pci_bus to NULL in pc_init_isa() Date: Fri, 22 Aug 2025 13:12:00 +0100 Message-ID: <20250822121342.894223-15-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250822121342.894223-1-mark.caveayland@nutanix.com> References: <20250822121342.894223-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM0PR06CA0080.eurprd06.prod.outlook.com (2603:10a6:208:fa::21) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|SJ0PR02MB7725:EE_ X-MS-Office365-Filtering-Correlation-Id: 201f1be0-5711-44af-0825-08dde175754d x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?YTVzcWhacmhGVzk0d2ZHOTNhU3VhL0F3SFF3UE16R2NVdGZhZzJNVUNVelFj?= =?utf-8?B?MFR1NGxWdTUvU2FMQTVuaHkwM25BeXFJTldZZVJkZzdpUjRpell1QTJIbXp2?= =?utf-8?B?V2NzSmhuemVMYjgzbHpFK0hBMzQvWFNwWjBldG12T1ZFdWNOb1B4N1lVU0Ix?= =?utf-8?B?MXJHMWtJMmpXd0xXODEvdnRzT2x4OENEWEpoclB4N1FBMVhpT29XZ1dKTlNj?= =?utf-8?B?ekZZVUZPUklIWXQ1NGMrUkpVdllXd21uNW5iOE1LRGY5aE9kQjI4UFY2MjJv?= =?utf-8?B?WGw3blF1dmttR3BrSEFhNXNxQmluVFdtZzc1WEtCYkFxS012WGpkL25kN1dz?= =?utf-8?B?aGZyOHRJK3BobUhwM1A5ZDdxRGpNOEcxMTZZV1VEUDNDU3IzS2pYQkhlOEo2?= =?utf-8?B?TTJuSjBjYk9RWmZZWFEwcC9uQzVwOUt4OFVYR3pNZ2p1cXRlRkV2TEVERU11?= =?utf-8?B?ZzA0UTNyWENUdlhnSjdWSy9aSXZXbDBudUZZZjJPSm9SL0QzRVF3dmRaMmh5?= =?utf-8?B?dmJmT1lQR2hHTWdxdVRqSnhRSnBqMWtLZnZLYmFIUjdMM0JaVXp2cHJ2U3NE?= =?utf-8?B?eEthdGRqVldZUU5pSG0vS1U4aDJwbEhpWlkxeWp0L29jV0dWMkgyVmc1RzhO?= =?utf-8?B?U0UwZUdYajQ0Q0h2bmJHVkxnYVlONWo4dWRnQ3hBWVpERXdQNnJubG4yODBk?= =?utf-8?B?UEQ2bkNBRkxUZWJEYkE5czFhVVR3eVlUZG14a3pWVHlBSkFCYWFvcFZYOTdV?= =?utf-8?B?cHRPdkZBTC9NWEI4VjRuUlZkRnhmRDBjdkdtZ1JXT0R3QURaRTUvMWpGUWJu?= =?utf-8?B?MldOK0Y4c096eG9FRVhKdFJnbXNFQWVEZUVuckNoNUpCN09oNlJoNmZvYlFQ?= =?utf-8?B?dUJyQjgwa0huSDAxSFRGdllRaXU4MHd5NkhCVEdBV1htUGlYdFh0cTdSYnpD?= =?utf-8?B?bnNHb3grQXVxQ05ReE9tcnBFSUhRTndlS01nZEVGd2tNcGlSa2pTMXRSNXkw?= =?utf-8?B?VmlBSnFEdXUvV3VmRGVYUFVjOU1mdDhaSkVjUDZRQ2NaWFJsY1E4R1FwTXpk?= =?utf-8?B?aXNsSUwwTy81QUFCZW5SSHBtNitkbzdTM2RLS2xVdWdOU015bnhra2dnR2F5?= =?utf-8?B?YTVENmY3K2lsd2xPM2hpZkN3b3J2TC95SDZHRkFEOVFmYklDSU5LWVdlM0N4?= =?utf-8?B?b1k5MjZEeDJXZ0pIdUFhVExNY2FkZmwrR1pDOFJvR291YngybmUyRUlHNldy?= =?utf-8?B?VmxjS2ZJZnpvM0srYUNoMmdyd3hYc2NScDd5WCttZm12ZmxXRkhpQVNDMjdR?= =?utf-8?B?aUozd3FQdkFPT0Y4MXFUNG9sVHAraWd5SnYyOTNzbnpwcWE3N0VQZXQ4MDFC?= =?utf-8?B?K3lKcElqNDRZMW9KZDhDMVVsM0dPNjkxWXR0cG9RSHBNOTEvb2VvTHhlYTlP?= =?utf-8?B?cmd4Q2s3N0hYZlEvN2lYMkJuZGY0L01PcnB5bWh1K3VYREN1S2tEOXdZWWVr?= =?utf-8?B?L0RhZUJNYTROeVljQ0RmK3JNWTJwRzJ1VzJieGE3SzlmSGtoTjdjclMxSkZZ?= =?utf-8?B?SG5kTmFGVGU3ZVhrN2hNdXlldExDVzFLZ01UNXZKSW5Mbi96S3RhNHVCK29X?= =?utf-8?B?S3QvdTJwQ1JYM2NwaVd2dVIzbDFpaU1VKy9zZktVeE5HZlF3RWQ4amRrYi9N?= =?utf-8?B?Rko2N2trV3ZPR3pFRjg2T3A3ZnpCT050NGszREFZa0dFRms5SmlJeGNGMk10?= =?utf-8?B?Z3ovT2xpdEF3RmRYVXdIeVdsM0ZiSnU0WndkK2J2UkNrZTFhZGI5QzZzTk9a?= =?utf-8?B?K25qc0Y0WU82aVkwL3FVTGJjdE1OVVdCOTdRRjgrT3lIY2NNRVZjdHhYSVJM?= =?utf-8?B?L3VXSnVkcXZ4dHdvRVF3RmN4bjFmUm1YQjRsK0cwN2kyY2dwWlRLSW5aTXdi?= =?utf-8?Q?2UlnqcL+bc4=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NW5Ba2hldFBxOUJIMEFwR25DcWk2cXcvdXc5N3ZtREJWRWl3a2lGQjNodGho?= =?utf-8?B?S2JneFltQnYrekpTcVNVSTcwTi9kTXNRWU90MjlDd3pvZUFINU5JZy94ZEt3?= =?utf-8?B?ZzM1NzRjVGprOG5pL01DTFdIejFHK0lMVmkwbVl3RWZ6anZ0d2Y1ZmJIVnBR?= =?utf-8?B?am9CYmRTUGhWL2N0OVVySGI2bkJRcVVURVRha3pNem1IYkowZFExb2hMVHBM?= =?utf-8?B?TnQ2TTJWN3ZFRVNKZGVFcU9OMjdlM3NUNGJBUTlZMVZwR0pzUmV2UlFsKzlD?= =?utf-8?B?ZTNKRFVWVWdBQ3U3ZC9Yd0l1eVNRNmUxU1FkYUhvR0xmSjE2YnRFYjZnNGhR?= =?utf-8?B?eTRtZlZjNGl0KzRaOUd2UG5teHpjcldBa3BKb1BVMTVJbURVeEJybGYwT3BQ?= =?utf-8?B?S3R4UTJOQ0ZyWnYxa2haMVBjT2VOOExTYm9zb2JHVWZyMFVsaEJ3amtBMkxQ?= =?utf-8?B?WUZUU1hZd09UUmpzeGhjMEV3b1VOTklmMmtXTysyTTdlN21kcUI1dnhKa0tv?= =?utf-8?B?MEYvT1YyREtLSnpjNDdHa0dmd3E0OU5JN1FUTFdycHhJTWpJVzF3eUlmY0tE?= =?utf-8?B?U3lTdFJQNXlUWmdXL3ZHZEVRT1RLeEgyWVVXbFozcDdBVHgzWXZDekNkbG9q?= =?utf-8?B?cERCTHpXblNuMkF0dThsbUNZQWVLRXdaMS92dHFrdmxHMVZBekUxN3JkWXhV?= =?utf-8?B?MG1zL09VUG00MEVEUS8yVllWUThUTzhMWDd1VXZKbzVxa09vc3hMUmN3c1l2?= =?utf-8?B?VGRnaG0xYUlBa3hLbG1pSktVZnVacWlqY2psMVFHWVVYekdLRUxtZ1ZjSVZ0?= =?utf-8?B?K1Q4SzJkdm1OcW8yQnRaM0RKMWtyQVd1bzgrYjNENFRpMWtuZnQ4aURKOGIw?= =?utf-8?B?blZiQUkvRGNGa0Z0SzBKYitLMExXZStKdXJpdWkvZXJ2LzF2aHNiSEQvbXJ5?= =?utf-8?B?MnpXeElCWm9NRFdGK1JPNnZSQVdzVkZPUnBmTjRteksxRFZBN3ZZT1FKY21u?= =?utf-8?B?S0EwbG8vaWFXRHZHZTJZYXRzM0orb3FaYUdCeHVkWHBCa01UZlNWSHRrT0ln?= =?utf-8?B?WjIrSWpNaXhiUFRwMzdZNEFseldyc2xhRzlpMkpyNERwMEY3QUlaNjNBemJU?= =?utf-8?B?ZFpOY0RHcTJ2MEFDSzE0OVJ6b3RXYXVTdGZ0azBpbTYvNk50VTZCa2VJMitp?= =?utf-8?B?cTA3ZzVtVUlKbkxFc2VRcERTMGk0UUNWWjFDdWM3YjNIaVY0L3QrbjhHUlgr?= =?utf-8?B?WjlQcWxkVFFjQU9vMkdXTzZ6VGQycyt0dFd0QzZQWUdiVk00MTJ6NDVnMFI0?= =?utf-8?B?Tm5IT2VLT3N6ZUtIUUF0WUZDNWZobXhOMG43UDJ2UDZ1WmxqeWVrWTlvb0hq?= =?utf-8?B?TnNObUNUTXJucldEK0FZMjZvS0NNNVZsZTdQc2hvWWFib1JueFRUam9wNnhK?= =?utf-8?B?UHZUckVlN1h2ZjdiSEZkcnpJajduaGU4aU9VZGF1NnQ4VmljUzJGeCtIbjlV?= =?utf-8?B?ODZIWGMzVFpBNG1MbzFTZGNaYUI1eUdsQW1lbmd4VTk4Y3NVc3lDSXRXZDJh?= =?utf-8?B?WTd5WVg0YTNsTTkyYk5zTmM2ZkV2d0FYdWp1WkwrRExvVEwwdU9DVHY4My9D?= =?utf-8?B?UUJpU1h4cWNBa09uWVdGVGtHMm5POWd4bWE5M2VXaUQvb3l0Y0dHMTNUTW5V?= =?utf-8?B?U3BqVE4vbnVnQmQzZXUwZTJTMG1HN1FUbWNqNmlHTS9tVmhuQTROZGVwN0tF?= =?utf-8?B?MWllejJqN2l1OVNNa3lyeXFQSE1rV25zQk5jTXk5S0dVWDBlWlhqRVVVQ3gv?= =?utf-8?B?NktEejZTV3ZwVkRPRThhMDdrR2paSTJsaEJmb3NtTG1KSUUvS1d0M1hRVm9N?= =?utf-8?B?SEE1T0M3N1dhc2RXdnZCeVh1bUIxNldhamVVNmdKM2w5Y1BKODFESFlmelN3?= =?utf-8?B?MCtPdStJN2J3ZDRld1RFNmZtWXh0ZHV0a3VPbVdoOHQvRTIvNFVvZVZzMFhB?= =?utf-8?B?S0I4aUU2MS9oRmJqRjI3S1hwUzZsWHhNQW5aam4vNXp3Y2ZsOEhuRXRuT0FR?= =?utf-8?B?QTU3Zlp1L0E0Tm80Nm9qSG43UVl4eExhQXQ2dkNENVprS2wzYTRhMytsYUhq?= =?utf-8?B?U3FCVmgrTEQ2ZGxrWURQVTRVSWN3bThqV1ZQZDh3cnloOWFCN0ZkYWlPRERC?= =?utf-8?B?UGc9PQ==?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 201f1be0-5711-44af-0825-08dde175754d X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2025 12:14:35.4450 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3CodMlGIz7cw6GJrnw393A05JvY9GTHt/JmU3Rl2XvCC1rhALgv23oOFQVN2l4U0GvVN4Na1XlElrC6A0+QTB7aE7gD0T2vdUYMA0MC2bbs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR02MB7725 X-Authority-Analysis: v=2.4 cv=TdPPdRQh c=1 sm=1 tr=0 ts=68a85f2c cx=c_pps a=TjEtcBNk5QtzPaPmdoRRgA==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=m4-MuDShih0a2sssyXkA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 a=cPQSjfK2_nFv0Q5t_7PE:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODIyMDExNCBTYWx0ZWRfXwK5AnnYvy1cO q7VhrONdZfQ44lghAzRp0gycrZEi1x7gS18AMpXb4dwizDwe7Bq90I5xB0ZcdJ0/jXhVq3uhOAS 0K1NOZl3y9qKx3QB+Sm27QTDWLqwnXxBdkSG8G/W8I69dbBEKUq9gIspZy3c02NuGXCPu2LCkwg O2BmoAOEgjhbZnpjHYOtJhwe+89HotP0dK421eu6JF7Bl8/xYG+abej0BOZM3JNndRZyEVeSdY6 nckjycjWlnxyqID5fHNPwnO0sQCzOXJ/bF/nOuh9JjZTbvHSeei9onzMFOtUZpvDy8lX+lKA5Zx bsdwpeZAF7yXNSPvPv1SwlmNQ5tyJ+fhgKuXBStfUeZSfiErksjL/mvyUqQwXkTkQ8gdgkiXLvH lN56dPdxEeqUpnPzCvYLHJE3s0sgLw== X-Proofpoint-GUID: e5ePnsBLqlsTWomYY28Sr79owSTDm8Qa X-Proofpoint-ORIG-GUID: e5ePnsBLqlsTWomYY28Sr79owSTDm8Qa X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-22_04,2025-08-20_03,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.151.68; envelope-from=mark.caveayland@nutanix.com; helo=mx0a-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1755865447668124100 By definition PCI can never be enabled on an isapc machine so hardcode the = PCIBus argument of pc_nic_init() to NULL. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Xiaoyao Li --- hw/i386/pc_piix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index e8603b585a..49bd1a41e7 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -519,7 +519,7 @@ static void pc_init_isa(MachineState *machine) pc_basic_device_init(pcms, isa_bus, x86ms->gsi, x86ms->rtc, !MACHINE_CLASS(pcmc)->no_floppy, 0x4); =20 - pc_nic_init(pcmc, isa_bus, pcms->pcibus); + pc_nic_init(pcmc, isa_bus, NULL); =20 ide_drive_get(hd, ARRAY_SIZE(hd)); for (i =3D 0; i < MAX_IDE_BUS; i++) { --=20 2.43.0 From nobody Sat Nov 15 03:14:59 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1755864919; cv=pass; d=zohomail.com; s=zohoarc; b=KI/SfXFeTSDMRTtRXCwDlkQYQHWmZkXpCALz/q5EZrVrY8dG7s10ogJbLcZ+fpWPTJp3G/hKErZNmXaBurR+dzUk4cD1mF8hcar2LfF1Y6gAAWbHRq6ucAixFXAkdE503glGfxPKnAyRILT+g137MreBA7y4NF2ctzLPvNPAXRI= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1755864919; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=/XTu8amX6Z1vv0g2FjQXw6WroZw51LdOx6sVhj+qN8A=; b=AdBvhCYmBA1vVYPSFME+cFNMjsSdQIOu0+lPgKOopqr1IxnU8BAxQTFSkMGfcbMezrNgkpN3UOjkWV5j4J4ZzMrox51+uc7cflzgvgd3qrggJ2SddPOtbpCiH0GgwmAbgd+dEOSBJ6KqzWXEuHhE0dRTNmfF8YWkS8s2HkbKs1Q= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1755864919281246.7229759910415; Fri, 22 Aug 2025 05:15:19 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1upQfk-0001tM-Ht; Fri, 22 Aug 2025 08:15:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upQfQ-0001jN-9v for qemu-devel@nongnu.org; Fri, 22 Aug 2025 08:14:49 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upQfK-0000oE-Jq for qemu-devel@nongnu.org; Fri, 22 Aug 2025 08:14:44 -0400 Received: from pps.filterd (m0127843.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57M7iUkm713901; Fri, 22 Aug 2025 05:14:40 -0700 Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12on2100.outbound.protection.outlook.com [40.107.244.100]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 48mye6qge9-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 22 Aug 2025 05:14:40 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by SJ0PR02MB7725.namprd02.prod.outlook.com (2603:10b6:a03:322::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.24; Fri, 22 Aug 2025 12:14:38 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%3]) with mapi id 15.20.9052.014; Fri, 22 Aug 2025 12:14:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=/XTu8amX6Z1vv0g2FjQXw6WroZw51LdOx6sVhj+qN 8A=; b=1wtUpq7YtOokV7EBD1rqRdPQove96SlOaaE07Fpb33IPQRTxobOOCqNNh vJpCB9V3cZpuvqdEjN8Ojpw0gjrM9eCaxntcF9D5NJ4YYaBjhvqCqXp/WbJrHS4o 0ErjfAr0+b9DV1UyAtFAJ1GoF5HkzI797R7zF50LWqIOP7ONq3LQqWl5ck0W00o1 k/yjs9V9NCEhydE52NRfvpUNp4dJlv0kxdO76sIFAFUynPVZHgFK7m47MYkGSfEp Ox+/ghD8foa1A5KFpWAJ6EOZrHn7Jy2TIlonEzOb50oz8Ep7yO4s7esgpE2zhPfe mhQq7OdTZxc7iMmVtCGZuf6W/cWpQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mjVM0B89XpfK3Ygj4R9rqHDh+M7F9t60RAEIkWSBzbUSzBw4eDqSuUogbUmBz7sySFfzh7uFnPqT8tVsdnBLKYnbcz4Z3hIET3AUKeNU/3MCXoEfwGSfNQW0HGhaHEgF1X5f9whJLgoXMLQlLzNiiHz1Rm9RSBdz1YRsrqy7PScW48b6oPurXTkq0iWuvEmVrR2beYJHLm+eu/ZtVDFzvYmEuaisouy9yNQQVF9k0gaKC9SCIaWSWy7CxGi42E26h/SzakX49J43nUcM6HTJLh58AcaOg3QvA44BH4tegS2H1eEyDMnK1aKit29ojOpgqGeAwWgKMuA+utGH7RI+gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/XTu8amX6Z1vv0g2FjQXw6WroZw51LdOx6sVhj+qN8A=; b=TKljXxi7KJU+wynf4BzWs5iFmCIwl/qeqjfDqsaWyuToxyap0lWg2bk1Dqh8gbPtJmov/guaQn3UXFYu1L2j3GQcyuPmzBzgpF8iPl9/1D9uGtHacXwmQtm1DcskUwKaP2/O7OT4lxV5D2gCx0Yx08OHWsqo6No+H61NAkjuKnCw5NL4VmpFwFK/a2Pe870RYGXYW/Y68zr423nuFrd+IJJBXqg/ZvlnvUJ/WseNWry7EZ4VwcR3M9Bc6nJDRcXXpvAsp2dnyJxB/lvqD8U0rHcMum8d1t64XKTfiZCq7Oq5QqJWQckkZKsGxb5pC9jqEo9YlO/ni9yneOJp2aQoWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/XTu8amX6Z1vv0g2FjQXw6WroZw51LdOx6sVhj+qN8A=; b=qvb1CVNgUs++BUV57llGKs3pVTWqD92whk7+xLj7IC56s7FcQ+iLHNKv2L+E95HRAz3oozoY4tdeBzZEt8RAM+vhgYcQPlQqlUBy73mnB7hCD3uDROeoJTdyuboc/dEECMRi4zb3oJzGdPndQfnaM1cSbuH1mJGZuhTK1QOr6ycL77KHYVDF7i+wD6e0PqyKx6QYqNpUqeCa2oXqdRfkHhU3I70mVVu7Y3gm7HmMq5pMsi6FegJv51DLKdL79UyvEhUbPZDWgo7RAgOuDdZod1hoZFr8IrctzUyRd1MEBLf28RM/iQomNt6j5w0LGedmS5caU0wjU0iZ2lgBai9/1g== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v6 15/19] hw/i386/pc_piix.c: assume pcmc->pci_enabled is always true in pc_init1() Date: Fri, 22 Aug 2025 13:12:01 +0100 Message-ID: <20250822121342.894223-16-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250822121342.894223-1-mark.caveayland@nutanix.com> References: <20250822121342.894223-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM0PR06CA0084.eurprd06.prod.outlook.com (2603:10a6:208:fa::25) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|SJ0PR02MB7725:EE_ X-MS-Office365-Filtering-Correlation-Id: df9ecc06-ba9c-4784-cf82-08dde1757750 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?UFZVbklVUUpGYTJNNk9CdElIOUdkdW5CWWhYcmdENjlDckZJYXZJUTljNDZF?= =?utf-8?B?QzZHVThjbGxOWXJhTVQyWTVuNmIzTzhUZnlJcWU1dVAxYWYvUmhSWjBROS9C?= =?utf-8?B?dkJ2dXFTVE1PM3N5N3dDaVQ0dkt3U2VRRWdGRjZtbVFHVndyTTJCWUw1bmsy?= =?utf-8?B?WkxmS0J4djFmSHFiL3JmTkxhSHl5WXZTS1RZYlloOGJiL243djdpcFYvWEdR?= =?utf-8?B?M25aUGtQUWdCcmxnVGFTdkxhZC8wMjk4bEljY3FLQk14QVRwdnZwaXlaRmZR?= =?utf-8?B?ZDNBOThjODFvV01KQnR4YnNxdit5Y1JNdGVxNzFlVk52RWUvY3lNNkpwa3dP?= =?utf-8?B?VExJTXVTWjR5eTdjamFmUGVEaFEybmMzNVFlZ3JIZm94OXRPODU4Y3pvVnlZ?= =?utf-8?B?NGloNFFpWmlUZWFpR0RlV3ZPT1NwNmtzTXVvWXljeElocW5rd1JucjVBaVN1?= =?utf-8?B?dUpoOUcraWRWSmt3dTA2aTdEYkFFWmZKK1dLbzJvVEg3K1Rqc2d1SmhxY09v?= =?utf-8?B?YnZRaUxIbm5UeUN6d3oxU01hWkQyN2pqbGxKeVhyUDYySzVEckFTZC85T0tH?= =?utf-8?B?YjBvTGRNVUNZcGtSSVpLOWxzNFBlYVNxMzFNK3BaVlBNc1RwbTM3MnVlaExH?= =?utf-8?B?dC9YSUQ2a0hGSnNxL29GUis0Y1FLeXR4VjhqWkxCMGxNWmlSaGJmR3l0TFNZ?= =?utf-8?B?cG1BWDZaZDg1SkdGUlN2RzN6M0FKOWQzY2dSRHphT3hJUE9RZXhRcWNoa0pK?= =?utf-8?B?cDY1ODFEWkoxYUdNZDVmd0pQbjlySXFIb3g3blFtcG1HMEJtU2VTS2YzM0dZ?= =?utf-8?B?Y0xHTHhDaFZwMjlDeHptaUV3UXVleUwyMUZVOTF6R216ZHNpYkZEL2JjMXhR?= =?utf-8?B?eGcyVmswZXVoWlBhdFlLMG44TXVDZGdZbTNJV3RTLytVY2ZPWnZPRjVDaVZT?= =?utf-8?B?U3dNTzBReC9SVWtFbXpJZ0xLNlJPRnVsNE5IMlZXYTA0SU5nbUJPenpQN01q?= =?utf-8?B?QXlCVUhxa1lGek5iUnFxb0Q3b1hNSk9LSXpCN1NjL0doNko3NUNGNllqdVdL?= =?utf-8?B?c281VXFnL2JuOERNVnYxRHg4dU9wUjY0cFpsTjNoUDlBNjFlS1QxcDdHaGg3?= =?utf-8?B?N2IvWmVWenZSS05Pb2J5VGJsVk1hWHhZckdLbUtSMEs3cVdDaU5GeDNxSkwy?= =?utf-8?B?TmZJUW1PQkx6TWdJSWM1elVsT2tYUXdnRzBDaHBqVWcrdk9aQlRkMEk0MTNJ?= =?utf-8?B?KzhVYkZsRnkvR3ZSNnBadWpscUp1MU5ZL3ZTb2xyWHpodVdyTlFnUFFpZDhT?= =?utf-8?B?K0hyZ0NnckkzMEwwcjduRVNkaHUrWkRnSVhOR1A4S1d5QjYzZHNSR0haOGNu?= =?utf-8?B?NVBwUHZGTEVPVGV0SC82akZzR0hMNXBGMVlaVklMOHAzbUF0ZFkzVktqSjlK?= =?utf-8?B?dlZGZ3RVV3F5LzljMFkwelh0d2NHb3I0RjFjaVVxQ3l0RjEvbC9IRzY3MllB?= =?utf-8?B?QU5IT09aRTFUUUliK2lFNEtiNllNREZyQXJjQU5WaE5ubjZZZ1dNeTY2M1pw?= =?utf-8?B?Vno3TXNNMlY2c2Vjb2lIN1VLZ1dVZVc4Rkdlb1pybWVSZ0xlZk9JL21STU9x?= =?utf-8?B?MU9lTUNFbGtVUnRaYjhDQVJQZExxc2RYVEp0NjE2Y05RbXZTU0xjbVYwdjRK?= =?utf-8?B?UDJDdlI2SUFOZVhrQmpIRU9tMTFDL04vL2Z4S1NHNVRSSW81NDFORGNyVEc3?= =?utf-8?B?RDdmb2lkd1JXeHJqODFkTElBcmpUVEtzWkhwV01tTDROVi9LazB6bHVFMk8w?= =?utf-8?B?ZDAwN2ZiRXlVVURhSE1OMW9uNHpUa1NIWkJ0K1lYeW5yTUNiL0sweng3d3ky?= =?utf-8?B?eEpjRitGaVAvOW12R1pmUG5WSTNpVmJUdlpUVWhsSHcwemoycE8zTzdMcjR4?= =?utf-8?Q?BvyGM6xxJFw=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZmRjYjhsTVBWU2xycEhYOTlXcVVJbk5uVFBIYzJPMkE2M2NzUVpyU2w3RVhQ?= =?utf-8?B?VW5vekl3dlVpZGl3MkU0YUszT094bkxWV1lMWGJMZUdxbmhGRGJ4M1lIK1pv?= =?utf-8?B?aXVOd0JIV0RlYk12TVp6UVlqVGhwdlBqUUJyOUFGN1JBcnRvTVJYbFZ0Qlcv?= =?utf-8?B?b3ZoMTJqSlVVRmVvelJHMzg1bk01V3pzU1RuaGI3WmREQmNRbFEyaXZ5N2xY?= =?utf-8?B?ZVNRTDFwWlNHNlg5eDR6QVJGR3dXZ3loeVkyVUdlQVJ6VkhnQWVNQTNXRm50?= =?utf-8?B?Q2pyRUZrQW9WUUJpeWJsTVhXa2ptQzZ5K25Rd3BPR2d1UC8wZTVsZXJ4M0Y0?= =?utf-8?B?UVhYRm8zU3EzVC9mS3hOd3FYY0JWbURCbE1zRHNMMURFZCtId3VJUGo1UXNR?= =?utf-8?B?cVIxWDNZUnBJR3Y5V0h6YW1UR3VpU2RqL3QvSnpLVUYrVnkzSisrc2NTdVha?= =?utf-8?B?WjBIdjlaTFdGYnRPU0lCMTl6QjExZ2ZPL095U2s0TEc4M2s4bzhsUThvelZu?= =?utf-8?B?ZXdaMU5DMWE0ZHBXZEdtd0ljb0ppajZ5SzVoMTR4eHB4SHpWTmdGZGs1WGtn?= =?utf-8?B?a3RTei9ESzdzbTNiakE5TnhqNitWT0Vpb2JVUVFxeVJSVlBiRFo0KzB5RWJx?= =?utf-8?B?VUJITjc3U1F0SDRkU1lIdmt6RkVYVW1Sb0o3a0FVckk4U2luVEJ6RS9NS25J?= =?utf-8?B?WlJ1bGcwbTk5RHZ1M0Ewbk1NNllQRW9yTVZmZzRjUWNGUDFndnRwTEhWcFBz?= =?utf-8?B?TlorOE90NjZkcjI1T3ZEYUs1aSt2NTJJU3RmYm9DSTdkbnhhU0lnMnUwQU1w?= =?utf-8?B?bU9hVGN0OVo4SGdSdjlUTFBnZm1vZG9FY0lOK3N4ZE1NeE12YkpwQkVMd0Vm?= =?utf-8?B?T1drM3JTK3M4VzlNUkRiNENHWGxwM2g3U3NuQ1UrMXM3RlBBZmpHeFV0SmVP?= =?utf-8?B?NndVZGt3a2U5QmNaZVM3R1c0UWw4NjFxSDFiMFJhZWUwVGpaN0xkSlZVNjFC?= =?utf-8?B?QUhud3Ftc2ZXcnd0T0VEVVJXTHM5T3VLZm0vMTYzekxSLzR3MlY3WHB5QU0x?= =?utf-8?B?WWo0YS80T3krUmU2VzhtYnZXWUM5ZFYyK3g2ekpRbmI2a2xYVnRmL3ppY2t4?= =?utf-8?B?dmI1OE10U0pSQUhzQVVXUlo2Qk5xRElpQUllMDMwcHRrTlFsZUtTZEVCbENX?= =?utf-8?B?VkZOUTlNSVR0MG5PSHZiZHc1ODBzeHdDMm5MOVVzd0NHLzJGSDE2c0dMZVVE?= =?utf-8?B?UkhSMVFFWm8zNWdkZTl5NDc1OXBIcW45WkJmaXJzaHdtays2eDJ4TXM1aEY5?= =?utf-8?B?ZGI4a1RDUHoxa2NUR3ZpRVFVeHZRL0hxZnpVUFJOQU9TWnBrL2FmMTVBeGZ6?= =?utf-8?B?MTNlUTk5eHB6UEFjbzh0c3BDWSs3TWJzWVEzb1RzTHZKM3pVckdZZWRVakVn?= =?utf-8?B?amo0QkdGU0tVUjNNb1lGeklneFZvWEhnMUxkcU5PRFNiZXNkM3JPTTVOUHdm?= =?utf-8?B?L2E5YzV3VjV6NFVpaWt6WnhWZEZTblNHOUxDVG5MZVViTVNDWENlUTlVaGpF?= =?utf-8?B?SWhsc1pwdlhCb05QTkZKK21tZzRreVV2UUJ4SXBVSjFNT1NUWlM1VDNKdmNq?= =?utf-8?B?QmEvcUNsMU00S0ptcnBHcThsYzBtbXB2dnJBTUdpWHFMQ2VoNWZBeVFDQXZu?= =?utf-8?B?d0xENU1ka3Y5aWlWYUpZMW9LYWd4a0JTVlNIaFlzaHNjWFpSS3VHcTg1UFha?= =?utf-8?B?Tm1Od3FzaTl2RG9DQ2lGWjB1TjBYdXVnVU1yQ3lWQ0Rtd3MwTzZUQkdyWDZX?= =?utf-8?B?R1UwQ2RXeW1RSnh6ZFJyQUJUbWdyeXlYT2h5MGdtWmFxU00xcWErc2txTWRT?= =?utf-8?B?MFY5STlvQU1kcC9DZ0tnT0c3QVdLaTBpWEZWVUdNUmJRbVRHcnB4QlpRK0VW?= =?utf-8?B?bkJVR1FIVU0zMXROeHJReEVUZTR5Zy9GVktPWjF2azljQ20xZS9oZnBFZWx1?= =?utf-8?B?OFdPLysyc2ZGYVc5NFcwRTk2VTA2RUhtcWFQSlFFQm5sMDlMSEt2SmFRMFhl?= =?utf-8?B?V1JMUk5jMUREaFcyVVp4bzNiUW8veTRYbWl6TEQ3Zk5ER1ZtWmYxNk54TXpt?= =?utf-8?B?UFhzRjVDc3o3L1RHQTJuQnA2VDZKYzJxTjBTUWg1NTJ2MEtBSGlsWkgyaXQ3?= =?utf-8?B?MkE9PQ==?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: df9ecc06-ba9c-4784-cf82-08dde1757750 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2025 12:14:38.6781 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: S+BExXFEZL4cYBNpxmbYHQdYtWwvtJyObBTIpxwjLAzO8sgHFX/fyJKdvSZ/KNfSQqfjTeecr+efvhdUhGAkHJAXZITS9lHRM8Dzbc6drj8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR02MB7725 X-Proofpoint-ORIG-GUID: HvFJqj_UOCcWN2LFQWk3IdDLUT0Fbh9u X-Authority-Analysis: v=2.4 cv=QLwxhgLL c=1 sm=1 tr=0 ts=68a85f30 cx=c_pps a=X0TKh/MBF1+/LqYN1SieOw==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=ZtfbtUD1nkWWkvgxnEIA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 a=cPQSjfK2_nFv0Q5t_7PE:22 X-Proofpoint-GUID: HvFJqj_UOCcWN2LFQWk3IdDLUT0Fbh9u X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODIyMDExNCBTYWx0ZWRfX3c8xNhE0KDmH glhaIkxzDcZu8+7NZu+oigdHRfnl82mcdcN+UOKf4SUD7ucdWHW0KOB47hl+fgNbPGC4id6BPjy XJKaHK1AGinBFEuGJkRBuzni0/Dq5/cY3HKJsh8ugkwpEso1iFkA2s6MoVkmWICWvcj46Ss2Rof CeQ5ASEv849KjvxyNIynkfgG4LBBVFPGeMe/N+ZjRy3nS/Us+7jSv3HZgddy9QBpdJFZO0gbUk8 xp4nu+g1EUED840dLYRYxEK4UkeBNd2TR32RDmgErEYGkfXLdDfe04N+k2pkscfSJlYF7uOuI5/ WzcCGQkLh52gdAoS/lEY7LJ6PEKHM5/dChQ0+N7DLXgD7UrhV2mJQpOT2MMGTJEyRnoe0Eq6+F+ TDa2Ibc6zM8ksf2F5l+fC9kVGti1pw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-22_04,2025-08-20_03,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1755864921186124100 PCI is always enabled on the pc-i440fx machine so hardcode the relevant log= ic in pc_init1(). Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Xiaoyao Li --- hw/i386/pc_piix.c | 194 ++++++++++++++++++---------------------------- 1 file changed, 76 insertions(+), 118 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 49bd1a41e7..a776998504 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -71,7 +71,7 @@ =20 #define XEN_IOAPIC_NUM_PIRQS 128ULL =20 -#ifdef CONFIG_IDE_ISA +#ifdef CONFIG_ISAPC static const int ide_iobase[MAX_IDE_BUS] =3D { 0x1f0, 0x170 }; static const int ide_iobase2[MAX_IDE_BUS] =3D { 0x3f6, 0x376 }; static const int ide_irq[MAX_IDE_BUS] =3D { 14, 15 }; @@ -125,6 +125,9 @@ static void pc_init1(MachineState *machine, const char = *pci_type) MemoryRegion *rom_memory =3D system_memory; ram_addr_t lowmem; uint64_t hole64_size =3D 0; + PCIDevice *pci_dev; + DeviceState *dev; + size_t i; =20 /* * Calculate ram split, for memory below and above 4G. It's a bit @@ -195,38 +198,36 @@ static void pc_init1(MachineState *machine, const cha= r *pci_type) kvmclock_create(pcmc->kvmclock_create_always); } =20 - if (pcmc->pci_enabled) { - pci_memory =3D g_new(MemoryRegion, 1); - memory_region_init(pci_memory, NULL, "pci", UINT64_MAX); - rom_memory =3D pci_memory; - - phb =3D OBJECT(qdev_new(TYPE_I440FX_PCI_HOST_BRIDGE)); - object_property_add_child(OBJECT(machine), "i440fx", phb); - object_property_set_link(phb, PCI_HOST_PROP_RAM_MEM, - OBJECT(ram_memory), &error_fatal); - object_property_set_link(phb, PCI_HOST_PROP_PCI_MEM, - OBJECT(pci_memory), &error_fatal); - object_property_set_link(phb, PCI_HOST_PROP_SYSTEM_MEM, - OBJECT(system_memory), &error_fatal); - object_property_set_link(phb, PCI_HOST_PROP_IO_MEM, - OBJECT(system_io), &error_fatal); - object_property_set_uint(phb, PCI_HOST_BELOW_4G_MEM_SIZE, - x86ms->below_4g_mem_size, &error_fatal); - object_property_set_uint(phb, PCI_HOST_ABOVE_4G_MEM_SIZE, - x86ms->above_4g_mem_size, &error_fatal); - object_property_set_str(phb, I440FX_HOST_PROP_PCI_TYPE, pci_type, - &error_fatal); - sysbus_realize_and_unref(SYS_BUS_DEVICE(phb), &error_fatal); - - pcms->pcibus =3D PCI_BUS(qdev_get_child_bus(DEVICE(phb), "pci.0")); - pci_bus_map_irqs(pcms->pcibus, - xen_enabled() ? xen_pci_slot_get_pirq - : pc_pci_slot_get_pirq); - - hole64_size =3D object_property_get_uint(phb, - PCI_HOST_PROP_PCI_HOLE64_SI= ZE, - &error_abort); - } + pci_memory =3D g_new(MemoryRegion, 1); + memory_region_init(pci_memory, NULL, "pci", UINT64_MAX); + rom_memory =3D pci_memory; + + phb =3D OBJECT(qdev_new(TYPE_I440FX_PCI_HOST_BRIDGE)); + object_property_add_child(OBJECT(machine), "i440fx", phb); + object_property_set_link(phb, PCI_HOST_PROP_RAM_MEM, + OBJECT(ram_memory), &error_fatal); + object_property_set_link(phb, PCI_HOST_PROP_PCI_MEM, + OBJECT(pci_memory), &error_fatal); + object_property_set_link(phb, PCI_HOST_PROP_SYSTEM_MEM, + OBJECT(system_memory), &error_fatal); + object_property_set_link(phb, PCI_HOST_PROP_IO_MEM, + OBJECT(system_io), &error_fatal); + object_property_set_uint(phb, PCI_HOST_BELOW_4G_MEM_SIZE, + x86ms->below_4g_mem_size, &error_fatal); + object_property_set_uint(phb, PCI_HOST_ABOVE_4G_MEM_SIZE, + x86ms->above_4g_mem_size, &error_fatal); + object_property_set_str(phb, I440FX_HOST_PROP_PCI_TYPE, pci_type, + &error_fatal); + sysbus_realize_and_unref(SYS_BUS_DEVICE(phb), &error_fatal); + + pcms->pcibus =3D PCI_BUS(qdev_get_child_bus(DEVICE(phb), "pci.0")); + pci_bus_map_irqs(pcms->pcibus, + xen_enabled() ? xen_pci_slot_get_pirq + : pc_pci_slot_get_pirq); + + hole64_size =3D object_property_get_uint(phb, + PCI_HOST_PROP_PCI_HOLE64_SIZE, + &error_abort); =20 /* allocate ram and load rom/bios */ if (!xen_enabled()) { @@ -242,72 +243,51 @@ static void pc_init1(MachineState *machine, const cha= r *pci_type) } } =20 - gsi_state =3D pc_gsi_create(&x86ms->gsi, pcmc->pci_enabled); - - if (pcmc->pci_enabled) { - PCIDevice *pci_dev; - DeviceState *dev; - size_t i; - - pci_dev =3D pci_new_multifunction(-1, pcms->south_bridge); - object_property_set_bool(OBJECT(pci_dev), "has-usb", - machine_usb(machine), &error_abort); - object_property_set_bool(OBJECT(pci_dev), "has-acpi", - x86_machine_is_acpi_enabled(x86ms), - &error_abort); - object_property_set_bool(OBJECT(pci_dev), "has-pic", false, - &error_abort); - object_property_set_bool(OBJECT(pci_dev), "has-pit", false, - &error_abort); - qdev_prop_set_uint32(DEVICE(pci_dev), "smb_io_base", 0xb100); - object_property_set_bool(OBJECT(pci_dev), "smm-enabled", - x86_machine_is_smm_enabled(x86ms), - &error_abort); - dev =3D DEVICE(pci_dev); - for (i =3D 0; i < ISA_NUM_IRQS; i++) { - qdev_connect_gpio_out_named(dev, "isa-irqs", i, x86ms->gsi[i]); - } - pci_realize_and_unref(pci_dev, pcms->pcibus, &error_fatal); - - if (xen_enabled()) { - pci_device_set_intx_routing_notifier( - pci_dev, piix_intx_routing_notifier_xen); - - /* - * Xen supports additional interrupt routes from the PCI devic= es to - * the IOAPIC: the four pins of each PCI device on the bus are= also - * connected to the IOAPIC directly. - * These additional routes can be discovered through ACPI. - */ - pci_bus_irqs(pcms->pcibus, xen_intx_set_irq, pci_dev, - XEN_IOAPIC_NUM_PIRQS); - } + gsi_state =3D pc_gsi_create(&x86ms->gsi, true); + + pci_dev =3D pci_new_multifunction(-1, pcms->south_bridge); + object_property_set_bool(OBJECT(pci_dev), "has-usb", + machine_usb(machine), &error_abort); + object_property_set_bool(OBJECT(pci_dev), "has-acpi", + x86_machine_is_acpi_enabled(x86ms), + &error_abort); + object_property_set_bool(OBJECT(pci_dev), "has-pic", false, + &error_abort); + object_property_set_bool(OBJECT(pci_dev), "has-pit", false, + &error_abort); + qdev_prop_set_uint32(DEVICE(pci_dev), "smb_io_base", 0xb100); + object_property_set_bool(OBJECT(pci_dev), "smm-enabled", + x86_machine_is_smm_enabled(x86ms), + &error_abort); + dev =3D DEVICE(pci_dev); + for (i =3D 0; i < ISA_NUM_IRQS; i++) { + qdev_connect_gpio_out_named(dev, "isa-irqs", i, x86ms->gsi[i]); + } + pci_realize_and_unref(pci_dev, pcms->pcibus, &error_fatal); =20 - isa_bus =3D ISA_BUS(qdev_get_child_bus(DEVICE(pci_dev), "isa.0")); - x86ms->rtc =3D ISA_DEVICE(object_resolve_path_component(OBJECT(pci= _dev), - "rtc")); - piix4_pm =3D object_resolve_path_component(OBJECT(pci_dev), "pm"); - dev =3D DEVICE(object_resolve_path_component(OBJECT(pci_dev), "ide= ")); - pci_ide_create_devs(PCI_DEVICE(dev)); - pcms->idebus[0] =3D qdev_get_child_bus(dev, "ide.0"); - pcms->idebus[1] =3D qdev_get_child_bus(dev, "ide.1"); - } else { - uint32_t irq; + if (xen_enabled()) { + pci_device_set_intx_routing_notifier( + pci_dev, piix_intx_routing_notifier_xen); =20 - isa_bus =3D isa_bus_new(NULL, system_memory, system_io, - &error_abort); - isa_bus_register_input_irqs(isa_bus, x86ms->gsi); + /* + * Xen supports additional interrupt routes from the PCI devices to + * the IOAPIC: the four pins of each PCI device on the bus are also + * connected to the IOAPIC directly. + * These additional routes can be discovered through ACPI. + */ + pci_bus_irqs(pcms->pcibus, xen_intx_set_irq, pci_dev, + XEN_IOAPIC_NUM_PIRQS); + } =20 - x86ms->rtc =3D isa_new(TYPE_MC146818_RTC); - qdev_prop_set_int32(DEVICE(x86ms->rtc), "base_year", 2000); - isa_realize_and_unref(x86ms->rtc, isa_bus, &error_fatal); - irq =3D object_property_get_uint(OBJECT(x86ms->rtc), "irq", - &error_fatal); - isa_connect_gpio_out(ISA_DEVICE(x86ms->rtc), 0, irq); + isa_bus =3D ISA_BUS(qdev_get_child_bus(DEVICE(pci_dev), "isa.0")); + x86ms->rtc =3D ISA_DEVICE(object_resolve_path_component(OBJECT(pci_dev= ), + "rtc")); + piix4_pm =3D object_resolve_path_component(OBJECT(pci_dev), "pm"); + dev =3D DEVICE(object_resolve_path_component(OBJECT(pci_dev), "ide")); + pci_ide_create_devs(PCI_DEVICE(dev)); + pcms->idebus[0] =3D qdev_get_child_bus(dev, "ide.0"); + pcms->idebus[1] =3D qdev_get_child_bus(dev, "ide.1"); =20 - i8257_dma_init(OBJECT(machine), isa_bus, 0); - pcms->hpet_enabled =3D false; - } =20 if (x86ms->pic =3D=3D ON_OFF_AUTO_ON || x86ms->pic =3D=3D ON_OFF_AUTO_= AUTO) { pc_i8259_create(isa_bus, gsi_state->i8259_irq); @@ -321,7 +301,7 @@ static void pc_init1(MachineState *machine, const char = *pci_type) x86_register_ferr_irq(x86ms->gsi[13]); } =20 - pc_vga_init(isa_bus, pcmc->pci_enabled ? pcms->pcibus : NULL); + pc_vga_init(isa_bus, pcms->pcibus); =20 /* init basic PC hardware */ pc_basic_device_init(pcms, isa_bus, x86ms->gsi, x86ms->rtc, @@ -329,28 +309,6 @@ static void pc_init1(MachineState *machine, const char= *pci_type) =20 pc_nic_init(pcmc, isa_bus, pcms->pcibus); =20 -#ifdef CONFIG_IDE_ISA - if (!pcmc->pci_enabled) { - DriveInfo *hd[MAX_IDE_BUS * MAX_IDE_DEVS]; - int i; - - ide_drive_get(hd, ARRAY_SIZE(hd)); - for (i =3D 0; i < MAX_IDE_BUS; i++) { - ISADevice *dev; - char busname[] =3D "ide.0"; - dev =3D isa_ide_init(isa_bus, ide_iobase[i], ide_iobase2[i], - ide_irq[i], - hd[MAX_IDE_DEVS * i], hd[MAX_IDE_DEVS * i += 1]); - /* - * The ide bus name is ide.0 for the first bus and ide.1 for t= he - * second one. - */ - busname[4] =3D '0' + i; - pcms->idebus[i] =3D qdev_get_child_bus(DEVICE(dev), busname); - } - } -#endif - if (piix4_pm) { smi_irq =3D qemu_allocate_irq(pc_acpi_smi_interrupt, first_cpu, 0); =20 --=20 2.43.0 From nobody Sat Nov 15 03:14:59 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1755864936; cv=pass; d=zohomail.com; s=zohoarc; b=FWPRaSbw674vnXPRGHP9EVDN7w4NVMFOzKfTB+4rl51X2tv+WYp36ir5akXRtlvnlzP2jFz26lI3ai5MjtygLyp/dlggYGGBa8S1RRlyH4WAELPxesar3/LCDd+Ud+3shLtdydiwwNYX3Yz89LXMMXTy+C2a3fDoVGtSuq3aGSM= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1755864936; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=w7GnCI21r7uxu2sKvURTGrcYYdCL4Fz43w2UDIWpOTQ=; b=VmwIQlRTBp5APGwix+JOpnS+1+JMU/+25kI6GY1FoxIZQUlYkz5lwiHbPNkhJ7xeWX0RJdYdIyEdXC96hAodxAVNPCxemM/CSvgk6QbQNWafbQtuaHYc768otMCDu33N1exSVXWe5bqTlraYDSh5HzN7iaH6G7sz815Euf/c8Mg= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1755864936785351.90667971143546; Fri, 22 Aug 2025 05:15:36 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1upQfk-0001u1-Ix; Fri, 22 Aug 2025 08:15:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upQfX-0001kQ-8v for qemu-devel@nongnu.org; Fri, 22 Aug 2025 08:14:56 -0400 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upQfQ-0000pO-2s for qemu-devel@nongnu.org; Fri, 22 Aug 2025 08:14:54 -0400 Received: from pps.filterd (m0127837.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57M7LJFn667851; Fri, 22 Aug 2025 05:14:43 -0700 Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12on2122.outbound.protection.outlook.com [40.107.244.122]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 48mye8qef9-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 22 Aug 2025 05:14:43 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by SJ0PR02MB7725.namprd02.prod.outlook.com (2603:10b6:a03:322::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.24; Fri, 22 Aug 2025 12:14:42 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%3]) with mapi id 15.20.9052.014; Fri, 22 Aug 2025 12:14:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=w7GnCI21r7uxu2sKvURTGrcYYdCL4Fz43w2UDIWpO TQ=; b=JI1fHgioK1c8TdUaOakCpS+EjbrofChUPuwJ842c1TbbwwGe/0X8XS52y M+jWMjwF/NnJq2WJok2D4Q9+4zj6tmMOIl41jmS4YhsNvsxhL83xhpqqTKyDHvVT NOWXOGz+pF8uPPCNy65haiR02IhFNRlHDuKXSSsdXsIv+QIIhpZIM1TRobC/1hB8 xXuTpQrR/veXK2b5qRyiR5zZcEfFPgi3skg5htlEVZV1lTGkzh7oCAeNbdcSCF3r Euu7rq0yiFR0IPs0UqfY5eG0rbe/IrJQxlqNoK8VCaZLqR91wj0ViFks7opg8ilv MpS7+bcPfUqh0+XcLUY3Qbe373zbg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=eJX1hnW0Rs8eJfOf0Ky1FFpnbCjRFdOwWSfSitH9BWnwpGJyYryB/F5763+GaJt9cAF9LIdKBC+UdjIGnPZoxL1G8SBJrgGncdBQp72hBH0F+itY1mXtecuMCy0oth4z5zKcCHbMEhvNyPKvxFAdWFHO+Z7/8nk6F/YderwntaR8Xaf6IC7Xpuyvy1/sFPgy72Ju88hynohyy1hdj5blrf4xVB1D4VjtP/397Ryx2pPGCsVMpw/OP3xPput0WmW0X/VXUsq8/EsCFOkqlXIHEGISVV4P4BdZZ/JMYwYC5J8Kk/Hy4xGkNzqc0gxLTVixCiyBALZw97DrumnmmWeYiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w7GnCI21r7uxu2sKvURTGrcYYdCL4Fz43w2UDIWpOTQ=; b=hQ/sQyPOyCT4R9ZF9OYFkVNpYwxWzPSooWwKyJz9OyoMncFyowJOooVd9K28OAP2brm9qZ0wq6gwFhXHo2nvBlRELI1Zk0PIQGdg9P+9yPEFV9SN5acWkPPJvX/NVS5e4+da9LqwLzBaYQS0vR0L+N+widA9B8CGiZLb+RDcfCricuE/QZdBm8q/a20wFuD9MyFMNqDOR78Oh0IBke0BH9T9XDk2vnEANhsVlk3h3tNoaeoe2swrF7S4eDNwc5P97pZmVt96ExQz9Q85mJCkHpDw0RDlgpIc6IgXBSGwpzMEaE8ZyWELZdp80araNpjqnbfetvlcmmZYKk3XRxw4Tw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w7GnCI21r7uxu2sKvURTGrcYYdCL4Fz43w2UDIWpOTQ=; b=qiavpgTFFVJrhVeV1nyvUzbosWbFT56pLrbR2/dxrR3Gyfs7U5YPiPGiM+jooJ0CBGUh7ndfGF/TI4Qk2bcnzu26NZfmCvTYm5wTu0XLLW/D4VIp79MWIRU6M+3lm2kXXwYA0Y0EVB5YocDaxVQyTDZmRT1Eim75Oji5aVW7hsbn2pEBuZdbw9BWbTJ/dQcHRVMH31zCFstYwsIhq7bgVrqvl8Ad6jZ2t2UavR9eSQQFUaqfzBe+5D9v7FNGykxvjz1Nbeo99ncsqV1prztA0yHM7OVSGojPTF9A5PY2dghE5v1W5RXoxcALuwopu2H2gcrzoI4PtZHuGfcX/zCRDA== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v6 16/19] hw/i386: move isapc machine to separate isapc.c file Date: Fri, 22 Aug 2025 13:12:02 +0100 Message-ID: <20250822121342.894223-17-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250822121342.894223-1-mark.caveayland@nutanix.com> References: <20250822121342.894223-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS4PR09CA0022.eurprd09.prod.outlook.com (2603:10a6:20b:5d4::14) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|SJ0PR02MB7725:EE_ X-MS-Office365-Filtering-Correlation-Id: bcff1270-0a46-42ae-5874-08dde1757958 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?svNGzYADkq8/93LqCt6wKjyAhd108CyN7PAp+ycr8/uAwt4rJszRfsbeAl6P?= =?us-ascii?Q?LrGdDUJMFYgkcGunqCnQFYB8TBDCLu9QfednZYc4FBxh83C0KbcaR9JNiYv4?= =?us-ascii?Q?QFEHaFQ81rjduyzoycJ7BUXyID/+10zhnisqRCC+FnrMpSwqwYKU1s9ESrVK?= =?us-ascii?Q?T+Yemyp649D62koCwM2MtQ77csUwIkV+IWZqQnnSFQaW0icPwwSSwUr/lzI/?= =?us-ascii?Q?XOgdf4m0dUX9aQpAzZ4v46DdGYBIs6wA3UoivJEvybCv5S/ejEoEdlIY6edb?= =?us-ascii?Q?RVAyiAy3SfoZiGdhYbad0T3h2ShXXVRQfxSQ1EUvgX8TM5utPe1eR3v9P0j9?= =?us-ascii?Q?NDeoWziXT7Gl5+D8WHktCnzXr97xy8yCSfQ+5U6ew+Z61LvxTbRY0qJfjfZF?= =?us-ascii?Q?gdJxVNsUq4Q4y1cwyXfZ6P9XPgW7DPQT/xK8Cv0h0fms3tsPz/I5JcYW5WET?= =?us-ascii?Q?Kq1qH3JsPvubqZboXbTMcAqM3XTMSH1nnG1sBWq55Zz4L/tLRNRFqNLeBYql?= =?us-ascii?Q?QH0EB6Z6zqW92TxOLncggJyMppfUbf8hNQ9o2sukn7OCiinWv9jAOUaj2P/K?= =?us-ascii?Q?92HCsLy6f/AcpNTGqUiHOeidZQ4y+HQ7/t+q9JbymDOq1d9goARIdlMBboS4?= =?us-ascii?Q?UuEavNUla3R12zC8uajBLkmkZ0uniu9c/Xmx/G2UKqRwTl8xShKgAqk/8jPS?= =?us-ascii?Q?8x6QXfD8rvyrK0q0v7XlKtGiCA0826/r9Yj9e2bu9QwsApJ9FXwAw1WEBmnH?= =?us-ascii?Q?XVkt+09nFqObLbLAZIqpyPDk5ZqUHp6bYw1nX+ZdI5eaap3s6JkGJUGlQQns?= =?us-ascii?Q?vmbTCNMpRLQattz3wN5IiOWsfo84tRVBrtzPDHnw5wDk3KTm94nXtXCN2Ygi?= =?us-ascii?Q?aMPwL4QMJQm3cYOQ98ZSOBrwYNpAKfdsKqv7J7t4N2GovxmrTNSSq8emU/fT?= =?us-ascii?Q?SMtIBMPhjRXJlJCRfHxQdqxlag5Y3td5jqaVmHV8DiOHDZ8yKMwdrj6GWVMl?= =?us-ascii?Q?R3k2SADqff7NV/UsMnFXFY8PRBgxNn9JQxhBgaqq+PIHNcvPXLssaCkc1V/x?= =?us-ascii?Q?UvZaAUUMF1lt6pZ65Ann5WMvL+xkhRL3241/wuHAH2dJX4K0Ig1ByIr8kYK5?= =?us-ascii?Q?ZzLp9PzudEtMt1OO/INTO2puvP+RkiHdbTzy+mnKvcp1z5stgV3UVrWitcuM?= =?us-ascii?Q?SLOaW//vvptqljippw8ejTyCK8+qfvNRcxAUCi7mlWBjbdG7cJ9ANi0D+d7y?= =?us-ascii?Q?4NnWxpqZIdAM1u8EnTzUP+RsatraFiWneZa/Tr2obOLKJrP2A6cqQqyFwPL1?= =?us-ascii?Q?8B5qy+/iN/78Ijx8/nS8i5wDhtuSFN49qnOKf1mnMDHWzFDwgkxl9V/QZgix?= =?us-ascii?Q?PdcXRbPJTbc4yDt9WWk6rjWQPw+VfV9PRknaYVr90VDejv1VRcTjm8BIUMsZ?= =?us-ascii?Q?cGipFDRR188=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?c5nYZ7SmL09Low3CI5mIyiLHxzU+FNwzX26rosZDnfK1Uv0EuP1QEkdRhU8K?= =?us-ascii?Q?cArd5K7Y6NEpGWe+OefeTus8G1Cz956hUPny1r3vFVYz1C3oi60xnQ3R+xnc?= =?us-ascii?Q?y1SipnLF3dPpPqlLLl73OeWP+mo924PJWsG4R3cHrNwWyj6WEwTVahFYT8ip?= =?us-ascii?Q?d7Hpk45stljWoJwNVuAWBqj4dLlSc/gasc0mpFnGYpdF6QJCRWsgArYTlwFn?= =?us-ascii?Q?nyi2cXqDz5P7EjQAgvHkqG+Li0c40oZm5BJtahsyA1oTVsVa2D+oTm1YIrjL?= =?us-ascii?Q?Q45DJ/6+n48oJHWnkNA2LQtEChQ0nRwjp876/0dfTtBkGI6C8ay3s4VpPMzJ?= =?us-ascii?Q?asonImC7q9AnQkl+rfZMyj9cK8bXowuBGqYdK6Rq0yT2EEuhe1epwJkwWvGM?= =?us-ascii?Q?f/n3qOKSfvdkNPVxlx9L66QH6oNQkt7mfRPn50LfYRuL2y2/UXiJX4LI3FOi?= =?us-ascii?Q?A3gWHzBzPIR9Zspa/PTmj3TutvQB0FrIFBnoogcQ46uqMlFAi+hb6wV6KXI8?= =?us-ascii?Q?2gNAWCn2fTTt6N3QlW0thfIPlYjQ7E0xI2fcfuiM4oCLpHBfmXaKaTvl2n1+?= =?us-ascii?Q?TRHfGMZkjs1RkwXkOb+LOhVP1mAaSSM0llLpgZhthQCH+V5tv6whyGFwmGuS?= =?us-ascii?Q?3jChTV6NeQkSzAO2qO87KY+PvtPlIsquwoaqugajptY9v9SXjMbhJvBU1p4K?= =?us-ascii?Q?ToVTYnOAn0k6Vkjk71oF1L5eFGT1wV7k4Lv6vRJkKMJHnaJ5amImNB+juXcF?= =?us-ascii?Q?YNoU9aMYs6ZiCtJYjWfj0uJ4ETgUP5+KU6rW6CTF9ftl6ZPEJA2axwL8X83V?= =?us-ascii?Q?PkXae0KoWCVtRVW9gf1qU/JarbZgYqv1TujGaAEDaxo6XzUicwb9wAT03G/S?= =?us-ascii?Q?Rt2uK7V8FGAMvpT5MH3ukcMv6R6uZJ1V8VvQOQyM4TAQXzLwp8ya1WLenm2s?= =?us-ascii?Q?2fFgXA4cyltbRjQ5isLzOOZr4Tl3Eq/BbwWOLoVVAfRfA01RYuJoZbuPFTKZ?= =?us-ascii?Q?3Aj+TXvkwaO+LjV5QnU4Ec9Qcqh6MU/YUMErYCnVMw3qIdi1eESkfVImOgIZ?= =?us-ascii?Q?Tn7rYoVfekvO8DOI9YWnWcnuoMn1dPdTZ6Cai80s1dk06CTeG+7LEmmJ6MFm?= =?us-ascii?Q?mMDVgiztjmJsxmTib84yRyTcvbzdSH6t+k+5LjS3QdttE/ZBLNYdv1eO23GY?= =?us-ascii?Q?F3/C4+j6frtXkBeiOanYNMmwey2hveeYJCutS84Ubw7xYfm9oNQSTY9RgCyX?= =?us-ascii?Q?1Piu1A8fsgNBKGszO3lMWT2eZbvFoLuLjECNYGaYW3HtP5mUHGBilgKiVZSm?= =?us-ascii?Q?9KoUt/SQboebX54nKo5TZjINNBxHJIJLy/ZiAuK4pxqgpWpL32B5krsoV9dX?= =?us-ascii?Q?6eNxmZodfRDHXyiel9vV2pwtpmxrgbYh44a4IASVIQHVpfXYyHCUxeSJr4FL?= =?us-ascii?Q?yOpY9ruHqoGs3Ktb+ysRYg9LprWWWuorm51TzxU2CZwBdElQz5BpostiCw6J?= =?us-ascii?Q?5Va4ubT1aJWPvd7gvG1zzHvIgB2n/sM7lKCqi6XKb211t8pSj/bOnFW05/ko?= =?us-ascii?Q?IltU69IlfxEfPSt3AaIf+0SHu6YjuAoiTwWZJXd8JHF98zq90d5F7e5XhPRC?= =?us-ascii?Q?EA=3D=3D?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: bcff1270-0a46-42ae-5874-08dde1757958 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2025 12:14:42.0506 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6dkwdWFvGvClngPeRXKNmSnse5VoXMFd+AgUQvtEkVfSD76+KOBE1Aylf71xPgCrNpEzNINJZRzYyzYjinHUu41mGFM1d3SidkSejVYXecQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR02MB7725 X-Authority-Analysis: v=2.4 cv=TdPPdRQh c=1 sm=1 tr=0 ts=68a85f33 cx=c_pps a=ysIXdlsiLQEa0wkRuds0Og==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=2OwXVqhp2XgA:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=pGLkceISAAAA:8 a=Pbl5c31VFoorxvNN0s8A:9 a=cPQSjfK2_nFv0Q5t_7PE:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODIyMDExNCBTYWx0ZWRfXyE20+6PsomS6 msyocGKIoULgb42XBEDsAyksqIucyB+/zR1il/nMlzLw4nmKUQOfd2BRrreiDSpy6c2FwOREL8q RDP0A6oQ9+pXhXn1Htxi53oXctP8JRv1jyWxCIH+ju0uUuOwfHKlW9RmhgWD5hzomHA0pvM6tW7 BCLp7QGyPQ+yxZiKMq51SDa0COiquTttquvdB7aiWpudWb79ZS2zt3HxFKa5w0De8GLYmqLNINy Mqk26+aTGEsFcdy9beEcvhhrr53Lhn3q3/ptb0oSnUp7LSLwxo3U+xIbp8zCKgX6szNHACI9ZM5 LcAeRjEbErCBapblQlEuFYP8pi3DtgGT0dtPS4YWfzonmJFrXCBsESE4tTfr3Qqvu4S6n+uH0fy RBQ9QSmfHtFMXQtu30TcT+LmS5mHVQ== X-Proofpoint-GUID: y7TAMWipR2CO936cVuhuqBItf2J_x0if X-Proofpoint-ORIG-GUID: y7TAMWipR2CO936cVuhuqBItf2J_x0if X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-22_04,2025-08-20_03,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.151.68; envelope-from=mark.caveayland@nutanix.com; helo=mx0a-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1755864938662116600 Content-Type: text/plain; charset="utf-8" Now that pc_init_isa() is independent of any PCI initialisation, move it in= to a separate isapc.c file. This enables us to finally fix the dependency of ISA= PC on I440FX in hw/i386/Kconfig. Note that as part of the move to a separate file we can see that the licenc= e text is a verbatim copy of the MIT licence. The text originates from commit 1df9= 12cf9e ("VL license of the day is MIT/BSD") so we can be sure that this was the or= iginal intent. As a consequence we can update the file header to use a SPDX tag as= per the current project contribution guidelines. Signed-off-by: Mark Cave-Ayland Reviewed-by: Bernhard Beschow Reviewed-by: Xiaoyao Li --- hw/i386/Kconfig | 3 - hw/i386/isapc.c | 171 ++++++++++++++++++++++++++++++++++++++++++++ hw/i386/meson.build | 1 + hw/i386/pc_piix.c | 149 -------------------------------------- 4 files changed, 172 insertions(+), 152 deletions(-) create mode 100644 hw/i386/isapc.c diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig index 3a0e2b8ebb..6a0ab54bea 100644 --- a/hw/i386/Kconfig +++ b/hw/i386/Kconfig @@ -96,9 +96,6 @@ config ISAPC select ISA_BUS select PC select IDE_ISA - # FIXME: it is in the same file as i440fx, and does not compile - # if separated - depends on I440FX =20 config Q35 bool diff --git a/hw/i386/isapc.c b/hw/i386/isapc.c new file mode 100644 index 0000000000..62acdada3e --- /dev/null +++ b/hw/i386/isapc.c @@ -0,0 +1,171 @@ +/* + * QEMU PC System Emulator + * + * Copyright (c) 2003-2004 Fabrice Bellard + * + * SPDX-License-Identifier: MIT + */ + +#include "qemu/osdep.h" + +#include "qemu/units.h" +#include "qemu/error-report.h" +#include "hw/char/parallel-isa.h" +#include "hw/dma/i8257.h" +#include "hw/i386/pc.h" +#include "hw/ide/isa.h" +#include "hw/ide/ide-bus.h" +#include "system/kvm.h" +#include "hw/i386/kvm/clock.h" +#include "hw/xen/xen-x86.h" +#include "system/xen.h" +#include "hw/rtc/mc146818rtc.h" +#include "target/i386/cpu.h" + +static const int ide_iobase[MAX_IDE_BUS] =3D { 0x1f0, 0x170 }; +static const int ide_iobase2[MAX_IDE_BUS] =3D { 0x3f6, 0x376 }; +static const int ide_irq[MAX_IDE_BUS] =3D { 14, 15 }; + + +static void pc_init_isa(MachineState *machine) +{ + PCMachineState *pcms =3D PC_MACHINE(machine); + PCMachineClass *pcmc =3D PC_MACHINE_GET_CLASS(pcms); + X86MachineState *x86ms =3D X86_MACHINE(machine); + MemoryRegion *system_memory =3D get_system_memory(); + MemoryRegion *system_io =3D get_system_io(); + ISABus *isa_bus; + GSIState *gsi_state; + MemoryRegion *ram_memory; + MemoryRegion *rom_memory =3D system_memory; + DriveInfo *hd[MAX_IDE_BUS * MAX_IDE_DEVS]; + uint32_t irq; + int i; + + /* + * There is no RAM split for the isapc machine + */ + if (xen_enabled()) { + xen_hvm_init_pc(pcms, &ram_memory); + } else { + ram_memory =3D machine->ram; + + pcms->max_ram_below_4g =3D 4 * GiB; + x86ms->above_4g_mem_size =3D 0; + x86ms->below_4g_mem_size =3D machine->ram_size; + } + + /* + * There is a small chance that someone unintentionally passes "-cpu m= ax" + * for the isapc machine, which will provide a much more modern 32-bit + * CPU than would be expected for an ISA-era PC. If the "max" cpu type= has + * been specified, choose the "best" 32-bit cpu possible which we cons= ider + * be the pentium3 (deliberately choosing an Intel CPU given that the + * default 486 CPU for the isapc machine is also an Intel CPU). + */ + if (!strcmp(machine->cpu_type, X86_CPU_TYPE_NAME("max"))) { + machine->cpu_type =3D X86_CPU_TYPE_NAME("pentium3"); + warn_report("-cpu max is invalid for isapc machine, using pentium3= "); + } + + x86_cpus_init(x86ms, pcmc->default_cpu_version); + + if (kvm_enabled()) { + kvmclock_create(pcmc->kvmclock_create_always); + } + + /* allocate ram and load rom/bios */ + if (!xen_enabled()) { + pc_memory_init(pcms, system_memory, rom_memory, 0); + } else { + assert(machine->ram_size =3D=3D x86ms->below_4g_mem_size + + x86ms->above_4g_mem_size); + + if (machine->kernel_filename !=3D NULL) { + /* For xen HVM direct kernel boot, load linux here */ + xen_load_linux(pcms); + } + } + + gsi_state =3D pc_gsi_create(&x86ms->gsi, false); + + isa_bus =3D isa_bus_new(NULL, system_memory, system_io, + &error_abort); + isa_bus_register_input_irqs(isa_bus, x86ms->gsi); + + x86ms->rtc =3D isa_new(TYPE_MC146818_RTC); + qdev_prop_set_int32(DEVICE(x86ms->rtc), "base_year", 2000); + isa_realize_and_unref(x86ms->rtc, isa_bus, &error_fatal); + irq =3D object_property_get_uint(OBJECT(x86ms->rtc), "irq", + &error_fatal); + isa_connect_gpio_out(ISA_DEVICE(x86ms->rtc), 0, irq); + + i8257_dma_init(OBJECT(machine), isa_bus, 0); + pcms->hpet_enabled =3D false; + + if (x86ms->pic =3D=3D ON_OFF_AUTO_ON || x86ms->pic =3D=3D ON_OFF_AUTO_= AUTO) { + pc_i8259_create(isa_bus, gsi_state->i8259_irq); + } + + if (tcg_enabled()) { + x86_register_ferr_irq(x86ms->gsi[13]); + } + + pc_vga_init(isa_bus, NULL); + + /* init basic PC hardware */ + pc_basic_device_init(pcms, isa_bus, x86ms->gsi, x86ms->rtc, + !MACHINE_CLASS(pcmc)->no_floppy, 0x4); + + pc_nic_init(pcmc, isa_bus, NULL); + + ide_drive_get(hd, ARRAY_SIZE(hd)); + for (i =3D 0; i < MAX_IDE_BUS; i++) { + ISADevice *dev; + char busname[] =3D "ide.0"; + dev =3D isa_ide_init(isa_bus, ide_iobase[i], ide_iobase2[i], + ide_irq[i], + hd[MAX_IDE_DEVS * i], hd[MAX_IDE_DEVS * i + 1]); + /* + * The ide bus name is ide.0 for the first bus and ide.1 for the + * second one. + */ + busname[4] =3D '0' + i; + pcms->idebus[i] =3D qdev_get_child_bus(DEVICE(dev), busname); + } +} + +static void isapc_machine_options(MachineClass *m) +{ + static const char * const valid_cpu_types[] =3D { + X86_CPU_TYPE_NAME("486"), + X86_CPU_TYPE_NAME("athlon"), + X86_CPU_TYPE_NAME("kvm32"), + X86_CPU_TYPE_NAME("pentium"), + X86_CPU_TYPE_NAME("pentium2"), + X86_CPU_TYPE_NAME("pentium3"), + X86_CPU_TYPE_NAME("qemu32"), + X86_CPU_TYPE_NAME("max"), + NULL + }; + PCMachineClass *pcmc =3D PC_MACHINE_CLASS(m); + + m->desc =3D "ISA-only PC"; + m->max_cpus =3D 1; + m->option_rom_has_mr =3D true; + m->rom_file_has_mr =3D false; + pcmc->pci_enabled =3D false; + pcmc->has_acpi_build =3D false; + pcmc->smbios_defaults =3D false; + pcmc->gigabyte_align =3D false; + pcmc->smbios_legacy_mode =3D true; + pcmc->has_reserved_memory =3D false; + m->default_nic =3D "ne2k_isa"; + m->default_cpu_type =3D X86_CPU_TYPE_NAME("486"); + m->valid_cpu_types =3D valid_cpu_types; + m->no_floppy =3D !module_object_class_by_name(TYPE_ISA_FDC); + m->no_parallel =3D !module_object_class_by_name(TYPE_ISA_PARALLEL); +} + +DEFINE_PC_MACHINE(isapc, "isapc", pc_init_isa, + isapc_machine_options); diff --git a/hw/i386/meson.build b/hw/i386/meson.build index 7896f348cf..436b3ce52d 100644 --- a/hw/i386/meson.build +++ b/hw/i386/meson.build @@ -14,6 +14,7 @@ i386_ss.add(when: 'CONFIG_X86_IOMMU', if_true: files('x86= -iommu.c'), i386_ss.add(when: 'CONFIG_AMD_IOMMU', if_true: files('amd_iommu.c'), if_false: files('amd_iommu-stub.c')) i386_ss.add(when: 'CONFIG_I440FX', if_true: files('pc_piix.c')) +i386_ss.add(when: 'CONFIG_ISAPC', if_true: files('isapc.c')) i386_ss.add(when: 'CONFIG_MICROVM', if_true: files('x86-common.c', 'microv= m.c', 'acpi-microvm.c', 'microvm-dt.c')) i386_ss.add(when: 'CONFIG_NITRO_ENCLAVE', if_true: files('nitro_enclave.c'= )) i386_ss.add(when: 'CONFIG_Q35', if_true: files('pc_q35.c')) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index a776998504..05713662e4 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -71,12 +71,6 @@ =20 #define XEN_IOAPIC_NUM_PIRQS 128ULL =20 -#ifdef CONFIG_ISAPC -static const int ide_iobase[MAX_IDE_BUS] =3D { 0x1f0, 0x170 }; -static const int ide_iobase2[MAX_IDE_BUS] =3D { 0x3f6, 0x376 }; -static const int ide_irq[MAX_IDE_BUS] =3D { 14, 15 }; -#endif - static GlobalProperty pc_piix_compat_defaults[] =3D { { TYPE_RAMFB_DEVICE, "use-legacy-x86-rom", "true" }, { TYPE_VFIO_PCI_NOHOTPLUG, "use-legacy-x86-rom", "true" }, @@ -390,112 +384,6 @@ static void pc_set_south_bridge(Object *obj, int valu= e, Error **errp) pcms->south_bridge =3D PCSouthBridgeOption_lookup.array[value]; } =20 -#ifdef CONFIG_ISAPC -static void pc_init_isa(MachineState *machine) -{ - PCMachineState *pcms =3D PC_MACHINE(machine); - PCMachineClass *pcmc =3D PC_MACHINE_GET_CLASS(pcms); - X86MachineState *x86ms =3D X86_MACHINE(machine); - MemoryRegion *system_memory =3D get_system_memory(); - MemoryRegion *system_io =3D get_system_io(); - ISABus *isa_bus; - GSIState *gsi_state; - MemoryRegion *ram_memory; - MemoryRegion *rom_memory =3D system_memory; - DriveInfo *hd[MAX_IDE_BUS * MAX_IDE_DEVS]; - int i; - - /* - * There is no RAM split for the isapc machine - */ - if (xen_enabled()) { - xen_hvm_init_pc(pcms, &ram_memory); - } else { - ram_memory =3D machine->ram; - - pcms->max_ram_below_4g =3D 4 * GiB; - x86ms->above_4g_mem_size =3D 0; - x86ms->below_4g_mem_size =3D machine->ram_size; - } - - /* - * There is a small chance that someone unintentionally passes "-cpu m= ax" - * for the isapc machine, which will provide a much more modern 32-bit - * CPU than would be expected for an ISA-era PC. If the "max" cpu type= has - * been specified, choose the "best" 32-bit cpu possible which we cons= ider - * be the pentium3 (deliberately choosing an Intel CPU given that the - * default 486 CPU for the isapc machine is also an Intel CPU). - */ - if (!strcmp(machine->cpu_type, X86_CPU_TYPE_NAME("max"))) { - machine->cpu_type =3D X86_CPU_TYPE_NAME("pentium3"); - warn_report("-cpu max is invalid for isapc machine, using pentium3= "); - } - - x86_cpus_init(x86ms, pcmc->default_cpu_version); - - if (kvm_enabled()) { - kvmclock_create(pcmc->kvmclock_create_always); - } - - /* allocate ram and load rom/bios */ - if (!xen_enabled()) { - pc_memory_init(pcms, system_memory, rom_memory, 0); - } else { - assert(machine->ram_size =3D=3D x86ms->below_4g_mem_size + - x86ms->above_4g_mem_size); - - if (machine->kernel_filename !=3D NULL) { - /* For xen HVM direct kernel boot, load linux here */ - xen_load_linux(pcms); - } - } - - gsi_state =3D pc_gsi_create(&x86ms->gsi, false); - - isa_bus =3D isa_bus_new(NULL, system_memory, system_io, - &error_abort); - isa_bus_register_input_irqs(isa_bus, x86ms->gsi); - - x86ms->rtc =3D isa_new(TYPE_MC146818_RTC); - qdev_prop_set_int32(DEVICE(x86ms->rtc), "base_year", 2000); - isa_realize_and_unref(x86ms->rtc, isa_bus, &error_fatal); - - i8257_dma_init(OBJECT(machine), isa_bus, 0); - pcms->hpet_enabled =3D false; - - if (x86ms->pic =3D=3D ON_OFF_AUTO_ON || x86ms->pic =3D=3D ON_OFF_AUTO_= AUTO) { - pc_i8259_create(isa_bus, gsi_state->i8259_irq); - } - - if (tcg_enabled()) { - x86_register_ferr_irq(x86ms->gsi[13]); - } - - pc_vga_init(isa_bus, NULL); - - /* init basic PC hardware */ - pc_basic_device_init(pcms, isa_bus, x86ms->gsi, x86ms->rtc, - !MACHINE_CLASS(pcmc)->no_floppy, 0x4); - - pc_nic_init(pcmc, isa_bus, NULL); - - ide_drive_get(hd, ARRAY_SIZE(hd)); - for (i =3D 0; i < MAX_IDE_BUS; i++) { - ISADevice *dev; - char busname[] =3D "ide.0"; - dev =3D isa_ide_init(isa_bus, ide_iobase[i], ide_iobase2[i], - ide_irq[i], - hd[MAX_IDE_DEVS * i], hd[MAX_IDE_DEVS * i + 1]= ); - /* - * The ide bus name is ide.0 for the first bus and ide.1 for the - * second one. - */ - busname[4] =3D '0' + i; - pcms->idebus[i] =3D qdev_get_child_bus(DEVICE(dev), busname); - } -} -#endif - #ifdef CONFIG_XEN static void pc_xen_hvm_init(MachineState *machine) { @@ -854,43 +742,6 @@ static void pc_i440fx_machine_2_6_options(MachineClass= *m) =20 DEFINE_I440FX_MACHINE(2, 6); =20 -#ifdef CONFIG_ISAPC -static void isapc_machine_options(MachineClass *m) -{ - static const char * const valid_cpu_types[] =3D { - X86_CPU_TYPE_NAME("486"), - X86_CPU_TYPE_NAME("athlon"), - X86_CPU_TYPE_NAME("kvm32"), - X86_CPU_TYPE_NAME("pentium"), - X86_CPU_TYPE_NAME("pentium2"), - X86_CPU_TYPE_NAME("pentium3"), - X86_CPU_TYPE_NAME("qemu32"), - X86_CPU_TYPE_NAME("max"), - NULL - }; - PCMachineClass *pcmc =3D PC_MACHINE_CLASS(m); - - m->desc =3D "ISA-only PC"; - m->max_cpus =3D 1; - m->option_rom_has_mr =3D true; - m->rom_file_has_mr =3D false; - pcmc->pci_enabled =3D false; - pcmc->has_acpi_build =3D false; - pcmc->smbios_defaults =3D false; - pcmc->gigabyte_align =3D false; - pcmc->smbios_legacy_mode =3D true; - pcmc->has_reserved_memory =3D false; - m->default_nic =3D "ne2k_isa"; - m->default_cpu_type =3D X86_CPU_TYPE_NAME("486"); - m->valid_cpu_types =3D valid_cpu_types; - m->no_floppy =3D !module_object_class_by_name(TYPE_ISA_FDC); - m->no_parallel =3D !module_object_class_by_name(TYPE_ISA_PARALLEL); -} - -DEFINE_PC_MACHINE(isapc, "isapc", pc_init_isa, - isapc_machine_options); -#endif - #ifdef CONFIG_XEN static void xenfv_machine_4_2_options(MachineClass *m) { --=20 2.43.0 From nobody Sat Nov 15 03:14:59 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1755865774; cv=pass; d=zohomail.com; s=zohoarc; b=P5taRPIivRpmFmI63r7FB5MeqF/R1aOhWx5QVdN3HZjiKhwTZAYQKZlcpi+VHfZoX9sDQ2pNJcpv4MtDljAJ2HuvNuGbAtuXP6HgU3b79Z4yyqkishRqtduecLvjHFBKiv4E7s3dH/cPBtbRe03yZjz2p6dYstOpm1gjqZpCN1U= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1755865774; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=PI/FQYmenBP1zsQQ9NjjUqx0YjtIT1nxqjGbtKBVBns=; b=PaAab3dJBAjPehrAHnU18hnvlFyrN7N379dwjwt3MBsZauppjmMEmzTBwtC+tq5E7haN9jj9BpkaN65X/TyRAlUF9aNW9OGVIG0/KpZ3HA8nl82WYh+57XV5hdeOSzfdV4MgR1Ax7ZjHSXU1GTkFCWnFtXHk0sWi/tKpnm37PaA= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 175586577449619.829299759987066; Fri, 22 Aug 2025 05:29:34 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1upQft-0002DW-K8; Fri, 22 Aug 2025 08:15:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upQfk-0001v5-KL for qemu-devel@nongnu.org; Fri, 22 Aug 2025 08:15:10 -0400 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upQfb-0000qX-CW for qemu-devel@nongnu.org; Fri, 22 Aug 2025 08:15:04 -0400 Received: from pps.filterd (m0127838.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57MA7uhJ2824419; Fri, 22 Aug 2025 05:14:55 -0700 Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11on2095.outbound.protection.outlook.com [40.107.220.95]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 48pphe080n-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 22 Aug 2025 05:14:55 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by SJ0PR02MB7725.namprd02.prod.outlook.com (2603:10b6:a03:322::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.24; Fri, 22 Aug 2025 12:14:45 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%3]) with mapi id 15.20.9052.014; Fri, 22 Aug 2025 12:14:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=PI/FQYmenBP1zsQQ9NjjUqx0YjtIT1nxqjGbtKBVB ns=; b=kqltZ7rWiDSRztsOGyG8BfAeN/SaeJJx7z7o5K4QXuFNcDrWVVFUzkY68 CPlBKNl6IgYeiL3IILiFX2GWdztd8FasqZRr6Z3hguwpDkgnos9UEtAX3wau//SN Whw9sxuye09wgfTx0K9AANRzhWhYt/ksUxVaNYR7Ndtxh/8nhN23VQ+vK26T6+ZR S6WH8ghgeyVSgXXCjcBY9z5+wf4Xoo+vwrYJwveIhqc5WyO7efcNeRlAx4mjlA38 9T73y+OFQzGrlXzRXMPOWZa01Iayh/VcGqdrCwA1C6cQig+hGT6rMuJNeqndd1p+ we7Rtys1GcgpwSDTjfKalZaDE5EfQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pVEYMYu/D+ncY0Pb+vamwgtLnZX7cvTKF3fWEaCYc+2OfrwAIFGAZ3QQesobikCZ7ynVl1Oa96LGb6+ifiK7wuQnQ/RGveiSmT3Ywyl5oitq+43GeBAPwqqfcc1nlY+00ccCtrr9fJ/mK5PinSbba/txj77ujx5vdp4L1FqDjjEL9b7ehNDLnmivZuHCbXF3YI/7Pv+AQwLRFIH4/5/dSvNGejoHicDt6Qde4SFaiVfjROta2pNoTYjADThqiZubIJFbhGTfjszVsyYIRCQr62doq3mFNigpz52fNzSGIGMopO1LiZ9efeZxav2ia4UcoOEySsRGZlYZILZWad58bA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PI/FQYmenBP1zsQQ9NjjUqx0YjtIT1nxqjGbtKBVBns=; b=wNA571R4fVclbuHmqJXH0OQNkUPeYpDFsckaU/5y3ZqJarFSpqm4yf1bNaaYABDK+6YR5yE4OuDfjNFeJRHkPG8/91rBW1t4dsYtbarcj8C49zb99rBI87Ox4i1tU6RTOYgc5e7WssY+6Co6EhMOKAksYYi/sEUPAdBPaKcejXBHQb8Mm9LaaDlM7b++lMEvciAiSU5jFF8/r1TYtxYHcWjpqc+j0eazx8NQ6/dCh4KmXkj+autSd3/CNMs8+huCNsmWHjWT51SdpckBSy7eHk/HAD7b+/kyM+4UabDpW55EKZKKnFcOHH1X0h8LQrdZxiMkZ6lVmua7ExVU8lBQRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PI/FQYmenBP1zsQQ9NjjUqx0YjtIT1nxqjGbtKBVBns=; b=BHhQ4nXFhLY5RtxPpbvc5xueQh76+JAYFJv3xduif7vhIJme5qgxrF3ksGTFyw1/EKSg/AxqXZIFjvfhpNRqmw6PvEVNIJpmGCIALNyW4QD3xl6kiW72UQ3D2Zg+a8JsURnqRGnElFgHVONfToAJks7Kovbq4JmrxWZSox0c6LCxE0x73EKpNAoMbV0XE2mCVdSgoG8ikhlC7tRsmasMxEuk7MOscYdtqVPR3ksoxiOtcl7loe0Zn2ngRdTf7+WR9yK9ZJ771xFAKO8S27s8NAaz2qBK6tOtLW9R7UosBWvCCbxa5vMTgCvNI2y5YR3zFVu5xThWWoGaPgYBuXoU0A== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v6 17/19] hw/i386/pc_piix.c: remove unused headers after isapc machine split Date: Fri, 22 Aug 2025 13:12:03 +0100 Message-ID: <20250822121342.894223-18-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250822121342.894223-1-mark.caveayland@nutanix.com> References: <20250822121342.894223-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM0PR01CA0175.eurprd01.prod.exchangelabs.com (2603:10a6:208:aa::44) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|SJ0PR02MB7725:EE_ X-MS-Office365-Filtering-Correlation-Id: 09f1623c-f423-45a1-24c5-08dde1757b59 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Y3JHckNlZUQ1WHFnazlpdjZvRE44eHkxZmQ0THE1TXJlTHZhQUYvcWxRZ2Zi?= =?utf-8?B?RU5ZclQvYVR2aXBQMmM1eVZzYTVoNWR1ZzZ5eXJFWTdPQm05S1VzVzFBemFm?= =?utf-8?B?YTl4eWxibkhBVlhGSklvcHhaSHdXQnVhQlplV2JnMmhtUS9kdFA0bC94Q001?= =?utf-8?B?RG05ekIyUHNoVGVqdlZMVmh6aXhYODVDV2JxSFJKWWdaRFVHWHQrQkxuanRZ?= =?utf-8?B?WHlnQjZjMW5iT1ZVRGdWRDhjS1VDc3llWCtTMUx5ZmdqcFJZQ2o1ZDRCOTFv?= =?utf-8?B?MzF6citFQkNYRlI5L3doSWVnTWpWZ3hpZzVtcHBGV1hkekh2MzI3dHFIY0Rj?= =?utf-8?B?TjJ2cG9ma1l3U3dZOC9lb3kvRG5mMDl1eVB0emZabUVSMllwWDc1NGZsODNV?= =?utf-8?B?djg5QVNBR1h5NmxVd3AzQ25TUlJVUXg5VmNjRTVqU2lrVWs2SFhQY3ptQ0R0?= =?utf-8?B?REtIUTBPRXB1eDFlc0dQa2V4TGxiTUZMdzJKMHpsZTFTVWVHM1hWS1lXYVRU?= =?utf-8?B?NlZ1RUU1TGpDOVR2UFNBRlFlcHRTR1h0ZHlPOFFoaVJoc2YrMG91OFI2Qi91?= =?utf-8?B?R1Y0MnhhSTNFMGNROTRQOFVPN0JVMWlIRDR6clpyRUxtZzkwd3lYTWNoQnNy?= =?utf-8?B?d0lrS3BHczFhMGZJaGlZeGQ3cHlCbGkzcHhHVnpHd3RlaHdTS0lWRWw0Tkda?= =?utf-8?B?MGdrTFJ4UlJZTURyWGpoUVUzZVF0R0kyTFBtTjZJZEpVeTZock9zSjFZNW5n?= =?utf-8?B?UEUvV2ZQMUZKN3pWRkJvT2xWMjUrT3BLQWdvYng5akpPMTJMTHlITmpUNUQx?= =?utf-8?B?d1VUbzc1TU40T2RmNFJhcGtBNVZqa01HRlVPL1B1TWlRRlhmSXlrTUYxVmpj?= =?utf-8?B?MmxCOWVxc3M1UGtlUlRGdWs2Zjg4azZSemd3SVMwR0JaU3RzVFZqeTRERkFG?= =?utf-8?B?OUF1U0srSVdjSDBPa3JTWjNFa2hRL3lkMUF4cXdKR3NVYzNlYTh4Nkp6cklu?= =?utf-8?B?L255WTdXc3Y1OWxLTUVPQzVCcitGMzNxODZ2cXlYYm1ZaEtweGRlNEdrdnZh?= =?utf-8?B?aE85dW53a1I0Tm9IOXV3WUNaV0dRamhqTkllbEt0VGQ4aHZyaVJzNWhyZWdv?= =?utf-8?B?Mk1seTZlUkw3SjdLVlpodFZTUDYxMTBoSWJqcEQyWXBEOE5LRU14cGZkdHRC?= =?utf-8?B?Wk5lQkU3SmRlcmVSd29Sem9EOVJJTTh6Z0w0dFZDRHJYbEw5KzRXSUd0Z2VI?= =?utf-8?B?Y245TzRENGZMeDV5cC9zUE9td0N6VHlKQUw3aFZMNldrWXlEVHNhT2NkNHJ0?= =?utf-8?B?VmY0dEFRdUcveGpPcjdrZnJmV0tpYkxBc201Y2tXNlNSdURtS3RBOFFhR09I?= =?utf-8?B?TXFPMzRKL292OVk4ZkFkR0dBd09ieHRmZmJrS00zYVF3NmlrM3YwMnIyVEQ5?= =?utf-8?B?N04xSkhtbDJXdnBVN1I1KzNrbVhFemhqaW85NC83MmpiUm11bmt3L2JDcXQy?= =?utf-8?B?cDUvUUt6QmUxOEZlZEYrald2dkwrWWlZOHMrRlo5M2dJTUJLT2JzTW9JcVl1?= =?utf-8?B?TFRQNFJqM2d0TU82dU1sVGhuY3BmeTE1VDhVYlpsMnNCN2ZuUXNHeUNyR3Iw?= =?utf-8?B?QmxNeW5CYjFLVlBNQzlYaHJjcEVXMVN6RTdJcmJJWmYvOVN4U0lyaytmRHlQ?= =?utf-8?B?enBsNVB6VC9GNlppcmhUWGR6VGFaTjJHSk82amw5UXc5akh4V1V4My9PRXRp?= =?utf-8?B?Ri9lWkc0aWtudEdHamFrNWdSQjJPc0hGME9kaHVaRE9qRFFFbE9KdkdBenlv?= =?utf-8?B?M3BrckFJbVhnYTcyb2p6MUFUZXNHV1cwTHZLMitMOEgvSDNnUHc5WkpFdy82?= =?utf-8?B?bEhLTVl0Q0Y5d0R3bkFGWSswcFg2ZjBHQURySWo1SlZPUGc9PQ==?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NGdSZ0JBdGdIUnF6d3hQc0k3ZnVGSzRxQ2s0Vi8rUTFSNmNMZFBoVW5UWG4w?= =?utf-8?B?NGdGUVc2UTZPVHNZcU04VkpWKzhSeENaVTZqa1ZyOVZSaFFmN3dOQzZDWXpu?= =?utf-8?B?aWg1N2lBSTFmNTdyb0lPQWZZZk5qMGFkZzFZV1RGTDJ5MWZSYjgvYm53cWJE?= =?utf-8?B?aHViTytCanVIOWNDL2tra2c1ZXowd0Q2MlpCVytRMWdKam96aEFHOHB1ZFBW?= =?utf-8?B?akp1amVJeVRWSnRkWGJkZEdHT0ExN3ZpSWRwTVA5SWROdnpLS2pmVWxXcDMw?= =?utf-8?B?eFpKSFE0dWJzVTlGd0ptZWRoeTVENFZDSWZyMUlWVDY3NFhSK2h3RzNXUlEr?= =?utf-8?B?SERlRDQwSEs0MEJUNnFNSS9JMFMzenpyYzhyMktCSW5MdGR0Q0NMQ0JjUXRj?= =?utf-8?B?TGhlQnhja3I4L0lwWmg5K21JRVh0bzlqTCtVd2xLY1RTYUZ4RWp5c3VXcEhT?= =?utf-8?B?bkdUUjdYdWY1K0pLQkY1OHpYMmNGU3pwalZSVlNvN1VpcTJqUjBKc3VDM2Fv?= =?utf-8?B?UlVraGFmczg5dERhdXhLY1J6U1IvMEcwS3VKdjYvcnNKSFF3NHQweWltM1RU?= =?utf-8?B?enBDR3pYY01GNFZpNkc3VzBkcEtHU2Q4M0o3MzB5ZytBSG9kNUh1SzFualR3?= =?utf-8?B?bkpvNytoU1pqTUU3ei9yRndkRm5pWERUcWFuWXB5QmVweXE3RUhqV1E0V0J3?= =?utf-8?B?OHcweDFLc0R4YU1NaXlHeDArem5FbEthTzNLMHhDZDBweERqQ3RnZWJKTEZC?= =?utf-8?B?VzAxZWFpeU9FSElMcjA0SWNlT0VJYm5kSjMrYThLd0E4TXdWZ0JZc1dBSVpM?= =?utf-8?B?MjJaazFwUVpkWkFaR1AxdzlidWRrY1FCOG1TQzZSbEcyQXEzZHlxZSs2OXBm?= =?utf-8?B?Zlg2ZUNmcHFJQzk0aDU3dTAxK09VYUQ2d3FMYjE0TDVsNzlxZGV4SjlqbG9S?= =?utf-8?B?VnF0a1lhaisxSGc0UXVhNE13THpEVHdYdHowdVBwS1JobkQxRkhJRkxPaWww?= =?utf-8?B?RkxPbkYxVlVQL2t3cmdwUGlSR1dGNXhYd01BaENkMVpDZlZWdERLNVBpb0x5?= =?utf-8?B?NzhvUkNXR2VWRDJBbFBHQjFyY3VvdzR5eFE3TFJyNmFYUWVGRG1VckVveVd2?= =?utf-8?B?aFdNc3dRZ3d6Y3hEcnVJUk9vbDI5T3RIWFlPSFBMRlFJYUdYUEpEK2hvN2I3?= =?utf-8?B?Zk5RME9QOHBnU1BTeC95aUlac1puYWs4UWV3TnpPWlJndDZWSnNaV2o2T0pl?= =?utf-8?B?Ti96OXdSZWRwSVR2ZktmN1VlTzMvM0hRMGl0WWFUTis2eWlqekJIOGlIaHVK?= =?utf-8?B?UXFreTBmdW1DUW1GNkZKRjhLS0t5VG1ENTgzc282S0JibnJwUU15dWM1b0po?= =?utf-8?B?WGJ2eDBLRHFndlppbUQyWXV6eWJlN3ArUlhvWlN4eForWUZqQTYrays3SGt4?= =?utf-8?B?MlI2bm1wMG0vQW02dUpjN3F0THJ6RlJNc3d4eW1hS3dqanFRNGxOTURVNnRz?= =?utf-8?B?K2pETkZQbjFSd3dLeGtLbjVsV2NjQnA2VXcvakhoTUFsbmZ5b2JLZVJpT1Jp?= =?utf-8?B?bTc2UXIrZFlEWGJBT09iUjlnajRTSzU0K2pibUVFeVI4Q2FUcWxvbW9IcFdi?= =?utf-8?B?NkJCNVVodnN6ejQ0Ly9IUmcxRzI4Sm93cXAxbHNwTEs0SURBT3ZIUERpOVAr?= =?utf-8?B?YTJKN0RFUjhzNVJvRWhudnFUSVlJZ2sreGx2eVIzN3ZqWENGUXZhY3VnZU1Q?= =?utf-8?B?bWllbEJ6Ry9Ra0hzUU4ydkthUngyektzSWpRWklQYVVEOWJtams5UGpoaThY?= =?utf-8?B?S2dFbnhMY3BWZTQ0dDRZd0R4c1g5YitmVHdiUGkzTGhqbGJWUWFJMXZBMzZk?= =?utf-8?B?aldTeUpYNHFEbFhKdjJNSHluNlZFaXJyQmY3RTN1QkIxRncxZktVeGZjcWJ2?= =?utf-8?B?V29tODdvL0lqNFJ3bUlYanRZdC9HYjJzNVlHWGhadTNBS0ltOTUra0JvdnJn?= =?utf-8?B?MUI4d0hwTStlaS9UVyswemF2VkpBZDlDY0RHcnFtSnZGV09ESmRjZzZQbldm?= =?utf-8?B?Z1ltdmRyU1A0dHdJM0UrK2c5V0o4QXpDM0poaWJGdlZ0WjM2UGdTSHNhR28v?= =?utf-8?B?RmhvNUdCTTRFY2VvR2t1NElxc3lWTjBCRkExL3FjNW82dGhNQjltcEJDQlFF?= =?utf-8?B?RXc9PQ==?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 09f1623c-f423-45a1-24c5-08dde1757b59 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2025 12:14:45.4915 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hFxyksSAlDaZuI7Z9ZizirYkoqPTJOYMMnZLE6O4TmM17VsGY3nFJxCiXu21i1Taw8U24fdbUOsKfkqwLtRam2w9g6hdzOxjY/kFQeM93b8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR02MB7725 X-Authority-Analysis: v=2.4 cv=PvLKrwM3 c=1 sm=1 tr=0 ts=68a85f3f cx=c_pps a=YKE8LuPMBYZ6rjMuwm3XPg==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=W95sc-WnjIl6KLOMV5AA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 a=cPQSjfK2_nFv0Q5t_7PE:22 X-Proofpoint-GUID: 3FutNbSTCHSPMcoCLB3PEVidSb76Pvjy X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODIyMDExNCBTYWx0ZWRfX3DBqdD+bGRXO I1c9sh8d9fBoiZKcYnii63oXuYsHzgDUdTN4vX9SHf1jHS6sPIO6nCRExGNhnjfnTuFgELlqfnr SPLKTzgdXcLBjWAyQYu8OQqknpFkqsqWFO2b9ulAodbS5Fxdw8RPZ43pNqvW2Nf3nYZ9DAPz87z mAuuztjHB6GVA4Sy0mSBnfTpUWznTe+DJvpQUTp/LAYTqIpF9XTG2Rna+yNrjgn6je5CMc8iDQO UBTzWIwvm4YL/dUREGvQuMmCkj70S/1B8GsxAdnClxcvafFcUEnll+Y3daXIGR63VE1zhqx7Hul u1lJmXeFDm+IRPr2rITHgzRcC7G3qXh3NlojG2TjxmLLwGKj4gug8XuUH7Flf8ZlN+kRKWWhWAn pcnqAooSqelRJSAAzRBYu/5jmeo69A== X-Proofpoint-ORIG-GUID: 3FutNbSTCHSPMcoCLB3PEVidSb76Pvjy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-22_04,2025-08-20_03,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.151.68; envelope-from=mark.caveayland@nutanix.com; helo=mx0a-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1755865776959124100 The headers for isapc-only devices can be removed from pc_piix.c since they= are no longer used by the i440fx-pc machine. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Xiaoyao Li --- hw/i386/pc_piix.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 05713662e4..5babdc3e4c 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -27,19 +27,16 @@ =20 #include "qemu/units.h" #include "hw/char/parallel-isa.h" -#include "hw/dma/i8257.h" #include "hw/i386/x86.h" #include "hw/i386/pc.h" #include "hw/i386/apic.h" #include "hw/pci-host/i440fx.h" -#include "hw/rtc/mc146818rtc.h" #include "hw/southbridge/piix.h" #include "hw/display/ramfb.h" #include "hw/pci/pci.h" #include "hw/pci/pci_ids.h" #include "hw/usb.h" #include "net/net.h" -#include "hw/ide/isa.h" #include "hw/ide/pci.h" #include "hw/irq.h" #include "system/kvm.h" --=20 2.43.0 From nobody Sat Nov 15 03:14:59 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1755865467; cv=pass; d=zohomail.com; s=zohoarc; b=lU5XwQ5tKsnrQwOEe0LwmkSbERrwMJhorHD0xbCEAb/Cm1H4S6hdWWKIdzcc+rHkvOFFmEjYN7+eJIVN9uomGYV+oCKbj19LWqnjZ8efNAz+q8ZP2bugr+Vw7Sq3FL013JKgouyt2Nkqi2TmewBNJbVpAKlj+l17dov+9mSmC2A= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1755865467; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=7pdaTuuDJcaGjxWsNMwSdITadxGExHeIUdYsV5+MF0E=; b=Z+u6P1Db+TNYdcyMjhvs2F9DnoHfS1L21BwMGlT1ydX/E5hLwGkDdaVPV7a7leZS2uceGhWv+nEqTW9dti91Cm8uIcSgV9F2W2aDmxM2aW0K0UQmlsvzFcyqdW1H/QzuzI7S2injEVDgzgOcnwXDZuAZFTq/j7zasrlHRXYMo6g= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1755865467969349.30674110144105; Fri, 22 Aug 2025 05:24:27 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1upQfr-00024n-Jo; Fri, 22 Aug 2025 08:15:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upQfe-0001qk-MO for qemu-devel@nongnu.org; Fri, 22 Aug 2025 08:15:03 -0400 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upQfb-0000qa-CF for qemu-devel@nongnu.org; Fri, 22 Aug 2025 08:15:02 -0400 Received: from pps.filterd (m0127838.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57MA7uhK2824419; Fri, 22 Aug 2025 05:14:56 -0700 Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11on2095.outbound.protection.outlook.com [40.107.220.95]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 48pphe080n-2 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 22 Aug 2025 05:14:55 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by SJ0PR02MB7725.namprd02.prod.outlook.com (2603:10b6:a03:322::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.24; Fri, 22 Aug 2025 12:14:49 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%3]) with mapi id 15.20.9052.014; Fri, 22 Aug 2025 12:14:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=7pdaTuuDJcaGjxWsNMwSdITadxGExHeIUdYsV5+MF 0E=; b=0UMJMPCdgPwIrBRyW+SDOadTlabEQ8PyGKoHCP8Xazyws3R5VcNL1BLoW EaB2RVEcMUi8NMlwGKqjD2jZMBpc9bcfAQe/O/qxxkqvgH0SYma30NT0IDv511CT kp6YryvcRdVbe6rrGfKFi1Hi+t5uxchfy1WrUMM97CrYbGAOToYRy9ClnqXcwmj6 vPkl1K5rgWZxmCS4nlImP6o2RtXbh+ZFrnu3bTMZhGw5sMOfAW2QQS3QdGzHvuTH 3vvXG7zogIwTb0yzexi9Zkf/DzzncafUCv2gGCtVOXuvSQiSCVK3GUg+SayrIS3t warfUYrBb1y9yWPD5khQel4lDurgw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bROLp0agC3gfYWwJNYvZX/CqFwzroLtxsGgQPxAoHSQP8JVfKEfu3mnO2TyTovIbn06+TWypL23cjd03EiwxWvKMw0+Ue5tu+pXplBk3dVHGOvo3KAvEE2yvU/mOrodANnxTGOe5vo6oBegPq8Kv08zbZNmWDiLvvIfCnUQXjHHqxsMF4McAY0ZLLKcN9ww4zc5svE5XYCDWBgDAYHgAD+CbZ7HLz9GVrwh3lNp1U+KYpsFY8mHu/Djj0PHnC4nv4FvXL7bOqavkSZ95b7QkKud6fHjNYgjaiNN2FfrpDntOlbpDiN/1bAm6FayOg+SEm36pV9UryY5r/vh9JF8jTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7pdaTuuDJcaGjxWsNMwSdITadxGExHeIUdYsV5+MF0E=; b=YM9N8l37CIH/gBIFSU6FDx1VDraJteLPZekWYJN2kcMqo5oBZ+s/9ma/UFfMDhwXaPsFJzhFFoffNBjT6VZnjRU9slC9pJQjSlmR4I5GuPP9crYeaOKSKH93uH5mCbhuo+C4iVUe8NYJ5vfBLM9CmTNSQwZgrEkRHKJpmRU8zfyHhGtgGQ+tBxRsslcE2UGrAmoOk2bHD6lU8L5nb6mTgTJa4fnCja993CPxY4shhf3PZ6YDDwhIbEfxX4TGmSMJlyvi4IcWFxMKzjjjS5iiNfINLNGEwIyLIBqDjN1SWqqAVW15hDzYNAUjZYsgZEcUsHHYxyFXO7YLGqJ2maw5Lw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7pdaTuuDJcaGjxWsNMwSdITadxGExHeIUdYsV5+MF0E=; b=XTqzRizQQLfbLhw6rrAqLWPjdcToIfgiQjuTaeUxeaMExIB3T51YK7dtt658km1lw9jcFeQG5vdWsUfByTlZe7BuAi5BUcII26Kj3vkQUzsRnalg/K9DH7mfiRkK/NDA5RbWDHSwdwB9Y3yiLrB8howF4HSFMJ26WLTR7w+U7LF04gp6dJFuHJYV96pW4aqMDYh4mXbQVtrJpWMhik/5MT5Gx/yM6mA5W1OhSCextUYkujkmXjd4USuB6gROFbgM8PZwnquYgKswR/aI9oMSmhKGlBs7yoYnV97mdhooxdfiwCpwPVIdTe4kc9fKLwY5DifxnXXN6xCxsOxtkRB0Iw== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v6 18/19] hw/i386/pc_piix.c: replace rom_memory with pci_memory Date: Fri, 22 Aug 2025 13:12:04 +0100 Message-ID: <20250822121342.894223-19-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250822121342.894223-1-mark.caveayland@nutanix.com> References: <20250822121342.894223-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM0PR02CA0170.eurprd02.prod.outlook.com (2603:10a6:20b:28e::7) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|SJ0PR02MB7725:EE_ X-MS-Office365-Filtering-Correlation-Id: 8bc551ec-1927-4eba-96b8-08dde1757d8d x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?a0FkVDRuZDZHV1Q3UXB4MlY0dkhwZlU1ZmhROUliZjBpTWh1Ny9WaHJURjJG?= =?utf-8?B?SU1uWmhMNXZncHVVZU02RFpMWWRxeWRsVkFYSlRoRW01c2FPUW5ISDNaQUk0?= =?utf-8?B?cUsxeGc4Y0F2eW1nQ2JIK2VRT1RzbU9mZ0FWQmQyVmx3Q2c5ZkxkbUtFRVo1?= =?utf-8?B?TGhXNWhzZE8yZTljTUtuZHd4MGh1WDdVV28ySXlBUWtXK2pKSE5mQ2l4RjZB?= =?utf-8?B?RlEwN21uOWZVbGpZUEVmQTlURlRmWHI0R2FCblp2cHdxQkVNSHBMNEpWeENG?= =?utf-8?B?R0NyeEFyYjZzbnZYR2U5bEdmOENHTUJLQmNyU2tvR0pxWml5WUxlQStBSTNp?= =?utf-8?B?cDdWeFZndTZQK0E3bFVENmkvcGdDQTNNbXhlQml6Z3VFNzl1QVF3SHdaMGRq?= =?utf-8?B?M3hwdFFHdFhyY0hIc0thelppQjUrbHlxL1pldU5lSkpRUUl5czgxczZYMWlO?= =?utf-8?B?bTZkSXYzV0dSeVMyak1xRWlkcjJMODhWTEtPQXhTNGN1eHhmNDBuSTFIY0JE?= =?utf-8?B?bVVVOG5uVnZQODA3YzJYQXc0OXlZeGo0TEMzUTNDNFZVMzZNaTVQNEtZVUxX?= =?utf-8?B?MURDUFB3NnBVVXduVlRjZHVNc0hqYVppb00xK01ETmNzdmY5V0VZenhtbWht?= =?utf-8?B?NTdKTk1BREFielg0cHZvQjdSZEQza1d1NGlPcVJmVTRmeE1tbUhjdzB4S2Nk?= =?utf-8?B?L0x6UFdaQldTV2Uxa29KK21ScVA0aTZFZ1BvalhVaTk4R1FXTGNpS2ZkU1VW?= =?utf-8?B?NSt2Vk4rREVBZXdzZ3dUdlcvdmFsa1ZGUTI0b2xLb3Z2SFp2YndlR0ZsRjNF?= =?utf-8?B?a0k5SnRIUU1LTm52cFlrejFUbk1zVU1YR2wwUUdHRlgwVzc2VitNQjlwZ0pH?= =?utf-8?B?cWNnWVhScVp3YnRjcDdoVlMwZ3J6ZzNHVE1nZkI5SDkvenJadlovRnFuTSta?= =?utf-8?B?VFpCUFhrc3o2amJsRXpEV1pMRXZWM3hiSUlxY3ZFV1AwalJPR2orK1pRcjZr?= =?utf-8?B?d21sWC9FTnozaW0vZlNUenphQzhEa1FDRy9xRnA2cWJSWVFJbGNxeFpNekow?= =?utf-8?B?WFM0OUdnWlhyRFVMRDRqUjcvVzFSNW5xUVBLZVErZW5RUldwbUx4UkovUzh2?= =?utf-8?B?dWNEQ1BEZ0dCMGNLT3I0ZlVMZXI0K01rNTQ5ald3bW5PTHVRQnZtM0hJUWV5?= =?utf-8?B?SjhRNkFTM0pIbUsxalhMU3RGbzA4cm9PVjlWR3NZRGJocy9naWxucDlFQ2M3?= =?utf-8?B?dzIwaXRiUVhibXI0VytEWE5mbmd4NVc1Mms2ZGVXT0ExTlVUNHVZTis0czdM?= =?utf-8?B?MDZZRmJqSEJ6MWN1d1UvRjZuNDZQeTFLbmJJTVVCTFc0Z1REMWJmekJ2SHA3?= =?utf-8?B?allDUnkyQ0VsWWNIcmhHdWFXWUNuTDdsZTJZZGhOSTEwR2h1K2x0Zk5ZWWxP?= =?utf-8?B?K0tEM2ROazV6bnBZUUxKZGh1dE1icFdrK1dWbnpUc2tXTld4WnVQUjlFRWIw?= =?utf-8?B?Ynl2M3VzL1ltSXovZG8rSkduZUdwWitLK29NVG1ZYkpZcTNrQkRRUUk2amdD?= =?utf-8?B?VlFvOVp2ZGpGOUFxNEZ1dE5XNDlibVcrSFViVUwwbUhMQmFYQnVzbmVQL1FX?= =?utf-8?B?dXA3RWtPdUdzdEdlVWJtQkc2cjA3MTJyUlQvazVXRXh2WkVhMGIxSVIveEh6?= =?utf-8?B?RFJJZTJic2o2UHJUZWJabXkyWXpDTHZiSjV6clVvNkN5UmUwazQvVldLWkNu?= =?utf-8?B?UDFWNVFONmQ4Z2tJTjhReFkzQzE2MUtLMjdHRWVVV3lRdG1uTTRVVzM3UWlE?= =?utf-8?B?WnVOZzBjYi9YTTQ5THRUbXlkaGdlakM2VmlkZ1A5RVJUdTdwT2VlUW05clVB?= =?utf-8?B?VlJzZHJlN0RQSXE0VFF3SEMrVDhNZWRvMFk4VE8wTUYyMDBFVHhKcVJJd3Fa?= =?utf-8?Q?hCb7pGfhCWg=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S1BEU09taEtjVTRVNjZjWWlLSTBMWTFQWnA3Ym9ZWjZEZ281aDd3cE1oK1hT?= =?utf-8?B?enNTb2c0ZnlQelI4V1RyYWtkTHJqaytnL1F4bGNUUWxoOUZtZlUzYnRjTUQ5?= =?utf-8?B?dHJSWHFWSHBRbWxEMnhnWGRFcHZqUGtQYUY5STZ4eXJlWnRRd084Uzd3RCsx?= =?utf-8?B?ZmJhSzZFQWkwZzVyZG50eFlnMklKVTRyU0dBN3Zqa09OWXhRSXNCditqZmc4?= =?utf-8?B?Y3NZRlpqRk1yYmEzdGlQR0RuL2taYjBTend0SHAvWi9jYk10a2hRRjNveEVC?= =?utf-8?B?Zlk2VWs5clRleS9wUWxkS0cvdCthTHNEMVV6bTd0bDFPbzVXRU1KS3JiNUlY?= =?utf-8?B?MjBIMk1aZi9TRzdkL2lQK28veUltWFNwbXR4V2NPTVIwWGNYNFZnTDVPNnV0?= =?utf-8?B?UzJXREVmdTZab0VlZjZrVi9VY3lHcE5TRnp5Tkt2c0F6bnFJbUJnanVCU0FN?= =?utf-8?B?dExEamdnNmM2Z1dhZGljQVg0NmJTb1hzSi9jMGlpaTg4cFphK1ZUbG5OYlE5?= =?utf-8?B?MTdtMXhaTSt4NzJ6RWF1eXJUVVNkNjAzZEovUGpYcTlaZXhHOHh6ZWJBWlJa?= =?utf-8?B?VkNvMU9EU1htQ3dkRUdsWURWK25Zell1ekphZ0Vsb1ZSTDljeWlwTkxQeEUx?= =?utf-8?B?aTkyWGh5QUdzVGNJVXluOUR3di9OWEdSRzl5aGxjakNRdmRkYmYrUkIrOVc3?= =?utf-8?B?NmlHSGFNem1oc2NjaVB1eGNlUWUxUml2d3ZqWWU5cys2VElNREJXVEgzRWNL?= =?utf-8?B?b3BlcEdFdjNJTm9BRE5SbW1oYnllWVg4djRpRUdUbzR3Y0JrU2djS0o5NXZv?= =?utf-8?B?djNnUjBlT2FsMXhtZnIxN3hEZkRpSy9nTjhhbGZCcW9pL3pQQm1ITW5CK3E3?= =?utf-8?B?ejcyVXhVUlRkZG81Vlo1RnNwQWgwRGZiTnNZV2tCK3M3THNBeFZnQUs3VGpY?= =?utf-8?B?NERucXJXY2lwYk9yTjFLb2VFRTBNTDJxSTF2N2dnVW8rUnE0UE90UCtBT0Jt?= =?utf-8?B?NG9pMTFlSWY4S1pCanVja1kxRnFCcDd1VXZVUGZEaC9TaDNId0FzMFVUM05h?= =?utf-8?B?c1k1Q21xbnRnYjJMRk1SMFc5TW5VL3g4dWc2SGp2dk5qMlVsYlBWUDEvb2RV?= =?utf-8?B?M2pHNEJUZnh2Vi8xYUVudjFqMnNGNkxlTnVxeERnYXF5bTloampPVkdZSU0x?= =?utf-8?B?ZGxreUNxZUVNNHJVMy9vWEloWmpJTERQem9mb3RuMnNkN21kdzkvK0hqNUFq?= =?utf-8?B?bzFGZE85L1FMcTlWaEVqQUpQR3NKVnkyQWlOUVR6UXdIaU5OcTkyb1Zyc0ZX?= =?utf-8?B?TWlkY2JYTnh3M2lWS1liNmRsNVlKbjdkOUVXNTE5bWk0dTh6R2ZBZHRpVUF1?= =?utf-8?B?OUI5QjVyN2g0QXhONVp3RHFsVjFhWEQvUkVZbkZBcEpNY0VJc3loMkNBN2du?= =?utf-8?B?NjNVMEhtN3lmS1plMGZaUEtSUEVqZnVtYlk1dXBPY2pNNFpMVU1tMHpBTktB?= =?utf-8?B?Q2Qya3JNblUyTm5ZZStVMDJWTmxWdUs5bWF1Mi9peGxBZU1OT2hDVTNmcXp1?= =?utf-8?B?UG1jek44Sk1WcEpscW9rSjdndFJNc0pvd2J5Nm9jeHFrcCtiUmdGaGJjdnp6?= =?utf-8?B?dXJZR0RpNmwvM1RUQTc1WVF4UlhlY013aFVySXNMTXMxYnJPdFZPQldpOVo4?= =?utf-8?B?eVRJam5FK3VXWjNMSUJSTUZWSm9oL1ZReGpDWEJ6TjBnWlgvaC9ZeVpiMHNJ?= =?utf-8?B?VEtuUkVXQzRQWko4WURLWnFXNEk3a3gydXhkVzhaWGxVejdURERxd3IwUXUz?= =?utf-8?B?T3ZOZTBhV0JFbmRBYUdEUGdrSXI1RE5GNXhwbnErSS9jWkdQcFlZdGdZdjRV?= =?utf-8?B?M2dNczJDVFJ2UmtFWHVpM05PR3NvSVkrcGZNclRjUDUzVi9mcTB1ZTQ5NmNx?= =?utf-8?B?M1k1OFZOWjV2cFRPV3ZFNGpwb052Z2Z4KzZ5bHQrL0lGRzJUWkRXVk4wNXZS?= =?utf-8?B?NU9VT3U2MUpzZCtzbU53N2lRUjhxaWF1b050czFLM0ZUYTRndVVxK1pqNVh3?= =?utf-8?B?RWVYTlFMVVpPVFlhV2JoQXhnVHpZZ2poRzNMTjZqZWlXampKTjNzNGxHT1g0?= =?utf-8?B?NW81SkNhRGNyK3FDNFkvb2lJNjJoTW9WTTl1ZE1aQ0RSSzJ3ZmZCRUtGTDV6?= =?utf-8?B?ZkE9PQ==?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8bc551ec-1927-4eba-96b8-08dde1757d8d X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2025 12:14:49.1916 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GVwCx25w6ovi+HssI0N+oYSdySrJomotm80kd3UiAF/XCdhqZJ82AjQFSP2UKNye2xyKnpBYcoLXWcV09HtWPBZpZHnyTPgv1dOfU4cFrCY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR02MB7725 X-Authority-Analysis: v=2.4 cv=PvLKrwM3 c=1 sm=1 tr=0 ts=68a85f3f cx=c_pps a=YKE8LuPMBYZ6rjMuwm3XPg==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=9K-6XCuZSqnjzfDIaq0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 a=cPQSjfK2_nFv0Q5t_7PE:22 X-Proofpoint-GUID: XpgtR_vlPBkRu1L_GITfmq4LT0wrGXp7 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODIyMDExNCBTYWx0ZWRfX1krDIxlxxLzC bSeKjFMSyUHTInVPET7wgQK7ihkVu64GdDImU3k2Y2cr1xDmOjgrgwplZytIm0nKQByLwd63GYP 2C7S+UYS4FAb+ZKpxXpxpmgrTAkXvJA2eKZkw8/EZ3Lz+X6sEapgBrOYYJdXOCyJ6kQh5GqM7CC fK6qGCOSNbwSzr/YFKfekaWSBqyjNcp5tvyBGMqUL6O3dpdoYqC4jxGWEGF/A4F2IOnlN4/73vc 95WJUXEHU6fpCHJU6GZ5+s6/6DZYJ9H3y7gXfdr2/jhraW6KvDjvjO90ekRUUs0E0UOBw1yTWE3 frDqJq2SL62H7mTDhtdhZpOA2N678exOwn5/Ao56S1YWnY3Rhh3rSs7Qge5sBQ672kYGrkAV1nv xYo0j79gSgGirYivfnm37g1mzfBzQw== X-Proofpoint-ORIG-GUID: XpgtR_vlPBkRu1L_GITfmq4LT0wrGXp7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-22_04,2025-08-20_03,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.151.68; envelope-from=mark.caveayland@nutanix.com; helo=mx0a-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1755865469355124100 Now that we can guarantee the i440fx-pc machine will always have a PCI bus,= any instances of rom_memory can be replaced by pci_memory and rom_memory removed completely. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Xiaoyao Li --- hw/i386/pc_piix.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 5babdc3e4c..b736f0f236 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -113,7 +113,6 @@ static void pc_init1(MachineState *machine, const char = *pci_type) GSIState *gsi_state; MemoryRegion *ram_memory; MemoryRegion *pci_memory =3D NULL; - MemoryRegion *rom_memory =3D system_memory; ram_addr_t lowmem; uint64_t hole64_size =3D 0; PCIDevice *pci_dev; @@ -191,7 +190,6 @@ static void pc_init1(MachineState *machine, const char = *pci_type) =20 pci_memory =3D g_new(MemoryRegion, 1); memory_region_init(pci_memory, NULL, "pci", UINT64_MAX); - rom_memory =3D pci_memory; =20 phb =3D OBJECT(qdev_new(TYPE_I440FX_PCI_HOST_BRIDGE)); object_property_add_child(OBJECT(machine), "i440fx", phb); @@ -222,7 +220,7 @@ static void pc_init1(MachineState *machine, const char = *pci_type) =20 /* allocate ram and load rom/bios */ if (!xen_enabled()) { - pc_memory_init(pcms, system_memory, rom_memory, hole64_size); + pc_memory_init(pcms, system_memory, pci_memory, hole64_size); } else { assert(machine->ram_size =3D=3D x86ms->below_4g_mem_size + x86ms->above_4g_mem_size); --=20 2.43.0 From nobody Sat Nov 15 03:14:59 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1755864988; cv=pass; d=zohomail.com; s=zohoarc; b=UoK0DyLbbucxgzK1Gm7QidK4AJt2OFf24FsL5gMp77gdgUs8MvqWGabVP6MHM0gAFKayhKjPZ4BflJ8OQNxhg6r85J+TxNkFBH3bAYSUljbMFqA9ORG+Z37ZV12XX7X1vh0wi3TfsiiPUB6yps+QW+XLRCIEqhX2a9dcLwFXAVo= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1755864988; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=Kch221Ty1TNCyV8Np/NBxaD/6LyFYzy/nMX8c2x3+TQ=; b=hp3MJ9oQdwP/qh7HlqesYHzkbMqTyINwP7FhpS50bwRviifi5COw/hjtkLJacvAKvFL3CJtV/n/6rNwLdDrSYGHqdBWgz2i6J7XBs9HQzw+BBue1fyGtuSlhJkODA75I45ZPran0WASjMA+RYrrRWFpQ8YcruBuzmwrVPpVnVIs= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1755864988710951.1596403619501; Fri, 22 Aug 2025 05:16:28 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1upQfs-0002Cr-IS; Fri, 22 Aug 2025 08:15:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upQfk-0001v6-KL for qemu-devel@nongnu.org; Fri, 22 Aug 2025 08:15:10 -0400 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upQfd-0000qd-21 for qemu-devel@nongnu.org; Fri, 22 Aug 2025 08:15:04 -0400 Received: from pps.filterd (m0127838.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 57MA7uhL2824419; Fri, 22 Aug 2025 05:14:56 -0700 Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11on2095.outbound.protection.outlook.com [40.107.220.95]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 48pphe080n-3 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 22 Aug 2025 05:14:56 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by SJ0PR02MB7725.namprd02.prod.outlook.com (2603:10b6:a03:322::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.24; Fri, 22 Aug 2025 12:14:53 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%3]) with mapi id 15.20.9052.014; Fri, 22 Aug 2025 12:14:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=Kch221Ty1TNCyV8Np/NBxaD/6LyFYzy/nMX8c2x3+ TQ=; b=VFVcnp5/yLPLhsSWo1z+2dg1ubBeUzgUx6CW2haae4hQnqG2UsuY+y2+T lc4mxkNjiYV1FjLwNyhelLEUVdYULk2ZYssTlXKnpp28HfnNQAJyRf5Uab5y19KI diJVmypC4bROmOOHPmp869/8bIxxSoKax6gYldhVqlYXkuND9pamzty4ddnC6Kyz LsqGRspDke4V3hPyPxAVVm1SaVKKlGhrBpwTVYAK4+QPdMpXT0b4OyV7PkIrIUPC pxi6zQ7cpS+Ksm4tDie5ZO2d42VHD+3lggBqgfe1H/1o8NnwsiB/IIjTSO8pdn10 GZf3jZCV7d3QGqAnJ8MG/M+B6AK+Q== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dYEpSvpRShpdn6OjD39+uo/r2EhokV7FlYGnGYQeu7ltKJUgU/CEIGW5bvBPLAvEQZ6guAKGQbsRSFPF+6gPSRP4LyppFPBrol13BOkfHkPF6sW7PVl6cuV+IA3N12IISuhU+a8j64EYYlQqfxcyJBa5F0RLw3VUgwrjQOGfybBr9LuMEib3q6UEKwJGZ1OxKRepFeB+uC4EXaBiM3qPV+6uhooEEISLoUMLPLZROn9yObQqpH+edpnjHQdsAA3yU5Eo5FCeIbdCrobYeDOM9RuDC8EBMqlZyTLf5fMd5jAQ/8g86OMluz6tsBmyBjQF8U2Dzag6wH2HFdYFcbi52g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Kch221Ty1TNCyV8Np/NBxaD/6LyFYzy/nMX8c2x3+TQ=; b=FekTCMFCywm8mBCS6tpl+JXxjLDUm9fxmhpLhvP0nSkWHYg7tIMgbNUDNAztGPHpGsZ3PoRBDMoNVcmdP/8p+Quj2NOnTFxDR5Z6uPxcw2WUkw0WxxgINTpBdmYjc/IBvkVEcoEZg81H0RtWZW8SbB8O/ZOXfZsHzq5JOxvFI7hFGEIiQvBg943YRFXUtpkv8qKTlGVtbAiBD9aPCoMo3+Nv2AhuOHgl32GVaXZ05JkzmIkI57kJXre/1WZQqSSbvMlG6eFRimXCkAeDoAX+9aPd1cEoMbtsDILtsXhrh7Am0YWUNBB+75d7Fl3Szz156/5BIcHVICxvwpo43l0Byg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kch221Ty1TNCyV8Np/NBxaD/6LyFYzy/nMX8c2x3+TQ=; b=UNiOVgEAQG+LVgZqDja2eJkJ2SRWdmxLc2M3l/vP1QTFwco7jBTHi4NhPD4eAdKH0rsxyruAHZ0OV4WGrBZBhd+moB9PPgkg4sl0Gho5ul5aqpRJGhkmc+9SaAnn8ZiglO6yKKRb5bqkcVk75JtPEZ6esySZjpFHDi7DMq/t57Ut1+NXdILK0JOiRYjAnn6IJxiterCYDJb036s3q4KUrMzBaxFW77SatDrYNDO0OSKW9mk2VnE0aWeILVLMoQINzGT02knbLIo1BCqn8kBGDQAjcmLdxu5u6nsOC5QghoWFkTGEhGhjGtR8/AnHAXjtEsROWdx8vXsr2vU2s0Hgjg== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v6 19/19] hw/i386/isapc.c: replace rom_memory with system_memory Date: Fri, 22 Aug 2025 13:12:05 +0100 Message-ID: <20250822121342.894223-20-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250822121342.894223-1-mark.caveayland@nutanix.com> References: <20250822121342.894223-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM0PR01CA0180.eurprd01.prod.exchangelabs.com (2603:10a6:208:aa::49) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|SJ0PR02MB7725:EE_ X-MS-Office365-Filtering-Correlation-Id: a9b9ca9a-8130-4e0b-085b-08dde1758016 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dExNWm8yVzdOSm85Sk1yT3pDMEtlWFh2U1BUMnowSjVEdWRZZUp5YmF6NUEz?= =?utf-8?B?ZEc3dW9PR1had2lxelhGU1RoajhXZ2VlVVVxcUNzbERoT2lQTzFPa2NRWloy?= =?utf-8?B?ak1WMnN3dFE5eTd6VzZFUmNabDhvUWpuaW1WNlBMcFJiVExyaktkNTljcFBR?= =?utf-8?B?UGZsUGRSbjBPQ08xWm1vN202ajV6RElRT2ZuTkxJU1FXc1RhaldTc1NJZlBs?= =?utf-8?B?ckVMUEtwbXlpTzJYbnpmeC9SZnRDRW5hV290LzN4cnRNYnk3WStIeExLa0Nw?= =?utf-8?B?TGlnWHNtNU9wNU55WWlkbi9Pem5iVFhPZU1xUGJNcW9nWFJJTjNQa3BHcXVS?= =?utf-8?B?WXR1bklNdFpjNHJCNUkxdHlHTTBHTGVMSkxXNlpvcDkxRkNWN3VydXBuUjFO?= =?utf-8?B?SkQ4c2ZEYVppTTNneE1lWmpMZlhxdUZWVkxDOS8rVEZLaVNYTlFWSXRnaTcw?= =?utf-8?B?UmUwenVjNndVL2RaR2tGWEkrNXJSZUxlQUUwZUxnUUhxZVpDOWJpQ1RyWWwy?= =?utf-8?B?RE41dU40NGVLRFJ3eklPYmlVdDk1cHdpZ2lwdFNKU1c3cVZwRGlITDg3djVt?= =?utf-8?B?YmhZWDB0UkhqbDFJR29XVFRMcnB0YlR4bElLVjFFV0FiTk9yeERZWFVLUkJW?= =?utf-8?B?WGRuK2RuQVRiTWJiamxJMjllaU9GSjFDYm1QbGNHNGczZFBjcHRidnEzOXRJ?= =?utf-8?B?Q1ZjZWl2cTUzRlZvd0NGc2gyQWpZaVZsbFFRRmMxejJVV3REQTRwUWh1WGJ6?= =?utf-8?B?UzY0YlpuNVY1MFUwT0JrOUI5Q0lVcmVycVFnUHFsdUV0YkhxMXUxNVpVZk01?= =?utf-8?B?empHZDhxVjRFZFoxd3I2NE9UVGE0ZUp1c3k5bTRhQ0lOUDdaTzJwNFNkOFUx?= =?utf-8?B?RjdNZnB3SDlmRGdSUE9Kb2JscHVGYnp0TDVRZEFMU1czby84eE1OLzRzbHhZ?= =?utf-8?B?bHpsNXpDUjhmdDVtTHpSQzZlS1RlQ0l2d3ZyUUx3UHNrOGJ5dmpBc0RYVHh1?= =?utf-8?B?eHJqRWwzQjNTREowcHpjeGV5V1RQZFRxUDNsc2IxVVM1cS9IeWZJT2pqMkpi?= =?utf-8?B?LzZJSGRpU0dPSGprT0FOQmx5VUpDVS9NNjR0UTBCZDZVM0xJS2NwclgwQ0hh?= =?utf-8?B?VEtQckRxbFB1cXgxWkIrb3ZSUnVIRHhDMzVQWjJxaHZIL0tHaWlsYjJQQnhG?= =?utf-8?B?U1lkN3BVSHNsdjdrTG5YQlNZOU40SkpjS0ptdlBrcEo0ZWlVQ0oyV2VvV3NP?= =?utf-8?B?eWtnQ1dLSWpCdndPQXhsbndDTjAzOUE2VUJ1YjNTdm5CNnhzak9DTGJLNG5q?= =?utf-8?B?UldYOU8vOW44VXpoaDZqaDVKN0NaWktZS3grWGlDUVcrS1Z6bHNXYStJZ0Rx?= =?utf-8?B?bFlyWWtZbDV2NVhtblhZMXRzVVNxM2xyUzNqUUZDWG9iZVpLV2RqTjdhbTl2?= =?utf-8?B?Qzh5Q1hXYmh6Y2g1Snk1YUREMEJRNGo5TkRveDVvM1Q0dDBlV1B6c3hQMG1T?= =?utf-8?B?dXlMUnlxTldtOFNmTmErYjVaTzNCQ3NGM2g0N0N1L1ExYnBkMWVYQUNTRTR6?= =?utf-8?B?bFdpalY2YWEyREdxTFhyZ1BGbGw5R1dVc1RXVzBBTVdOcW1HaktGMVp2bDNv?= =?utf-8?B?Q1M0d1BHK2JHb2lNaUI0VTZ5Y2VkVllpTmVwOFZRQWFoekt1WVJiZkZPK3cx?= =?utf-8?B?QURlTExmOTNrR3FROFZleE4wTGRWVTJhM2NlZUVaYjFVVDAvVzJPMkpiZEhU?= =?utf-8?B?eTdvdEpnRXJOa1VYZE9odHdWTFJmREp2bjdneW9rdFJ3RXMvam9jV3kwK0lG?= =?utf-8?B?anhxWTBrM0xzaG5aZ05zVnRQeWtXQjBxbENFaFJpVDlEWmRBbWFCWGFQMXlo?= =?utf-8?B?RktpL296elZvVWlOTVA3RTJacmo5bmltMUJ5MitvODgvOFFBMU9rVElOajRV?= =?utf-8?Q?5FTocXbeGDw=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y1BzdGdzdW5lYXBaakRHQ28zVGYyaEZwTFpuSE9ISmpINE5nNzVURFRpVjE4?= =?utf-8?B?MSt0S0loaTkzRDFYb24zeEY2NzJGOEJiMWNwSzVMbFVzZ3BCUGF3ZFBTanZk?= =?utf-8?B?dENBT3VpM1ZqUGh2MFEwWW1PWHVLdGpJeE85V3M2akRkN3piY0FuUmtYNmIy?= =?utf-8?B?RmVZaElmWmgxbFNqT1NOYnlITjBzZTRrdWl2MG8zQ2toUDYxYnp1WUFwaGlI?= =?utf-8?B?VHFWSFFZeWlaR3BoQThFZWRFcllhVXZEcTdqbFhvVTgrWTJJZXIxMmZPWnk0?= =?utf-8?B?ckJJZFA0OG9hRk5wNXpneUIrZHk3eU40NGZ4eVc4SC9HRjJveHlVTGljUWRk?= =?utf-8?B?MWVab3UxV09BbG56YVNkMjdmUU5DbmEyQ1JzajBtRlYwQ3RUbmhiVmtWTkRu?= =?utf-8?B?Q3E4VXgzaGFiemdBbmJMejZiWHFGT0dPQjhjK2RIT2c2VTFQdnhrOUtDT3U2?= =?utf-8?B?dmxZMGZHQmo3YmhubXJMNmJJVWlyRGk5RnF4emlGU0lUaTVNdUZGazAzYkhh?= =?utf-8?B?OUdTQ0h6R2RYcVd2Qm45dVVtYnFkbjBJRlkrQms5VHJmS0dtSEtiZmdMOS9l?= =?utf-8?B?cE1ZK1JKcWxxTDh3bzNaR0lJMm1RU2tkK2xtSC9yVzhzTXRyL0E4OSt4N3Ir?= =?utf-8?B?ZFd2b0pjbjF5MmREWFVZOGQ1c204SlQ0NVJwUXJCamJUckJQTHlQa2lSSERG?= =?utf-8?B?bmZzQ1MyUE5PM3QxRHh0Y21uTzhpeGg1TWdueGRsdDMyaGlna0RSY2pmcXo0?= =?utf-8?B?ZkRsSFFkZU5ONmNJWk1xTjQ3c251UFI1UE16ZHkvOTZScTRRRDN0a09XMG5h?= =?utf-8?B?cHVoQXRKeFVaNGtkMG53Y1d0emlmNktNOEkrQlFyTnlLYlJQWVZ5NnFuaEhV?= =?utf-8?B?czRuMDhWSG0xOTBKanFDWHZtaXprL1U0cTlaaHd0eWdoMTRweG01UEtCZDVw?= =?utf-8?B?K1ZiSnRuMUNycklaYmlWdmNNVTZ1N2k1SHgvNUJHeFlyVjJINmo5KzBHOE85?= =?utf-8?B?aGtJa2NUMXl1WGxEbi95UjBpL0FGaXJSdGVZd0EwaFFZdXNQdkxKQUFLMHVD?= =?utf-8?B?ZXoxa1p3UHhjaDlnN21PSVg0bFd3QllUYTBSVCtmRndPdmczM3F5Q0ppclc4?= =?utf-8?B?SU56L3hVN0xVTmZMR1c3WTBaVC9pell2VDkwczAyc2FQbVdEUVNhSmdrK3RV?= =?utf-8?B?NjJMZGZuTGpqdEd5RHB1Uzl5aThBNVFxaDRaUm00SXY4eHdsZE8rRGQrMjRy?= =?utf-8?B?eXh4RzVKY0tJSnRTM1F3MjlhQzZCNGdrY0loM0NZOXFoZ3B1UmhyTHVBNzVw?= =?utf-8?B?KzVUL1R6L01UUU82R0NjaFRnOWhtanhCN0lBajNmc2JwNmFqeFRkdncweFpi?= =?utf-8?B?UUJiVUlsK3hId0ZJV1pabHlUdFVrbVp6WTQrRkdmb1c0dHZaclVwOWJjbUxQ?= =?utf-8?B?M3NIRXMvVU85VFYrWXdDbnVDWmhrUlRISGdsRzFDeWFtR2psamR4QzF1Q2hK?= =?utf-8?B?NDlnM2lTS0crdHptbWpzZitONTVFdzNEeWdrQ0FTTUpCUVFYK1pXMlNXY2RN?= =?utf-8?B?eHNRR2hWMWNIQktOQjRKb0thcFhLSmtXNkhFa0JJNUpGVE5mMHkvR0tRQjc3?= =?utf-8?B?WFFEV0lpQ1c2d1IydFdLaDV5VXJwRGlsM1F2VXYwNDFwbUlxODlHTGVJdzla?= =?utf-8?B?dnFLNWR2WGpDaVhmOFQ1OVJ4Vm5TZVYrWTZ1YjhuV2o4SXFEdG95d2FNK2R2?= =?utf-8?B?SzdSajgwUGxrV2JZSHBMK3hjVEtRVmhiTU5yQkJQRHlaUzVsa2Eva3daUisv?= =?utf-8?B?L1J4M1IrSUMwT1V4YlcwK1Jid1BERGJ2UFBUbjZpalE5R0xJbitIS0E1Rmpm?= =?utf-8?B?ZG0vWWpWRmpHNzNpSGxzS3NjZHhSditwVmIzTjh3OHV1QXpzMXpWQytGenRU?= =?utf-8?B?OGVIZ0xISmp0VWJOTS8xUmdYOSswT3BnRUhaeHkwa1dVcHQ1c1U0MFV0d2ZK?= =?utf-8?B?K1Y4WGNzdFliWVhmWklGZFNzaGtxOUNsRXlKU1VpNFcvS21JbjZxczN3Rk0v?= =?utf-8?B?cEJmeWkxb2ljWTVOd2NQaElWUk1HRm96YkVMNEFCZ21qdkFZSElpQmVlSHVw?= =?utf-8?B?NWptSDRoTGZMdHFjaEc4L2wvK054ai96MytiYU01OTJodGgycktrY3JPdzlx?= =?utf-8?B?T3c9PQ==?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: a9b9ca9a-8130-4e0b-085b-08dde1758016 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2025 12:14:53.5503 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sIeM7zBJlcOokkLebJaCdGL9Z7BmIIoK6k0/RN3Dho9tAwSlUhta9pnnaiVKQ8N5I6yA64N0Y5BSOCFZypQk2/uAIX+qiLVIYRITYbe4OKM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR02MB7725 X-Authority-Analysis: v=2.4 cv=PvLKrwM3 c=1 sm=1 tr=0 ts=68a85f40 cx=c_pps a=YKE8LuPMBYZ6rjMuwm3XPg==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=k_ivhQKdL2eqRxG3LxMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 a=cPQSjfK2_nFv0Q5t_7PE:22 X-Proofpoint-GUID: srxCYTzWeqSoLtx7c1WFURb1LhnJ9_Oj X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODIyMDExNCBTYWx0ZWRfX/UL+wEFplASw 6gg4p+F/4JvLbcdsrTABju2K1oJOhIPXNVn9ZnvAMeFt/aJY+tMVK8bJXkKPzj7D3ePNxPWJkBx GE9xw9LBaavt7PnJGpGTI5EorqY0h4FYh9HGfOZTTEA3ylz5jxvcmk8LZe/s/xAXD3RvgRaJsGK LSKMpe+vP+Sk382Fe2i++kaHTs+lPbVBEvFtbGiSZwpeFgGGAkqySaHqg9VtAknMYtghrXFppyM U7UFw38reCQcDLrDl9qmDKXMTsLuocilutT9zZ7B3ls/MxU9CYmvlc8OzyOBWVxEbzWxadUiDig dVCT3OMPpsY6egFXd0II9TJLa8S/Pd1UvuRd4AYZ2yAKy2b9K+dufl7eh1Y4UIbZ69BnaSwzpdp BFKzSIo3famMRAn9k8JNKwPVkO9Bug== X-Proofpoint-ORIG-GUID: srxCYTzWeqSoLtx7c1WFURb1LhnJ9_Oj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-22_04,2025-08-20_03,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.151.68; envelope-from=mark.caveayland@nutanix.com; helo=mx0a-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1755864988990116600 Now that we can guarantee the isapc machine will never have a PCI bus, any instances of rom_memory can be replaced by system_memory and rom_memory removed completely. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Xiaoyao Li --- hw/i386/isapc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/i386/isapc.c b/hw/i386/isapc.c index 62acdada3e..87193beb44 100644 --- a/hw/i386/isapc.c +++ b/hw/i386/isapc.c @@ -37,7 +37,6 @@ static void pc_init_isa(MachineState *machine) ISABus *isa_bus; GSIState *gsi_state; MemoryRegion *ram_memory; - MemoryRegion *rom_memory =3D system_memory; DriveInfo *hd[MAX_IDE_BUS * MAX_IDE_DEVS]; uint32_t irq; int i; @@ -76,7 +75,7 @@ static void pc_init_isa(MachineState *machine) =20 /* allocate ram and load rom/bios */ if (!xen_enabled()) { - pc_memory_init(pcms, system_memory, rom_memory, 0); + pc_memory_init(pcms, system_memory, system_memory, 0); } else { assert(machine->ram_size =3D=3D x86ms->below_4g_mem_size + x86ms->above_4g_mem_size); --=20 2.43.0