From nobody Sat Nov 15 05:17:04 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1755870924; cv=none; d=zohomail.com; s=zohoarc; b=KDiZpHw+dtr8HznjZPoU39s44jqnDwLC/e8Ye3mn6szQKEVN3UqzHo43NmFH4SKkonmHkWgrrfi7Mfg+X72vqSNd3MsOpNPhhQmiJPAOgrjrhIef9+St96grjHtGxzZx3LwJx9RZP7tNbVLPVOulps9d7VxKsWPtb1eCfePziK4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1755870924; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=vh5PW27wq4M7UAgJQHpY8LHqZa1HVp12yT5xQoyQ7OE=; b=RfXnBdDSwm6anqAWLWgdlr4T/VMRl5hpDHU2wblLs5LawXK0YsvG7ha2uw2xwMa+PL2ZP0wFeDXCIsTV28sAhOhIZ3gsvkrz0QZWSUm7p5RJXdLUBYuz1ChDZtO4+I0mYisNoQQiokn/8u3uRRJB2HrNhc4UFJmYvNdVAavpEnQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1755870924674429.07937563810947; Fri, 22 Aug 2025 06:55:24 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1upSDP-0005sv-Um; Fri, 22 Aug 2025 09:53:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upO1z-00063w-Oz for qemu-devel@nongnu.org; Fri, 22 Aug 2025 05:25:55 -0400 Received: from mail-pg1-x52a.google.com ([2607:f8b0:4864:20::52a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1upO1u-0007HH-4F for qemu-devel@nongnu.org; Fri, 22 Aug 2025 05:25:55 -0400 Received: by mail-pg1-x52a.google.com with SMTP id 41be03b00d2f7-b47175d02dcso1480337a12.3 for ; Fri, 22 Aug 2025 02:25:48 -0700 (PDT) Received: from warg.hq.igel.co.jp (napt.igel.co.jp. [219.106.231.132]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-245ed4c6fb7sm78560215ad.89.2025.08.22.02.25.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Aug 2025 02:25:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=igel-co-jp.20230601.gappssmtp.com; s=20230601; t=1755854746; x=1756459546; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vh5PW27wq4M7UAgJQHpY8LHqZa1HVp12yT5xQoyQ7OE=; b=DE2oWXZ2aGdAGKT9Je46/ChaN2UK301u/Fg2GH9etR1f1kbpIXdQiauuwHTp7nXeiG AFMSCKpEJC0ELUQV6kfG0oFEcW34txbkT67WlZ/07Rf62rV8CghV4WiytBdH81lTHs2m LOzwZFuZ7+lAP6w6Jx2POBYb9YyhX/79T63Vgs1+hYbrhuW9Giw6C3RF5JtxLJjh2YrO XDToyH7O2Wbr5X8i8KLR9mgO9CV9LOYj2exkI80/sCYDm/rdwBKFDYiQKA4D9iLrJJIO GBrg+ijM6ByFdO7cFTMTB8b/RyhLSHTt6BzylfRabKZsz4FlxIKKY+IhYd07bmHddV7a 1THQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755854746; x=1756459546; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vh5PW27wq4M7UAgJQHpY8LHqZa1HVp12yT5xQoyQ7OE=; b=cdcXyUTBQvBbob8RMASGyY+WJf7fh3P/SGMnIKTYsVivIGJSZOpSMLI+esXFI+Fc/B N11tw30z2MzYglah+L7P4EVEIh+CarjU9QxobvcNQIWmdccstjjmh2OVInKE63xEbl/f 0vL4X/QlPgOLykeX39aNqnk9udI7iIETiMJG5mOyiaqRoK/LfQ/4rDD+mHT7Rky7pRRi n7CvOHrdmwrJdhhuqPzvf5pyfG4uIN3q5LrHrf4aWBImDQCr6bnHf22SNe5RDxnfQjRE GBl6H/i1KajCH5y5FpNkydYEEQ5LLPlK4NzAaiJh/WVvVwAIuEFLMf+CtdBYJAzvfaHJ Ko5g== X-Gm-Message-State: AOJu0YxPWUARNEJ2RlyXZXoO7JDjT7chwBrzSp+O0JP5oyKUBMtXgo4A VFmk5E1OINPCUfwtBwGYQO9bHgDx4iG02YIqKHzHfSUpnR/ZF8BVTiDT5L7xIukwVWz64M86jbW HEw3p3nQ= X-Gm-Gg: ASbGnctqDJbnzlTlUlxcM0rO0pdGZ6ViHFDKiGc9pHTnIOOZsidyh2FTP6LvJKN3EvW nVhZWCTdIqpAFi/V/ldXdyimHpU7pS4Bi53Ya9ZZ2xUVP2OZe+mnmaVlAT74RlJF/OBV7+cp2m9 p/LG4a69t2r/q0TM8WULHJX1hbheZjKt8Yb1fBjGubBZQ6V1ItjFtGpgx1z7dqj82UVmLYM1/PA 5Gwl2opjJjH+71g/IjQ0XRJs7sTCBEi2WbiNf3nQw0slvUsdKztxvHpZIn+yRek73O/JTNEF/O1 9n5TgHTCZuodv9eX3FhpKQe2KB6K3HwThdyzIxbJKOl9s6F6wvQ/AVPGKDhDZtv6fsSIfNA9cHR 0AEz4dN0nnt+1IjU786jgQ8V1DIt8Wd4fb19i3a///Q== X-Google-Smtp-Source: AGHT+IFqrkDmltRg7rBvuIoosHiBNJHGiYIXbN8rlbL3FhYZHp7oXOt3yH4etsE7arp7mbrFo0zW5g== X-Received: by 2002:a17:902:f68e:b0:243:7cf:9bcf with SMTP id d9443c01a7336-2462ee0be0bmr37041655ad.2.1755854746463; Fri, 22 Aug 2025 02:25:46 -0700 (PDT) From: CJ Chen To: qemu-devel@nongnu.org, qemu-block@nongnu.org, qemu-riscv@nongnu.org, qemu-arm@nongnu.org Cc: Paolo Bonzini , Keith Busch , Klaus Jensen , Jesper Devantier , Palmer Dabbelt , Alistair Francis , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , Tyrone Ting , Hao Wu , Max Filippov , Peter Xu , David Hildenbrand , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Fabiano Rosas , Laurent Vivier , Tomoyuki Hirose , Peter Maydell , CJ Chen Subject: [RFC PATCH v2 7/9] system/memory: assert on invalid unaligned combo Date: Fri, 22 Aug 2025 18:24:08 +0900 Message-Id: <20250822092410.25833-8-cjchen@igel.co.jp> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250822092410.25833-1-cjchen@igel.co.jp> References: <20250822092410.25833-1-cjchen@igel.co.jp> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::52a; envelope-from=cjchen@igel.co.jp; helo=mail-pg1-x52a.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Fri, 22 Aug 2025 09:53:58 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @igel-co-jp.20230601.gappssmtp.com) X-ZM-MESSAGEID: 1755870927450124100 Content-Type: text/plain; charset="utf-8" When it comes to this pattern: .valid.unaligned =3D false and impl.unaligned =3D true, is effectlvely contradictory. The .valid structure indicates that unaligned access should be rejected at the access validation phase, yet .impl suggests the underlying device implementation can handle unaligned operations. As a result, the upper-layer code will never even reach the .impl logic, leading to confusion. Signed-off-by: CJ Chen Tested-by: CJ Chen Suggested-by: Peter Xu Acked-by: Tomoyuki Hirose Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- system/memory.c | 1 + 1 file changed, 1 insertion(+) diff --git a/system/memory.c b/system/memory.c index d6071b4414..b536a62ce9 100644 --- a/system/memory.c +++ b/system/memory.c @@ -1654,6 +1654,7 @@ void memory_region_init_io(MemoryRegion *mr, const char *name, uint64_t size) { + g_assert(!ops || !(ops->impl.unaligned && !ops->valid.unaligned)); memory_region_init(mr, owner, name, size); mr->ops =3D ops ? ops : &unassigned_mem_ops; mr->opaque =3D opaque; --=20 2.25.1