From nobody Sat Nov 15 05:17:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1755871104; cv=none; d=zohomail.com; s=zohoarc; b=UtkECT4k6rOW16fvc8TPLrTHdfFT9zY72Fd2qwDd+ljgTJHN50onFsQ5ATaDTvE6/ahya7fns3dXjY2UvzXCCf+f3JvZZIKVs3ycirN7irP2lQCC69Pwg/p9jU6qjRP25+8QYroTFqpQFZhgCJEvIU70uJ/qL3qjXZta7wu/02w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1755871104; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=mlo0VNE2LkX+k6ixV83bmWbI8LIl4VVBBmVNmXeQQcY=; b=jABhYJDyDezfaFlFJ98bOZZCsk8oYwcvK6Ai1J1OaRQwKnG63dpE+MM5BUcr+hGMc3wpVaFj0ebqjSzWM7ErJDziUUb7UhTRaVsFbi77vBPHK8wL7RxNt1X0q0ew40gTTtYBInXY04FE9idl1YZu50G/O1dxsA1NYaDIsAr6bmw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1755871104255861.7257474094797; Fri, 22 Aug 2025 06:58:24 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1upSDW-0005vP-J9; Fri, 22 Aug 2025 09:54:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1upO1Q-0005cm-1M for qemu-devel@nongnu.org; Fri, 22 Aug 2025 05:25:20 -0400 Received: from mail-pg1-x535.google.com ([2607:f8b0:4864:20::535]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1upO1M-000792-Cj for qemu-devel@nongnu.org; Fri, 22 Aug 2025 05:25:19 -0400 Received: by mail-pg1-x535.google.com with SMTP id 41be03b00d2f7-b49c622e598so137810a12.1 for ; Fri, 22 Aug 2025 02:25:15 -0700 (PDT) Received: from warg.hq.igel.co.jp (napt.igel.co.jp. [219.106.231.132]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-245ed4c6fb7sm78560215ad.89.2025.08.22.02.25.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Aug 2025 02:25:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=igel-co-jp.20230601.gappssmtp.com; s=20230601; t=1755854714; x=1756459514; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mlo0VNE2LkX+k6ixV83bmWbI8LIl4VVBBmVNmXeQQcY=; b=gHlpWm/esdPlDf6OBTQA7j9IL58URUKNJ0ypl7KeyPyy08LqL136YGcVIR5dnkvhRM D31OB5pb2A36D7g9zEb8ePHOJPr7cdsNh17PgXh4SQaLp6GvjkAuKeD1qVoL2XvDPueB LmmTrstfjrYf8b+fKHtwP01Ch/obmqPSUI5hebbJ86QYdt0qHVYzHlQsa3u+1z5AiF/k nyyE5JhkLvgRS/cOnxTLmoMavA4IARyEM0sbEzJdzHfZqnQwAOXJtF2AvR8QnPmHnpY+ 80ufSJoKrpnPDXps6WynkWrmvAtTbD+qjVzBLInJun54WGVFd8lC2xmW+hhRGTPUaCmq fY2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755854714; x=1756459514; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mlo0VNE2LkX+k6ixV83bmWbI8LIl4VVBBmVNmXeQQcY=; b=v4TtVMhs1NzXghMduwyd2VdC7j31A0Oi5mAKxA9zvh/Yq9u8tsu5QLDqKuUXkXq7a/ birS3llMyzz/cTLFPiSIQh06x5QZppScz3Icy2P2ODEhGAI31vjRfzlUUY0+b1nH2788 HaDnlCu5UybNFxlJj/DiEaeONrpQOyUuF2ELkmK/erBxZuDEC8V79KPZbvaWcXXux1Kh VZRMFHz8C58lKMXB+F2/i/eV0kn3/7a6L+ucsZn0L5Sjus50WspNMPpIRXcMymqOYja3 ofk1ajT3YOBmGD6QZuSbrRoQZG/LIf5hzMNabhIMFPeF7OHLnc1OjRiKezSph5OMD292 zr2Q== X-Gm-Message-State: AOJu0YxzE7kRNh+QgXb5W4Wc+rqPlE4UmXN1rJRm8PI8bGXv59Yw7WX9 EVdm8tspIbXPTsgbnhZO1Epm6/5dWFO1IQKEUliFiHQ1lWSO8/bEEnmO5PRO4AIwUCGTCkA4bpI SOX3IkIk= X-Gm-Gg: ASbGncvlesa3rpUoGqKN1YPQ8ul8yyhFscQ2vmUVY3UBlvsUB2kANyH4PuowY0p3JnS Edq2pcXZGFveKrMccyZr/jdIFhRWn8u9rhtH5bsLvRyaNxHgAYCFgoAxVJv1ednOdBHLV6lwAZd RYH3VssI1HhnKcvquK1vAlkdZkb26lbDr0MvoWR805vPBWDXEoQ+X8DKg+0SEOU/noA6iIWlHms m9r/3fUXtJ6LAR4qcRBgw8Z3YThKE5VqUqv2Eq1wuCrWj1TjLLW7DBHasZfrBB8K63n76Xt1Icg aRFOl/2zju5xIx+JsjgpjaPrTWsEnssgVZJ5K8hAtSdhdcjox7tLLwJg5rp2/Va0HYoQgQQ+5pQ hVeuhrCVglAa/FQbFcKBLlKpuOQu1IgpZJyb2nk2+EwoSWXicV8dP+l0EXciVbQQ= X-Google-Smtp-Source: AGHT+IEqxrEnh0zkYioghUeAJylIvzfIK34NEJeRhP+7uR5uCgzNq3nYAwgrwA28HLoaAtq27/RD1g== X-Received: by 2002:a17:903:2302:b0:240:3b9e:dd4c with SMTP id d9443c01a7336-2462ef446b7mr34309165ad.36.1755854714249; Fri, 22 Aug 2025 02:25:14 -0700 (PDT) From: CJ Chen To: qemu-devel@nongnu.org, qemu-block@nongnu.org, qemu-riscv@nongnu.org, qemu-arm@nongnu.org Cc: Paolo Bonzini , Keith Busch , Klaus Jensen , Jesper Devantier , Palmer Dabbelt , Alistair Francis , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , Tyrone Ting , Hao Wu , Max Filippov , Peter Xu , David Hildenbrand , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Fabiano Rosas , Laurent Vivier , Tomoyuki Hirose , Peter Maydell , CJ Chen Subject: [RFC PATCH v2 2/9] hw/riscv: iommu-trap: remove .impl.unaligned = true Date: Fri, 22 Aug 2025 18:24:03 +0900 Message-Id: <20250822092410.25833-3-cjchen@igel.co.jp> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250822092410.25833-1-cjchen@igel.co.jp> References: <20250822092410.25833-1-cjchen@igel.co.jp> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::535; envelope-from=cjchen@igel.co.jp; helo=mail-pg1-x535.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Fri, 22 Aug 2025 09:53:58 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @igel-co-jp.20230601.gappssmtp.com) X-ZM-MESSAGEID: 1755871104912116600 Content-Type: text/plain; charset="utf-8" Since riscv-iommu does not support unaligned accesses, drop `.impl.unaligned =3D true` to avoid the contradictory pairing with `.valid.unaligned =3D false`. This makes QEMU reject unaligned accesses for this device and prevents the assertion in memory.c that previously caused `make check` to fail. Signed-off-by: CJ Chen Tested-by: CJ Chen Acked-by: Tomoyuki Hirose Reported-by: Tomoyuki Hirose Reviewed-by: Daniel Henrique Barboza --- hw/riscv/riscv-iommu.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/riscv/riscv-iommu.c b/hw/riscv/riscv-iommu.c index a877e5da84..277746598a 100644 --- a/hw/riscv/riscv-iommu.c +++ b/hw/riscv/riscv-iommu.c @@ -2288,7 +2288,6 @@ static const MemoryRegionOps riscv_iommu_trap_ops =3D= { .impl =3D { .min_access_size =3D 4, .max_access_size =3D 8, - .unaligned =3D true, }, .valid =3D { .min_access_size =3D 4, --=20 2.25.1