From nobody Sat Nov 1 01:30:32 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1755791134; cv=none; d=zohomail.com; s=zohoarc; b=W+0/jLdJM2TG5l9go7tvyNa8M2BSZa4nwoIiIlmKt+DBoO6wAMFR7uV0zA97fdEyTZdbR0bV0lAY20uCXexamSqZOoYj9HsNteRQWaNQRKTeC6zzAh7ykrcq/kscpyqJod+3W1qZ47TCdlrp3uo+QO3UtOk2B641pGwMjsqTUn8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1755791134; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=9TBVPD6oa19o0Rlf8ysqop9Irol7X6lGtL0OpntaIok=; b=Wn9cYnCqQoW5t1D4mZp1fMB+d0AbmCukFGcwIg9CJc3zPFi68+e/qAf5pyw3pc32eFuez8ZJaQS+6r4XeDBrzzcI0tkr8WFttVKaBac2h6dSGM+sZCH8G21aEM3BWlyjyf0pVTazNWWERRYeNEEeZveIiX0quioMoEBGdeE5/hw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 175579113411280.18941304469308; Thu, 21 Aug 2025 08:45:34 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1up7Te-0003Rk-RS; Thu, 21 Aug 2025 11:45:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1up7TU-0003NQ-5e for qemu-devel@nongnu.org; Thu, 21 Aug 2025 11:45:15 -0400 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1up7TL-0007Ip-C0 for qemu-devel@nongnu.org; Thu, 21 Aug 2025 11:45:09 -0400 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-45a1b0cd668so6066075e9.3 for ; Thu, 21 Aug 2025 08:45:02 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3c4c218c6c2sm2838429f8f.66.2025.08.21.08.45.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Aug 2025 08:45:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755791101; x=1756395901; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=9TBVPD6oa19o0Rlf8ysqop9Irol7X6lGtL0OpntaIok=; b=T1/9MW9RtSJ3mpVmiJFF+OWyzVwyKRei0qvmbMtma//USyhUzEUoaOVKoF4DC2LqU5 RgLa+nqZCPrdbXXVj7FmOn7qIdDOdySgT0AkQn3mCpJtWV/Z2VX96z11fIlRn1YwiGTa RiVKYTz59zggQrtUARqUW5LzyBkK3E5kN446l4ikC9onwYbh7/M0ok2iLaeuKF3oLSkf jn0yy/C+2CS4yKzXSrmsaO4WRmXlD2WZrNm8Q1myinpFwTZxkI8pfvM9qZbc1sYUVqex Hf6VqvRvGauO/9rOTQUEr5rgtDyW4+rSr2g9Gdr9HqvuXP058aF5DROMwB79PFtkCYlH raVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755791102; x=1756395902; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9TBVPD6oa19o0Rlf8ysqop9Irol7X6lGtL0OpntaIok=; b=dtMGDkiV8UowdFJZ84FVzfgxFGaRacq0r/4b0B4z1vIZLO8UfjH/kN5gTn3BmJI53p I4yLe6SSqYw7WCEJ/2tmqZY4AQcNyZOq2Ej/SbZk7RQZQavLPIkoroySQm38tgjnhkhK X3a9YZMmlK+Ac85WwXqXu8ORxIGEX/jrOTwjgTvao6F1p5mAxjsfSTopH7R1GVDs3Oqp 7+/0QGlMw/6kSuReI4ZVhvp+6885X436Jp5IJpH8ZHsQVu33Zy92zFT35Pja0x8T3/bs F6d2usa+nuHGF1jFjOTrC8Vo2D7xP0ICVA41Nfk9476wMFMrgsSbdbByxlVOAbX6sDTK bR/Q== X-Forwarded-Encrypted: i=1; AJvYcCWdZA6ZyPD9vPfjH33JAv6PkXqyvbDWzcLztZ6gkww3qC0f1l0+CMnouJv/SLqZTMrKsCGyZHH11wHm@nongnu.org X-Gm-Message-State: AOJu0YzTdB4lv7nxRmYX5mpvGoE3G2euSsKoctbx/mRe+L2GWPDV7X79 n+V+MFZDv7SfsjbYsRT69UlwUE+J9ebL821P1yRIh5YwK4xZpzR6a4Q91TvtkrcjJDaJvwwAAVo mc8S+ X-Gm-Gg: ASbGncvlt+Mf8FmORdbZDoHop5nLp+VdVyI8vXOqA/ZjcaOaRndrTTdwY7+7uVJzaE+ NqfnBJTj1QE1QaFwWpCVM57cj1lKtXRoeWgf3muO6mufpfjgE7vi+P9RZ+yJl9zlX9qohuTlXU7 waehsY3I+a4x9X81eyeV7gc/C3Ni5x7GMJE4v/Hrya0PC2NBS2PiBEjLbjIyFLPVt7OAvFQM/9P vinBm/a2ZwPk06EoRe7MYjGYIyJMmdyhmkOl8dMEqdjSvFWEyzpvgWWcYzdxyo9AcPMkW7qOYxN yvbJFTyzMYunF5PzldbtlXJZDhgd/VIxq7IxvykHXUhXz4gm8UteBLGq9a41kNmJK0VwTAcqhN7 rF/T+ADK/TtT60K94f4HGi7ojUE2fjzilTWs14U8= X-Google-Smtp-Source: AGHT+IH0B7xZKjjroXLrapu7eouajRrB/DQ7DauPcYFTXVv2EqvOYauFvjaNNi9gqr+oNTaDTdnXIQ== X-Received: by 2002:a05:600c:1c0d:b0:456:19be:5e8 with SMTP id 5b1f17b1804b1-45b4d830ae6mr25088515e9.20.1755791101588; Thu, 21 Aug 2025 08:45:01 -0700 (PDT) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, Glenn Miles Subject: [PATCH] hw/gpio/pca9554: Avoid leak in pca9554_set_pin() Date: Thu, 21 Aug 2025 16:44:59 +0100 Message-ID: <20250821154459.2417976-1-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1755791134948116600 Content-Type: text/plain; charset="utf-8" In pca9554_set_pin() we have a string property which we parse in order to set some non-string fields in the device state. So we call visit_type_str(), passing it the address of the local variable state_str. visit_type_str() will allocate a new copy of the string; we never free this string, so the result is a memory leak, detected by ASAN during a "make check" run: Direct leak of 5 byte(s) in 1 object(s) allocated from: #0 0x5d605212ede3 in malloc (/mnt/nvmedisk/linaro/qemu-from-laptop/qemu= /build/arm-asan/qemu-system-arm+0x21f1de3) ( BuildId: 3d5373c89317f58bfcd191a33988c7347714be14) #1 0x7f7edea57b09 in g_malloc (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0= x62b09) (BuildId: 1eb6131419edb83b2178b68282 9a6913cf682d75) #2 0x7f7edea6d4d8 in g_strdup (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0= x784d8) (BuildId: 1eb6131419edb83b2178b68282 9a6913cf682d75) #3 0x5d6055289a91 in g_strdup_inline /usr/include/glib-2.0/glib/gstrfun= cs.h:321:10 #4 0x5d6055289a91 in qobject_input_type_str /mnt/nvmedisk/linaro/qemu-f= rom-laptop/qemu/build/arm-asan/../../qapi/qo bject-input-visitor.c:542:12 #5 0x5d605528479c in visit_type_str /mnt/nvmedisk/linaro/qemu-from-lapt= op/qemu/build/arm-asan/../../qapi/qapi-visit -core.c:349:10 #6 0x5d60528bdd87 in pca9554_set_pin /mnt/nvmedisk/linaro/qemu-from-lap= top/qemu/build/arm-asan/../../hw/gpio/pca9554.c:179:10 #7 0x5d60549bcbbb in object_property_set /mnt/nvmedisk/linaro/qemu-from= -laptop/qemu/build/arm-asan/../../qom/object.c:1450:5 #8 0x5d60549d2055 in object_property_set_qobject /mnt/nvmedisk/linaro/q= emu-from-laptop/qemu/build/arm-asan/../../qom/qom-qobject.c:28:10 #9 0x5d60549bcdf1 in object_property_set_str /mnt/nvmedisk/linaro/qemu-= from-laptop/qemu/build/arm-asan/../../qom/object.c:1458:15 #10 0x5d605439d077 in gb200nvl_bmc_i2c_init /mnt/nvmedisk/linaro/qemu-f= rom-laptop/qemu/build/arm-asan/../../hw/arm/aspeed.c:1267:5 #11 0x5d60543a3bbc in aspeed_machine_init /mnt/nvmedisk/linaro/qemu-fro= m-laptop/qemu/build/arm-asan/../../hw/arm/aspeed.c:493:9 Make the state_str g_autofree, so that we will always free it, on both error-exit and success codepaths. Cc: qemu-stable@nongnu.org Fixes: de0c7d543bca ("misc: Add a pca9554 GPIO device model") Signed-off-by: Peter Maydell Reviewed-by: Glenn Miles Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/gpio/pca9554.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/gpio/pca9554.c b/hw/gpio/pca9554.c index de3f883aee9..eac0d23be34 100644 --- a/hw/gpio/pca9554.c +++ b/hw/gpio/pca9554.c @@ -174,7 +174,7 @@ static void pca9554_set_pin(Object *obj, Visitor *v, co= nst char *name, PCA9554State *s =3D PCA9554(obj); int pin, rc, val; uint8_t state, mask; - char *state_str; + g_autofree char *state_str =3D NULL; =20 if (!visit_type_str(v, name, &state_str, errp)) { return; --=20 2.43.0