From nobody Sat Nov 15 03:13:40 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1755769759; cv=none; d=zohomail.com; s=zohoarc; b=dcfBLXsEKLtIGYSLXXZDxFvfPv3siPC/XNzW/I4mqPqTYJ3Z0NkqBRro6/VUFHMt7CTPNeTxqQx/qnQRBMWDrOps22KIX4NNvEFGan6Jw5LfK40dO5r2owujW4madCWOGye3pB+bKgmhwQuv3/IuF2y4mtKUG1crGqpPheg7tfE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1755769759; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=yJv9AVcPmULD62NGzS++wKzayuNoXdj66VzLzZU9Bqc=; b=VRLcm/GWq9mLTjTtx09rjjarTkpE9af7jkEoMfr4N8ZZDtzMjYfWwph3YciMz1WZHWo0GB6OhWhI3Tpyt8azveEwtmHwlAqWsDE2MppdPl+frNSHG42tHshtyJwhyEDGmm0uqFSXtNPUtDlM7OZDUHDzPxXuP7KsAwX2nLtfJp0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1755769759822546.0818324954331; Thu, 21 Aug 2025 02:49:19 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1up1ti-0000p3-Vp; Thu, 21 Aug 2025 05:47:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1up1tg-0000ov-Gh for qemu-devel@nongnu.org; Thu, 21 Aug 2025 05:47:52 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1up1tc-0002WH-K9 for qemu-devel@nongnu.org; Thu, 21 Aug 2025 05:47:51 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-56-zVCKZcVzOAS4tEdacKDPiw-1; Thu, 21 Aug 2025 05:47:40 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DFFD11800285; Thu, 21 Aug 2025 09:47:38 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.45.224.166]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5C554180044F; Thu, 21 Aug 2025 09:47:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1755769664; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=yJv9AVcPmULD62NGzS++wKzayuNoXdj66VzLzZU9Bqc=; b=AZhcIdFqaLqaPnv0IkZ9cCvRqntb8t5dnlihcc84YDTjHWdxlyUOQMPypP/i4MMxwe0dWg jtW1oBpwYIbniiRZVPRnNqTZluQUo/q7Zz/KePN9VHi9z5asfQnolQOYsoFJms0Gxu6ZQ3 Uk4gRO+gg1MBaveu1Trd4CI9fif9KVk= X-MC-Unique: zVCKZcVzOAS4tEdacKDPiw-1 X-Mimecast-MFC-AGG-ID: zVCKZcVzOAS4tEdacKDPiw_1755769659 From: Thomas Huth To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH] tests/functional: Use more fine-grained locking when looking for free ports Date: Thu, 21 Aug 2025 11:47:35 +0200 Message-ID: <20250821094735.804210-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1755769761319116600 Content-Type: text/plain; charset="utf-8" From: Thomas Huth Currently, we have one lock that is held while a test is looking for free ports. However, we are also using different ranges for looking for free ports nowadays (PORTS_START is based on the PID of the process), so instead of using only one lock, we should rather use a lock per range instead. This should help to allow running more tests in parallel. While we're at it, also create the lock files without executable bit (mode is 0o777 by default). Signed-off-by: Thomas Huth Reviewed-by: Daniel P. Berrang=C3=A9 --- tests/functional/qemu_test/ports.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/functional/qemu_test/ports.py b/tests/functional/qemu_te= st/ports.py index 631b77abf6b..81174a61532 100644 --- a/tests/functional/qemu_test/ports.py +++ b/tests/functional/qemu_test/ports.py @@ -23,8 +23,9 @@ class Ports(): PORTS_END =3D PORTS_START + PORTS_RANGE_SIZE =20 def __enter__(self): - lock_file =3D os.path.join(BUILD_DIR, "tests", "functional", "port= _lock") - self.lock_fh =3D os.open(lock_file, os.O_CREAT) + lock_file =3D os.path.join(BUILD_DIR, "tests", "functional", + f".port_lock.{self.PORTS_START}") + self.lock_fh =3D os.open(lock_file, os.O_CREAT, mode=3D0o666) fcntl.flock(self.lock_fh, fcntl.LOCK_EX) return self =20 --=20 2.50.1