From nobody Sat Nov 15 03:05:04 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=FreeBSD.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1755719610162464.57377423708795; Wed, 20 Aug 2025 12:53:30 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uoorg-0007rh-Ca; Wed, 20 Aug 2025 15:52:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uolZT-00025p-QI for qemu-devel@nongnu.org; Wed, 20 Aug 2025 12:21:55 -0400 Received: from 2001-b011-3808-3444-a66b-b6ff-fe3d-469a.dynamic-ip6.hinet.net ([2001:b011:3808:3444:a66b:b6ff:fe3d:469a] helo=llvm) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uolZR-0006Fn-VV for qemu-devel@nongnu.org; Wed, 20 Aug 2025 12:21:55 -0400 Received: from blast (uid 1001) (envelope-from blast@llvm) id 2abde by llvm (DragonFly Mail Agent v0.13+ on llvm); Wed, 20 Aug 2025 12:16:41 -0400 From: ShengYi Hung To: qemu-devel@nongnu.org Cc: Paolo Bonzini , "Michael S. Tsirkin" , ShengYi Hung Subject: [PATCH] ii6300esb: fix incorrect mask for interrupt type Date: Wed, 20 Aug 2025 12:16:41 -0400 Message-ID: <20250820161641.25789-1-aokblast@FreeBSD.org> X-Mailer: git-send-email 2.50.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=2001:b011:3808:3444:a66b:b6ff:fe3d:469a; envelope-from=blast@llvm; helo=llvm X-Spam_score_int: 29 X-Spam_score: 2.9 X-Spam_bar: ++ X-Spam_report: (2.9 / 5.0 requ) BAYES_00=-1.9, FSL_HELO_NON_FQDN_1=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.029, HELO_NO_DOMAIN=0.001, KHOP_HELO_FCRDNS=0.4, RCVD_IN_PBL=3.335, RDNS_DYNAMIC=0.982, SPF_NONE=0.001, UNPARSEABLE_RELAY=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 20 Aug 2025 15:52:52 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1755719611381124100 Content-Type: text/plain; charset="utf-8" According to Intel 6300ESB Controller Hub Datasheet 14.4.15, the interrupt = type mask should be 0x03 (0b11) instead of 0x11. In the original implementation, when we want to disable all interrupt by setting the value to 0x03, we will get 0x01 which will be incorrect when we reading the value again. However, there is no problem since 0x1 is reserved and unused. Signed-off-by: ShengYi Hung Sponsored by: The FreeBSD Foundation --- hw/watchdog/wdt_i6300esb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/watchdog/wdt_i6300esb.c b/hw/watchdog/wdt_i6300esb.c index bb8a2766b6..3aa01b8d68 100644 --- a/hw/watchdog/wdt_i6300esb.c +++ b/hw/watchdog/wdt_i6300esb.c @@ -55,7 +55,7 @@ /* Config register bits */ #define ESB_WDT_REBOOT (0x01 << 5) /* Enable reboot on timeout = */ #define ESB_WDT_FREQ (0x01 << 2) /* Decrement frequency = */ -#define ESB_WDT_INTTYPE (0x11 << 0) /* Interrupt type on timer1 timeout = */ +#define ESB_WDT_INTTYPE (0x03 << 0) /* Interrupt type on timer1 timeout = */ =20 /* Reload register bits */ #define ESB_WDT_RELOAD (0x01 << 8) /* prevent timeout = */ --=20 2.50.1