From nobody Sat Nov 15 05:15:32 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1755678683; cv=pass; d=zohomail.com; s=zohoarc; b=I6xo53RDT2/fkXVNuKDqckZaG0lYpMup4zNVGeAh64pFTP0Nh3juibkZY3SmPriN6Lwc/gN2FzUhBlI9eibHXpdtPVlInJoAIw/urJGW87hXQ9Y4FZG7ygMRgZZvc3K17dUcis3s7f6n62ro6SXMUFCdGyT0s3mUcbkD4S80kcY= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1755678683; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Ov1YVBEp04Va5An8ZHJNWYzqc4As5VAUcKIfEggj9+8=; b=SbTo2mlYericAUifvZuIJQ3d/ApY6htqV7xwNpvSWPDjtBONbmB/8L5n65EabqEx1hsN0k8p58HFp2WUIiN6+jn1DLzxV/aj7ymm91C0i/ahr2FJN6Z6TlsX/LVzw809Pv9kDLoBh351QEh45h9bdBCNqf7HCTpbXhPHjAQsgVY= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1755678683969394.09947400673104; Wed, 20 Aug 2025 01:31:23 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uoe9f-0004LY-N7; Wed, 20 Aug 2025 04:26:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uoe9d-0004I9-M9; Wed, 20 Aug 2025 04:26:45 -0400 Received: from mail-mw2nam04on20621.outbound.protection.outlook.com ([2a01:111:f403:240a::621] helo=NAM04-MW2-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uoe9b-0000vc-86; Wed, 20 Aug 2025 04:26:45 -0400 Received: from MW4PR04CA0343.namprd04.prod.outlook.com (2603:10b6:303:8a::18) by SA0PR12MB4397.namprd12.prod.outlook.com (2603:10b6:806:93::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9052.14; Wed, 20 Aug 2025 08:26:36 +0000 Received: from CO1PEPF000075F0.namprd03.prod.outlook.com (2603:10b6:303:8a:cafe::3) by MW4PR04CA0343.outlook.office365.com (2603:10b6:303:8a::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9052.13 via Frontend Transport; Wed, 20 Aug 2025 08:26:36 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1PEPF000075F0.mail.protection.outlook.com (10.167.249.39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.9052.8 via Frontend Transport; Wed, 20 Aug 2025 08:26:36 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 20 Aug 2025 03:26:34 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.1748.10; Wed, 20 Aug 2025 01:26:33 -0700 Received: from XFR-LUMICHEL-L2.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Wed, 20 Aug 2025 03:26:32 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WHFKCs4jy5bb+ca6odA98nUZjmsFHHNZ8yA5cmfHLz3u6ZSOmHawgpW4ztWHKXaRsItrxfdwdqfjSJx9i7SBcqfGfC43Dov2O9PNaaSNiu6cjckj/oG71X7MgcNxSEFENlk2aaiQ2iJdhoemezDMtSepW0KMIb+/Mvzx/d48hGclqtcIkhD4NFfFXjzNrxmdrFAHRrsT/NKuZd/JZT2aCcmti0C4Y75exj/1EWxvpBU9wEmsmbApN3mLAi4VSLIVk6nzq2evyl4ef06GnB1DMUzsjxGMue3cA6++ESuTzfrTLxlvSjm6pPPyooB4D7730qvsUM98PbwuoDiIDvx5ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ov1YVBEp04Va5An8ZHJNWYzqc4As5VAUcKIfEggj9+8=; b=DZrCPZt3jqk8OHYJmwBfc9xTj0wLcC8wz0AbpmWO/rP4mpsJq5+i4zjD1Q/Dsam0AFgZ8CZqHQ+PEI1+vo4J7EzwgaFT9C2fRE7oAZMWMVoezxiN0mjp13s3wm87eWYH6H/TOMe/sbRMOCqWFMGxILcwB3+HmYRNmCeNsmO3lEyi4MoUZIyOCqqCtm+bZjf5TNcxzQ09Ys61qbvX4T061+f52U7nqCgSrXhes4573D/ztd+WAqR4hqtR0NziscNw//aM7r3eD9toynTO63PFinqzksN1ef4no3+oh9Vvo2fGWplXayc1wqoBEw8OLREPxlrrwA2hcOJWDLF2d2eRWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=nongnu.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ov1YVBEp04Va5An8ZHJNWYzqc4As5VAUcKIfEggj9+8=; b=4jRWpNKYmBqO8d1Up2LuODML1Rsl4S9UZUoubmfmv9FYFbUaSxar8Xd1d2s+jfZqVNS/85HpetjR2xjvPujArQHgGEQc2JqrCFCtFoKSAqX25jTDrGR+oro+Dn8m6UUl0b1+Dr+e6RQH2jJkfEfoIGBLHerrxII+v8dRBMYQBgM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Luc Michel To: , CC: Luc Michel , Peter Maydell , Francisco Iglesias , "Edgar E . Iglesias" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alistair Francis , "Frederic Konrad" , Sai Pavan Boddu Subject: [PATCH v2 13/47] hw/arm/xlnx-versal: PMC IOU SCLR: refactor creation Date: Wed, 20 Aug 2025 10:25:12 +0200 Message-ID: <20250820082549.69724-14-luc.michel@amd.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250820082549.69724-1-luc.michel@amd.com> References: <20250820082549.69724-1-luc.michel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000075F0:EE_|SA0PR12MB4397:EE_ X-MS-Office365-Filtering-Correlation-Id: dd70e8da-64a2-4c6e-b120-08dddfc3472b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|376014|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?ZntWZjrHeNh12K18MsKVjLt6gdiJdGVimr2kkEBTnvzz5OuJeH99kVTlOahV?= =?us-ascii?Q?LLGeJhVnvDZszHwHrkIS9JKKUwOiR1Jl7fdcBt/FIiNPcahmpbiqDUvStF4Y?= =?us-ascii?Q?Z54QmF+10/FHNUNlBez2Nu/ydAr82abMk27i+Dyr2GDkr5E1YxpcP1GrQBRO?= =?us-ascii?Q?Ek59d5eaH1t1JM4D8yqqrxFnmTeLNdOhaZ4KyhBKGz9RIKiyQevQ3zydCBtF?= =?us-ascii?Q?4kWhYaEXbFIA17nZPMYqdMRHalRUWEAqKvTGy699JqYR4+HLmMRwN4BGX5tD?= =?us-ascii?Q?9U2zKO7BeCDVMRyDe2d1ZN4lb4WW0XocSO5hoM+By0esO54dbM3TK8aqlCm9?= =?us-ascii?Q?TrAtfVnIIcjMgt2poaVEbR2J8iFa0nn4rqbUiq20WMPsJg0bFRDKuezhd1mZ?= =?us-ascii?Q?yeATEO9nXC4wyl8p7Q3SNJmjV6AxjjPj4bL+zuHyzj2lCSndL4REbUEmVHQS?= =?us-ascii?Q?Euikjv5lcuhvPJYz7owhtEoODsWCJiGAsvoa9M2+LUqbKAIXgir/xhz4QQmr?= =?us-ascii?Q?ApuZf3u+h7PpvAyAgw9lwn1lfi17b9qLKr0JDxiLhRMc2bZ+IxnrDp0sSXi0?= =?us-ascii?Q?WGDejp/uoGTPy0O8m21P8aOuIGOKa6354R+h+F9TmxOOEUeCCRHzvUvZycfI?= =?us-ascii?Q?NMsN5HTZa/oyyD4wedD3+S70JhO1U3Bb72HeU6YNyRVS5H5sAUOFx1P4zfBt?= =?us-ascii?Q?IxUdIllAF6HqdqBrgXZ8/B9wrKEhau5V1PruiO8v76mdXelfyG6mzYChxM8l?= =?us-ascii?Q?hIq50Nw6PnWBNzZUZuqIZv8YbBXb2ZtODDAQwnj2pvA1yrZ6bDw2khlSgY/i?= =?us-ascii?Q?tLy0L8jo6F1xOIrrGeyHk9/bL4UgZV4dy0vTQncUXB3Y0FOy7oFZVsqT4m3O?= =?us-ascii?Q?OnSC92llQDigCHPoyy+o43am6vRywy/L+/tfN0Km7ZLDYArpLb7aD8Bzvi/T?= =?us-ascii?Q?GN6LOZpnYWXbaejE+e0jZl7Xm4UKqphUb70HhjohzGlI+mDfTZ8smIYdGhdj?= =?us-ascii?Q?U1acJ6LZEZFCAKrpuCWH8eL9WW6hDpNlLLnO3ptWDEZyP3k/yofNdTgrOurY?= =?us-ascii?Q?SSVAIMog+jeK3b45gvrVii7UXfPMYzAGkFvpN4NBagZkwDEhrNwkfhhDZ+Pu?= =?us-ascii?Q?ualfIZHzKnuMpsp/GuszrfZo9i2E3Cmuej/7Vt73xt8m44ww4qAkmLjqkGd2?= =?us-ascii?Q?2mtCMQ/Pr8du3XFdP1uJHtxDEVnwUVMsAlixgOGpHuB5cN074WXJGJlVwbJf?= =?us-ascii?Q?yuhQ+5H10mZTvjS3L8FGBf515kAoSzbpoysRsmn9zW+gk48yDVQUAbfFEj5j?= =?us-ascii?Q?fx77BW4FbYL02v0FbH9a0BxffYLT3CKX+rCpIJJ4cMlviDP7a9W3hbtRyZn+?= =?us-ascii?Q?AWXat+gpARTL4xKe1XMgkPdOSW3fSOF2OOWogtCFiJCEHtquKZpL9OfgcFIj?= =?us-ascii?Q?qBqN47GB30yoNuMu6yEBnvbCc9sj/Dgn0usnOur4AftQmaYsen0EeDTUm6zA?= =?us-ascii?Q?sgpfIouzlgJOov/mgIgy22nuwIddmoSx0X7B?= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB03.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(82310400026)(376014)(36860700013)(1800799024); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Aug 2025 08:26:36.0791 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dd70e8da-64a2-4c6e-b120-08dddfc3472b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000075F0.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4397 Received-SPF: permerror client-ip=2a01:111:f403:240a::621; envelope-from=Luc.Michel@amd.com; helo=NAM04-MW2-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1755678686378124100 Content-Type: text/plain; charset="utf-8" Refactor the PMC IOU SLCR device creation using the VersalMap structure. This is the first user of a shared IRQ using an OR gate. The OSPI controller is reconnected to the SLCR. Signed-off-by: Luc Michel Reviewed-by: Francisco Iglesias --- include/hw/arm/xlnx-versal.h | 5 ---- hw/arm/xlnx-versal.c | 48 +++++++++++++++++++++--------------- 2 files changed, 28 insertions(+), 25 deletions(-) diff --git a/include/hw/arm/xlnx-versal.h b/include/hw/arm/xlnx-versal.h index b7ef255d6fd..78442e6c2c5 100644 --- a/include/hw/arm/xlnx-versal.h +++ b/include/hw/arm/xlnx-versal.h @@ -19,11 +19,10 @@ #include "hw/intc/arm_gicv3.h" #include "hw/rtc/xlnx-zynqmp-rtc.h" #include "qom/object.h" #include "hw/nvram/xlnx-bbram.h" #include "hw/misc/xlnx-versal-crl.h" -#include "hw/misc/xlnx-versal-pmc-iou-slcr.h" #include "hw/misc/xlnx-versal-trng.h" #include "net/can_emu.h" #include "hw/misc/xlnx-versal-cfu.h" #include "hw/misc/xlnx-versal-cframe-reg.h" #include "target/arm/cpu.h" @@ -82,14 +81,10 @@ struct Versal { XlnxVersalCRL crl; } lpd; =20 /* The Platform Management Controller subsystem. */ struct { - struct { - XlnxVersalPmcIouSlcr slcr; - } iou; - XlnxZynqMPRTC rtc; XlnxVersalTRng trng; XlnxBBRam bbram; XlnxVersalCFUAPB cfu_apb; XlnxVersalCFUFDRO cfu_fdro; diff --git a/hw/arm/xlnx-versal.c b/hw/arm/xlnx-versal.c index 89c93278336..d34a36e18aa 100644 --- a/hw/arm/xlnx-versal.c +++ b/hw/arm/xlnx-versal.c @@ -33,10 +33,11 @@ #include "hw/dma/xlnx-zdma.h" #include "hw/misc/xlnx-versal-xramc.h" #include "hw/usb/xlnx-usb-subsystem.h" #include "hw/nvram/xlnx-versal-efuse.h" #include "hw/ssi/xlnx-versal-ospi.h" +#include "hw/misc/xlnx-versal-pmc-iou-slcr.h" =20 #define XLNX_VERSAL_ACPU_TYPE ARM_CPU_TYPE_NAME("cortex-a72") #define XLNX_VERSAL_RCPU_TYPE ARM_CPU_TYPE_NAME("cortex-r5f") #define GEM_REVISION 0x40070106 =20 @@ -114,10 +115,12 @@ typedef struct VersalMap { uint64_t dac_sz; uint64_t dma_src; uint64_t dma_dst; int irq; } ospi; + + VersalSimplePeriphMap pmc_iou_slcr; } VersalMap; =20 static const VersalMap VERSAL_MAP =3D { .uart[0] =3D { 0xff000000, 18 }, .uart[1] =3D { 0xff010000, 19 }, @@ -154,10 +157,12 @@ static const VersalMap VERSAL_MAP =3D { .ctrl =3D 0xf1010000, .dac =3D 0xc0000000, .dac_sz =3D 0x20000000, .dma_src =3D 0xf1011000, .dma_dst =3D 0xf1011800, .irq =3D 124, }, + + .pmc_iou_slcr =3D { 0xf1060000, OR_IRQ(121, 0) }, }; =20 static const VersalMap *VERSION_TO_MAP[] =3D { [VERSAL_VER_VERSAL] =3D &VERSAL_MAP, }; @@ -861,25 +866,28 @@ static void versal_create_efuse(Versal *s, sysbus_mmio_get_region(SYS_BUS_DEVICE(cach= e), 0)); versal_sysbus_connect_irq(s, SYS_BUS_DEVICE(ctrl), 0, map->irq); } =20 -static void versal_create_pmc_iou_slcr(Versal *s, qemu_irq *pic) +static DeviceState *versal_create_pmc_iou_slcr(Versal *s, + const VersalSimplePeriphMap= *map) { SysBusDevice *sbd; + DeviceState *dev; =20 - object_initialize_child(OBJECT(s), "versal-pmc-iou-slcr", &s->pmc.iou.= slcr, - TYPE_XILINX_VERSAL_PMC_IOU_SLCR); + dev =3D qdev_new(TYPE_XILINX_VERSAL_PMC_IOU_SLCR); + object_property_add_child(OBJECT(s), "pmc-iou-slcr", OBJECT(dev)); =20 - sbd =3D SYS_BUS_DEVICE(&s->pmc.iou.slcr); - sysbus_realize(sbd, &error_fatal); + sbd =3D SYS_BUS_DEVICE(dev); + sysbus_realize_and_unref(sbd, &error_fatal); =20 - memory_region_add_subregion(&s->mr_ps, MM_PMC_PMC_IOU_SLCR, + memory_region_add_subregion(&s->mr_ps, map->addr, sysbus_mmio_get_region(sbd, 0)); =20 - sysbus_connect_irq(sbd, 0, - qdev_get_gpio_in(DEVICE(&s->pmc.apb_irq_orgate), 2)= ); + versal_sysbus_connect_irq(s, sbd, 0, map->irq); + + return dev; } =20 static DeviceState *versal_create_ospi(Versal *s, const struct VersalOspiMap *map) { @@ -1201,10 +1209,11 @@ static void versal_unimp_irq_parity_imr(void *opaqu= e, int n, int level) "is not yet implemented\n"); } =20 static void versal_unimp(Versal *s) { + DeviceState *slcr; qemu_irq gpio_in; =20 versal_unimp_area(s, "psm", &s->mr_ps, MM_PSM_START, MM_PSM_END - MM_PSM_START); versal_unimp_area(s, "crf", &s->mr_ps, @@ -1223,27 +1232,22 @@ static void versal_unimp(Versal *s) qdev_init_gpio_in_named(DEVICE(s), versal_unimp_qspi_ospi_mux_sel, "qspi-ospi-mux-sel-dummy", 1); qdev_init_gpio_in_named(DEVICE(s), versal_unimp_irq_parity_imr, "irq-parity-imr-dummy", 1); =20 + slcr =3D DEVICE(versal_get_child(s, "pmc-iou-slcr")); gpio_in =3D qdev_get_gpio_in_named(DEVICE(s), "sd-emmc-sel-dummy", 0); - qdev_connect_gpio_out_named(DEVICE(&s->pmc.iou.slcr), "sd-emmc-sel", 0, - gpio_in); + qdev_connect_gpio_out_named(slcr, "sd-emmc-sel", 0, gpio_in); =20 gpio_in =3D qdev_get_gpio_in_named(DEVICE(s), "sd-emmc-sel-dummy", 1); - qdev_connect_gpio_out_named(DEVICE(&s->pmc.iou.slcr), "sd-emmc-sel", 1, - gpio_in); + qdev_connect_gpio_out_named(slcr, "sd-emmc-sel", 1, gpio_in); =20 gpio_in =3D qdev_get_gpio_in_named(DEVICE(s), "qspi-ospi-mux-sel-dummy= ", 0); - qdev_connect_gpio_out_named(DEVICE(&s->pmc.iou.slcr), - "qspi-ospi-mux-sel", 0, - gpio_in); + qdev_connect_gpio_out_named(slcr, "qspi-ospi-mux-sel", 0, gpio_in); =20 gpio_in =3D qdev_get_gpio_in_named(DEVICE(s), "irq-parity-imr-dummy", = 0); - qdev_connect_gpio_out_named(DEVICE(&s->pmc.iou.slcr), - SYSBUS_DEVICE_GPIO_IRQ, 0, - gpio_in); + qdev_connect_gpio_out_named(slcr, SYSBUS_DEVICE_GPIO_IRQ, 0, gpio_in); } =20 static uint32_t fdt_add_clk_node(Versal *s, const char *name, unsigned int freq_hz) { @@ -1262,10 +1266,11 @@ static uint32_t fdt_add_clk_node(Versal *s, const c= har *name, } =20 static void versal_realize(DeviceState *dev, Error **errp) { Versal *s =3D XLNX_VERSAL_BASE(dev); + DeviceState *slcr, *ospi; qemu_irq pic[XLNX_VERSAL_NR_IRQS]; Object *container; const VersalMap *map =3D versal_get_map(s); size_t i; =20 @@ -1312,17 +1317,20 @@ static void versal_realize(DeviceState *dev, Error = **errp) for (i =3D 0; i < map->num_usb; i++) { versal_create_usb(s, &map->usb[i]); } =20 versal_create_efuse(s, &map->efuse); - versal_create_ospi(s, &map->ospi); + ospi =3D versal_create_ospi(s, &map->ospi); + slcr =3D versal_create_pmc_iou_slcr(s, &map->pmc_iou_slcr); =20 + qdev_connect_gpio_out_named(slcr, "ospi-mux-sel", 0, + qdev_get_gpio_in_named(ospi, + "ospi-mux-sel", 0)); versal_create_pmc_apb_irq_orgate(s, pic); versal_create_rtc(s, pic); versal_create_trng(s, pic); versal_create_bbram(s, pic); - versal_create_pmc_iou_slcr(s, pic); versal_create_crl(s, pic); versal_create_cfu(s, pic); versal_map_ddr(s); versal_unimp(s); =20 --=20 2.50.1