From nobody Sat Nov 15 05:14:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1755678854; cv=pass; d=zohomail.com; s=zohoarc; b=LCnuG+/HoMaUgENbBdJd/XkaaSkHdevR1bfvUyJ58FKT4HpgRTd5g40n5VzIjffpeLJwsQVmGYoyoDal+GX0L03Jh2sqsDuWLAi16rlBX2G6zjqeyWzujqmUSw0O3l75jHr1iFQWY833qgxV1WSrYG7dNHSyOPcWjAalzG9paCc= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1755678854; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=kQUVuSMCimkWeSzSIIVhontBUqAnE4ykxxAfLrMegBM=; b=Rg3Ok41D3DFdJNRGHLOjMqf2Buw1cQ95qEUp4ZX0whUPv4XOu1s2nqP+ZfzyRDosfsRsAmBbxyFTUSeIDVNPGljYd6Wl9H0RizlKSTubq5EJyS/fRO72SvnEYenoh02GgNN9ZYK2XcWL1zIlS7yyET878abCg0adzQe3ll528vU= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1755678854004996.8756580471747; Wed, 20 Aug 2025 01:34:14 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uoe9a-0004GI-0O; Wed, 20 Aug 2025 04:26:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uoe9X-0004Dd-49; Wed, 20 Aug 2025 04:26:39 -0400 Received: from mail-mw2nam12on2062d.outbound.protection.outlook.com ([2a01:111:f403:200a::62d] helo=NAM12-MW2-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uoe9U-0000sh-Jz; Wed, 20 Aug 2025 04:26:38 -0400 Received: from BYAPR08CA0050.namprd08.prod.outlook.com (2603:10b6:a03:117::27) by LV2PR12MB5990.namprd12.prod.outlook.com (2603:10b6:408:170::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.25; Wed, 20 Aug 2025 08:26:29 +0000 Received: from MWH0EPF000989E5.namprd02.prod.outlook.com (2603:10b6:a03:117:cafe::57) by BYAPR08CA0050.outlook.office365.com (2603:10b6:a03:117::27) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9052.14 via Frontend Transport; Wed, 20 Aug 2025 08:26:28 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by MWH0EPF000989E5.mail.protection.outlook.com (10.167.241.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.9052.8 via Frontend Transport; Wed, 20 Aug 2025 08:26:28 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 20 Aug 2025 03:26:28 -0500 Received: from XFR-LUMICHEL-L2.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Wed, 20 Aug 2025 03:26:26 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gNSzaeTdgHAK2ZzjMAsqb8pV84LUuAwT+o9sapqG3Ll+3qnHiq3ykVHQCd+3qY49Zn4HPw995BUypIO0ZSBvavRbIvdlnRg2ZDxq9fDWs39L+MGoU0pD6s2wCz/bWfZ4NHGB3YxPZYOi6qmaGfBkkLl07hru6kxBZKqtptMiK3SBooucH8b1rX2OJSD+W9vMY1bF5RwRZK8j0Ky5fCLEpVoq9hPI9q86/LXKMCID3IzTHJj3lDgeYy91xWYV7SDa/YEQwLL/22TBfki2p2xn2T5atgOasgzh7kGWItsyHt81dv/se4MFF6ke3mcHWgdnqd/RLq3MAWBj1IqVITElNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kQUVuSMCimkWeSzSIIVhontBUqAnE4ykxxAfLrMegBM=; b=UYB/V1750s5sHz0/GqcrEpdnEoU2qmlYpntf3ytm2BS50EA0D0aaIUM7h0sYjrFd61BlCHV5uzmnoMVkzAHxpNumW1M8CBbS7cQCCzYLOyONfp7WaJvihH+32/V+DNUN1UHzoX9Zgw7XXpbAE4o/qN4udOrby32SRLhz637EJ1VGn0WAsiERNZDXqXpQMWLpW1JcDUKuYcIs5Y2n+34i0TpcWQZWfdM2ek7a6eezBTo9rd16OsO7d5uQxAcs3lbCExZMPIudDMHFVk+3rSvr70ZZUDRfGToAAZVRKCfCvMkzhAgmqSNfVeVmlYd2rinh5G3v5LgGS0WuoXHwH572uw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=nongnu.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kQUVuSMCimkWeSzSIIVhontBUqAnE4ykxxAfLrMegBM=; b=pvAMMenWFJVXqtG+Qlowvu187rZkT+4oAn8l89cjzSDWYi6QIr1/g9GnQxJ2aX1aqvYYr2CqIucNvwMYt4g8OA5v2uxNQfJ0eULIeZUsxaSofMXJJQlyt05cvKrvIY11EQa4D0MWnnRdfVIEIru1tV15Z6DfKU7MT9Ew2scaslI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Luc Michel To: , CC: Luc Michel , Peter Maydell , Francisco Iglesias , "Edgar E . Iglesias" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alistair Francis , "Frederic Konrad" , Sai Pavan Boddu Subject: [PATCH v2 10/47] hw/arm/xlnx-versal: efuse: refactor creation Date: Wed, 20 Aug 2025 10:25:09 +0200 Message-ID: <20250820082549.69724-11-luc.michel@amd.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250820082549.69724-1-luc.michel@amd.com> References: <20250820082549.69724-1-luc.michel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: None (SATLEXMB04.amd.com: luc.michel@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000989E5:EE_|LV2PR12MB5990:EE_ X-MS-Office365-Filtering-Correlation-Id: d5a68240-6f7e-48a1-e95b-08dddfc342a9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|36860700013|1800799024|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?caFIOoV6TESA2uEYg/oa0pBXfLfjLDj3YlNDVtEn+6yuj8d2fKUHzeKAMHlt?= =?us-ascii?Q?cJeG9rPk9bdFppYGvnBdg8r6+0FDMlAOQxZzkSflKmtlrgaJN5deNznQoN/6?= =?us-ascii?Q?toM/IDIEIqTEW9TSBdkKLKy1Xp11jrErodJT+1JOcBvWpL3qL3CYbJGTNZqR?= =?us-ascii?Q?/SBszA8RPeJloHhWDFy3SuoKGl6mB7FgEh11GAo1q0dBxG9ouqdZasuxcgwI?= =?us-ascii?Q?3s2XoO+rdmEyfRKEFkwSlGbuPoGTdP1O9wnsAarF9f+CcCcblWDxlkQBSK3J?= =?us-ascii?Q?qxJbWdGlRHcq/giuxAHr6ZpfCQdMBPA2ujuGhv42zzu4zaXOTm3xUwNCJ925?= =?us-ascii?Q?m5e6+YMoFusaHIR8urNb2x+xVASDSCCjqev2LVzdHsbWHbOBA0upzkB9E4/t?= =?us-ascii?Q?y0SynpQwVQdB7q7AoUGJntqRDSmGdCbEM4YSm2QOTVSoujUo56S9c43Yh1ea?= =?us-ascii?Q?EkdGShtHXSUyVZfTYSm91+odebA0jJOXbQWrAvxQVbydAU2r5EyJwIzjDTYA?= =?us-ascii?Q?8uLsX7NF8pI0zetwj9Pkng8p8n7SDqFxycCneDppH+4qj8kiHVKbqDXwRRHK?= =?us-ascii?Q?jkIzVG4tQeSNyMmmoGR7ITUpTCpHNEpKeUA2qcN2qYIIz2sB9d8nfl+iRCio?= =?us-ascii?Q?kv46lEP+90wYFHX+qjHyBEyhK+kFlV7kwZ6/yL5F8dema+DcIWMViHILrfLl?= =?us-ascii?Q?q4Jc1pg2YHAfSodJCTJro14pF1syoe1j6NGxWqIrT8Qt1feK/+S0ZfA9J5IY?= =?us-ascii?Q?XMuNOOFXNALHJQl6w5kE5rjzX3aQvORJmu45HRZiQAouIyV1SQqgU9OnQKWk?= =?us-ascii?Q?7XPGBXpnhQFfsypbrsFZD9nr5DZtVkt0rq2EbWkj8D/nu3vqvhfy53WhXxd7?= =?us-ascii?Q?rBj9KbbLWm4EAW0YWExW6rvQFoxZXLdTTOLbovTl11N8fsbl/qVkLA9nEY7N?= =?us-ascii?Q?OdKf0MfsRxN/kWcGfFtIWlhdzsKotIkfpkmYrLImUybJ2CC9L56TtVhk4RKU?= =?us-ascii?Q?ZyuhFbsGM+UPtRzv1qtTLM5AMAO9Dgeq+5OC7M5b0QMDVuK7j7/+tWDyw6qL?= =?us-ascii?Q?iVPLWa//sRF5NtZSi6L8xHvO47yf8XaMCfd+xxk3eeaW1EG7GLNEpxNx6j9X?= =?us-ascii?Q?bfhXPJ2A3H/crAeZu0JwK02ANmj6wmgNKJmPlIdkhVzrayJHlttxUV5+Eeyz?= =?us-ascii?Q?lA7BMhOeBl/dvM1Yh/Yz/8KFQxh5tOUC66BIvEUS1s6uGP2c8W9/pqND2geg?= =?us-ascii?Q?snciarp0e8CpI3r7MINSKbq5nqKb+MOHTW8a+9D9gSg0arsaJAFsvQ+6hzpK?= =?us-ascii?Q?X5aUd5vBMQO4gVwbwkb2CGqvcr2a7ebAcXLxJAZJLV172pXn7RtlaMTJOKE/?= =?us-ascii?Q?u8Ga385/aJ8DpwdC8xvPydk5vTqUq+hXk0r5NcLznq7r05w7mT014w87/uEd?= =?us-ascii?Q?9kAVqJ5dkeT3MRyJDKYVZkDwKgvRji95MXKrtwV4IV5RVVdZzo/vuBMBapNG?= =?us-ascii?Q?hQMzLMYtscMU07/eHqSkX2mZxZRlDsMbwZUn?= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(376014)(36860700013)(1800799024)(82310400026); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Aug 2025 08:26:28.5180 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d5a68240-6f7e-48a1-e95b-08dddfc342a9 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000989E5.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5990 Received-SPF: permerror client-ip=2a01:111:f403:200a::62d; envelope-from=Luc.Michel@amd.com; helo=NAM12-MW2-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1755678856470116600 Content-Type: text/plain; charset="utf-8" Refactore the eFuse devices creation using the VersalMap structure. Note that the corresponding FDT nodes are removed. They do not correspond to any real node in standard Versal DTBs. No matching drivers exist for them. Signed-off-by: Luc Michel Reviewed-by: Francisco Iglesias --- include/hw/arm/xlnx-versal.h | 5 +-- hw/arm/xlnx-versal-virt.c | 43 ++------------------ hw/arm/xlnx-versal.c | 78 +++++++++++++++++++++++------------- 3 files changed, 54 insertions(+), 72 deletions(-) diff --git a/include/hw/arm/xlnx-versal.h b/include/hw/arm/xlnx-versal.h index 5d4b30f0ff9..79ca9b13321 100644 --- a/include/hw/arm/xlnx-versal.h +++ b/include/hw/arm/xlnx-versal.h @@ -18,11 +18,10 @@ #include "hw/or-irq.h" #include "hw/intc/arm_gicv3.h" #include "hw/rtc/xlnx-zynqmp-rtc.h" #include "qom/object.h" #include "hw/nvram/xlnx-bbram.h" -#include "hw/nvram/xlnx-versal-efuse.h" #include "hw/ssi/xlnx-versal-ospi.h" #include "hw/dma/xlnx_csu_dma.h" #include "hw/misc/xlnx-versal-crl.h" #include "hw/misc/xlnx-versal-pmc-iou-slcr.h" #include "hw/misc/xlnx-versal-trng.h" @@ -100,13 +99,10 @@ struct Versal { } iou; =20 XlnxZynqMPRTC rtc; XlnxVersalTRng trng; XlnxBBRam bbram; - XlnxEFuse efuse; - XlnxVersalEFuseCtrl efuse_ctrl; - XlnxVersalEFuseCache efuse_cache; XlnxVersalCFUAPB cfu_apb; XlnxVersalCFUFDRO cfu_fdro; XlnxVersalCFUSFR cfu_sfr; XlnxVersalCFrameReg cframe[XLNX_VERSAL_NR_CFRAME]; XlnxVersalCFrameBcastReg cframe_bcast; @@ -137,10 +133,11 @@ static inline void versal_set_fdt(Versal *s, void *fd= t) g_assert(!qdev_is_realized(DEVICE(s))); s->cfg.fdt =3D fdt; } =20 void versal_sdhci_plug_card(Versal *s, int sd_idx, BlockBackend *blk); +void versal_efuse_attach_drive(Versal *s, BlockBackend *blk); =20 int versal_get_num_can(VersalVersion version); int versal_get_num_sdhci(VersalVersion version); =20 /* Memory-map and IRQ definitions. Copied a subset from diff --git a/hw/arm/xlnx-versal-virt.c b/hw/arm/xlnx-versal-virt.c index cf5e297fef7..f8e9a269b50 100644 --- a/hw/arm/xlnx-versal-virt.c +++ b/hw/arm/xlnx-versal-virt.c @@ -190,45 +190,10 @@ static void fdt_add_bbram_node(VersalVirt *s) 2, MM_PMC_BBRAM_CTRL_SIZE); qemu_fdt_setprop(s->fdt, name, "compatible", compat, sizeof(compat)); g_free(name); } =20 -static void fdt_add_efuse_ctrl_node(VersalVirt *s) -{ - const char compat[] =3D TYPE_XLNX_VERSAL_EFUSE_CTRL; - const char interrupt_names[] =3D "pmc_efuse"; - char *name =3D g_strdup_printf("/pmc_efuse@%x", MM_PMC_EFUSE_CTRL); - - qemu_fdt_add_subnode(s->fdt, name); - - qemu_fdt_setprop_cells(s->fdt, name, "interrupts", - GIC_FDT_IRQ_TYPE_SPI, VERSAL_EFUSE_IRQ, - GIC_FDT_IRQ_FLAGS_LEVEL_HI); - qemu_fdt_setprop(s->fdt, name, "interrupt-names", - interrupt_names, sizeof(interrupt_names)); - qemu_fdt_setprop_sized_cells(s->fdt, name, "reg", - 2, MM_PMC_EFUSE_CTRL, - 2, MM_PMC_EFUSE_CTRL_SIZE); - qemu_fdt_setprop(s->fdt, name, "compatible", compat, sizeof(compat)); - g_free(name); -} - -static void fdt_add_efuse_cache_node(VersalVirt *s) -{ - const char compat[] =3D TYPE_XLNX_VERSAL_EFUSE_CACHE; - char *name =3D g_strdup_printf("/xlnx_pmc_efuse_cache@%x", - MM_PMC_EFUSE_CACHE); - - qemu_fdt_add_subnode(s->fdt, name); - - qemu_fdt_setprop_sized_cells(s->fdt, name, "reg", - 2, MM_PMC_EFUSE_CACHE, - 2, MM_PMC_EFUSE_CACHE_SIZE); - qemu_fdt_setprop(s->fdt, name, "compatible", compat, sizeof(compat)); - g_free(name); -} - static void fdt_nop_memory_nodes(void *fdt, Error **errp) { Error *err =3D NULL; char **node_path; int n =3D 0; @@ -391,19 +356,19 @@ static void bbram_attach_drive(XlnxBBRam *dev) if (blk) { qdev_prop_set_drive(DEVICE(dev), "drive", blk); } } =20 -static void efuse_attach_drive(XlnxEFuse *dev) +static void efuse_attach_drive(VersalVirt *s) { DriveInfo *dinfo; BlockBackend *blk; =20 dinfo =3D drive_get_by_index(IF_PFLASH, 1); blk =3D dinfo ? blk_by_legacy_dinfo(dinfo) : NULL; if (blk) { - qdev_prop_set_drive(DEVICE(dev), "drive", blk); + versal_efuse_attach_drive(&s->soc, blk); } } =20 static void sd_plug_card(VersalVirt *s, int idx, DriveInfo *di) { @@ -478,12 +443,10 @@ static void versal_virt_init(MachineState *machine) versal_set_fdt(&s->soc, s->fdt); fdt_add_gic_nodes(s); fdt_add_timer_nodes(s); fdt_add_rtc_node(s); fdt_add_bbram_node(s); - fdt_add_efuse_ctrl_node(s); - fdt_add_efuse_cache_node(s); fdt_add_cpu_nodes(s, psci_conduit); fdt_add_clk_node(s, "/old-clk125", 125000000, s->phandle.clk_125Mhz); fdt_add_clk_node(s, "/old-clk25", 25000000, s->phandle.clk_25Mhz); =20 sysbus_realize(SYS_BUS_DEVICE(&s->soc), &error_fatal); @@ -496,11 +459,11 @@ static void versal_virt_init(MachineState *machine) =20 /* Attach bbram backend, if given */ bbram_attach_drive(&s->soc.pmc.bbram); =20 /* Attach efuse backend, if given */ - efuse_attach_drive(&s->soc.pmc.efuse); + efuse_attach_drive(s); =20 /* Plug SD cards */ for (i =3D 0; i < versal_get_num_sdhci(VERSAL_VER_VERSAL); i++) { sd_plug_card(s, i, drive_get(IF_SD, 0, i)); } diff --git a/hw/arm/xlnx-versal.c b/hw/arm/xlnx-versal.c index 4e4df0851e8..ed202b0fcda 100644 --- a/hw/arm/xlnx-versal.c +++ b/hw/arm/xlnx-versal.c @@ -31,10 +31,11 @@ #include "hw/sd/sdhci.h" #include "hw/net/cadence_gem.h" #include "hw/dma/xlnx-zdma.h" #include "hw/misc/xlnx-versal-xramc.h" #include "hw/usb/xlnx-usb-subsystem.h" +#include "hw/nvram/xlnx-versal-efuse.h" =20 #define XLNX_VERSAL_ACPU_TYPE ARM_CPU_TYPE_NAME("cortex-a72") #define XLNX_VERSAL_RCPU_TYPE ARM_CPU_TYPE_NAME("cortex-r5f") #define GEM_REVISION 0x40070106 =20 @@ -86,10 +87,16 @@ typedef struct VersalMap { uint64_t xhci; uint64_t ctrl; int irq; } usb[2]; size_t num_usb; + + struct VersalEfuseMap { + uint64_t ctrl; + uint64_t cache; + int irq; + } efuse; } VersalMap; =20 static const VersalMap VERSAL_MAP =3D { .uart[0] =3D { 0xff000000, 18 }, .uart[1] =3D { 0xff010000, 19 }, @@ -117,10 +124,12 @@ static const VersalMap VERSAL_MAP =3D { .irq =3D 79, }, =20 .usb[0] =3D { .xhci =3D 0xfe200000, .ctrl =3D 0xff9d0000, .irq =3D 22 = }, .num_usb =3D 1, + + .efuse =3D { .ctrl =3D 0xf1240000, .cache =3D 0xf1250000, .irq =3D 139= }, }; =20 static const VersalMap *VERSION_TO_MAP[] =3D { [VERSAL_VER_VERSAL] =3D &VERSAL_MAP, }; @@ -744,46 +753,45 @@ static void versal_create_bbram(Versal *s, qemu_irq *= pic) sysbus_mmio_get_region(sbd, 0)); sysbus_connect_irq(sbd, 0, qdev_get_gpio_in(DEVICE(&s->pmc.apb_irq_orgate), 1)= ); } =20 -static void versal_realize_efuse_part(Versal *s, Object *dev, hwaddr base) +static void versal_create_efuse(Versal *s, + const struct VersalEfuseMap *map) { - SysBusDevice *part =3D SYS_BUS_DEVICE(dev); + DeviceState *bits; + DeviceState *ctrl; + DeviceState *cache; =20 - object_property_set_link(OBJECT(part), "efuse", - OBJECT(&s->pmc.efuse), &error_abort); + ctrl =3D qdev_new(TYPE_XLNX_VERSAL_EFUSE_CTRL); + cache =3D qdev_new(TYPE_XLNX_VERSAL_EFUSE_CACHE); + bits =3D qdev_new(TYPE_XLNX_EFUSE); =20 - sysbus_realize(part, &error_abort); - memory_region_add_subregion(&s->mr_ps, base, - sysbus_mmio_get_region(part, 0)); -} + qdev_prop_set_uint32(bits, "efuse-nr", 3); + qdev_prop_set_uint32(bits, "efuse-size", 8192); =20 -static void versal_create_efuse(Versal *s, qemu_irq *pic) -{ - Object *bits =3D OBJECT(&s->pmc.efuse); - Object *ctrl =3D OBJECT(&s->pmc.efuse_ctrl); - Object *cache =3D OBJECT(&s->pmc.efuse_cache); + object_property_add_child(OBJECT(s), "efuse", OBJECT(bits)); + qdev_realize_and_unref(bits, NULL, &error_abort); =20 - object_initialize_child(OBJECT(s), "efuse-ctrl", &s->pmc.efuse_ctrl, - TYPE_XLNX_VERSAL_EFUSE_CTRL); + object_property_set_link(OBJECT(ctrl), "efuse", OBJECT(bits), &error_a= bort); =20 - object_initialize_child(OBJECT(s), "efuse-cache", &s->pmc.efuse_cache, - TYPE_XLNX_VERSAL_EFUSE_CACHE); + object_property_set_link(OBJECT(cache), "efuse", OBJECT(bits), + &error_abort); =20 - object_initialize_child_with_props(ctrl, "xlnx-efuse@0", bits, - sizeof(s->pmc.efuse), - TYPE_XLNX_EFUSE, &error_abort, - "efuse-nr", "3", - "efuse-size", "8192", - NULL); + object_property_add_child(OBJECT(s), "efuse-cache", OBJECT(cache)); + sysbus_realize_and_unref(SYS_BUS_DEVICE(cache), &error_abort); =20 - qdev_realize(DEVICE(bits), NULL, &error_abort); - versal_realize_efuse_part(s, ctrl, MM_PMC_EFUSE_CTRL); - versal_realize_efuse_part(s, cache, MM_PMC_EFUSE_CACHE); + object_property_add_child(OBJECT(s), "efuse-ctrl", OBJECT(ctrl)); + sysbus_realize_and_unref(SYS_BUS_DEVICE(ctrl), &error_abort); =20 - sysbus_connect_irq(SYS_BUS_DEVICE(ctrl), 0, pic[VERSAL_EFUSE_IRQ]); + memory_region_add_subregion(&s->mr_ps, map->ctrl, + sysbus_mmio_get_region(SYS_BUS_DEVICE(ctrl= ), + 0)); + memory_region_add_subregion(&s->mr_ps, map->cache, + sysbus_mmio_get_region(SYS_BUS_DEVICE(cach= e), + 0)); + versal_sysbus_connect_irq(s, SYS_BUS_DEVICE(ctrl), 0, map->irq); } =20 static void versal_create_pmc_iou_slcr(Versal *s, qemu_irq *pic) { SysBusDevice *sbd; @@ -1247,15 +1255,16 @@ static void versal_realize(DeviceState *dev, Error = **errp) =20 for (i =3D 0; i < map->num_usb; i++) { versal_create_usb(s, &map->usb[i]); } =20 + versal_create_efuse(s, &map->efuse); + versal_create_pmc_apb_irq_orgate(s, pic); versal_create_rtc(s, pic); versal_create_trng(s, pic); versal_create_bbram(s, pic); - versal_create_efuse(s, pic); versal_create_pmc_iou_slcr(s, pic); versal_create_ospi(s, pic); versal_create_crl(s, pic); versal_create_cfu(s, pic); versal_map_ddr(s); @@ -1286,10 +1295,23 @@ void versal_sdhci_plug_card(Versal *s, int sd_idx, = BlockBackend *blk) qdev_prop_set_drive_err(card, "drive", blk, &error_fatal); qdev_realize_and_unref(card, qdev_get_child_bus(DEVICE(sdhci), "sd-bus= "), &error_fatal); } =20 +void versal_efuse_attach_drive(Versal *s, BlockBackend *blk) +{ + DeviceState *efuse; + + efuse =3D DEVICE(versal_get_child(s, "efuse")); + + if (efuse =3D=3D NULL) { + return; + } + + qdev_prop_set_drive(efuse, "drive", blk); +} + int versal_get_num_can(VersalVersion version) { const VersalMap *map =3D VERSION_TO_MAP[version]; =20 return map->num_canfd; --=20 2.50.1