From nobody Sat Nov 15 05:39:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1755615458; cv=none; d=zohomail.com; s=zohoarc; b=kcLyWzYAiomNju0Bh8/dRH8uyInQYIjjUvc3bxVOOPhAJjAANjAAsVTQn+4GeNLVSLq4L5L8vLeJZF+bLhuTLDqBcdix5TntpvM3tzqWVFDTFTVVF8BW1hBtmxAtpAzG4VITLZkOG94nSnILrqs+yn16T/fDOnE/3KOptlC7Cvc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1755615458; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=nTU6s1lLYHTXTSeG/Jwij9zqsCWcsjK+a5Jdl9ABAQk=; b=DQp8NI9gC8BTBu2tWpQUESVww4MtgWzOEXNa/yixBfx0Fy4GvMRgs+jFE6dYy4VCzqZ8PhI19/87/EePj1wVd2pT7twDlfHqqKqMUKh5cYsjItroBiuuqvxiWv57t9tN746Q+6JJZHmAgNrzg+0XBgfhcRWS5Vk480Ga3rkqMWE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1755615458234515.6407880668412; Tue, 19 Aug 2025 07:57:38 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uoNlq-00074U-Pp; Tue, 19 Aug 2025 10:57:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uoNlo-00073f-W0 for qemu-devel@nongnu.org; Tue, 19 Aug 2025 10:57:05 -0400 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uoNln-00026q-Bp for qemu-devel@nongnu.org; Tue, 19 Aug 2025 10:57:04 -0400 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-45a1b00e4a1so37110145e9.0 for ; Tue, 19 Aug 2025 07:57:02 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45a24e5562csm161864175e9.20.2025.08.19.07.57.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Aug 2025 07:57:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755615421; x=1756220221; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=nTU6s1lLYHTXTSeG/Jwij9zqsCWcsjK+a5Jdl9ABAQk=; b=xfPygPqlPoF2F6Sxmgk+AbvPKUFrFOp9UMYqSyEhi5hPcPOlbHnb2f+sTM2N5Z/KHM 5Z0jePiGvX46NVP2P7RAH1tXh+xSV6BlUkLyz6JJY/M0Gm29JXYSKRPQ8+C3A7mVXelx sPbI5Kd1On7ObZLjMzc4Ymj/9G8pdmbC8vYCm1cDRD/HoJuc144yB3Ceqn0/UYTsUVQM EqbkicBMXq6jhjemkBIxqI0AQ3MNS+mAKjXvzWkU0qEqC03DSWPjvij/Iq+RaFk0B2la iR21w8HP+qsqS3SAnYJsbndre/EvvzHYWEPHGCnqmUdpHP3wI8axSuwo3BlVgoKRSAjZ QP+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755615421; x=1756220221; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nTU6s1lLYHTXTSeG/Jwij9zqsCWcsjK+a5Jdl9ABAQk=; b=YVkbd1hQKujb+x2A1z7UOLN1j9GhXFgYPG3nBLO6Nmc17pkcAyqGi1gcE7wJWo0gpb kYvRsVfdBaYLZpFsKhhp+DxH2FBcAqVc3D3Cpsoc6CRLdGVyTJROmHHVtsxjE82OHyc6 M2+PzerPL8Wp8+u7g1fUONnnWA1oQToCJliS/X0GHXVevqdW2s/BsfZHrAgAtDHJvqfm KsIbCAe5GOR2IGp1S5+ZKaEX3Q4kayflobPUSvJBfpXzUyWy5T/dpXDNA3HdftATfnlz 1eq2AsaNRm5aTqItiAGlRWn29MngOT4L0d8n51+H2hHQQpmiHR3hm8I2R8vrIJ7U021Y N93w== X-Forwarded-Encrypted: i=1; AJvYcCXRodRp4nqmtBkKyEyPtVGZzYu3OC1LV/QcWU3oGZmTvg7gSTrZpn42AiHCESimrl5pMQcFbm77xcmM@nongnu.org X-Gm-Message-State: AOJu0YyuXav81xLGf+kETa/CJ1yXRmnON/kozZVi+V0fLMNgUzovAlNM j8G8C05arl3cSgDeCvAuxgLZa7CcPl3sKaXaGtDwcEH13lvfz2MNEhrCNknpHJSkF3I= X-Gm-Gg: ASbGnctTw1rCfAhfHtGmgh4RkdAfnnPsVF++RDJ7dL7UeYpUl4nJIBQ6yUJA6KDZOd2 q22+lAW+kADOxVwTHduYEalzmMwihCHNAP0mjYCg9qLOt2bQ0R+/kdPmMxiqoRtbVlaOJriaN1W dG6Ev6XLMRE8mcV53lLTi8mvlXZw/oHIb2dJ7lb3YXOFb0Yv7eSNePV9Yoq47q1MwLGx8+RESE3 pc3KYeACj3wADkXNOrbQWEOC24NP7zQBth4oMt4fQTYz+WzcaSel7fpheL4IFFxTHlWHDjjfnBf oTMwQT4VSG6ljujIKU/4PWbXY8zMcEKa839d4zxU7bCfOxjuInW/dDPdTGEp5A//OfyKekQ36Z3 489NSG4G7qnhvZsFeeiOPMiBSkx1V X-Google-Smtp-Source: AGHT+IEXol+Zs2XeBVw4Vbx57c7TZHWHCm74fwf/0QuniICw6LwTtSWWHbv95PXKReaV2TOT1Qd+Ww== X-Received: by 2002:a05:6000:288b:b0:3b8:fb9d:248a with SMTP id ffacd0b85a97d-3c0e2e724e3mr2364242f8f.24.1755615421511; Tue, 19 Aug 2025 07:57:01 -0700 (PDT) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Richard Henderson Subject: [PATCH] target/arm: Correct condition of aa64_atomics feature function Date: Tue, 19 Aug 2025 15:56:58 +0100 Message-ID: <20250819145659.2165160-1-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1755615460327124100 Content-Type: text/plain; charset="utf-8" The ARMv8.1-Atomics feature (renamed FEAT_LSE in more modern versions of the Arm ARM) has always ben indicated by ID_AA64ISAR0.ATOMIC being 0b0010 or greater; 0b0001 is a reserved unused value. We were incorrectly checking for !=3D 0; this had no harmful effects because all the CPUs set their value for this field to either 0 (for not having the feature) or 2 (if they do have it), but it's better to match what the architecture specifies here. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- I think it makes more sense to fix the condition first and rename the feature second, though there's not much difference in it. I'm happy to fix up the trivial conflict in target-arm.next. target/arm/cpu-features.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/cpu-features.h b/target/arm/cpu-features.h index 5876162428a..a4d00a001d3 100644 --- a/target/arm/cpu-features.h +++ b/target/arm/cpu-features.h @@ -408,7 +408,7 @@ static inline bool isar_feature_aa64_crc32(const ARMISA= Registers *id) =20 static inline bool isar_feature_aa64_atomics(const ARMISARegisters *id) { - return FIELD_EX64_IDREG(id, ID_AA64ISAR0, ATOMIC) !=3D 0; + return FIELD_EX64_IDREG(id, ID_AA64ISAR0, ATOMIC) >=3D 2; } =20 static inline bool isar_feature_aa64_rdm(const ARMISARegisters *id) --=20 2.43.0