From nobody Sat Nov 15 07:43:01 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1755491119; cv=none; d=zohomail.com; s=zohoarc; b=PEBxZje0BQGXkiThZsxYEtWBByApTPxBMlNfefcuYfn1cWwj1/pGsgzwqW3c/NBdEwyv/5w03LamtrcSqbdgzabQFtPmHRJxKbMV0kuBrZTA2fRiPxeNSjfNfyiJm0RAqfPpLx4mamIKgksNlyV+zQGSPEbsPHraikWvTD6IfZY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1755491119; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=bTfdSLA0aqt0pUrLTWLPJvwrF5/GVtbYLzuNkuYs9EQ=; b=OJtUBBTwpTBwVmIiIhnAn3z4yXqzZXYSUTjhs6suowUwEQn3sbe8gzJrBkmpJJc5/IaKxmkxtloM7bsmbNeQ/ju089MOpp6xt33q3N4ZHtg8qBYxfKCT87ApKpbSZctiRixoNF88DRL1KD9Av2Pkhn+Cdrbm8YObWWRoKGIEsuw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1755491119445312.5821873291326; Sun, 17 Aug 2025 21:25:19 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1unrQN-00081w-E9; Mon, 18 Aug 2025 00:24:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1unrGA-0005oP-AR for qemu-devel@nongnu.org; Mon, 18 Aug 2025 00:14:15 -0400 Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1unrG8-0002CH-L7 for qemu-devel@nongnu.org; Mon, 18 Aug 2025 00:14:14 -0400 Received: by mail-pj1-x102e.google.com with SMTP id 98e67ed59e1d1-32326e202e0so2835410a91.2 for ; Sun, 17 Aug 2025 21:14:12 -0700 (PDT) Received: from localhost.localdomain ([206.83.122.207]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3232f8c8e4bsm5498344a91.2.2025.08.17.21.14.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Aug 2025 21:14:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755490451; x=1756095251; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bTfdSLA0aqt0pUrLTWLPJvwrF5/GVtbYLzuNkuYs9EQ=; b=JPKdbpdw9g0Qdzy3y3j+GAwW14uskGKUxjr8b6FVRfcXLgOcuwIgE9eLzxI61dTRMx 2b7Uj4M6PPbMlbr+MmOPiML+IZSYn2lNN92FpKmC3H7s/a9nNGDP9srQYwJRkWU246tT YsHPsu+p4Z6Y/bFWIdkog+YD+H13a6+3nD3ARy9YmP34p69NXV7bg3cZEphWOTQau3ya 3/Z1Xb//Dx8ZD3TUFEmDqXgsN3c/HEx5BAZPXDYc5Ji4pm4u7U2nXSgPS2SndESdNTZX KTVxwGnBMBXB63VGmRCK1DbxZtY/GV2Rla9BDDVH5l4Eatyi84hkcANEBfCRcQVxxqhM HPjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755490451; x=1756095251; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bTfdSLA0aqt0pUrLTWLPJvwrF5/GVtbYLzuNkuYs9EQ=; b=dWpgxL23+IKt/AAJwJfthNgYrKbwW2HN8zC6QLYennGT82JIZWKpPx607NyXK19xUz QNKq5nnpma7YV2eayZh5i5Bzjy/NJLH9XpOmgqBkueB9XuiG1xifK7yB2u7o2nHsD279 Gi7C4D9vMzXzeFZBWaw7d4ZZ8iMHT8PDr7KZGZUwuKd3IlEJpg+Tk4tdrtkf80gkW1aq 2PWq6t1x/YIu7k63yjZM4Qrzgw9S1pWG7KIbd5sDxadFK0kcIuH3pii4AiY4DBpIPgmr icuSKn+ijLuew0shJ1DzMKui4KpM0KXQjmZQIVXkEb73aBfUdhyu3+/Dhk6eSgm1Yr6B hpGQ== X-Gm-Message-State: AOJu0YygN5sHtETGStKUB6RbifuoRLX3+seq+f+zEMzNMSUEEJQBkODl 6bODSy7esoLa+RVuvzU7HLor/H7PsTr81Q6AlQFUWuPKsfhfkq3iRRZrIlgDEZYYknfTPxUnL9o Ol92P6gY= X-Gm-Gg: ASbGncskW39DCqn/rcP7oPI0jlvnBSMrpyDgAWzmo5UMwN8HNhR+f+tN08o6QyeQbFM +Voe/CvYtdhGFGLTje5NNnIm5uREJsX0dWnTAQHhbgBEhqqmB0cOPpylfF4qTVB9Ehw7Z/DQMSf WSkumQE7V1crSlllKr3EJ0ZZZXvHvo48X9Nt6eIFptj8jS5saWoLicue4JTj5btrEcAHJMQzfdr cB9iei86NNEwlegV+7wwBZc7aYcpVV1AyhYJEEKi0T+QrmFKX+YntKyIBOeAWRIdgzimF85wFEH oawlKC/LAHinsyht5LI/bCHvt5/7T4zV428V85aKyOAp/GI/Fc32ITLRP43+PV6+RSe/w7Yw7JS H5bRZfJMLDTQpzoUgdbIyaHPoFMgWErcQhOWrxQTVJ3BvjWU= X-Google-Smtp-Source: AGHT+IGdErE1IGOIXT4wRJMngyZK5ECh/vUtMFj3GcPqVhvfGDdYH+rSH5BFl9vY+Qz16lOzFXg96g== X-Received: by 2002:a17:90b:1dca:b0:321:87fa:e1e8 with SMTP id 98e67ed59e1d1-3234db6f096mr10302724a91.2.1755490450817; Sun, 17 Aug 2025 21:14:10 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: mads@ynddal.dk, agraf@csgraf.de, qemu-arm@nongnu.org, philmd@linaro.org Subject: [PATCH 2/7] target/arm: Move compare_u64 to helper.c Date: Mon, 18 Aug 2025 14:13:49 +1000 Message-ID: <20250818041354.2393041-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250818041354.2393041-1-richard.henderson@linaro.org> References: <20250818041354.2393041-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::102e; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1755491121096116600 Content-Type: text/plain; charset="utf-8" We will use this function beyond kvm.c. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- target/arm/cpregs.h | 3 +++ target/arm/helper.c | 11 +++++++++++ target/arm/kvm.c | 11 ----------- 3 files changed, 14 insertions(+), 11 deletions(-) diff --git a/target/arm/cpregs.h b/target/arm/cpregs.h index c9506aa6d5..2854960c08 100644 --- a/target/arm/cpregs.h +++ b/target/arm/cpregs.h @@ -1189,4 +1189,7 @@ static inline bool arm_cpreg_traps_in_nv(const ARMCPR= egInfo *ri) (arm_is_secure(_env) && !arm_el_is_aa64((_env), 3))= , \ (_val)) =20 +/* Compare uint64_t for qsort and bsearch. */ +int compare_u64(const void *a, const void *b); + #endif /* TARGET_ARM_CPREGS_H */ diff --git a/target/arm/helper.c b/target/arm/helper.c index 0c1299ff84..d230f9e766 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -40,6 +40,17 @@ =20 static void switch_mode(CPUARMState *env, int mode); =20 +int compare_u64(const void *a, const void *b) +{ + if (*(uint64_t *)a > *(uint64_t *)b) { + return 1; + } + if (*(uint64_t *)a < *(uint64_t *)b) { + return -1; + } + return 0; +} + uint64_t raw_read(CPUARMState *env, const ARMCPRegInfo *ri) { assert(ri->fieldoffset); diff --git a/target/arm/kvm.c b/target/arm/kvm.c index 6672344855..9e569eff65 100644 --- a/target/arm/kvm.c +++ b/target/arm/kvm.c @@ -718,17 +718,6 @@ void kvm_arm_register_device(MemoryRegion *mr, uint64_= t devid, uint64_t group, memory_region_ref(kd->mr); } =20 -static int compare_u64(const void *a, const void *b) -{ - if (*(uint64_t *)a > *(uint64_t *)b) { - return 1; - } - if (*(uint64_t *)a < *(uint64_t *)b) { - return -1; - } - return 0; -} - /* * cpreg_values are sorted in ascending order by KVM register ID * (see kvm_arm_init_cpreg_list). This allows us to cheaply find --=20 2.43.0