From nobody Sat Nov 15 05:33:50 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1755181499; cv=none; d=zohomail.com; s=zohoarc; b=MdkUK0/2YuJN7CT0QJU8xe0dMUZptBXPqdJ6rjSgF8NXFItdS8UfAGvaVtfEGjVsVX5Brqj/0KhmTj6cYO11xAHlGzgaBQLQX/TTtt468zq1M1mrc9v7yfC0UzTr30HB/fsPsEtVnMwVssDe160emaNtG4lyjAp7JvuRsLUrnzI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1755181499; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=1dJm+wEoWJsy971flHleGAxJooy183umOhAYkqOVTAM=; b=YIxV+gcE4lc+wlyr3FAq6QzmtfT7sH6VaQMXo4r8hZDGItqRJuSzIMcB7+b9gbHz4H4fSJOGiKTr+FP2oEMd79qZL/jEHOy5aZSUPVkd+RTHseCOdtjf+EwYT9fEr5b0hiLqrJu+YMOqaImzsh1QouPiyng/ahGc4iDXVeNEZEA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1755181499305856.979232889597; Thu, 14 Aug 2025 07:24:59 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1umYs1-0004Az-Hw; Thu, 14 Aug 2025 10:23:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1umYrz-0004AS-DI for qemu-devel@nongnu.org; Thu, 14 Aug 2025 10:23:55 -0400 Received: from mgamail.intel.com ([198.175.65.21]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1umYrt-0003Ct-L8 for qemu-devel@nongnu.org; Thu, 14 Aug 2025 10:23:55 -0400 Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Aug 2025 07:23:47 -0700 Received: from lxy-clx-4s.sh.intel.com ([10.239.48.52]) by fmviesa001.fm.intel.com with ESMTP; 14 Aug 2025 07:23:45 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1755181430; x=1786717430; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=hbATJmh33hiD2jm2Ul61SMq1SjQEEQHmzjo3F5wj3Eo=; b=VMzmxFYOfFhhAQGR4LfR7F3+k9SQA8o+rmQ14N4PCNppsLz8clBDTZvw VspqhdlJ1oowollTLZE7PLCXgGPEmVL+LsaAAn3MPTkIyTkRzLulBSsrw 9lnxQFQ2zMDxUdHHIHykgiraCRd+XEmelj6A5FySSJZGdr3uYKuN75pZe v78vA+plVUTylLhaK00XO4GafndpRw+ZoV7m3prPtMOSTt7HbsPYOW/2U xNlgObTPIYe1N3UbMq6Q/xcmgELbHCuLvYRMy6pFzekzcijcU2Y7ZOgGt 0armCkOeIY1tZzhNrRXNAQjfdBWqXdeKZtB7fDLkH6iux3MXEgRF1ROlj w==; X-CSE-ConnectionGUID: 1ojXyEu7RcOVMAXWcf1LTw== X-CSE-MsgGUID: hhrE1Zd4R5GAmejC+NsnoQ== X-IronPort-AV: E=McAfee;i="6800,10657,11522"; a="57406085" X-IronPort-AV: E=Sophos;i="6.17,287,1747724400"; d="scan'208";a="57406085" X-CSE-ConnectionGUID: 7aecShlRTZWQ9zzH8EhPiw== X-CSE-MsgGUID: S8eelrQ5TamTQbjnjuAVlQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.17,287,1747724400"; d="scan'208";a="197625240" From: Xiaoyao Li To: Gerd Hoffmann Cc: Paolo Bonzini , qemu-devel@nongnu.org, Xiaoyao Li Subject: [PATCH] x86/loader: Rectify the address of setup_data Date: Thu, 14 Aug 2025 22:14:06 +0800 Message-ID: <20250814141406.2371767-1-xiaoyao.li@intel.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=198.175.65.21; envelope-from=xiaoyao.li@intel.com; helo=mgamail.intel.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HK_RANDOM_ENVFROM=0.001, HK_RANDOM_FROM=0.94, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @intel.com) X-ZM-MESSAGEID: 1755181501838116600 Content-Type: text/plain; charset="utf-8" Commit 214191f6b574 ("x86/loader: read complete kernel") changed the semantics of kernel_size from the piggyback kernel to the whole kernel file, which leads to the setup_data_offset contains setup_size and leads to wrong address of setup_data being written in header[0x250]. Fix it by minusing setup_size. Fixes: 214191f6b574 ("x86/loader: read complete kernel") Signed-off-by: Xiaoyao Li --- hw/i386/x86-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/x86-common.c b/hw/i386/x86-common.c index 7512be64d67b..127b85eb02cc 100644 --- a/hw/i386/x86-common.c +++ b/hw/i386/x86-common.c @@ -935,7 +935,7 @@ void x86_load_linux(X86MachineState *x86ms, kernel_size =3D setup_data_offset + sizeof(struct setup_data) + dt= b_size; kernel =3D g_realloc(kernel, kernel_size); =20 - stq_le_p(header + 0x250, prot_addr + setup_data_offset); + stq_le_p(header + 0x250, prot_addr + setup_data_offset - setup_siz= e); =20 setup_data =3D (struct setup_data *)(kernel + setup_data_offset); setup_data->next =3D 0; --=20 2.43.0