From nobody Mon Dec 15 21:29:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1755177230; cv=none; d=zohomail.com; s=zohoarc; b=c64iMYi3m0QoCWBG1z3syuwtThFbT0VjAnzvhmO07fml0OBCwr8RtLtCaq2X9ZvzLH2N/yCBKLF86aM7oTzN+XafoVCaxmadDCdYaHk94zvWbExAs7CuZc5/LnUC1kB4dEIS353mt2G02rfX/kwmCdRWmC8j3i1qH67En8NhxZU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1755177230; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=5UYaNg4HgCgaMfA5VDdSs+JLi614JTEFfBBOaKuI9nc=; b=V6ZlpuAOHFqAsQugESIKHJIx7nSjCMT1klf9/fDGbXKA2IUwquqoEpIifPOxaCV4XyZFrDGO6v4BVoFenPfDxmTPo/SZk8sLuGhdmv4Pwl2V4+/SrkgBgVZ2nChoay4KgemXwVDs5/PLa8Z/8gvH/gnNCTe0uCs4AK51UbfpvF0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1755177230223106.14050455735094; Thu, 14 Aug 2025 06:13:50 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1umXeF-0003oa-2x; Thu, 14 Aug 2025 09:05:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1umXcy-0002Mi-96 for qemu-devel@nongnu.org; Thu, 14 Aug 2025 09:04:22 -0400 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1umXcn-0005AZ-N8 for qemu-devel@nongnu.org; Thu, 14 Aug 2025 09:04:20 -0400 Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-76e2ea933b7so931450b3a.1 for ; Thu, 14 Aug 2025 06:04:08 -0700 (PDT) Received: from localhost.localdomain ([206.83.105.236]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-76bcce6f6fesm34480631b3a.26.2025.08.14.06.04.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Aug 2025 06:04:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755176647; x=1755781447; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5UYaNg4HgCgaMfA5VDdSs+JLi614JTEFfBBOaKuI9nc=; b=dDqUQKZ+K/mwr6XRXU+m/JUx9RaDOcOu5WoVfYePn3ZafRO+k0LWNynoPtW0kybpSv x5f91tP6YqYrf5EWxiNpQTqyZXLBYqSuFpHcjm8d2M7n+34gcvj9DG2N9ZvS9WZOrmj0 DfYieIvt1ir7t/ImR/qICJNuCkKwHv3SN2uZy4DkXwK67pbOy4m84Rw2G1cOjenNBO6U QLjI0cEB/i+tVGA+oqX3JL/DWyH99+OrYM/oYwWceKWpz5IPKNoBpARLKWUswjwE4nWe +DgAaUnsBzZhHodCh8amO7vpubIxOWP+Ocnx+1rnlyHsXJG651CTed+p06takgdMDC2o q5bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755176647; x=1755781447; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5UYaNg4HgCgaMfA5VDdSs+JLi614JTEFfBBOaKuI9nc=; b=Mya/DP756iVn6oujrFY+P97aro1mu8yEMz+2T6vj3RZpPgoRh8PvBLXCye2PmVwyHF DLRiU3IId99SyEiWwSGVpE5F+sKTAOnWSuNKQphGdWBYUD+majKKKzwgN/XSGL9G9aLO 2sSN5MRcpeBc9JRgxOyrZQ+DqEMTH34p8an98C0G8LaW3k74qbi6x3JWh008odZs7Kxk OvZz5nicex5YVNet/YW95Ar+g4I1tlMj2aOpS5CFQtSrPxYniowgBKeTnDxpqATTo6x7 CIOvOZWxLsFiePC+JDsQtvBCS0FJzjbG4NpVevPola6+wHfBtPJefRGmCMDmlRXvgUmw 08vA== X-Gm-Message-State: AOJu0YxWWBcf9TaG5zzhJqTGy9dkwmqHEl29yuecYYsLzIwgBlywhf/F KmSH1BkgXMttV0f/P/qE4dhu0R9cz3nxuCpAxJu20f38tiTHZ9oxrVqyMHH3U5NlYWj5U0aEN5r 4qtx1Y3g= X-Gm-Gg: ASbGncsJ5lXAvGLGv+urN1G/dNdODGpaUCiabFXGEDDP433mfN8ZM4KIepLpAlRd8Fj h18nNfC96oFVWIuW0EPmuC6oLxGP6xgSwugEcK2Zz0IGzE8bKP+E/uY6YfNPz+FM8GAwAjTfRq8 lzVpS9gkbe2vBKfE26aLcjYWzFd1zROJhraItW1NHS8XcOKoZPFp+0QgCdHBauFQs4ZLO6L4COn sNWAYLyIPighmC7qOkznngU/YtlKMu67vaSP7zieeykxES0YHSYsWpJW2j7BThFqceoAaNBr1Tk xxVGyrgx7G1yuXR7XXLJghi2Qf6Hqu5l1miNFRYEjWkd5Vv2E9Cn8SvuhudN7SPr35+YpImiOvu FoOgSKPdD2ooUnyR19oq9jM85koxrN9j0MXS/qG5KWewWfIk= X-Google-Smtp-Source: AGHT+IHbcL9yFtTdFvbJWhleQZlD98zUECBjX9xEHWFbaAH21wwuK1d4JHDgOj3pgY+eTw5tFboK8Q== X-Received: by 2002:a05:6a00:91d3:b0:742:aed4:3e1 with SMTP id d2e1a72fcca58-76e321f1e29mr3765791b3a.2.1755176646935; Thu, 14 Aug 2025 06:04:06 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Pierrick Bouvier Subject: [PATCH v3 55/85] target/arm: Emit HSTR trap exception out of line Date: Thu, 14 Aug 2025 22:57:22 +1000 Message-ID: <20250814125752.164107-56-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250814125752.164107-1-richard.henderson@linaro.org> References: <20250814125752.164107-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::431; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_SPF_HELO_TEMPERROR=0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1755177231103116600 Content-Type: text/plain; charset="utf-8" Use delay_exception_el to move the exception out of line. Use TCG_COND_TSTNE instead of separate AND+NE. Reviewed-by: Pierrick Bouvier Signed-off-by: Richard Henderson --- target/arm/tcg/translate.c | 18 ++++-------------- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/target/arm/tcg/translate.c b/target/arm/tcg/translate.c index c4dd3a747c..f6fdfaa551 100644 --- a/target/arm/tcg/translate.c +++ b/target/arm/tcg/translate.c @@ -3033,21 +3033,11 @@ static void do_coproc_insn(DisasContext *s, int cpn= um, int is64, =20 if (maskbit !=3D 4 && maskbit !=3D 14) { /* T4 and T14 are RES0 so never cause traps */ - TCGv_i32 t; - DisasLabel over =3D gen_disas_label(s); + TCGLabel *fail =3D delay_exception_el(s, EXCP_UDEF, syndrome, = 2); + TCGv_i32 t =3D + load_cpu_offset(offsetoflow32(CPUARMState, cp15.hstr_el2)); =20 - t =3D load_cpu_offset(offsetoflow32(CPUARMState, cp15.hstr_el2= )); - tcg_gen_andi_i32(t, t, 1u << maskbit); - tcg_gen_brcondi_i32(TCG_COND_EQ, t, 0, over.label); - - gen_exception_insn_el(s, 0, EXCP_UDEF, syndrome, 2); - /* - * gen_exception_insn() will set is_jmp to DISAS_NORETURN, - * but since we're conditionally branching over it, we want - * to assume continue-to-next-instruction. - */ - s->base.is_jmp =3D DISAS_NEXT; - set_disas_label(s, over); + tcg_gen_brcondi_i32(TCG_COND_TSTNE, t, 1u << maskbit, fail); } } =20 --=20 2.43.0