From nobody Sat Nov 15 05:33:52 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1755007508; cv=none; d=zohomail.com; s=zohoarc; b=IYJac+lqXhfgLuszVc5Ff/Qfw/wR0L4Bjbk86IA3NOyrwNe7FcmGcCU5n8qhez/N9mtaHItqtlw5L0Bf9HyceD9UDUTm4j87TLLXrj6p9vlTOhhWsnt1FxOTkJ0aGJ3GdMa27d4p9ITVMtj+NLxEu9Ks9cX+FNd5lOYv197njuc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1755007508; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=xIFWjdnlfJkUuXmB+qiWsTetFCi9OyczEwhVE30q1+k=; b=gu5REBApIkFgEf4rltHiiQJ4dvXDSmeBodU45pKhdBW9tuaKzF0PHoNFJpcNzSGuWs3HDJ7MNB4sjvXQyoQgXIYvsiiYW3Qpkt2yNNRkWZw54Zwi6aWldyQwktoMfRZ0LYXI+V4RhDZHE/Tm43aJ8Sz9r8mHC7V3pUpNaq2fcyY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1755007508819669.687790573044; Tue, 12 Aug 2025 07:05:08 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ulpcC-0007Th-Kn; Tue, 12 Aug 2025 10:04:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ulpcA-0007T1-VB for qemu-devel@nongnu.org; Tue, 12 Aug 2025 10:04:34 -0400 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ulpc5-0007jC-Oa for qemu-devel@nongnu.org; Tue, 12 Aug 2025 10:04:34 -0400 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-4563cfac2d2so47987655e9.3 for ; Tue, 12 Aug 2025 07:04:27 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-459e5843021sm323838745e9.3.2025.08.12.07.04.21 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 12 Aug 2025 07:04:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755007462; x=1755612262; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xIFWjdnlfJkUuXmB+qiWsTetFCi9OyczEwhVE30q1+k=; b=END0WNCsyiBzOYWH6kpcamnQYo+tuIpgUND2m7H7LHWcxp9vQKrVRH1jeYlg8zDS68 l/YshQ12uVutyBHUptzp+nXfw7dKsTtOHlgrDzfmA5aEYUP3EIyZy4fvvQSFFHMJRonz pGE5LUlN9IftW5YWeIvhBv8wspeRCuLrUZMiIPxrv2BFETeJKwGs0U44I7sIWIGNb3NF rpzYpFqHsXJs6FGkhMMQx2gCrdGmP9aNjK/p+JPj8j+W4X6arL4RTLF/TM5uQnmMFjuP QHQDifNJagf5hBbieHnwLQ+otgUUeVUBd07AUNQi7mEJ7Gq+g7EJVbwQUFo4OkTezNRj 3CqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755007462; x=1755612262; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xIFWjdnlfJkUuXmB+qiWsTetFCi9OyczEwhVE30q1+k=; b=dhPInj2pjyuSqs/RpyVTbH1HazsMdWP2PczvHccyvj15ai44ua3TerGt3kmq4mATD5 UrvqcL275HUHno39mP7DF4iwVKX6a0fKEEaRYRd2Rf/8qa2MTZi7axS2aQ1zjAeUjIvR TQNzn8TBewuZpRiIXSmF+lMQE9ZTIzy4qMHl2MUXe+4Y7lkgsq04CgJ4NJLFm0cbcMyq +XP+z3EYTBUypXbi6YV0ngaK44ackfzn1q+TJfJXoS/z61YSa/G72st+u5pUBokQUg0Y /qT/bZfeEitHyJsr9WvKx3s/2ix70yXhzF5yNR9aFR4mo2hXAGYzDCTAFoN4rIjRkWKg /iGg== X-Gm-Message-State: AOJu0Yxke8sgnBgCAFcn/WYzXo69g/0E8KuXKXltw+yL/SuQWyydinHW S296RMw5EmCTQrniNNMyDoa/vwYPnktUXVqXdBIbcxLVwgEK7BL9+f0J34NjjoFUyc7oL5Gf5vU A222t X-Gm-Gg: ASbGncvapSpPowy2P9nOdBTe5R9Op0aAaylFsbdbolHi1ESS46joIshqgbU4sPyT8i+ RmOMlXPlIR1DwVehcve+R1rRrQpOgVdk2cdXR3jdwLG1AA2i4yjkG2gD4cBPHOEUhIVVuL2M6Xv EqoDumP5BUoeK1L0+zaZBBnqVPx6dFHOTaV9DXIeD7HvLhHxgmNdBlreBj62eCfI/laL1k9wSpG IJ+hrPDEiEeSr6XyFTuHLiG3vD3uIXfdYN+LcWoaNQ5uTp76+ouzQczzIy7yfvuIhNSLmCez62U 8zZhvMiVEkHCrh1lHXoeOa6CQ4WXxMJGmZ5pqixE/stAW+XjLLlUYx16QpBy8A9tc0idDysNp1f t/29p8ByvPeJINTr2M6x62RuaLgV5ozLE4QMlPe5YSlAp+U4fGEVsVfWejPLfxib3DkCLj5tz X-Google-Smtp-Source: AGHT+IGMHkoSYcGSPxyYIJgyRWKk0I7FhJcDTrnjuvJYtOw0mUH55Ep4WOE3k8S8lO8onut4QFzvSA== X-Received: by 2002:a05:6000:4308:b0:3b7:9350:d372 with SMTP id ffacd0b85a97d-3b900b4e1c5mr16541044f8f.24.1755007462448; Tue, 12 Aug 2025 07:04:22 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Guenter Roeck Subject: [PATCH-for-10.1 RESEND RESEND v2 1/3] hw/sd/ssi-sd: Return noise (dummy byte) when no card connected Date: Tue, 12 Aug 2025 16:04:13 +0200 Message-ID: <20250812140415.70153-2-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250812140415.70153-1-philmd@linaro.org> References: <20250812140415.70153-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=philmd@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1755007510596124100 Commit 1585ab9f1ba ("hw/sd/sdcard: Fill SPI response bits in card code") exposed a bug in the SPI adapter: if no SD card is plugged, we are returning "there is a card with an error". This is wrong, we shouldn't return any particular packet response, but the noise shifted on the MISO line. Return the dummy byte, otherwise we get: qemu-system-riscv64: ../hw/sd/ssi-sd.c:160: ssi_sd_transfer: Assertion `s= ->arglen > 0' failed. Reported-by: Guenter Roeck Fixes: 775616c3ae8 ("Partial SD card SPI mode support") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Guenter Roeck Reviewed-by: Alex Benn=C3=A9e Reviewed-by: Gustavo Romero --- hw/sd/ssi-sd.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/sd/ssi-sd.c b/hw/sd/ssi-sd.c index 594dead19ee..3aacbd03871 100644 --- a/hw/sd/ssi-sd.c +++ b/hw/sd/ssi-sd.c @@ -89,6 +89,10 @@ static uint32_t ssi_sd_transfer(SSIPeripheral *dev, uint= 32_t val) SDRequest request; uint8_t longresp[5]; =20 + if (!sdbus_get_inserted(&s->sdbus)) { + return SSI_DUMMY; + } + /* * Special case: allow CMD12 (STOP TRANSMISSION) while reading data. * --=20 2.49.0 From nobody Sat Nov 15 05:33:52 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1755007537; cv=none; d=zohomail.com; s=zohoarc; b=LLB80GT+uDwYOSEmTomFRJHJv/ZPtGLUqlOqR3Uj6z5L+qKAQMLBliTtE3Ro70t9Gd8P/NKOmRsmB2VQSUQ55SP1CzUAdfua3g7EvH4jugNttMyfV0XxpOzF8nsf2F1KFBd/DLwuhV/Aq+PRpSeMTsIFgDU6fXojn/e1EUzIHvo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1755007537; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=f93tv/vnA/xMKC2H8Wzbvol4EZUoCD7p17vWtC4FtnY=; b=Pas+uihB2IHhBPkEFCBAjyUNpDlzrGfpx9BK7V8cwFqnGiwe6W6cMaUS3eMcqdEUKbAkcn3Pl8dOZOowv9t8DabmGcyOcXO6wiFfPAJBBygeBp9Qd+xpnry4Sb6dOYAkcgNRsDaTS/iEW2MTv07qustk3bYps5YNxjkX68pxYhM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1755007537490966.0211419618926; Tue, 12 Aug 2025 07:05:37 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ulpcF-0007Vr-J7; Tue, 12 Aug 2025 10:04:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ulpcC-0007U2-RX for qemu-devel@nongnu.org; Tue, 12 Aug 2025 10:04:36 -0400 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ulpc9-0007k3-8Y for qemu-devel@nongnu.org; Tue, 12 Aug 2025 10:04:36 -0400 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-3b8de193b60so3121927f8f.0 for ; Tue, 12 Aug 2025 07:04:29 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b79c453333sm45923437f8f.45.2025.08.12.07.04.26 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 12 Aug 2025 07:04:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755007467; x=1755612267; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=f93tv/vnA/xMKC2H8Wzbvol4EZUoCD7p17vWtC4FtnY=; b=vxLtc4ClBBCAbLbliwO474bDs7e+Nws+R/O2QjUw/tFTym8hgK27XomsK/vVyvBQac FqJ8V4am/HsKvlY9meMyHlvFu0QP0jpBNfVaPQere6EFnl1qe+zmFIC4h2i5azVhM/xd 2CJYYP+ma0EbPBTDRq/yR2FMoQ5RNsNCSZwtYQKMbTaJ1N+2WHxLo7V6+3ANt3vj8qUB p7zp+xnTtK4oi27+7EsVACZXCgtqmW4JXNHH/k8pM1eXWKa5zFJs1Lwq8PrY/cFdzHCA L1MvlOMRfEjDtoXIe/Ai6/w88duncMADka3sUfZhv3Qmhzsg1S2YfOhximhUdcQHOqC9 IIuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755007467; x=1755612267; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f93tv/vnA/xMKC2H8Wzbvol4EZUoCD7p17vWtC4FtnY=; b=hecCEz8eoVTnxfLGxYiIfa+zGXVDIeQsKuDu/AoPjHClGU6MxdL0r6qGvFwKS38t1S ugz6P38qiIdtEEQYmgwEgEjEx7euGKM6a8/qpoz5l+o6ctAotbCTv8Tl4zbT/ci8e1Db yO9soFXNmzX5O9++tWLhMoEob5yhqYJRniqpd1TwFx/9vQYFW4PAw8FW9A8fj4EkVjVP vx7PrRosivyq1FGFwAXSV+EE2mAcefXh4khXyramrYnUbRHm4AOJfwgy19kkdSHHYYcM 0p6RSGQd6hk/3+itW0a25nx9wqXhjc5nds4vg6ISqpR+EWi4Pybr6/Y6gacfKzjVC3IY E/AA== X-Gm-Message-State: AOJu0YwPzQEjisiDjJL+gU7u3MrDQv0SahRvXQHoqEjE3TVDyuln2S5i G2kKehqmzSMoXlFHrFHi2368K9ghsTKVrOeeAhGaaQ7BneXAlSJnQwAUUkzPtndqMk842JW4sYt nqYxa X-Gm-Gg: ASbGncuQMOMLbsLJaftbZdpWfr+g7sI4nP1PYos428dFIvrob/N+SndzHYXF1zVQlFO aKYpfQ8TJDfUVwGY1oSERlVcJnYtqyheeWOnaHiDh1u/hoMQSmqzjqqONayIX09SvMXaxhxuHlZ cb+dJQdL/VRNqFbImAbHcjzanjHwh/pkb320Yph6ex0V/zG0+TR/Rw78IOP9mKd4ASkk/9FnM0Z tdpsZe7kZS8AiSHoK/hAC8jYxdvqCpdAfFYqnuykgRTb40LKiK5R+UDuWXICMvR5XUF2/2acpgp aeFOEKtEIp7xwlsLl/OJgPsQlYzMhY21Y9hg8AmVow1NH81U+NpGtPOo1Bv8KCy/TTUXCVZ9SaP zqq2dxBw7mYJtqoFATy53ZieY9tqEP8batUgm0+c8M9zBPyO8W5jxo92lnBPMS3LQj6R+R+01 X-Google-Smtp-Source: AGHT+IFwaqA8DGx2N7QECxFWYEBb2K+QjE1qQT79J/Fzs77ogahZmTVE3Xvo4xLzF78FRFwBM+4RsQ== X-Received: by 2002:a05:6000:2304:b0:3b9:10af:59f2 with SMTP id ffacd0b85a97d-3b911014ba4mr3054328f8f.28.1755007467124; Tue, 12 Aug 2025 07:04:27 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Guenter Roeck Subject: [PATCH-for-10.1 RESEND RESEND v2 2/3] tests/functional: Test SPI-SD adapter without SD card connected Date: Tue, 12 Aug 2025 16:04:14 +0200 Message-ID: <20250812140415.70153-3-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250812140415.70153-1-philmd@linaro.org> References: <20250812140415.70153-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=philmd@linaro.org; helo=mail-wr1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1755007538076116600 SPI-SD adapter should be usable, even without any SD card wired. Refactor test_riscv64_sifive_u_mmc_spi() to make it more generic and add another test, inspired by this report: https://lore.kernel.org/qemu-devel/5b2dc427-f0db-4332-a997-fe0c82415acd@roe= ck-us.net/ Inspired-by: Guenter Roeck Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alex Benn=C3=A9e Reviewed-by: Gustavo Romero Tested-by: Alex Benn=C3=A9e --- tests/functional/test_riscv64_sifive_u.py | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/tests/functional/test_riscv64_sifive_u.py b/tests/functional/t= est_riscv64_sifive_u.py index dc4cb8a4a96..ca4c3ba6e12 100755 --- a/tests/functional/test_riscv64_sifive_u.py +++ b/tests/functional/test_riscv64_sifive_u.py @@ -27,25 +27,37 @@ class SifiveU(LinuxKernelTest): 'rootfs.ext2.gz'), 'b6ed95610310b7956f9bf20c4c9c0c05fea647900df441da9dfe767d24e8b28b') =20 - def test_riscv64_sifive_u_mmc_spi(self): + def do_test_riscv64_sifive_u_mmc_spi(self, connect_card): self.set_machine('sifive_u') kernel_path =3D self.ASSET_KERNEL.fetch() rootfs_path =3D self.uncompress(self.ASSET_ROOTFS) =20 self.vm.set_console() kernel_command_line =3D (self.KERNEL_COMMON_COMMAND_LINE + - 'root=3D/dev/mmcblk0 rootwait ' 'earlycon=3Dsbi console=3DttySIF0 ' - 'panic=3D-1 noreboot') + 'root=3D/dev/mmcblk0 ') self.vm.add_args('-kernel', kernel_path, - '-drive', f'file=3D{rootfs_path},if=3Dsd,format= =3Draw', '-append', kernel_command_line, '-no-reboot') + if connect_card: + self.vm.add_args('-drive', f'file=3D{rootfs_path},if=3Dsd,form= at=3Draw') + kernel_command_line +=3D 'panic=3D-1 noreboot rootwait ' + pattern =3D 'Boot successful.' + else: + kernel_command_line +=3D 'panic=3D0 noreboot ' + pattern =3D 'Cannot open root device "mmcblk0" or unknown-bloc= k(0,0)' + self.vm.launch() - self.wait_for_console_pattern('Boot successful.') + self.wait_for_console_pattern(pattern) =20 os.remove(rootfs_path) =20 + def test_riscv64_sifive_u_nommc_spi(self): + self.do_test_riscv64_sifive_u_mmc_spi(False) + + def test_riscv64_sifive_u_mmc_spi(self): + self.do_test_riscv64_sifive_u_mmc_spi(True) + =20 if __name__ =3D=3D '__main__': LinuxKernelTest.main() --=20 2.49.0 From nobody Sat Nov 15 05:33:52 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1755007571; cv=none; d=zohomail.com; s=zohoarc; b=CuWLm8G08nlGj9KrCDpgB1VZxBBcNrWjflvcP/j9kqlfWru/DZk0Uq+ZTSLZ/TRKyl/06dcew+7IpazI1bAyj385BRM4200/254fiIij96oMMQBQixIakNqYdnOfaKtqnUwvU4kt43lqDIytvfO2bNLszk+2z70P6qQm4cHeHk8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1755007571; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=LjNdH5Wyoh4MqiPJIO2aI8sd0ovUKaYmzU8biN1Y86k=; b=X2duIzBoccPHvo1muxNwLVdTqUBIqyhKaNpqsopDbLmHJnn+nhNtrQ9iwNsP1kOag9O2AG5mqwUuy/iBpD69x5CGAplzMgzB0lcUrgHmxew2vToAt+RgX7lW0oopQcr3+JN7o8Ybx5nUtDYlKcQqjWgD7tDaRDCjER9VxsytbS0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1755007571244613.9929214969195; Tue, 12 Aug 2025 07:06:11 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ulpcI-0007X6-Cd; Tue, 12 Aug 2025 10:04:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ulpcG-0007WP-S7 for qemu-devel@nongnu.org; Tue, 12 Aug 2025 10:04:40 -0400 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ulpcB-0007kY-UG for qemu-devel@nongnu.org; Tue, 12 Aug 2025 10:04:40 -0400 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-459ebb6bbdfso34684785e9.0 for ; Tue, 12 Aug 2025 07:04:34 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-459e5853104sm299223425e9.8.2025.08.12.07.04.30 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 12 Aug 2025 07:04:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755007472; x=1755612272; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LjNdH5Wyoh4MqiPJIO2aI8sd0ovUKaYmzU8biN1Y86k=; b=vbAIkIckyMWFoO8keKgKE+Vfx8ws0nj7ywuZCNDFi0xveWfbRveLPN7CYwWxNYvSgK fDCIayS9vuTwfAYo/iBbaZl86rXpPhpe37Ev2tcUpiH0Eod1jPA93T2mPxPR8qXKkhlP K4n9LhBSNu4yPozJXWVIIo/eO3Og9dKvOyetMV0hweINRAc4yH5KXxXmnvvWxmkJOzJV SYx75fO6EQIMZhyltli24CpbJ1adOXvK95/5P7kURByooIH28LwcGblhuYNS6/745Kni ZcU8HjE3kcCmCJQPlhiRBQYWCJMohmoQehFX7MlwpD8zcVdrWpoTgMABgAslaPnq3W9k +B8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755007472; x=1755612272; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LjNdH5Wyoh4MqiPJIO2aI8sd0ovUKaYmzU8biN1Y86k=; b=bLN0eIKTwZbGKblYkqMUOQsu+59I5g5EJr5l4L1b7VCFwu+dL0PhtaewWI/n5RJefz oFm3VZc3KrlKU43II6+rETM5ZvT/LVQs9syPPQKdWTVzImfi++rFU3DpCKcG88V/b0Zt tjNkkpKYhGd9X7iQb8Zh//U6J8L8pYXkXBa0wiU+F9zNvXGr66fOlHbB279yOtpCPBpH AOlL+KdCk1Fw7PIfpv/qStIwaTDxYI45O1Q1fvX5SnfoOkULBY+pxhKWVL4Sp7YjcmMV HfEpbxnXlRScSvjeh9KkT9TRjITQMdBTvI6O6Nnv5ojhBHdZOsnkjI1Q4gd9TfIjDKHC QXJA== X-Gm-Message-State: AOJu0YxVSymoabnw2cYdDJr/qFl8KiPw2cadM4TBd89/cPp54VGUCuKC QuxmnZ3J0tilnLeiMi2J180s1iGuHsUljNB851eELEz1TwVThjsCxKgYQi+EJdLzsSLpVAthfQq yOQb0 X-Gm-Gg: ASbGncveZh2vN1nk1OfCm8Xzmi9slMzZnfHytN5slqx06DKxJqtlxQ9XRs4tojeIhMS OFOHGng2kqGzPBaJP4LPoiN9rujsudKck3BNdrdiZroWDY/Rg1Zs9+mrJoTCFH7FTUWhLxsqMbT 3waiY8Jm/N0YuKtyU4XM8Q34ZYV298KVW9hutQ/5Rr5D+qJpSIxhJyRQ4ulL3ByrjIVOlsQpXPy kfDtlgSjfrPUtBm+qHLz5E+M/cvSRmewdFfDm9gjZ6pdA2vFTursdLHsO8d38D8KncasU552+I7 NKiZ0JfSGrBAhQbY6Ed3D3bdjQRD5XsOnATkWZtJnb1rYpLngN6s7Ng+pYmZv9CyNMwVTtSVwkJ SlH3TLG7QNnvSSr9jvrtTG3w8KJKwbjCnnr+j/G5o9GQjHIdV+12qaJbIRILKeWPOgAZlwQqi X-Google-Smtp-Source: AGHT+IFL6WbcU2qAox8o9N+QNZjCqE+/L5nwIOJ0X2mUCixfX42bGyAcx0gQoImpf/ZpP1dTrs+pgw== X-Received: by 2002:a05:600c:1709:b0:458:be62:dcd3 with SMTP id 5b1f17b1804b1-45a10d258eamr23743945e9.17.1755007471795; Tue, 12 Aug 2025 07:04:31 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH-for-10.1 RESEND RESEND v2 3/3] hw/ssi: Document ssi_transfer() method Date: Tue, 12 Aug 2025 16:04:15 +0200 Message-ID: <20250812140415.70153-4-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250812140415.70153-1-philmd@linaro.org> References: <20250812140415.70153-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=philmd@linaro.org; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1755007573306124100 A SPI transaction consists of shifting bit in sync with the CLK line, writing on the MOSI (output) line / and reading MISO (input) line. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alex Benn=C3=A9e Reviewed-by: Gustavo Romero --- include/hw/ssi/ssi.h | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/include/hw/ssi/ssi.h b/include/hw/ssi/ssi.h index 3cdcbd53904..2ad8033d8f5 100644 --- a/include/hw/ssi/ssi.h +++ b/include/hw/ssi/ssi.h @@ -38,6 +38,7 @@ struct SSIPeripheralClass { =20 /* if you have standard or no CS behaviour, just override transfer. * This is called when the device cs is active (true by default). + * See ssi_transfer(). */ uint32_t (*transfer)(SSIPeripheral *dev, uint32_t val); /* called when the CS line changes. Optional, devices only need to imp= lement @@ -52,6 +53,7 @@ struct SSIPeripheralClass { * of the CS behaviour at the device level. transfer, set_cs, and * cs_polarity are unused if this is overwritten. Transfer_raw will * always be called for the device for every txrx access to the parent= bus + * See ssi_transfer(). */ uint32_t (*transfer_raw)(SSIPeripheral *dev, uint32_t val); }; @@ -110,6 +112,18 @@ bool ssi_realize_and_unref(DeviceState *dev, SSIBus *b= us, Error **errp); /* Master interface. */ SSIBus *ssi_create_bus(DeviceState *parent, const char *name); =20 +/** + * Transfer a word on a SSI bus + * @bus: SSI bus + * @val: word to transmit + * + * At the same time, read a word and write the @val one on the SSI bus. + * + * SSI words might vary between 8 and 32 bits. The same number of bits + * written is received. + * + * Return: word value received + */ uint32_t ssi_transfer(SSIBus *bus, uint32_t val); =20 DeviceState *ssi_get_cs(SSIBus *bus, uint8_t cs_index); --=20 2.49.0