From nobody Sat Nov 15 05:33:51 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1754992960; cv=none; d=zohomail.com; s=zohoarc; b=lJkaiLuD7LGkOcuPY10mGbrxc8YtqNeolNcs1YT9o3eYFbUyggmJQ08fgo4aAdljJ9zFeuTwBusTpdHOjbWUSbS+zvlwLhvvbUCVUL21W/toPRNN+WNV/Or79fBkIDQawcYXIwnKs9+tY2q43YM4OHxFGMkJs0YdyWurHepBHxk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1754992960; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=jN2ij8af1dnCmSc1kGgSBlKEEnJ3MJUar/jrXC2tiMQ=; b=nUDXC8moaAN9mfTI6XALivdyQwuMZ94W70Mak3ucR1S5XHWWihsywdNke+7W/D4xNC46LWp/zs+Uk9pdVXx7fAf854jITs5LNCG7AZJgDIfgGIWxiL2OjI9cAKNwD4eBUJzoNvc3Vc7LebTY1NrCv/dr/vqRPUCT8GA8dkDBZmA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1754992960638546.2770030971699; Tue, 12 Aug 2025 03:02:40 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ullp5-0002FJ-4W; Tue, 12 Aug 2025 06:01:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ullp2-0002EW-1k for qemu-devel@nongnu.org; Tue, 12 Aug 2025 06:01:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ullos-0004vu-H6 for qemu-devel@nongnu.org; Tue, 12 Aug 2025 06:01:31 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-454-R4sqTIZPP7u2e0ubHNXNdw-1; Tue, 12 Aug 2025 06:01:15 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 893511800292; Tue, 12 Aug 2025 10:01:14 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.45.224.64]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EC5C7180028A; Tue, 12 Aug 2025 10:01:13 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 47B9F18000B4; Tue, 12 Aug 2025 12:01:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754992879; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jN2ij8af1dnCmSc1kGgSBlKEEnJ3MJUar/jrXC2tiMQ=; b=Rw3O+TJaAjbsuB2i4lVQaDiFlxtJ0gpzGadOmKwPLFhah+djLCUla+S80sxPvAekmdRLV4 cEP4zwPuoK2AmOhgSDmo8wSpQxXgZ7+QzbAWXpXKRQEjR0fi7Qsgph4l5PpjPRELeZ1LGd +yC2L28PaGIjkjFr6YGQiHGDL0y5FdY= X-MC-Unique: R4sqTIZPP7u2e0ubHNXNdw-1 X-Mimecast-MFC-AGG-ID: R4sqTIZPP7u2e0ubHNXNdw_1754992874 From: Gerd Hoffmann To: qemu-devel@nongnu.org Cc: Gerd Hoffmann , Mauro Matteo Cascella , ZDI Subject: [PULL 1/4] hw/uefi: clear uefi-vars buffer in uefi_vars_write callback Date: Tue, 12 Aug 2025 12:01:07 +0200 Message-ID: <20250812100111.1520917-2-kraxel@redhat.com> In-Reply-To: <20250812100111.1520917-1-kraxel@redhat.com> References: <20250812100111.1520917-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1754992961238116600 Content-Type: text/plain; charset="utf-8" From: Mauro Matteo Cascella When the guest writes to register UEFI_VARS_REG_BUFFER_SIZE, the .write callback `uefi_vars_write` is invoked. The function allocates a heap buffer without zeroing the memory, leaving the buffer filled with residual data from prior allocations. When the guest later reads from register UEFI_VARS_REG_PIO_BUFFER_TRANSFER, the .read callback `uefi_vars_read` returns leftover metadata or other sensitive process memory from the previously allocated buffer, leading to an information disclosure vulnerability. Fixes: CVE-2025-8860 Fixes: 90ca4e03c27d ("hw/uefi: add var-service-core.c") Reported-by: ZDI Suggested-by: Gerd Hoffmann Signed-off-by: Mauro Matteo Cascella Message-ID: <20250811101128.17661-1-mcascell@redhat.com> Signed-off-by: Gerd Hoffmann --- hw/uefi/var-service-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/uefi/var-service-core.c b/hw/uefi/var-service-core.c index feec5a59583b..6ab8df091aaf 100644 --- a/hw/uefi/var-service-core.c +++ b/hw/uefi/var-service-core.c @@ -259,8 +259,8 @@ static void uefi_vars_write(void *opaque, hwaddr addr, = uint64_t val, unsigned si uv->buf_size =3D val; g_free(uv->buffer); g_free(uv->pio_xfer_buffer); - uv->buffer =3D g_malloc(uv->buf_size); - uv->pio_xfer_buffer =3D g_malloc(uv->buf_size); + uv->buffer =3D g_malloc0(uv->buf_size); + uv->pio_xfer_buffer =3D g_malloc0(uv->buf_size); break; case UEFI_VARS_REG_DMA_BUFFER_ADDR_LO: uv->buf_addr_lo =3D val; --=20 2.50.1 From nobody Sat Nov 15 05:33:51 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1754992957; cv=none; d=zohomail.com; s=zohoarc; b=aCqU0KoFe1gfV2YkUkZ5meOKATTzMlw2bcbVOOpKKeXVVd1UFOSzH1WXiODKPkw7+ClL81kqiLWmOZQqCFoiWeFvNdtdL6v4ghejm5Ju0QHPs9vnwm3GiCBhPt5n1nAa8sAf7Su+dy4skunsEFmX36vpb+vlWhFBTnwEvum9q5U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1754992957; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=HZIBu9E5mZXIA6EHZusH6ldSPFv2AgE11eh7RdqzdMg=; b=TE1vYRUWzvkZJiI3PHkxdSJfrUxjv4Zi+LkyYz4hfGwFIps4NtgDscUTH+gDK8bK7cze3Mo1C7Qd96QZtJL5z2hOIPd9OtAW0vkarnsJGwyyEUutrhUYFFI7n25tH90AK8QeKYMwMl/tp7rgu7PO4ALYUVAsyjuBAFIQRiDcpDE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1754992957847997.025000367433; Tue, 12 Aug 2025 03:02:37 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ullpF-0002I2-E2; Tue, 12 Aug 2025 06:01:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ullp2-0002EV-0O for qemu-devel@nongnu.org; Tue, 12 Aug 2025 06:01:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ullou-0004we-Lg for qemu-devel@nongnu.org; Tue, 12 Aug 2025 06:01:32 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-649-QBFIAeE9Nc21nr-_LnaWbw-1; Tue, 12 Aug 2025 06:01:18 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8070118004A7; Tue, 12 Aug 2025 10:01:17 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.45.224.64]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C82BF1955F16; Tue, 12 Aug 2025 10:01:16 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 5666C180038E; Tue, 12 Aug 2025 12:01:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754992884; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HZIBu9E5mZXIA6EHZusH6ldSPFv2AgE11eh7RdqzdMg=; b=emTMWdPo1feneBt5flxyKEVIw06LZqyXTgH4zWSp+2bbob0YuMvApaij0Fpr56M+n1YpHI +aymrsNFi0YQNvaObdjhOWdGCFQ7Zz4TkLJd2/imjBgGztbifwJ3ARvk8OfKwaretcU7Kh V23jzHZZtyTWDsxeJSZYZe/RKQOKxso= X-MC-Unique: QBFIAeE9Nc21nr-_LnaWbw-1 X-Mimecast-MFC-AGG-ID: QBFIAeE9Nc21nr-_LnaWbw_1754992877 From: Gerd Hoffmann To: qemu-devel@nongnu.org Cc: Gerd Hoffmann , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 2/4] hw/uefi: return success for notifications Date: Tue, 12 Aug 2025 12:01:08 +0200 Message-ID: <20250812100111.1520917-3-kraxel@redhat.com> In-Reply-To: <20250812100111.1520917-1-kraxel@redhat.com> References: <20250812100111.1520917-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1754992959237116600 Set status to SUCCESS for ready-to-boot and exit-boot-services notification calls. Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Gerd Hoffmann Message-ID: <20250811130110.820958-2-kraxel@redhat.com> --- hw/uefi/var-service-vars.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/uefi/var-service-vars.c b/hw/uefi/var-service-vars.c index 37d05b71cf70..cbeccdbd2664 100644 --- a/hw/uefi/var-service-vars.c +++ b/hw/uefi/var-service-vars.c @@ -702,12 +702,14 @@ uint32_t uefi_vars_mm_vars_proto(uefi_vars_state *uv) case SMM_VARIABLE_FUNCTION_READY_TO_BOOT: trace_uefi_event("ready-to-boot"); uv->ready_to_boot =3D true; + mvar->status =3D EFI_SUCCESS; length =3D 0; break; =20 case SMM_VARIABLE_FUNCTION_EXIT_BOOT_SERVICE: trace_uefi_event("exit-boot-service"); uv->exit_boot_service =3D true; + mvar->status =3D EFI_SUCCESS; length =3D 0; break; =20 --=20 2.50.1 From nobody Sat Nov 15 05:33:51 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1754992994; cv=none; d=zohomail.com; s=zohoarc; b=VwIGM97aEiQpyWzxlh3qblMEGWCXqkltYNI2TDNwcefp2pddZs/21054nRNGzNhlR0NlbKGDJ1Ttec5xq6/JUkwWdKTh7GDcWC2n+iS59CR5cFjoUgB5DegXYaRD6ctRjVPAqOX+lPn749mqxnCKiKyXxXvQaL1rnFUXktWFWcc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1754992994; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=uDxw3xNmM5Emh9dcYKX7SoeT/JGuEIT0empvXmChT1s=; b=EXSywtzLhXlpcxxQwmtpZ08JgvV4YACS/R3VgZJrgQIn1yBDZB/5v3h3pPKb1ICtUjaYw0I51CH/gYt1WPUUZRsGIQYSmf0j7Sy05DEZ4rAE4Do+0vg7FbZx6pG/x1/oAjR8oxrd9RdT9pX40/Go5EjmKDpXJqRDIvYbRKPZTGY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1754992994881394.37630309925305; Tue, 12 Aug 2025 03:03:14 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ullp5-0002FI-QO; Tue, 12 Aug 2025 06:01:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ullp0-0002E8-8q for qemu-devel@nongnu.org; Tue, 12 Aug 2025 06:01:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ullos-0004wD-Le for qemu-devel@nongnu.org; Tue, 12 Aug 2025 06:01:30 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-649-lEXz_sf1N66oP6gHBX_5og-1; Tue, 12 Aug 2025 06:01:18 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 395241800347; Tue, 12 Aug 2025 10:01:17 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.45.224.64]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CFC3530001A1; Tue, 12 Aug 2025 10:01:16 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 6451F1800390; Tue, 12 Aug 2025 12:01:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754992882; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uDxw3xNmM5Emh9dcYKX7SoeT/JGuEIT0empvXmChT1s=; b=Nx6x2xjc85BEtw+QlHQpbrgYVG+w1f1/2vjb2NlYDmZQFD1+YLV+NqCT4d8b+M6qMAHnlz RXmyrhDtvoXlWs0+NSA4IVy5WOOoGLHMlIMKd2rM9Mz29kznfWOJezP8wBd6VHaNk01n4s 3yQd0+HVQO+3yhHHKzts6vbIt3XI4ig= X-MC-Unique: lEXz_sf1N66oP6gHBX_5og-1 X-Mimecast-MFC-AGG-ID: lEXz_sf1N66oP6gHBX_5og_1754992877 From: Gerd Hoffmann To: qemu-devel@nongnu.org Cc: Gerd Hoffmann , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 3/4] hw/uefi: check access for first variable Date: Tue, 12 Aug 2025 12:01:09 +0200 Message-ID: <20250812100111.1520917-4-kraxel@redhat.com> In-Reply-To: <20250812100111.1520917-1-kraxel@redhat.com> References: <20250812100111.1520917-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1754993006415124102 When listing variables (via get-next-variable-name) only the names of variables which can be accessed will be returned. That check was missing for the first variable though. Add it. Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Gerd Hoffmann Message-ID: <20250811130110.820958-3-kraxel@redhat.com> --- hw/uefi/var-service-vars.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/uefi/var-service-vars.c b/hw/uefi/var-service-vars.c index cbeccdbd2664..8533533ea5c8 100644 --- a/hw/uefi/var-service-vars.c +++ b/hw/uefi/var-service-vars.c @@ -357,6 +357,9 @@ uefi_vars_mm_get_next_variable(uefi_vars_state *uv, mm_= header *mhdr, if (uefi_strlen(name, nv->name_size) =3D=3D 0) { /* empty string -> first */ var =3D QTAILQ_FIRST(&uv->variables); + while (var && !check_access(uv, var)) { + var =3D QTAILQ_NEXT(var, next); + } if (!var) { return uefi_vars_mm_error(mhdr, mvar, EFI_NOT_FOUND); } --=20 2.50.1 From nobody Sat Nov 15 05:33:51 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1754992957; cv=none; d=zohomail.com; s=zohoarc; b=BUyq+G4raftARCTuvHtSCQp6Vw0xrCvR5rr8VaApNJtbiBh8zKAQR43Khw2MFcI/lFGqWP7VNWaWbjKwwLE24spamZ4cDu9Qhlo9kTUN+N+R7JYDTIxt5gj7PlPn7tI+hQqmhUKlJFvf3BX8SxgRjgtpIzKKtLS26vw4EL4Qvq4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1754992957; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=UVB34e9Uj7epez3MD5LTEJ1aRum/LY79+Mc50gVpemg=; b=Lux76GALEzQa/tRbeRFX6XTilcCcgDAzCB5lGAAPotCcwrDfK2QA0wK9eY3C147Eo69JroPZH6/QRb9Zh3ktKbTlJ7iH2T0bdl1GEpHj5yv3xulx0jV5m6rE3vq1jeePTPpaJuuxa+7zppDhGIlfGTOw+qxT+TPawgqufWKQcow= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1754992957284686.1236455146636; Tue, 12 Aug 2025 03:02:37 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ullp9-0002H7-Hk; Tue, 12 Aug 2025 06:01:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ullp4-0002F4-1H for qemu-devel@nongnu.org; Tue, 12 Aug 2025 06:01:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ulloy-0004x7-Ps for qemu-devel@nongnu.org; Tue, 12 Aug 2025 06:01:36 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-36-G1eLbleIMK-o12qO-LA9cw-1; Tue, 12 Aug 2025 06:01:24 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0CDDC1800451; Tue, 12 Aug 2025 10:01:20 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.45.224.64]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BB4D61954199; Tue, 12 Aug 2025 10:01:19 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 72C461800393; Tue, 12 Aug 2025 12:01:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754992887; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UVB34e9Uj7epez3MD5LTEJ1aRum/LY79+Mc50gVpemg=; b=PAbfhYKrMjfAO2GhaPKXM9KWC5ioxR6tdp0JYyoi9Tz4ED1Cve+Mt+/ui4BdsvrL/MNPPn Z+O15pWbgFM+p32ERotBcY5aux3LLj49j2S6CFNevfTHDpjuZqJrcyKT93MX8WU7aumYU4 JOGwaUyZrCfsIIhIP7FrIdetFY3nBGg= X-MC-Unique: G1eLbleIMK-o12qO-LA9cw-1 X-Mimecast-MFC-AGG-ID: G1eLbleIMK-o12qO-LA9cw_1754992880 From: Gerd Hoffmann To: qemu-devel@nongnu.org Cc: Gerd Hoffmann , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 4/4] hw/uefi: open json file in binary mode Date: Tue, 12 Aug 2025 12:01:10 +0200 Message-ID: <20250812100111.1520917-5-kraxel@redhat.com> In-Reply-To: <20250812100111.1520917-1-kraxel@redhat.com> References: <20250812100111.1520917-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1754992959630124100 Fixes file length discrepancies due to line ending conversions on windows hosts. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3058 Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Gerd Hoffmann Message-ID: <20250811130110.820958-4-kraxel@redhat.com> --- hw/uefi/var-service-json.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/uefi/var-service-json.c b/hw/uefi/var-service-json.c index ad3462cd1557..f5f155683334 100644 --- a/hw/uefi/var-service-json.c +++ b/hw/uefi/var-service-json.c @@ -172,7 +172,7 @@ static GString *uefi_vars_to_json(uefi_vars_state *uv) void uefi_vars_json_init(uefi_vars_state *uv, Error **errp) { if (uv->jsonfile) { - uv->jsonfd =3D qemu_create(uv->jsonfile, O_RDWR, 0666, errp); + uv->jsonfd =3D qemu_create(uv->jsonfile, O_RDWR | O_BINARY, 0666, = errp); } } =20 --=20 2.50.1