From nobody Sat Nov 15 05:39:08 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=google.com ARC-Seal: i=1; a=rsa-sha256; t=1754948323; cv=none; d=zohomail.com; s=zohoarc; b=N79G2zwVKp9AbOyVOk25YLvPjpylEhEHBhBD06Al9QYhwn29BWzsd3bjh7nBKIDh8MXwxVqZNsIgN2morN+8R4lUK6f34ClcyXgKcyCAkfcVjRIevBwzEL2xIv0i0PE2whkiwQhYGV13jFhUMXJXdT5Bs4o2hL/wgHzxeYSwmnk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1754948323; h=Content-Type:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=eZmDu3jdm85zT/kkoUu6drjP5lcoEw7fmNxr6cvxvOc=; b=TWuzGmFU4ReaoQpFQLKEqnVRMDtdaDUzFUnv3zx6CLKRmd2PKKg6Tc8OEj0X6REq4yDvBP+H8+Tzb5H3Y36GIGuM8FKQJ+hQv7mzT2lpWVR7Xmeq9LXNpvQiQTn0N1qxQPc0fyFh7jxduWtHx9pDikfOZ4oFN20HbH48zoGgEbI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1754948323249607.9985486865115; Mon, 11 Aug 2025 14:38:43 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ulaCK-0007Fe-7P; Mon, 11 Aug 2025 17:36:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <3Y2KaaAgKCtw9FGJJGCPEMMEJC.AMKOCKS-BCTCJLMLELS.MPE@flex--bhillier.bounces.google.com>) id 1ulaCF-0007FS-Sv for qemu-devel@nongnu.org; Mon, 11 Aug 2025 17:36:47 -0400 Received: from mail-pf1-x449.google.com ([2607:f8b0:4864:20::449]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <3Y2KaaAgKCtw9FGJJGCPEMMEJC.AMKOCKS-BCTCJLMLELS.MPE@flex--bhillier.bounces.google.com>) id 1ulaCA-0001SC-3S for qemu-devel@nongnu.org; Mon, 11 Aug 2025 17:36:47 -0400 Received: by mail-pf1-x449.google.com with SMTP id d2e1a72fcca58-76bf8e79828so9280953b3a.3 for ; Mon, 11 Aug 2025 14:36:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1754948195; x=1755552995; darn=nongnu.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=eZmDu3jdm85zT/kkoUu6drjP5lcoEw7fmNxr6cvxvOc=; b=FfsWSXzUG1lpk611EoPBjJjYzGrVHCOL3qzOs4/QQCQ7esVEKilhrCHCvjiUb4QfAm ZuHwqSAEvUM/+EvAqsS1Lo6lDWAidI0aUqQssr/1r0E6qFrRP032OwFhkQWi6yP3k4xX Fq3BPaPAKfXQl4cgQmJ0GmRGGiOJxls5xJAMH/5YBj+VataiAEhiZlslJFBEwstdN0/e /3zFrzFVGJPKxah3wzsaAhoc4Ux+WeOeoPofPvnANx/XOjJs5Y5ViVQL9vtwf5MspJ83 /jYWNEVDydEUHogb01k6mAg5Iz2lWet5vN5ATNwCkGrBFy0wbK4pOT7H3sgbr9VeGeZP S3cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754948195; x=1755552995; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=eZmDu3jdm85zT/kkoUu6drjP5lcoEw7fmNxr6cvxvOc=; b=mLCMD3WTVqklSfUSjQfp5ioCpH+MpQypxrnaE38P88XY7+16CL31le4QI6mZGAJD9A YaWgkyEK/oPAtlCqek3vgOHW9zqPzkw80ypkzpRhvIJW7or3mKJh8UOhl3W3Lm9v7e7L yahekavpPh8GACGJaqTDE+23qGx4HkkDuDo/8cujeaOTVGx/7A5yBMR6t+D8RlhKvLzd ZWjlcr8VL1OtV+oVpFtrFzg/VwqpM35Gzk+aIehHkddERwsMfQr1vXK0znheUCiUCtYm 4QSxTYM5uS9Moo90EiSfDynE2jS8fUbSaSNVt6NFbZJ667CwxzCDeBoiiYukBGZTkUuA siTQ== X-Forwarded-Encrypted: i=1; AJvYcCXhFQWTLUPwbRV4GZUHsxGLrTkY0NKKSZzAJv2qJbvT2wJpzGOx6sSbtbVDJhy/7Pfw9dmHGyZDTv2J@nongnu.org X-Gm-Message-State: AOJu0YxEsLK/THyeyH1tQRML2Ry9DZ64/Dl396pfJk6WXTUNJNBxalnx ZmIPbxMpu9KypHtIzEsn+1EImNaypQK+rVTti3BMj8omuMGLXoUhpetH/eqiDvZnUkA9lsOcoQL RpN2+t1d/iFDz4w== X-Google-Smtp-Source: AGHT+IG94lKLP9Y8GMEv/VHbQbhw3MdTobj5no2b5qJW7sNIP6qpEjibOgqGlj2zML+Gk9MXsX71uxcrhuoXyA== X-Received: from pfbmy9-n2.prod.google.com ([2002:a05:6a00:6d49:20b0:76c:4298:869f]) (user=bhillier job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:4fce:b0:748:ed51:1305 with SMTP id d2e1a72fcca58-76c460906b2mr17113212b3a.5.1754948195094; Mon, 11 Aug 2025 14:36:35 -0700 (PDT) Date: Mon, 11 Aug 2025 21:36:31 +0000 Mime-Version: 1.0 X-Mailer: git-send-email 2.51.0.rc0.155.g4a0f42376b-goog Message-ID: <20250811213631.2197063-1-bhillier@google.com> Subject: [PATCH v2] hw/sensor: add stub for ADM1266 blackbox From: Ben Hillier To: wuhaotsh@google.com, kfting@nuvoton.com Cc: philmd@linaro.org, qemu-arm@nongnu.org, qemu-devel@nongnu.org, Titus Rwantare Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::449; envelope-from=3Y2KaaAgKCtw9FGJJGCPEMMEJC.AMKOCKS-BCTCJLMLELS.MPE@flex--bhillier.bounces.google.com; helo=mail-pf1-x449.google.com X-Spam_score_int: -98 X-Spam_score: -9.9 X-Spam_bar: --------- X-Spam_report: (-9.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.299, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01, USER_IN_DEF_DKIM_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @google.com) X-ZM-MESSAGEID: 1754948325349124100 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Titus Rwantare This patch fixes a bug that causes a kernel panic when calling ADM1266_BLAC= KBOX_INFORMATION. Log Message: adm1266 5-0042: Could not read blackbox! Kernel panic - not syncing: stack-protector: Kernel stack is corrupted in: = adm1266_nvmem_read+0x168/0x170 Signed-off-by: Titus Rwantare --- hw/sensor/adm1266.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/hw/sensor/adm1266.c b/hw/sensor/adm1266.c index 9017ce6116..cd11526c2b 100644 --- a/hw/sensor/adm1266.c +++ b/hw/sensor/adm1266.c @@ -75,6 +75,7 @@ typedef struct ADM1266State { static const uint8_t adm1266_ic_device_id[] =3D {0x03, 0x41, 0x12, 0x66}; static const uint8_t adm1266_ic_device_rev[] =3D {0x08, 0x01, 0x08, 0x07, = 0x0, 0x0, 0x07, 0x41, 0x30}; +static const uint8_t adm1266_blackbox_info[] =3D {0x04, 0x00, 0x00, 0x00, = 0x00}; =20 static void adm1266_exit_reset(Object *obj, ResetType type) { @@ -125,6 +126,17 @@ static uint8_t adm1266_read_byte(PMBusDevice *pmdev) pmbus_send(pmdev, adm1266_ic_device_rev, sizeof(adm1266_ic_device_= rev)); break; =20 + case ADM1266_BLACKBOX_CONFIG: + return 0; + + case ADM1266_READ_BLACKBOX: + return 0; + + case ADM1266_BLACKBOX_INFORMATION: + pmbus_send(pmdev, adm1266_blackbox_info, + sizeof(adm1266_blackbox_info)); + break; + default: qemu_log_mask(LOG_UNIMP, "%s: reading from unimplemented register: 0x%02x\n", @@ -154,6 +166,9 @@ static int adm1266_write_data(PMBusDevice *pmdev, const= uint8_t *buf, pmbus_receive_block(pmdev, (uint8_t *)s->mfr_rev, sizeof(s->mfr_re= v)); break; =20 + case ADM1266_BLACKBOX_CONFIG: + case ADM1266_READ_BLACKBOX: + case ADM1266_BLACKBOX_INFORMATION: case ADM1266_SET_RTC: /* do nothing */ break; =20 --=20 2.51.0.rc0.155.g4a0f42376b-goog