From nobody Mon Feb 9 13:53:30 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1754941215; cv=none; d=zohomail.com; s=zohoarc; b=QGWLQtSvj0QxM9U095ZTfe1ijWS6zglV+LZiOKk9ytE8NeHICMxvdHzagKFKqok/gdKH36Lxs46sik5j29Ew3iFNjCz4KrwAnqELNYRGNxuyz3DImMjATJlWSMS5BdRccTtEU3Z/r/UL16rNc7cTaAu/EDJq2Xx1E+WlbbtleXA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1754941215; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=bBQY3JDfi5sIsqu5HUp7kVZ6LoWCvvo+zOI9FAcYnaE=; b=GMei8buXQqUWECxtaiIq59kAYAWhrdqKr/1CQJj5BD9qU7Hq8ZxFuGkXHlkiC4qFexxdnbPFJ9yfY3rwQJP8PcG0Unri9Gk29AWMAsqdBxiZpDHCBycupDutuFz7pbReYMyFhWBbfKLKVQeuuk57ZIYQD2PPKCxlF14QSz3Wv3E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1754941215544928.5958010987799; Mon, 11 Aug 2025 12:40:15 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ulYKs-0007FL-K7; Mon, 11 Aug 2025 15:37:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ulYKd-0007D5-RI for qemu-devel@nongnu.org; Mon, 11 Aug 2025 15:37:21 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ulYKR-0003r2-Bk for qemu-devel@nongnu.org; Mon, 11 Aug 2025 15:37:19 -0400 Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57BBJE7s008171 for ; Mon, 11 Aug 2025 19:37:00 GMT Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48ffhjhev9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 11 Aug 2025 19:36:59 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-76c47324232so2932710b3a.0 for ; Mon, 11 Aug 2025 12:36:59 -0700 (PDT) Received: from admin15.qualcomm.com (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-76bccfbcef6sm27677171b3a.85.2025.08.11.12.36.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Aug 2025 12:36:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=bBQY3JDfi5s Isqu5HUp7kVZ6LoWCvvo+zOI9FAcYnaE=; b=oSkdoQPxebT128j1Hp84fj9kWRH sCAOgWRjax9wIRHLgOy9mZUoADSvzU9EC3Qh81Q5GtngbbK7y81SU6GfbUTTHe2P LLzI3ganok2QKx2Tv2TAoCdcO3FV3YHRue88a9ORwyaJ+mNYbiygxK1UEYwTMeWD PbVRK08RaUcdWbYuKyTmRvrruPce5NleJZBapapBDh3jXXybktsehT0FjilWhOIq 6Vm6jeL6HaerYlWXY92eqqN6UhsUo+GlGW0e9shuAGIzyLIwmUegMxpnmpqh0WkA Ero3h5bZozCY1clzTxTJHvj+9q3lHvqUFbHres6ngxfmrWDqaPXKolEMQxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754941018; x=1755545818; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bBQY3JDfi5sIsqu5HUp7kVZ6LoWCvvo+zOI9FAcYnaE=; b=j2zx/JMHRlUTfLtdAN08XfCuQ4tXXfCUQs2KI2X20o/VbhSY64K6B1BzIXNAp8GUcB L+KbgW9D5P2NRwaem1U44VvO+cmuf4cMh0Ck9Joh2K64DOt2Ewsb6ZKi2TAzZaYSB/GH RYv4BgyZtsyW0K/TNkoEjhokXdjXzj/n5yiO2ZfLBjZGdgSqWBRjnQmmN6vZtxy2+pz5 hEdkhBQiChL6Q6iz6sNLxSPp0cpgzO90ygSj1mYEhIGOHxqzyDXnoZJcAHaAPcVmocuF LcOfV/NPwFedRIMx9wFkcnCGVOJsMD2Ev8Y5hOgQjK8LB7/YTajm0zaO930kFkt1QJrU OCkw== X-Gm-Message-State: AOJu0YxjainrpTNNZheB5yusKtDvg3Cwr94aOSdS0t4dShHhOG5GmPYM CMN5157Ns5gMHSJNmynvjX7+L4qgEk9G3rKbOSzWtB+mNS4WLaOdlSnW5fkSbTvqGNii1l71Bzl eZJogEvhAcyh1mHeHvqWss/UL8ifMAcyCM/dYQxmsduUWjhn0we7BeEZGFOx0Qxu+NREE X-Gm-Gg: ASbGncswn9/huGMpuN9Ms9PmMgvVoPkaWcvJZnDTeBU3Npi4vUXP7Y44S3oq8zOYozl /EkiqaZMXQAaQDEYR+JyJV6ms11I2vFQG7VvHciTfPVk1VMp4fFkSnCfEE1Yf26a0i6PmzirDVV LVvYYq/HArieP691at2hLFRJ4KR13FSc0uPoiPvR+1jUASQi9PpYIofXh645xC7z/LzLFa6d//q ttdSIHvSS6iXnRrDUteb6asx59Z7Mnt10Gt25NCokqd4vA15Uj5m3sF+8qNc3cXrlS/MFFZSQsu fWMrIGDEuQwgXp8S+JzdyOcK8Czs4/i0Nm96oYuQTORGnPewCjG+Ig1lOwBpRrYQIwjMxIdKgB+ d8ougyvtf5CsFnSU= X-Received: by 2002:a05:6a21:32a3:b0:23d:de52:a5f0 with SMTP id adf61e73a8af0-24055204322mr22839558637.42.1754941018391; Mon, 11 Aug 2025 12:36:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFmle9vBKoxLagh8sWB8D2Zda0I8i/qcY6cxkD+vXIumb/y1I90opfpv8KW4iHC2k2pDa8ENg== X-Received: by 2002:a05:6a21:32a3:b0:23d:de52:a5f0 with SMTP id adf61e73a8af0-24055204322mr22839523637.42.1754941017984; Mon, 11 Aug 2025 12:36:57 -0700 (PDT) From: Vacha Bhavsar To: qemu-devel@nongnu.org Cc: Peter Maydell , qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Thomas Huth , Vacha Bhavsar Subject: [PATCH v5 1/4] target/arm: Increase MAX_PACKET_LENGTH for SME ZA Date: Mon, 11 Aug 2025 19:36:51 +0000 Message-Id: <20250811193654.4012878-2-vacha.bhavsar@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250811193654.4012878-1-vacha.bhavsar@oss.qualcomm.com> References: <20250811193654.4012878-1-vacha.bhavsar@oss.qualcomm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODExMDA3NCBTYWx0ZWRfX0WDIuWJa/Sls tJ9r2uQqIQNuNFwklz6NhaiPBIQLfCZ2vfJh4BtkZr0ne1GD1CuuT/C2bT44H+WgDhnPbooo3EA 6zfk9GYNod6OD1/70S55f5nGqmTcsYtyK475NXMOp2LS3h0bVq3zcza6JnRQ7ujxey3haxn7Cts o1kJpzDmihhPRIRMkSGLL76R+jJLn1aY2r3lb3E9UpJnhBHZ6MeqbdMZpv7qBUzGfauP1SoFbdQ yapcn3kT4l9xG9jTrABOynBRcB49g8MHGvM8lYIxy4Do3A4p3CD58aWUm75Phi1s1mqP4uKX+Pc 5+6vYGXWfyMfSVTnQoVf/CScuZIT3mqQewFENzlYd+xEWCzuWwB5EF8JA+Nl7j00+ILVPUy/BJr /YHF3oX/ X-Proofpoint-GUID: o7uqJhVgJkB5Hv_lbkCkCbUGv3PoGeXl X-Authority-Analysis: v=2.4 cv=TJFFS0la c=1 sm=1 tr=0 ts=689a465b cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=2OwXVqhp2XgA:10 a=CCpqsmhAAAAA:8 a=EUspDBNiAAAA:8 a=XJBTR8SIO4LSYOdVysIA:9 a=IoOABgeZipijB_acs4fv:22 a=ul9cdbp4aOFLsgKbc677:22 X-Proofpoint-ORIG-GUID: o7uqJhVgJkB5Hv_lbkCkCbUGv3PoGeXl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-11_04,2025-08-11_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 adultscore=0 impostorscore=0 malwarescore=0 phishscore=0 clxscore=1015 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508110074 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=vacha.bhavsar@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_PASS=-0.001, T_SPF_HELO_TEMPERROR=0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1754941217547124100 Content-Type: text/plain; charset="utf-8" This patch increases the value of the MAX_PACKET_LEGNTH to 131104 from 4096 to allow the GDBState.line_buf to be large enough to accommodate the full contents of the SME ZA storage when the vector length is maximal. This is in preparation for a related patch that allows SME register visibility through remote GDB debugging. Signed-off-by: Vacha Bhavsar Reviewed-by: Peter Maydell --- Changes since v4: - the value for MAX_PACKET_LENGTH is changed from 131100 to 131104 to align with a similar update made to gdbserver --- gdbstub/internals.h | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/gdbstub/internals.h b/gdbstub/internals.h index bf5a5c6302..87f64b6318 100644 --- a/gdbstub/internals.h +++ b/gdbstub/internals.h @@ -11,7 +11,27 @@ =20 #include "exec/cpu-common.h" =20 -#define MAX_PACKET_LENGTH 4096 +/* +* Most "large" transfers (e.g. memory reads, feature XML +* transfer) have mechanisms in the gdb protocol for splitting +* them. However, register values in particular cannot currently +* be split. This packet size must therefore be at least big enough +* for the worst-case register size. Currently that is Arm SME +* ZA storage with a 256x256 byte value. We also must account +* for the conversion from raw data to hex in gdb_memtohex(), +* which writes 2 * size bytes, and for other protocol overhead +* including command, register number and checksum which add +* another 4 bytes of overhead. However, to be consistent with +* the changes made in gdbserver to address this same requirement, +* we add a total of 32 bytes to account for protocol overhead +* (unclear why specifically 32 bytes), bringing the value of=20 +* MAX_PACKET_LENGTH to 2 * 256 * 256 + 32 =3D 131104. +* +* The commit making this change for gdbserver can be found here: +* https://sourceware.org/git/?p=3Dbinutils-gdb.git;a=3Dcommit;h=3D +* b816042e88583f280ad186ff124ab84d31fb592b +*/ +#define MAX_PACKET_LENGTH 131104 =20 /* * Shared structures and definitions --=20 2.34.1 From nobody Mon Feb 9 13:53:30 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1754941161; cv=none; d=zohomail.com; s=zohoarc; b=UMR5UXnjcYsfeNjdKcGePh6g8GvinD0yMtPsjPFn089fq91IbdfRkuKD7NkDlVd4xcVMCliS40FsIDubwY61OWXD0nDFuy1pGiMwgjJ8uXmC6ecM/Emni5KFgZTSgpRikciKnUbgm7cYb37Tau2C8ClbRB9s0KIV8uhBy/GIcXo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1754941161; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=kTCG4odqlk4I31FckedmmBZfTyjLctBkXvzLD9hftMI=; b=LJlt3M/8D0N+ZjafYiyOUMw727eG3/nZvOSQ+NQG0ceX8P9N5Oso3ui/O0WXVQcDNbuOOHslyZ9d6F8Odb4/VqfjDJJjquJ+cqFeirE9TrirSYISuOq1uNn33JelJXDCWVZAwavTjqt/8BBBWeEmst3/OqEJJgwJN7Wubtj4iPE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1754941161905481.0091193751871; Mon, 11 Aug 2025 12:39:21 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ulYL3-0007JC-6y; Mon, 11 Aug 2025 15:37:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ulYKh-0007Dn-Ft for qemu-devel@nongnu.org; Mon, 11 Aug 2025 15:37:27 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ulYKR-0003rX-Jv for qemu-devel@nongnu.org; Mon, 11 Aug 2025 15:37:22 -0400 Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57BGW383022560 for ; Mon, 11 Aug 2025 19:37:01 GMT Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48fm3vggcn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 11 Aug 2025 19:37:01 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-76bf8e79828so9094079b3a.3 for ; Mon, 11 Aug 2025 12:37:01 -0700 (PDT) Received: from admin15.qualcomm.com (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-76bccfbcef6sm27677171b3a.85.2025.08.11.12.36.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Aug 2025 12:36:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=kTCG4odqlk4 I31FckedmmBZfTyjLctBkXvzLD9hftMI=; b=YvyoM7Nrz9Utd/f3AJsGiHbc830 p7dJ1sXW40ZAOaP90AEaY4sqmg5MnpuqXYt/nyqjkgmsxqodT3BNJr2ONMdva8Om aK/a3t9RVIYOhSnbOxKG6LvkoxnzkaXIj19emqN2QZVMvW/y7AeogjcCGGpUUrNp la4PsuC+rDoLStZrVJWzajJ5A8OnicHA+EeFD/XOAAegFqN7r/f/n34NIsNqvKe0 5BjDct9PuhB2hcRa3BpM3yo9BUibpUjpwKqmmC+XpA88Jo/w7gqxaaqJiEqcFK9G rMzI9WGD2laBPXbZH4oUEu09XEtohvCch7QXQs0WAJXmlFZ2EojZlxhFZgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754941020; x=1755545820; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kTCG4odqlk4I31FckedmmBZfTyjLctBkXvzLD9hftMI=; b=El166ZYROAObLZUidH8FjbuQlCPVNc13gCAGuE5W5WEPNh7WwWDlfuVz+tjmp2H+Jj /aKUS0tYHrKBhVvm6LuqozlQS7j78tUOQKLAkVh4VRAQ9jCr+BNkEeuBZFnllXEVfKcW 6Z383EiOcpssh+3PEmGxC4FogPv9BgiTKiNCWZqMDYSVp2w16KRtTEaY7yRgFeq7MaSV 4aCkZXci+1YpYb6opKxM6A+Y4muBwLwwQavoM4SGjoHmAUBdz75FxNPnLt1FsDjaSAlv dB25eXcd/LyVA7BSl/CgQkBxEXrfLDdEmk/PwcG3aIHtsNJqeWwf0w8+A7LXZ79WsERh 7zbQ== X-Gm-Message-State: AOJu0YwGKWzik0Bees+aUXt3qxaWsNtHHpsRO6/IIh0zIb0Vwn1LFCRu Pwf2Bs9FwsUEY+bTar+QQ6UdpEy4bBaNh+n8VklV4WpjHKzZEtGQ2l4GryZMd5wm91x9RAsfAA/ 1cfEu6xx6ayYGkYt1SWcFC+uXgYHiqkm7h4GklW+uScyFbIJFmUJazlqlHlssHfkaJ9aY X-Gm-Gg: ASbGncs1qzzll7E5kRJYPNaE37e8GoydlrVxodFY4UFTobFaPgeKBj9W0nn1WA72V7o UO3ytWbaGC7HOIT8hIBA1IknUX3QAU85r6lTl4FXrtI2Er+I7f6jpIIHRNjHZNSHb92GZaddBj0 VOQsCP1lQnEauC5h/6+WYYiDq9JzCs372padeyRfC/71TklDLJ+ah7fGLs6Jv66oI8hkmBUWUoI Uczzrh6NIKu4VpaAFfb7y6X7g6R6b2o5VXguTAdey3dP4tEJBKLqnPZyX8K83MvD73zjiyV4AGe wwPvpj4l+FZWoysY5vMVYt5ckGO2F/4HsFAvsj7egHrEJjZ8xIovt7NMwzGvBG6wsJbHlLqXjSm H0wjzSVvZa8nNvqM= X-Received: by 2002:a05:6a00:14cc:b0:748:f750:14c6 with SMTP id d2e1a72fcca58-76c4615bd8cmr20210597b3a.14.1754941019698; Mon, 11 Aug 2025 12:36:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFKY/+VMA4PGeSzQIazQ5ZD0pwlpk82BzSIgQzHx6RHSkmcgZaY3DKMeQMifr4wZ3Y0/xK7dQ== X-Received: by 2002:a05:6a00:14cc:b0:748:f750:14c6 with SMTP id d2e1a72fcca58-76c4615bd8cmr20210563b3a.14.1754941019262; Mon, 11 Aug 2025 12:36:59 -0700 (PDT) From: Vacha Bhavsar To: qemu-devel@nongnu.org Cc: Peter Maydell , qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Thomas Huth , Vacha Bhavsar Subject: [PATCH v5 2/4] target/arm: Change GDBState's line_buf to a GString Date: Mon, 11 Aug 2025 19:36:52 +0000 Message-Id: <20250811193654.4012878-3-vacha.bhavsar@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250811193654.4012878-1-vacha.bhavsar@oss.qualcomm.com> References: <20250811193654.4012878-1-vacha.bhavsar@oss.qualcomm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODExMDEwNyBTYWx0ZWRfX7rg3lAmh9H4Z 9aoCjSZ8o+Sx6SZTP0CitobNhP/WjLDQpo1cQlH+bfKDEW5saewyZ5Ei+2zkg7HKu/fE391psHq v1rYz07Cc+skWVggVZ8TwzX3aSE4r+NkBR14nCsXZf0uLeFqetC+oygZNX9rB+R2pz3xWJPpKUY 4gwJJSvGp/vyeB0PHwWfJSGsNrpSjDAd+uWgTd1Yrp2TyEvwCrKawsuWgCR4FJbY7jjISuxvnl7 gEuGmabCAoQBTlpfX1jLju3Qh66R3KKD8Y6tNAxUsw/vUW7i50NKckxzEma14GcROlpNjibEu1p nKqh7D1K6he3Qli5YVUiH+nx9EraXiklEXCYkMsZ918aRRVy8eST9+qbs9v6eTV3mGrSQij/Ihm qrSHTXie X-Proofpoint-GUID: VH6TMhomdvMMGg8Ik19t1DSC5yIbiJMe X-Authority-Analysis: v=2.4 cv=A+1sP7WG c=1 sm=1 tr=0 ts=689a465d cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=2OwXVqhp2XgA:10 a=EUspDBNiAAAA:8 a=w1AtNIWgmVDSpf7mFgMA:9 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-ORIG-GUID: VH6TMhomdvMMGg8Ik19t1DSC5yIbiJMe X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-11_04,2025-08-11_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 priorityscore=1501 malwarescore=0 spamscore=0 phishscore=0 clxscore=1015 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508110107 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=vacha.bhavsar@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1754941163535116600 Content-Type: text/plain; charset="utf-8" This patch changes GDBState's line_buf from a character array to a GString. This allows line_buf to be dynamically re-sizeable. Signed-off-by: Vacha Bhavsar --- Changes since v4: - this patch was not present in v4, it has been added as suggested during review of v4 --- gdbstub/gdbstub.c | 25 +++++++++++++------------ gdbstub/internals.h | 3 +-- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index dd5fb5667c..0634ff9e91 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -64,6 +64,7 @@ void gdb_init_gdbserver_state(void) memset(&gdbserver_state, 0, sizeof(GDBState)); gdbserver_state.init =3D true; gdbserver_state.str_buf =3D g_string_new(NULL); + gdbserver_state.line_buf =3D g_string_new(NULL); gdbserver_state.mem_buf =3D g_byte_array_sized_new(MAX_PACKET_LENGTH); gdbserver_state.last_packet =3D g_byte_array_sized_new(MAX_PACKET_LENG= TH + 4); =20 @@ -2369,7 +2370,7 @@ void gdb_read_byte(uint8_t ch) case RS_IDLE: if (ch =3D=3D '$') { /* start of command packet */ - gdbserver_state.line_buf_index =3D 0; + g_string_set_size(gdbserver_state.line_buf, 0); gdbserver_state.line_sum =3D 0; gdbserver_state.state =3D RS_GETLINE; } else if (ch =3D=3D '+') { @@ -2393,12 +2394,12 @@ void gdb_read_byte(uint8_t ch) } else if (ch =3D=3D '#') { /* end of command, start of checksum*/ gdbserver_state.state =3D RS_CHKSUM1; - } else if (gdbserver_state.line_buf_index >=3D sizeof(gdbserve= r_state.line_buf) - 1) { + } else if (gdbserver_state.line_buf->len >=3D MAX_PACKET_LENGT= H) { trace_gdbstub_err_overrun(); gdbserver_state.state =3D RS_IDLE; } else { /* unescaped command character */ - gdbserver_state.line_buf[gdbserver_state.line_buf_index++]= =3D ch; + g_string_append_c(gdbserver_state.line_buf, (gchar) ch); gdbserver_state.line_sum +=3D ch; } break; @@ -2406,13 +2407,13 @@ void gdb_read_byte(uint8_t ch) if (ch =3D=3D '#') { /* unexpected end of command in escape sequence */ gdbserver_state.state =3D RS_CHKSUM1; - } else if (gdbserver_state.line_buf_index >=3D sizeof(gdbserve= r_state.line_buf) - 1) { + } else if (gdbserver_state.line_buf->len >=3D MAX_PACKET_LENGT= H) { /* command buffer overrun */ trace_gdbstub_err_overrun(); gdbserver_state.state =3D RS_IDLE; } else { /* parse escaped character and leave escape state */ - gdbserver_state.line_buf[gdbserver_state.line_buf_index++]= =3D ch ^ 0x20; + g_string_append_c(gdbserver_state.line_buf, (gchar) ch ^ 0= x20); gdbserver_state.line_sum +=3D ch; gdbserver_state.state =3D RS_GETLINE; } @@ -2429,19 +2430,20 @@ void gdb_read_byte(uint8_t ch) } else { /* decode repeat length */ int repeat =3D ch - ' ' + 3; - if (gdbserver_state.line_buf_index + repeat >=3D sizeof(gd= bserver_state.line_buf) - 1) { + if (gdbserver_state.line_buf->len + repeat >=3D MAX_PACKET= _LENGTH) { /* that many repeats would overrun the command buffer = */ trace_gdbstub_err_overrun(); gdbserver_state.state =3D RS_IDLE; - } else if (gdbserver_state.line_buf_index < 1) { + } else if (gdbserver_state.line_buf->len < 1) { /* got a repeat but we have nothing to repeat */ trace_gdbstub_err_invalid_rle(); gdbserver_state.state =3D RS_GETLINE; } else { /* repeat the last character */ - memset(gdbserver_state.line_buf + gdbserver_state.line= _buf_index, - gdbserver_state.line_buf[gdbserver_state.line_b= uf_index - 1], repeat); - gdbserver_state.line_buf_index +=3D repeat; + for (int i =3D 0; i < repeat; i ++){ + g_string_append_c(gdbserver_state.line_buf,=20 + gdbserver_state.line_buf->str[gdbserver_state.= line_buf->len - 1]); + } gdbserver_state.line_sum +=3D ch; gdbserver_state.state =3D RS_GETLINE; } @@ -2454,7 +2456,6 @@ void gdb_read_byte(uint8_t ch) gdbserver_state.state =3D RS_GETLINE; break; } - gdbserver_state.line_buf[gdbserver_state.line_buf_index] =3D '= \0'; gdbserver_state.line_csum =3D fromhex(ch) << 4; gdbserver_state.state =3D RS_CHKSUM2; break; @@ -2477,7 +2478,7 @@ void gdb_read_byte(uint8_t ch) /* send ACK reply */ reply =3D '+'; gdb_put_buffer(&reply, 1); - gdbserver_state.state =3D gdb_handle_packet(gdbserver_stat= e.line_buf); + gdbserver_state.state =3D gdb_handle_packet((char *) gdbse= rver_state.line_buf->str); } break; default: diff --git a/gdbstub/internals.h b/gdbstub/internals.h index 87f64b6318..27afbef4f5 100644 --- a/gdbstub/internals.h +++ b/gdbstub/internals.h @@ -72,8 +72,7 @@ typedef struct GDBState { CPUState *g_cpu; /* current CPU for other ops */ CPUState *query_cpu; /* for q{f|s}ThreadInfo */ enum RSState state; /* parsing state */ - char line_buf[MAX_PACKET_LENGTH]; - int line_buf_index; + GString *line_buf; int line_sum; /* running checksum */ int line_csum; /* checksum at the end of the packet */ GByteArray *last_packet; --=20 2.34.1 From nobody Mon Feb 9 13:53:30 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1754941220; cv=none; d=zohomail.com; s=zohoarc; b=MwryV4PJn3wwmd1bSNC2x7uE7cEccOgC+bjxZmMh5aNseHPDB3QZPPs4jbY5Os3VPN4ma5IxF4arwtxIC8qI1eawdHlvdmI3ct9+vbYVCTARPdlc4GnsrmxE8Ok0cEyf1I8fUNB5VOFZ0xmrIQ+rNKt44oAcZX9A26LTxSXd0WY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1754941220; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=7rQftNpdawuun3GG01df+hVC7NJaB4/u1DcHDd2SFC8=; b=HUNl2CcrbcZX3c8Uunk9PRtscmzWhcnFzL0I9AUF6IuxryXiGBtDTNVFivvx/wLkPHVjW711LHeVZIP6yckjJB6qjGS04XqPPKbO79a0H2t3db0ylL0XgU2mM5NwDfBbCgLx2CS2rgT8WjzEhS5u/AHuNd3XmmCHN0Ie76T6xVs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1754941220054547.871786400986; Mon, 11 Aug 2025 12:40:20 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ulYKv-0007HK-Kh; Mon, 11 Aug 2025 15:37:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ulYKj-0007E1-2r for qemu-devel@nongnu.org; Mon, 11 Aug 2025 15:37:27 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ulYKS-0003rz-Vh for qemu-devel@nongnu.org; Mon, 11 Aug 2025 15:37:24 -0400 Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57BGwLmv018342 for ; Mon, 11 Aug 2025 19:37:02 GMT Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48dy3g5jj7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 11 Aug 2025 19:37:02 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-76be6f0bbfdso6123680b3a.2 for ; Mon, 11 Aug 2025 12:37:02 -0700 (PDT) Received: from admin15.qualcomm.com (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-76bccfbcef6sm27677171b3a.85.2025.08.11.12.36.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Aug 2025 12:37:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=7rQftNpdawu un3GG01df+hVC7NJaB4/u1DcHDd2SFC8=; b=pE4gYxzd/VwzSgneXnLHIm0YRPs CLGweaQX1Rsr6tGvSl99e85nJdhMzSufSXSNVDinZRydbTkDdOSg5JTef0cuNHJI ufUHTPfggEe6tgIdd/KxFsE4O515UvtXKZrLdupQQjp/QXNi8+akCUt/8nFnSr02 TWykuNoO2dO6xf5QkztvLiKEZOf8sVEmAu5BAxDGb/Hr0gGSZvplaK54npgu2zv+ eQpTzeyOIaSDtGCh65aroJbgO1OFiYMGUBwpHuIYijfkTcG+PjsOMwYZ3wu5OJTq Hf8OeVSKYdSuXF7htWSvuECfefSrfwR3ZTwS4nr1A+yeC2k1RbtpRK+/IQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754941021; x=1755545821; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7rQftNpdawuun3GG01df+hVC7NJaB4/u1DcHDd2SFC8=; b=qxTiEDQ1+E1BRKS8bWenGos+QVrQWhD/MRw8OvtmELPNIWUVb8kCb/Sb4x01sFax3D 7UKMNiVah3GRs5NulUZRS+NywAILfjJAZ+VG1R7FHtNSqSwDuSwpoom9g5KZCcKjS/qu Nfp2XeW0wPsIraYCXWxUMelOzU6bWj9sCidrEwSRoI/XquqGZTH08cP4KDHDt36zZm+t BZd1c1X6tgZb/hyguDLrDDGh9A5gOI+5yrv7sfzStgaLTwlBR4vAMfA1aoq9TleYwQrU /e1El1CDBfX8KUmTW2FMdITsgO2MvH0d8W3vMUH4588YZtR7s//B/1Fhr3DeyXT3zv2J 8gig== X-Gm-Message-State: AOJu0YzfM3+wc2nqlQ3qlQhzqzM12K7Kt4528mubgehNwujHdrRtIjfJ 7ULqgUyFBUPRTRAKTF36p+j9zsfCbKfl5zdx7d+repr33tLmQaJoxnjP/amyHOUIw9S0YgP46zC uq1dnSPtt48CRkT/1lLNdGy6JEMhFYdHRv/c0cwSv0sg7NcLSSvhpR3x3nGCssi0DZlBV X-Gm-Gg: ASbGncusDlbHIg1RrP+LNRHGN2zyFNuOVNtH9QliLy2Td2yX+u23tH/qGY3y54OUEsf XvEfbdEqxiFCD/XhviQg0LnGKBxNp7aDRMqkMmDEsEM9cyUW+LbRFV6grfTrL8lj2h3QDO5xU0d 0KWNJ1VrTDd+AFSZz25cOjYlt3wsde7NMdOyH/mH35SjRAOJG+FNPtH1Skwun2D6OqyispHUyGY oz/ObmEVNJdB4FsOv3uWTPYKeHMZsDBPyXGsKoO8oYlv/+OirdTiLizJX2KoapCYMOljD91rndN yVKOhX3aA+aYvkn0q1gV6826/uKLSaM8WKLPOh0dy/YLy5LW+y2otzygI6ridHs5aOoSwZkwkup FDlK8mL1kd4looyg= X-Received: by 2002:a05:6a00:852:b0:76b:42e5:fa84 with SMTP id d2e1a72fcca58-76c460af27bmr18420228b3a.7.1754941020997; Mon, 11 Aug 2025 12:37:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGdfQOSV/vy73V1stugvh+APrpPn3MN/3GDT0yWkuig7fCUn3k2T3W3oxzQzrTDLpAWt2Q1Mg== X-Received: by 2002:a05:6a00:852:b0:76b:42e5:fa84 with SMTP id d2e1a72fcca58-76c460af27bmr18420199b3a.7.1754941020521; Mon, 11 Aug 2025 12:37:00 -0700 (PDT) From: Vacha Bhavsar To: qemu-devel@nongnu.org Cc: Peter Maydell , qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Thomas Huth , Vacha Bhavsar Subject: [PATCH v5 3/4] target/arm: Added support for SME register exposure to Date: Mon, 11 Aug 2025 19:36:53 +0000 Message-Id: <20250811193654.4012878-4-vacha.bhavsar@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250811193654.4012878-1-vacha.bhavsar@oss.qualcomm.com> References: <20250811193654.4012878-1-vacha.bhavsar@oss.qualcomm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=X4lSKHTe c=1 sm=1 tr=0 ts=689a465e cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=2OwXVqhp2XgA:10 a=EUspDBNiAAAA:8 a=BNg5ujFbbBWOBbuzlAkA:9 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODA5MDAzMSBTYWx0ZWRfX7F8So1zjpcBG XYqjHAw3x9uyuOvDcLgpQsYXW1BqG4zI2NVptKl6fleKvIO+BsmYEP6yLgC47OU11xQkfkpWt9I Uc/ASeIjU0c0U14qOsQd7k7qkojtKPgZnq8GvaYx1OYCQEaua7RzjJF+HWpkBJA2EfFkhdOtt5k u9nWTw6doak1gJbvC2yd6sNuXZCcm7V6kOHgPSlfvzu3xPbwOk5bmdzPOwT7/oODfeM+Xs6Wa9L LAcqdJnIXIcO1iIaiHSmPJb9MYpA6T3gkg+plGwLDufKcvMHtWcaIvd5xOEcnKdSdExPopLRrQP h2IGjJppw7n/FnGQZ+kbxE0zU72yY/PmsUCAyerAbo6pTDFtajTkbOtAenk6sXQV5VKWtkwJjJ7 T4gg+wbu X-Proofpoint-GUID: m3jtNUtG5yBkoRZcxdN6EEyhtKlXzu2K X-Proofpoint-ORIG-GUID: m3jtNUtG5yBkoRZcxdN6EEyhtKlXzu2K X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-11_04,2025-08-11_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 adultscore=0 spamscore=0 bulkscore=0 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508090031 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=vacha.bhavsar@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1754941222653116600 Content-Type: text/plain; charset="utf-8" The QEMU GDB stub does not expose the ZA storage SME register to GDB via the remote serial protocol, which can be a useful functionality to debug SME code. To provide this functionality in Aarch64 target, this patch registers= the SME register set with the GDB stub. To do so, this patch implements the aarch64_gdb_get_sme_reg() and aarch64_gdb_set_sme_reg() functions to specify how to get and set the SME registers, and the arm_gen_dynamic_smereg_feature() function to generate the target description in XML format to indicate the target architecture supports SME. Finally, this patch includes a dyn_smereg_feature structure to hold this GDB XML description of the SME registers for each CPU. Signed-off-by: Vacha Bhavsar --- target/arm/cpu.h | 1 + target/arm/gdbstub.c | 6 ++ target/arm/gdbstub64.c | 122 +++++++++++++++++++++++++++++++++++++++++ target/arm/internals.h | 3 + 4 files changed, 132 insertions(+) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index dc9b6dce4c..8bd66d7049 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -933,6 +933,7 @@ struct ArchCPU { =20 DynamicGDBFeatureInfo dyn_sysreg_feature; DynamicGDBFeatureInfo dyn_svereg_feature; + DynamicGDBFeatureInfo dyn_smereg_feature; DynamicGDBFeatureInfo dyn_m_systemreg_feature; DynamicGDBFeatureInfo dyn_m_secextreg_feature; =20 diff --git a/target/arm/gdbstub.c b/target/arm/gdbstub.c index ce4497ad7c..4371a367a0 100644 --- a/target/arm/gdbstub.c +++ b/target/arm/gdbstub.c @@ -531,6 +531,12 @@ void arm_cpu_register_gdb_regs_for_features(ARMCPU *cp= u) GDBFeature *feature =3D arm_gen_dynamic_svereg_feature(cs, cs-= >gdb_num_regs); gdb_register_coprocessor(cs, aarch64_gdb_get_sve_reg, aarch64_gdb_set_sve_reg, feature, 0); + if (isar_feature_aa64_sme(&cpu->isar)) { + GDBFeature *sme_feature =3D arm_gen_dynamic_smereg_feature= (cs, + cs->gdb_num_regs); + gdb_register_coprocessor(cs, aarch64_gdb_get_sme_reg, + aarch64_gdb_set_sme_reg, sme_feature, 0); + } } else { gdb_register_coprocessor(cs, aarch64_gdb_get_fpu_reg, aarch64_gdb_set_fpu_reg, diff --git a/target/arm/gdbstub64.c b/target/arm/gdbstub64.c index 08e2858539..047b1f8133 100644 --- a/target/arm/gdbstub64.c +++ b/target/arm/gdbstub64.c @@ -249,6 +249,91 @@ int aarch64_gdb_set_sve_reg(CPUState *cs, uint8_t *buf= , int reg) return 0; } =20 +int aarch64_gdb_get_sme_reg(CPUState *cs, GByteArray *buf, int reg) +{ + ARMCPU *cpu =3D ARM_CPU(cs); + CPUARMState *env =3D &cpu->env; + + switch (reg) { + /* Svg register */ + case 0: + { + int vq =3D 0; + if (FIELD_EX64(env->svcr, SVCR, SM)) { + vq =3D sve_vqm1_for_el_sm(env, arm_current_el(env), + FIELD_EX64(env->svcr, SVCR, SM)) + 1; + } + /* svg =3D vector granules (2 * vector quardwords) in streaming mo= de */ + return gdb_get_reg64(buf, vq * 2); + } + case 1: + return gdb_get_reg64(buf, env->svcr); + case 2: + { + int len =3D 0; + int vq =3D cpu->sme_max_vq; + int svl =3D vq * 16; + for (int i =3D 0; i < svl; i++) { + for (int q =3D 0; q < vq; q++) { + len +=3D gdb_get_reg128(buf, + env->za_state.za[i].d[q * 2 + 1], + env->za_state.za[i].d[q * 2]); + } + } + return len; + } + default: + /* gdbstub asked for something out of range */ + qemu_log_mask(LOG_UNIMP, "%s: out of range register %d", __func__,= reg); + break; + } + + return 0; +} + +int aarch64_gdb_set_sme_reg(CPUState *cs, uint8_t *buf, int reg) +{ + ARMCPU *cpu =3D ARM_CPU(cs); + CPUARMState *env =3D &cpu->env; + + switch (reg) { + case 0: + { + /* cannot set svg via gdbstub */ + return 8; + } + case 1: + aarch64_set_svcr(env, ldq_le_p(buf), + R_SVCR_SM_MASK | R_SVCR_ZA_MASK); + return 8; + case 2: + int len =3D 0; + int vq =3D cpu->sme_max_vq; + int svl =3D vq * 16; + for (int i =3D 0; i < svl; i++) { + for (int q =3D 0; q < vq; q++) { + if (target_big_endian()){ + env->za_state.za[i].d[q * 2 + 1] =3D ldq_p(buf); + buf +=3D 8; + env->za_state.za[i].d[q * 2] =3D ldq_p(buf); + } else{ + env->za_state.za[i].d[q * 2] =3D ldq_p(buf); + buf +=3D 8; + env->za_state.za[i].d[q * 2 + 1] =3D ldq_p(buf); + } + buf +=3D 8; + len +=3D 16; + } + } + return len; + default: + /* gdbstub asked for something out of range */ + break; + } + + return 0; +} + int aarch64_gdb_get_pauth_reg(CPUState *cs, GByteArray *buf, int reg) { ARMCPU *cpu =3D ARM_CPU(cs); @@ -413,6 +498,43 @@ GDBFeature *arm_gen_dynamic_svereg_feature(CPUState *c= s, int base_reg) return &cpu->dyn_svereg_feature.desc; } =20 +GDBFeature *arm_gen_dynamic_smereg_feature(CPUState *cs, int base_reg) +{ + ARMCPU *cpu =3D ARM_CPU(cs); + int vq =3D cpu->sme_max_vq; + int svl =3D vq * 16; + GDBFeatureBuilder builder; + int reg =3D 0; + + gdb_feature_builder_init(&builder, &cpu->dyn_smereg_feature.desc, + "org.gnu.gdb.aarch64.sme", "sme-registers.xml", base_reg); + + + /* Create the sme_bv vector type. */ + gdb_feature_builder_append_tag(&builder, + "", + svl); + + /* Create the sme_bvv vector type. */ + gdb_feature_builder_append_tag( + &builder, "", + svl); + + /* Define the svg, svcr, and za registers. */ + + /* fpscr & status registers */ + gdb_feature_builder_append_reg(&builder, "svg", 64, reg++, + "int", NULL); + gdb_feature_builder_append_reg(&builder, "svcr", 64, reg++, + "int", NULL); + gdb_feature_builder_append_reg(&builder, "za", svl * svl * 8, reg++, + "sme_bvv", NULL); + + gdb_feature_builder_end(&builder); + + return &cpu->dyn_smereg_feature.desc; +} + #ifdef CONFIG_USER_ONLY int aarch64_gdb_get_tag_ctl_reg(CPUState *cs, GByteArray *buf, int reg) { diff --git a/target/arm/internals.h b/target/arm/internals.h index 1b3d0244fd..41e05066b9 100644 --- a/target/arm/internals.h +++ b/target/arm/internals.h @@ -1802,8 +1802,11 @@ static inline uint64_t pmu_counter_mask(CPUARMState = *env) } =20 GDBFeature *arm_gen_dynamic_svereg_feature(CPUState *cpu, int base_reg); +GDBFeature *arm_gen_dynamic_smereg_feature(CPUState *cpu, int base_reg); int aarch64_gdb_get_sve_reg(CPUState *cs, GByteArray *buf, int reg); int aarch64_gdb_set_sve_reg(CPUState *cs, uint8_t *buf, int reg); +int aarch64_gdb_get_sme_reg(CPUState *cs, GByteArray *buf, int reg); +int aarch64_gdb_set_sme_reg(CPUState *cs, uint8_t *buf, int reg); int aarch64_gdb_get_fpu_reg(CPUState *cs, GByteArray *buf, int reg); int aarch64_gdb_set_fpu_reg(CPUState *cs, uint8_t *buf, int reg); int aarch64_gdb_get_pauth_reg(CPUState *cs, GByteArray *buf, int reg); --=20 2.34.1 From nobody Mon Feb 9 13:53:30 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1754941162; cv=none; d=zohomail.com; s=zohoarc; b=cmfy6AWXZrrIZbQqbRi6kM56ISX+Z4cJ6H4W4IzrHeh8nQZEB/RpC3JHcmNrjb5Axn8GvsNHERsd6/q0Q9rtl4I5K6j5fkjT0QNVo0I/d++SniQMt+yYD6IrrVs6+Iy94sFCU1Yt7u6/52FCC8fd7WJhULnLbvRWHLhboLY54Zk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1754941162; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=oeFCTcBeYBuAaNVMoPz5tm7BdWNU7A6jatOQ6V3bflg=; b=BiWl6qaYpUrm8hczmSbn1xl/oBXI7Ky3xpp2lVg0ESzENxmj9rfl1dPLInJRsoi1jtmM2FmY+3kaq0jD1em8y3tdwBeawPe+jc/8hswbD4CkWXgSDuE+mDrCOk0dp36gwPF2A6+PRrR/toLMrU7ajfNps8dhPF2Fw2j5fthE9hU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1754941162095645.1207106534853; Mon, 11 Aug 2025 12:39:22 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ulYKz-0007If-2O; Mon, 11 Aug 2025 15:37:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ulYKi-0007Dt-OX for qemu-devel@nongnu.org; Mon, 11 Aug 2025 15:37:27 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ulYKS-0003sS-5S for qemu-devel@nongnu.org; Mon, 11 Aug 2025 15:37:23 -0400 Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57BFVDIY019150 for ; Mon, 11 Aug 2025 19:37:04 GMT Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48dxduwm2u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 11 Aug 2025 19:37:03 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-74b29ee4f8bso4792604b3a.2 for ; Mon, 11 Aug 2025 12:37:03 -0700 (PDT) Received: from admin15.qualcomm.com (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-76bccfbcef6sm27677171b3a.85.2025.08.11.12.37.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Aug 2025 12:37:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=oeFCTcBeYBu AaNVMoPz5tm7BdWNU7A6jatOQ6V3bflg=; b=fYk00oh16WmjmWtnJInz1VQsMHN JFG14giDhCTgLVNTpXn2LN6MViKVVzSb2z40fc6F0EijDfWCSKzmwCYDkEWjcZwH jlrlOyLxGu7+7ZsW4/66zFTRaKGSBSF/lEJSDJPQ7LNTs1DayYB4LEnijocnSRw7 z1ae4aR1npCfxAFin6wAZVm6eozw9eI1fS1Tby5VjiLDk0dXk1z9TC6qCP0Za4zL kTCVhZ8AQGVYYBPWj22rpIpNbOJ8SOVM7XhksQbM7jQkuc/3inouy8pGAaK6V9TB LlShzbifmBA0fCCLs/YuHFPyJhT0Iykm0E47xyhEYOT7zp+s2hAVVq8g0Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754941022; x=1755545822; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oeFCTcBeYBuAaNVMoPz5tm7BdWNU7A6jatOQ6V3bflg=; b=kvOG+NmUN7rVdkmqjXCklDPBqIIpZMWYQjghxHt+gh0p4HT8dN3JU0BErML+q8Dluv UAPZzzL+aLYLEuJSouk4C7AxO1np23UEcHz9ku90h6KbK9j8NN0NZycBlE8gPR3vOGNf OaUN9Z5TxX4Sc31T9FtNIlKk8uLCbyt2g1xTjeSn65owPOOTJsjFVSq6sOYqh0DydEY4 lfw62Fh2Ktk34P98hpnHPf/9QqKeVjQRY4FmhZ4ZrOs4vI5OMtK5oNLgI1TRxmUO0Wmp yPJyKyJnUHgF1wVidBibo/TFHRKmbZzwyGfKTxvxA8sUlb5/JjDcT0rRTyDoMANkXEOq L+fg== X-Gm-Message-State: AOJu0Yzu98wBB2FifhRg2JoF9vjpcIbgsjYF01/qKTAYi30STwm0NjLn ZzdhwKFdjEtgUf8otnTUj60BA66fr1V1Ab1NzUTTVzP5zLYD7tir+Slc/A3adGKiI8NkM3AbWxn zP4C07roaan2818Exob5WEszHSm+qGn7wsKVhErg+hSW+PGyPhlTrFBC6JxzSPeKHz7US X-Gm-Gg: ASbGncvB0io7pwpgZCgddi9lP7FKul5ZP7xzJFNMsvGd39x1RuqXoG/rSgFpEbm5kMR 2grwl4nyHUga4l5ktGLXP/dfwXsFqDE0utHUJsBjCsJbb6DnSFZap4xKKzCEPMrhnY+tWoAe4y+ 3enTa6MMr+H169XRl5aIWh4neJwNVBxvlJdk92yvNmw9pXg8DxGJ5M5nFtftItdr3ZV2a7nnX1n P2274K9a8bFFypYZnLgoxZjJ+/F6b1ZG1CMtG7za/3SpQuwj3x7Pu0ydIK8yU6NmQA3rXdS6XAM BFg9xJU+Ckad9sXCGMB1XLKkDGOiA4MxSusInJGxsJMj7lyomMgSXGn+comrg00o2bUwv/yn0rw qjsvYDkTE2386wuM= X-Received: by 2002:a05:6a20:3944:b0:23f:fbb1:c21b with SMTP id adf61e73a8af0-24055046d01mr23603461637.17.1754941022354; Mon, 11 Aug 2025 12:37:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHNK6WAXYBIufEApoPMX97MHuwAocEaR3meWsnutyVRxqqNJv9Aoff5E/Xn/5+qA3fM3rtxkQ== X-Received: by 2002:a05:6a20:3944:b0:23f:fbb1:c21b with SMTP id adf61e73a8af0-24055046d01mr23603411637.17.1754941021818; Mon, 11 Aug 2025 12:37:01 -0700 (PDT) From: Vacha Bhavsar To: qemu-devel@nongnu.org Cc: Peter Maydell , qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Thomas Huth , Vacha Bhavsar Subject: [PATCH v5 4/4] target/arm: Added test case for SME register exposure Date: Mon, 11 Aug 2025 19:36:54 +0000 Message-Id: <20250811193654.4012878-5-vacha.bhavsar@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250811193654.4012878-1-vacha.bhavsar@oss.qualcomm.com> References: <20250811193654.4012878-1-vacha.bhavsar@oss.qualcomm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=IuYecK/g c=1 sm=1 tr=0 ts=689a465f cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=2OwXVqhp2XgA:10 a=EUspDBNiAAAA:8 a=hapuXSQWAQPwXaHXDnUA:9 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-ORIG-GUID: b9aQUFnquVpE5Dr6vXNmvaVkfSFr6Acr X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODA5MDAyNSBTYWx0ZWRfX+oYIzkmpBbjB yL9G18lZXmTVwBoAy34PG9wE5/m5LR3kL46oM/3B813ojHrCaPuTLCBPODYpcGUgCAsg9GHrZat UZF7jAi9Wz6Q6VMneNP7kP3bUxUtPcONAQNgxluCVWgFabppIRSpTku6o43fZ3GfXXO8jwhvTpD Q/jTw1PM9XNMCXrR7rorclIo/N6JpjzpVzcTzX1upHG64jNviF/fLFJgFv+4YFZxKy0V+VURnCU xbFv8WzI9qJSxMEMBE4Bv5Se8uGlnaSzM74ropCv2EZZbOpZvokWqPknIszLM1e13IpAiL0mQ+T 0Glrl26DJwjbI9cH3kzVzE7zPgymc7BcIL7JMar1zE/lwhwiBC4CGPzB7osL+Qg7cCCmXU+6KAW KPjgCNWj X-Proofpoint-GUID: b9aQUFnquVpE5Dr6vXNmvaVkfSFr6Acr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-11_04,2025-08-11_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 spamscore=0 priorityscore=1501 adultscore=0 clxscore=1015 phishscore=0 suspectscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508090025 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=vacha.bhavsar@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1754941163542116600 Content-Type: text/plain; charset="utf-8" This patch adds a test case to test SME register exposure to a remote gdb debugging session. This test simply sets and reads SME registers. Signed-off-by: Vacha Bhavsar --- Changes since v4: - this patch was not present in v4, it was added based on suggestions during the review of v4 --- configure | 6 ++ tests/tcg/aarch64/Makefile.target | 23 ++++- tests/tcg/aarch64/gdbstub/test-sme.py | 119 ++++++++++++++++++++++++++ 3 files changed, 147 insertions(+), 1 deletion(-) create mode 100644 tests/tcg/aarch64/gdbstub/test-sme.py diff --git a/configure b/configure index 825057ebf1..177d3775ac 100755 --- a/configure +++ b/configure @@ -1837,6 +1837,12 @@ for target in $target_list; do echo "GDB=3D$gdb_bin" >> $config_target_mak fi =20 + if test "${gdb_arches#*$arch}" !=3D "$gdb_arches" && version_ge $gdb= _version 14.1; then + echo "GDB_HAS_SME_TILES=3Dy" >> $config_target_mak + else + echo "GDB_HAS_SME_TILES=3Dn" >> $config_target_mak + fi + if test "${gdb_arches#*aarch64}" !=3D "$gdb_arches" && version_ge $g= db_version 15.1; then echo "GDB_HAS_MTE=3Dy" >> $config_target_mak fi diff --git a/tests/tcg/aarch64/Makefile.target b/tests/tcg/aarch64/Makefile= .target index 16ddcf4f88..1a33ef17a0 100644 --- a/tests/tcg/aarch64/Makefile.target +++ b/tests/tcg/aarch64/Makefile.target @@ -132,7 +132,28 @@ run-gdbstub-sve-ioctls: sve-ioctls --bin $< --test $(AARCH64_SRC)/gdbstub/test-sve-ioctl.py, \ basic gdbstub SVE ZLEN support) =20 -EXTRA_RUNS +=3D run-gdbstub-sysregs run-gdbstub-sve-ioctls +ifneq ($(CROSS_AS_HAS_ARMV9_SME),) +# SME gdbstub test +ifeq ($(GDB_HAS_SME_TILES),y) +run-gdbstub-sysregs-sme: sysregs + $(call run-test, $@, $(GDB_SCRIPT) \ + --gdb $(GDB) \ + --qemu $(QEMU) --qargs "$(QEMU_OPTS)" \ + --bin $< --test $(AARCH64_SRC)/gdbstub/test-sme.py \ + -- test_sme --gdb_sme_tile_support, \ + basic gdbstub SME support) +else +run-gdbstub-sysregs-sme: sysregs + $(call run-test, $@, $(GDB_SCRIPT) \ + --gdb $(GDB) \ + --qemu $(QEMU) --qargs "$(QEMU_OPTS)" \ + --bin $< --test $(AARCH64_SRC)/gdbstub/test-sme.py, \ + basic gdbstub SME support) + +endif +endif + +EXTRA_RUNS +=3D run-gdbstub-sysregs run-gdbstub-sve-ioctls run-gdbstub-sys= regs-sme =20 ifeq ($(GDB_HAS_MTE),y) run-gdbstub-mte: mte-8 diff --git a/tests/tcg/aarch64/gdbstub/test-sme.py b/tests/tcg/aarch64/gdbs= tub/test-sme.py new file mode 100644 index 0000000000..c2b9d774ae --- /dev/null +++ b/tests/tcg/aarch64/gdbstub/test-sme.py @@ -0,0 +1,119 @@ +from __future__ import print_function +# +# Test the SME registers are visible and changeable via gdbstub +# +# This is launched via tests/guest-debug/run-test.py +# + +import argparse +import gdb +from test_gdbstub import main, report + +MAGIC =3D 0x01020304 + +def run_test(): + "Run through the tests one by one" + + frame =3D gdb.selected_frame() + rname =3D "za" + za =3D frame.read_register(rname) + report(True, "Reading %s" % rname) + + for i in range(0, 16): + for j in range(0, 16): + cmd =3D "set $za[%d][%d] =3D 0x01" % (i, j) + gdb.execute(cmd) + report(True, "%s" % cmd) + for i in range(0, 16): + for j in range(0, 16): + reg =3D "$za[%d][%d]" % (i, j) + v =3D gdb.parse_and_eval(reg) + report(str(v.type) =3D=3D "uint8_t", + "size of %s" % (reg)) + report(int(v) =3D=3D 0x1, "%s is 0x%x" % (reg, 0x1)) + +def run_test_slices(): + "Run through the tests one by one" + + frame =3D gdb.selected_frame() + rname =3D "za" + za =3D frame.read_register(rname) + report(True, "Reading %s" % rname) + + for i in range(0, 16): + for j in range(0, 16): + cmd =3D "set $za[%d][%d] =3D 0x01" % (i, j) + gdb.execute(cmd) + report(True, "%s" % cmd) + for i in range(0, 16): + for j in range(0, 16): + reg =3D "$za[%d][%d]" % (i, j) + v =3D gdb.parse_and_eval(reg) + report(str(v.type) =3D=3D "uint8_t", + "size of %s" % (reg)) + report(int(v) =3D=3D 0x1, "%s is 0x%x" % (reg, 0x1)) + + for i in range(0, 4): + for j in range(0, 4): + for k in range(0, 4): + cmd =3D "set $za%dhq%d[%d] =3D 0x%x" % (i, j, k, MAGIC) + gdb.execute(cmd) + report(True, "%s" % cmd) + for j in range(0, 4): + for k in range(0, 4): + reg =3D "$za%dhq%d[%d]" % (i, j, k) + v =3D gdb.parse_and_eval(reg) + report(str(v.type) =3D=3D "uint128_t", + "size of %s" % (reg)) + report(int(v) =3D=3D MAGIC, "%s is 0x%x" % (reg, MAGIC)) + =20 + for j in range(0, 4): + for k in range(0, 4): + cmd =3D "set $za%dvq%d[%d] =3D 0x%x" % (i, j, k, MAGIC) + gdb.execute(cmd) + report(True, "%s" % cmd) + for j in range(0, 4): + for k in range(0, 4): + reg =3D "$za%dvq%d[%d]" % (i, j, k) + v =3D gdb.parse_and_eval(reg) + report(str(v.type) =3D=3D "uint128_t", + "size of %s" % (reg)) + report(int(v) =3D=3D MAGIC, "%s is 0x%x" % (reg, MAGIC)) + + for i in range(0, 4): + for j in range(0, 4): + for k in range(0, 4): + cmd =3D "set $za%dhd%d[%d] =3D 0x%x" % (i, j, k, MAGIC) + gdb.execute(cmd) + report(True, "%s" % cmd) + for j in range(0, 4): + for k in range(0, 4): + reg =3D "$za%dhd%d[%d]" % (i, j, k) + v =3D gdb.parse_and_eval(reg) + report(str(v.type) =3D=3D "uint64_t", + "size of %s" % (reg)) + report(int(v) =3D=3D MAGIC, "%s is 0x%x" % (reg, MAGIC)) + =20 + for j in range(0, 4): + for k in range(0, 4): + cmd =3D "set $za%dvd%d[%d] =3D 0x%x" % (i, j, k, MAGIC) + gdb.execute(cmd) + report(True, "%s" % cmd) + for j in range(0, 4): + for k in range(0, 4): + reg =3D "$za%dvd%d[%d]" % (i, j, k) + v =3D gdb.parse_and_eval(reg) + report(str(v.type) =3D=3D "uint64_t", + "size of %s" % (reg)) + report(int(v) =3D=3D MAGIC, "%s is 0x%x" % (reg, MAGIC)) + + +parser =3D argparse.ArgumentParser(description=3D"A gdbstub test for SME s= upport") +parser.add_argument("--gdb_sme_tile_support", help=3D"GDB support for SME = tiles", \ + action=3D"store_true") +args =3D parser.parse_args() + +if args.gdb_sme_tile_support: + main(run_test_slices, expected_arch=3D"aarch64") +else: + main(run_test, expected_arch=3D"aarch64") \ No newline at end of file --=20 2.34.1