From nobody Sat Nov 15 07:40:54 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1754917383; cv=none; d=zohomail.com; s=zohoarc; b=ijSrKd2e1dgisAzVqfqbtRibTbnv++5eXueLOnmoxm/J9YASEIkl40RKJHFwUCUuH405kO7TLieCVhoBsFtqkIao+7LtpvQtR9lGgeJw+4kgNI8EwJo3xLiT1AV/HSaTmdIeaPmgC3BSQN5KGUap7BYsk+/O7dzjxByYw4xzGdw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1754917383; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ZUvb6xn8MMNHMeZDHR+wTILpotUiylcHkhGNs17Lh2w=; b=BTzBvsk9dRFguetxFv1V3ODhMEHzx+mF3VhVo7iaOIIsj4Bv8Klb7W/K3gEc8pfNDRhgLurHAPe5QBsSbk2cnM2/3xHTikbdcgOAGEzBx7hmLSGQE0w4/hpxoXlWAV8uD4cMzF3rkGwE5fjwCG9UXXYkCrMMEOO1n+Qje8kBpUM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1754917383489299.5613802562614; Mon, 11 Aug 2025 06:03:03 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ulSAk-00025G-5l; Mon, 11 Aug 2025 09:02:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ulS9d-0001XV-GY for qemu-devel@nongnu.org; Mon, 11 Aug 2025 09:01:43 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ulS9V-0005l9-5g for qemu-devel@nongnu.org; Mon, 11 Aug 2025 09:01:32 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-231-2Bx2GKOLMOWDXidb2hqPLA-1; Mon, 11 Aug 2025 09:01:21 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 282D71800290; Mon, 11 Aug 2025 13:01:19 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.45.224.64]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C305C1800292; Mon, 11 Aug 2025 13:01:17 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 9D06018000B2; Mon, 11 Aug 2025 15:01:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754917283; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZUvb6xn8MMNHMeZDHR+wTILpotUiylcHkhGNs17Lh2w=; b=AzOvOZg0DUJ/DvsfiD98vm/IjGlb0i2ec7IX9boOxcZE+2fnH0Pyo/zHzBKRb01pbjntiZ Y2Kfq0nin6iiBrf45/YR0HS0woX59NXyul+tw5TpBg4QYZ07js7UlW/mccOAMo71yk+HwC kKFaGJ/p9xX0edSzPC+vTKBi42i9oDY= X-MC-Unique: 2Bx2GKOLMOWDXidb2hqPLA-1 X-Mimecast-MFC-AGG-ID: 2Bx2GKOLMOWDXidb2hqPLA_1754917279 From: Gerd Hoffmann To: qemu-devel@nongnu.org Cc: Kashyap Chamarthy , Daniel Henrique Barboza , Palmer Dabbelt , Jiaxun Yang , Gerd Hoffmann , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Song Gao , Paolo Bonzini , Bibo Mao , Liu Zhiwei , Weiwei Li , Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-riscv@nongnu.org Subject: [PATCH 2/3] hw/uefi: check access for first variable Date: Mon, 11 Aug 2025 15:01:09 +0200 Message-ID: <20250811130110.820958-3-kraxel@redhat.com> In-Reply-To: <20250811130110.820958-1-kraxel@redhat.com> References: <20250811130110.820958-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1754917384852124100 Content-Type: text/plain; charset="utf-8" When listing variables (via get-next-variable-name) only the names of variables which can be accessed will be returned. That check was missing for the first variable though. Add it. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/uefi/var-service-vars.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/uefi/var-service-vars.c b/hw/uefi/var-service-vars.c index cbeccdbd2664..8533533ea5c8 100644 --- a/hw/uefi/var-service-vars.c +++ b/hw/uefi/var-service-vars.c @@ -357,6 +357,9 @@ uefi_vars_mm_get_next_variable(uefi_vars_state *uv, mm_= header *mhdr, if (uefi_strlen(name, nv->name_size) =3D=3D 0) { /* empty string -> first */ var =3D QTAILQ_FIRST(&uv->variables); + while (var && !check_access(uv, var)) { + var =3D QTAILQ_NEXT(var, next); + } if (!var) { return uefi_vars_mm_error(mhdr, mvar, EFI_NOT_FOUND); } --=20 2.50.1