From nobody Sat Nov 15 05:37:00 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1754720068; cv=none; d=zohomail.com; s=zohoarc; b=PM8lIDkdYoR3MLlv7xCF8P1MThVsZ7WwdmLYOvNGLQDV8txV6Urqe9Nen6VI96tHYzlTEzopVFg8vUzy7sbN01XywTvBmlFovTWgPW+f6IXE3ITUzREUc3ocS3QwHYCBiit00lNkN4qXxubZLPZZT1YBEcuMjdKt/qIaPneIuNo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1754720068; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Sender:Subject:Subject:To:To:Message-Id; bh=PiKI4+s+TL8km9hao5FuKgk7oLCXGmJGIlJqAZ194Ag=; b=P01EyCKthXn4FFN2CbvME4IpHCuMwEHwLMHYeg4vZzuEv0wGNZkk1rOEZrEXJgFfgkCjzsV70EtoQcLGNNltvV1BgWpwhXLsmAoHmZ4LnKc1Yb924gk50zlt2mFwuoAfolWB66pvC39Eer2ACxBUoWey2Fj5isxy77/DaH/rmiU= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1754720068640436.85991631204706; Fri, 8 Aug 2025 23:14:28 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ukcpT-0008Ch-Sd; Sat, 09 Aug 2025 02:13:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ukcpL-0008Ac-T3; Sat, 09 Aug 2025 02:13:11 -0400 Received: from mail.weilnetz.de ([37.120.169.71] helo=mail.v2201612906741603.powersrv.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ukcpJ-0004es-UK; Sat, 09 Aug 2025 02:13:11 -0400 Received: from qemu.weilnetz.de (qemu.weilnetz.de [188.68.58.204]) by mail.v2201612906741603.powersrv.de (Postfix) with ESMTP id AB500DA04B9; Sat, 09 Aug 2025 08:13:05 +0200 (CEST) Received: by qemu.weilnetz.de (Postfix, from userid 1000) id 8994D46012D; Sat, 09 Aug 2025 08:13:05 +0200 (CEST) Authentication-Results: mail.v2201612906741603.powersrv.de; dkim=none; spf=softfail (mail.v2201612906741603.powersrv.de: 188.68.58.204 is neither permitted nor denied by domain of stefan@weilnetz.de) smtp.mailfrom=stefan@weilnetz.de; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=weilnetz.de (policy=none) To: Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Samuel Thibault , Michael Tokarev , rent Vivier Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org, Stefan Weil Subject: [PATCH trivial] chardev/baum: Fix compiler warning for Windows builds Date: Sat, 9 Aug 2025 08:13:02 +0200 Message-ID: <20250809061302.596931-1-sw@weilnetz.de> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [2.60 / 12.00]; VIOLATED_DIRECT_SPF(3.50)[]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; FORGED_SENDER(0.30)[sw@weilnetz.de,stefan@weilnetz.de]; ONCE_RECEIVED(0.20)[]; DMARC_POLICY_SOFTFAIL(0.10)[weilnetz.de : No valid SPF, No valid DKIM,quarantine,sampled_out]; MIME_GOOD(-0.10)[text/plain]; RCVD_NO_TLS_LAST(0.10)[]; RCVD_COUNT_ONE(0.00)[1]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[weilnetz.de:mid,weilnetz.de:email]; ASN(0.00)[asn:197540, ipnet:188.68.56.0/22, country:DE]; RCPT_COUNT_SEVEN(0.00)[8]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; R_DKIM_NA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[sw@weilnetz.de,stefan@weilnetz.de]; R_SPF_SOFTFAIL(0.00)[~all]; ARC_NA(0.00)[] X-Rspamd-Server: v2201612906741603 X-Rspamd-Action: no action X-Rspamd-Queue-Id: AB500DA04B9 X-Spamd-Bar: ++ Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=37.120.169.71; envelope-from=stefan@weilnetz.de; helo=mail.v2201612906741603.powersrv.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Stefan Weil From: Stefan Weil via Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1754720071073124100 Content-Type: text/plain; charset="utf-8" Compiler warning: ../chardev/baum.c:657:25: warning: comparison between pointer and integer Use brlapi_fileDescriptor instead of int for brlapi_fd and BRLAPI_INVALID_FILE_DESCRIPTOR instead of -1. Signed-off-by: Stefan Weil Reviewed-by: Samuel Thibault --- This is a rather old patch which I now use since more than two years to support Braille with QEMU on Windows. It's a hack (because Windows uses a pointer (64 bit) which is assigned to an int (32 bit), but it seems to work. Regards, Stefan chardev/baum.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/chardev/baum.c b/chardev/baum.c index f3e8cd27f0..5c3587dda5 100644 --- a/chardev/baum.c +++ b/chardev/baum.c @@ -94,7 +94,7 @@ struct BaumChardev { Chardev parent; =20 brlapi_handle_t *brlapi; - int brlapi_fd; + brlapi_fileDescriptor brlapi_fd; unsigned int x, y; bool deferred_init; =20 @@ -654,7 +654,7 @@ static void baum_chr_open(Chardev *chr, baum->brlapi =3D handle; =20 baum->brlapi_fd =3D brlapi__openConnection(handle, NULL, NULL); - if (baum->brlapi_fd =3D=3D -1) { + if (baum->brlapi_fd =3D=3D BRLAPI_INVALID_FILE_DESCRIPTOR) { error_setg(errp, "brlapi__openConnection: %s", brlapi_strerror(brlapi_error_location())); g_free(handle); --=20 2.47.2