From nobody Sat Nov 15 05:37:36 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 175471848302524.07705659838507; Fri, 8 Aug 2025 22:48:03 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ukcQL-0000Vv-Py; Sat, 09 Aug 2025 01:47:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ukcQE-0000Re-Dd; Sat, 09 Aug 2025 01:47:15 -0400 Received: from isrv.corpit.ru ([212.248.84.144]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ukcQC-0001pU-5e; Sat, 09 Aug 2025 01:47:14 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id 12773140006; Sat, 09 Aug 2025 08:46:27 +0300 (MSK) Received: from think4mjt.origo (mjtthink.wg.tls.msk.ru [192.168.177.146]) by tsrv.corpit.ru (Postfix) with ESMTP id 423A025C264; Sat, 9 Aug 2025 08:46:55 +0300 (MSK) From: Michael Tokarev To: qemu-devel@nongnu.org, Stefan Weil Cc: Michael Tokarev , qemu-trivial@nongnu.org, Samuel Thibault , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini Subject: [PATCH trivial] chardev/baum.c: fix error return check for windows Date: Sat, 9 Aug 2025 08:46:53 +0300 Message-ID: <20250809054654.562361-1-mjt@tls.msk.ru> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=212.248.84.144; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1754718498815124100 Content-Type: text/plain; charset="utf-8" Commit 3736506e25ac7bb "meson: Fix brlapi compile test for Windows builds" fixed brlapi configure-time test to use BRLAPI_INVALID_FILE_DESCRIPTOR instead of -1, b/c on windows, it is not -1. But the same test is used at run time when initing brlapi in chardev/baum.c. Fix this one too. Signed-off-by: Michael Tokarev --- chardev/baum.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chardev/baum.c b/chardev/baum.c index f3e8cd27f0..ecbcd2e5c6 100644 --- a/chardev/baum.c +++ b/chardev/baum.c @@ -654,7 +654,7 @@ static void baum_chr_open(Chardev *chr, baum->brlapi =3D handle; =20 baum->brlapi_fd =3D brlapi__openConnection(handle, NULL, NULL); - if (baum->brlapi_fd =3D=3D -1) { + if (baum->brlapi_fd =3D=3D BRLAPI_INVALID_FILE_DESCRIPTOR) { error_setg(errp, "brlapi__openConnection: %s", brlapi_strerror(brlapi_error_location())); g_free(handle); --=20 2.47.2