From nobody Sun Dec 14 06:20:44 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1754640566; cv=none; d=zohomail.com; s=zohoarc; b=kPNWPOOH4uedjNxL10CjcX73zA/OfzWZkErJcqm1Yk5MurataHsdqdmoBP9ezoKpL5iva8r2ue59+pBSABtGByfrCgDlKPrBLSHeNDMdEtUYo3hrbNjjhZflE98ozPdNhqW9bbD05hf32Vhr8drkKGDedPelIh682kFeDOKYTYw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1754640566; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=lFO+wHuHsYmjvUEmMjjSVaO3ZnGXBm+IeroqybUwYqw=; b=IRq1RHOECtU0IUHNVboyjP84ccBnuyED5YoFDjfkzLUMMVcEWEMKK9m7R23LsERBYy0qlYJOeV+QToi0AWsz2/2eK77H8beviclWu4B5iIEIZWLE9+17UxeKLrQp/aQ2UmigOGa1+4/WRoZ1ReC5ETGSox5UEEAxHejfeeLS7fo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1754640566602510.1722633787235; Fri, 8 Aug 2025 01:09:26 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ukI9c-0007EM-Oa; Fri, 08 Aug 2025 04:08:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ukI9U-00073e-58 for qemu-devel@nongnu.org; Fri, 08 Aug 2025 04:08:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ukI9S-0006TS-Dm for qemu-devel@nongnu.org; Fri, 08 Aug 2025 04:08:35 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-210-HZCbQwY1OGq862UStORJdQ-1; Fri, 08 Aug 2025 04:08:31 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1EFD81800371; Fri, 8 Aug 2025 08:08:30 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.18]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 970BE1800291; Fri, 8 Aug 2025 08:08:29 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 5FC7E21E677A; Fri, 08 Aug 2025 10:08:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754640512; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lFO+wHuHsYmjvUEmMjjSVaO3ZnGXBm+IeroqybUwYqw=; b=DUYOvzfhSMZm74OgMGNn+7E0gLjkqHgNgReb2tp/KUl5ceWrLKSLQ8SIzI0wpvjTxZVPwu PnbUZpdEZ5LoziH/hQz+FOUEk/SNp1qy1Tgu9h4r2Rlfhbw9NvRyt6fHOPN4dKRAU4kXHJ e+K7gBQdJ0RUxYtJT/JMd3j5u+/o+58= X-MC-Unique: HZCbQwY1OGq862UStORJdQ-1 X-Mimecast-MFC-AGG-ID: HZCbQwY1OGq862UStORJdQ_1754640510 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: odaki@rsg.ci.i.u-tokyo.ac.jp, marcandre.lureau@redhat.com Subject: [PATCH 07/12] ui/spice-core: Clean up error reporting Date: Fri, 8 Aug 2025 10:08:18 +0200 Message-ID: <20250808080823.2638861-8-armbru@redhat.com> In-Reply-To: <20250808080823.2638861-1-armbru@redhat.com> References: <20250808080823.2638861-1-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1754640571216124100 watch_add() reports _open_osfhandle() failure with error_setg(&error_warn, ...). I'm not familiar with Spice, so I can't say whether it will work after such a failure. If it doesn't, then this should be an error. If it does, then why bother the user with a warning that isn't actionable, and likely confusing? Regardless of that, error_setg_win32(&error_warn, ...) is undesirable just like error_setg(&error_fatal, ...) and error_setg(&error_abort, ...) are. Replace by warn_report(). Cc: Marc-Andr=C3=A9 Lureau Signed-off-by: Markus Armbruster Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau --- ui/spice-core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ui/spice-core.c b/ui/spice-core.c index 5992f9daec..97bdd171cd 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -132,7 +132,8 @@ static SpiceWatch *watch_add(int fd, int event_mask, Sp= iceWatchFunc func, void * #ifdef WIN32 fd =3D _open_osfhandle(fd, _O_BINARY); if (fd < 0) { - error_setg_win32(&error_warn, WSAGetLastError(), "Couldn't associa= te a FD with the SOCKET"); + warn_report("Couldn't associate a FD with the SOCKET: %s" + g_win32_error_message(WSAGetLastError())); return NULL; } #endif --=20 2.49.0