From nobody Mon Feb 9 19:16:22 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1754562781; cv=none; d=zohomail.com; s=zohoarc; b=Q3t3W5puhai5Y6LiZIuor+KYpOUjAwtglnT7OKQXPyTXZRkRwkRdmQsEW1D4H7yiXcSF5Rj3WlZYGpiQvT2zQ5CcNs1Pr6YkT8LZdu/9gFX+SMAxE05B4nKHHaO02KoFBTMABfR/ojOsgsdZGZn6JSAHF3eqGS77FmLEA9jwHK0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1754562781; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=h8w3Cxk+e/HdehZDP+UNsCur4eyTAg3cqI8YUurDMt0=; b=HuxzrJPVdOTLlhZe6Dp2XCK9xXJu2z8qXBXyX/TBrFWJbCsIqQD4zitjCGq3Pm9ccB6xDmULx3JEldXBm/Kg/uslZuXRVg7Nnw81A0tmuZpotNRDKAfIXR8UuNNU7lxfV3OkJxu00gPevDFk2n/9BVH3o67Acg7QGCzZWTIdjqI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1754562781174614.5950858087547; Thu, 7 Aug 2025 03:33:01 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ujxug-0007tT-RF; Thu, 07 Aug 2025 06:31:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ujxuV-0007Yu-AD for qemu-devel@nongnu.org; Thu, 07 Aug 2025 06:31:48 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ujxuT-0003p4-Nk for qemu-devel@nongnu.org; Thu, 07 Aug 2025 06:31:47 -0400 Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-3-f5ZtQpweNomKZ8LkoKS2BA-1; Thu, 07 Aug 2025 06:31:43 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C60C919560A2; Thu, 7 Aug 2025 10:31:42 +0000 (UTC) Received: from localhost (unknown [10.45.242.9]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5DB36180035C; Thu, 7 Aug 2025 10:31:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754562704; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h8w3Cxk+e/HdehZDP+UNsCur4eyTAg3cqI8YUurDMt0=; b=O0tYveYEJ67Bc0KM7nSLvM6SEGByksMrDXpD5hJyDWY3auDm9uYYIMVM7onYQW/lHS2nIa s5ZOiScj8hMarBpAAGLfWM/+KprL3RtYtSJUJs0mtM4HBiSQOkUYrhvQgmyxOPuj6uBLQE C6BpgF1RWgifb2FVwhmZx2fZ7jqqimE= X-MC-Unique: f5ZtQpweNomKZ8LkoKS2BA-1 X-Mimecast-MFC-AGG-ID: f5ZtQpweNomKZ8LkoKS2BA_1754562702 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , stefanha@redhat.com, William Hu Subject: [PULL v2 1/1] ui/curses: Fix infinite loop on windows Date: Thu, 7 Aug 2025 14:31:31 +0400 Message-ID: <20250807103131.1912150-2-marcandre.lureau@redhat.com> In-Reply-To: <20250807103131.1912150-1-marcandre.lureau@redhat.com> References: <20250807103131.1912150-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1754562783358124100 From: William Hu Replace -1 comparisons for wint_t with WEOF to fix infinite loop caused by a 65535 =3D=3D -1 comparison. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2905 Signed-off-by: William Hu Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau [ Marc-Andr=C3=A9 - Add missing similar code change, remove a comment ] Signed-off-by: Marc-Andr=C3=A9 Lureau Message-ID: --- ui/curses.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/ui/curses.c b/ui/curses.c index a39aee8762..161f78c35c 100644 --- a/ui/curses.c +++ b/ui/curses.c @@ -265,7 +265,8 @@ static int curses2foo(const int _curses2foo[], const in= t _curseskey2foo[], =20 static void curses_refresh(DisplayChangeListener *dcl) { - int chr, keysym, keycode, keycode_alt; + wint_t chr =3D 0; + int keysym, keycode, keycode_alt; enum maybe_keycode maybe_keycode =3D CURSES_KEYCODE; =20 curses_winch_check(); @@ -284,8 +285,9 @@ static void curses_refresh(DisplayChangeListener *dcl) /* while there are any pending key strokes to process */ chr =3D console_getch(&maybe_keycode); =20 - if (chr =3D=3D -1) + if (chr =3D=3D WEOF) { break; + } =20 #ifdef KEY_RESIZE /* this shouldn't occur when we use a custom SIGWINCH handler */ @@ -304,9 +306,9 @@ static void curses_refresh(DisplayChangeListener *dcl) /* alt or esc key */ if (keycode =3D=3D 1) { enum maybe_keycode next_maybe_keycode =3D CURSES_KEYCODE; - int nextchr =3D console_getch(&next_maybe_keycode); + wint_t nextchr =3D console_getch(&next_maybe_keycode); =20 - if (nextchr !=3D -1) { + if (nextchr !=3D WEOF) { chr =3D nextchr; maybe_keycode =3D next_maybe_keycode; keycode_alt =3D ALT; --=20 2.50.1