From nobody Sat Nov 15 07:45:47 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1754052730364846.6935954576055; Fri, 1 Aug 2025 05:52:10 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uhpED-0007pc-SF; Fri, 01 Aug 2025 08:51:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uhosg-0001TH-0O; Fri, 01 Aug 2025 08:29:02 -0400 Received: from isrv.corpit.ru ([212.248.84.144]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uhosa-0004tB-J2; Fri, 01 Aug 2025 08:29:01 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id BECDD13CB5A; Fri, 01 Aug 2025 15:28:36 +0300 (MSK) Received: from think4mjt.origo (mjtthink.wg.tls.msk.ru [192.168.177.146]) by tsrv.corpit.ru (Postfix) with ESMTP id 2C7B8254A9B; Fri, 1 Aug 2025 15:28:51 +0300 (MSK) From: Michael Tokarev To: qemu-devel@nongnu.org, qemu-block@nongnu.org, Eric Blake , Kevin Wolf Cc: Michael Tokarev , qemu-trivial@nongnu.org Subject: [PATCH trivial] tests/qemu-iotests/tests/mirror-sparse: skip if O_DIRECT is not supported Date: Fri, 1 Aug 2025 15:28:49 +0300 Message-ID: <20250801122850.27632-1-mjt@tls.msk.ru> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=212.248.84.144; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1754052736251116600 Content-Type: text/plain; charset="utf-8" This test uses cache.direct=3Dtrue, but does not check if O_DIRECT is supported by the underlying filesystem, and fails, for example, on a tmpfs (which is rather common on various auto-builders, in CI, etc). Fix this by using _require_o_direct. This example shows where our testing framework is significantly lacking. In this test, qemu produces an error message on stderr at startup, because it can't use O_DIRECT mode. But this error message is not shown anywhere at all, even when running this test separately outside of meson framework, - stderr is completely hidden, and the only error we're getting is +Timeout waiting for capabilities on handle 0 so it's rather painful to find what the actual error is. I think that besides this change, we should also change the testing framework to show stderr at least in case of test failure, and especially when the failure occurs at the very beginning when we're checking for sanity. Fixes: c0ddcb2cbc146e "tests: Add iotest mirror-sparse for recent patches" Signed-off-by: Michael Tokarev --- tests/qemu-iotests/tests/mirror-sparse | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qemu-iotests/tests/mirror-sparse b/tests/qemu-iotests/te= sts/mirror-sparse index cfcaa600ab..19843a622c 100755 --- a/tests/qemu-iotests/tests/mirror-sparse +++ b/tests/qemu-iotests/tests/mirror-sparse @@ -41,6 +41,7 @@ _supported_fmt qcow2 raw # Format of the source. dst is = always raw file _supported_proto file _supported_os Linux _require_disk_usage +_require_o_direct =20 echo echo "=3D=3D=3D Initial image setup =3D=3D=3D" --=20 2.47.2