From nobody Sat Nov 15 09:50:15 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1753971907; cv=none; d=zohomail.com; s=zohoarc; b=mEmlQsSPsQwIUKyvbOhYXaCPerF4lNUbHlUIl9racl4ycY6tFDuVa88jUFIztoPy6wp9Q9nHS7if9EHP+dL5+WIyRHsCbbGDOw/hB+aEmDO0Im97hFTc2NogTsiEhh8LugfBoXTJU7am0ldGrj+xFtXUkA/eBObE/zfPsoAtx+Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753971907; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=kLghEdi44xi6/POYpygXyfMOGple2iuK5st+VMUWU2k=; b=bIHhDH8VI0qkWL0rcuBSzvF+kfbycgv/cBANP2D4JHSB7oTulSQpKd/PRq3+55TwY6ItTMLbtOQzLDdfiaJjf01crXeAj4ZJLPU+K5jXRmXgFN6e7+nM2+jPCTxExYYxbqKC5Pt7TUSnlRyzizFsuwZSl1Jl6Ld1dO7CihVI8Ow= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1753971907403486.22148587514073; Thu, 31 Jul 2025 07:25:07 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uhUBZ-0004Z2-NN; Thu, 31 Jul 2025 10:23:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uhTGa-0004Bl-1a for qemu-devel@nongnu.org; Thu, 31 Jul 2025 09:24:16 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uhTGY-0008PF-70 for qemu-devel@nongnu.org; Thu, 31 Jul 2025 09:24:15 -0400 Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-272-wxXdfNJbODiZ1hdiUY_cIw-1; Thu, 31 Jul 2025 09:24:11 -0400 Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-31ed2a7d475so996748a91.1 for ; Thu, 31 Jul 2025 06:24:11 -0700 (PDT) Received: from armenon-kvm.bengluru.csb ([49.36.99.139]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3209a84d115sm2007034a91.36.2025.07.31.06.24.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Jul 2025 06:24:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1753968252; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kLghEdi44xi6/POYpygXyfMOGple2iuK5st+VMUWU2k=; b=gsNUqZ6o32caURu1PFSbWXMNgXtMSO49ftharIhSscDYCuY2nLUh30Gyzg1HrW5kik9I/U wzJ2LkGyI/Y9UzX1N+rjfIcni9Vzx/QolG2O6j8YeVbEqn5Ca3zSmQTzS4VW/YCoIg5Q1e q0rDO+O53+6pfvl0TudPBzNSj6mu524= X-MC-Unique: wxXdfNJbODiZ1hdiUY_cIw-1 X-Mimecast-MFC-AGG-ID: wxXdfNJbODiZ1hdiUY_cIw_1753968250 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753968250; x=1754573050; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kLghEdi44xi6/POYpygXyfMOGple2iuK5st+VMUWU2k=; b=nwurGhMnBJG0te+V/CceCVwF8O1DpdEHhSfHgrb4IvqT/kZTbi++6SWAVVHwN/GCTq B1TGWgbXv+H3IGvbGxWP3o/F7rXs7U+gHiJ6r0/tCGQ1Q0m/PEgY5I5nnwbw7gx6rvK+ OdYyeP4TouGWAIDm4Y8uPOo89j5Ti/Wlw14DesIJcLFTGfwS7NKhYvW3KFXngZ6dHUda letfAXIwfR7/J23dG6h1T//KDNjtJpIXknlZw8sAv9rsXnCjtnSLpJ+bD9xlTTUcGOuO MUW/pqXzGaQdZYFbG/kwp9JjWDqWJs3ZzqH57gp9VciW0qDRe/3jZcmmc1SbFTcyzQPd i36g== X-Gm-Message-State: AOJu0YwliBYXfyAD6qmblAWlc6PrHQ+lo8zjXE2umSXawKNHewSL1PeY 07dlG/iscVigXIYFwAfDNzPF6c89anDdh8q0OsqI4lQ23PPI7FfIPP5gk4edxfoqf04nN7ofJGM tSYCv8lfbZNwjMSuAF1vqeOCvbYcDjdH4BUdLrfRN2D+FzQoPqy3pEkCicspfXmaasSASPI9fAx hCMcCLnnhiVYTzfY43L6W8SzgpuO/+v6EN2Gh7LBFHjA== X-Gm-Gg: ASbGncvVr2Uuqyej2NFYGVY0Pfk9l9BWjb0EV23gbDjMpfo0RBb2Wv+nPSleC3M61wH 85GER9kb29ubYxjE5oVFZ6VI89CZCt8BaOXPiKuTKhFKHNG8QamOEQih6hEPiHa0TP02MoWlvkA 5O9IrBP9c6jGSK5rrTTvCOla3gKF7IA9197lMZz4/gEqgy9iysrlThtW+JV6Ye5l9yUuMC8yrQG OIT8sbBwCjyNnQrIwyLqidGaXloxp7vuQCxHNJt3JAyg/3B3qsY+VokTFxA+tGsUpB2GmgaP0dq kRtpgBmmr0siLpvLq9j+1eiITvPhkFwJWsLZmxHLBbr6KD1lO/Pv X-Received: by 2002:a17:90b:4e88:b0:31e:ff94:3fba with SMTP id 98e67ed59e1d1-31f5de73be3mr10968961a91.24.1753968250181; Thu, 31 Jul 2025 06:24:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFRJ5xULk/vCXVp+z6uvdiMa1wS24tfrk5Fa3pMGUSobsyYWl/IgpyQYiPt48gJ9f7omyryDQ== X-Received: by 2002:a17:90b:4e88:b0:31e:ff94:3fba with SMTP id 98e67ed59e1d1-31f5de73be3mr10968888a91.24.1753968249545; Thu, 31 Jul 2025 06:24:09 -0700 (PDT) From: Arun Menon Date: Thu, 31 Jul 2025 18:50:54 +0530 Subject: [PATCH v8 14/27] migration: push Error **errp into loadvm_postcopy_handle_run() MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250731-propagate_tpm_error-v8-14-28fd82fdfdb2@redhat.com> References: <20250731-propagate_tpm_error-v8-0-28fd82fdfdb2@redhat.com> In-Reply-To: <20250731-propagate_tpm_error-v8-0-28fd82fdfdb2@redhat.com> To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Marcel Apfelbaum , Cornelia Huck , Halil Pasic , Eric Farman , Richard Henderson , David Hildenbrand , Ilya Leoshkevich , Thomas Huth , Christian Borntraeger , Paolo Bonzini , Fam Zheng , Nicholas Piggin , Daniel Henrique Barboza , Harsh Prateek Bora , Alex Williamson , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Peter Xu , Fabiano Rosas , Hailiang Zhang , Steve Sistare , qemu-s390x@nongnu.org, qemu-ppc@nongnu.org, Stefan Berger , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , =?utf-8?q?Alex_Benn=C3=A9e?= , Akihiko Odaki , Dmitry Osipenko , Matthew Rosato , Arun Menon , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1842; i=armenon@redhat.com; h=from:subject:message-id; bh=WpuifoUIMf3O+h85by3an6J009O2UfK/XwRSBRbjBtA=; b=owGbwMvMwCWWVaVqcZPfqI/xtFoSQ0Z37rP3vedfZXwJujK3NcT8P7tvdtYH1qBwtScP8t9VB ekzePt0lLIwiHExyIopsjR8DZBtCiiMiLR9eR1mDisTyBAGLk4BmIjMC0aG1qU5R2XLLGyj5irr Tb1s2sb6+t0dFwf2mjOWKQEGzx8wMjK8uPtjR9A8Vl/JNV57O4zbOe9M5DN9MlE4PjjZ6+KVJbe YAA== X-Developer-Key: i=armenon@redhat.com; a=openpgp; fpr=80F5501D82507158593DE9D76A7A2538D90F328E Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=armenon@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1753971908398116600 This is an incremental step in converting vmstate loading code to report error via Error objects instead of directly printing it to console/monitor. It is ensured that loadvm_postcopy_handle_run() must report an error in errp, in case of failure. Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Arun Menon --- migration/savevm.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/migration/savevm.c b/migration/savevm.c index c9ca0628183312e19fc72c06f791dc4d53566c16..771c3d2a074d5b6a5ebd3ccf58d= 564d9b4cefb93 100644 --- a/migration/savevm.c +++ b/migration/savevm.c @@ -2273,13 +2273,13 @@ static void loadvm_postcopy_handle_run_bh(void *opa= que) } =20 /* After all discards we can start running and asking for pages */ -static int loadvm_postcopy_handle_run(MigrationIncomingState *mis) +static int loadvm_postcopy_handle_run(MigrationIncomingState *mis, Error *= *errp) { PostcopyState ps =3D postcopy_state_get(); =20 trace_loadvm_postcopy_handle_run(); if (ps !=3D POSTCOPY_INCOMING_LISTENING) { - error_report("CMD_POSTCOPY_RUN in wrong postcopy state (%d)", ps); + error_setg(errp, "CMD_POSTCOPY_RUN in wrong postcopy state (%d)", = ps); return -1; } =20 @@ -2625,11 +2625,7 @@ static int loadvm_process_command(QEMUFile *f, Error= **errp) return loadvm_postcopy_handle_listen(mis, errp); =20 case MIG_CMD_POSTCOPY_RUN: - ret =3D loadvm_postcopy_handle_run(mis); - if (ret < 0) { - error_setg(errp, "Failed to load device state command: %d", re= t); - } - return ret; + return loadvm_postcopy_handle_run(mis, errp); =20 case MIG_CMD_POSTCOPY_RAM_DISCARD: ret =3D loadvm_postcopy_ram_handle_discard(mis, len); --=20 2.50.0