From nobody Sat Nov 15 07:39:23 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1753723863; cv=none; d=zohomail.com; s=zohoarc; b=S5d5mLcSzxjdjF4WCquaDD9fiRDO4smjgk/ZOV1MANOXvta5mXy/Qcq3IrHImLOgmULRP87GQ37uoqqtTSvim/oaGwLALxz7+F5txZydIlatsfXlTyM/OlKRby1i2907CwMDGxUzlj5FBkLotZqONv8i+40xo23hm2tU6/u8F4k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753723863; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=eUoKj/NKwS1Na52rnIVQy+Sv4r/p2PoH+hWl9VDYsC4=; b=YL7P/BjXL6j5KLH7fCuyihyR8tBghuCXgntP8rdatF0VdG98ntA5AbefoJC/tcPCF/I1EhgG+j2bvWLaPJM7PWAO1ggTxX4Jom7px/8+8X7kGPqazXfW+bKhTD72irYqjmznmJCzPC1OH/QA9XNGO1YxH4fuih8o+xakzF1KNfc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1753723862825586.7050033960152; Mon, 28 Jul 2025 10:31:02 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ugRgU-0003Eb-7A; Mon, 28 Jul 2025 13:30:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ugRgE-0002ly-Ia for qemu-devel@nongnu.org; Mon, 28 Jul 2025 13:30:32 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ugRg8-00061L-KO for qemu-devel@nongnu.org; Mon, 28 Jul 2025 13:30:28 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-640-NsCFXRGlPSqY1l_d9p9Ypw-1; Mon, 28 Jul 2025 13:30:21 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 91B4E1956089; Mon, 28 Jul 2025 17:30:20 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.45.224.117]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8085330001B1; Mon, 28 Jul 2025 17:30:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1753723823; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=eUoKj/NKwS1Na52rnIVQy+Sv4r/p2PoH+hWl9VDYsC4=; b=J+37hM6hkV63nBroUJvIO8y0EsyId/P2iCZEfJtgMYauKSGa6qF4msxIU61cKFPmolWv65 tIciQZ/7DW8zXKMfc3CsJ0sidWQxgauWpnBo0Py0IXSs3t3pBmqKhF4GGh3gDf7/tnQr6k NVeHLXCH5NdY6yZpPLEXl/ESiFBtY5s= X-MC-Unique: NsCFXRGlPSqY1l_d9p9Ypw-1 X-Mimecast-MFC-AGG-ID: NsCFXRGlPSqY1l_d9p9Ypw_1753723820 From: Thomas Huth To: qemu-devel@nongnu.org, Michael Roth , Kostiantyn Kostiuk Cc: qemu-trivial@nongnu.org Subject: [PATCH] qga: Fix ubsan warning Date: Mon, 28 Jul 2025 19:30:16 +0200 Message-ID: <20250728173016.314460-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1753723864588116600 Content-Type: text/plain; charset="utf-8" From: Thomas Huth When compiling QEMU with --enable-ubsan there is a undefined behavior warning when running "make check": .../qga/commands-linux.c:452:15: runtime error: applying non-zero offset 5= to null pointer #0 0x55ea7b89450c in build_guest_fsinfo_for_pci_dev ..../qga/commands-linu= x.c:452:15 Add a check to avoid incrementing the NULL pointer here. Signed-off-by: Thomas Huth --- qga/commands-linux.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/qga/commands-linux.c b/qga/commands-linux.c index 9e8a934b9a6..caf7c3ca22b 100644 --- a/qga/commands-linux.c +++ b/qga/commands-linux.c @@ -449,7 +449,9 @@ static bool build_guest_fsinfo_for_pci_dev(char const *= syspath, has_ata =3D true; } else { p =3D strstr(syspath, "/host"); - q =3D p + 5; + if (p) { + q =3D p + 5; + } } if (p && sscanf(q, "%u", &host) =3D=3D 1) { has_host =3D true; --=20 2.50.1