From nobody Sat Nov 15 07:40:54 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1753707133; cv=none; d=zohomail.com; s=zohoarc; b=jU3evKJSZTlSQSpm6NagWNtNzp/qrsxhuHAm3ieXSqdkBZYtfWqPZxSlih/esO323TiDxnNuCZ4+ww7Xk5wjOoeS2PBnqHUTKIap5pFwhmKW+CAQUEPjunkwkTq00aCBJGyjXuPVI86M5AzFdTE2Ts3Qce1SrE44pFTfN9ZQUVE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753707133; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=2szhJQ7dSyIH9DhmHOZ8nF3ebARAGyN8E/8WjdRAQpc=; b=acDejiI6ShNSp8b6a6uMP87kxOWV0ABEV7tG1q83HpPZtaost/FZ6DajumlzZuprsGqud+ThAtKP1HIivsNtka2t/GUCstMia8xF40dGDLNEWD/1SP+y4LNxz0sURB+2Bw6ahOBwQ/5McMACxGPHCxWhRJkeEHMlUJbu6BxoL0I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1753707133673618.9190967909663; Mon, 28 Jul 2025 05:52:13 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ugNKS-000102-50; Mon, 28 Jul 2025 08:51:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ugMcQ-0007gH-1q for qemu-devel@nongnu.org; Mon, 28 Jul 2025 08:06:15 -0400 Received: from mgamail.intel.com ([198.175.65.14]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ugMcG-0006fq-Rw for qemu-devel@nongnu.org; Mon, 28 Jul 2025 08:06:13 -0400 Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2025 05:05:58 -0700 Received: from lxy-clx-4s.sh.intel.com ([10.239.48.52]) by orviesa007.jf.intel.com with ESMTP; 28 Jul 2025 05:05:57 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1753704365; x=1785240365; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=RGlSGzGkbqVhDC4KFQQiXuDi9zm1hRpG1NVXQpKek9Q=; b=dglAUdAW9s64KBAZB1esblBo5UkaLjlM6Ey0+loxXPuunswupcxtw9cK MGZdqiYKcZiSCuLGFerh2WEUTuEiWTi6nspYkaAam2uR5XcNsxTYEnpH4 V2Az1HKrb8E7YwLYB4k07JDbe+6BL22KKfwdoDj4ThXhtIg8d+vidwFQz UpTAcOIHCrEJJ2eSenMg4rrMzTvcH+gy9aNCO10U9y6bnwpdFFUJbsk3x cEEigjdiDetEDp6gmMpp7MY0xjux4vYxNTGKnMKhVn9BZHq2HmEh+3pOz RiH0MXTVRF5sM50SaIKqu5skmcl3KVOZIOL568qNLzyAPYYETgMNiNp75 A==; X-CSE-ConnectionGUID: PwWc3KQlTeOYXvqgzXRZ4Q== X-CSE-MsgGUID: l7dj0tJdTJyiU8CNk8qNyQ== X-IronPort-AV: E=McAfee;i="6800,10657,11504"; a="59755643" X-IronPort-AV: E=Sophos;i="6.16,339,1744095600"; d="scan'208";a="59755643" X-CSE-ConnectionGUID: pVtzO6kKSuaKuxxq845gjw== X-CSE-MsgGUID: SCwLSxMeQGehbj74rlDn3Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,339,1744095600"; d="scan'208";a="162448041" From: Xiaoyao Li To: Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Cc: qemu-devel@nongnu.org, Xiaoyao Li Subject: [PATCH v2 1/3] accel/kvm: Switch to check KVM_CAP_GUEST_MEMFD and KVM_CAP_USER_MEMORY2 on VM Date: Mon, 28 Jul 2025 19:57:05 +0800 Message-ID: <20250728115707.1374614-2-xiaoyao.li@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250728115707.1374614-1-xiaoyao.li@intel.com> References: <20250728115707.1374614-1-xiaoyao.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=198.175.65.14; envelope-from=xiaoyao.li@intel.com; helo=mgamail.intel.com X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HK_RANDOM_ENVFROM=0.001, HK_RANDOM_FROM=0.299, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @intel.com) X-ZM-MESSAGEID: 1753707136368116600 Content-Type: text/plain; charset="utf-8" It returns more accruate result on checking KVM_CAP_GUEST_MEMFD and KVM_CAP_USER_MEMORY2 on VM instance instead of on KVM platform. Signed-off-by: Xiaoyao Li --- accel/kvm/kvm-all.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 890d5ea9f865..14d47246ca63 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -2776,8 +2776,8 @@ static int kvm_init(AccelState *as, MachineState *ms) =20 kvm_supported_memory_attributes =3D kvm_vm_check_extension(s, KVM_CAP_= MEMORY_ATTRIBUTES); kvm_guest_memfd_supported =3D - kvm_check_extension(s, KVM_CAP_GUEST_MEMFD) && - kvm_check_extension(s, KVM_CAP_USER_MEMORY2) && + kvm_vm_check_extension(s, KVM_CAP_GUEST_MEMFD) && + kvm_vm_check_extension(s, KVM_CAP_USER_MEMORY2) && (kvm_supported_memory_attributes & KVM_MEMORY_ATTRIBUTE_PRIVATE); kvm_pre_fault_memory_supported =3D kvm_vm_check_extension(s, KVM_CAP_P= RE_FAULT_MEMORY); =20 --=20 2.43.0 From nobody Sat Nov 15 07:40:54 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1753707167; cv=none; d=zohomail.com; s=zohoarc; b=JWuIIbvVD2pAxokiBqYtiS6slry5fu3l8GGLWrNilJh61dejriHr6DINMNl5dvB8IaLHiWEi2ENNHMnAmWXa+cyzwh8gVAl0ibb2DnwAhVtyQ6L0mLb1PD+FexmotvjPq2EsIt1/3SH1quUF78OtIvX1a3Ip9tndiiGYCqKNGfY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753707167; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=KJnFHAezcXMNBeY8SiXsV3Ri8xkV2YSvblU3X/fCwWQ=; b=UirT0gkMRSWxojuYU0TOJMfzGVyDCExjG3K0FOimRo068lcITYCe3ZZHlPY7YWXIA1jTD/RlY1gEK8kXnan33At2b3vP2ZzDwTkOsF0SEb5gpLy8yo7SjvKaYHuG/L/2hGQXpqh7eS1yi66PBQsc66Etn4b2mGdEUEJe5qNBQOE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1753707167095559.0780069407897; Mon, 28 Jul 2025 05:52:47 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ugNL3-0005n3-L5; Mon, 28 Jul 2025 08:52:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ugMcM-0006Qg-OI for qemu-devel@nongnu.org; Mon, 28 Jul 2025 08:06:11 -0400 Received: from mgamail.intel.com ([198.175.65.14]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ugMcF-0006gd-UO for qemu-devel@nongnu.org; Mon, 28 Jul 2025 08:06:09 -0400 Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2025 05:06:00 -0700 Received: from lxy-clx-4s.sh.intel.com ([10.239.48.52]) by orviesa007.jf.intel.com with ESMTP; 28 Jul 2025 05:05:59 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1753704364; x=1785240364; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=IV8iEfmq1zTpbU9+OYQ73jjYB45ZmpcAWAnHj52uhSY=; b=QuCclYvfpEz0zVZet174XniG8Lj9w3KBmpcmvjfr/SBhj11HKE8kZ/yd nmHUdlGpHQriuqzzfamFVxQwt0f/fKxYVYGZkONWmi043wj0FzvB6wyAd fLizbYWDyD1iw8WqwWtqXwC5eXpabphQ4XgAGbg3IQY2gOCN9nXXdhK2A QvXBpkJofOsB9wCYCw4zXKpGfafciG4Pieeu4uXwE1hNocFVKDuHXIxWo rCu30c86RwDmOR2ky8v1DK4joyywi1v8ehpS12gbBcMboKFBpPv0tIaHC HlSza+hVTqlMQ8IHaiZ3wu4PLbeMYIrXrMgmE7/X7+db6aXJQfYcEbfpP A==; X-CSE-ConnectionGUID: sJR5uebeSG2CgkqbpSexSA== X-CSE-MsgGUID: l0ngZA/LSV6eKHF4Jh+1fw== X-IronPort-AV: E=McAfee;i="6800,10657,11504"; a="59755648" X-IronPort-AV: E=Sophos;i="6.16,339,1744095600"; d="scan'208";a="59755648" X-CSE-ConnectionGUID: v3+v0K1xT9eFGE5QbQoSUQ== X-CSE-MsgGUID: ObnGkewGQuCBt2Tqo2PhRA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,339,1744095600"; d="scan'208";a="162448051" From: Xiaoyao Li To: Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Cc: qemu-devel@nongnu.org, Xiaoyao Li Subject: [PATCH v2 2/3] accel/kvm: Zero out mem explicitly in kvm_set_user_memory_region() Date: Mon, 28 Jul 2025 19:57:06 +0800 Message-ID: <20250728115707.1374614-3-xiaoyao.li@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250728115707.1374614-1-xiaoyao.li@intel.com> References: <20250728115707.1374614-1-xiaoyao.li@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=198.175.65.14; envelope-from=xiaoyao.li@intel.com; helo=mgamail.intel.com X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HK_RANDOM_ENVFROM=0.001, HK_RANDOM_FROM=0.299, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @intel.com) X-ZM-MESSAGEID: 1753707168799116601 Zero out the entire mem explicitly before it's used, to ensure the unused feilds (pad1, pad2) are all zeros. Otherwise, it might cause problem when the pad fields are extended by future KVM. Fixes: ce5a983233b4 ("kvm: Enable KVM_SET_USER_MEMORY_REGION2 for memslot") Signed-off-by: Xiaoyao Li Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- changes in v2: - using {} instead of memset(); (suggested by Philippe) --- accel/kvm/kvm-all.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 14d47246ca63..90f3b177a1ff 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -358,7 +358,7 @@ int kvm_physical_memory_addr_from_host(KVMState *s, voi= d *ram, static int kvm_set_user_memory_region(KVMMemoryListener *kml, KVMSlot *slo= t, bool new) { KVMState *s =3D kvm_state; - struct kvm_userspace_memory_region2 mem; + struct kvm_userspace_memory_region2 mem =3D {}; int ret; =20 mem.slot =3D slot->slot | (kml->as_id << 16); --=20 2.43.0 From nobody Sat Nov 15 07:40:54 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1753707167; cv=none; d=zohomail.com; s=zohoarc; b=f1L0EpxKpPwr4pApN/nRfpxyg2+9KFcPsAsBTbkRCbE3ppoWpfw2ssLOXqVv0RUoyJ/J+fVTVA7gM1Al66FgK9jX1Fm7A7/VD03z4+ee3ilppDwhyS83oMS+tK/IU5p6YuLKzGtMlLIkhD+Udrr3yFWe6tz7vNU8c5qg5HWEzag= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753707167; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=z/MvHOYFYa4h6LTexzTRNoWnI4hMok4Hz7KEO43PP/8=; b=Q6KeM7tYqn9qguSVTkpSDyBU0B+gRlorAxqOXm9zx3v9U8QaHD+2Gg/Ghp2MRUoHQIaM6AP7VheahBd3Kbo0PWRuKlkOAElGplr1ag0X8SJtO2u8xWmBiO0cFTj13CDnmnXMG8FS5IP7G01tbub9mPMrmD/Oh0bTsTxR68w2WXc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1753707167076977.6511687930447; Mon, 28 Jul 2025 05:52:47 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ugNKl-0002ve-FP; Mon, 28 Jul 2025 08:52:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ugMcU-0000er-D5 for qemu-devel@nongnu.org; Mon, 28 Jul 2025 08:06:18 -0400 Received: from mgamail.intel.com ([198.175.65.14]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ugMcO-0006gd-NL for qemu-devel@nongnu.org; Mon, 28 Jul 2025 08:06:18 -0400 Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2025 05:06:01 -0700 Received: from lxy-clx-4s.sh.intel.com ([10.239.48.52]) by orviesa007.jf.intel.com with ESMTP; 28 Jul 2025 05:06:00 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1753704373; x=1785240373; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=A8X/oNNt3W+yZsMLySvP4Wg+djHSi0ZYoJCDENTqZvs=; b=Nv4Wz3yTdNfGRBp+s3vxTpvaAVuchURKh7wCJc+MuRoKlqtmF8RCl5HX IwmyRwarfoH2FEu4VjoxItgFt7HpF431im+xkHC6C/I7NdZr6zdKdENAy tdCdjI4cL3DKoI2tPTgCAQLyYsvMour/nrX/7CpC48VfpECfHZwoEilJg gn+Kv9/FDtNPvyHIIxeGLw9o/EUcw4R9v3wf1QwsSeCBsBhlFraRQHUEZ 8TEl8gwZB2vTpMCCUoJHwv9GxUJA0b2Kr5THFzSAH1d3Fxtl8pfnkGRFT s4a5FNSMmAm+5OZK4HOy9j10vZRu6AZmVHLVUGmYS65qIl+2ZT8FF7FME A==; X-CSE-ConnectionGUID: z24kcERdR4O3+wcNPizKPg== X-CSE-MsgGUID: jNCL0Hl0SeKXc1otdT1WTA== X-IronPort-AV: E=McAfee;i="6800,10657,11504"; a="59755656" X-IronPort-AV: E=Sophos;i="6.16,339,1744095600"; d="scan'208";a="59755656" X-CSE-ConnectionGUID: HkfYL0nIQwiitS+4JV2Ppg== X-CSE-MsgGUID: 7+vw4gQbSKySyQeB8tBoKg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,339,1744095600"; d="scan'208";a="162448062" From: Xiaoyao Li To: Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Cc: qemu-devel@nongnu.org, Xiaoyao Li Subject: [PATCH v2 3/3] accel/kvm: Set guest_memfd_offset to non-zero value only when guest_memfd is valid Date: Mon, 28 Jul 2025 19:57:07 +0800 Message-ID: <20250728115707.1374614-4-xiaoyao.li@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250728115707.1374614-1-xiaoyao.li@intel.com> References: <20250728115707.1374614-1-xiaoyao.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=198.175.65.14; envelope-from=xiaoyao.li@intel.com; helo=mgamail.intel.com X-Spam_score_int: -36 X-Spam_score: -3.7 X-Spam_bar: --- X-Spam_report: (-3.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, HK_RANDOM_ENVFROM=0.001, HK_RANDOM_FROM=0.299, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @intel.com) X-ZM-MESSAGEID: 1753707168799116600 Content-Type: text/plain; charset="utf-8" Current QEMU unconditionally sets the guest_memfd_offset of KVMSlot in kvm_set_phys_mem(), which leads to the trace of kvm_set_user_memory looks: kvm_set_user_memory AddrSpace#0 Slot#4 flags=3D0x2 gpa=3D0xe0000 size=3D0x2= 0000 ua=3D0x7f5840de0000 guest_memfd=3D-1 guest_memfd_offset=3D0x3e0000 ret= =3D0 It's confusing that the guest_memfd_offset has a non-zero value while the guest_memfd is invalid (-1). Change to only set guest_memfd_offset when guest_memfd is valid and leave it as 0 when no valid guest_memfd. Signed-off-by: Xiaoyao Li --- Changes in v2: - initialize guest_memfd_offset in kvm_set_phys_mem(); (Phillippe) --- accel/kvm/kvm-all.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 90f3b177a1ff..cc694fe3c3a9 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -1595,7 +1595,8 @@ static void kvm_set_phys_mem(KVMMemoryListener *kml, mem->ram =3D ram; mem->flags =3D kvm_mem_flags(mr); mem->guest_memfd =3D mr->ram_block->guest_memfd; - mem->guest_memfd_offset =3D (uint8_t*)ram - mr->ram_block->host; + mem->guest_memfd_offset =3D mem->guest_memfd >=3D 0 ? + (uint8_t*)ram - mr->ram_block->host : 0; =20 kvm_slot_init_dirty_bitmap(mem); err =3D kvm_set_user_memory_region(kml, mem, true); --=20 2.43.0