From nobody Sat Nov 15 09:10:29 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=unpredictable.fr ARC-Seal: i=1; a=rsa-sha256; t=1753482858; cv=none; d=zohomail.com; s=zohoarc; b=It0StG3bkIm6F5Wq0iSx7J58p0YUh53BCX/DCROxcJ3B/C1iXTwI5xkwNxkevBgNhQH3mIdGiQvn+2q3WcOQ0zwqqwdYkM9J5zN+oIVxy0aG51XmCRvsMQlgfVdc5p2y/M0jaEXiM0+2CZl48x4C9siKphz/weQ8+kJlVAV27oE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753482858; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=eR/9MRlLPW5uSL11Gkutp5bmbs/sIhqyKweuQxFjGMY=; b=iw56gl1NNnGorLw0lFGSE/wvh4wTaiPwtDfC1heIqmvAu7mZKwe7wXCQ5Rld77cji0p/rhxwFBRhhNXMejI2j2ib86RVIVkscyhsZuIk+O+qoP56gdc2u8eZlksTq4MOovrAap2bgjI/KbSdEDnisAUF3z1e3zQCOTY6bzmOg9c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17534828579774.36332015288815; Fri, 25 Jul 2025 15:34:17 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ufQyJ-0007SD-C2; Fri, 25 Jul 2025 18:32:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ufQx0-0006fl-1i for qemu-devel@nongnu.org; Fri, 25 Jul 2025 18:31:39 -0400 Received: from p-east3-cluster3-host4-snip4-10.eps.apple.com ([57.103.86.43] helo=outbound.qs.icloud.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ufQwb-0003kY-Te for qemu-devel@nongnu.org; Fri, 25 Jul 2025 18:31:16 -0400 Received: from outbound.qs.icloud.com (unknown [127.0.0.2]) by p00-icloudmta-asmtp-us-east-2d-100-percent-4 (Postfix) with ESMTPS id E081E1800125; Fri, 25 Jul 2025 22:30:45 +0000 (UTC) Received: from localhost.localdomain (qs-asmtp-me-k8s.p00.prod.me.com [17.57.155.37]) by p00-icloudmta-asmtp-us-east-2d-100-percent-4 (Postfix) with ESMTPSA id 9511B1800130; Fri, 25 Jul 2025 22:30:43 +0000 (UTC) Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr; s=sig1; bh=eR/9MRlLPW5uSL11Gkutp5bmbs/sIhqyKweuQxFjGMY=; h=From:To:Subject:Date:Message-Id:MIME-Version:x-icloud-hme; b=Voh37PAJV+2cdxFJO5KjHs/pwY/+kA/etdYsb5zABmWMS9JMLBJesLWGHeYU9Ugh/kDFU1XzkuMUFmmlB53CAcopUIlQ1LQZuVk0MQV1k9W/HtLj8wpjPleHRT7YDUMEl/tH1kbz9HWYL3QNgBr365hVMHHxEEuFXZ6rK1vZA0Rs8bShYHLrdZoAFkdNFOUjafiQ4dDyEsFr+T4NkY0p2zqbiZcfM/ALVaqgVJPxcCwxaQDLJt3SahElfXPHF2/PPdpONG5cc0JiZWgChIeahTfTDUxsxgknaxYc+d0qSikiDb8Xq5IXRDSJoxxhcLRBnK6jH0uOHFEVioY5pqdwEA== X-Client-IP: 46.189.47.18 From: Mohamed Mediouni To: qemu-devel@nongnu.org Cc: Phil Dennis-Jordan , Mads Ynddal , Cameron Esfahani , Ani Sinha , qemu-arm@nongnu.org, Igor Mammedov , Alexander Graf , Shannon Zhao , Peter Maydell , Roman Bolshakov , "Michael S. Tsirkin" , Paolo Bonzini , Mohamed Mediouni Subject: [PATCH v3 3/9] target/arm: add asserts for code paths not leveraged when using the vGIC Date: Sat, 26 Jul 2025 00:30:29 +0200 Message-Id: <20250725223035.52284-4-mohamed@unpredictable.fr> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20250725223035.52284-1-mohamed@unpredictable.fr> References: <20250725223035.52284-1-mohamed@unpredictable.fr> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzI1MDE5NSBTYWx0ZWRfX4JtxKITk/DhC a8hoEifeHhARm5CivU7hNv7B73OVyGLcBKQddU/ZHg4sqNgpnogNFQTpSKo02ePj8J+rVxR7M0B /ev/rm+f83rxYlt6pcJ6Ow6YzPUYghbKllksC5RENSxaKf7DuCH/Caw0gtjJ0GjxHmbLZT8nNcS dMnFLtF8QGbSe8LGkzG3xZzCXztXpVvmfYCuobdsQ98l9KvOP4/ed3p3SlVmf30t2anSSaTp8M5 G26HEsKeBmcTcrxL1uwsmE4RS7GY69SIE6jZp1h0ssAPdUibF6/vP8MDOP/bVZg1Bw+u1H5d4= X-Proofpoint-GUID: sCZ8l14TPXwGbvbldrRGT-fZYhyiMevG X-Proofpoint-ORIG-GUID: sCZ8l14TPXwGbvbldrRGT-fZYhyiMevG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-07-25_06,2025-07-24_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 spamscore=0 malwarescore=0 mlxlogscore=662 suspectscore=0 bulkscore=0 phishscore=0 clxscore=1030 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.22.0-2506270000 definitions=main-2507250195 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=57.103.86.43; envelope-from=mohamed@unpredictable.fr; helo=outbound.qs.icloud.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @unpredictable.fr) X-ZM-MESSAGEID: 1753482861977116600 Content-Type: text/plain; charset="utf-8" When using the vGIC, timers are directly handled by the platform, so no vme= xits ought to happen in that case. Signed-off-by: Mohamed Mediouni --- target/arm/hvf/hvf.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index 3ba74b8daa..7beb47caad 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -1382,6 +1382,9 @@ static int hvf_sysreg_read(CPUState *cpu, uint32_t re= g, uint64_t *val) case SYSREG_ICC_SGI1R_EL1: case SYSREG_ICC_SRE_EL1: case SYSREG_ICC_CTLR_EL1: + if (hvf_irqchip_in_kernel()) { + abort(); + } /* Call the TCG sysreg handler. This is only safe for GICv3 regs. = */ if (hvf_sysreg_read_cp(cpu, reg, val)) { return 0; @@ -1702,6 +1705,9 @@ static int hvf_sysreg_write(CPUState *cpu, uint32_t r= eg, uint64_t val) case SYSREG_ICC_SGI0R_EL1: case SYSREG_ICC_SGI1R_EL1: case SYSREG_ICC_SRE_EL1: + if (hvf_irqchip_in_kernel()) { + abort(); + } /* Call the TCG sysreg handler. This is only safe for GICv3 regs. = */ if (hvf_sysreg_write_cp(cpu, reg, val)) { return 0; @@ -1965,6 +1971,10 @@ int hvf_vcpu_exec(CPUState *cpu) /* This is the main one, handle below. */ break; case HV_EXIT_REASON_VTIMER_ACTIVATED: + /* This is only for when a user-mode irqchip is used. */ + if (hvf_irqchip_in_kernel()) { + assert("vtimer activated vmexit when using platform GIC"); + } qemu_set_irq(arm_cpu->gt_timer_outputs[GTIMER_VIRT], 1); cpu->accel->vtimer_masked =3D true; return 0; --=20 2.39.5 (Apple Git-154)