From nobody Sat Nov 15 11:12:30 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1753255318; cv=none; d=zohomail.com; s=zohoarc; b=IshlZlb7aTKSpEUxCyyTceXuUHqvQG+iaQaIN0E/55tf3ZTcxVaPXXaoSRtOrvA7xPxTkuVBq/OtEuDPvpa+1W6Bz35Bixbpb3j7V6UZmepeJIeMwO2pbmz1BCbVmcwEODXk1yljku/A4wyGWcOUSeUFMGSaPtSaNPEa2++KIN4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753255318; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=JOpP+NQ5jwtC9qWrag6XTOS6/VxuG+1ChioG8mfBUZA=; b=R7yEcT1fqWFGnzcYP5qgmQ4ZuvDR2MKLn5Xe5gmpxURiU5rjwUjRm+vBSccR6Q8iItijmOR08O7L4ntcAS9kDUR6L5VEyUuwOLCiQIC9ULCJIiAQ+Cxc8d+KoLog/XlaURZs+tloQtEAYXn/I9bcfXViOXs5HK4o3iE76/axues= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1753255318345700.3404563031252; Wed, 23 Jul 2025 00:21:58 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ueTmm-0004fH-NO; Wed, 23 Jul 2025 03:21:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ueTkQ-0003LA-CX for qemu-devel@nongnu.org; Wed, 23 Jul 2025 03:18:48 -0400 Received: from mgamail.intel.com ([198.175.65.17]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ueTkM-00045r-TO for qemu-devel@nongnu.org; Wed, 23 Jul 2025 03:18:41 -0400 Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jul 2025 00:18:28 -0700 Received: from lxy-clx-4s.sh.intel.com ([10.239.48.52]) by orviesa010.jf.intel.com with ESMTP; 23 Jul 2025 00:18:27 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1753255119; x=1784791119; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=52oT5Itnfiv37Yuay+npj8js5KUzQMhQ5rorHPwD6W0=; b=WjoC7klbyXTAOxP7Pgvmw/PInskhH4WleynwPXBRnZS234vcZQs+MyXH TQr9b9rgziHIOdnmdGnvVdllAqSPoJbyl6FFf5862yWzOli/gH4aXb4QK D8Bf8YlFfowPLfREBNdOy2lc2J4r/2eLgQyBWGp24X/PRH5jRJA/sAQB6 6ZH3pCg457JNSvq5cXtI6HW1c46qU+RUQrmgrO0FTFfDWG8Vzc2aLzQa4 Ol6sZ8Ywqq2QaL7TvWXk66emDS+ZTaa5Ad21A9tej2lVOTDrW5UGLwU0+ d29V3PEw/afNDsq3oPWnkCHdIJaULUSCLOxq8YEU6SPerZdpjuz3vNxX8 g==; X-CSE-ConnectionGUID: gkSq5w0eRTqkpxjJCYoqjA== X-CSE-MsgGUID: GtnUo8lxR7eZcDn7zTzNog== X-IronPort-AV: E=McAfee;i="6800,10657,11500"; a="55480932" X-IronPort-AV: E=Sophos;i="6.16,333,1744095600"; d="scan'208";a="55480932" X-CSE-ConnectionGUID: 65/Bv/Q6RaKIHJy/0Rxgww== X-CSE-MsgGUID: Eu7Bn4nmSw2igAIZ/X7Atw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,333,1744095600"; d="scan'208";a="158662236" From: Xiaoyao Li To: Paolo Bonzini Cc: qemu-devel@nongnu.org, Xiaoyao Li Subject: [PATCH 3/3] accel/kvm: Set mem.guest_memfd_offset only when guest_memfd is valid Date: Wed, 23 Jul 2025 15:09:51 +0800 Message-ID: <20250723070951.1134374-4-xiaoyao.li@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250723070951.1134374-1-xiaoyao.li@intel.com> References: <20250723070951.1134374-1-xiaoyao.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=198.175.65.17; envelope-from=xiaoyao.li@intel.com; helo=mgamail.intel.com X-Spam_score_int: -39 X-Spam_score: -4.0 X-Spam_bar: ---- X-Spam_report: (-4.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.633, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HK_RANDOM_ENVFROM=0.001, HK_RANDOM_FROM=0.999, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @intel.com) X-ZM-MESSAGEID: 1753255318921116600 Content-Type: text/plain; charset="utf-8" Current QEMU unconditionally sets the mmem.guest_memfd_offset in kvm_set_user_memory_region(), which leads to the trace of kvm_set_user_memo= ry look as: kvm_set_user_memory AddrSpace#0 Slot#4 flags=3D0x2 gpa=3D0xe0000 size=3D0x2= 0000 ua=3D0x7f5840de0000 guest_memfd=3D-1 guest_memfd_offset=3D0x3e0000 ret= =3D0 It's confusing that the guest_memfd_offset has a non-zero value while the guest_memfd is invalid (-1). Change to only set guest_memfd_offset when guest_memfd is valid. Signed-off-by: Xiaoyao Li --- accel/kvm/kvm-all.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 4f4c30fc84b2..2b6fbf58a127 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -367,7 +367,9 @@ static int kvm_set_user_memory_region(KVMMemoryListener= *kml, KVMSlot *slot, boo mem.userspace_addr =3D (unsigned long)slot->ram; mem.flags =3D slot->flags; mem.guest_memfd =3D slot->guest_memfd; - mem.guest_memfd_offset =3D slot->guest_memfd_offset; + if (slot->guest_memfd >=3D 0) { + mem.guest_memfd_offset =3D slot->guest_memfd_offset; + } =20 if (slot->memory_size && !new && (mem.flags ^ slot->old_flags) & KVM_M= EM_READONLY) { /* Set the slot size to 0 before setting the slot to the desired --=20 2.43.0