From nobody Sat Nov 15 11:12:30 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1753255322; cv=none; d=zohomail.com; s=zohoarc; b=YlaqZLFYQFX1Zqc25YSQo1Hf/qIeBOX71T7gWh0x4Ijk/Fe+b1yCKtk8eJ8TNvSj+AooaAuymYi1V9k122hwvX4FO5Rwa8KTIhvpvy/gWP8RHYI750J3YG1mwPT0GqJ5VgaqjE8XM8GM0Z2eOD7SjwgGiZME3P7dRFzqD8a7lGQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753255322; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=xCyUl8zkYtQkCEhA22gnL/TeflPw49Z2mo9jp5TmfQw=; b=I/beQjSBqXwGTezH1AIk8aOtDAAckTFvfMRxYptIJkrb7z3jUwgt6Wu8VYKElvJm6Aee1aVRy4dcHBQWPGaGDRtmdVhepyn+XGbcvpRBZKuLdbXQp5sQau4zV3cGLozVE9RxDojPY7xdvsPh5Pkp5Nc9ZzinPc5gdXbA0/KiRLI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1753255322624648.0081530371217; Wed, 23 Jul 2025 00:22:02 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ueTmx-0004qo-4Y; Wed, 23 Jul 2025 03:21:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ueTkM-0003Kh-Hc for qemu-devel@nongnu.org; Wed, 23 Jul 2025 03:18:41 -0400 Received: from mgamail.intel.com ([198.175.65.17]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ueTkG-00046A-KL for qemu-devel@nongnu.org; Wed, 23 Jul 2025 03:18:38 -0400 Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jul 2025 00:18:27 -0700 Received: from lxy-clx-4s.sh.intel.com ([10.239.48.52]) by orviesa010.jf.intel.com with ESMTP; 23 Jul 2025 00:18:25 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1753255113; x=1784791113; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=qJZpNmIiyzLZ+1AQHuc1dq2zIeu4XixLkbA12OZ7a+k=; b=PRb1drwd3w0XEsSzXHk6m2gjferbhaSKpQT8XABN9VyStaotCHPOhupH 59PyhWUXBodx4UEv+2GBU0JyIDGnhKZUd5CO/O8EtYISY5LazGXfrsZA0 efADUSremSv44o8kyqF1J2wAaEp+gJTD3abWWL0HTmMlrTSiAdHeFPCD2 fwcx1ZFs65rGra+zcQzATePyN+IbK25TPJy1kbsoU1tbK3tW2nXEB9Wi9 nmN0+18LMhR7t+x5PgfAH/O664MRAClNawIjPF7CN+NQUfWkRk2nSU6go M4ssfMW2J5Fz+5/5hNWJXAMtNzo0KC75rdb1vHuEbrTrAZ0qRIdwgBVFk Q==; X-CSE-ConnectionGUID: Txvnx8XQSG+oI/MrV0ss1g== X-CSE-MsgGUID: JvBZ8XwpR+yNfgh9PNoG1Q== X-IronPort-AV: E=McAfee;i="6800,10657,11500"; a="55480929" X-IronPort-AV: E=Sophos;i="6.16,333,1744095600"; d="scan'208";a="55480929" X-CSE-ConnectionGUID: fJ4CRkcgQTKpSoww9sNvFg== X-CSE-MsgGUID: tC4EPSiJR4mPv5b1062cEw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,333,1744095600"; d="scan'208";a="158662233" From: Xiaoyao Li To: Paolo Bonzini Cc: qemu-devel@nongnu.org, Xiaoyao Li Subject: [PATCH 2/3] accel/kvm: Zero out mem explicitly in kvm_set_user_memory_region() Date: Wed, 23 Jul 2025 15:09:50 +0800 Message-ID: <20250723070951.1134374-3-xiaoyao.li@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250723070951.1134374-1-xiaoyao.li@intel.com> References: <20250723070951.1134374-1-xiaoyao.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=198.175.65.17; envelope-from=xiaoyao.li@intel.com; helo=mgamail.intel.com X-Spam_score_int: -39 X-Spam_score: -4.0 X-Spam_bar: ---- X-Spam_report: (-4.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.633, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HK_RANDOM_ENVFROM=0.001, HK_RANDOM_FROM=0.999, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @intel.com) X-ZM-MESSAGEID: 1753255324859116600 Content-Type: text/plain; charset="utf-8" Zero out the entire mem explicitly before it's used, to ensure the unused feilds (pad1, pad2) are all zeros. Otherwise, it might cause problem when the pad fields are extended by future KVM. Fixes: ce5a983233b4 ("kvm: Enable KVM_SET_USER_MEMORY_REGION2 for memslot") Signed-off-by: Xiaoyao Li Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- accel/kvm/kvm-all.c | 1 + 1 file changed, 1 insertion(+) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 14d47246ca63..4f4c30fc84b2 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -361,6 +361,7 @@ static int kvm_set_user_memory_region(KVMMemoryListener= *kml, KVMSlot *slot, boo struct kvm_userspace_memory_region2 mem; int ret; =20 + memset(&mem, 0, sizeof(mem)); mem.slot =3D slot->slot | (kml->as_id << 16); mem.guest_phys_addr =3D slot->start_addr; mem.userspace_addr =3D (unsigned long)slot->ram; --=20 2.43.0