From nobody Sat Nov 15 11:14:44 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1753227859; cv=none; d=zohomail.com; s=zohoarc; b=CyBdhH3CXCerIG2MbhwsqlUkY/Ijr7wNnpJaKzdiZD+ZhK6cEidTg6NYoFRFT/Vn4wKDVY+OZHXcSm38Fz+Wm/42giZtRXM1P1JpQgEWkwZ3gTPOw+XkAB8hVZKM58i7IchcPNkkREaKJazZDqjy1LCWdkFOUtfySnzyPTRGG3c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753227859; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=p+XAgmDBTmks2GsZR1QW1XdUNlqAMMzX8BRwPw+gsOQ=; b=hLmikHBsh7+FJOo5+NDYc3yy3jagLI57S5tgPkYAbL86WtY5K0jBeHW/xzMMYX2UWIOeS4uaj8AsvaoeVaJi0EWkjH0jnrW8AdWea9EioWuAhZ70MhorHl4CpmtPMfRcb1pCKU5kh6hEYyx8CGmN/IImnjUED4ul41oHbGVMWtc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1753227859826424.8790027366971; Tue, 22 Jul 2025 16:44:19 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ueMd6-0002Hx-LL; Tue, 22 Jul 2025 19:42:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ueMd0-0002Bq-Pe for qemu-devel@nongnu.org; Tue, 22 Jul 2025 19:42:34 -0400 Received: from smtp-out2.suse.de ([2a07:de40:b251:101:10:150:64:2]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ueMcy-0007qF-J1 for qemu-devel@nongnu.org; Tue, 22 Jul 2025 19:42:34 -0400 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AB1401F78A; Tue, 22 Jul 2025 23:42:21 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 193E313AF1; Tue, 22 Jul 2025 23:42:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id YOwhMtshgGiqOgAAD6G6ig (envelope-from ); Tue, 22 Jul 2025 23:42:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1753227741; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p+XAgmDBTmks2GsZR1QW1XdUNlqAMMzX8BRwPw+gsOQ=; b=mT3j9EHZNx1MSa5EKhUoaFfKqKuvEVDU8ggh+4eupXUGIH8SHoS41/v4ImSknCmsYA0WCv kPBcY/VpiV9CDhKXJ8F4DjfbZIL8Cq/EfIDtgL4Frslz/HGIlb5T8d1T4hrVQeRzq2jtxn X+P9gKZRWLkhv8qQdKFjPeq8MH2XkEY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1753227741; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p+XAgmDBTmks2GsZR1QW1XdUNlqAMMzX8BRwPw+gsOQ=; b=3WxXdwSq+F9Zz+MZCWUBkyd6OuaKFAZ4ujFpL6tR+tuOwT+qV5h6gZXyXHnIBAv/k4jR7Z 3UFJcEOhHbXdsADw== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=mT3j9EHZ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=3WxXdwSq DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1753227741; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p+XAgmDBTmks2GsZR1QW1XdUNlqAMMzX8BRwPw+gsOQ=; b=mT3j9EHZNx1MSa5EKhUoaFfKqKuvEVDU8ggh+4eupXUGIH8SHoS41/v4ImSknCmsYA0WCv kPBcY/VpiV9CDhKXJ8F4DjfbZIL8Cq/EfIDtgL4Frslz/HGIlb5T8d1T4hrVQeRzq2jtxn X+P9gKZRWLkhv8qQdKFjPeq8MH2XkEY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1753227741; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p+XAgmDBTmks2GsZR1QW1XdUNlqAMMzX8BRwPw+gsOQ=; b=3WxXdwSq+F9Zz+MZCWUBkyd6OuaKFAZ4ujFpL6tR+tuOwT+qV5h6gZXyXHnIBAv/k4jR7Z 3UFJcEOhHbXdsADw== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Peter Xu , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 1/7] migration: HMP: Fix possible out-of-bounds access Date: Tue, 22 Jul 2025 20:42:09 -0300 Message-Id: <20250722234215.6807-2-farosas@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20250722234215.6807-1-farosas@suse.de> References: <20250722234215.6807-1-farosas@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-3.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; MIME_TRACE(0.00)[0:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:mid,suse.de:dkim,suse.de:email]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Queue-Id: AB1401F78A X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action X-Spam-Score: -3.51 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a07:de40:b251:101:10:150:64:2; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) X-ZM-MESSAGEID: 1753227862161116600 Coverity has caught a bug in the formatting of time intervals for postcopy latency distribution display in 'info migrate'. While bounds checking the labels array, sizeof is incorrectly being used. ARRAY_SIZE is the correct form of obtaining the size of an array. Fixes: 3345fb3b6d ("migration/postcopy: Add latency distribution report for= blocktime") Resolves: Coverity CID 1612248 Suggested-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 Link: https://lore.kernel.org/qemu-devel/20250716182648.30202-2-farosas@sus= e.de Signed-off-by: Fabiano Rosas --- migration/migration-hmp-cmds.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/migration/migration-hmp-cmds.c b/migration/migration-hmp-cmds.c index cef5608210..bb954881d7 100644 --- a/migration/migration-hmp-cmds.c +++ b/migration/migration-hmp-cmds.c @@ -57,11 +57,9 @@ static const gchar *format_time_str(uint64_t us) const char *units[] =3D {"us", "ms", "sec"}; int index =3D 0; =20 - while (us > 1000) { + while (us > 1000 && index + 1 < ARRAY_SIZE(units)) { us /=3D 1000; - if (++index >=3D (sizeof(units) - 1)) { - break; - } + index++; } =20 return g_strdup_printf("%"PRIu64" %s", us, units[index]); --=20 2.35.3