From nobody Sat Nov 15 09:11:53 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1753207310; cv=none; d=zohomail.com; s=zohoarc; b=TGO578jopcpObGpI2obhM9IGZoUVA3ew0v6mOdDrC8QnSsTAHpcUzSkHLPz37gMa/wafyB0/jpppcl4aUH+DlSQrA8+keB7RUIcT1r95P5R2iox8MHg3+foXcIg/3LWNngTCzL4bqMCna6dHP4zh/Bq8XyXn6PQ+92w2qFxtngs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753207310; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=sQk5HUJlRR9IftTw5Rv2cyyQTojyYbTrMClGWoQN4IM=; b=Vv4WLmTOwH6vjUQjJivUs7OhkDJsB1libJsJrCxVzm2ZdHICDfNLxIbJQ9Wp3ZyvYKD62EDCJJ7zvGRPd2EeJrKHegPvEl7r7h4R3ZHO3cnV1sKVxqk07pBJ/KZ+45VjPEPgl8oX4djpivaCjOGf1vK+DJ3gbFzcJxhC3/Yb+5U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1753207310133545.6858275377416; Tue, 22 Jul 2025 11:01:50 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ueHJ6-00076A-7d; Tue, 22 Jul 2025 14:01:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ueGvw-0000Dl-At for qemu-devel@nongnu.org; Tue, 22 Jul 2025 13:37:44 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ueGvu-00009g-Ah for qemu-devel@nongnu.org; Tue, 22 Jul 2025 13:37:44 -0400 Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56MFrtTt010735 for ; Tue, 22 Jul 2025 17:37:40 GMT Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4826t19qxt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 22 Jul 2025 17:37:40 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-3132c1942a1so7940001a91.2 for ; Tue, 22 Jul 2025 10:37:40 -0700 (PDT) Received: from admin15.qualcomm.com (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-31cb5c5da0csm10081180a91.25.2025.07.22.10.37.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Jul 2025 10:37:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=sQk5HUJlRR9 IftTw5Rv2cyyQTojyYbTrMClGWoQN4IM=; b=Z+fuWK9xQ0glAGFPMBTuur8Bz4z ThBQEXvVKFu7Ij0xU7Jn9pexqw4UPMV+/+LpL8tsyFSagXO+bXXiP4MBBdvzk4SB tkaDywF+D2kuYDHyh2+k0TqG5idfBFzPAMhp3Op5wm+RsaPlyMcOvXMOPd/pPzVY zDC91DOZj1kuzdjiCigs+3iUleUlo8it4b6NQa96ruB/3g5y7r+VkTKFzwjeWRGl se671gfa4Ii5opVyzatNs3kfxnHceu6Ez0mZduvGteWu2XrNhe7TzO2asT2y+2b/ 0TN0BPPDYeEsUt5Jl4WX9Mev49xmohNsy8LOz33rNUteh2bg7xQWhYNohCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753205859; x=1753810659; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sQk5HUJlRR9IftTw5Rv2cyyQTojyYbTrMClGWoQN4IM=; b=mdsPoenRlx5roWHU+8lYVFEt+iSBU1ZmBIgHCjap2+R6VnxviKwM0HTByvKr30Xkmy 9k1vtP8roeuerkQjHfJQAyGbu2yKQ4enc8fiCAbNcpc6ct258alu7RhWI6SbwubNEUhs LaNGIKn1XsY8ArJISPnqlTvfW3RMR7qB9HsrD3wILgXRzp3UjHFpBzZBfBR7LcKn1UVJ OkRpk8nBSOttxfBbGoNqpgQfc7mfv/52F7GaTukq3MSwR80629mAj2umLK0YSF11m/t1 HfKZ6KVTzDdEnsHvXXiVzQ32bDBXcq50FbAGYKXh4023+TQArDInBrRXc6LL0tWIRIW2 OOgQ== X-Gm-Message-State: AOJu0YyUdJf4DWuxP1t7/OHLJkwz9IGwqzBPCJHEHIFyfy835zJPI3Tw SWqeg6D2HJSkqZijiDvoJidh2zz8kaVXI7tehw1Gx7m+qVmFhQJXkhwl/xg+NLEK1gQPmH0Fq1K x7fJzDZn6yzMn9+umH0U6uExftBCHXpMPvt0KcBbJThzSuK+ZOjA1xwJKKMpGPJF/xpov X-Gm-Gg: ASbGncvkzm+Bh5BGrmTKinWkxdsGE3AOp0TFvmIOGE+QUnJj9dbPgeWzWAzuBW6x3qw 5Jr+Z9pRAJp5QCgocPdosZHlHcuvNN78fVtbXokQuW6KtBS04N87vFr1v5Zookj/6CkxbHRbJhm pKXeJI/00cH6Heyejyr2wRYGsbBdwoE2J2NWS6cf2KdgrxbkguVAF8p4OB4pb1qUhwPLKXH3VzP SH0+Hm39B24noRZ9Z4UEQ7GDHahP3C8pwe9xsd+4CH5UN7Pe2aT2VK2t8MD34HDVRhjkj7x7uHf 0x0Ve1amYSj+KuxZRqWdSq/7dA4PgRHQBfxcL7l91B5QFrk2cd7+ML+1jWOpK5b+eXiFL9Q8CZI 4Fj2Dbuq3/vjxNqc= X-Received: by 2002:a17:90b:3cc3:b0:313:23ed:6ff with SMTP id 98e67ed59e1d1-31e506f9b36mr216018a91.1.1753205859397; Tue, 22 Jul 2025 10:37:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHNSFGE9C7UIX8z5Upn1vLQE1FHr1aNfTQSqwEgQnF4vwvNd+V0ufMCgHKilz0K6BCXF870sw== X-Received: by 2002:a17:90b:3cc3:b0:313:23ed:6ff with SMTP id 98e67ed59e1d1-31e506f9b36mr215983a91.1.1753205859010; Tue, 22 Jul 2025 10:37:39 -0700 (PDT) From: Vacha Bhavsar To: qemu-devel@nongnu.org, vacha.bhavsar@oss.qualcomm.com Cc: Peter Maydell , qemu-arm@nongnu.org Subject: [PATCH v2 1/2] target/arm: Fix big-endian handling of NEON gdb remote debugging Date: Tue, 22 Jul 2025 17:37:35 +0000 Message-Id: <20250722173736.2332529-2-vacha.bhavsar@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250722173736.2332529-1-vacha.bhavsar@oss.qualcomm.com> References: <20250722173736.2332529-1-vacha.bhavsar@oss.qualcomm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: hsEKs3qYlQlJWYlFz5wmBEK1uglTYwhg X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzIyMDE0OCBTYWx0ZWRfXwVEtbnu2w9OF MA7aUjTdTbYZ5+MYM5jDStQFG4ToiW1R7vt+MjeXc6rXdCu+oYz7YLTVBX+EZ3OcK4qXjkLTKZ5 ttnG+c1d8vh8miQ44dTOdcDQfxGqlpOaXgeM8VTG6CxY49hA9PJ1GD3JMLRxXOeFIUmbNkU2szt Pj5IdsJ9xE5FLQ70UX6Cg2E1hDRfDvebEoxbRLm/j8P3fscuK0CPUxSgCWdg3unh0VLtfVnjDKa 7OkjrykdcCXUeOU5onkCf94BY4EAqU+Y1YKZCIrz7bREdRMwshgPbkNarSUNN9F0pLKVXiLa+Gv N2N7fZ5tOxfQpn6vLvryxnYN0NGryOz/ClnglMowDs+xR6PuIYp0iQhQBqKfx+nFHGCgfXx8QU7 Gh//it0io1LiHgIs6BMDubQL06OiXmYtMgWHyiuiBGZvLXKVlsMNVpuxdVbx6H79TtBUnX3U X-Authority-Analysis: v=2.4 cv=E8/Npbdl c=1 sm=1 tr=0 ts=687fcc64 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=Wb1JkmetP80A:10 a=EUspDBNiAAAA:8 a=mos1SNEY7zeSx4t9hPcA:9 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-ORIG-GUID: hsEKs3qYlQlJWYlFz5wmBEK1uglTYwhg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-07-22_02,2025-07-21_02,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 suspectscore=0 clxscore=1015 phishscore=0 mlxlogscore=817 mlxscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507220148 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=vacha.bhavsar@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1753207311779116600 Content-Type: text/plain; charset="utf-8" This patch adds big endian support for NEON GDB remote debugging. It replaces the use of ldq_le_p() with the use of ldq_p(). Additionally, it checks the target endianness to ensure the most significant bits are always in second element. Signed-off-by: Vacha Bhavsar --- Changes since v1: - corrected styling error in if-else block - corrected commit message to no longer refer to patch "series" notion target/arm/gdbstub64.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/target/arm/gdbstub64.c b/target/arm/gdbstub64.c index 64ee9b3b56..c9d8012907 100644 --- a/target/arm/gdbstub64.c +++ b/target/arm/gdbstub64.c @@ -115,8 +115,15 @@ int aarch64_gdb_set_fpu_reg(CPUState *cs, uint8_t *buf= , int reg) /* 128 bit FP register */ { uint64_t *q =3D aa64_vfp_qreg(env, reg); - q[0] =3D ldq_le_p(buf); - q[1] =3D ldq_le_p(buf + 8); + + if (target_big_endian()){ + q[1] =3D ldq_p(buf); + q[0] =3D ldq_p(buf + 8); + } else{ + q[0] =3D ldq_p(buf); + q[1] =3D ldq_p(buf + 8); + } + return 16; } case 32: --=20 2.34.1 From nobody Sat Nov 15 09:11:53 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1753207159; cv=none; d=zohomail.com; s=zohoarc; b=RVxx/g9ROA4bZ9Z9EbiCbQYP4RzPVJPzSh/u+GHBYoHMHsA/P27kf+zPYOiQr/nQalAeF8lxIMsLnzyRGeVp6hbmwOE1PvrZh425CEOHBVdCtZiTXGtukRCCKHYWONihZ0CCqmrSs04m2oCQOBFcJY+ZYjL9MEzwKCzB4svzKso= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753207159; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=obCClsJcQMc052y7t2akKepUi0DGGNqD8BY6lnSGTo4=; b=Wgd9FXDQQBh1CjLmiVviEd0iSwUR7ANCvB8B2YatBLaYrQvp0ex0YxIYJF0AP8e7Z87NpG1TBt/j14PUyqHHO1DQ3cN8w8w1Fwsf/xEyhmpH4bN3QxTL5WUESdIMqoVS5hp7tIQXCrmrvp5T05I9kK5nKliDFiX9J9p5YRnQwjc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1753207159152497.168834259899; Tue, 22 Jul 2025 10:59:19 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ueHFc-00044s-OW; Tue, 22 Jul 2025 13:58:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ueGw0-0000Lq-4t for qemu-devel@nongnu.org; Tue, 22 Jul 2025 13:37:48 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ueGvy-0000AW-P4 for qemu-devel@nongnu.org; Tue, 22 Jul 2025 13:37:47 -0400 Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56MGhdg2012558 for ; Tue, 22 Jul 2025 17:37:46 GMT Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 481qh6mnab-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 22 Jul 2025 17:37:45 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-3132c8437ffso9883250a91.1 for ; Tue, 22 Jul 2025 10:37:45 -0700 (PDT) Received: from admin15.qualcomm.com (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-31cb5c5da0csm10081180a91.25.2025.07.22.10.37.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Jul 2025 10:37:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=obCClsJcQMc 052y7t2akKepUi0DGGNqD8BY6lnSGTo4=; b=cmH3rjw/HL32ef0orVUn42DkGAW RGvvmqQ++ZJ4FnoCYNbu39SIoZcXsDDfHwIRaGBv+iYyHMKq0qs+OT83hgwmqV+t g+YcDInE9/TwL2G1os53YFswWEatzSejza/2/e+goLl8fPvbAs2zb4Y5uV2OqANi xlRjeUfFtPlo8LfWGuvuYlccrI8DNGaBHOfzgsxEFodZ0WQUrAQyezSl0yvFv7/Z tbbNsm7N/fDcKA/M3yBjISo7RGG/zXg58FOENtVo6PLjhrWcBSkLTa3C+mVZYbJi riKNGUHOe7Z96861yF8vZ6LpoxsaCQca0RK3qt9N/AcuiD4wRaGd7WLxdRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753205860; x=1753810660; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=obCClsJcQMc052y7t2akKepUi0DGGNqD8BY6lnSGTo4=; b=dFdTbqGhxAc/mjBRaX6y/nbG6A1T2MenKq7dEwzxp72DqOQAIoLgnP6qNhMjpy7fz2 6nki2JhqsML7o5P8n9AjBL4pjlU07XBug/IagWhznIpDzbNZj5nX9GfE02jh+Ma/HJif kYloqBeqdHTKbfBuxezbVmOSFVwhszrQdrHplYZ+ZMCoyzVQsrXqG4hTYQEewXt/opWk VsgIHzHzUZt0IRELpU9biMfpHxMozXtm9vNClTJXb4Ylk61pZBWuCY844+WLvQ7Anbe+ G7LLCGVrvg388nPABk/vcEe7AL/ITRwnaLjROHn4TqhAxlFlDiXWkS5ZxLQjk87OhfRm JSPg== X-Gm-Message-State: AOJu0Yz5PNzY163JfbzYTiR7o55DXLB7/y8Tgpykn7ffm8vWYkSWp+9N GSg6sI1b2n/luIN0Y9ugAAcIo4VtEj8LOlPq6c18Q9cCYznH5E0cO6N7Pnfd+rYFof+cKkheQuz OVb2UkP78BRDPhTZ5c6iU/nh3sfZEbeFqo+fjs+5unKqiAkUvyTCZ6DbN9cG9C3aN4WyE X-Gm-Gg: ASbGncsMm3BGuRaaqVdJd1zi4TtiL1gGyoTsnttRU7CJEBlZnxnMBvU5nC1G+BLtFkk oh6Cwxhpb+IS8Cm0j5RCiJ3RqCLLq1A+XB0rsSQTM+oaTQ7/JzY+NKtn0yvJyXAo268F1y2ghvV r80AIYgBrRMPAViGRSDjznXab/fbmPsY11Te3TufK0nslbyIv4S0A7KIBIiVrY8NsBio8f2tKXk utqVvVxtJ//SCoZ/vjBlJ41CvUUbXLknUxHkVIIAs9q0xw8lq7trdItfOjW/B6scovD4vPlWkCj hvMo5j+sOA//eZ/+cMg5azg3GlGpbGxuNOHVSLvhoiCpMEviPRN15jq4rpZZI2pBLXsy8qZGsTr AUG+YcK1inwVU39M= X-Received: by 2002:a17:90b:2885:b0:311:f99e:7f4b with SMTP id 98e67ed59e1d1-31e507ce490mr148985a91.28.1753205860297; Tue, 22 Jul 2025 10:37:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGYlm3VuL+wL06ZHfokI+fHHJVWcmjTlW2ak3xoOyfjkiYsf5LiO6T2WZWxFTbVtcu2uGFcBA== X-Received: by 2002:a17:90b:2885:b0:311:f99e:7f4b with SMTP id 98e67ed59e1d1-31e507ce490mr148957a91.28.1753205859836; Tue, 22 Jul 2025 10:37:39 -0700 (PDT) From: Vacha Bhavsar To: qemu-devel@nongnu.org, vacha.bhavsar@oss.qualcomm.com Cc: Peter Maydell , qemu-arm@nongnu.org Subject: [PATCH v2 2/2] target/arm: Fix big-endian handling of SVE gdb remote debugging Date: Tue, 22 Jul 2025 17:37:36 +0000 Message-Id: <20250722173736.2332529-3-vacha.bhavsar@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250722173736.2332529-1-vacha.bhavsar@oss.qualcomm.com> References: <20250722173736.2332529-1-vacha.bhavsar@oss.qualcomm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=CZ4I5Krl c=1 sm=1 tr=0 ts=687fcc69 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=Wb1JkmetP80A:10 a=EUspDBNiAAAA:8 a=zyzssM-dKFwhFTZ1wpsA:9 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-ORIG-GUID: s9fErqjdfywSAnFdWIkuRZNlJqQUNbZB X-Proofpoint-GUID: s9fErqjdfywSAnFdWIkuRZNlJqQUNbZB X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzIyMDE0OSBTYWx0ZWRfX1hH1O32a93JS W49TVCA85lp6jj90+ji0BkFmo+7oz8XkLUJ6HrFFpekrqPXgmC93iXoIHWOz8s7YxTR6HzvVuIo oaGlUvCCquLmwHUJxW+e/TtuWrQoS8AO4ZLU8/o0mll5yRT2Mz6S0DdrfYCWJvJj7p5BfbFkYrX r4a9GPGLbdD8ygYWsXuo0ipU4V1XnxVD44zmHGPHrMhUn+AvXyxjyj1rjRvAQLVM6a+CiXp0gLP 1L6qfA0s8uQCE4b7G6NbrWV2N4Ta0IYejneueyoJutvbNpkunFpq1JwP4QtPHmMZS5A0Mz/AByk aG8XMtVYsTTPCcd2Q1hQ6LmxQolGw61CJ5ce/bVrhichGkq5y93rBtAgzzIIsbBVjFmvwwn2dYU lnjAvWXocMXlRJR33Zyh8PU4fwINNkiR0g97t2iFV2hOT9IWJ/HbkLNWb/ILnZB5zlFLv7FQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-07-22_02,2025-07-21_02,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 mlxlogscore=718 impostorscore=0 clxscore=1015 mlxscore=0 lowpriorityscore=0 phishscore=0 adultscore=0 bulkscore=0 spamscore=0 malwarescore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507220149 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=vacha.bhavsar@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1753207160079116600 Content-Type: text/plain; charset="utf-8" This patch adds big endian support for SVE GDB remote debugging. It replaces the use of pointer dereferencing with the use of ldq_p(). Additionally, it checks the target endianness to ensure the most significant bits are always in second element. Signed-off-by: Vacha Bhavsar --- Changes since v1: - corrected styling error in if-else block - correct commit message to no longer refer to patch "series" notion target/arm/gdbstub64.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/target/arm/gdbstub64.c b/target/arm/gdbstub64.c index c9d8012907..f276522af7 100644 --- a/target/arm/gdbstub64.c +++ b/target/arm/gdbstub64.c @@ -199,10 +199,17 @@ int aarch64_gdb_set_sve_reg(CPUState *cs, uint8_t *bu= f, int reg) case 0 ... 31: { int vq, len =3D 0; - uint64_t *p =3D (uint64_t *) buf; for (vq =3D 0; vq < cpu->sve_max_vq; vq++) { - env->vfp.zregs[reg].d[vq * 2 + 1] =3D *p++; - env->vfp.zregs[reg].d[vq * 2] =3D *p++; + if (target_big_endian()){ + env->vfp.zregs[reg].d[vq * 2 + 1] =3D ldq_p(buf); + buf +=3D 8; + env->vfp.zregs[reg].d[vq * 2] =3D ldq_p(buf); + } else{ + env->vfp.zregs[reg].d[vq * 2] =3D ldq_p(buf); + buf +=3D 8; + env->vfp.zregs[reg].d[vq * 2 + 1] =3D ldq_p(buf); + } + buf +=3D 8; len +=3D 16; } return len; @@ -217,9 +224,9 @@ int aarch64_gdb_set_sve_reg(CPUState *cs, uint8_t *buf,= int reg) { int preg =3D reg - 34; int vq, len =3D 0; - uint64_t *p =3D (uint64_t *) buf; for (vq =3D 0; vq < cpu->sve_max_vq; vq =3D vq + 4) { - env->vfp.pregs[preg].p[vq / 4] =3D *p++; + env->vfp.pregs[preg].p[vq/4] =3D ldq_p(buf); + buf +=3D 8; len +=3D 8; } return len; --=20 2.34.1