From nobody Sat Nov 15 10:39:15 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1753077728; cv=none; d=zohomail.com; s=zohoarc; b=VkvPXr9jsWwk6TkG0EOzlKXA//DQ9RDMROE2yDEDA33UQKHEAZJ6isdcyGa36/XXe1R/Q/TcYXHdxtq0ghkDyE9pnCazBxNY5zARPlvPkhbnN77EpZ0eAEOIQzpR7A+oVWVBW/9mlvHgxjkC6zMAgLOAOtQX+nYisbIt7jw5vFY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753077728; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=IDF+JFdowBa/PmuJ6B7AgL6OhHfe1s9R8UQbM+M3o5c=; b=EZedCfUcR8I7R5L7ANCXwqnnF9VSe2qx0mxNHySq4+wOFVQ41bKcqA0lS0bXcWmz6ibhnHG/N29AXKpWWVkAYoob5+xCUlEBKxiOi+ZyM12m6U94m/LMnyUY77yMBnnjK1R+3yzBNxCg6mutFvAaj0rhEWWApyP/e3txxvwIFeI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1753077728395403.08095804624884; Sun, 20 Jul 2025 23:02:08 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1udjb3-0000TZ-1F; Mon, 21 Jul 2025 02:01:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1udjZP-0008MK-BY for qemu-devel@nongnu.org; Mon, 21 Jul 2025 02:00:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1udjZL-0006Mx-Qi for qemu-devel@nongnu.org; Mon, 21 Jul 2025 02:00:13 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-251-AtgnmKqzNa-THtUEosUU0w-1; Mon, 21 Jul 2025 02:00:08 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B98DE1800C38; Mon, 21 Jul 2025 06:00:07 +0000 (UTC) Received: from localhost.localdomain (unknown [10.72.112.190]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5EF7419560AD; Mon, 21 Jul 2025 06:00:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1753077611; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IDF+JFdowBa/PmuJ6B7AgL6OhHfe1s9R8UQbM+M3o5c=; b=D5x1rUhcVbnGq0Tsji20nP/LFsW1gyFlcwkjZIG9q234OOx5ONxzZXWwoxLS2XLbeVJh7z mADDhz3vwtWjWozpWHYuIgrjTVvCSq5hc1/93VZa79UM1Anzu2BlThzoiQ8EroGeNlwka4 jjVS9GVChljHqsoIaQ4g4GUVJfzpqGc= X-MC-Unique: AtgnmKqzNa-THtUEosUU0w-1 X-Mimecast-MFC-AGG-ID: AtgnmKqzNa-THtUEosUU0w_1753077607 From: Jason Wang To: qemu-devel@nongnu.org Cc: Laurent Vivier , Peter Maydell , Jason Wang Subject: [PULL 11/12] net/passt: Initialize "error" variable in net_passt_send() (CID 1612368) Date: Mon, 21 Jul 2025 13:59:26 +0800 Message-ID: <20250721055927.75951-12-jasowang@redhat.com> In-Reply-To: <20250721055927.75951-1-jasowang@redhat.com> References: <20250721055927.75951-1-jasowang@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=jasowang@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.088, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1753077729260116600 Content-Type: text/plain; charset="utf-8" From: Laurent Vivier This was flagged by Coverity as a memory illegal access. Initialize the pointer to NULL at declaration. Signed-off-by: Laurent Vivier Reviewed-by: Peter Maydell Signed-off-by: Jason Wang --- net/passt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/passt.c b/net/passt.c index 43c336e596..32ecffb763 100644 --- a/net/passt.c +++ b/net/passt.c @@ -124,7 +124,7 @@ static gboolean net_passt_send(QIOChannel *ioc, GIOCond= ition condition, { if (net_stream_data_send(ioc, condition, data) =3D=3D G_SOURCE_REMOVE)= { NetPasstState *s =3D DO_UPCAST(NetPasstState, data, data); - Error *error; + Error *error =3D NULL; =20 /* we need to restart passt */ kill(s->pid, SIGTERM); --=20 2.42.0