From nobody Sat Nov 15 11:33:47 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1752860693; cv=none; d=zohomail.com; s=zohoarc; b=bt33peObB6zHlSp9BPAKGfIeMMK1zlpauOYHcSD7dbsIYZ6AhKnCQ+GbpUkxkVon5l6YfDXvw2m+4wnS+6gEfSwVZO+Ui4yzBLKRxiEoZrCxX1KEMb1U+8Rxieef5t2KwXX6SmdQCHvjeB+rdSTrX5+Rvz90/IE5JtiWya5rXQE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752860693; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=VTq6sdILRqpJUa4aACdnr1dXTMtMDz2K4P9Jj5bpG7E=; b=FErtImtIobJDtw+gPXNUs/Vv0fdu2Cl6UbJgdxjIclOm82nImXnqEuYlvcunIMJ1ywVYfYa/8KleDs7XnjsmYdBpqRBA4wnfAa7HS0cXrZm0uTxDC+MaMAQ3YbmApPJrIIoTP4ds9wzMUPYoTRFFm0OtOz2F7omPnTXU5vz5yrs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752860693296576.1869569445955; Fri, 18 Jul 2025 10:44:53 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ucp89-000867-Us; Fri, 18 Jul 2025 13:44:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ucov3-00055z-Uq for qemu-devel@nongnu.org; Fri, 18 Jul 2025 13:30:52 -0400 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ucov0-0000sa-Nt for qemu-devel@nongnu.org; Fri, 18 Jul 2025 13:30:49 -0400 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-451d54214adso17179825e9.3 for ; Fri, 18 Jul 2025 10:30:46 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b61ca25443sm2454655f8f.9.2025.07.18.10.30.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Jul 2025 10:30:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1752859845; x=1753464645; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VTq6sdILRqpJUa4aACdnr1dXTMtMDz2K4P9Jj5bpG7E=; b=Cr1rBjbQOPdd0iMcCKRN8oEZlarmlzn7k232BHijLQBlBsBpTUdjMZjNkQy7F3TPbN Qs2vVNmaBcjJNO1Go+tUZwwy5m7c725j3rHb0Bof3oO+d119QECTCBh6ecfvDg2/unBe GA9kLqqktK7h2EEmwxpwWEht1sKk6K528Q7oAm1L/78KvqUBpNLwBQZHXm48Xp+IlTEN EmhrSKZU/v+bVI5qGvVopxXpsPdcLOBk47ahikYh9Q3W6QiRmrjNDVofdryD5sFDQv+l IC3NDq1Jxz5dvjDmNpUd4lt0earNkwfvcRZxyCHbFs2zYCFFZj9plB1hMN+ASZJ9TpuD o8HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752859845; x=1753464645; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VTq6sdILRqpJUa4aACdnr1dXTMtMDz2K4P9Jj5bpG7E=; b=YlnieUhdDGCheW1jy/s1AEb8YEWpAS8PCRzdC3jhQkoK/aXCuScDl+FxO/+MkVD/cL EWB5flvhhugKtGr14uFGThIOCScdazJjYWi1j2yzQPPo+4RkBIRyf2994iQDHZ4PS3E+ Dv+1FVkrIVun0RvKV+RT1i/9zrbOF2ZWFmteHjyT5ZmnVSv0mRpP7CnfScjY/RCH2zUj tClpyIXqt8XC16rS2hTka3F3uVkaHlAN5Kaoe2D3ebbk0jg2PEst9e+eeWq9NM7+rKSZ rKP372X+TZPdQUAc5Ybq4cZTGFu0yhiGej8RBlDkQVR5f2j8bhyxMvnkSo6Cv4kS1Btt qHFA== X-Forwarded-Encrypted: i=1; AJvYcCUjf4k+UmfV53tNkOZricLMz+lvChWoBruQwbLZf3IeFZa+nbIE5Z8Y96Ymp00UxsJzuUZ/JJcSPdsX@nongnu.org X-Gm-Message-State: AOJu0YwT00u5YxIN4kVfkkucVkSBvEYDFAx8dU45wQVYbzN9s722XgD7 JB9AcDowA4SK0i5EjnJrIyvIB25VS0Yp0rznMvgtYR0gH4Sbn0xgpVGMPAKV58cFz38HsTuM50s lyZZd X-Gm-Gg: ASbGncvsUcPx3ffRbxFiOqWFinpKdr6nhCDjl0MiezPVbQu2CoNyQp4DJmz7MzmGNjD jCCdqMFvKK0Imw9sHC2/zoJiQvSeCL9tJL+4uwKUB5NwPqFItm+gg6IZgk2oQgkBeWrTV69ptpF UYnuGxCPZZj5FSqngK+X/eB3SP8O0/Dew9wEX0FXcEhaY6CqSsIuMsRvSUb5vhpK2bKv/c82t11 abLiIcOlZvMwX2GqHt3J0imgCDE6V4K4hsW+FTiIljfLIMbyRzJAyksxC06SeH1Tt4g3ujvnec6 7ZLg+AGPDYM4dL8tAGJ1pbEaFN7EXrpDUn5GqWXTk6W7ksrGSf781PZg/nNMhHlzKIBVJ55myDU g71N196o7lb/KDKKA+WZvaHlp5pA2EzhwfmybzMQ= X-Google-Smtp-Source: AGHT+IFgt7aZDHGjiKQDQO1pSNy326DvR33iyVj7kf8kRYd06fhb2TFbEm0B9AIQoF6bRuk1daRsSA== X-Received: by 2002:a05:6000:230b:b0:3b6:333:256f with SMTP id ffacd0b85a97d-3b613eb49f0mr6272738f8f.58.1752859844744; Fri, 18 Jul 2025 10:30:44 -0700 (PDT) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Richard Henderson Subject: [PATCH for-10.1 08/10] target/arm: Don't nest H() macro calls in SVE DO_REDUCE Date: Fri, 18 Jul 2025 18:30:30 +0100 Message-ID: <20250718173032.2498900-9-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250718173032.2498900-1-peter.maydell@linaro.org> References: <20250718173032.2498900-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1752860694727116600 Content-Type: text/plain; charset="utf-8" In the part of the SVE DO_REDUCE macro used by the SVE2p1 FMAXQV, FMINQV, etc insns, we incorrectly applied the H() macro twice when calculating an offset to add to the vn pointer. This has no effect on little-endian hosts but on big-endian hosts the two invocations will cancel each other out and we will access the wrong part of the array. The "s * 16" part of the expression is already aligned, so we only need to use the H macro on the "e". Correct the macro usage. Fixes: 1de7ecfc12d05 ("target/arm: Implement FADDQV, F{MIN, MAX}{NM}QV for = SVE2p1") Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- target/arm/tcg/sve_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/tcg/sve_helper.c b/target/arm/tcg/sve_helper.c index 105cc5dd122..bf894f0bf13 100644 --- a/target/arm/tcg/sve_helper.c +++ b/target/arm/tcg/sve_helper.c @@ -4509,7 +4509,7 @@ void helper_sve2p1_##NAME##qv_##SUF(void *vd, void *v= n, void *vg, \ TYPE data[ARM_MAX_VQ]; \ for (unsigned s =3D 0; s < segments; s++) { \ uint16_t pg =3D *(uint16_t *)(vg + H1_2(s * 2)); \ - TYPE nn =3D *(TYPE *)(vn + H(s * 16 + H(e))); \ + TYPE nn =3D *(TYPE *)(vn + (s * 16 + H(e))); \ data[s] =3D (pg >> e) & 1 ? nn : IDENT; \ } \ *(TYPE *)(vd + H(e)) =3D FUNC##_reduce(data, status, segments); \ --=20 2.43.0