From nobody Sat Nov 15 11:33:48 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1752860314; cv=none; d=zohomail.com; s=zohoarc; b=LZ5/ZMi9xGhFcdyuYYzuGRavdMvUoaLi6fbQGOUPrF9PCtPyem5RsYOSWueU3pwTmw6rVO7nwnEHlQyMjjZbNj5+PfgVktAq/F4Dj/ZfELIUSIR8jFbM/WWuTuLXJ1mXGJm+hB9i2N+QgD6cVpbmmhotMttdFZ8naxRxyKcVBzs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752860314; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=XvEZoZH3mUSnAV2VTJKTR+Ia4eaH8LTVsbCwMx9JGI4=; b=JHGompUDThVB4zgmwRgp9tRGMBhu5AcEpxLnfGb65+QpHCskKkphBro9Lcg+zlgVnoJbtqgNrZfheKztujRH17FAReMf5k/e7cKJOgGUWXmxPWTPVaFPh6WT7KZQlvH15K4OeToMRUvJuN7hfuj9dUClFHNFpO7j9gC/V0xwJbQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 175286031453034.66690363074542; Fri, 18 Jul 2025 10:38:34 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ucp1x-0001wX-Gd; Fri, 18 Jul 2025 13:37:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ucov3-00055a-An for qemu-devel@nongnu.org; Fri, 18 Jul 2025 13:30:51 -0400 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ucouz-0000s8-Pv for qemu-devel@nongnu.org; Fri, 18 Jul 2025 13:30:48 -0400 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-45619d70c72so27916785e9.0 for ; Fri, 18 Jul 2025 10:30:45 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b61ca25443sm2454655f8f.9.2025.07.18.10.30.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Jul 2025 10:30:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1752859844; x=1753464644; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XvEZoZH3mUSnAV2VTJKTR+Ia4eaH8LTVsbCwMx9JGI4=; b=dOFS40arjTd82yGeo/6/JZeJh8EtxaQ3O+PQu8GCP9We7ZQLMSe65/svq0PzjwdRgA cgDTpmj7xEF3YwT3SLemPul9AtqCoQ+pR0vedc8l4qr2GxhtnQvkl3gXmMuFzq3+e/PM BgMwh/vwnhwIFFdJbWY2FLz8ELccxJjA50DlWjtKQGm8aGkYHBS+b6NDT8nWnm1ujslp QcfAM6y0bcVawBQDDynGbPBjeRM4/Tv1SVWWDLZRt5UF+fipOg+Y1Ij2qvNV+i0r7DaL rlOLhkOPR4Wj6yFtut1Jt3WtfjROhfPt5LD6TiDGRt3jkIMN6R7AXFSeaEsH4scG9ZFL FXew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752859844; x=1753464644; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XvEZoZH3mUSnAV2VTJKTR+Ia4eaH8LTVsbCwMx9JGI4=; b=I78lVfXnq6FptUPyfp/vRVVyOceCNw/fAwVDVYlqAHa3cYVxsi0hnichqamjJ27nwA 36N8byRVBeIN8nIhtOPDjHbb/CQcusen2WYJ/eH1VM6PziPgWqavoI6O4drNC5LfUbZf KpVhGwwm/o32X5xiBtL9L7ZgmJuLSnVaEFzuGpouI0nm2DqasxfNW/b97q6QOLlWdXNb bwN9NH/UUSIJxBTLUXc18Yrq43ckwp9aOh3dnIUi9BPb58BbSqNrf2/21Z/YKNhYD+En Vkip9RCvtWNov/g7aryFafmrHR4rjnzwWgsoCgiQRMJMZbbFYjBoHmKDiGB1+wRZTqnv uMig== X-Forwarded-Encrypted: i=1; AJvYcCXK4mTfUb8fTurkakt2EWkRFrbQ8QR9AkZO2ucS+UuFfizwC/Oju33MI3ZKzPK/RWqIKzu2FPZPxnNC@nongnu.org X-Gm-Message-State: AOJu0Ywex/8q4bPpQ1ErCO7lMY+k4UGQnQOqIM3DqK55houdRplRQgHZ IVkzQIdZQgWG4aCFw7IA07EWLQcGI3dwIPQyZZfkDLm6ikOEOqY1lNIvAdR25LZhBYbNVQC2ym3 mlMDp X-Gm-Gg: ASbGncujdrKv+dcc9RCHcDqC2K2KrUiRxn2Y8ybDgtJ/o1l6XBV1zozKNpe5GYZHY+L sXIHAnKP27B0IAqpNCBAtlP/KhjOOqkKVWxEEZhAw7ss6ELVMxEOzRIrZAfn8MBVNVHAzbgK3t5 6ZgDDkHMCg+9/LtctTyFgo1V213ZVsewkZ4zJZwIVcopPul1FFPSeffdKqqvdkP5hzyqg0sA/aK 3NkYa1Ia0FGTq+Z3CWrigoTySFm4k7J+EonDp6LEfTVF74RN1q30xDVc8ppF0onXdlNtqWszhgl WN0NfLIx0AE1txaDwv5NDDYZGWoaBX5aXH0pnSOWSpCw4Xrm33jmVvZ9AX2cXj6aLCJEewSSzHI 30FPKgvL8azA6CUShwDbUXLFzduS6fvXROrtwCXk= X-Google-Smtp-Source: AGHT+IFrnkwHPbSooHVEXVPASDSTgFr48II+Atg7XpMzelaM+pU51pxQrmZcUuFUHaUMFnjvgtSzvQ== X-Received: by 2002:a5d:5f47:0:b0:3a5:7895:7f6b with SMTP id ffacd0b85a97d-3b613ab26f5mr7415234f8f.7.1752859843644; Fri, 18 Jul 2025 10:30:43 -0700 (PDT) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Richard Henderson Subject: [PATCH for-10.1 07/10] target/arm: Correct sense of FPCR.AH test for FMAXQV and FMINQV Date: Fri, 18 Jul 2025 18:30:29 +0100 Message-ID: <20250718173032.2498900-8-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250718173032.2498900-1-peter.maydell@linaro.org> References: <20250718173032.2498900-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1752860316826116600 Content-Type: text/plain; charset="utf-8" When we implemented the FMAXQV and FMINQV insns we accidentally inverted the sense of the FPCR.AH test, so we gave the AH=3D1 behaviour when FPCR.AH was zero, and vice-versa. (The difference is limited to hadling of negative zero and NaN inputs.) Fixes: 1de7ecfc12d05 ("target/arm: Implement FADDQV, F{MIN, MAX}{NM}QV for = SVE2p1") Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/arm/tcg/translate-sve.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/arm/tcg/translate-sve.c b/target/arm/tcg/translate-sve.c index fc76624b5a1..2ed440aff15 100644 --- a/target/arm/tcg/translate-sve.c +++ b/target/arm/tcg/translate-sve.c @@ -4020,7 +4020,7 @@ static gen_helper_gvec_3_ptr * const fmaxqv_ah_fns[4]= =3D { gen_helper_sve2p1_ah_fmaxqv_s, gen_helper_sve2p1_ah_fmaxqv_d, }; TRANS_FEAT(FMAXQV, aa64_sme2p1_or_sve2p1, gen_gvec_fpst_arg_zpz, - (s->fpcr_ah ? fmaxqv_fns : fmaxqv_ah_fns)[a->esz], a, 0, + (s->fpcr_ah ? fmaxqv_ah_fns : fmaxqv_fns)[a->esz], a, 0, a->esz =3D=3D MO_16 ? FPST_A64_F16 : FPST_A64) =20 static gen_helper_gvec_3_ptr * const fminqv_fns[4] =3D { @@ -4032,7 +4032,7 @@ static gen_helper_gvec_3_ptr * const fminqv_ah_fns[4]= =3D { gen_helper_sve2p1_ah_fminqv_s, gen_helper_sve2p1_ah_fminqv_d, }; TRANS_FEAT(FMINQV, aa64_sme2p1_or_sve2p1, gen_gvec_fpst_arg_zpz, - (s->fpcr_ah ? fminqv_fns : fminqv_ah_fns)[a->esz], a, 0, + (s->fpcr_ah ? fminqv_ah_fns : fminqv_fns)[a->esz], a, 0, a->esz =3D=3D MO_16 ? FPST_A64_F16 : FPST_A64) =20 /* --=20 2.43.0