From nobody Sat Nov 15 09:24:00 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1752858281; cv=none; d=zohomail.com; s=zohoarc; b=NIzLcEkvOHpvy9Ol9ZcEscDbAUxf4VLkV8aegkBqIRt1Ck/3TB/QpnkaTPo7PM/D0EB4gHZFN+5LOT+iVwkLmMS29QA+sFNL+R1qyKzxv4zzyjhsbC5V2wMUCBskHdVoFHtSADaofYOM69ufsWeMW4UvXS1nGQea0UwXV2/mOqk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752858281; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=d8kJDLuC+UaKMIjK/HRmpSPdwsiOoh88VgdFCc0iMko=; b=abI/F4f++fp+dGA0Fu9WlaRlvYmSLELpIGz3n/HQgPdT1XMcMdBsbuzE59lR1kgtGWt3sEGPBBl+GVtDfgCpWRwCdG5Tho7tFV0YOjWGHBOQ7ppEmDky8lHht3FeBN01aO+Zf9AYcI5Ia86YJc7dml3woxkIBO+A5pGbmbhl1pI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752858281066979.3800360834844; Fri, 18 Jul 2025 10:04:41 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ucoVJ-0005Zu-Oc; Fri, 18 Jul 2025 13:04:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ucnt5-0007hS-Sg; Fri, 18 Jul 2025 12:24:43 -0400 Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ucnt2-00072R-MM; Fri, 18 Jul 2025 12:24:43 -0400 Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-5561c20e2d5so2972472e87.0; Fri, 18 Jul 2025 09:24:36 -0700 (PDT) Received: from localhost.localdomain (m91-129-102-83.cust.tele2.ee. [91.129.102.83]) by smtp.googlemail.com with ESMTPSA id 2adb3069b0e04-55a31dacd84sm310615e87.206.2025.07.18.09.24.33 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 18 Jul 2025 09:24:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752855875; x=1753460675; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=d8kJDLuC+UaKMIjK/HRmpSPdwsiOoh88VgdFCc0iMko=; b=iB+PD8GRkYhqXb9O2eXg+CEVokL4xtijvGdeAoqI9JCb507DKQTJ4k1OaTk5FqYgUJ P562DY+PKN5idvjTMVcmnZ4AW0oOC9R2fxG1q49QPpTaLmP2ShbPGaHuwF/mHiWY/yZM xVOInucAMqZWdB0nFUN5xostgRwSafT8rOrZwn76w8S42FagoOLmQPR1ABHS8KfGvHMI rvGHHBsHNwq2miFhOF3cXLvy+RlyUSkoHtRnsCYrKOyu8pciuweVhl9QMWavbUYhOyOh ZRBdyOi/lrvr9lj84GeiNtD9SOhK0rLj4goUIZ2cqT5oj8ifX9DA549IuOgrWtUbs4nI srtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752855875; x=1753460675; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d8kJDLuC+UaKMIjK/HRmpSPdwsiOoh88VgdFCc0iMko=; b=wtItX+xOEhBUBxS5M/mUct4ItGk1OXwJueWS+0pfmE0VJjstfxoFJOpVIt/oLmvdCt 5kCne6B3RViJNm6pW/oUk8K51hfacM3evoFyEZUfQRjcBPxHAUUN15JPKAoa5J7pV8o6 uVvstm3mRZiSI1IxPOCXGn8cIUn7kYOiJXr6yMKZF5r87G7qSZx6yLYKtOsI7Vt285Mr q+StqEZVSdGJOU/+tG9m76TthiUGkjJtQx+o3SpcvjCWv4yl8yPSfbXiHjJ6Jdx2gzwQ KvgcLqQEZLkJ713a3HByC2n/ZHN5rsqtcqjcZIGGpmEQ/YlWHn4fCbFQdtErv6l5Dt59 0pWg== X-Gm-Message-State: AOJu0YzRX7Od/5EcyX83/lOt0uOT+lFN/hIqFpYexutSJY8yH/hQTNsu VTaJ4SFiMP+6zMFh5krF1vjXKPkHYxREMB5ZuggANyVXQbnIpbnY6FYUrAScKMQZmI2Hkw== X-Gm-Gg: ASbGncshR6U4nz1Pp4AB/BkkU2D3htg5VPAdf2gedOmw9IxAQMJO8rp0IEdw8GPjrzM bGICVEM94h21kvu0yJBqo9er/42S/NOq0aQbAxZQ5FaOLvCMU3Brb5ZI3/5clTLCLMZ6aYh3LE3 AZxFtEN6+JFFX9Esnf+e2ElBxWMlCeJg0Mp0GeCe1Kr5oy9R5fgBTZPlb3jtM7HGFUWBAy+wkQo BCIv8kXA1S0Fd0C5d7jzIZqOw1R+hZrRPy1HtA7MbYER/evGPGh8bvbZoPGmxMqevSf6k98d2Uu 0hiS35F4hbvN5H96QGzl3uhgh11kSlG5fTJIrWM624cfBnCi02Y3fnA0iYtSeJUx4uAdJWqXVbU LuBaJO8p6OCe0QwmOQonJ7NHrypaFnRvJ9SZ1JXT4Fy5OdvzRlYObcdBP7yHJ3wHA5rPZh0Irq8 Zhw24iKlAbhzm5Ww== X-Google-Smtp-Source: AGHT+IENXYP1k/2GxplmkUb0rUBIwCEFpwx/rq0d8RZS6SPEvHiRAopRfMQ9+dhcX67N0jNSPLj0xQ== X-Received: by 2002:ac2:42cf:0:b0:553:d7f1:6297 with SMTP id 2adb3069b0e04-55a3188e89bmr747653e87.34.1752855874422; Fri, 18 Jul 2025 09:24:34 -0700 (PDT) From: Vadim Chichikalyuk To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Vadim Chichikalyuk , "Michael S. Tsirkin" , Igor Mammedov , Ani Sinha , Shannon Zhao , Peter Maydell Subject: [PATCH 1/4] hw: acpi: add support for SPCR revision 3 Date: Fri, 18 Jul 2025 19:20:42 +0300 Message-Id: <20250718162045.49012-2-chichikalyuk@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20250718162045.49012-1-chichikalyuk@gmail.com> References: <20250718162045.49012-1-chichikalyuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::12b; envelope-from=chichikalyuk@gmail.com; helo=mail-lf1-x12b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1752858283080116600 Content-Type: text/plain; charset="utf-8" The UART clock frequency field of the SPCR table was added in revision 3. Currently, build_spcr() treats revision 3 tables the same as revision 2 and only includes this field in revision 4 tables. Fix build_spcr() to include the clock frequency field in revision 3 tables. Per the specification, this is the only change between revisions 2 and 3. Signed-off-by: Vadim Chichikalyuk Reviewed-by: Jonathan Cameron --- hw/acpi/aml-build.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 1e685f982f..9855d5f053 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -2123,20 +2123,22 @@ void build_spcr(GArray *table_data, BIOSLinker *lin= ker, build_append_int_noprefix(table_data, f->pci_flags, 4); /* PCI Segment */ build_append_int_noprefix(table_data, f->pci_segment, 1); - if (rev < 4) { + if (rev < 3) { /* Reserved */ build_append_int_noprefix(table_data, 0, 4); } else { /* UartClkFreq */ build_append_int_noprefix(table_data, f->uart_clk_freq, 4); - /* PreciseBaudrate */ - build_append_int_noprefix(table_data, f->precise_baudrate, 4); - /* NameSpaceStringLength */ - build_append_int_noprefix(table_data, f->namespace_string_length, = 2); - /* NameSpaceStringOffset */ - build_append_int_noprefix(table_data, f->namespace_string_offset, = 2); - /* NamespaceString[] */ - g_array_append_vals(table_data, name, f->namespace_string_length); + if (rev >=3D 4) { + /* PreciseBaudrate */ + build_append_int_noprefix(table_data, f->precise_baudrate, 4); + /* NameSpaceStringLength */ + build_append_int_noprefix(table_data, f->namespace_string_leng= th, 2); + /* NameSpaceStringOffset */ + build_append_int_noprefix(table_data, f->namespace_string_offs= et, 2); + /* NamespaceString[] */ + g_array_append_vals(table_data, name, f->namespace_string_leng= th); + } } acpi_table_end(linker, &table); } --=20 2.39.5 (Apple Git-154) From nobody Sat Nov 15 09:24:00 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1752858032; cv=none; d=zohomail.com; s=zohoarc; b=VuvevKWf4Z0rL/qf9n0LMocVASuUitK5jUyMUqGvMwmm5ruQasuIzWqn9Ku+sVGU1FvQxZiZWBLhmtTv0nF7/jY4qsRu1ty91aD1YDq6GCxx85Za8V9BaSn8L2PfZIPj5BFMuPDCJACrYG8t4o79VyMYJRKxxDMfb1j92dxmJlM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752858032; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=4fvsdLfmb83aU2Sh4Qg/fqQwyzBBdQVHUoJEX1nqKVw=; b=nk3ZqEfMCBwHbGrT8xYbMw4VSe5CS1d+lfczNDRpxTgqmhCcyTxi7ZvsnKetGszstVvuX+jH/A4REWG5VqDlc9BSp0p93ecCmTDjtWP+3TKKzWH+UkGfZtNhAZdwHdzIwYVdMjfUdA5TiI0kipFBbDYPRW3TK+BTnJ9aUQJFzbg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 175285803242131.680269679912044; Fri, 18 Jul 2025 10:00:32 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ucoR5-0007kR-P5; Fri, 18 Jul 2025 12:59:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ucnt4-0007fb-I3; Fri, 18 Jul 2025 12:24:42 -0400 Received: from mail-lf1-x131.google.com ([2a00:1450:4864:20::131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ucnt2-00076F-ML; Fri, 18 Jul 2025 12:24:42 -0400 Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-55516abe02cso2326558e87.0; Fri, 18 Jul 2025 09:24:38 -0700 (PDT) Received: from localhost.localdomain (m91-129-102-83.cust.tele2.ee. [91.129.102.83]) by smtp.googlemail.com with ESMTPSA id 2adb3069b0e04-55a31dacd84sm310615e87.206.2025.07.18.09.24.35 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 18 Jul 2025 09:24:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752855877; x=1753460677; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4fvsdLfmb83aU2Sh4Qg/fqQwyzBBdQVHUoJEX1nqKVw=; b=YnnL1y3gejWQiS6o71FCM0gHDhGJkh+Ur5xaVsGa5LNi3Ji9SXR5uUByeKi8tX9VwM 3d7jeJCjUyz4bWqLc+M61BoRtKdn5qDe1kbKbi/2v2ZhokBJ+o8xo3fCL0/lbdvY00h6 GlohuLJqPZTnng3hTcjNKoH2fIco+P3kZKuWckLs1Xp4wsrmtiakVd6gToH2Mj3Yc6yd D9XMHoDfkI8P2onh7qHeXeCEpxumcACOqTNoS8nQ2i6wJhYKlM36diOOugftRdQL25gr lu/J16M3J3cVBvXna0QNu0Je6Qvaed8ceXzBmxAENmZ1g7aPIiJrlaLM72O1ZEkhqZ9m 7TdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752855877; x=1753460677; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4fvsdLfmb83aU2Sh4Qg/fqQwyzBBdQVHUoJEX1nqKVw=; b=L7fyvTnqdWItUxTVT8LUb+Nh3iSV+1w+TUC6j6X8nl6TaAvfDb0uqUA2TELNk2tTut 7cNMJ1zNJ/1BirwLdglo0OVZIHdkU/bB3OZDW265sW28SxwV59QCnY0TZdlMVkI7A3K+ z8t2eds/e5o91h7MPHm/t6vL80WCi4iqL2OHv/5Oy/7aVhJnwfyTgDY0qpLWFI1dFKuO 3d1IKX8qrVV+Sbw3I/POTU/cAxz3cUp8vvMnHRkLbPE4I60/gE0+KHJOU7g5t98+QTcE QfNkyr1HXhTM7PCAFMMpLks5b4UQOqr2OcirPJhWB7iW1StPFFrllvif5NSAjz25KKQt G6pQ== X-Gm-Message-State: AOJu0YyM5eQM0MTsOJdt/1MZx5FCP3+EJCjjmgivnRggyTHpvb6QGwyT nIY15DRHHJzKgGYYgWl+RePL0iqreMdKr52wqYrA9DAKyjIbTWTj/5bVulF9ns8TGzafPA== X-Gm-Gg: ASbGncuynX9dHuumGk5m+M285u4Vs0XIYe8DY3Acy0sqQBLUH/atVfD5FUuOa4Uojnl HPJMtInMEuNtt424/I9L2ThGvuFYFxopNG8UvzTkccPFauuxxnRv94DZUK/ZMazDj9/XcaBCNZc YSGDoSo3uWiNCZYRkNrt7WksmVEXF2ixjp01E7HX+MSohrrlkfl5lG8WX/CTsJg6p2vh/9PpPRI DOU9DBWWwwGdwaiucwwMxHORbqHqlzxTrVuPkLJoXOoCSEYXBcrTDJljVbSZuysg0LCaG1m6Key RQ9A0YE3FBukGTOz+L63CC0SfGB9zb16HopocDkUxp6vBEUBNOWAc3nwvGagqTnD4h2l/mCrZX7 WlXW2A+k2q9UkirFjWqcRlIKGftR2H7l68lwWElP5tFZLfDNDStC2LRwNV9NHjpguvj0kaBvD2r ESHh6+AL7GXXK4oA== X-Google-Smtp-Source: AGHT+IGU25PLablMzKwTO5FI2bsrYyo8sQ1RpC8WQgSQV9PH00Xa2Pk8aLtDQR04n63VjmGRG3DrHQ== X-Received: by 2002:a05:6512:1296:b0:553:a294:3f8 with SMTP id 2adb3069b0e04-55a2fe38ecfmr1383553e87.14.1752855876964; Fri, 18 Jul 2025 09:24:36 -0700 (PDT) From: Vadim Chichikalyuk To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Vadim Chichikalyuk , "Michael S. Tsirkin" , Igor Mammedov , Ani Sinha , Shannon Zhao , Peter Maydell Subject: [PATCH 2/4] tests: acpi: whitelist expected blobs Date: Fri, 18 Jul 2025 19:20:43 +0300 Message-Id: <20250718162045.49012-3-chichikalyuk@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20250718162045.49012-1-chichikalyuk@gmail.com> References: <20250718162045.49012-1-chichikalyuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::131; envelope-from=chichikalyuk@gmail.com; helo=mail-lf1-x131.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1752858033919116600 Content-Type: text/plain; charset="utf-8" Signed-off-by: Vadim Chichikalyuk --- tests/qtest/bios-tables-test-allowed-diff.h | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios= -tables-test-allowed-diff.h index dfb8523c8b..2a30472d57 100644 --- a/tests/qtest/bios-tables-test-allowed-diff.h +++ b/tests/qtest/bios-tables-test-allowed-diff.h @@ -1 +1,2 @@ /* List of comma-separated changed AML files to ignore */ +"tests/data/acpi/aarch64/virt/SPCR", \ No newline at end of file --=20 2.39.5 (Apple Git-154) From nobody Sat Nov 15 09:24:00 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1752858080; cv=none; d=zohomail.com; s=zohoarc; b=V7dhsy9UMEA5E1kY7Xak7kALkIa9PrFKdCeA1JnWeWPYF3+2zcH3Rq21EaXQ8vMvI7JoOnf0fGAOF0Fn10WuxaymMbbGijMGiVDV6K3DUZexNv8U+bm8Qnlo+fmA0TgFROjjLp9h9nQQJZanc+sL1k5h57808eFDechLThTfC6s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752858080; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=TRHDBLUxey+b9W0XCfwAkBDbX0DcQai5/OanTm9BFeY=; b=WGXwj9VI51Ur4rjfulxIzQbp3IFh5qRncn77CK9xv1gToA3fL8IuT3XXQU5wcix4ZtBZVczKhT7WJnBt3CZA+B6rRjE+I3j2j6Tk7eAZuVNvmBl963udk9yOjlQeZZG9EjxXl5xWv6ndxWlbq4TL26clWuKxrGDo6Qg+LacYq6I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752858080626313.3001712085446; Fri, 18 Jul 2025 10:01:20 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ucoRy-0000Be-1f; Fri, 18 Jul 2025 13:00:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ucnt5-0007hU-Uv; Fri, 18 Jul 2025 12:24:43 -0400 Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ucnt4-00077N-0g; Fri, 18 Jul 2025 12:24:43 -0400 Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-55502821bd2so2861485e87.2; Fri, 18 Jul 2025 09:24:41 -0700 (PDT) Received: from localhost.localdomain (m91-129-102-83.cust.tele2.ee. [91.129.102.83]) by smtp.googlemail.com with ESMTPSA id 2adb3069b0e04-55a31dacd84sm310615e87.206.2025.07.18.09.24.37 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 18 Jul 2025 09:24:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752855879; x=1753460679; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TRHDBLUxey+b9W0XCfwAkBDbX0DcQai5/OanTm9BFeY=; b=Uy7cGeBYAvG36Yjll6+ZE6NJDChRIIGKvuz6jcWPi80DrM+zj+KZLb2hGxUoOnIDQ0 mPgQ77nXjRzw6j1ei3cVacqFXJlbU4Qog3LH4gkzN5DhnP+NEUTyZ+5EbpNY3fJ0ZvRu RFDF6M3WHs/FJhimNw82mhXtktFWzrAaUPMpTzRVpodlEsTiKPTORdQd3J7UuGR6yL2j Z9foMDvSZu9nwehjat9I9MFkkPd9uaBOOtoFhv1v9OaLLIx2sulMmRz3yJ6enwiloNHd 5ZaLXoRQFMBNzqxoVtOStoWzIWdNHbdQb5JdE9MNM+dFp94Pg5RhkcvrX1/t4h9Y5i5r FwkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752855879; x=1753460679; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TRHDBLUxey+b9W0XCfwAkBDbX0DcQai5/OanTm9BFeY=; b=TIkdyyo23A6MItPdhqNd6LnYpj9cZ49p/eh7oJwZtUGbbX/mW08P6Pf71hHQ/kewOF +fZkT2PQZAMChz9K7GPTpp2dW/jIyLTVYVB3b3EDJf4qxbY2ZTDkFQ3Z7555Gn3ttu+p Z8ONw9OGmq0GFePmKuGeOcGY/NXZohmrIpjFxYiLtoIatP8TgATn+w901nXhHmw0osfz SF6oYNLO5yNUwdQbyWI6vLuDyOQQz/WClrmPMr7xPGlAFZUHTTwAMuALKiyWwc6UP4/C biUXCXPVdLjbjbeS3VL+cWe+2O9rddzr4+DUZvJ+HqYrjgpa3LCpLt7vjvQNVHSYTmiC 9/bg== X-Gm-Message-State: AOJu0Yxuh/43hv1f7DMkAbdAcHSzZGOivYKg/UaL429LXlTvR+WltXqT 5h4OI8kDlF3Lv2H7mwFErNlVsz3nFWCCCixfHUIQE2LY03XnvKzPtofz0pOsMmahjD7zjA== X-Gm-Gg: ASbGncu7MWQ8LZ8S6n7lHov4qQYueJK96ho62rYhorBlw8bz+l9E+wfPsiIQTokPAbG SuPAT1j/PXdg43w0jZ8diU3NgBl5Zy0Zja7mNJQ4ymV6CUGFZXIRd+TRv+e4VnyNHMsJw75Sz5w UaVOL+CCljlFwR3JP5lQRpbB8F92IQDsZYSckSaIOzqFweNE94LPT35mPxaEFPk/WLmbHPsXSuE sbKbJTIoxRD+p4IMjjh73EXbOqAdrMXINUvR/Ly5Lg4bc2/my6bcJMJmKMZSYLGbBZYONn4nd+I SuGDnN/bYqlJXfQiOk7ez6IkwLj9Yi09w1IwE2+nGu5OYl38cQ3FmFTkoXw35bLHH7o6fzeG7Ca +oQxBcCmtHw56/Yp2ZEYT6l+pkgbe1LzyxTtzRPnqi9komIW44Yt49dBeoTMreMejnCj3Qx0lRI y1KnE= X-Google-Smtp-Source: AGHT+IEMj3QUFecwPdX0c/Ir5JNMOLt0+AlPfxRlTQdo9Bb7Igjad8o7Eus2XpVBkkf+d409iwhJhg== X-Received: by 2002:a05:6512:b17:b0:553:2bb2:789c with SMTP id 2adb3069b0e04-55a23f3f09dmr2616009e87.37.1752855879284; Fri, 18 Jul 2025 09:24:39 -0700 (PDT) From: Vadim Chichikalyuk To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Vadim Chichikalyuk , "Michael S. Tsirkin" , Igor Mammedov , Ani Sinha , Shannon Zhao , Peter Maydell Subject: [PATCH 3/4] hw: arm: acpi: add UART clock frequency to SPCR table Date: Fri, 18 Jul 2025 19:20:44 +0300 Message-Id: <20250718162045.49012-4-chichikalyuk@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20250718162045.49012-1-chichikalyuk@gmail.com> References: <20250718162045.49012-1-chichikalyuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::12b; envelope-from=chichikalyuk@gmail.com; helo=mail-lf1-x12b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1752858082316116600 Content-Type: text/plain; charset="utf-8" On the ARM virt machine, there is currently no way to programmatically discover the frequency of the UART reference clock solely through the use of UEFI/ACPI (without the DTB). The SPCR table can include this information as of revision 3. Bump the revision to 3 and add the clock frequency of 24 MHz to the table. Signed-off-by: Vadim Chichikalyuk Reviewed-by: Jonathan Cameron --- hw/arm/virt-acpi-build.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index b01fc4f8ef..029cbb37f7 100644 --- a/hw/arm/virt-acpi-build.c +++ b/hw/arm/virt-acpi-build.c @@ -559,12 +559,13 @@ spcr_setup(GArray *table_data, BIOSLinker *linker, Vi= rtMachineState *vms) .pci_function =3D 0, .pci_flags =3D 0, .pci_segment =3D 0, + .uart_clk_freq =3D 24000000, /* 24MHz */ }; /* - * Passing NULL as the SPCR Table for Revision 2 doesn't support + * Passing NULL as the SPCR Table for Revision 3 doesn't support * NameSpaceString. */ - build_spcr(table_data, linker, &serial, 2, vms->oem_id, vms->oem_table= _id, + build_spcr(table_data, linker, &serial, 3, vms->oem_id, vms->oem_table= _id, NULL); } =20 --=20 2.39.5 (Apple Git-154) From nobody Sat Nov 15 09:24:00 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1752858032; cv=none; d=zohomail.com; s=zohoarc; b=W6BiFLQhf5AsUgMuE5AgtCQaAnXgAPPE/UQWBjnFY/G78EUWvFQa0d6Olbj29BixbbHRFfc6n8lwEJJCg2q9HlkrYmxF7GWLsK+Q4ZzAd1htlVo15cMopkIdEUi25Wo68tyJkuT0FHipR5yGGrcWDlZTkHGfnJBkVA83ROuDvf0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752858032; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=lBrX8kFqn3SKWgrzeGigP/iZk6FEK2hdUWJr2evgfk0=; b=PyT+SO2++UZxXrobhpx3GXZkpTtf84diaVfe9tm0kWuPy8Wq9omBwiVWvrPyg4axfzuity16+KOMM2V9tqHG9hkOgCtAldR+sQ8I/S7mb5adDQyB37sBLgqD1aECiWyc32FP3EUuqPytMbsjtTyKmNpEBehWTM3OnZGXw8ddtTk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752858032492893.2365145449047; Fri, 18 Jul 2025 10:00:32 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ucoR9-0007oc-Os; Fri, 18 Jul 2025 12:59:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ucnt7-0007kk-Ru; Fri, 18 Jul 2025 12:24:46 -0400 Received: from mail-lf1-x131.google.com ([2a00:1450:4864:20::131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ucnt6-000783-8b; Fri, 18 Jul 2025 12:24:45 -0400 Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-5561ab55c4dso2321215e87.2; Fri, 18 Jul 2025 09:24:43 -0700 (PDT) Received: from localhost.localdomain (m91-129-102-83.cust.tele2.ee. [91.129.102.83]) by smtp.googlemail.com with ESMTPSA id 2adb3069b0e04-55a31dacd84sm310615e87.206.2025.07.18.09.24.40 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 18 Jul 2025 09:24:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752855882; x=1753460682; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lBrX8kFqn3SKWgrzeGigP/iZk6FEK2hdUWJr2evgfk0=; b=NiBtA1QqKI6Zx57J3XDhk0dZAA77YZU/GbGWM84eUVA/qPOBOIJl11Urg/LafgKTwX IeeQuWqlrF/WylkCIw+Z4CBqD04WpoeBqT5BVH7y81Z+PpaGXmFIA9RcV8jzJJwKDwvO 2fb5qm6wayfv7DyqC16+kKQx1u7IUWNw+Fy8Oc9W5238YqcYb3am/lMsnLMNHi+zSpJV s+k46atsf49Z34OKUKI/tSsTuD4HVVWa3J04X6jJvhneTruQt37zkS9/djUu4P3HECpp imWZB64+knw8PLkKalRj/AliNSpwd3DWn1JiPUW5wdbDs1d/JbzL2WD924Gvenu5moNL jB7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752855882; x=1753460682; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lBrX8kFqn3SKWgrzeGigP/iZk6FEK2hdUWJr2evgfk0=; b=dvFbH63/e+uxYM2s/69FLkViOH3ekJsfQbRpm+HKYVu7/XKMCH01jMRqAa2st4bmES QM2G/jeUHLHfEjYW8gDgwPhm2TAEfI6OkcoZzj34uw3sXWoWtwcD/tcVn2sq9460s8Ah Fwcqu00Pb3K2Procml+dHtptOUuEEcnyh2an/NUUVehpDvyWn+9wibPu/SGhyZKLxsml cZn9D4v+KS6ltaBSE0MIZABwdC6sKTEK4/8ARD4SQFlMlB0Ua4ppJO4Nm+UJs5Wo/Xga HTA/nk3Qyjx7O669pi2YSsbquPfLtz6JbjBnqlSoNVVDucGAt7Mp9fklqcWaKHPnIaXf VZuw== X-Gm-Message-State: AOJu0YyT1T+nfNVBK1dwCmCBzHJWGVIOzB3RbKSEScU7YsRi2ytqsCpc zY69QHv453RWEmC0mto8yTQlllMUlWfZP/wMXCh5o40eksCzpTvPyDspXCZz/30YGFJkyQ== X-Gm-Gg: ASbGncu2NBjRtw/gsnYp2+OMSdX/A56BUx9t9gqueFrDfj0udtjSTm+Db0PhyU8MStd NKAyGMsJ7cEr6JWQ8SBIMMDnfWsYSocvz3z1wt/TcZRfRLYjs62zFRzw58cacxM83mswlsCtUBh Gxi7L4v35I/HGXNs8HNSbznV6oI/oXsmvOMmEd+b9t+S3N4km7ZiV/IneZUetAgjTHG4uNdL+rs kxrQ/w/uBL2fZ6hk/+37cwwvFHMcw427VjQ21ap957xbYswXKEN860JszhtGVAGlUANtInJN9hE VpUlo+knKQ2zr4rHwNZ5aX5HF/uKsOFzSHkZhXhFRLwga9HsP3kD3PWOzOKYIP//zNGkimIwVJw NvYkhJ8iCUW+ImF6/aF2HV5Cjj8iUdxzZyR8jEy7BdStduNVcrWhA1GZAQI9fF7iiAgUqoqtZ8j R5vUA= X-Google-Smtp-Source: AGHT+IGlHiMksbEmRW0KxRp1iZ6W6YbmkAf69uMpLqxicNJIdMpRH+IefAPftUveOA/RA17QXw0NZQ== X-Received: by 2002:a05:6512:238e:b0:553:24f4:8736 with SMTP id 2adb3069b0e04-55a318a967amr897237e87.53.1752855881576; Fri, 18 Jul 2025 09:24:41 -0700 (PDT) From: Vadim Chichikalyuk To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Vadim Chichikalyuk , "Michael S. Tsirkin" , Igor Mammedov , Ani Sinha , Shannon Zhao , Peter Maydell Subject: [PATCH 4/4] tests: acpi: update expected blobs Date: Fri, 18 Jul 2025 19:20:45 +0300 Message-Id: <20250718162045.49012-5-chichikalyuk@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20250718162045.49012-1-chichikalyuk@gmail.com> References: <20250718162045.49012-1-chichikalyuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::131; envelope-from=chichikalyuk@gmail.com; helo=mail-lf1-x131.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1752858033865116600 Content-Type: text/plain; charset="utf-8" Previous patch changed the SPCR ACPI table for AArch64 virt: @@ -15,2 +15,2 @@ -[008h 0008 001h] Revision : 02 -[009h 0009 001h] Checksum : B1 +[008h 0008 001h] Revision : 03 +[009h 0009 001h] Checksum : 0B @@ -49 +49 @@ -[04Ch 0076 004h] Reserved : 00000000 +[04Ch 0076 004h] Reserved : 016E3600 @@ -53 +53 @@ -0000: 53 50 43 52 50 00 00 00 02 B1 42 4F 43 48 53 20 // SPCRP.....BOCHS +0000: 53 50 43 52 50 00 00 00 03 0B 42 4F 43 48 53 20 // SPCRP.....BOCHS @@ -57 +57 @@ -0040: FF FF FF FF 00 00 00 00 00 00 00 00 00 00 00 00 // ................ +0040: FF FF FF FF 00 00 00 00 00 00 00 00 00 36 6E 01 // .............6n. In a revision 3 SPCR table, the "Reserved" field is the UART clock frequency field. Signed-off-by: Vadim Chichikalyuk --- tests/data/acpi/aarch64/virt/SPCR | Bin 80 -> 80 bytes tests/qtest/bios-tables-test-allowed-diff.h | 1 - 2 files changed, 1 deletion(-) diff --git a/tests/data/acpi/aarch64/virt/SPCR b/tests/data/acpi/aarch64/vi= rt/SPCR index cf0f2b75226515097c08d2e2016a83a4f08812ba..76ac417fbdc4dc6a473c51b8216= 4f40bc5320c58 100644 GIT binary patch delta 20 bcmWFt;0g|K4hmpkU|{B+$mPszmd6MHD|7?L delta 20 acmWFt;0g|K4hmpkU|`xfk;|DG$N&H@90SJy diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios= -tables-test-allowed-diff.h index 2a30472d57..dfb8523c8b 100644 --- a/tests/qtest/bios-tables-test-allowed-diff.h +++ b/tests/qtest/bios-tables-test-allowed-diff.h @@ -1,2 +1 @@ /* List of comma-separated changed AML files to ignore */ -"tests/data/acpi/aarch64/virt/SPCR", \ No newline at end of file --=20 2.39.5 (Apple Git-154)