From nobody Sat Nov 15 11:12:57 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1752774643; cv=none; d=zohomail.com; s=zohoarc; b=cVFdeJqzUctzXUAdA7XVwgTc9oJMlYE6mm291CkXxI4DvU/luA+FKjfq7HwqvOAM7oROZe0sRmT95rhkR8vZoFew9mHF7gyYvkRWMg9VmIqAnXMvLtdwBAieA9406B1xj5fltVIpyMM/K8RYd6zUN1fmqR/Qdg77uZEn6F9jXpc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752774643; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=+Jjg6a0N4ARZEG0dwAx8NTgZN35A3vMWJZdB4oulssc=; b=c7HgIHFHrW+hfu9oEXchETcH9yUrlChav8/cMikXXKEbCMBZ4ZjelauEU4+yML26z2+owdgAoM0IyTW7SYldoZykIX1loTUgazFDtiGpUiw/hVPtdiVm5dQKR6Ig8YKyMZLgevW/cK7soJeCZvfwriIc52Ag1oGUZZhNE2i2zZM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752774642942925.7819006604279; Thu, 17 Jul 2025 10:50:42 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ucSkX-00026c-Cd; Thu, 17 Jul 2025 13:50:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ucQDk-0006pX-F7 for qemu-devel@nongnu.org; Thu, 17 Jul 2025 11:08:30 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ucQDi-00029x-RK for qemu-devel@nongnu.org; Thu, 17 Jul 2025 11:08:28 -0400 Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-134-BJLBnfD_Pnu1Yee6ZZiLiw-1; Thu, 17 Jul 2025 11:08:23 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AFF9519560A2 for ; Thu, 17 Jul 2025 15:08:22 +0000 (UTC) Received: from lenovo-t14s.redhat.com (unknown [10.44.33.65]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id AFF07180049D; Thu, 17 Jul 2025 15:08:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752764906; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+Jjg6a0N4ARZEG0dwAx8NTgZN35A3vMWJZdB4oulssc=; b=HMoIqKXrx0/lK0S80yduH15R0ZXqd+pDJDRwpVGjPMt7rOFz/cKIie5yYjMFP2POMCJDlN nbn9Di93EXruwy3jFzP35nJ3p9crD4Kdv4ff1eKldW4V8y6NeW3b5ftMvzZlHPc7GJWekA VDX2v1+L58dq2y14ZaCGDDw3GZT2vVE= X-MC-Unique: BJLBnfD_Pnu1Yee6ZZiLiw-1 X-Mimecast-MFC-AGG-ID: BJLBnfD_Pnu1Yee6ZZiLiw_1752764902 From: Laurent Vivier To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Jason Wang , Laurent Vivier Subject: [PATCH 6/6] net/vhost-user: Remove unused "err" from chr_closed_bh() (CID 1612365) Date: Thu, 17 Jul 2025 17:08:05 +0200 Message-ID: <20250717150805.1344034-7-lvivier@redhat.com> In-Reply-To: <20250717150805.1344034-1-lvivier@redhat.com> References: <20250717150805.1344034-1-lvivier@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=lvivier@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1752774644329116600 Content-Type: text/plain; charset="utf-8" The "err" variable was declared but never used within the chr_closed_bh() function. This resulted in a dead code warning (CID 1612365) from Coverity. Remove the unused variable and the associated error block to resolve the issue. Signed-off-by: Laurent Vivier Reviewed-by: Peter Maydell --- net/vhost-user.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/net/vhost-user.c b/net/vhost-user.c index cec83e925ff0..8b96157145a7 100644 --- a/net/vhost-user.c +++ b/net/vhost-user.c @@ -298,7 +298,6 @@ static void chr_closed_bh(void *opaque) const char *name =3D opaque; NetClientState *ncs[MAX_QUEUE_NUM]; NetVhostUserState *s; - Error *err =3D NULL; int queues, i; =20 queues =3D qemu_find_net_clients_except(name, ncs, @@ -317,9 +316,6 @@ static void chr_closed_bh(void *opaque) qemu_chr_fe_set_handlers(&s->chr, NULL, NULL, net_vhost_user_event, NULL, opaque, NULL, true); =20 - if (err) { - error_report_err(err); - } qapi_event_send_netdev_vhost_user_disconnected(name); } =20 --=20 2.49.0