From nobody Sat Nov 15 11:14:13 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1752774697; cv=none; d=zohomail.com; s=zohoarc; b=ZmLHklnos3tWzAeoHYIifpY+zIQKgliXFX1tWOcq6YV4n8lGo+1PAleYds5zEHsM9eT7D9MJXmFbU3xaBeKQFCyoP6FHT9vah8Sq31W/KGweVDmXTMRGpYgoB5+SJsbuye/6NHgQA9k6ex/ZUCVQX6IF5DFDzGoRb82JaCo0/yI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752774697; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=OQ8pbbshTo9Bio5ak+vqsPdwzrzC+NEekKOEuUB4BgQ=; b=RLOzj9CzsC+7lUOMpzBI11av1wnY8TvF3Kfm76Zcykl3pR+nAwuWMDSC/UQaEMSLXcbj7HinXFW+8fzxil4MWDM5BXzMzBUOt9cCqpnui+WYkIOmyy1uiw1Hy01v1GgKo3l2HjXXet8ETsUUxzx7/u+cohclsaB3aMbyupkaxJ8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752774697342488.9111076753078; Thu, 17 Jul 2025 10:51:37 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ucSkf-0002La-BJ; Thu, 17 Jul 2025 13:50:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ucQDw-0006rn-45 for qemu-devel@nongnu.org; Thu, 17 Jul 2025 11:08:44 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ucQDt-0002BD-I0 for qemu-devel@nongnu.org; Thu, 17 Jul 2025 11:08:38 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-98-r0agnbe_MQ6s8mMKHks9wA-1; Thu, 17 Jul 2025 11:08:34 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1A1201850DEF for ; Thu, 17 Jul 2025 15:08:20 +0000 (UTC) Received: from lenovo-t14s.redhat.com (unknown [10.44.33.65]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6F42018003FC; Thu, 17 Jul 2025 15:08:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752764916; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OQ8pbbshTo9Bio5ak+vqsPdwzrzC+NEekKOEuUB4BgQ=; b=HVqT+TIYlAralyUnyeNhkL7zcftpKaTfnT7TpbICKIyffJDEDOL7iaFk50qP99IbzEk+kL VC+LUWcsRRWUcWdd+GFCt2B1SRUkaTGLCUbt3U92qEeizg6dACrA1osXi5zuOKhEGxy1Ze 8JY1OrYxcceO+BjeAFJTok8BADLGZNg= X-MC-Unique: r0agnbe_MQ6s8mMKHks9wA-1 X-Mimecast-MFC-AGG-ID: r0agnbe_MQ6s8mMKHks9wA_1752764914 From: Laurent Vivier To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Jason Wang , Laurent Vivier Subject: [PATCH 5/6] net/passt: Initialize "error" variable in net_passt_send() (CID 1612368) Date: Thu, 17 Jul 2025 17:08:04 +0200 Message-ID: <20250717150805.1344034-6-lvivier@redhat.com> In-Reply-To: <20250717150805.1344034-1-lvivier@redhat.com> References: <20250717150805.1344034-1-lvivier@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=lvivier@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1752774699091116600 Content-Type: text/plain; charset="utf-8" This was flagged by Coverity as a memory illegal access. Initialize the pointer to NULL at declaration. Signed-off-by: Laurent Vivier Reviewed-by: Peter Maydell --- net/passt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/passt.c b/net/passt.c index 43c336e5968c..32ecffb763b4 100644 --- a/net/passt.c +++ b/net/passt.c @@ -124,7 +124,7 @@ static gboolean net_passt_send(QIOChannel *ioc, GIOCond= ition condition, { if (net_stream_data_send(ioc, condition, data) =3D=3D G_SOURCE_REMOVE)= { NetPasstState *s =3D DO_UPCAST(NetPasstState, data, data); - Error *error; + Error *error =3D NULL; =20 /* we need to restart passt */ kill(s->pid, SIGTERM); --=20 2.49.0