From nobody Sat Nov 15 09:31:56 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1752774219; cv=none; d=zohomail.com; s=zohoarc; b=esxfYulWgBhuaF59Ea5YovDkR+a2OHz8w7Pt5LNgNsR5wXdi2Axqgo4ETZXD1Y/ZH5G3r/qcGhVoQuJPWPhAlF/x1bSHpJME+AB0E3Ke7/PoDfHwYi1VhtYdmzkS0//gZPkzQ0tpJSGP+OUAFIa0JuSPwqmbjG9n901+ds7tp38= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752774219; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=DBQX4oHEyEVSgUlx/4xDvO7ZYEg0OgUmDIvJpF3hZz8=; b=HffrWqbxYp6BAkW/HXT0BoOhnb7GX2UEpbyij9G+VSn2ec5ZIA6Ao13sJJpe+JqhTCd/wrf47/9jzPlt2U11+tJuIqGI6i2zbCCZsB3/brdeXhjbcdiedkMuUJPmwOZtT906zVBUwasx3zAM/P5HFJ/Oaiwi4UsN9uceImf5O9Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752774219064691.8605919606185; Thu, 17 Jul 2025 10:43:39 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ucSdo-0005pw-4S; Thu, 17 Jul 2025 13:43:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ucQDh-0006p4-Lj for qemu-devel@nongnu.org; Thu, 17 Jul 2025 11:08:26 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ucQDb-00027d-C9 for qemu-devel@nongnu.org; Thu, 17 Jul 2025 11:08:25 -0400 Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-130-3ttw-xoLMLaU-MQ083qRKQ-1; Thu, 17 Jul 2025 11:08:12 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 66FCA195608B for ; Thu, 17 Jul 2025 15:08:11 +0000 (UTC) Received: from lenovo-t14s.redhat.com (unknown [10.44.33.65]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B92D318003FC; Thu, 17 Jul 2025 15:08:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752764894; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DBQX4oHEyEVSgUlx/4xDvO7ZYEg0OgUmDIvJpF3hZz8=; b=UHjRVohOD0RBAgl7IiM05Y8S05yQXdZwWWGiYERO745LUcP5KgQ7Binj4j+f3qUNhN7192 fuCn6jEh+hZTd/F7EONGwHMPwzFJ8Jvg9QzJV9Vym6htFzQ84T04hG+9rzW7vTuPd4B7B7 8lk774NN9wjeqWpCo93ebhkb4JkMSrs= X-MC-Unique: 3ttw-xoLMLaU-MQ083qRKQ-1 X-Mimecast-MFC-AGG-ID: 3ttw-xoLMLaU-MQ083qRKQ_1752764891 From: Laurent Vivier To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Jason Wang , Laurent Vivier Subject: [PATCH 1/6] net/passt: Remove unused "err" from passt_vhost_user_event() (CID 1612375) Date: Thu, 17 Jul 2025 17:08:00 +0200 Message-ID: <20250717150805.1344034-2-lvivier@redhat.com> In-Reply-To: <20250717150805.1344034-1-lvivier@redhat.com> References: <20250717150805.1344034-1-lvivier@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=lvivier@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1752774221344116600 Content-Type: text/plain; charset="utf-8" The "err" variable was declared but never used within the passt_vhost_user_event() function. This resulted in a dead code warning (CID 1612375) from Coverity. Remove the unused variable and the associated error block to resolve the issue. Signed-off-by: Laurent Vivier Reviewed-by: Peter Maydell --- net/passt.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/net/passt.c b/net/passt.c index 6f616ba3c258..9cd5b3e6f2af 100644 --- a/net/passt.c +++ b/net/passt.c @@ -397,7 +397,6 @@ err: static void passt_vhost_user_event(void *opaque, QEMUChrEvent event) { NetPasstState *s =3D opaque; - Error *err =3D NULL; =20 switch (event) { case CHR_EVENT_OPENED: @@ -428,10 +427,6 @@ static void passt_vhost_user_event(void *opaque, QEMUC= hrEvent event) /* Ignore */ break; } - - if (err) { - error_report_err(err); - } } =20 static int net_passt_vhost_user_init(NetPasstState *s, Error **errp) --=20 2.49.0 From nobody Sat Nov 15 09:31:56 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1752774758; cv=none; d=zohomail.com; s=zohoarc; b=BhRtE38uBvqYfAaG2Qgg3dTn7kzgGRVqzJaY3h23rN1CcxEdwniG+3bl0RnKC2pco2wsgES6iTmoP85Lp8kzcM2hk6A+63UlstU25i6Z8L+nH/Ysr6t46hw4F+bdKt2PIljoeItwV9dfn5wZtVqW1qQExyYe/c+ycSY7g3+30Z8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752774758; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=J4vkSzxZ32qN+KEwg2njP6bzH1pAEpatOoTTjl/xNdk=; b=IzWaqQy4kQsCm4mMbQg9BNRVdMXuSCM58npvM9FUjUq9TBP7DcBcipLyRB3zM5mKuXhnmILV9UwOZTDeY7FYR+Ld0euPfiRzhV2mb7jBXt99cxVMUr1Krx7dc3vsdNJTvzKtCVlOkqenLU1Lwt2Zu+lOSUYu67gc520mU3nCQgo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752774758427849.9703376903166; Thu, 17 Jul 2025 10:52:38 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ucSkm-0002oh-Qz; Thu, 17 Jul 2025 13:50:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ucQDg-0006nX-7U for qemu-devel@nongnu.org; Thu, 17 Jul 2025 11:08:24 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ucQDb-00027n-8W for qemu-devel@nongnu.org; Thu, 17 Jul 2025 11:08:23 -0400 Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-570-a4l7cJfzPwameKONN3Frgw-1; Thu, 17 Jul 2025 11:08:14 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 86119195608F for ; Thu, 17 Jul 2025 15:08:13 +0000 (UTC) Received: from lenovo-t14s.redhat.com (unknown [10.44.33.65]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E11FB18003FC; Thu, 17 Jul 2025 15:08:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752764895; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J4vkSzxZ32qN+KEwg2njP6bzH1pAEpatOoTTjl/xNdk=; b=MZvrvPq1VruldX8xUAgaRbpfrzHXhwFZnmo0SrFYUO6oYVJaJHP0cD8sEWKevzP/aydODg jwNLaVNYGohHsgZevqR0Qmp46ivPdhYUHv40HZ+b3ghqfFsxHeOGnw4ViQXP0IO9qMEbwq Xn7qkbDn1DvhoNRiT7qEGGAjTJxSDYg= X-MC-Unique: a4l7cJfzPwameKONN3Frgw-1 X-Mimecast-MFC-AGG-ID: a4l7cJfzPwameKONN3Frgw_1752764893 From: Laurent Vivier To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Jason Wang , Laurent Vivier Subject: [PATCH 2/6] net/vhost-user: Remove unused "err" from net_vhost_user_event() (CID 1612372) Date: Thu, 17 Jul 2025 17:08:01 +0200 Message-ID: <20250717150805.1344034-3-lvivier@redhat.com> In-Reply-To: <20250717150805.1344034-1-lvivier@redhat.com> References: <20250717150805.1344034-1-lvivier@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=lvivier@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1752774759684116600 Content-Type: text/plain; charset="utf-8" The "err" variable was declared but never used within the net_vhost_user_event() function. This resulted in a dead code warning (CID 1612372) from Coverity. Remove the unused variable and the associated error block to resolve the issue. Signed-off-by: Laurent Vivier Reviewed-by: Peter Maydell --- net/vhost-user.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/net/vhost-user.c b/net/vhost-user.c index 1c3b8b36f351..cec83e925ff0 100644 --- a/net/vhost-user.c +++ b/net/vhost-user.c @@ -329,7 +329,6 @@ static void net_vhost_user_event(void *opaque, QEMUChrE= vent event) NetClientState *ncs[MAX_QUEUE_NUM]; NetVhostUserState *s; Chardev *chr; - Error *err =3D NULL; int queues; =20 queues =3D qemu_find_net_clients_except(name, ncs, @@ -375,10 +374,6 @@ static void net_vhost_user_event(void *opaque, QEMUChr= Event event) /* Ignore */ break; } - - if (err) { - error_report_err(err); - } } =20 static int net_vhost_user_init(NetClientState *peer, const char *device, --=20 2.49.0 From nobody Sat Nov 15 09:31:56 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1752774624; cv=none; d=zohomail.com; s=zohoarc; b=hyavbMHRDk4WDA8XVKeaWPMfQYISIZaBuYy0YpWkXJOkF9WyAvR1RV1ikknQc7Q8Buyr8XHX0Yg+Ui/AGnHEPxXsBalnsWVacVt11KyPbbXL2h9mVWqk3k6x23yoS6XoioTbaPw0jA6as2kXyc1LizZGOFlhfwAyYlAjV/OBUZc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752774624; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=qdmYQyp1if23DWfbBGI3waNotU+eaTtpUKnbCvSdG7U=; b=Y1we5RSkFPDo/AP0FrlF3Sf/SdA9gNIKI04ENadsu1lJBsH2N5z9OW57nTfibkCaU0cGngtoZYnlLXIORpqJdmk93sceIG67wv7wTEztcm9pindOsdKTtzYF7FoL9y/859KExXWXY+cDNo5ORHaJh5xrRQRqyLtWqkOjqTmG5hQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752774624530227.57605071623186; Thu, 17 Jul 2025 10:50:24 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ucSjy-0001We-VE; Thu, 17 Jul 2025 13:50:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ucQDg-0006nR-2J for qemu-devel@nongnu.org; Thu, 17 Jul 2025 11:08:24 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ucQDb-00027x-56 for qemu-devel@nongnu.org; Thu, 17 Jul 2025 11:08:23 -0400 Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-574-meiAwj9GPeWJfLskkZfyCQ-1; Thu, 17 Jul 2025 11:08:16 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CADA619560A5 for ; Thu, 17 Jul 2025 15:08:15 +0000 (UTC) Received: from lenovo-t14s.redhat.com (unknown [10.44.33.65]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 3A53118003FC; Thu, 17 Jul 2025 15:08:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752764898; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qdmYQyp1if23DWfbBGI3waNotU+eaTtpUKnbCvSdG7U=; b=AxVc3lEK++hUopWYuKR/rTfwHe1fner0WiVWmj4URe0BSyamLHJpODjsFmxhLB9gJzEGQj rlVJuJ9MWMdv8kP6DB3zWSIhYqM3br3aCCwg7/HowOX4d5ZzQZ+izh0vmY2NjiejixXMOn YALZPRqStOLcAeJq7jcFPMKSBZ9EAiI= X-MC-Unique: meiAwj9GPeWJfLskkZfyCQ-1 X-Mimecast-MFC-AGG-ID: meiAwj9GPeWJfLskkZfyCQ_1752764895 From: Laurent Vivier To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Jason Wang , Laurent Vivier Subject: [PATCH 3/6] net/passt: Remove dead code in passt_vhost_user_start error path (CID 1612371) Date: Thu, 17 Jul 2025 17:08:02 +0200 Message-ID: <20250717150805.1344034-4-lvivier@redhat.com> In-Reply-To: <20250717150805.1344034-1-lvivier@redhat.com> References: <20250717150805.1344034-1-lvivier@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=lvivier@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1752774626382116600 Content-Type: text/plain; charset="utf-8" In passt_vhost_user_start(), if vhost_net_init() fails, the "net" variable is NULL and execution jumps to the "err:" label. The cleanup code within this label is conditioned on "if (net)", which can never be true in this error case. This makes the cleanup block dead code, as reported by Coverity (CID 1612371). Refactor the error handling to occur inline, removing the goto and the unreachable cleanup block. Signed-off-by: Laurent Vivier Reviewed-by: Peter Maydell --- net/passt.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/net/passt.c b/net/passt.c index 9cd5b3e6f2af..ef59d0682be1 100644 --- a/net/passt.c +++ b/net/passt.c @@ -375,7 +375,8 @@ static int passt_vhost_user_start(NetPasstState *s, Vho= stUserState *be) net =3D vhost_net_init(&options); if (!net) { error_report("failed to init passt vhost_net"); - goto err; + passt_vhost_user_stop(s); + return -1; } =20 if (s->vhost_net) { @@ -385,13 +386,6 @@ static int passt_vhost_user_start(NetPasstState *s, Vh= ostUserState *be) s->vhost_net =3D net; =20 return 0; -err: - if (net) { - vhost_net_cleanup(net); - g_free(net); - } - passt_vhost_user_stop(s); - return -1; } =20 static void passt_vhost_user_event(void *opaque, QEMUChrEvent event) --=20 2.49.0 From nobody Sat Nov 15 09:31:56 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1752774262; cv=none; d=zohomail.com; s=zohoarc; b=UgSSQBSdcC/wRDlrJ9uUkocF+sz696fUqDC3jduU57+mAtoc0HKKO9BHUivKX4HScMSLcsXrAhCKaNq3enK4tD/41KbDLVlroTcz25Rf3b/A4naqCsLCMFYjLF1E9LZoIkAHu3S8CGbU6DeMQ73Dhbx4yO9jf6u3XwFW6hL+GqM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752774262; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=M2Bf86os9SSI0e5+gs1+aDE+pC3O9YFtF/ov/MW6nrA=; b=Gt218ylbBh8M0o7JGZyeZYgyhNxahmbiuo6kERlJp7n8E8pZ9BACBKedUbMZp/rkLBFHnGTudN5h7Tz3MFgK7J0DEVttSJLtDDp6JwBn0MECrkBZMsZCJ52s8yjxBoo3TnLDc1PMYW5uUXCnbMUgMYJx9my+VXOPwUR0b90NfTE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752774262796287.4983845251852; Thu, 17 Jul 2025 10:44:22 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ucSeV-0006Yt-EY; Thu, 17 Jul 2025 13:44:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ucQDi-0006pE-Ix for qemu-devel@nongnu.org; Thu, 17 Jul 2025 11:08:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ucQDd-00028F-EL for qemu-devel@nongnu.org; Thu, 17 Jul 2025 11:08:26 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-125-w47qddlQOE-cDo5LHL4_Fw-1; Thu, 17 Jul 2025 11:08:18 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E9225195FE11 for ; Thu, 17 Jul 2025 15:08:17 +0000 (UTC) Received: from lenovo-t14s.redhat.com (unknown [10.44.33.65]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 503F818003FC; Thu, 17 Jul 2025 15:08:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752764900; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M2Bf86os9SSI0e5+gs1+aDE+pC3O9YFtF/ov/MW6nrA=; b=Z6ds5+J0hTqOhJ6qyZSniw400WpZ3tXqedg6qWeTDteQPruceUfCzntjnvLS0q/JX3zqeO 7kbDtyVGufpULNk+tZPg51t9vNFJw7JZ/tUk1IszMs52mPy17+xtN47oFP5KYQ3waiGPgj 95AEqScTkysmgWdq2a8M7tGTqf/6icA= X-MC-Unique: w47qddlQOE-cDo5LHL4_Fw-1 X-Mimecast-MFC-AGG-ID: w47qddlQOE-cDo5LHL4_Fw_1752764898 From: Laurent Vivier To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Jason Wang , Laurent Vivier Subject: [PATCH 4/6] net/passt: Check return value of g_remove() in net_passt_cleanup() (CID 1612369) Date: Thu, 17 Jul 2025 17:08:03 +0200 Message-ID: <20250717150805.1344034-5-lvivier@redhat.com> In-Reply-To: <20250717150805.1344034-1-lvivier@redhat.com> References: <20250717150805.1344034-1-lvivier@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=lvivier@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1752774263563116600 Content-Type: text/plain; charset="utf-8" If g_remove() fails, use warn_report() to log an error. Signed-off-by: Laurent Vivier Reviewed-by: Peter Maydell --- net/passt.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/passt.c b/net/passt.c index ef59d0682be1..43c336e5968c 100644 --- a/net/passt.c +++ b/net/passt.c @@ -103,7 +103,10 @@ static void net_passt_cleanup(NetClientState *nc) #endif =20 kill(s->pid, SIGTERM); - g_remove(s->pidfile); + if (g_remove(s->pidfile) !=3D 0) { + warn_report("Failed to remove passt pidfile %s: %s", + s->pidfile, strerror(errno)); + } g_free(s->pidfile); g_ptr_array_free(s->args, TRUE); } --=20 2.49.0 From nobody Sat Nov 15 09:31:56 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1752774697; cv=none; d=zohomail.com; s=zohoarc; b=ZmLHklnos3tWzAeoHYIifpY+zIQKgliXFX1tWOcq6YV4n8lGo+1PAleYds5zEHsM9eT7D9MJXmFbU3xaBeKQFCyoP6FHT9vah8Sq31W/KGweVDmXTMRGpYgoB5+SJsbuye/6NHgQA9k6ex/ZUCVQX6IF5DFDzGoRb82JaCo0/yI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752774697; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=OQ8pbbshTo9Bio5ak+vqsPdwzrzC+NEekKOEuUB4BgQ=; b=RLOzj9CzsC+7lUOMpzBI11av1wnY8TvF3Kfm76Zcykl3pR+nAwuWMDSC/UQaEMSLXcbj7HinXFW+8fzxil4MWDM5BXzMzBUOt9cCqpnui+WYkIOmyy1uiw1Hy01v1GgKo3l2HjXXet8ETsUUxzx7/u+cohclsaB3aMbyupkaxJ8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752774697342488.9111076753078; Thu, 17 Jul 2025 10:51:37 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ucSkf-0002La-BJ; Thu, 17 Jul 2025 13:50:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ucQDw-0006rn-45 for qemu-devel@nongnu.org; Thu, 17 Jul 2025 11:08:44 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ucQDt-0002BD-I0 for qemu-devel@nongnu.org; Thu, 17 Jul 2025 11:08:38 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-98-r0agnbe_MQ6s8mMKHks9wA-1; Thu, 17 Jul 2025 11:08:34 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1A1201850DEF for ; Thu, 17 Jul 2025 15:08:20 +0000 (UTC) Received: from lenovo-t14s.redhat.com (unknown [10.44.33.65]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6F42018003FC; Thu, 17 Jul 2025 15:08:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752764916; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OQ8pbbshTo9Bio5ak+vqsPdwzrzC+NEekKOEuUB4BgQ=; b=HVqT+TIYlAralyUnyeNhkL7zcftpKaTfnT7TpbICKIyffJDEDOL7iaFk50qP99IbzEk+kL VC+LUWcsRRWUcWdd+GFCt2B1SRUkaTGLCUbt3U92qEeizg6dACrA1osXi5zuOKhEGxy1Ze 8JY1OrYxcceO+BjeAFJTok8BADLGZNg= X-MC-Unique: r0agnbe_MQ6s8mMKHks9wA-1 X-Mimecast-MFC-AGG-ID: r0agnbe_MQ6s8mMKHks9wA_1752764914 From: Laurent Vivier To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Jason Wang , Laurent Vivier Subject: [PATCH 5/6] net/passt: Initialize "error" variable in net_passt_send() (CID 1612368) Date: Thu, 17 Jul 2025 17:08:04 +0200 Message-ID: <20250717150805.1344034-6-lvivier@redhat.com> In-Reply-To: <20250717150805.1344034-1-lvivier@redhat.com> References: <20250717150805.1344034-1-lvivier@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=lvivier@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1752774699091116600 Content-Type: text/plain; charset="utf-8" This was flagged by Coverity as a memory illegal access. Initialize the pointer to NULL at declaration. Signed-off-by: Laurent Vivier Reviewed-by: Peter Maydell --- net/passt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/passt.c b/net/passt.c index 43c336e5968c..32ecffb763b4 100644 --- a/net/passt.c +++ b/net/passt.c @@ -124,7 +124,7 @@ static gboolean net_passt_send(QIOChannel *ioc, GIOCond= ition condition, { if (net_stream_data_send(ioc, condition, data) =3D=3D G_SOURCE_REMOVE)= { NetPasstState *s =3D DO_UPCAST(NetPasstState, data, data); - Error *error; + Error *error =3D NULL; =20 /* we need to restart passt */ kill(s->pid, SIGTERM); --=20 2.49.0 From nobody Sat Nov 15 09:31:56 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1752774643; cv=none; d=zohomail.com; s=zohoarc; b=cVFdeJqzUctzXUAdA7XVwgTc9oJMlYE6mm291CkXxI4DvU/luA+FKjfq7HwqvOAM7oROZe0sRmT95rhkR8vZoFew9mHF7gyYvkRWMg9VmIqAnXMvLtdwBAieA9406B1xj5fltVIpyMM/K8RYd6zUN1fmqR/Qdg77uZEn6F9jXpc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752774643; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=+Jjg6a0N4ARZEG0dwAx8NTgZN35A3vMWJZdB4oulssc=; b=c7HgIHFHrW+hfu9oEXchETcH9yUrlChav8/cMikXXKEbCMBZ4ZjelauEU4+yML26z2+owdgAoM0IyTW7SYldoZykIX1loTUgazFDtiGpUiw/hVPtdiVm5dQKR6Ig8YKyMZLgevW/cK7soJeCZvfwriIc52Ag1oGUZZhNE2i2zZM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752774642942925.7819006604279; Thu, 17 Jul 2025 10:50:42 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ucSkX-00026c-Cd; Thu, 17 Jul 2025 13:50:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ucQDk-0006pX-F7 for qemu-devel@nongnu.org; Thu, 17 Jul 2025 11:08:30 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ucQDi-00029x-RK for qemu-devel@nongnu.org; Thu, 17 Jul 2025 11:08:28 -0400 Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-134-BJLBnfD_Pnu1Yee6ZZiLiw-1; Thu, 17 Jul 2025 11:08:23 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AFF9519560A2 for ; Thu, 17 Jul 2025 15:08:22 +0000 (UTC) Received: from lenovo-t14s.redhat.com (unknown [10.44.33.65]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id AFF07180049D; Thu, 17 Jul 2025 15:08:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752764906; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+Jjg6a0N4ARZEG0dwAx8NTgZN35A3vMWJZdB4oulssc=; b=HMoIqKXrx0/lK0S80yduH15R0ZXqd+pDJDRwpVGjPMt7rOFz/cKIie5yYjMFP2POMCJDlN nbn9Di93EXruwy3jFzP35nJ3p9crD4Kdv4ff1eKldW4V8y6NeW3b5ftMvzZlHPc7GJWekA VDX2v1+L58dq2y14ZaCGDDw3GZT2vVE= X-MC-Unique: BJLBnfD_Pnu1Yee6ZZiLiw-1 X-Mimecast-MFC-AGG-ID: BJLBnfD_Pnu1Yee6ZZiLiw_1752764902 From: Laurent Vivier To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Jason Wang , Laurent Vivier Subject: [PATCH 6/6] net/vhost-user: Remove unused "err" from chr_closed_bh() (CID 1612365) Date: Thu, 17 Jul 2025 17:08:05 +0200 Message-ID: <20250717150805.1344034-7-lvivier@redhat.com> In-Reply-To: <20250717150805.1344034-1-lvivier@redhat.com> References: <20250717150805.1344034-1-lvivier@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=lvivier@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1752774644329116600 Content-Type: text/plain; charset="utf-8" The "err" variable was declared but never used within the chr_closed_bh() function. This resulted in a dead code warning (CID 1612365) from Coverity. Remove the unused variable and the associated error block to resolve the issue. Signed-off-by: Laurent Vivier Reviewed-by: Peter Maydell --- net/vhost-user.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/net/vhost-user.c b/net/vhost-user.c index cec83e925ff0..8b96157145a7 100644 --- a/net/vhost-user.c +++ b/net/vhost-user.c @@ -298,7 +298,6 @@ static void chr_closed_bh(void *opaque) const char *name =3D opaque; NetClientState *ncs[MAX_QUEUE_NUM]; NetVhostUserState *s; - Error *err =3D NULL; int queues, i; =20 queues =3D qemu_find_net_clients_except(name, ncs, @@ -317,9 +316,6 @@ static void chr_closed_bh(void *opaque) qemu_chr_fe_set_handlers(&s->chr, NULL, NULL, net_vhost_user_event, NULL, opaque, NULL, true); =20 - if (err) { - error_report_err(err); - } qapi_event_send_netdev_vhost_user_disconnected(name); } =20 --=20 2.49.0