From nobody Sat Nov 15 09:50:13 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1752774107; cv=none; d=zohomail.com; s=zohoarc; b=JzxxSUuTyVHoYQns6ZwOgrSslOuv9Y1AK7pcYj2F0XaJgbkoZAgPQJowUqkVBmXfRrq9RboMyBk3QvmYzihddVCdJZBmKLtOIsPpI7vSdrkBVdNrXUNUtLKmla71oyS/Z/CSysfWaKN6RYonzgJB3lqKuOLAC7weNYNUfiTo3JM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752774107; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=s4PwemJfNWw4gTqH6cQb/KQ7d7y1Ytp/4de0LQhCpN4=; b=iwn45zBkcuwNmh0bIHcHzljjkPwoXCefP1D6Vqt33RYE8Do6zBULguXIu5fNPEy6dKSyXwvkD1ypTGeiBub5zRINrtexbZoyvB4FJLkTtVpOGrPC7/kZymtUQiPWro35F/r4UJwPmQP3PUheVQ9XGlcmS4uBV+6XBGLMY/ZHBGM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752774107723217.58898719625506; Thu, 17 Jul 2025 10:41:47 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ucSba-0003WK-3u; Thu, 17 Jul 2025 13:41:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ucQ5Z-000329-T0 for qemu-devel@nongnu.org; Thu, 17 Jul 2025 11:00:02 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ucQ5W-0000qF-J1 for qemu-devel@nongnu.org; Thu, 17 Jul 2025 11:00:01 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-681-_PFl5ccKMn2ALoAYxwElXw-1; Thu, 17 Jul 2025 10:59:54 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 20A2B1800C36 for ; Thu, 17 Jul 2025 14:59:53 +0000 (UTC) Received: from srv1.redhat.com (unknown [10.44.32.152]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5091C1956089; Thu, 17 Jul 2025 14:59:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752764395; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=s4PwemJfNWw4gTqH6cQb/KQ7d7y1Ytp/4de0LQhCpN4=; b=A2n4aWuzvwcCmRfknVp2sFAbQlbbqAQgUCU0Qmfxug1PXxBCNNgPDgvMjVPVpgWHg65zj/ UEJMnUJEP9y5SYU9Fvq3NnM3u6F6pzxVhvBg94s7jK5cyng4eMqbzhH5NkE2GUSiot6fFS iFMhXdUuJKBsXzcL9puhTqeVLze4SPk= X-MC-Unique: _PFl5ccKMn2ALoAYxwElXw-1 X-Mimecast-MFC-AGG-ID: _PFl5ccKMn2ALoAYxwElXw_1752764393 From: Kostiantyn Kostiuk To: qemu-devel@nongnu.org Cc: Markus Armbruster , Yan Vugenfirer , =?UTF-8?q?Daniel=20Berrang=C3=A9?= , Kostiantyn Kostiuk Subject: [PATCH] util: win32: Write hex value when can't get error message Date: Thu, 17 Jul 2025 17:59:48 +0300 Message-ID: <20250717145948.77870-1-kkostiuk@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=kkostiuk@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1752774110176116600 Content-Type: text/plain; charset="utf-8" g_win32_error_message - translate a Win32 error code (as returned by GetLastError()) into the corresponding message. In the same time, we call error_setg_win32_internal with error codes from different Windows componets like VSS or Performance monitor that provides different codes and can't be converted with g_win32_error_message. In this case, the empty suffix will be returned so error will be masked. QGA error example: - before changes: {"error": {"class": "GenericError", "desc": "failed to add D:\\ to snapsh= ot set: "}} - after changes: {"error": {"class": "GenericError", "desc": "failed to add D:\\ to snapsh= ot set: unknown Windows error 0x8004230e"}} Signed-off-by: Kostiantyn Kostiuk Reviewed-by: Yan Vugenfirer --- util/error.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/util/error.c b/util/error.c index daea2142f3..b1342558ae 100644 --- a/util/error.c +++ b/util/error.c @@ -188,6 +188,11 @@ void error_setg_win32_internal(Error **errp, =20 if (win32_err !=3D 0) { suffix =3D g_win32_error_message(win32_err); + // g_win32_error_message() failed + if (!suffix[0]) { + g_free(suffix); + suffix =3D g_strdup_printf("unknown Windows error 0x%x", win32= _err); + } } =20 va_start(ap, fmt); --=20 2.48.1