From nobody Sat Nov 15 08:50:45 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1752686963; cv=none; d=zohomail.com; s=zohoarc; b=JEfqfKTg5pd/tCpVMyq8prufcDkv/qAtGW3nZVF2gASOxbgVp/w6DhTmEI0c6NBoQrU0pGOe3oRdjTeMjZ6aBJItBhLlWURgrJvZRWCkOyvuw0fQ1NHuOIxNw15Mfe27AVaAOMFw161RnVPYkSdA5LlyjdlHt4GQhMJqn4Od/ZI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752686963; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=jvMqfwhNEUaAbyBTg3ZU/8Yl+gwZdDpyb6yyXj/6hXQ=; b=YlVeRbwE1ikZgJlI7XWVJZ3PhtxTVraV8L2fkvqYQuNfn7EDFI6iXpwxsF+ryU3+2ELsN2+sdRMcj8nZXBvK5ZtSFg5rnq4cGmh+2IpzaCKpSOxe3ezpytXeH8HzTI8QtMxgsDNrWlpOEvG8CRZO2ZbgK/4WcT8IwIsXzWIo4Jw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752686963245122.0821305397327; Wed, 16 Jul 2025 10:29:23 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uc5vj-0001nx-OX; Wed, 16 Jul 2025 13:28:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uc5vd-0001iX-4c for qemu-devel@nongnu.org; Wed, 16 Jul 2025 13:28:25 -0400 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uc5vb-000087-Cs for qemu-devel@nongnu.org; Wed, 16 Jul 2025 13:28:24 -0400 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-3b45edf2303so62386f8f.2 for ; Wed, 16 Jul 2025 10:28:22 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4562f7514afsm22412785e9.8.2025.07.16.10.28.19 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 16 Jul 2025 10:28:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1752686901; x=1753291701; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jvMqfwhNEUaAbyBTg3ZU/8Yl+gwZdDpyb6yyXj/6hXQ=; b=iwuRCXFRw/tt5MDLDAhuz/Myp6KecDaKVwyvBDHW+SnsFEF3iU34qCKlDUpzOxN1Zj 5wFrLd5Bw5MFtOhYorjZcjTVu1KuYM7PMIOkd4SfuCYKmGlqK4QrUxhPwLKdUvOmlJbE wJC0Wk2TCoIGt63gWKo3wj3sxsEbv3r7HHRvAZqbKObD6sTV+zOuKu7DlxzuZelmyrc9 avX6zrgM3SzDHyXcEwXvtgwXF581/5nHu4RaXGloFYJN3JoDvn8wc3k7/Bsz1DqEf9TD 1H6KgPzxwh1W5vcaeitnsu6OMgu/veWn+s/ffkuIU9dGlHhpwPNQ2nA/IlUmr23O/xwH H7ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752686901; x=1753291701; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jvMqfwhNEUaAbyBTg3ZU/8Yl+gwZdDpyb6yyXj/6hXQ=; b=ZTMOi/q0/YOXD4DT4vc2+rqK6kUy4Fyd5Mr/efmVWjtWZA0OhOok45m5OsQan+dqIk GBtjZJdgbA58noDR0RPCDKmXv/eiOunhKGGsYXDlAuIptmkX+/2aJszsZbPAu2NgiuiC 3jQorpHVL2BQVyfPeX5BvxFa4fOXbXCpSWPN7oYxdrMOCbg8rx8tEmR634MzPTCt9uAT zavctNQx4nmz69bkIcVaHxNI8AE+75akgJc1qtvkdX2PVSWSvLmFO2U4RA9jIN/ah7y7 ADC6M6sGhsqm7/u45/hDzn6t5sCkR8qPJluKHT+j0TuJHlQDXwG0I5mH6EhTnh1RYJfc JRWQ== X-Gm-Message-State: AOJu0YwI4r7BUY6UObWaF5o+ocSOA5CnrH2+yxDlrHjkAu1mb+Xcr6DZ pb2r0hPyAG6q2MSbVbi/ys6N4PjU6QJf9n9MagxldKh9uZo9zqX/kH82BRJZNqZDPkrhZ2CijGX q4E7u4dk= X-Gm-Gg: ASbGncuRvgjCAG+It1SsEuPmiEWfd9uW8I3Uqp4CpAy+XLvIWfgx0IkRs2czWomMgFr T1reUsrqyNjzDHBWgPkPczdCggK7D/YoOvmaAiqTFLbo68cE+wHiwmRfNTe9yxVRW0n0C7a/4Vq ovJKAMNuw5j877LKfYfy5ghXxHczYoHm4fAbcB5NqxXx3jjOMW2KPD5280tGgxZykauaNcAr/GT H7BzoVd/KKKbV7SwdOSAXAvpvLYimVjiouQYAesyFTXnaVIoPKoAATrE+deWy5duczlxUAFNBCC SREwKligzflhWwCRHYAQfB77ZdUNznKagvZGE3w9zNnwkwRFSXyCKm/h7RaBuGOArqwHAO+3GMx KLtfx8SKcuI8UtlCh7xbHTxImpan/Xm8IB7QqA85kA/PEd+4LfLqNJnMzuT2+jRHa1Blr7DZWKg kZcqT5PAk= X-Google-Smtp-Source: AGHT+IEySn6a4TwkwiHvZsCcDGfvrS+Pq05mAv5J6DwrLCGyKDFZtWtTqsOikgNI0LL+aO8PTZe12g== X-Received: by 2002:a05:6000:43c8:b0:3a6:ec1b:5742 with SMTP id ffacd0b85a97d-3b60dd4f78amr2806114f8f.22.1752686901040; Wed, 16 Jul 2025 10:28:21 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Cameron Esfahani , Peter Maydell , qemu-arm@nongnu.org, Roman Bolshakov , Mads Ynddal , Phil Dennis-Jordan , Alexander Graf , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [PATCH-for-10.1 1/3] accel/hvf: Display executable bit as 'X' Date: Wed, 16 Jul 2025 19:28:11 +0200 Message-ID: <20250716172813.73405-2-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250716172813.73405-1-philmd@linaro.org> References: <20250716172813.73405-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=philmd@linaro.org; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1752686965257116600 Developers are custom to read RWX, not RWE. Replace E -> X. Reported-by: Alex Benn=C3=A9e Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alex Benn=C3=A9e Reviewed-by: Mads Ynddal Reviewed-by: Xiaoyao Li --- accel/hvf/hvf-all.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/hvf/hvf-all.c b/accel/hvf/hvf-all.c index e67a8105a66..0a4b498e836 100644 --- a/accel/hvf/hvf-all.c +++ b/accel/hvf/hvf-all.c @@ -84,7 +84,7 @@ static int do_hvf_set_memory(hvf_slot *slot, hv_memory_fl= ags_t flags) trace_hvf_vm_map(slot->start, slot->size, slot->mem, flags, flags & HV_MEMORY_READ ? 'R' : '-', flags & HV_MEMORY_WRITE ? 'W' : '-', - flags & HV_MEMORY_EXEC ? 'E' : '-'); + flags & HV_MEMORY_EXEC ? 'X' : '-'); ret =3D hv_vm_map(slot->mem, slot->start, slot->size, flags); assert_hvf_ok(ret); return 0; --=20 2.49.0 From nobody Sat Nov 15 08:50:45 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1752686978; cv=none; d=zohomail.com; s=zohoarc; b=KS0mCiRFbDFmfMs0YBOoIMAvnFmw30HjT3BZ/Vsjfqx84IQLG76I9IpavWSxSOgV37xpySC62/e597uGfAhpgM4BIRqZsFg9e/pzViV0JdwwU6lyZoZDgBBCKCmQMMStUBIw8R4IphzZVOcFhWJSFsT79Bf965hX81YuypD97Z8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752686978; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ps+e7ssT12p6go031p/X+dV+am0FTNx9EebSq8FDbrI=; b=MDc1+Vw8k682QLm3+Sfn8EaoSz4kpnQtzJQcFaXxutQg2b23D5mNa2u57hiVv57FTnys5ymGvQqgUuGpnOHrRf8Od/SbymYnNQobo/bcWlp8mW6qawcpuDBSYpcahwQhs5WNzrlO74qh4XXtKnywDyq82OVglonOOz2Bp97zG84= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752686978414962.0346791427528; Wed, 16 Jul 2025 10:29:38 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uc5vk-0001oy-Iq; Wed, 16 Jul 2025 13:28:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uc5vj-0001mV-2J for qemu-devel@nongnu.org; Wed, 16 Jul 2025 13:28:31 -0400 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uc5vg-00009c-FL for qemu-devel@nongnu.org; Wed, 16 Jul 2025 13:28:30 -0400 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-3a536ecbf6fso64122f8f.2 for ; Wed, 16 Jul 2025 10:28:28 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8e0dc3esm18308292f8f.47.2025.07.16.10.28.25 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 16 Jul 2025 10:28:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1752686907; x=1753291707; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ps+e7ssT12p6go031p/X+dV+am0FTNx9EebSq8FDbrI=; b=N6FXTTWLGG5YeXXELOO74tYoCVMA73dSGsfZj1p7L20KemmByQfU5K0EKr0Hdeoioh caiG9+OoaPH3VvIg51YL82IONQ8Q3Wt9KlCKbpT00bwhNjgdaJ0UPPvTfwXrL9zSBEju +6NupagxzwT1LhQma16ITh8oZ0LfslHYphgE6t24TmSu0nADJSAuPUesjL38vV3lHIba vyJHtfevqfAtwlmCRsrqf0XqxEVtJz5SopF/qykDzICYrK7UDgSnM2pDMMC2dP4BE6Cc jkl3xlXNcc7Frriot4m58QNheJK7FdfO+i74383MdchdZz3B2D4BPss1wxVd8u8gcWiO T62w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752686907; x=1753291707; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ps+e7ssT12p6go031p/X+dV+am0FTNx9EebSq8FDbrI=; b=MgfaDTz87hFnGaYoGhKJ+7waONlTiCh8/qv/uY4GfcbSa3UNjIpoP1WartQn3viQJA LYgiRSLRgw5zGDzJLLYwsxCBLgNEdSC7w+6iTf/MmwIaBlrJUb8AalofghDkxOUZF2s/ Wc84YDH0j7htMWb4UtUY3AmKZ8s2SmvOWZooUCXU4W4iNPHiMHcNqtY4w/KSaaOZ+Dr5 R2iMpfe5LqEJGQX3W+1Nim6bp8zStgPnk31O2pyc1OZtGRwz3NLoeq/iNOcyD9/Z/7dU zhCAqn3qEWOE6XfrB6ZhY5ZvknJE7zL1mPJ6dhYGS0I1Sz8eYUjB70eBnMRtVAg7OmiY cWXw== X-Gm-Message-State: AOJu0YzjE2wYCX1diy0cyakEH0lUj010TOLqVfC4iaf9Ij0IMDEv6SoW ai70yKan6VCDzDUZZRuwSVpl4hETV8qN7nJndBRHrkV9/9KbTlYoi9sgE4TdXF5YbAuDS5v4p2l wU7by7Mo= X-Gm-Gg: ASbGnctwncme3UzcCRmaPqT8wBz7t9scBT4RvJhRbna++IC12MVftjUhDcQcyUxoWhX sVqe3DjglrUMJ2uFv/Qh61WOpzMyPygufkJOfuh4SS0GoY9k2Co4pbrS3sTcw2UwpJCyjKCXsZy ziogMR9gs9FscVmASMvs37MHgwn3y2BH0iU/aSF7wnusxXpDi1OCRal3NMj6z7PKfYfBueAevUI 64kp7H2C79tYAxlLyXt0J+50yxD8jBNWk+IJzR/LgFh7oYNLWgGNYvA4AvGhRfxpx75l4Yhqho3 dYcqfhF4rI7gn27ikHSRELN8O/LYh58JqXjqEoLjQO/LaJ8sDvivsprQ9EsKDxP89+dofDjSNuf j7HRGeM3mYnmBUGUCDOEHdX0eMPxhQG3R8u3C2MNnhqNz76zucv+0FGWMabqoXUuNJl6OofA3 X-Google-Smtp-Source: AGHT+IFte4bkpthavf7WGnbTSeu2PaFexmWzi13urEVA104uU+T2KnJRvcGU4bDaP/sF9cM3LdR4yQ== X-Received: by 2002:a05:6000:12cf:b0:3a5:3b14:1ba3 with SMTP id ffacd0b85a97d-3b60dd89a00mr2708265f8f.49.1752686906526; Wed, 16 Jul 2025 10:28:26 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Cameron Esfahani , Peter Maydell , qemu-arm@nongnu.org, Roman Bolshakov , Mads Ynddal , Phil Dennis-Jordan , Alexander Graf , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH-for-10.1 2/3] accel/hvf: Do not abort in hvf_arm_get_*_ipa_bit_size() Date: Wed, 16 Jul 2025 19:28:12 +0200 Message-ID: <20250716172813.73405-3-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250716172813.73405-1-philmd@linaro.org> References: <20250716172813.73405-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=philmd@linaro.org; helo=mail-wr1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1752686979929116600 Do not abort in hvf_arm_get_default_ipa_bit_size() and hvf_arm_get_max_ipa_bit_size() when the IPA can not be fetched. Return 0 (and document it). Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/arm/hvf_arm.h | 11 +++++++++++ target/arm/hvf/hvf.c | 8 ++------ 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/target/arm/hvf_arm.h b/target/arm/hvf_arm.h index ea82f2691df..21a69e7d105 100644 --- a/target/arm/hvf_arm.h +++ b/target/arm/hvf_arm.h @@ -22,7 +22,18 @@ void hvf_arm_init_debug(void); =20 void hvf_arm_set_cpu_features_from_host(ARMCPU *cpu); =20 +/** + * hvf_arm_get_default_ipa_bit_size: + * + * Returns the default intermediate physical address bit length or 0 on er= ror. + */ uint32_t hvf_arm_get_default_ipa_bit_size(void); + +/** + * hvf_arm_get_max_ipa_bit_size: + * + * Returns the maximum intermediate physical address bit length or 0 on er= ror. + */ uint32_t hvf_arm_get_max_ipa_bit_size(void); =20 #endif diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index c9cfcdc08bb..180fd94def2 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -943,24 +943,20 @@ uint32_t hvf_arm_get_default_ipa_bit_size(void) { uint32_t default_ipa_size; hv_return_t ret =3D hv_vm_config_get_default_ipa_size(&default_ipa_siz= e); - assert_hvf_ok(ret); - - return default_ipa_size; + return ret =3D=3D HV_SUCCESS ? default_ipa_size : 0; } =20 uint32_t hvf_arm_get_max_ipa_bit_size(void) { uint32_t max_ipa_size; hv_return_t ret =3D hv_vm_config_get_max_ipa_size(&max_ipa_size); - assert_hvf_ok(ret); - /* * We clamp any IPA size we want to back the VM with to a valid PARange * value so the guest doesn't try and map memory outside of the valid = range. * This logic just clamps the passed in IPA bit size to the first valid * PARange value <=3D to it. */ - return round_down_to_parange_bit_size(max_ipa_size); + return ret =3D=3D HV_SUCCESS ? round_down_to_parange_bit_size(max_ipa_= size) : 0; } =20 void hvf_arm_set_cpu_features_from_host(ARMCPU *cpu) --=20 2.49.0 From nobody Sat Nov 15 08:50:45 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1752686961; cv=none; d=zohomail.com; s=zohoarc; b=nnvGoakea5RplWujG/stUnqz5YxYKA085Rkj43gBQKGah7ic0iSZtRYjfNNtzMUvdLI4lNVX3JSdkJV3EK5Xe49Hdf4F4BcN9y65GCO8UE+y2Ww2LhGgvbzetxLt0tLyogTlCNrUJE/Fo7gMTb52AMA6arOrsvJA/DrpxX/VK9w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752686961; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=tWQe0nwaHjFSPbzauTR/fxg60n5AbbyVfV/ixwGD2ZA=; b=M1xM3t0GIeA82Fj2ascoaRrmdiukaCK6kZj5XidLpt4f3xjorLCjTFBjzwL5H1VL9cwUT5utU9hHEnF6YpXVg89SDCSc/oM8vqMMcC7s7rf6AebMW1iwcpGq6C+h76egQcegr/5nwFAzfIiMQedh4DQ0O396/uLRd9N0wL1vbxM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752686961740284.39976756492524; Wed, 16 Jul 2025 10:29:21 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uc5vt-00020m-9H; Wed, 16 Jul 2025 13:28:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uc5vo-0001uc-5I for qemu-devel@nongnu.org; Wed, 16 Jul 2025 13:28:36 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uc5vl-0000Br-DK for qemu-devel@nongnu.org; Wed, 16 Jul 2025 13:28:35 -0400 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-4561514c7f0so881035e9.0 for ; Wed, 16 Jul 2025 10:28:33 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4562e83c712sm26892265e9.33.2025.07.16.10.28.30 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 16 Jul 2025 10:28:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1752686911; x=1753291711; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tWQe0nwaHjFSPbzauTR/fxg60n5AbbyVfV/ixwGD2ZA=; b=joR7FKTo8VLlQrV//2eA0+ep+sNdHtOZvnZbJxl0kl4tFQ65bdsQwYNa75qZr4kyrD GoySaN+P21wck7cPBGDQrgNvOUeIp2lF19or2HRnTh07I6cPp44vcmWkpLBQVSfA3NBO YIVb5/ALUGrvuS3P6nxYS3u2kqSuCcIkEBAgnL6ROvzQvxhHBAZHYCq+GkgKulVoSoFi XZzc4xFk91Jgiesn9oOh3koQy/dhXPfbxTVcBCd9UWsIzQoKgy6h7E/x96XSp6sAq76X inrNUFLUNFnTZq2mY/bC4TaaFVRDceTL70R90NurYRtgGpkOaH1T7lwv2wVCLgOoojd1 u1rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752686911; x=1753291711; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tWQe0nwaHjFSPbzauTR/fxg60n5AbbyVfV/ixwGD2ZA=; b=CJ4sbmPqCainzt1QNDmqXJlOxoownkxGO2UQohGyLZ3MuHzhw2Qh+MgrnnDDbYSAcN KcvFzKEBaZ8QOhB2sF9/mCDftNb/CPhxHQUbtmH4IQBwtYYO4yf+ZSbdZWXbQIEkfRsB 9BsTC+apC/xV2sLDTsHwkBXy1RqDWEK+vESA8ka40I5RyyXHIualORwISAky0kN4Rrf8 g5GLCKVJuqmQVf8alTv4JfOETlq6SYMUBGi+GV7Vo6jHVyrDZCU5NHjIpUZX8cQLjWSA hyKGUhF7/JgZ7yyiR3f35uBZXLe+Ioq2d6r+JMEwZC8QpAgAH4UWvgeDVdYWtoABOj8p AgHg== X-Gm-Message-State: AOJu0YyoTaJBg/j4YBks7VDzBmv9h30Kw8FcmEdcgw13nhFM8oV/xiS6 nIQNlnZrtE7qzKhR7AxmrjPsnoVi3rcs5rhUE/jcB13wITZc0UI0q+SBcuBBZv/7yQ1ZfM7SjaV YNsBbMns= X-Gm-Gg: ASbGncvy1gMCTNEPt0ojmhq/njJpEabt6voYzWJMnbKMqeOoYVGp889eMcNn5xXrtIz MufUXOOBapsMIpBncg5J5d8OZhwicLe4S6nckSFLgHs/ak52h2DMKOEk6d2PUkAMtgJ6PS51WJI xJXOJCXpkr8DINhQeWhSlHtEB9U4bS8U7We21rKSyr/W9thT4zZCleN8L/LgvKZnNVGnlbf72i+ 3TwWmIwkfq2EfCyO8dQMXH3G7BVNAXQtvXNQfRe0bfpExC+yZbjUK9I81IbVhdbJVg3vpKRjmNm Nm988CB4aggxlVuaprQZY4au1yPkRgiedEamChEE7gALHqJ8axqV4YnFV5ePZ9mJcELk28drUOm +IqRn2lQ1NRg2MLsV1c7JP+n9LAe7VMc9A1weHIdM/r0/W0SNCnw9GEPEynBnGTmE0mlM4DAb X-Google-Smtp-Source: AGHT+IEjy5mT+VlMmimH2ItxJttWj0qTFpf6nuSVx7+W3QydPRBGRLmZ/xijNFByXbddHOJj4wQBww== X-Received: by 2002:a05:600c:3496:b0:456:1b8b:b8c6 with SMTP id 5b1f17b1804b1-4562edaa066mr35328655e9.14.1752686911508; Wed, 16 Jul 2025 10:28:31 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Cameron Esfahani , Peter Maydell , qemu-arm@nongnu.org, Roman Bolshakov , Mads Ynddal , Phil Dennis-Jordan , Alexander Graf , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH-for-10.1 3/3] hw/arm/virt: Warn when HVF doesn't report IPA bit length Date: Wed, 16 Jul 2025 19:28:13 +0200 Message-ID: <20250716172813.73405-4-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250716172813.73405-1-philmd@linaro.org> References: <20250716172813.73405-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=philmd@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1752686963830116600 Emit a warning when HVF doesn't return the IPA bit length and return -1 as "this accelerator is not usable", allowing QEMU to try with the next one (when using '-accel hvf:tcg'). Reported-by: Ivan Krasilnikov Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2981 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Mads Ynddal --- hw/arm/virt.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index ef6be3660f5..062812bf252 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -3149,8 +3149,12 @@ static int virt_hvf_get_physical_address_range(Machi= neState *ms) { VirtMachineState *vms =3D VIRT_MACHINE(ms); =20 - int default_ipa_size =3D hvf_arm_get_default_ipa_bit_size(); - int max_ipa_size =3D hvf_arm_get_max_ipa_bit_size(); + uint32_t default_ipa_size =3D hvf_arm_get_default_ipa_bit_size(); + uint32_t max_ipa_size =3D hvf_arm_get_max_ipa_bit_size(); + if (!default_ipa_size || !max_ipa_size) { + warn_report("HVF didn't report IPA bit length"); + return -1; + } =20 /* We freeze the memory map to compute the highest gpa */ virt_set_memmap(vms, max_ipa_size); --=20 2.49.0