From nobody Sat Nov 15 10:22:14 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1752625650; cv=none; d=zohomail.com; s=zohoarc; b=XDy1SVISDGeYlkUyBu9PB3NlNw2zIHf6364jtf9SBk1bGYRB/lPpolSDRArwwTLDRoFTGyl2/gphDxOgRGDX5qi4q31ed4cFdJqCOapHiyyBU6bq1kEtAYbUw2no6eyIh8/e0i4vqxlO+pJ5PVjibRBhNPEXeHRWIZgsDod0VvE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752625650; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=oxgqE0WCspBFRJxj7t9XnY9yStgxjGadVomj2GNaNB0=; b=gpiEERT97yOHnwCFP3K7Tx9XrqQXmfnV/LzlzccRnAlK7qy9VUEBPGwe0M7reJNhGikY6wGE4FYL3EbNl1ur2i11jXpEaCk5sHyf+989vuoTJJVkAahf1HQDu7McHz6HONtCh4xpCNYvH2Ktn6NmE39pbiArNlzKEP+cJaILkDg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752625650598983.4322840702376; Tue, 15 Jul 2025 17:27:30 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ubpyf-0005W1-Kd; Tue, 15 Jul 2025 20:26:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ubpyd-0005T1-Iv for qemu-devel@nongnu.org; Tue, 15 Jul 2025 20:26:27 -0400 Received: from mail-qk1-x72e.google.com ([2607:f8b0:4864:20::72e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ubpyb-0002YW-S8 for qemu-devel@nongnu.org; Tue, 15 Jul 2025 20:26:27 -0400 Received: by mail-qk1-x72e.google.com with SMTP id af79cd13be357-7e0d65a87e8so329588485a.0 for ; Tue, 15 Jul 2025 17:26:25 -0700 (PDT) Received: from user-jcksn.mynetworksettings.com ([2600:4040:b51a:4200:cc77:a278:6e60:d8ba]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e1861fe700sm382830285a.99.2025.07.15.17.26.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jul 2025 17:26:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752625584; x=1753230384; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=oxgqE0WCspBFRJxj7t9XnY9yStgxjGadVomj2GNaNB0=; b=Rc4l7zC4fZt40jrp8aUpETCSLEMrIoJvihMWpsPmuz4dUnDg1lapcEJD2UK13fyPmu Y6vqMwWWPpoy8+DDU5n2XGMQBd2nsOFsbsI3acj1EAA8Z68bK82G5pu2ykxA/dtqc+au qbAE1YLamo98cD4i3SbweC2rOHNche+dvo/v2PeEHtP3Y5sQzI3lKdQYuZDKLy158Sxn +mtZytGNQ9dNsqLyy8loDeyc5esNXst4GaRyyVSb59j3n3zb2Ha1pCpHkXDg4OWENfWc IoQZioUR8kTnjZiuZA5fdiQF7EkB8Wmn27sXRUOJ5GcLplQh1HxZwNMblcnpoqbtj2yw jSTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752625584; x=1753230384; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oxgqE0WCspBFRJxj7t9XnY9yStgxjGadVomj2GNaNB0=; b=fnfp5HH01b31fLTxvrQGDY49SbMvQ+NVmvx5AE1kVFDzpGYchm6YAgDRlq8uDY0e3H ct9gE2scJXx9nJLacIi2CN3Ri7UCPHGRy/AsFXzZiv3NGr6mZeij4O+nDyYzSG3Hzakw fXVR9Aqf96JrMIYQ9+KR/8DJqPy5p217BBZ69QzC3h5YLgoIqJTffFFFuUvK6/c+7eFL iXHJFc+1whiQSspDOn8H7zVHivyZxWcthQ1DYMkOPqRQSGs5X0H71QNgqDJlZZL/ChxC Y3GalesiPMBInGbB+hnXLOaAKnWuvzP6jO5d6AdOCB+1fym/X1fyJ4NltREz/mkA3Aig ltXw== X-Gm-Message-State: AOJu0Ywfxfe5YBksxeoipjeyvWcocnaNJDcHAC22wOH4jz95FYm6UEa6 b4TyXiq6jKB6W2xJ37z+/e8E6PMOX8wq0AhRV4lswdUcNzgwi18bF4ZBHDmQEA== X-Gm-Gg: ASbGncuWMPlQxbL8X9RdkPi1Ge8lj+jJT2UbJ4aSbnP+b9eyw53ObaWBJKlJysLc/jm RD0EI37cjYbRHlkQNq1ZpM8cN5QFODI+hDBvDHYBGJ0zzd534rzkiSqsRH76uczJ3AIU0q6cYG7 203QiDARSlJLLq+DiNQq3tEmNEjcoTxtERqwrWDFGVLpdLaZVry7dNhoDoM7o9Hompr5w8Ffy1O dlM0d4I1Zge/9c8Ftmps8rMuPPD2OVfgFynVqqOjmMbOzSYg5IHyQtUZ573ucbHWLK8dGuF0ec9 ifwoqdmottI7BTCjdPsE6Dz7Q4HcpKqIklbtfb9Czm20TZBCgLGFk781VwcClbS4jfClSJXSDCY nfAH/hTGNphA2dYAXtSoC9+xOWSbXvXgZoYjA//HVonqitDQ= X-Google-Smtp-Source: AGHT+IHq2EczeakNZa0HOtcvAg3bxjhAtvPq9eIyHkBLZSCfR3PBewVFqaGEkTYjzQqVrSc56VPumw== X-Received: by 2002:a05:620a:4445:b0:7d3:c4c7:75d6 with SMTP id af79cd13be357-7e342b6838dmr193955785a.47.1752625583800; Tue, 15 Jul 2025 17:26:23 -0700 (PDT) From: Jackson Donaldson X-Google-Original-From: Jackson Donaldson To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org Subject: [PATCH] hw/misc/max78000_aes: Comment Internal Key Storage Date: Tue, 15 Jul 2025 20:26:22 -0400 Message-Id: <20250716002622.84685-1-jcksn@duck.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::72e; envelope-from=jackson88044@gmail.com; helo=mail-qk1-x72e.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1752625653071116600 Content-Type: text/plain; charset="utf-8" Coverity Scan noted an unusual pattern in the MAX78000 aes device, with duplicated calls to set_decrypt. This commit adds a comment noting why the implementation is correct. Signed-off-by: Jackson Donaldson --- hw/misc/max78000_aes.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/hw/misc/max78000_aes.c b/hw/misc/max78000_aes.c index 0bfb2f02b5..d883ddd2b6 100644 --- a/hw/misc/max78000_aes.c +++ b/hw/misc/max78000_aes.c @@ -79,6 +79,12 @@ static void max78000_aes_do_crypto(Max78000AesState *s) keydata +=3D 8; } =20 + /* + * The MAX78000 AES engine stores an internal key, which it uses only + * for decryption. This results in the slighly odd looking pairs of + * set_encrypt and set_decrypt calls below; s->internal_key is + * being stored for later use in both cases. + */ AES_KEY key; if ((s->ctrl & TYPE) =3D=3D 0) { AES_set_encrypt_key(keydata, keylen, &key); --=20 2.34.1