From nobody Sat Nov 15 12:49:57 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1752512679; cv=none; d=zohomail.com; s=zohoarc; b=TmF3oEK9DltMZRQ6kwxRG4eNYDC+mdwdFT0PUzt1UfCnuUUtnTRP6N00GElL37GC6TQQgrDzTXKWughUd2NAs9HHmpX150dxfzNgf3MYibgPQHCBo7h4K0W0dWjLIy9NXN9ZbHcFh1wZfkh7/hAhqlKzu5xsMRUOImzBoOCJBl4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752512679; h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=bWqpl7PIm7rv+bAdDcNYrQYUADOLMGGpJ4naslblg9U=; b=jILh8emdQc5l8BkG5ImxEFGRyVjZsx3pS2nhnh0OSMrWqTkfkw4aYIlhwWRIB9GOa4DlkD4PRISd+MnzQESXaphwKQElhqSg8v0xYgMUZZGQ9eApbwUtFBBQPakR4j7wjYj3nVwGT5B+V8f0CHApdMLGi4GUGJV9UCD0O/sijgs= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752512679182399.12745577547605; Mon, 14 Jul 2025 10:04:39 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ubMVQ-0007it-33; Mon, 14 Jul 2025 12:58:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ubLcJ-0005O5-8M; Mon, 14 Jul 2025 12:01:32 -0400 Received: from [185.176.79.56] (helo=frasgout.his.huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ubLcH-0008KT-HV; Mon, 14 Jul 2025 12:01:23 -0400 Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4bgn5q1rc0z6L5M0; Mon, 14 Jul 2025 23:57:51 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 9454C140142; Tue, 15 Jul 2025 00:01:18 +0800 (CST) Received: from A2303104131.china.huawei.com (10.203.177.241) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 14 Jul 2025 18:01:09 +0200 To: , CC: , , , , , , , , , , , , , , , Subject: [RFC PATCH v3 07/15] hw/arm/smmuv3: Implement get_viommu_cap() callback Date: Mon, 14 Jul 2025 16:59:33 +0100 Message-ID: <20250714155941.22176-8-shameerali.kolothum.thodi@huawei.com> X-Mailer: git-send-email 2.12.0.windows.1 In-Reply-To: <20250714155941.22176-1-shameerali.kolothum.thodi@huawei.com> References: <20250714155941.22176-1-shameerali.kolothum.thodi@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.203.177.241] X-ClientProxiedBy: kwepems500002.china.huawei.com (7.221.188.17) To frapeml500008.china.huawei.com (7.182.85.71) X-Host-Lookup-Failed: Reverse DNS lookup failed for 185.176.79.56 (deferred) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=185.176.79.56; envelope-from=shameerali.kolothum.thodi@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Shameer Kolothum From: Shameer Kolothum via Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1752512680269116600 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" For accelerated SMMUv3, we need nested parent domain creation. Add the callback support so that VFIO can create a nested parent. Since 'accel=3Don' for SMMUv3 requires the guest SMMUv3 to be configured in Stage 1 mode, ensure that the 'stage' property is explicitly set to Stage 1. Signed-off-by: Shameer Kolothum Reviewed-by: Nicolin Chen --- hw/arm/smmuv3-accel.c | 15 +++++++++++++++ hw/arm/virt.c | 12 ++++++++++++ 2 files changed, 27 insertions(+) diff --git a/hw/arm/smmuv3-accel.c b/hw/arm/smmuv3-accel.c index 0b0ddb03e2..66cd4f5ece 100644 --- a/hw/arm/smmuv3-accel.c +++ b/hw/arm/smmuv3-accel.c @@ -10,6 +10,7 @@ #include "qemu/error-report.h" =20 #include "hw/arm/smmuv3.h" +#include "hw/iommu.h" #include "hw/pci/pci_bridge.h" #include "hw/pci-host/gpex.h" #include "hw/vfio/pci.h" @@ -81,8 +82,22 @@ static AddressSpace *smmuv3_accel_find_add_as(PCIBus *bu= s, void *opaque, } } =20 +static uint64_t smmuv3_accel_get_viommu_cap(void *opaque) +{ + /* + * Accelerated smmuv3 support only allowes Guest S1 + * configuration. Hence report VIOMMU_CAP_STAGE1 + * so that VFIO can create nested parent domain. + * The real nested support should be reported from host + * SMMUv3 and if it doesn't, the nested parent allocation + * will fail anyway. + */ + return VIOMMU_CAP_STAGE1; +} + static const PCIIOMMUOps smmuv3_accel_ops =3D { .get_address_space =3D smmuv3_accel_find_add_as, + .get_viommu_cap =3D smmuv3_accel_get_viommu_cap, }; =20 void smmuv3_accel_init(SMMUv3State *s) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 22393cf39e..fdb47eda6a 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -3053,6 +3053,18 @@ static void virt_machine_device_plug_cb(HotplugHandl= er *hotplug_dev, return; } =20 + if (object_property_get_bool(OBJECT(dev), "accel", &error_abor= t)) { + char *stage; + + stage =3D object_property_get_str(OBJECT(dev), "stage", + &error_fatal); + if (*stage && strcmp("1", stage)) { + error_setg(errp, "Only stage1 is supported for SMMUV3 = with " + "accel=3Don"); + return; + } + } + create_smmuv3_dev_dtb(vms, dev, bus); } } --=20 2.34.1